From nobody Sat Oct 11 12:14:58 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1419A2BCF54; Tue, 10 Jun 2025 14:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749565112; cv=none; b=BxDsgmh3wxSFSyH+J+fRNf2+aQ+T8u2HEZnUlZ1ZvQUDaUr/quwKsQSEJ/bY8eKwO6388nZ6htwUtlGC309pt4EswuPeM63UAhSsSNJFnNcDRhvbWA5O9YtYNLQXWx0cX5loXk3gLRZHMGRfvvYBWBEk3G9KhmzShrxUuyqKI2g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749565112; c=relaxed/simple; bh=LlxLG4ZmmZ05HdJBKIcojJYmWyB7mryqIF9FNdb8jNw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kIHoaZQ3aXCQPpPifC70ESqJLC3TSa75L8KVls09NdzzMFaorsS3Sm+SbFbGqyuuPAPaldZ4YOY/yhw9kWRcydehoktqfgKb1QqD+tz7U1FOdKAIdpEzHNfgPW9owfredK0ksY0c0VUqXXI71pgraP1/zkatJxL5xrl0TFUeBbk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H5ZSBf+I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H5ZSBf+I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9719EC4CEF1; Tue, 10 Jun 2025 14:18:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749565111; bh=LlxLG4ZmmZ05HdJBKIcojJYmWyB7mryqIF9FNdb8jNw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=H5ZSBf+IHIiba142GJw/+yoyKqx4hrCFhGipnZ8suNhcn8mlbu53XL9b2MPeBzD3V UJ+qIPb6ZobgSaE57ezAciyy2bYcwpDF2uU09buGRbuXXTvkfB4mijYDOi5HGK6Dmc ilPEjdiF2pCSqBEscgJKFE5OSXFuu2C7pEuQzjFa+l9dNPVcsIG4jzw2/rZyG/qX3Y K78Ij/zSTdyjnKMwKa8tK2NqMhyubYzhbsMbQJKS5vplo8aqBfpJKw80jM6qd2O5kW TPfq2kBSV1LbceWX9XH5XkNaQiDbEuyegscFt8fbaS5GGnH62JsYh3aDyDtCSN6j37 n4qucaNonj8Mg== From: Mark Brown Date: Tue, 10 Jun 2025 15:13:54 +0100 Subject: [PATCH 1/4] kselftest/mm: Clarify errors for pipe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250610-selftest-mm-cow-tweaks-v1-1-43cd7457500f@kernel.org> References: <20250610-selftest-mm-cow-tweaks-v1-0-43cd7457500f@kernel.org> In-Reply-To: <20250610-selftest-mm-cow-tweaks-v1-0-43cd7457500f@kernel.org> To: Andrew Morton , Shuah Khan , David Hildenbrand Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=941; i=broonie@kernel.org; h=from:subject:message-id; bh=LlxLG4ZmmZ05HdJBKIcojJYmWyB7mryqIF9FNdb8jNw=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBoSD6x1SHgu0Mj8blcBIhqQTzo7nMRr5o1bjePcJ5J z8Lr5SaJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaEg+sQAKCRAk1otyXVSH0EzUB/ 9s7iTIMDN3f4KsC67LoFg7m1MlUCCN6vtcljxtnkG3oEB4ElCHW6rYrPy+BNaQ+A2r33rauIciusf0 8hDAw1Dc7s26BaKqakVRB4yQzdykb5FDUcwNFO2NbL0jAQO2HQdhpIdYNIcGiIlg81LIvH32pnbnnk eI784P1B2DqQJVoaynWIGy6Lgdb8CakHy0iTfHV4x6NA2Zjv85i979hku0oR1uMD9oxnwAlCdtXH/t W5bYOhpYkbffWOYX6nFdQr9VPVf1Sz/Qv6BG+hRvUTbCmO2WWPPnaZd5Cv7fRd8AMkTXgRAgfAxmxo DCjDhcBfuX0LXwi8ePXqSbUnOCHDha X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Specify that errors reported from pipe() failures are the result of failures. Suggested-by: David Hildenbrand Signed-off-by: Mark Brown Acked-by: David Hildenbrand --- tools/testing/selftests/mm/cow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/= cow.c index dbbcc5eb3dce..0adc0ab142c1 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -113,11 +113,11 @@ struct comm_pipes { static int setup_comm_pipes(struct comm_pipes *comm_pipes) { if (pipe(comm_pipes->child_ready) < 0) { - ksft_perror("pipe()"); + ksft_perror("pipe() failed"); return -errno; } if (pipe(comm_pipes->parent_ready) < 0) { - ksft_perror("pipe()"); + ksft_perror("pipe() failed"); close(comm_pipes->child_ready[0]); close(comm_pipes->child_ready[1]); return -errno; --=20 2.39.5 From nobody Sat Oct 11 12:14:58 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10BB329B214; Tue, 10 Jun 2025 14:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749565114; cv=none; b=EJsDqKn+YFmVR2K0F4EJoix1s+EVLqv/MSsajA5Sa43IEUh6hyJfHvosLO2JN3dqPH/RaDIj0KWa8cvjXWegiwx1R3MPs/coG47R7OkW0K7LCmWs3HTsRIJLrJWJkGJ7zVsW991ymtfVZkUkOWEzWIRkrCtY9k/s00zPIxuEUrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749565114; c=relaxed/simple; bh=+8K7IHPM2fvcDtNu46rok2dhi80R6Thr3mEpDEugxAg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C0AKtJeCxQ2NFLM+U3leYdbBblOOxQ64RhYwntKyXeQ1buAD1LWzV36I2E12/aG7ITkYBBcsWeMRFbFeOGVBVPbgDDFJJqR9na/+TK39sXFQFQnCsCBY67ltBE3ThcltiTC5djrQ8qsy7vaoHh95RTVQvSilOmTNUuO7nKWT+lQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FCdqnfFA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FCdqnfFA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B831C4CEF1; Tue, 10 Jun 2025 14:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749565113; bh=+8K7IHPM2fvcDtNu46rok2dhi80R6Thr3mEpDEugxAg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=FCdqnfFAUl4A99tXQMEDoFQqQcOvFS37YTuPwHgEMxcSPHDMdFUmZF72YGIUA21x/ zxdBiV+15DDZPb6Xvoy6Bj5Sx2q/S084Ua10cC3xsGe+HznmB390bUh7sZpzDgcxOY Iu6DK3hWSgrEySXM/HpeEWVEdWDr5MOx0j5BNRWf4xcIwk7kSnP+CzbWArdCBJ2LKq kJBJn0zqYsXmBc+ZvM20kxdlAseOtSGWyXvnwssG4+c/WkJkKt2igKJVS820XrhZUX L2vhZuMTIJkSl96eMNQnXaBf82co4h54CohNs4SB4U1V7U+CpsOqa2z8FhUDI0Q1pT 4jFclgj/TQpng== From: Mark Brown Date: Tue, 10 Jun 2025 15:13:55 +0100 Subject: [PATCH 2/4] selftests/mm: Convert some cow error reports to ksft_perror() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250610-selftest-mm-cow-tweaks-v1-2-43cd7457500f@kernel.org> References: <20250610-selftest-mm-cow-tweaks-v1-0-43cd7457500f@kernel.org> In-Reply-To: <20250610-selftest-mm-cow-tweaks-v1-0-43cd7457500f@kernel.org> To: Andrew Morton , Shuah Khan , David Hildenbrand Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1392; i=broonie@kernel.org; h=from:subject:message-id; bh=+8K7IHPM2fvcDtNu46rok2dhi80R6Thr3mEpDEugxAg=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBoSD6yARNVcgIIAyMWNkKfVEgWVOv+rHJU+IwHQGaA c236rxGJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaEg+sgAKCRAk1otyXVSH0EO8B/ 4tIObYcoHExr8QY9lLg8h65TZOO5K4KTzeF5m1iMQdEH7OtmBkOlYTQtEeZ8Gx88pOR8uzSFC2uxUm HrOqjH9RZv7R4WNKP3wKmAG7ojauFv8vuuWDyv9i3UtwFQNWiRK9l/2WFGjuCT46bU0UKzyCddTcjo FImOnCwUgbo9jiwXCKeeqvR+NERpp1w8PH6EeyemJy4O7jopdebKr+02h5rDyMZKUraWsZd/8Iri/L kWaLx/Pu66Z2jt1Brruzcb4ok0YvvtWRLv1wAjZYayOA0eP7xaX3PK0wUw5wJ7ZscC8OtdHfMc/T1D zpAf2lurm+6njmmJjuXrrB6FybfoWC X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB This prints the errno and a string decode of it. Reported-by: David Hildenbrand Signed-off-by: Mark Brown Acked-by: David Hildenbrand --- tools/testing/selftests/mm/cow.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/= cow.c index 0adc0ab142c1..ff80329313e4 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -332,7 +332,7 @@ static void do_test_vmsplice_in_parent(char *mem, size_= t size, if (before_fork) { transferred =3D vmsplice(fds[1], &iov, 1, 0); if (transferred <=3D 0) { - ksft_print_msg("vmsplice() failed\n"); + ksft_perror("vmsplice() failed\n"); log_test_result(KSFT_FAIL); goto close_pipe; } @@ -562,7 +562,7 @@ static void do_test_iouring(char *mem, size_t size, boo= l use_fork) while (total < size) { cur =3D pread(fd, tmp + total, size - total, total); if (cur < 0) { - ksft_print_msg("pread() failed\n"); + ksft_perror("pread() failed\n"); log_test_result(KSFT_FAIL); goto quit_child; } @@ -628,7 +628,7 @@ static void do_test_ro_pin(char *mem, size_t size, enum= ro_pin_test test, =20 tmp =3D malloc(size); if (!tmp) { - ksft_print_msg("malloc() failed\n"); + ksft_perror("malloc() failed\n"); log_test_result(KSFT_FAIL); return; } --=20 2.39.5 From nobody Sat Oct 11 12:14:58 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92D892BFC7C; Tue, 10 Jun 2025 14:18:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749565115; cv=none; b=JI6dlC5sO7pCYWqpIgHnUzgECruSQ6kypodkOVDGdNQP8uhkLVjF3VWS3UzerMYUzJaJ+HbXCpVORHmi/JFDfH3mmu275Raa8TlOIUjRdnb/92dPYC6+Xew2Gbqc+5AQjMxRMmjvU2wxXOWKvxNw+ZHan4ZzFPa+6Cwnvo0pz18= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749565115; c=relaxed/simple; bh=7dkbBW+srIa9CP5zJ4/JMoZP4cQbiZRPdB3hd+GHPkU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rnSJJsSeUbZZ1Shn9TOsqS/zO9jgsCXTwhUfTF2fOWbl20+Q0tHRxpg7HIZJqZL/ktCyj2idew/Cr6mr+Zke1Jn2G4K4o1Rf3FjMiFrPKvkkUB2SjxyTOmHumRWa9eGBH3iBZZxoQ3K1UNaYtCaAdeydpWl6CkDARomHcaBQqU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gnkNCRbJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gnkNCRbJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CA3CC4CEED; Tue, 10 Jun 2025 14:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749565115; bh=7dkbBW+srIa9CP5zJ4/JMoZP4cQbiZRPdB3hd+GHPkU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=gnkNCRbJUuKZuZXJFnugSYIwcQwp81d5BJaWdworVxld21iSQFK+zCh63Qt6Dkg7u tVHy750rboTE1MzP2qVwb1VoyibWuesRgcSnLyDWQqZEXqGxe7f0gbg17WVtVdWUKL JKTJ3x8AJivJh6DvMBCZPxRXxUzkgG9ZgtIwNoz4xA6c0tTuMNeTNvjeufTfH+FnlG UTt0UInuLdU3b5gBReTqHth9IA4CNvGzKqwOM7/CCqdPgLRCciJKVVn26PjbBYMHe9 tAh9wcLIcM7QRt9i0FD17g+0DqA1qdj+oEtM5r2h/yXjI8T6a2tevwZFReld4g5IIw 7QcAwqUcFlzHg== From: Mark Brown Date: Tue, 10 Jun 2025 15:13:56 +0100 Subject: [PATCH 3/4] selftests/mm: Don't compare return values to in cow Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250610-selftest-mm-cow-tweaks-v1-3-43cd7457500f@kernel.org> References: <20250610-selftest-mm-cow-tweaks-v1-0-43cd7457500f@kernel.org> In-Reply-To: <20250610-selftest-mm-cow-tweaks-v1-0-43cd7457500f@kernel.org> To: Andrew Morton , Shuah Khan , David Hildenbrand Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1118; i=broonie@kernel.org; h=from:subject:message-id; bh=7dkbBW+srIa9CP5zJ4/JMoZP4cQbiZRPdB3hd+GHPkU=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBoSD6ze+vnhBcNS9iDQaq2sxtbsC/5EymYJENC6vV0 8/u/FSSJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaEg+swAKCRAk1otyXVSH0Do1B/ 9tYlYfTdop02ZdScX7Wk4Y2dnQT/W90nkm5eMhPgmQWxTukF+qZAIIIP6KmA5uD9D2fVDLEGqhudmz o5z45q0aW3mj5+g7QrBWTVr9kwLoAjF24OicMjwUnoZhPA2e5V0a6aBxSxcPaCPrlW92q9BGlYHSkO Dl4mzIyqfhdEFkUIFG1WHmeDTrzRbdZ6v1pRfAOS01rCP/xFMDi7fluEVL67pRDaV3Ja2u4WbYMMwO j7p/uGfuXfzb1xwRn4CcyVvIEYM4xLROeuiPqWBB3uyq22H+nGQ3UG16e1ozfV87FVaOhGXeSZLbj5 rrOGIyeIeyoZ3T0z+v9xIyYb7yQYfE X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Tweak the coding style for checking for non-zero return values. While we're at it also remove a now redundant oring of the madvise() return code. Suggested-by: David Hildenbrand Signed-off-by: Mark Brown Acked-by: David Hildenbrand --- tools/testing/selftests/mm/cow.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/= cow.c index ff80329313e4..48fcf03aa4cd 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -1613,13 +1613,13 @@ static void run_with_huge_zeropage(non_anon_test_fn= fn, const char *desc) smem =3D (char *)(((uintptr_t)mmap_smem + pmdsize) & ~(pmdsize - 1)); =20 ret =3D madvise(mem, pmdsize, MADV_HUGEPAGE); - if (ret !=3D 0) { + if (ret) { ksft_perror("madvise()"); log_test_result(KSFT_FAIL); goto munmap; } - ret |=3D madvise(smem, pmdsize, MADV_HUGEPAGE); - if (ret !=3D 0) { + ret =3D madvise(smem, pmdsize, MADV_HUGEPAGE); + if (ret) { ksft_perror("madvise()"); log_test_result(KSFT_FAIL); goto munmap; --=20 2.39.5 From nobody Sat Oct 11 12:14:58 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98CB429C33A; Tue, 10 Jun 2025 14:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749565117; cv=none; b=aUH/At9pW9TDiyCAKULdTsWGrDtZ+z/F1yQCdzvhYdG9hnp+56ZXvOx4wSSWpqisDe68QQ2oU5Ez99hEvZygxnXJlbA0axS5KcoENmDncqEHGPTv6q+N8pvk3SoOW28auyHoDfcXrrKPeqI1ExBGUpCm1BjMx0v0v9eoXRYGihU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749565117; c=relaxed/simple; bh=XIqlvXcLhigaPQ9Uiztdzq4aV3ciRSHw6O22PqR8rDU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C+ywzE5GgY1X9tY19ltlLKd1Ik3E7YmM6GxSQhxOUAy0zaP35K3M8RIEfuK3bz48Z058ONx51WXdMaMDTQH9ONYFWteVcbTsIrsmGfMsZB1LyanEjvCf/TkjpEOGI38dgaeXST9ScoyNQFfXmb7Cak4Y0vd9AFDvBVQzTXhaMDo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fvEJkNA8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fvEJkNA8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3A9FC4CEF1; Tue, 10 Jun 2025 14:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749565117; bh=XIqlvXcLhigaPQ9Uiztdzq4aV3ciRSHw6O22PqR8rDU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fvEJkNA81zAL7NF8UKiSuwgNZEWLUkVEUY/DR1hVDBAwmDzKco7CtDda8YUlLICfT e8GvGMLPXC4h/lOwBep3rHrkxXer83eUT/HjAV33gvLE0SQN+ioXVCewGK3+sakL1W GgWXCdVGuZ1I29KVmkR/e8t71KSEVAvg5cG0BnP86cvQivSkfwEBbJvSTe/G90ZnVp U6Htk7qZ0Q50T+MXpdZvqoXC8P/IfZ9/G+izpnrYuP39rD849IemRZEaLWjUUX1495 /1PDbI3TChQCZzTA9HsGvrm9kjLUTAfDw5xVycdm7/wC0cYiSO1Abu6DGLsrk5pxqa d5g7+Odfj+mIQ== From: Mark Brown Date: Tue, 10 Jun 2025 15:13:57 +0100 Subject: [PATCH 4/4] selftests/mm: Add messages about test errors to the cow tests Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250610-selftest-mm-cow-tweaks-v1-4-43cd7457500f@kernel.org> References: <20250610-selftest-mm-cow-tweaks-v1-0-43cd7457500f@kernel.org> In-Reply-To: <20250610-selftest-mm-cow-tweaks-v1-0-43cd7457500f@kernel.org> To: Andrew Morton , Shuah Khan , David Hildenbrand Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3040; i=broonie@kernel.org; h=from:subject:message-id; bh=XIqlvXcLhigaPQ9Uiztdzq4aV3ciRSHw6O22PqR8rDU=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBoSD6z7nodlgS22VhRNHY97fp3ZLzuwRlu31UHzQwB gXw7IGCJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaEg+swAKCRAk1otyXVSH0PuSB/ 9Gzkq/wcaXkrOxcFyL1WuVMFr8UsfjIpTwUaNEqszIp9AWmFw/DzRxjm33G41mFMQr1kRnUa0VtOqO aj1PB7cWiOLoalM2Z2ZwH7P0sa0Eqh0NI5kZ/4yiOpUDJVPnTuYtiw87wFWxKPn/Je0qO2sace67zh 8g4xKUoaU0Xi6lgPjnHDQjEEF9+US9M+nKjGzwJQmE7qw56NVvqbva0YpiaIKWvnXLFO32x8KRiwDN hJ+z5+qfe/bOTdsWuruJZM5sAEBHjCiAxleGAN/8dnoCXCIdfDXOPULSGQkdcAcjOtwjOcVMTMP5rL NmLXpU70IC61Cn+eVEiZj9gd48ZDu7 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB It is not sufficiently clear what the individual tests in the cow test program are checking so add messages for the failure cases. Suggested-by: David Hildenbrand Signed-off-by: Mark Brown Acked-by: David Hildenbrand --- tools/testing/selftests/mm/cow.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/= cow.c index 48fcf03aa4cd..29767e2afdd0 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -268,8 +268,10 @@ static void do_test_cow_in_parent(char *mem, size_t si= ze, bool do_mprotect, * fail because (a) harder to fix and (b) nobody really cares. * Flag them as expected failure for now. */ + ksft_print_msg("Leak from parent into child\n"); log_test_result(KSFT_XFAIL); } else { + ksft_print_msg("Leak from parent into child\n"); log_test_result(KSFT_FAIL); } close_comm_pipes: @@ -397,8 +399,10 @@ static void do_test_vmsplice_in_parent(char *mem, size= _t size, * fail because (a) harder to fix and (b) nobody really cares. * Flag them as expected failure for now. */ + ksft_print_msg("Leak from child into parent\n"); log_test_result(KSFT_XFAIL); } else { + ksft_print_msg("Leak from child into parent\n"); log_test_result(KSFT_FAIL); } close_pipe: @@ -570,10 +574,12 @@ static void do_test_iouring(char *mem, size_t size, b= ool use_fork) } =20 /* Finally, check if we read what we expected. */ - if (!memcmp(mem, tmp, size)) + if (!memcmp(mem, tmp, size)) { log_test_result(KSFT_PASS); - else + } else { + ksft_print_msg("Longtom R/W pin is not reliable\n"); log_test_result(KSFT_FAIL); + } =20 quit_child: if (use_fork) { @@ -725,10 +731,12 @@ static void do_test_ro_pin(char *mem, size_t size, en= um ro_pin_test test, ksft_perror("PIN_LONGTERM_TEST_READ failed"); log_test_result(KSFT_FAIL); } else { - if (!memcmp(mem, tmp, size)) + if (!memcmp(mem, tmp, size)) { log_test_result(KSFT_PASS); - else + } else { + ksft_print_msg("Longterm R/O pin is not reliable\n"); log_test_result(KSFT_FAIL); + } } =20 ret =3D ioctl(gup_fd, PIN_LONGTERM_TEST_STOP); @@ -1417,10 +1425,12 @@ static void do_test_anon_thp_collapse(char *mem, si= ze_t size, else ret =3D -EINVAL; =20 - if (!ret) + if (!ret) { log_test_result(KSFT_PASS); - else + } else { + ksft_print_msg("Leak from parent into child\n"); log_test_result(KSFT_FAIL); + } close_comm_pipes: close_comm_pipes(&comm_pipes); } @@ -1528,10 +1538,12 @@ static void test_cow(char *mem, const char *smem, s= ize_t size) memset(mem, 0xff, size); =20 /* See if we still read the old values via the other mapping. */ - if (!memcmp(smem, old, size)) + if (!memcmp(smem, old, size)) { log_test_result(KSFT_PASS); - else + } else { + ksft_print_msg("Other mapping modified\n"); log_test_result(KSFT_FAIL); + } free(old); } =20 --=20 2.39.5