From nobody Mon Feb 9 07:34:50 2026 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B714279782; Tue, 10 Jun 2025 07:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749539326; cv=none; b=S0LtLksnqeILVb2odHBPg9w/JyeDrkcYc4samnMnDBvc7vxhtzdE2rif5Ua5hkl1NMXBqYMJ8ERGMFRPYO6Po5c8uACHc46NsDeBkJE2QeBc0CFH+CW8xWUI0B3iimefoUqgqrXpG56C6xalEt6numx17Tmy/x/rhbww7MYmhQE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749539326; c=relaxed/simple; bh=QcyXPFcPfN14Q5mVuC3lAt6POPZJpQWvb+wyX6TiII8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=u+1a2jkCYjahgifpTyCupFZTCWB7ACDpytdiBSrZsF0z8nWtwaVesjT88xyz5KIjxwOFuOSb6fXwPI0ZjE8QVhJRRowM0mcrvxqQHF1PTSYMA0q3D2qKzrj1KL60CfDDXNkk2gStPIh8jL8yce5PnIeggFrxgqg9kQGhRZSUd3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=qxNwjfzC; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="qxNwjfzC" Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55A2bxrF004177; Tue, 10 Jun 2025 09:08:36 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= mpLBdpH7Q64UGulCvUH0/TRi7b8UYxTI3kawUDO4Z6Y=; b=qxNwjfzC8mQFG39q 861Vt723blDlKoApvlZKj8j+00dSOy2h+H2iT2KE90MjBBYIj9gQ6tp46WFOrsYk QejggceI63Sqv0QYcax/+uYnkw2NRapS85/F0SSVC91Ve46A/m5zlIkJKyDiEZjq RkcT/20a7Db24v4WTCGnf8oj+CXZlKmAQPyjIVJFlx93hyM4lpdZ7WnDYPaUTKPO nO8PSXGndWf4jci8U0zytEoiKYjbcgSvnLAgOw8P4OQYfRsEgl04AFXGjKF1yFlN DvDq7nfCT7UTJpJzsXmzRFa0q5ZJUbqcZm1Ki6oKlR3sVsxeWpHeASAIvwdLADmh hkMxYg== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 474cs2k6sc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jun 2025 09:08:36 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 688ED40049; Tue, 10 Jun 2025 09:07:58 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id AE7E9B9DCE2; Tue, 10 Jun 2025 09:07:42 +0200 (CEST) Received: from localhost (10.130.73.167) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 10 Jun 2025 09:07:42 +0200 From: Benjamin Mugnier Date: Tue, 10 Jun 2025 09:07:41 +0200 Subject: [PATCH v2 1/4] media: i2c: vd55g1: Fix RATE macros not being expressed in bps Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250610-fix_vd55g1-v2-1-328305748417@foss.st.com> References: <20250610-fix_vd55g1-v2-0-328305748417@foss.st.com> In-Reply-To: <20250610-fix_vd55g1-v2-0-328305748417@foss.st.com> To: Sakari Ailus , Sylvain Petinot , Mauro Carvalho Chehab CC: , , Benjamin Mugnier X-Mailer: b4 0.14.2 X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-10_02,2025-06-09_02,2025-03-28_01 As a bit rate is expressed in bps, use MEGA instead of HZ_PER_MHZ. Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 25e2fc88a0367bf6a28bb22d209323ace99299f2..78dd22d9cab03edf4ff3e5a301f= 8d045e930c997 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -129,8 +129,8 @@ #define VD55G1_FWPATCH_REVISION_MINOR 9 #define VD55G1_XCLK_FREQ_MIN (6 * HZ_PER_MHZ) #define VD55G1_XCLK_FREQ_MAX (27 * HZ_PER_MHZ) -#define VD55G1_MIPI_RATE_MIN (250 * HZ_PER_MHZ) -#define VD55G1_MIPI_RATE_MAX (1200 * HZ_PER_MHZ) +#define VD55G1_MIPI_RATE_MIN (250 * MEGA) +#define VD55G1_MIPI_RATE_MAX (1200 * MEGA) =20 static const u8 patch_array[] =3D { 0x44, 0x03, 0x09, 0x02, 0xe6, 0x01, 0x42, 0x00, 0xea, 0x01, 0x42, 0x00, --=20 2.25.1 From nobody Mon Feb 9 07:34:50 2026 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC4FE27AC3C; Tue, 10 Jun 2025 07:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749539327; cv=none; b=UYsy1RaZg26xFUCiTmWiJJinKzqIW3qoNYBfdn8AjXOpKQkO19VG2EPqe+hGLXQOm/6MYKtq/4SIuJ0tvZH/kuNXTtRMmcnRTrGsIrQ2VBvIwb+Rxjs4Ox0yklWv8Ya8b3nrmMFgB5fyIUsyoX+Bw/e9uZdkWJMByP3ZZj2D0LE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749539327; c=relaxed/simple; bh=69Lk3vhK7kxM+f3aRs9NZGKK7v3SZWRNe334x64JVkU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=mLRyy3WbXLXlEivTggmRjgpGKDIPDvnZM/Ywyhwvs20ZNLhAK3nm1Y16RMTZyzvG0nC/Z0+F12pBovmhEP1IUChGeIz2cKcICyfLA85631qvGQUnKZe85ndlQQatOYbFlDbv9DFogUeumJhbEzrv29/BI2VCfJNA3sK0Jkf6Kjs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=HU2Dr8hF; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="HU2Dr8hF" Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55A6pmar003209; Tue, 10 Jun 2025 09:08:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= PX/y7gliH4I8f98WoXqhCdSxGh4NTXeRFWxdmsiFQgw=; b=HU2Dr8hF0Y8uEhi2 jI9Kmex0phlqEN7QH8IPqPxPhm+33Fkbetza1JUzm8R8vqrwWuA1mtjb3Irgjo9x 14++eYZSo5euKqgJeJDY2aV6fYTmDzL7bXF8c/5jBOuoNFOuxZDArhaMhUdklU4i 9rG3WOYbao01Bs5ESg7i1GMnLlkjd3MKWG3cW6YqL2+DTPw8dhlTCMECU6DK8Bed 9guOQLzW/a0WEMrYCF+sRuP5MZTTz6nAqo6CjuC2Dnc/BlbLbxSSVEaJ7TRoGvXE LhHjFERW94i+QBMGHNeUQLL6TKwvR25h97JJC6WKQyFC6TG/Hn6f5iyH4PCYwaUS RnKAfA== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 474cs2k6sq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jun 2025 09:08:38 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 91B9B40058; Tue, 10 Jun 2025 09:08:00 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 3EB0AB9DCDD; Tue, 10 Jun 2025 09:07:43 +0200 (CEST) Received: from localhost (10.130.73.167) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 10 Jun 2025 09:07:43 +0200 From: Benjamin Mugnier Date: Tue, 10 Jun 2025 09:07:42 +0200 Subject: [PATCH v2 2/4] media: i2c: vd55g1: Fix return code in vd55g1_enable_streams error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250610-fix_vd55g1-v2-2-328305748417@foss.st.com> References: <20250610-fix_vd55g1-v2-0-328305748417@foss.st.com> In-Reply-To: <20250610-fix_vd55g1-v2-0-328305748417@foss.st.com> To: Sakari Ailus , Sylvain Petinot , Mauro Carvalho Chehab CC: , , Benjamin Mugnier X-Mailer: b4 0.14.2 X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-10_02,2025-06-09_02,2025-03-28_01 Enable stream was returning success even if an error occurred, fix it by modifying the err_rpm_put return value to -EINVAL. Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 78dd22d9cab03edf4ff3e5a301f8d045e930c997..336dc3c85ac9e695f22aa524e0d= f6138dc76e45c 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -1084,7 +1084,7 @@ static int vd55g1_enable_streams(struct v4l2_subdev *= sd, =20 err_rpm_put: pm_runtime_put(sensor->dev); - return 0; + return -EINVAL; } =20 static int vd55g1_disable_streams(struct v4l2_subdev *sd, --=20 2.25.1 From nobody Mon Feb 9 07:34:50 2026 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B64821FF25; Tue, 10 Jun 2025 07:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749539327; cv=none; b=H4Hy0hC+dg71JrLBeG4J7cQjePCR2vHujVg3CAZCliQfdXcswso6ERt/KXbfYVDJWGNRmbw90Ezja9Z0QpOLONWh9uAd/FrcGDXYRZQUTCjA+Dx+rYHV5YoYApI1yTvUHnI4Re4tw8tnJc7NdaL8zPiTC4asiFOCQSMFOE1aN0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749539327; c=relaxed/simple; bh=U4jGWHaIaMXuRCicMbs1PcoLZQJpE3+kZRirVXC12Bw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=Q7VllF2eyc3qTl6MWggzzwAqjcZqgP7/TX5x6MEttc0tJw4frpSWsc7TFBjAksfbWrzUHQmO5De64KSPvas3TWRyqjwDxFZnztkd0c6miloDi1SJjwy5Ib2oce0F48HM2PyuHwQaCnLuXRS7bvmkwWWgMkBBR/1vArY9a6GUo60= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=M+HiorQb; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="M+HiorQb" Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55A6s2sX008257; Tue, 10 Jun 2025 09:08:36 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= TV0Ykqz+yMv+EUoGBcc//ckZ5rwVDZ0YS3LKw7DDNAs=; b=M+HiorQbPUS67Vop lOGtDiSaBQdsAbRwNg9ZCMZEV3n4RYD9YuLEauesT0tWuJS8lXP6tQuVRHgSfEAR 3YbpiEdsOwAMdmzpmoGzx+54lJ5bU0OQqStzmt0ExDz0uJ2EWlXK2ToxHUXkEDmk mOoR8FNsvKtu2twhNmWBs9wzGlrxrxw4wFYHG4ZLt5rRDwziQzogjUc8IQv3wAyo CQBiBSSvNoxXPLv/yOMkhihIQoI6FW3SGFqWpJVhTQjYajNXcr+SFHZ9abXKJ24e 0xZP43RZdZ9VCu69L86F79kGN4Eok5ZYFhBJiLEyoldljDrxNIoVcMurx3d58KCU +JFTjg== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 474cs2k6sb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jun 2025 09:08:36 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 2776D40059; Tue, 10 Jun 2025 09:08:01 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id CA57DB9E7E5; Tue, 10 Jun 2025 09:07:43 +0200 (CEST) Received: from localhost (10.130.73.167) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 10 Jun 2025 09:07:43 +0200 From: Benjamin Mugnier Date: Tue, 10 Jun 2025 09:07:43 +0200 Subject: [PATCH v2 3/4] media: i2c: vd55g1: Setup sensor external clock before patching Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250610-fix_vd55g1-v2-3-328305748417@foss.st.com> References: <20250610-fix_vd55g1-v2-0-328305748417@foss.st.com> In-Reply-To: <20250610-fix_vd55g1-v2-0-328305748417@foss.st.com> To: Sakari Ailus , Sylvain Petinot , Mauro Carvalho Chehab CC: , , Benjamin Mugnier X-Mailer: b4 0.14.2 X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-10_02,2025-06-09_02,2025-03-28_01 Proper clock configuration is required to advance through FSM states. Prior than this having a different clock value than default sensor's value was used (12 MHz) could prevent the sensor from booting. Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 336dc3c85ac9e695f22aa524e0df6138dc76e45c..dec6e3e231d54a742bdd08ff2a5= 06c152bb89429 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -1038,8 +1038,6 @@ static int vd55g1_enable_streams(struct v4l2_subdev *= sd, if (ret < 0) return ret; =20 - vd55g1_write(sensor, VD55G1_REG_EXT_CLOCK, sensor->xclk_freq, &ret); - /* Configure output */ vd55g1_write(sensor, VD55G1_REG_MIPI_DATA_RATE, sensor->mipi_rate, &ret); @@ -1613,6 +1611,9 @@ static int vd55g1_power_on(struct device *dev) goto disable_clock; } =20 + /* Setup clock now to advance through system FSM states */ + vd55g1_write(sensor, VD55G1_REG_EXT_CLOCK, sensor->xclk_freq, &ret); + ret =3D vd55g1_patch(sensor); if (ret) { dev_err(dev, "Sensor patch failed %d\n", ret); --=20 2.25.1 From nobody Mon Feb 9 07:34:50 2026 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B6B322B8CB; Tue, 10 Jun 2025 07:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749539326; cv=none; b=mgfm7fvt6Fpn9/QWk95aJKSbvZc/SNorUHBwKujuQYhYpPRqYqY6l69gcMbBhXXwWuUpVcl0ChLlj04RlZxQ6WyrnoyUk+zb/NELS4A8HOiq9CoeM6v9D+wtDTwFM+qbwOp0yfZqVv0SA8vtI/421AtMgHJmPOCOGnK0Eu7xo1Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749539326; c=relaxed/simple; bh=tToi8tfhAwhbg8M9op98TVL8Co/zc0UThzZIsHoprw0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=buu2V2dOU1uPOTvb7q63RAWTAfcJgNftBNXkADdrvXryuspXPralQSLVc3ORC9/wRavHl8Wro+LsBaYDmWCcjPowSosh3Z+V6NceO7KxUmQCD3CxzlFHmryaUU/AiLwVnMsu0rvaMnUDWIvrIT8dd022I1iRW9WAVj4RQqogspA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=StJN63c2; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="StJN63c2" Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55A5xdqd006735; Tue, 10 Jun 2025 09:08:36 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= ZPw43GyUj1rBJP84OCQo1msrNqbW6/iMIuz9l5cgfso=; b=StJN63c22GLOtsvG 9fojwf5LSEuEPKjFbXmz84uIY7ub3vFX99Z9XJXV2a1vFpsN5d5S2XhOo0h0Q7GF HBpGoemQxN4fcBWM5/ZHQdUMn1f8kB3SxQ7DzQiHjg1MHcQm4zqi/F1Pd7P2N9nH YGS0i8KoFV64+rIpwliONXS0nstH7n8kaK5J8LrF7QuRHWTsaRorojKTVLi1GixN h4GSLWeaddFox9BAgi13SEz3KX+kW65txewuOE3Vgl8CUYkAaKLUNd5jdGeFkRgd CADr9mUF0OMeANtFtjm3NanRjZdPo4IgMnxRVv+xkPkgZU4JPDfu3LmquDkFDc3q bGa+8Q== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 474cs2k6sd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jun 2025 09:08:36 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id A8EBB4005A; Tue, 10 Jun 2025 09:08:01 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 531B6B9EE0A; Tue, 10 Jun 2025 09:07:44 +0200 (CEST) Received: from localhost (10.130.73.167) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 10 Jun 2025 09:07:44 +0200 From: Benjamin Mugnier Date: Tue, 10 Jun 2025 09:07:44 +0200 Subject: [PATCH v2 4/4] media: i2c: vd55g1: Use first index of mbus codes array as default Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250610-fix_vd55g1-v2-4-328305748417@foss.st.com> References: <20250610-fix_vd55g1-v2-0-328305748417@foss.st.com> In-Reply-To: <20250610-fix_vd55g1-v2-0-328305748417@foss.st.com> To: Sakari Ailus , Sylvain Petinot , Mauro Carvalho Chehab CC: , , Benjamin Mugnier X-Mailer: b4 0.14.2 X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-10_02,2025-06-09_02,2025-03-28_01 Factorize code and prevent future erros in case of media bus codes change. Rename VD55G1_DEFAULT_MODE to VD55G1_MODE_DEF to mimic other macros while at it. Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index dec6e3e231d54a742bdd08ff2a506c152bb89429..177caa5470cfcf49e0ae2fb568d= 7872a5608a11f 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -111,9 +111,9 @@ =20 #define VD55G1_WIDTH 804 #define VD55G1_HEIGHT 704 -#define VD55G1_DEFAULT_MODE 0 +#define VD55G1_MODE_DEF 0 #define VD55G1_NB_GPIOS 4 -#define VD55G1_MEDIA_BUS_FMT_DEF MEDIA_BUS_FMT_Y8_1X8 +#define VD55G1_MBUS_CODE_DEF 0 #define VD55G1_DGAIN_DEF 256 #define VD55G1_AGAIN_DEF 19 #define VD55G1_EXPO_MAX_TERM 64 @@ -1260,7 +1260,8 @@ static int vd55g1_set_pad_fmt(struct v4l2_subdev *sd, static int vd55g1_init_state(struct v4l2_subdev *sd, struct v4l2_subdev_state *sd_state) { - unsigned int def_mode =3D VD55G1_DEFAULT_MODE; + unsigned int def_mode =3D VD55G1_MODE_DEF; + unsigned int def_mbus_code =3D VD55G1_MBUS_CODE_DEF; struct vd55g1 *sensor =3D to_vd55g1(sd); struct v4l2_subdev_format fmt =3D { 0 }; struct v4l2_subdev_route routes[] =3D { @@ -1278,7 +1279,8 @@ static int vd55g1_init_state(struct v4l2_subdev *sd, return ret; =20 vd55g1_update_img_pad_format(sensor, &vd55g1_supported_modes[def_mode], - VD55G1_MEDIA_BUS_FMT_DEF, &fmt.format); + vd55g1_mbus_codes[def_mbus_code].code, + &fmt.format); =20 return vd55g1_set_pad_fmt(sd, sd_state, &fmt); } --=20 2.25.1