From nobody Sun Feb 8 03:48:44 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A49321D5A2; Mon, 9 Jun 2025 21:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749503307; cv=none; b=sssXj8EqwJH6DYiowZNiI/7Zn1IGGqxcOmEojcr1K95sPoNktfRZZ/zo9PFXFXtajZEmT2GAIb9+Vnaa+0VTfgLWrN7f8hEhtPH1IGcoaK+4+v5NqdbJ4IXUTiPA/op0VtPMm27LZ23bbsaxXL2V6JbkIgi67AzdGQoIwSklT+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749503307; c=relaxed/simple; bh=zJTjdCr8yR6jka+8Fl6/XXKV/YPVY/4YWXAs4bcR55U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sS8bFibjM5F5CsBqezPQHoiillKB+KT+hdOnCGwbOuUDxj0HDibZijNJMwZ9EGbfE4Pg8uritpIzos5gozdOuho7CpJxWCcb7OaxLhiM0ktfNdpAS8PWbGfnuQ+3nJjLcb6DwbkekZVgnD271wDWUxH6ePvsgB3/057RBR+qgFA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E0B/N0Lp; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E0B/N0Lp" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ad883afdf0cso867213366b.0; Mon, 09 Jun 2025 14:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749503304; x=1750108104; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aaer8KAt7DHXZvrLCnz/sCu0lhGcXvLJk84mttxt34U=; b=E0B/N0LpVCF0rcat7KgPdyKFCLMBVdc7Z97xWV7Q/nTv6kKFazzAeiPsRsTHT8OUpL rOhPkYYci1rzUg4fCs6IDmiSzBnVeq9fBMX3QxByilTOXzhwTlKJy/gGMQpQRH6XMAUU SHtQjW+SjqUVxbkYlISQjptGr1uhzk4i+I59ra7yW5BXppoz0iY7dKFh70gidqZb/ndx m3UJvAJjdQr/hrneRBtZtUmv6r0zXVPlZmz5nTUVAfud4EkiVqaVDRK9pQ8QYKNkmFN4 PKSzkMSvWjhvK8TlDMQ5MVis222sJn9YmocHt/TXaEhF8B2DBIngyhQpl8ZRbB5bBM1S HhAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749503304; x=1750108104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aaer8KAt7DHXZvrLCnz/sCu0lhGcXvLJk84mttxt34U=; b=fU8KWbZaF5jzqZyjSezjt+xvZE6pd/9JJBYBVlRJar0SaSW7/ekrO2MKD6V2gpqArG oFbsfNyo+eczdpFl5/7cWHDQSBiWRf0aXET/teAoBWId5Ly52/cOglj3LX3Ij6g9HBsR XsW9DbUXzw1q5uJ6uNgaouXOGxvsjRkaQaPgl90nOzmJUZs7mqCTVwejKBqiKQ4GOGgl SAcXcjP+4uZ/4kCzTu+FxeI0L8pgW2gw22DcSDO/qViq4SHK76F3bAqiA073uqKnHGEF syl4Y8nc+IsOB2c1cm04o8FBUSdKE8SMagQ6U+MtEpvp682GwrBveUpxpYJzJaS4gkal 410A== X-Forwarded-Encrypted: i=1; AJvYcCULSHr6+WZfIfTytes29I4jO1w1Gcyvv/U7OxRN4A5YHfk/ss6Fx0pnCVucqaF5rPAhm8U6h32d@vger.kernel.org, AJvYcCXaOVxS5DMvHZpT+/fo3AspQWfxTkZx8xjEqw8rc+sQfb6YD9lgAzQN4vY0hJraZJtww+WcQ8hcFvDZQdE=@vger.kernel.org X-Gm-Message-State: AOJu0YzRLE6E8WAPGViV/52dMkCq6PRYQhJ7ApqrP7zLn+4BCkXQLt4w Dk4tvUiqgu7+v2D4DZ5EDEgw7CVWnIAxPiYbAPdKPei2A9fu/I78UsLZ X-Gm-Gg: ASbGncuipEGlaIiYgb/zjNGagEjIIZNcZts3TjF40bsgckqMhWs0GqpikjIVyfNwjh0 nFWwzOSRNmCSJOD0FUQHQTLW+J5wq3kZk8A6Tus+aN+Wa2kT/q+xyqokeQqNEm7TT+b+S6UIWv2 8nN+GYl6VseArTaS12E/UHpb0VIwpi6192eDEe/5wDb32GeleULVAxWm0bnfa9UUsMGDMHnBllY CTjqbMiRzx/lJyRoi2xs4pT+XQmq5/hGyBB3KMDdoNdt3FXOfcw/7Kp8AUkBBN8ce/Tl77H1nDm OihzHuvjiIJEIqIp6kF1BKLsdfv0jo1Qw6o+eIcn0bUiD8fo3SJ+qB9/x946o0O9NVYIT9Cm X-Google-Smtp-Source: AGHT+IEF3fQvwd1EIVSbTlo6LUuUxv3OibA7tXvxVkt4PpEP2e2lZf2MmCaWCy6qIv21CKgts09mig== X-Received: by 2002:a17:907:7216:b0:ad4:f517:ca3 with SMTP id a640c23a62f3a-ade1aa0702cmr1303826466b.20.1749503304229; Mon, 09 Jun 2025 14:08:24 -0700 (PDT) Received: from debian-vm.localnet ([2a01:4b00:d20c:cddd:20c:29ff:fe56:c86]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ade1dc1c57fsm609733366b.100.2025.06.09.14.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 14:08:24 -0700 (PDT) From: Zak Kemble To: Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Zak Kemble Subject: [PATCH v1 1/2] net: bcmgenet: use napi_complete_done return value Date: Mon, 9 Jun 2025 22:08:08 +0100 Message-Id: <20250609210809.1006-2-zakkemble@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250609210809.1006-1-zakkemble@gmail.com> References: <20250609210809.1006-1-zakkemble@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make use of the return value from napi_complete_done(). This allows users to use the gro_flush_timeout and napi_defer_hard_irqs sysfs attributes for configuring software interrupt coalescing. Signed-off-by: Zak Kemble --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/e= thernet/broadcom/genet/bcmgenet.c index fa0077bc6..cc9bdd244 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -2472,10 +2472,8 @@ static int bcmgenet_rx_poll(struct napi_struct *napi= , int budget) =20 work_done =3D bcmgenet_desc_rx(ring, budget); =20 - if (work_done < budget) { - napi_complete_done(napi, work_done); + if (work_done < budget && napi_complete_done(napi, work_done)) bcmgenet_rx_ring_int_enable(ring); - } =20 if (ring->dim.use_dim) { dim_update_sample(ring->dim.event_ctr, ring->dim.packets, --=20 2.39.5 From nobody Sun Feb 8 03:48:44 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91BEC223DC7; Mon, 9 Jun 2025 21:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749503310; cv=none; b=PhmSuaimOgokPJlXXwIril6kCURbr/ydyG07PS2e5zPGYF/55TuQreAsuqcP8+PX6THLgLTEwb96hr/EpPfmv0eUUvUsBZlzvgQtc0seR1osawHCsNpTzqjhqGFEcueAhnS4gW8pfOLGJajOZkw5+KgLUnMsFZeob/DZ/nvzEug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749503310; c=relaxed/simple; bh=R5txiWduQ1MLb/7Ofzb1I1KmObx5d/2qHesoSZIUDnQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ixitql89nqyVFBqQmBYfSAX3DTx/NDxHAV10NJswqf5mVRXwm/L2q54EMyxeUvDqeZ0AO9apnya6FL8OSl7fsEbEqdizBTFtYywp1B4IhRlSCrIF2dKkmEKNCYeervOKBddGD2cymCiMZw5hrZVAePbyKbnKR3TsV0BTZBt9TDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kyHu7krb; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kyHu7krb" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ad88d77314bso891739266b.1; Mon, 09 Jun 2025 14:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749503307; x=1750108107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0+ejMMbHq5PYDlrAJtCac52TZKigbKKjKjZOjD2zAkU=; b=kyHu7krbBQWh4JJJdu1a7bnI7IPKrZ/pohySGnw18VfoGO/OqmyLuHX9K5/y9pxjpe oqZzqauJ8R7mgB+4nhlDTIcehJwBlS2VzgzX7c+PLKGmAFUjNUba+pW00NWUvG0Sz7KZ pBrngFxZiQz3wPZhBxo8oJBx7LN7A3eQAZu+MKVaxjQ7+nGLfhv9HfavrurtRnnQ7/f0 T6XYJJx/OLFCbvpMgJVNQ8EM9IfUYXXHzURkBmObEYOafStRjukjiiBXLuYwW4oZnpLA DqdfUCMGYg5Es2Nw4TV5geNV29ie7R6aPNi/DKxeVDCKMa80QfnWhylziMK5Fx5Ci6lc 21Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749503307; x=1750108107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0+ejMMbHq5PYDlrAJtCac52TZKigbKKjKjZOjD2zAkU=; b=UZlbKNSMCEDT8+hDVUjT+/DiC1g82lukx/FElK01mtti/BML6ZPM1582QuOTfVzYdw MY9B1xQGyDbePhU7mFk6PcI+0ZF9J+GKn6dbSujUtsYt/yKxhNrzxPSLNStmvXSJFnZC 1VeqgkyX2jknCCkM6jTmM2kUkaLJbitrJc/etQ+pwezkksf9BQlalyEySjLmtw82uXi3 /7pfS4bvgvYA71/RNiRjpda7sFJiRJF2/8XVuh1s2FoxH+Asm/S6tGTyR8+GoVoEdJCE BeaAMd6SYsm56RZIVlfFGiqC41wjswYa8WbCqpunwiR9EhP8/eecYub0Bvtn2QxI6vA+ gm6Q== X-Forwarded-Encrypted: i=1; AJvYcCWLwiEztxlY+3cgEW3P1+FcGs/83K96tm0S6W/QLASH612+JgNN0GRZdv1NIdgf2kTtps4LFXIn@vger.kernel.org, AJvYcCXxJddLIVZagnJwSVG8y+uFUUSPlG3JeZ2QhtMmvbSIASkXrNmkwmtozdZ+YdW0+a1hifPuLsKPrIfqG2Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxbLwPL5HdJoJR2qtoftd4JXKC1BVaWBq9rKNDN8lryLM7lgat0 8ExbCavRP+I7ekphMIYgFPlDILK9vFPcwkx36Tvs+QpchQ+02fpGJjbz X-Gm-Gg: ASbGncuf1FNWFDaOp5H9DJGVD0G3tdnUWTqlW37HzSDqIH6rKQQ2NyULoFG44Vr3p3K /QwWQ9TsJPNFLKA3udvfJTZcI7/lEJEKV/rrD5wSzUUA0wolNouwVPlrkfUN6Eevz/KRapes5fJ kSQl68+5UTyTOO4XqT2hBps8GpsBntSBwiNcqPAOOdMLozdWHoQgHuDPkW7F0Stvo5R5venriGm dtQhOLxrXgSUTuDwNYylhVZzsSdhtFYYShnS3idXcXyX5eskvwBXsDOpK7ymTLggXHmoG7ju4BR bH9oaP+u77imQN7bQFXrJA8R+bxmFXFHU7SugmniafhLhXtS5sdOEeT5HsmnCInHUFaKya55 X-Google-Smtp-Source: AGHT+IFs6pWFDchlGAYQbAfzSey//l01J4bVVh1jx84lu/dDM6vfN333xLffOwWloudzTuKhEhqitw== X-Received: by 2002:a17:907:6d28:b0:ad8:9909:20ac with SMTP id a640c23a62f3a-ade7ad0d89emr7718566b.50.1749503306793; Mon, 09 Jun 2025 14:08:26 -0700 (PDT) Received: from debian-vm.localnet ([2a01:4b00:d20c:cddd:20c:29ff:fe56:c86]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ade1dc1c57fsm609733366b.100.2025.06.09.14.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 14:08:26 -0700 (PDT) From: Zak Kemble To: Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Zak Kemble Subject: [PATCH v1 2/2] net: bcmgenet: enable GRO software interrupt coalescing by default Date: Mon, 9 Jun 2025 22:08:09 +0100 Message-Id: <20250609210809.1006-3-zakkemble@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250609210809.1006-1-zakkemble@gmail.com> References: <20250609210809.1006-1-zakkemble@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Apply conservative defaults. Signed-off-by: Zak Kemble --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/e= thernet/broadcom/genet/bcmgenet.c index cc9bdd244..4f40f6afe 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3986,6 +3986,8 @@ static int bcmgenet_probe(struct platform_device *pde= v) dev->hw_features |=3D dev->features; dev->vlan_features |=3D dev->features; =20 + netdev_sw_irq_coalesce_default_on(dev); + /* Request the WOL interrupt and advertise suspend if available */ priv->wol_irq_disabled =3D true; if (priv->wol_irq > 0) { --=20 2.39.5