From nobody Sun Feb 8 13:56:46 2026 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0826E21CC79; Mon, 9 Jun 2025 18:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749494841; cv=none; b=URLQP+9rARy2WY1WBPrfda9zR7qsY8LtxB9WV5rHeOIrnQMcyO3EVap7A63CcGkEa3nC+U/05FR5vxJve+YTGMg1gNc4wB4Lmimr17W6CZz7TKeufpNbtjCrzyEwS/cQCqdy5Wi60uCGs+LHwiTAR5mobA2RRB0jm3Yj6WnXs1g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749494841; c=relaxed/simple; bh=HktfipjCtbNhdpQdjG/jx9IyuttYJiKuu2cQchPP5AQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u3zmlZxRNTzm7IhkmVUsA9pGdAlgoX5xrV0qi/euCqiq0YmdvMolS3MHw770Jr+MKLknQ+t72DKPKv65Cv2dbnPbjq3O+BYR4TR5lwQe+4yzXtqBwr/Clp19WicB8cLLqX1q83ld+zsThup0FyDP3XTseZ0unP1dVD31Qy/0e60= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HalJ2oHG; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HalJ2oHG" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-2cc82edcf49so1412363fac.1; Mon, 09 Jun 2025 11:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749494838; x=1750099638; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=80W2fxDPnqr3BsAdMQ1F8twH1xONkZpWztd0paXrfPc=; b=HalJ2oHGsZqbMPhU4otjW0yuVymQ0tfBoX3Lh9qVN6O88uez2WcQQRRLK4eKX5CKkP VfjwmWqQxbEm3ODTItoxtlf8lsTVYM6mepvwoBMSgszrllD0tVGUUBCtYgR7S/zacd8e MGVfCKjxYYivGUizxHwx/iiiAMZ70v6BsbropD0mx1S9BtPOz/sdei3A37FSO9ecCOat rEn7cTJJt4LcAmTfb+ZS3YEHLXxVNFVHG1Q2SGAmJlusPPacBJGaZXhs4d8RzTmu/kwA QGU37A4hQ3eA0b76z9EXoG1LkpTiARdPksZRMUuKM3GaVolMoagf1Jfv5dGT2XscOjF6 ESjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749494838; x=1750099638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=80W2fxDPnqr3BsAdMQ1F8twH1xONkZpWztd0paXrfPc=; b=SX5CUBbE32KVyofHU6ea0R2DGD/nRG54jdBxXRzkVjzqnc7t0JNdNcuCcmsk2BOONA hBTBHZKZmXX4LRt4MRKnKzoyociExtfjmySZeHxtvGJg2HygauBL1Gkm1pDJOJ5ncCQ3 BjownoTjPLvOXYX/PHinI0BsXsfMOMIV/efje3LzVspCt+ipSWfl3Q+QGo79tN3PX3wo 59rGTs2BvDHDNTTGuBPucnjI3io6CnxSoBwoPL2nZ65gU9a3Gou0OGrUteUtmZIJelF+ 4L1l4VXAQyHB02N+5BBAN9u8FG5PsdNoEpdUYR26x1pE0NpzDv76OwXfQMNc7LdQx3qy sOmw== X-Forwarded-Encrypted: i=1; AJvYcCX0ByTqxUcIj2I6Ecq7baNYqDbJm9FlbMx6IHUZ63BlV7Njio4n7/188dsJ9gfaDXGhLvBJVi4G61Zw5zU0s1gPX30E@vger.kernel.org X-Gm-Message-State: AOJu0YwnPdNKLVbcdMMN8d0LBFpw0F+1vTAWdin0jdItLNvk6QlfsfuO jaHkxs13OwevCiJldLW0ykPkT03k59CA4lCZ1Y5ZnkRY+8nhNRqi/nB9fCVohg== X-Gm-Gg: ASbGncvmKvdDJmErawl4ULnDzlB2ro8sRP7QWrh2/uhYbTuj6Z4do3NT32T0+npsviW yCtnluw6j6/XG37JcTzWNuLeE65suNKn+pvY1PFBU4dc4NZMV2GR3MrJqM3b/fJpW+kZhuD4fhH ennLt7irxWPqe1kLiK2yWDB+I4YixG3tHRu6eTYtRqXVEMArhEMcl0aFa66eaf12tldx8IV1ngm D4yXQblQy17o4jYEzl2RLZRBrd5C+6yIjVz9nM4zNALi2FO9yf4O37S2AhvAAnBuHL7/ATePDEr gA14r/+JxxZIx2KNY1oxEp1EIYw14f8JrAxyu49b7Z7GBctLS5jpZRZr+kp3EGmkcy2rWfmj5mT h4ut/aZtgayVubs46sPRW7MZwwqDeRKIrvlGd+sM= X-Google-Smtp-Source: AGHT+IFYd2Pb6z0OQ0t6KVOhuFvgsgdyigHOZ3cWHV72uPQsIyZKUUK/GHsc9XGTsnae/EUFCmMbxw== X-Received: by 2002:a05:6870:818f:b0:2e8:ff0e:17d3 with SMTP id 586e51a60fabf-2ea009b7c99mr8178703fac.21.1749494837674; Mon, 09 Jun 2025 11:47:17 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ea072e4b5asm2035950fac.30.2025.06.09.11.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 11:47:17 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v4 1/5] platform/x86: dell_rbu: Fix lock context warning Date: Mon, 9 Jun 2025 13:46:55 -0500 Message-ID: <20250609184659.7210-2-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250609184659.7210-1-stuart.w.hayes@gmail.com> References: <20250609184659.7210-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix a sparse lock context warning. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index e30ca325938c..7b019fb72e86 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -91,7 +91,7 @@ static void init_packet_head(void) rbu_data.imagesize =3D 0; } =20 -static int create_packet(void *data, size_t length) +static int create_packet(void *data, size_t length) __must_hold(&rbu_data.= lock) { struct packet_data *newpacket; int ordernum =3D 0; --=20 2.47.1 From nobody Sun Feb 8 13:56:46 2026 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BD0A21D58F; Mon, 9 Jun 2025 18:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749494841; cv=none; b=EqbUyIxdSBKzoaO362dniPUT+ivH5UuS0vw5sCrA2rdoTdRLdld0E76EoYPb7uvxDnUstR9WHPg3laZ51FY4salPgH/YKtKJ6OJalD6WABsEvUmo+L0FbgSvGGaxELtAiTGHEyKgBzA/d5MI0ON3cxUzKahhkf2GSs+RpMI7GCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749494841; c=relaxed/simple; bh=6s198e3EyQkclHWrtjrz3SraPafZ8SUb1XQ2K7FcJLk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pkh6HoXq2Q0Mt2yQvbRvuTEtzoptwJrSAW1TdJrAZjWrBC1CYeFcmCG4F9g996KSxkNPEcD9QgLh+MjEuXLjIsed/4OGfKC05LPv2/i/ASpWyVqTG9JOqOxRdHnKzpx2xZj54FYgmQfSLvLlCMF3/yXEOD7rlHZAS1FG0XeHLXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hsm1iJ08; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hsm1iJ08" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-730580b0de8so3214399a34.1; Mon, 09 Jun 2025 11:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749494839; x=1750099639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ybR1JZUoZ3rp+Oss0+CZOa5JsyVyUt8gjQEnl0L+tP4=; b=hsm1iJ08WtsyZht5M0npu7miI6n/XKJpuKW8BjkOznb50pYRWji/+0BBf5vJ+3VQLm GP4AqC6OM8Oeyx3r/p44cxPi0rMnG8y6vLlTOk8ptNi20MNOruVHundbva+qapkE8311 smVhwgJX7bO/5y1T86wTXswePXvZMK8igipDqpyFmS91Day00JMDtqonGG2OqziY5H3j MmI/6a6KOrCEM8Kv/vrpVSGptfrIgRwh0eejZ4sNKWyMiXnKrxHIKwujkuTlOFwm2O8r o/dsXfw0zC28WTd2bpw0+5bmHFP/gcUSdxnbhAdMd8kb3YmGr3DEkUUQ228IKGbyko+1 ipvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749494839; x=1750099639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ybR1JZUoZ3rp+Oss0+CZOa5JsyVyUt8gjQEnl0L+tP4=; b=NHN6LTt+E1/1PgefJf61ClaZ24sPF4R0Md1/l9P2ls4sbghXl4ePmdhuOzYESSDcxS Ro3rYzvlUZGZiydsq/yJITI4bPlacBu3iKg7dKRJKkEJjP2UNELZYhZB2ffPBAQ8eIrt tyd269LdrbIUttekSfFXaBOrHiyCQFxNKWeAivyaZbOmhNY0nDtZOATnpMkr6ACuYuNI PQ/Kg7i6B6i66POPpAoS0JF48V0oyBBiHMU6DGnCIEJhM3l6+5QiDN/6962s/9JOx7ix XWYRHCYT3NmhBaKSrEARTitMku7mQ2e1Nne2K1of4Kr6eNuu8HAYpMTDsWhNo4IplAWH 3leQ== X-Forwarded-Encrypted: i=1; AJvYcCXjXtqggtMwEVbsrJqFWz+3NZebfGis6jdUth0cSwT+rFU1jYy8mNj/rOoJTnl42CuqgA1NRs/qL++qMQdM0jakuOf0@vger.kernel.org X-Gm-Message-State: AOJu0Yw6G7tIqq3BZBVp2AIM6quC83JwNTK5rj+QknBcu9+Is6wZw3fG tFs6CWrB9yzETcUnJW50/tuQxPVLPNLgXtoVj6Jnvp8tCTZvzeC1e37YYHh8TA== X-Gm-Gg: ASbGnctnpHoLVI0FUkwzCq2TeahfMVePHumBSPa+bgsBglymo/sQlr4ZVRJDzFwCUt9 +FnACeSyzKiNO68PnZKr1EHZXAwYdj3D99RR7KATm9H1wOXzkDnG4sLRi0Q2jnzz6qJsFdZ7RgS ZSSFBJh2sijSb1wKVRfd1fM7u0dc1XCDIrZyM2bX+vnbvJIS3T6pNKv1x11j7C4mO6lnlnQlw2W faVeyWNMotOcf28HiOVA8PkdisMmezJD206tsPpKbTHEnqIK0ZM08uZzh3srRM64m7a8JkrFP/r ZF/ld4VOGXEa7p/LhcG3WuqMwDM/c4bvIoaxCryJZZE2LX3UTAuuk9s+4gK2Pg7BCPvVk5KT90+ rd3MAIJEPftFeqNWh54XNgRMlQuXa X-Google-Smtp-Source: AGHT+IGYSwAfVIi7rIylDueosfMJYfw6Zm6TohFLFsmESJte+Z/Uy8OcYnBiwsZuXwOX15cKOUk+sA== X-Received: by 2002:a05:6871:183:20b0:2e9:8f40:9ea2 with SMTP id 586e51a60fabf-2ea769f974fmr285707fac.7.1749494838926; Mon, 09 Jun 2025 11:47:18 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ea072e4b5asm2035950fac.30.2025.06.09.11.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 11:47:18 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v4 2/5] platform/x86: dell_rbu: Fix list usage Date: Mon, 9 Jun 2025 13:46:56 -0500 Message-ID: <20250609184659.7210-3-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250609184659.7210-1-stuart.w.hayes@gmail.com> References: <20250609184659.7210-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Pass the correct list head to list_for_each_entry*() when looping through the packet list. Without this patch, reading the packet data via sysfs will show the data incorrectly (because it starts at the wrong packet), and clearing the packet list will result in a NULL pointer dereference. Fixes: d19f359fbdc6 ("platform/x86: dell_rbu: don't open code list_for_each= _entry*()") Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index 7b019fb72e86..722979b19e0e 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -292,7 +292,7 @@ static int packet_read_list(char *data, size_t * pread_= length) remaining_bytes =3D *pread_length; bytes_read =3D rbu_data.packet_read_count; =20 - list_for_each_entry(newpacket, (&packet_data_head.list)->next, list) { + list_for_each_entry(newpacket, &packet_data_head.list, list) { bytes_copied =3D do_packet_read(pdest, newpacket, remaining_bytes, bytes_read, &temp_count); remaining_bytes -=3D bytes_copied; @@ -315,7 +315,7 @@ static void packet_empty_list(void) { struct packet_data *newpacket, *tmp; =20 - list_for_each_entry_safe(newpacket, tmp, (&packet_data_head.list)->next, = list) { + list_for_each_entry_safe(newpacket, tmp, &packet_data_head.list, list) { list_del(&newpacket->list); =20 /* --=20 2.47.1 From nobody Sun Feb 8 13:56:46 2026 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F2DF21D5B0; Mon, 9 Jun 2025 18:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749494842; cv=none; b=drr1X/vz/wlkLaUDQLxH0kaW82GWQQgjQyQbDDoN+8HFYvlgpFfR2sYrgbaGyyH21xlwzbe8V7OKsIygAuHblb9iO+jNvdCTOfhp0ElS6KpJzGDC/2EXFMdYzxIWSrvq3j2wC0smmfD+Y42GGYC0Zb+Pbu9xSQia22Bgf3Z7zes= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749494842; c=relaxed/simple; bh=pPoC/LS0uN6ywHh7EurpvMakWSVRudAGdL1ngeHOvfs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GQoIm+87IzXCrnDgNMk5KO0UteUXYX2mRXnz4IrpowKzqaNzAD9bb05zS+M9RLOJUMwf/FZcvLuXAjKMbx3AxeCKdu/QI7+g8BK4gBoka7IiE4qV242cKrjGqV/i4N6IJCZmjkXVfnSN+xWdtuqphfYcsVyqnL1oreJ7+H5NsSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZNsYwqJz; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZNsYwqJz" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-2ea08399ec8so1993452fac.1; Mon, 09 Jun 2025 11:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749494840; x=1750099640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ld2tbrtbZ/fRYlkxF78AVoT3iV81szTL1HbnVLl1RG0=; b=ZNsYwqJz+XBM3U4ufbbi/LyxUKmptBXDYnneZceVZyR7B4yGjnbXGO62LqomOZhWOF g0r2te8XaHB1s1aqbmtFsBiznW66DUpQZj9s3JGx4FwqKwUT0QCIojkJvkCP9nmL+vRM 81a9KWqIcFfezf/2W16JhE/XHukR42HN/QsXXMCdmqnKZjFZPuKoMzHGfwilxHY6n0N+ +HHNT4hcChncG3gpA7dvpgjR3ZrXY6ey0Z/Ab/W6V4LvHqg7xhwBXh5NpHpbQ1a2C4yZ BlvfDOAZ47rewDLamIiSFki4Pny7fv0gOCadaLIkxIi7yKU+Boyh4ZUrnUa/l/TPmnBA RYnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749494840; x=1750099640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ld2tbrtbZ/fRYlkxF78AVoT3iV81szTL1HbnVLl1RG0=; b=J+EjtnCL6zyPzNrUCKYY/Aaueb7H5RYWsO7yvAX/xUDZkWcJMutPZ8f8Kp5XiOXlzZ QR9PIhdxKWOA3BdonwXbTNA31hE9hxIyHGqGqPf4JZAFvXS1TPgbI68KeO9vJA61YNAI mI0XNfS0d6BHb4uwB2jENY/koySSFKzRbAoGetnr5XaXihlqlY6YIeXXJ3COy3fn1Lr3 a450BsnTCZAGcv8DxwnAM32OpcUDWcFxPrUF5NEbkGwmhWFxmgosD1Sx5ffA92YveeQ5 XcrmaDBD8OnIJAqshQNalR2syuvMbOe2h/G1kZPPSTFENSJ48C6782cFlF0hlSMTDpxY 30bw== X-Forwarded-Encrypted: i=1; AJvYcCVrJl05AshZgAmjLHVYkZJaKnu7KauivPgFkNWotx6/RaYOvocyG2UTkUibW1/pyh/23/JoW79B/2pM1IHEm1uDVfQ5@vger.kernel.org X-Gm-Message-State: AOJu0YzVCesF5ThIxKbfMrCCG8K+JjVfKIONBjxa7ofeDL4pIwnsJcdK wQoo6hvldAVKvYXrE7IVk9YD6KtdbcQ2iK20fn+QDHgQJSIus/EGwCNlRFzFyw== X-Gm-Gg: ASbGncuKE9ko7KftW71kFx8Rv36y54pNxctLlhFOlbplcttQ9p6twBwBrVarq9b9o7n zJBle5z1hgRYEVMywwwFFNG99l1ZqjmVb6lp9LeiAMhc4YaLIM2rEzsu91fSVdBF2ZQBVNjuIm3 3KhdzEaLae3ncyXmOcfj5iRpFflEuZfNUx7lc11lyDHLWQtdMCHzwKgQ3BAZuzZWzDGF3scQvq5 luvkzSVJhm2M/7dctSBuKNfDk9zSZ3JLiAiOgVZf3lyReRDfjpazecHtuFPy4sTVmqmJXE5nEcG 1iMIqzH0MaZ/iMA439CH19LQIAYNGTLczZfa4V4q3ACoqCUrAeMicWGU8bbAmfSJIt1li8ccbYa qSSbvRjwgmuITO91hog== X-Google-Smtp-Source: AGHT+IEhoG6dThL+SskJLpDoTokE/gVtENSR8qsicmFijN2sFd/IU/wmWmHylydRq9SfI/xCR8727A== X-Received: by 2002:a05:6870:1056:b0:2ea:6ea1:9625 with SMTP id 586e51a60fabf-2ea6ea1988cmr1139023fac.31.1749494839991; Mon, 09 Jun 2025 11:47:19 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ea072e4b5asm2035950fac.30.2025.06.09.11.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 11:47:19 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v4 3/5] platform/x86: dell_rbu: Remove unused struct Date: Mon, 9 Jun 2025 13:46:57 -0500 Message-ID: <20250609184659.7210-4-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250609184659.7210-1-stuart.w.hayes@gmail.com> References: <20250609184659.7210-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Stop using an entire struct packet_data just for its embedded list_head. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index 722979b19e0e..c03d4d55fcc1 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -77,14 +77,14 @@ struct packet_data { int ordernum; }; =20 -static struct packet_data packet_data_head; +static struct list_head packet_data_list; =20 static struct platform_device *rbu_device; static int context; =20 static void init_packet_head(void) { - INIT_LIST_HEAD(&packet_data_head.list); + INIT_LIST_HEAD(&packet_data_list); rbu_data.packet_read_count =3D 0; rbu_data.num_packets =3D 0; rbu_data.packetsize =3D 0; @@ -183,7 +183,7 @@ static int create_packet(void *data, size_t length) __m= ust_hold(&rbu_data.lock) =20 /* initialize the newly created packet headers */ INIT_LIST_HEAD(&newpacket->list); - list_add_tail(&newpacket->list, &packet_data_head.list); + list_add_tail(&newpacket->list, &packet_data_list); =20 memcpy(newpacket->data, data, length); =20 @@ -292,7 +292,7 @@ static int packet_read_list(char *data, size_t * pread_= length) remaining_bytes =3D *pread_length; bytes_read =3D rbu_data.packet_read_count; =20 - list_for_each_entry(newpacket, &packet_data_head.list, list) { + list_for_each_entry(newpacket, &packet_data_list, list) { bytes_copied =3D do_packet_read(pdest, newpacket, remaining_bytes, bytes_read, &temp_count); remaining_bytes -=3D bytes_copied; @@ -315,7 +315,7 @@ static void packet_empty_list(void) { struct packet_data *newpacket, *tmp; =20 - list_for_each_entry_safe(newpacket, tmp, &packet_data_head.list, list) { + list_for_each_entry_safe(newpacket, tmp, &packet_data_list, list) { list_del(&newpacket->list); =20 /* --=20 2.47.1 From nobody Sun Feb 8 13:56:46 2026 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F236721FF24; Mon, 9 Jun 2025 18:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749494843; cv=none; b=q99zrXhwuWWxRkQN2FKsCYmPpyFgNNuWwXnpoX7h0CoxGXUhKc0FDUT9rR5f/Q6j5lt4BrgRzWbQ7NAHbX+pf3aUVzRZhglcp0W1pYKREjQwxiGQWKGVk827bg5j8ZMxeDRi3raizXk5Ga/k9S7RFlDZHd++5K7fwCYa22vdUl4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749494843; c=relaxed/simple; bh=rmhaipyfzvFTUet4CzgciV8GW7lENMyYlvOXGJwmoRE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UCWWRzaJlRfgfLB4Znh7+tUKpj/HHrf6AxDbYIToB8AdQJun87+WPEP6qiriO9EbSm5E5jp6J16ZK6jrMc1uuxR+V4qnwiP+D7hmjf32aNFSQd8XNvV3/yQaz8MaPNPN7YiZWsBLFkuEIioU0fR+MmvRES3gGDGDfG7EIyQG3Zc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MYCzRcKv; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MYCzRcKv" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2ea08399ec8so1993456fac.1; Mon, 09 Jun 2025 11:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749494841; x=1750099641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L8MAicc+DqzsUNmkTOSviTgh6t6DU99MU86Mrya0BRs=; b=MYCzRcKvoveQWNyCL7bQ6DkgADD8hwnNOhdiJ+wr2+0/RsWcxH/S9dOLWMf9dVEkWy YATvRpKTf+XcMuOOjiymK6cyufvQiFfdFKUJk+4Bg7Tiy3uvg5cSspla9/s0fSCWys3r qDb91v1xF+dgDtuzjjBsFwYK2CzisvjKrfxOO2UIljaF2dgLfb6ijeE7B69e4lM6CdtO JIeg47B/4sQjXORdVXM921jA996sOn3ZJXD9aJF9GRhmMwZLqSwx95207tACfDNKwust EPsMp93iGIp+sajHJbl4t3GoY06EWUVJzYRigUXXPKxLitoOCHFDNCAeC0Z9G7yYn5O2 Ui0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749494841; x=1750099641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L8MAicc+DqzsUNmkTOSviTgh6t6DU99MU86Mrya0BRs=; b=LXFr4AgKOG5YiEzJDizM3FnBHQXhhYntQ4ZvgAmlqj7dMcR0ux2XIUI3K9nl0Jm/09 5ALISb76xNDFbUg1oT0sJi88HlEHv5V/OG17Gie5CsFEVvnT8sjUGphzor3bZQwCNDYR 8nIY5ofxvMb+m61TK+vqnJBPb4Dba2deNeG0/SCDQFucTS9VWmIprgdjTn9/OtjG8Dkj xl9s1k0DhP7r756KcOGeS1F/FEfuSBrBkE2hX2HLc6JjetsO91zU8buFW2R1mQG9CGra EH0EMdeEUq0VaCsMvKEod5T5sFG29A+6yDcUcSK0pj8qlDo9UmYy2FPnKyeq36h51cZD +uRQ== X-Forwarded-Encrypted: i=1; AJvYcCUsMMUYby3B4fBlL2hbHc/aGaSTXbYZzaKjBsrT41U4Tnpe5XbNuW2nBvbtaRkuIytWuu0OkF3OFzbKETAiPfeHg7xx@vger.kernel.org X-Gm-Message-State: AOJu0Yw0dz3mu3jDX2fNq93SVo/LGzSZwOUTX6mp6n5Wbx1Bk1ak2aco 7ibEkhmLeIr3EF5xomf0u8UQl0I3Xq+lTiyvQUpXQNfo5F7yyE9Enr+3PcQk6g== X-Gm-Gg: ASbGncufmUCniICFqFTyGWFxx2JVareIYffjQ3BByfIQSwxHNZDdWNOcu4aVoqQf8/U gkOR1/b0CDEOGPcBLhUiVc9ypKesW5XeodbDAHWxVL4H75wPixjeFk/4n17LxzUJCsc6z+Lheh8 AL0/elbMSh44Q8XQqAJF60prOAD6HO7EO6hSjUQhIAhKdmLqgrUtNFRirrU5x+Mx9iOP4ICKB7a beUcoXAnwDO7VBC4N2Qh4AmlEjpn93CkBXzvp3SbtnfXYrRrX6Up/ob2uJq7vp3ps5Wx9Kc453q SdkNNgDRVN4cfzChuCm8fb+0VnPQBDrKFwrSRw2gtUagYwv87jpwlRJEVS5X7s5sgErsg+7jkT2 2p4hqn/+/DKzMWfNqLttJwJ7orOOFd51hEaibVoA= X-Google-Smtp-Source: AGHT+IHyq/vKQLED9Su1Jd0QEhZdlhfl/u6ki32haPcxOuv+dLXepFEpdo0E2eWGpreZkqGONLAelA== X-Received: by 2002:a05:6870:5147:b0:2d5:2955:aa6b with SMTP id 586e51a60fabf-2ea007cdf93mr9081717fac.5.1749494840890; Mon, 09 Jun 2025 11:47:20 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ea072e4b5asm2035950fac.30.2025.06.09.11.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 11:47:20 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v4 4/5] platform/x86: dell_rbu: Stop overwriting data buffer Date: Mon, 9 Jun 2025 13:46:58 -0500 Message-ID: <20250609184659.7210-5-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250609184659.7210-1-stuart.w.hayes@gmail.com> References: <20250609184659.7210-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dell_rbu driver will use memset() to clear the data held by each packet when it is no longer needed (when the driver is unloaded, the packet size is changed, etc). The amount of memory that is cleared (before this patch) is the normal packet size. However, the last packet in the list may be smaller. Fix this to only clear the memory actually used by each packet, to prevent it from writing past the end of data buffer. Because the packet data buffers are allocated with __get_free_pages() (in page-sized increments), this bug could only result in a buffer being overwritten when a packet size larger than one page is used. The only user of the dell_rbu module should be the Dell BIOS update program, which uses a packet size of 4096, so no issues should be seen without the patch, it just blocks the possiblity. Fixes: 6c54c28e69f2 ("[PATCH] dell_rbu: new Dell BIOS update driver") Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index c03d4d55fcc1..7d5b26735a20 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -322,7 +322,7 @@ static void packet_empty_list(void) * zero out the RBU packet memory before freeing * to make sure there are no stale RBU packets left in memory */ - memset(newpacket->data, 0, rbu_data.packetsize); + memset(newpacket->data, 0, newpacket->length); set_memory_wb((unsigned long)newpacket->data, 1 << newpacket->ordernum); free_pages((unsigned long) newpacket->data, --=20 2.47.1 From nobody Sun Feb 8 13:56:46 2026 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63A5721C19F; Mon, 9 Jun 2025 18:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749494844; cv=none; b=AU7AWEVj7qjlBMzL/3RzBniIRAbBIei9/6i2o6wwo/IIcWeRXUhjrEVnG3h0BdIGeUCxdBuDY0oparhaJMTliv5nEOOGZxtyAkHN9kQtOf8OPMC/7KJnnqiNMEZJ2qyZFPKkyIVJZjBNQuB5XFm6K9GU8EdWbII9Ln6Ndwj0kn4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749494844; c=relaxed/simple; bh=QBX0wKas8hMg8UqxUJo8euFBcQTuFEJmE6HLDNOpMw0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ftIwTBlJiGAi4kv2xsKAGqocm+ev8aTA9zoSkYRVvfKTsoFhR5t4Jl5+Ue/APXzf6ABApF/mhrUM9tH8itt0WDib76lhwnM22Dzejml3aSQ9YpvTyab4eR4UmTrMzAQF4DWrOe6/nqSsdi4bac2aywkaFACiimS2i6cWeI9DGV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QeRfN+GH; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QeRfN+GH" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-2db2f23f174so2677415fac.2; Mon, 09 Jun 2025 11:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749494842; x=1750099642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DDwrjOc2P0lgnjjq9Q/Gy/AuUSnuvG7kFTIq26PL/EI=; b=QeRfN+GHzOXOlXAnu1nVI2Pxjtg3Fvh07cSfvRFcqrtbaIPuSoM/7KpTwZrNRVx8dn 2i5pNR4eYvE5sQmstLLzeAfHVTB3NzcRUNCWyJbzDRIQic/WKOYLozwCYInj8/HtZoKb cg8TRpTy6pUb+48oeCndFL8hgs3TgI6554t9pzYwAopx6LT5+S7YSanOgoo/PDw/RNna qB7QV6wOUwnANuByjcFyEgRvoWidol1shFdm9Gzqbov7EDfEq9zmPgJmYxUNAB7a9Aeo 947gyDvekamFU8SbUVEGPTWzkirpKnuguT8J1AcRdszU0YKRJIq5aHafsQKSBVXaJZaI Mggw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749494842; x=1750099642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DDwrjOc2P0lgnjjq9Q/Gy/AuUSnuvG7kFTIq26PL/EI=; b=iValcymXMC9s/WOoBbOESPb6/3dm9ndQtLbnQE4E5WDDJw9/+p5m7yIdsNv9zfhE+Z S8JDwlnPcMKdyahKyXFyJEmb5O8ZwyhSQNSkACsk3XfOLUOcrahPBRx6qrJgKKY9nkFd HWjC6fPS2eClx3sMqmDKBNbHk5ittEEelz0hX+0Wf2ZwoYrcF2RbxsINMocsNRtwi729 PjNf6FJFJJUYYUbf0zL99uF0Sv8orH8jXEsIgfHKra170QMQJinh2011yZCDhI3vYCLe jRb7TQmeE+MvPbpO+qXVTda1jYtqU3zANotBHAmGxMHmwuamzy1W6pWzqUMi04kE/U8T 4a0Q== X-Forwarded-Encrypted: i=1; AJvYcCU73cvZDBCSlf9OYU2GsZIkRv/8om2tynNNEAKaG07Q8RhIrvr3C2vOVZaWm52vqNFQ4Es8YMKDkKUMGWIlTbVHcL4C@vger.kernel.org X-Gm-Message-State: AOJu0YwESP6jKViqezb6IX/xcm5CPBt7zuYUQPl8pAkvWTet2GQhrX4Z jqvO0f4E19AW1xdBfekpfMaj6NOjxL7nl7cfPUEx0Oeomd2r38L7BRFShgItlg== X-Gm-Gg: ASbGncttf3vqSDUXfCtWOeaYuLEAgFzvkjaCsUlIxN28PY9UR02V9ttD93IsF8TumVU Iz3l6jRXb/Ws89rNr3DkJsiI0oRHbeGj0WCn4tOY8HpbVMEYe9x9YriluJ9zUvUYz+CQ+SaxyhK 76skKwOR4iOamqxyLX8kKFCO2Wrslu+cZJVU+0c3FQhNZoka0LWF2MnHK81M7JAc5BlVpM+rscj BGiQphVtiXiYqQQExWQfXHWNjX2tzyVn25Pg9eurl3J2znZBhMziOw8np6S5sXD/0Rz/axs3xjN rHEZNXbhy8/40yhkUkYJ/go6/kIkHbOnGeWQWMqSCSHLtUXcdvAWrrjGHgKVMrNt5nQGvO4Z7D4 nonta6U4cK47QPmi5JQ== X-Google-Smtp-Source: AGHT+IHpMFKjrAoLHyAokS1ybpSw77ZOAastSRyqcWmpTaoQn+3gbXFKypDR5+nK2z6vkOX5rzaz+w== X-Received: by 2002:a05:6871:e806:b0:2c1:ae41:6b5e with SMTP id 586e51a60fabf-2ea008793b9mr8549297fac.16.1749494842300; Mon, 09 Jun 2025 11:47:22 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ea072e4b5asm2035950fac.30.2025.06.09.11.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 11:47:21 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v4 5/5] platform/x86: dell_rbu: Bump version Date: Mon, 9 Jun 2025 13:46:59 -0500 Message-ID: <20250609184659.7210-6-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250609184659.7210-1-stuart.w.hayes@gmail.com> References: <20250609184659.7210-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Bump the module version. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index 7d5b26735a20..45c0a72e494a 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -45,7 +45,7 @@ MODULE_AUTHOR("Abhay Salunke "); MODULE_DESCRIPTION("Driver for updating BIOS image on DELL systems"); MODULE_LICENSE("GPL"); -MODULE_VERSION("3.2"); +MODULE_VERSION("3.3"); =20 #define BIOS_SCAN_LIMIT 0xffffffff #define MAX_IMAGE_LENGTH 16 --=20 2.47.1