From nobody Sun Feb 8 09:29:15 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3BB31D6187 for ; Mon, 9 Jun 2025 18:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749493487; cv=none; b=TgP8e2f6xVyBrcUH4GBFpwOeKaq84AiUmPVrjVwvgliTIqbSLjbwtonMl3GzWPVCZUvDTc3FwcMZHUd3d5JebAHGOS4E+VLu+Hd9tu67E0WejVfyjeD7rx/O6dZButnXuiYyrEUayBtefzYTpLrEAOn3F4aTKwcRIgn244pdZtM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749493487; c=relaxed/simple; bh=hqqVwI2DtCjfh9orO/cac6PjLKpP78bMvl+SrAmC4zM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H602XL7g4x1dfc182WAXTAsBHttGaoNZ02EuaBnTKmiQItnFHwphMaGoh/QquTKqFkkojFoxQSrr7Vn+HDcSeJ3oVdVWYEuE0IM3Bi3qnd5wrZEbdWBvuKbKE0VIH16xhSTyNFwejR4SyLfE3vD4Zxw4QC2UPtBiWnN6EZva/pA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i7hFueSs; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i7hFueSs" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5599fLwO022679 for ; Mon, 9 Jun 2025 18:24:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=F2gwz9xWCvt M03RmugvtKUkXIvbzjxIu6DI5yEMCZHg=; b=i7hFueSs0hspbXU3m8LSLRGfgQ0 oCWVIaU/SC8Q6wuVbDWHMy0gWZRDhhhCCen+GqFlbdNB1mM3sJQfi32BAxXb1Rp3 5VIEtZaZeAharmseIr4Ofyb35rbK5JOjBZ0pI83Cqmsa1MtB16pftHmfbKhTYIgU A2mZh7YGzblRncTclgfEJik6uRxl3DVxLWB0a8IysK5uQbBuLikw6YyltzvJkb5S Lj83IgWXqoaxCIWhut8wmtvwNIb123aQm08VvrgDgYTquXGUvSvxlDSceY5LIPXz vJZE7JhMCgNYwaSaMMritFN/m0ypOiGA8x64mME0N6jVKdBjOCo9djK7OiQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 474ekppmpq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 09 Jun 2025 18:24:44 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-742d077bdfaso6583619b3a.2 for ; Mon, 09 Jun 2025 11:24:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749493484; x=1750098284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F2gwz9xWCvtM03RmugvtKUkXIvbzjxIu6DI5yEMCZHg=; b=HF8DZR70ATw+MI9ry0hPnZ2W1iHC35DXUyBgS7f5LaKixZe6lhWo2/mxhN7l1Bx3Fa 82YG9R/d8wu0vO2ItbDyVNw4+wA/nwUR7GnDLVAVD9Y6yaC9gMiNPtObo5hAAsr6PSVA pdmPp3IcJYXaaIg0QowZx0lnLH2o/mk+3Hpy9NRmEygr0dn26HfmeTrjjK5d4xMYoNvq qOKujmsAi70B7rbFRP8OUeePf69RotrAmWN6hii2qxD+P7fW2HULrmhVM6KaP7nZpIYP 8bskjXIj0ZqzW8Euyagd2/CWFriMI3Xi9aVH4tXyv5ZwkaF2gT7WeDIal6ZJPiTf1/7j o4dw== X-Forwarded-Encrypted: i=1; AJvYcCVOapDDEJTljuKCD1/nSlSqdwKbWTIwRb6MD8FVG22Igqx1r7DU0A047KpOY8th9XG3TkLRL/Fy++PyHeg=@vger.kernel.org X-Gm-Message-State: AOJu0YzcTA7fo1Zqk0k5vO7bOjCPAFJuTXWE/BjMh00te27u30JatTGZ U4mN8g7iyDDEPjYd4eQ4Plglw5j5INX+DREYoT8ZJAZZ3LP6vT12eHBFUGVYeXzl0PJZlR0nH5h +MiksDXOxvfmBW/j7VIKnmZYyQlpjjP4wSLLAaOpfB4D28Cg7gMxRMIyUSK363sif55M= X-Gm-Gg: ASbGnctkJcCL+fl5SPr/5MSDiR4K+ioQNm7VIY6N1/n8/kOPrXWJXJk6Ow03eIs/ra7 BKNg2qCmCcYY/3Fxq4zb6HjGWPdBp+5qk6sfjQYXn1PdF0aHTmJkW/ijo4m+k7d8BVCrO5vVoXx TsALe25QKtFUwKA2lu4Hex8tJukEr6HEl/sY0/ZicZ1FAg4nts7ZBM+DdWa+YhYqpaxTXgSV6dK yfotTVxoyDL+HqTDaLuZpa30di/RnVdTKXJN7I47LhbGkVLDO/uYRECv1JSEELxKWdmOGfeo7y8 KaqmgdzWPHaTvihRRewKQw== X-Received: by 2002:a05:6a00:993:b0:746:2ae9:fc3d with SMTP id d2e1a72fcca58-74827f330a7mr17505742b3a.23.1749493484088; Mon, 09 Jun 2025 11:24:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGE4XO4k7jfNXjeUp4cke4cx2uvEFDbj4Fl9AWPgXX5AvA95l91RUCPxIh1kKECvcbV1YQhTQ== X-Received: by 2002:a05:6a00:993:b0:746:2ae9:fc3d with SMTP id d2e1a72fcca58-74827f330a7mr17505710b3a.23.1749493483727; Mon, 09 Jun 2025 11:24:43 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7482af7a216sm5945104b3a.40.2025.06.09.11.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 11:24:43 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Dmitry Baryshkov , Rob Clark , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 1/3] drm/msm: Rename add_components_mdp() Date: Mon, 9 Jun 2025 11:24:35 -0700 Message-ID: <20250609182439.28432-2-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250609182439.28432-1-robin.clark@oss.qualcomm.com> References: <20250609182439.28432-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=JcO8rVKV c=1 sm=1 tr=0 ts=684726ec cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=xqWC_Br6kY4A:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=vt6ngUXDG6_mDpkR7fcA:9 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA5MDE0MCBTYWx0ZWRfX23fqshhAblxW ZC8kU/+IDLN7QvBIBjZzO1889gh2BNGjvWdWjRAHRzvvqcEkF3eXoUIMaYjkDLetsBcYtXv02da +N0p/XN2bLs0BzWjUCpUYFEbiGxgCYV0Z6bYX1qPq/mP3Ts8aG97pqKsFXyzL17TSVMvViQc5+R iZ61ztDZ08IGDmL90xdVexfVNnvK+QwWAzBuTXvwrgThmWTFt+JJHKzSoEMMx81OE68Ik3B2Zbu SXL7FMJeSAqFuadM9ko21GftvKnsFcqtlIwEfnfAKHLPXc3pu2FXMcMnz5KXEAkU5lZMTlLLel0 35fminGjAX0E2gPwwTnWdbOw4vMNs+R7lNfCxOoROj01OSbZo7zp4dnkrVGyHCUuyWBp7Oe2JJQ vrQYH+MOKYhWv3vBb22QG+KSxIKMyLaOGVVLyZN8SBWyQmUWCVqiMaXxxMeyNAP8x2zb0R1R X-Proofpoint-GUID: NOWTajSWfL5ROW8rzbSrMKqNgHDgHjvz X-Proofpoint-ORIG-GUID: NOWTajSWfL5ROW8rzbSrMKqNgHDgHjvz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-09_07,2025-06-09_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 priorityscore=1501 mlxscore=0 adultscore=0 clxscore=1015 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506090140 Content-Type: text/plain; charset="utf-8" To better match add_gpu_components(). Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 710046906229..87ee9839ca4a 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -852,7 +852,7 @@ static const struct drm_driver msm_driver =3D { * is no external component that we need to add since LVDS is within MDP4 * itself. */ -static int add_components_mdp(struct device *master_dev, +static int add_mdp_components(struct device *master_dev, struct component_match **matchptr) { struct device_node *np =3D master_dev->of_node; @@ -997,7 +997,7 @@ int msm_drv_probe(struct device *master_dev, =20 /* Add mdp components if we have KMS. */ if (kms_init) { - ret =3D add_components_mdp(master_dev, &match); + ret =3D add_mdp_components(master_dev, &match); if (ret) return ret; } --=20 2.49.0 From nobody Sun Feb 8 09:29:15 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2765E21CC47 for ; Mon, 9 Jun 2025 18:24:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749493488; cv=none; b=DCBU6Lzg4GmSUGL01a9/HfLjhc5KzZvXb25F/42b0zdydl6cjk2+kDT4Wo0SwrG7YNsxbZNQl1rUqKw66O7V3g2JojtMJ3tQqQ7vRsixSJ3KwrAgjKswvppLEI37qvklwBxmW2ti6XmFHuqTueHAEKhNaOMyJlvlItbAnraiXcE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749493488; c=relaxed/simple; bh=Nw5R6/u/rNV294XNdLAIM6gmpeegWVncNwNovOkszVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u7IK4nQjEc0WiYj0IPFYFdqJtYhXnn3YWtdsAvcLiUVvARmVIEmRiYwvwd75bqz+PPQ4mBGLW7VxHNNJui2ftsuopaGY2rn9zZqjSl4dk4p06wAE3E6y+DVOGlGmxoQj+Xil8O5UQBSiuJnQJvSzJKYEAn+vm2e2b+gRTT/aiis= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=camXxapc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="camXxapc" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5599HdgY031223 for ; Mon, 9 Jun 2025 18:24:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=wDKSo0B4Owx KLMBW6S+ptTFSRqNPn23bmUpGk8ww0sU=; b=camXxapca/C/5sga8qhF50Bxhjt SNi9SsTxyiRTTSRo4DiMOYHTmJIyznRy+nIm4KDSepuTlI9zI2V/Nv1SVFme4ppy xGz6ND1y8MjBFX+E/YWoQVeYv9Yi5jrzitoEX5XnxIzhA2bzI20f5oaJTpcNC9rK x3pdqu65IFoqIuQHNc9Dfmb7+el7sREE6HY/Fevb5kpdPwJCPmCqDcpK0g6M1EIu Lzbtj/pE5qH640sgzDdUEBAAKrudRZOEwJagqickt5+q4D0xvUALIPxwVtFBWkWq cx12eOXdsfHOly3DJmTLE1pBUmZj94gUou5T9GEEcRgQg5nxkI683CZ9GPA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 474e6jepn3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 09 Jun 2025 18:24:46 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-235f77f86f6so30116495ad.2 for ; Mon, 09 Jun 2025 11:24:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749493485; x=1750098285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wDKSo0B4OwxKLMBW6S+ptTFSRqNPn23bmUpGk8ww0sU=; b=EUuFEd+j+meKWJq8aZ0jNOShtR82ZuZXF++AABzoYbOF9FN7ZM4HcDpjmjPGn0QpPt TAQITyClwMIYDn2R+ycKMkVrqtHMzmCsaTX1TCJXTOQCTkl9YIkjSgCiREdHkjoRZU/Z 2uzFTKVsMUvLF79jvnKoG4lR+Qx1m+8/HnhQ3GSMlwDyKXwZvqdwyyoDIfptt2zHY2hX 0iWhDcZNLWwr5VZmpnQW0XFDChDyfZ9rxXJPMRMNldsOG8sW3J5T5/bVl9IF8Kmmesbw 3hLFlXbfVOKZY7QOvedd5wI7QfRDEq90uncbyd6duRJsvM+fYEuS19e3OGG7n9YYkHkt OUog== X-Forwarded-Encrypted: i=1; AJvYcCVzisIRL5v5F6aG09ThCSZYSb95vG7BT89P8rAp0/+Kl+UjD5N1w4smPs6CFptlJR6UhNmyRaWmOW9LJvc=@vger.kernel.org X-Gm-Message-State: AOJu0YzCs4bTSL51ResRK09vOBRGtuaZ5CTNaQWnewTDlI2pTMrVtOWr 3gnKVpTfuoNAvK1dXxPIcO5IZga7RL8CbRil6gbZXthJYc0zlyw5gBbRXaC7QDQPGcrOWfyFaJy e4pa2RwovwhSCpSDZUvzC/HVipdi1sEt5Hnb6dCYUZoOpqlLTU76gOibVbA3CPDqSYqI= X-Gm-Gg: ASbGncsGQl2cV3Hr1IvU+2zud+YHozpab3tHsf9Gv3rSSh9HWRtfwmM1FFC7AqiLI53 R/j3GUuHvdWLiacIUpireQFfy3F9s8qYdcydUgSdSUG6NNWVEiUqXloV+++HczoUqcqxbJlPFpe jxrqtQJzjAMYfEqmW3wdahb8LJSA2GeZYEPhzWh+0oKTnvtiOlYEelAVTLxwd9tF0avaq2mB1Ls 3jbn9QqPtFPE76lORUrRyLL1fWwi5oHYiniSVVXf8gK5vk//VYIiHRHe/oBfTPSbuoMuq9iTNFn zyDT52hwhgHdjjA8LYRTkg== X-Received: by 2002:a17:902:e891:b0:235:f55d:99cc with SMTP id d9443c01a7336-23601cf68cemr203520005ad.2.1749493485377; Mon, 09 Jun 2025 11:24:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2xRWfunGxYuE2OM2dbnnHB5b46Yn438TRpEDL3+xKAueWZPA4Xlpunoydd121jW5MCcyDKQ== X-Received: by 2002:a17:902:e891:b0:235:f55d:99cc with SMTP id d9443c01a7336-23601cf68cemr203519705ad.2.1749493484921; Mon, 09 Jun 2025 11:24:44 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-236032fcea0sm58136435ad.103.2025.06.09.11.24.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 11:24:44 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Dmitry Baryshkov , Rob Clark , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Dmitry Baryshkov , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 2/3] drm/msm/adreno: Pass device_node to find_chipid() Date: Mon, 9 Jun 2025 11:24:36 -0700 Message-ID: <20250609182439.28432-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250609182439.28432-1-robin.clark@oss.qualcomm.com> References: <20250609182439.28432-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Id6HWXqa c=1 sm=1 tr=0 ts=684726ee cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=DSfSXdSXGXaEfb08ihoA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: plucRCxDdsHBQzt_bWJX0ohqzpyPKOyF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA5MDEzOSBTYWx0ZWRfX1xLYNEhFsO36 9rYg9xOd0hivQAYSQEj0RWdHRTOym/djBlnWy5TtqC2BWsJwMDwcGPRrLKOHvmIw1G3sFZyVmIs RhMRXS2UXq0mNX+2dbaavl53lM7z3uaTJc9qkbf/psvy1zrz9KldXBKIihc7+bWmhl+aPv6Z4YQ wvvFFmGXG7liPdbsHMwisEiq8rC2C5v8dgsdHtxtQ1vBBpG7jJJEqjxdnDG7mL8C7hiN/SBWmlu jVRO3rTn2v9sx8JsVhJhBM2JHkC1VH31pnI4/88UXY0J9z0tnD8Me7JIGzEpjEcrCAnwyn9Gg0y dhP91/QifJMOVzyCvQOvxvsI2frZe1LEqGbArmiNSuVD4vhqFoywLwN7UU1KvisUYjmaCNOXL+Q 5B7VjsjA/HqUM6BFOGIU4+clGi7ElAABqgwoqeaMPx9x0wVFQWMh1KmB0fAIX6n1RoZB+6Ew X-Proofpoint-GUID: plucRCxDdsHBQzt_bWJX0ohqzpyPKOyF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-09_07,2025-06-09_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 clxscore=1015 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506090139 Content-Type: text/plain; charset="utf-8" We are going to want to re-use this before the component is bound, when we don't yet have the device pointer (but we do have the of node). v2: use %pOF Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_device.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/m= sm/adreno/adreno_device.c index 6b0390c38bff..778e6ae7f137 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -133,9 +133,8 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) return NULL; } =20 -static int find_chipid(struct device *dev, uint32_t *chipid) +static int find_chipid(struct device_node *node, uint32_t *chipid) { - struct device_node *node =3D dev->of_node; const char *compat; int ret; =20 @@ -169,11 +168,12 @@ static int find_chipid(struct device *dev, uint32_t *= chipid) /* and if that fails, fall back to legacy "qcom,chipid" property: */ ret =3D of_property_read_u32(node, "qcom,chipid", chipid); if (ret) { - DRM_DEV_ERROR(dev, "could not parse qcom,chipid: %d\n", ret); + DRM_ERROR("%pOF: could not parse qcom,chipid: %d\n", + node, ret); return ret; } =20 - dev_warn(dev, "Using legacy qcom,chipid binding!\n"); + pr_warn("%pOF: Using legacy qcom,chipid binding!\n", node); =20 return 0; } @@ -187,7 +187,7 @@ static int adreno_bind(struct device *dev, struct devic= e *master, void *data) struct msm_gpu *gpu; int ret; =20 - ret =3D find_chipid(dev, &config.chip_id); + ret =3D find_chipid(dev->of_node, &config.chip_id); if (ret) return ret; =20 --=20 2.49.0 From nobody Sun Feb 8 09:29:15 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61FCC21D581 for ; Mon, 9 Jun 2025 18:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749493491; cv=none; b=lX/XmT0+Z4UrP19Ipp6hgU1DXFw+rn9mCNXGchKUKpnVDyblmCDjiPdDINYyM+iPTqzlnTdskX0nJNAQ/PnZ1C6leQnCETs/28v5UGy3D3dqOjYDlJnzVfQLMcIcMGAh+0ChtnJiY9TXRG/FOHIHsY+LsgTNnYFeCTFHbKx1cWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749493491; c=relaxed/simple; bh=2Yz04CrS4eDfH+osQ1AYNYmCh+wB/WulKnvayV3buXE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GGmA8waGGx4O7vD8Zlp32npfLuZwVQIov5sjhs1X0F86WO1M92MJaZmQ1Z6zh5LBxWoT94PNeZIyX7ps0i2kLdXEvLgAnrSkc7Ey/Y9wKwOpO/CB/eF2qFhhGhDDXZGsSQ5XymEqEuQCa3Y/JCP8A/l0RKOXfS4Uma4JHyYFe8U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fMl/ATCo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fMl/ATCo" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5599WeH7002402 for ; Mon, 9 Jun 2025 18:24:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ecf/gs5q5Dw zFWtmUtIrh+h+5TTwNY0t6ORkyO3PRW0=; b=fMl/ATCopv81RuOcttIfLT3RGCV f2aFpC33dDon0kLyS+40JQ4W5Pm2bdSaCyaSfeO9ej6Q5a/5VZIxHJuEVE2pZAHx 7fOEASnEIUe4EYRLaPVXWGZB2Nauq9gBZBfCoVlbceuikUOLy6EkajeRQmeXwXue qLnoGqBfkKECKtUtakL//L6/ak2etxDOwEPtxJhUDc2Poi9/Y6CvkSk60tq0rrnx c3bJ9JoRKMgsUss2RGWYKm/eLDxF6B3PoeJg1owl1ALvplNrQXnYIMmXLRlR90JQ ZDYoGJVWI6Tzvp23vkPEXxQpD0UJzxEs3HlxlTZyWKH91YENvDWwykoKyDw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 474dn66t7c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 09 Jun 2025 18:24:47 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3132c1942a1so6533538a91.2 for ; Mon, 09 Jun 2025 11:24:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749493486; x=1750098286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ecf/gs5q5DwzFWtmUtIrh+h+5TTwNY0t6ORkyO3PRW0=; b=Ec7sF1/pRGdLx38+iubmCdLDaYi0PE0aDN9P8APEUehhw7LaZdP5Fbtfyq2KT7jJcy DgGfukM8T1LpHczH/mIedR4jXRWnhVA3uXMiW7ANyNFM+tWs+aWuePBDCNZcm7/+ZiHa hi4NNtWoEB3hdBSm+5EKpICzyJrsfsETq6U2vsRVCyhCYVHixFP7HuZ57y1U2Xr+zBiz Ig58QdRxmwkNZCRwotIfJNPH23dtqhHGmJG1c/t0HXnQ9pOXp6HVhweK+/Z3tgfmEKJX dx7+WR+dkyZpTbzwYW/zGrUMtX6mjBp35oojX4+D70GWlRhypAV2VtcdRaPitSWx5lMX sQ7g== X-Forwarded-Encrypted: i=1; AJvYcCVsaa0ki/AYG+7btOES1KyeAAUBrxITmlWF71u2OH3ioJcne3X4qpaijigpmWlQ+ETzR8F1RyUNxSl+7wg=@vger.kernel.org X-Gm-Message-State: AOJu0YwRUgVaboXSuMXnpA6HJKMXTqrHEU+kJ2biCNzkanWqgCD5d5O1 ArYlQYy/YCtMa72R1avZf1nHQjiRj4iRRdBnSOXfgFC/9dFr5yrFthRYbfTy1r8RNtEW5MVCVIE yjxI5kfGQqG4rCamYI5a/BmXYzUMJqP8W4HflM4yTJDdAXJ09p7Wa+TPctBr8LI/D3oQ= X-Gm-Gg: ASbGncu7Rb56a6O+74l5wOyyzdP68Zh5pUUAnE2NAYBjobhavS4r5lTKIHXkabMuApl PhRezQhLSacL3bXutT+3LVJsJYRlcj96VQ3pSDEobVZBFM6BmvTxj6+C/1vyZGZgTiIanbMvR6t ojWmEB9elhxx1sezWPKZNcumPJ4I52XodZI/lHEsvmEfdhh7hY/mQadAnB4+JFNomgIsrNRc9/n t3On2Inlq60C8FhrZVy92hwqgxleQ7ed2hBoQ0GMxu5/Ddxt2OpIUXaEkHyE/rn7UlmHYBQLJ31 VTkK4AjsS+QYCLQ4PQwCIg== X-Received: by 2002:a17:90b:3c52:b0:311:ffe8:20e2 with SMTP id 98e67ed59e1d1-313472d4297mr20221926a91.4.1749493486580; Mon, 09 Jun 2025 11:24:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEigB0QkFd2i+DltDS7spF4Aiz+S0w1cLE1zE97QoFV7hOhFnk6CT2wbS3XvV3KokxiU/HvdA== X-Received: by 2002:a17:90b:3c52:b0:311:ffe8:20e2 with SMTP id 98e67ed59e1d1-313472d4297mr20221906a91.4.1749493486236; Mon, 09 Jun 2025 11:24:46 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31349f32c96sm6630688a91.12.2025.06.09.11.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 11:24:45 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Dmitry Baryshkov , Rob Clark , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Dmitry Baryshkov , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 3/3] drm/msm/adreno: Check for recognized GPU before bind Date: Mon, 9 Jun 2025 11:24:37 -0700 Message-ID: <20250609182439.28432-4-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250609182439.28432-1-robin.clark@oss.qualcomm.com> References: <20250609182439.28432-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA5MDE0MCBTYWx0ZWRfXzia7DF8GyTnU TdBiQcDMqaHIO2fCpVX7MI2mPaMMTeRLeHgfbHdHQjhycb914ypC3QHurhkYbvHrlEero4s6cHd cKv7PXJRn8hvyScYH7P1yhYOjYDGq72XUGrlES8n9+Dnzl73fBqmbBPS3HxoUGVD6TMs9Hw332h tSK+G99ETt3HJW5H8uyaVDZtS92GQh5HUum2K4NoUUrAy+cm5xrtAvy5Hq5aK74+8PeukXXgQjL zqfVxjeyXBq5rYid5RCsLXDCKZqnGIr02CkKtjs2vNiY3b7+5uuZ+MoS6J/Mj2l1T4qqLPmEwZ0 ILsQMZZCCmUwNEFCygJR6Ixkoa+7/50G9GqqkuLI3SuFzwJi8PTv5Y7U9UxM8ibvlOdrSNWUaF/ 1YXyhZeuX4jaxhBNVB53FVZV0WY7JFLuy4TgLjogFcWhs8xcQ7gKCWapmIVAA01V5GvkgxNw X-Proofpoint-GUID: enAbKuCxS9x-EivhnInJYXzDDE2mM0GY X-Authority-Analysis: v=2.4 cv=FaQ3xI+6 c=1 sm=1 tr=0 ts=684726ef cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=xqWC_Br6kY4A:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=4MAclHcQAAAA:8 a=KW-EWzdukDj2kg_Rd5wA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 a=6vtlOZhwcO7ZS_iRoh4Z:22 X-Proofpoint-ORIG-GUID: enAbKuCxS9x-EivhnInJYXzDDE2mM0GY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-09_07,2025-06-09_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506090140 Content-Type: text/plain; charset="utf-8" If we have a newer dtb than kernel, we could end up in a situation where the GPU device is present in the dtb, but not in the drivers device table. We don't want this to prevent the display from probing. So check that we recognize the GPU before adding the GPU component. v2: use %pOF Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Tested-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/adreno_device.c | 29 ++++++++++++++++++---- drivers/gpu/drm/msm/msm_drv.c | 2 +- drivers/gpu/drm/msm/msm_gpu.h | 1 + 3 files changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/m= sm/adreno/adreno_device.c index 778e6ae7f137..0d12454b1f2e 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -178,6 +178,26 @@ static int find_chipid(struct device_node *node, uint3= 2_t *chipid) return 0; } =20 +bool adreno_has_gpu(struct device_node *node) +{ + const struct adreno_info *info; + uint32_t chip_id; + int ret; + + ret =3D find_chipid(node, &chip_id); + if (ret) + return false; + + info =3D adreno_info(chip_id); + if (!info) { + pr_warn("%pOF: Unknown GPU revision: %"ADRENO_CHIPID_FMT"\n", + node, ADRENO_CHIPID_ARGS(chip_id)); + return false; + } + + return true; +} + static int adreno_bind(struct device *dev, struct device *master, void *da= ta) { static struct adreno_platform_config config =3D {}; @@ -188,18 +208,17 @@ static int adreno_bind(struct device *dev, struct dev= ice *master, void *data) int ret; =20 ret =3D find_chipid(dev->of_node, &config.chip_id); - if (ret) + /* We shouldn't have gotten this far if we can't parse the chip_id */ + if (WARN_ON(ret)) return ret; =20 dev->platform_data =3D &config; priv->gpu_pdev =3D to_platform_device(dev); =20 info =3D adreno_info(config.chip_id); - if (!info) { - dev_warn(drm->dev, "Unknown GPU revision: %"ADRENO_CHIPID_FMT"\n", - ADRENO_CHIPID_ARGS(config.chip_id)); + /* We shouldn't have gotten this far if we don't recognize the GPU: */ + if (!WARN_ON(info)) return -ENXIO; - } =20 config.info =3D info; =20 diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 87ee9839ca4a..40eb04bab35e 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -956,7 +956,7 @@ static int add_gpu_components(struct device *dev, if (!np) return 0; =20 - if (of_device_is_available(np)) + if (of_device_is_available(np) && adreno_has_gpu(np)) drm_of_component_match_add(dev, matchptr, component_compare_of, np); =20 of_node_put(np); diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h index 5508885d865f..56bd1a646b83 100644 --- a/drivers/gpu/drm/msm/msm_gpu.h +++ b/drivers/gpu/drm/msm/msm_gpu.h @@ -729,6 +729,7 @@ msm_gpu_create_private_vm(struct msm_gpu *gpu, struct t= ask_struct *task, void msm_gpu_cleanup(struct msm_gpu *gpu); =20 struct msm_gpu *adreno_load_gpu(struct drm_device *dev); +bool adreno_has_gpu(struct device_node *node); void __init adreno_register(void); void __exit adreno_unregister(void); =20 --=20 2.49.0