From nobody Sun Feb 8 11:51:09 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE131217654 for ; Mon, 9 Jun 2025 17:04:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749488691; cv=none; b=PjuvNQSIT3pS3Nl59birq9CZzCOg9iuZZAt/Q4nswhR+41YCSp5TkoyjNW6VWUgwa8gDkomm/R/z8X4D4s9j4APJjviEskxJr6yd78qYuZ+/3RQjkg131xdf79rDO0NiVl0gzFYiY/PlRMKxpqrKOw7O6kD/Cs92GEvZlsEn1ak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749488691; c=relaxed/simple; bh=hqqVwI2DtCjfh9orO/cac6PjLKpP78bMvl+SrAmC4zM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sePmv2z1/CvWW4C81vgh49+xXeOL/EaRFOIcjbaEvkz+A4s7CfZ7tnYMFXBdG4cTT/4Kkfb1qG8ZJXxGSkLCMRwd84jJbdr5M7pZx+0eJPoQE2eTPAcUD+YjcXuViKAKGLifL3LQHHIapSmYvnI8xJvR+4DSFdajyttUm5xSXdI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DFmIYHui; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DFmIYHui" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 559G2xn4003755 for ; Mon, 9 Jun 2025 17:04:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=F2gwz9xWCvt M03RmugvtKUkXIvbzjxIu6DI5yEMCZHg=; b=DFmIYHuiFIm2j/q4DYDF2lOaPG8 vjM9yH/w87pXIYloXTsVEv6twpb0jWJTThbJ5MI5E0qF62wKbc9U7Fp0TDtjRWLc wCEEtwHQRq6vpOJx6QP1AmbYLKWCnG9k2IvJ4TuLCy8ZhifcLUjKNQxj7pVJwbYP 4Yegyxruw4YrAtOdmVGWabtnkku3OHKY891DhWSrI44pGjQovrwAIGino3cb8xWB DDhYSlIbQB0U9CXFbyd3t0/nctrNrKfXZ5voRuN1SyCpELXsjGJ2PDqh8lu2tJDP 9X+JdtTE1vu6G8XfCMatQ9gTnWduivB6yBJFxKfvtkLVbqz+joXoCu5Heuw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 475v2y1f61-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 09 Jun 2025 17:04:49 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2358de17665so42895095ad.3 for ; Mon, 09 Jun 2025 10:04:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749488688; x=1750093488; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F2gwz9xWCvtM03RmugvtKUkXIvbzjxIu6DI5yEMCZHg=; b=iCg86Mq14F0ylPbgi2lk1LnF12M9+MWkY7wMwtV3ttKB3bOkov6IrxfXoHQzcBmR1J j1tCguGRt5n4xLR7aUaI9KJWrr7bopedUZT1V0qvTbthSUvqeOlIgHr7A50dJbWMKg1k vvzG9l4AHFcPtVUmBBYrDVx2Ah2u0EyqEEfkzv5me3ULfg4Lsx77ov0E99KqFdLxY4Hk ps7LjyFtQxC0iAbAqwiQMnIutI2S98F3NThImzirBTJr1kN6sb4B+oG0KBLQp/VpPIJL jzovQfXLpDS+zv1E88TsDP26iNQ6giZt/jHww54z9QTIqPVIjqzGAMKDwVboNNAJN88o QdVw== X-Forwarded-Encrypted: i=1; AJvYcCUNHCay1x7g1GFSER37bq7Lu0g6G0tRkofjGNbj2kww83+gnEbuyxriH/tchMwsa7wPjzHuE1Y4e3xlFAg=@vger.kernel.org X-Gm-Message-State: AOJu0YweX586OVWsHO32k6zpX6A1SR0fKfJ+N3dE1TJ2juSMrGV75fJS VD2b4S9DiCmHouCnD39Cogw1coTFpWDUaN0SpiH7fFuN+95inloQb9cEpXXIqMff8TRACUPoRNh T/CotHglshoU4OGWviWeIjsUJ1An7tdSHMpdJ2WUeEyiII0tkPc+yaPzvIECIoZB7Pis= X-Gm-Gg: ASbGnctxQX9zGlh0MD24PEckKDod4Ane1+1s+pAwfPIsrf0j5Wm3iFibLbUSenNFv5I k8VFoViBOgSei57F0i6XYS6pFUCgFdOVMYmMzckNCy/COiuks6Q5n0FVXyfseURl4uigCQqXHaW nUbkXXNRJiu6xTiJnOKqZGW1DlgvmRXbcml0gImYjSTJX+PAkmOaC/V+8izhrDo8fGXO9AnY2XD 7Tvi5ZvbDSjB+utVVQVbxb1Bq62FDpTCswBzS29HDhkhYTfAI2YNpx9VHWgCn/kfUYdfm3qga6e doBNrSkN2cYu3woT2kJh4fVndKI3TpPK X-Received: by 2002:a17:902:d2c5:b0:220:d257:cdbd with SMTP id d9443c01a7336-23601dcf348mr200552555ad.48.1749488688248; Mon, 09 Jun 2025 10:04:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6Cia52Pz9TP+vPUc/qxfkyKQnpKKCfw3Z7/NYylirl2PJBjN0RgEB3Shvrl9SsiqWE2h2gg== X-Received: by 2002:a17:902:d2c5:b0:220:d257:cdbd with SMTP id d9443c01a7336-23601dcf348mr200552095ad.48.1749488687819; Mon, 09 Jun 2025 10:04:47 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-236035069f3sm56821685ad.231.2025.06.09.10.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 10:04:47 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Dmitry Baryshkov , Rob Clark , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/3] drm/msm: Rename add_components_mdp() Date: Mon, 9 Jun 2025 10:04:34 -0700 Message-ID: <20250609170438.20793-2-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250609170438.20793-1-robin.clark@oss.qualcomm.com> References: <20250609170438.20793-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA5MDEyOCBTYWx0ZWRfX7c0LAbCASg+G Nj1g2rUN0poJIqsxCZPp4NHrYpTHgkzEMvKtaUE9ToV/2uzmrvloi/3M9X5HBIAsX7/B30DJrbn k//Lzy+WP0PQTqQQZLdMgXhPCXotIHo1sTLBzH/cfBtRGg3yCEbbFS5Dp5H1kamK3fggCO7ysIb /+aatu+4va1dqs0iheLcdgTyue50ArJoJoTr+hCkkwlIaNOkmy+HBrMWbxBfxz2Rf0mQjSlMI5q XooEsJR0O+5PWQQ9JFC99SWOS47sIqSp8E5PznI6Fz971vc2w7hIMncJjU1ousT1puliB7QtmfS t8SefSpXoK7sjQDJiwvmB1i/QLIvIxA5KDiQ+4VZDiiQaHmPgs9cI24pp5zGIWV07OCM+gB9lTF VGtcQ3sfsqypz0NSKeYJZH5x0rtjG3zHC8e4NIycE9eCn6GtATtPojyWZgsgdBwWqR3Bs6uq X-Proofpoint-GUID: XCMVyzYIKoOJPa4JmwsEItEUore2DlAX X-Proofpoint-ORIG-GUID: XCMVyzYIKoOJPa4JmwsEItEUore2DlAX X-Authority-Analysis: v=2.4 cv=f+BIBPyM c=1 sm=1 tr=0 ts=68471431 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=vt6ngUXDG6_mDpkR7fcA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-09_06,2025-06-09_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506090128 Content-Type: text/plain; charset="utf-8" To better match add_gpu_components(). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 710046906229..87ee9839ca4a 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -852,7 +852,7 @@ static const struct drm_driver msm_driver =3D { * is no external component that we need to add since LVDS is within MDP4 * itself. */ -static int add_components_mdp(struct device *master_dev, +static int add_mdp_components(struct device *master_dev, struct component_match **matchptr) { struct device_node *np =3D master_dev->of_node; @@ -997,7 +997,7 @@ int msm_drv_probe(struct device *master_dev, =20 /* Add mdp components if we have KMS. */ if (kms_init) { - ret =3D add_components_mdp(master_dev, &match); + ret =3D add_mdp_components(master_dev, &match); if (ret) return ret; } --=20 2.49.0 From nobody Sun Feb 8 11:51:09 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44F341F17E8 for ; Mon, 9 Jun 2025 17:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749488692; cv=none; b=a+4PuqiC+u64QDsJi/xDSCOWTNcTIr5HyPRFWg89I2Rf6AzLNM3f+zYJdWfmELs9V/pC7iYDj7gcgmOokqWzJyZihCt3xlFWv8vj+5/4/D3FjHc8vv/VpngzzzrdqZm9shZlWImscg/x8cV58u2Fy9fGZWHtLmGV32/+6l/UtDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749488692; c=relaxed/simple; bh=crq1IlqnKk3Vke1cuqo69ya/rFBgSDJLDgfHj6Dz4PQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E1o3Rv6U5L3oqHMFP78r2dHhzXZLtYExiZ4FUHfIT1qVs3A3jxG4vGZiXc/gvRjvbCRMV/RdcO+Hf/E01/cDk9MLYWx9EiCokF8Ba+/MMPm7m+piGUnDOOcaawj9ucFqCp2G37TQ8LAz+kqP/ujXaBporEMS/12s+yArx0ZJftU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jFlIHAJW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jFlIHAJW" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55995v7l026990 for ; Mon, 9 Jun 2025 17:04:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=6W/371YKVn8 zY+sgrwBLaaDGncwtCHPm73vufdI0Knw=; b=jFlIHAJW7s0p0FYHzBnfKk//Jbs VM4Z6p2u44RLC8bDfVfumcgJQRvycWQFi4JH3/ojlWcq3nbke/Kr3fLJz+vbDx15 8ZIovZEa5E5KuF2ZmJ78+jhhfDzPq87m3cYW1YFJqCnzyMP/364oP1RD7faHPPqD lbr3YPuX9qrJNhrJLeJ+uUmLbFG+iqJFVY2q3wCbdNSTBCp1aUzicjn3ZENPWpy6 GKitUW3DlS7KMfA08gPznUeCUBjAZKd5MEaIexUl+hMx9nzPaz1e9p+Ejk7UE3RY /qf3Bd9zRoRuwjmqJb3hikSgbW+C8KSl+4/x/0cn1qqOqTsZ1derLMC0bgg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 474dn66mdx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 09 Jun 2025 17:04:50 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7377139d8b1so3709397b3a.0 for ; Mon, 09 Jun 2025 10:04:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749488689; x=1750093489; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6W/371YKVn8zY+sgrwBLaaDGncwtCHPm73vufdI0Knw=; b=hUtreilDdxsKlr6Bzq5h9m5KljolfDFyT/PIqQyOmoXWI+PdwNA/xVXIpyWHokwsi+ eTwZ+e2eW8TWGHsyAChnPXP3MLhPyYIGKmi4venVyUgJLf/91vv1gbekiOcF+Zl00usj tonFOyUM+pNUptA0LTy3KYr54cWXdOz8cEFL5+/6wPYmpyxZmfvEg3icYIAFbfymWsnO k5Trsy4LsIbTWDKAT0aHdvtjQNvLpx6V6H5SfkIORE9gcupMGVL9dMHAD/4tMAfdC/24 dHhd7dhWMlvf5kh1X1EIIw4pecOJc9gFojKM8fiQmW/oLfZTkMDoBWYZr8VedVE1/8pv qOAQ== X-Forwarded-Encrypted: i=1; AJvYcCWPRqvmyFg33rOJGROKfgsqWFFO/MJwGVVQXYPBTb7Fb73C2uBU1pGnNppqDjRAwV3cCST4e2iAVbprHuE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh+riHsjyY9M/YHZMjRTAOEuPs9ycVWkYgwTTH4GgQ85ZPAsNp V9vOKq4cRmW2qTUR2G/PE4ZkD43wz74SPclVKKRxqBFp9ju7vxjQTxTyQSC5QcTUw39nXvch43f tRQh4WmI0nyDqD1Ddfr4Ecmjh9bN32J/PpJIlw8Go/WgsxFDqk3Y3W05zMOuuzLHqP2g= X-Gm-Gg: ASbGncvSCtfDn6H1sgD2RL+IXS0Id+/JnACymxAGI1Kd2EYgqEib9mT5nij0cNg19wT kAMEhqte/+t9xhe1px4urlB4fwFtELzx6LTtQVaTzxG7WmEjSnYea8a+a+sM8M7zr7LTNKWt/Wl gZW5ruo5tUCa6Ncz/vJbekgWVh1L+LLrZKy8vm8mPPimcM1nFT/cJrvetX3bI2T/jHFDWCSxxkq B+aJdyLWWqzMSc0PaF05RX/1kHHndfxljCZdnQJyka3vrzXqW03My4C1Jqgn+5lZoTYSiDeHoar AO6zs/oSfoHGlXXPMGS+OCLbrrg6PGDL X-Received: by 2002:a05:6a00:4f8e:b0:742:aecc:c46d with SMTP id d2e1a72fcca58-74827e4e9c7mr16970843b3a.5.1749488689473; Mon, 09 Jun 2025 10:04:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEVMskIvufXApiy1mvHcQX0CnDdei1oN4pY7QtQVLahbgeU0gQD7OlQZ+oMMskVwE/QXOj6Uw== X-Received: by 2002:a05:6a00:4f8e:b0:742:aecc:c46d with SMTP id d2e1a72fcca58-74827e4e9c7mr16970818b3a.5.1749488689086; Mon, 09 Jun 2025 10:04:49 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7482af7af0csm6186677b3a.62.2025.06.09.10.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 10:04:48 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Dmitry Baryshkov , Rob Clark , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Dmitry Baryshkov , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/3] drm/msm/adreno: Pass device_node to find_chipid() Date: Mon, 9 Jun 2025 10:04:35 -0700 Message-ID: <20250609170438.20793-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250609170438.20793-1-robin.clark@oss.qualcomm.com> References: <20250609170438.20793-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA5MDEyOCBTYWx0ZWRfX4lTHavqCTsaN IHskPBvtWXi4tmevM38pkFMyyIxSpujOooNwp0+vPYF08QwE7na+s0vh2CpIMrzikPstkhPfuym qekHcpf50wVYHuGDVdtuyNxmSXG/pnAs0CIAigLY5MwRngHPi292eXdr+HygpBP7JTxHGy+276s 4+FcJE37E3HRNjv3KM3Vc0ktQfoKuk1uXrkArYa5TdoEqBQLfqSidoTsNScE9AVpYnwMaJRtVJc 0vlG/bG5pVRl3law3At2u5gZ3UEyLCt/FPJRmIrw8rjPVCucEHdwiyGdwopWZazmFIt+OKROuc8 molxoa2HxGtvdwfoGdhPpB9pNFn0XVZOLNTWKGWJRz0T3LArVXhSQzG6oLx55+eXh3kElIKzplB T2KkosCDIg/3U+cKWWl+FMFWeXnXM2eL2Zn11taX0D1p/tMuJzzDM7K+J+2h2hdaTy83Y7O6 X-Proofpoint-GUID: gbrzSIvllkq0WOlTc4JPBqIwvCmLkppO X-Authority-Analysis: v=2.4 cv=FaQ3xI+6 c=1 sm=1 tr=0 ts=68471432 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=xqWC_Br6kY4A:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=DSfSXdSXGXaEfb08ihoA:9 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: gbrzSIvllkq0WOlTc4JPBqIwvCmLkppO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-09_06,2025-06-09_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506090128 Content-Type: text/plain; charset="utf-8" We are going to want to re-use this before the component is bound, when we don't yet have the device pointer (but we do have the of node). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/m= sm/adreno/adreno_device.c index 6b0390c38bff..504174dbe6d6 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -133,9 +133,8 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) return NULL; } =20 -static int find_chipid(struct device *dev, uint32_t *chipid) +static int find_chipid(struct device_node *node, uint32_t *chipid) { - struct device_node *node =3D dev->of_node; const char *compat; int ret; =20 @@ -169,11 +168,12 @@ static int find_chipid(struct device *dev, uint32_t *= chipid) /* and if that fails, fall back to legacy "qcom,chipid" property: */ ret =3D of_property_read_u32(node, "qcom,chipid", chipid); if (ret) { - DRM_DEV_ERROR(dev, "could not parse qcom,chipid: %d\n", ret); + DRM_ERROR("%s: could not parse qcom,chipid: %d\n", + node->full_name, ret); return ret; } =20 - dev_warn(dev, "Using legacy qcom,chipid binding!\n"); + pr_warn("%s: Using legacy qcom,chipid binding!\n", node->full_name); =20 return 0; } @@ -187,7 +187,7 @@ static int adreno_bind(struct device *dev, struct devic= e *master, void *data) struct msm_gpu *gpu; int ret; =20 - ret =3D find_chipid(dev, &config.chip_id); + ret =3D find_chipid(dev->of_node, &config.chip_id); if (ret) return ret; =20 --=20 2.49.0 From nobody Sun Feb 8 11:51:09 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4819A21C9F2 for ; Mon, 9 Jun 2025 17:04:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749488694; cv=none; b=Q8K+fKp1gSCevTFkGSSfbirmDNM71N6JVGRZ1mIp2gBk7860JXjLlJAxMsTybVzxiyUJUm2/ky6k9E20H5Js0IWDLmMhh4cezGDW87kogotZUJKL7Am7er0EWQCE0VknZ2D9tKqwUvA/UcIWXaC61pqibdZt7twX922RwQV/jGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749488694; c=relaxed/simple; bh=8Zh5FxpdEEPYWNBe5RT+mh0B6sH5fibgodIzdBiCrhI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BtrMsNUstavpCfCY15DNzoaKG/rRg03YWYEvM9O47OzO/bPb1wc8jV2vFr3Ds50FIBUuPeYdoLGNAxkH8rDvbhXXCxGkmNWKvhkgprmRDOGEgFnr6OmdZjQMgD39zx5CIylTqBpVXSGbj/8wxfc07Zn+1WbpeBoZ4o5EqmZwhGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bS5tLNMm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bS5tLNMm" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 559G59JA027402 for ; Mon, 9 Jun 2025 17:04:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=XzZwPYZlbjF MZPye7rfYt1k670m73tYiBP58ZldSdxI=; b=bS5tLNMmGaTk0fsAqXaNNjrHiYe N3gHqmWXUDfnVH+wgr8H4JcLzIp6H9Zq/p4mEzC6+P2295TtVQ5LZuPHfJU2IWWY bs72wVFA5URZtBpe2+tJTwBWUvyVbr0/w355zMXtfNs/2PVVJfB6PykQkPG8dn2Y w7i86gKbxI3qIkapl1xcbP9ZuE0APkfmywZWCrwZXTMW8Z+I1UkZF6qVxEOmx+ug ATDCWo8aYB1lPpoZn7/+xpPhn6Ai8BspSaYAlDFyKydI65T6jQ8aS4tNwb2qyCzY PgU7yDxY1OAAwdupUgR5qXB9VHEDTyTDon5+6ZmS1NL6DZmIDqDMM4lIB7Q== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4762tg04ru-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 09 Jun 2025 17:04:52 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b2eeff19115so5520365a12.0 for ; Mon, 09 Jun 2025 10:04:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749488691; x=1750093491; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XzZwPYZlbjFMZPye7rfYt1k670m73tYiBP58ZldSdxI=; b=aK7x5eCrvjWNVbdBqhi9SpvHIjnOaE/IG9NKkXWAxhRKOcIaTFbY459Chli6yugoFr LNXpQCq+jHGhRa2Jv4r3fAWIswLnI40xlQIqkQicBlNDVHk+LIBqykvOXy1ygBfIEtQE vSZ4HDHMZN/YCyAa0aBxuIn1kOqCyru2hucrqkw+wmnbt3fX2D/lqq69DtWmg3derwQv ItLiwgAWrrpJ0e2KXhWInrrV78PrBteqpQH+dc1hx3j0snmdl9+TEm1uxjmwZueRxdmF T89Ujsa+IGStC2kbzgYIrl1HDC49N+c2BhpDm/wS/xmKWmEYt80aF+1FjJlSThuSDLha AX9g== X-Forwarded-Encrypted: i=1; AJvYcCXMCXHJRHW6Ow+KSFjvlOqMdgskEOdfdIcskcNnBArQ6U4TEksxhKtII1vHs4OXnTI32AQ3H/83l1/od2U=@vger.kernel.org X-Gm-Message-State: AOJu0YzXfd5kvyZteTn6+ZOAwmKZMPrroxTBqlpI1spQx+VDTvUpAN3M 1bNzl3oNoISuQXjO2TBDb9c4PGkcQAqzfWDi1d7QfM+lE8R6e/k2PtWst4XojvjgD7W/m9Q5KC0 61IQWgU35sUqkjFCC+ovbF0KBYrJnEFD2yWnXPLvj9bsyYF9N9xbwtNqGl8ezGOtbPKQ= X-Gm-Gg: ASbGnctbKyB6M5WBxflfe2WkfkK/fXK36XkqT/RPh1hJFRLOJXXeZjl306rvk99VQpd FPyfaLLyCd3lCya0fbm79QKD3P4MlJQ3V2DvgJvqOdE4sml3u5yhrnqUi8Ypv2LiCP4LI3+dCAQ atP17g/nFyi+vvvVSvT9x1hhPFKPlyfk21ZMdSvuoV1q/1V5MNK44w8FC0A5ETGoabFfE87SKHs obq0lwyuFRsYXFWqfyVyKfgBJofnALJyVWkW4qkzh51Tc2xoyzrvE/fdzM/u++Q933LhbmgWnRP MCa+FGo82iSa18wsZRBcnk/wgg28zobs X-Received: by 2002:a17:903:2301:b0:235:779:eddb with SMTP id d9443c01a7336-23601d7194bmr213852575ad.36.1749488690845; Mon, 09 Jun 2025 10:04:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFL1pHFRZONFYaAY8yeqfuRk4Hrvwb8mpHSMYXfnTl0BvljOd/9GrDX2S0s4MWKivdH4qiYQw== X-Received: by 2002:a17:903:2301:b0:235:779:eddb with SMTP id d9443c01a7336-23601d7194bmr213852165ad.36.1749488690463; Mon, 09 Jun 2025 10:04:50 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23603504ed2sm57042115ad.219.2025.06.09.10.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 10:04:50 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Dmitry Baryshkov , Rob Clark , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Dmitry Baryshkov , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 3/3] drm/msm/adreno: Check for recognized GPU before bind Date: Mon, 9 Jun 2025 10:04:36 -0700 Message-ID: <20250609170438.20793-4-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250609170438.20793-1-robin.clark@oss.qualcomm.com> References: <20250609170438.20793-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=OqZPyz/t c=1 sm=1 tr=0 ts=68471434 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=xqWC_Br6kY4A:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=4MAclHcQAAAA:8 a=MWJfq7QAy6hsqaZmoI4A:9 a=x9snwWr2DeNwDh03kgHS:22 a=6vtlOZhwcO7ZS_iRoh4Z:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA5MDEyOCBTYWx0ZWRfX6vubCI+fXw73 UARvMa6jRyPkTwTA5Rkg6YpTldMIqFuefpJDbJhsmFZQYx5cMdgKGGPG3Y0b5ZVCBbKklD2JFPh OWbDt3PQuUTv7sVyTohho0FsEYHo/8s4bY24DvxIC0r7N5Ziu9fvsAm+38o+VhIZhJznsZOew9+ 0WWRRj/EWzPwZNfq0MvfTPbEZWT9VDoMvDoBFc/SUE0708lqyoACp0KKnCOqBZJVaFSx3q33U83 jHoNc7BZaF8y3BYzZ8gU8DDE3Zhmg59edsOTXqrTvzPBySuBMJE+z8xm9Y0ohHOH7XMCJJQsU8Q HVaRU0SXcNGek9wPXhQErTex7xhSB02svA8YS6QCKpMf5bi3gmqbJ7v58EkVwR871v8PHdCNMbB e8EP+8Ua4/bGkq5EO+m9n3RlHpUcbtkNu1r7Xg6Ew3Pfx5C5hOVD4pPjUF6RPJGxLJcY9zXS X-Proofpoint-ORIG-GUID: g6Ywb9XQ-Xu8rnNnwyiaE8OuOymlsxQV X-Proofpoint-GUID: g6Ywb9XQ-Xu8rnNnwyiaE8OuOymlsxQV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-09_06,2025-06-09_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506090128 Content-Type: text/plain; charset="utf-8" If we have a newer dtb than kernel, we could end up in a situation where the GPU device is present in the dtb, but not in the drivers device table. We don't want this to prevent the display from probing. So check that we recognize the GPU before adding the GPU component. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 29 ++++++++++++++++++---- drivers/gpu/drm/msm/msm_drv.c | 2 +- drivers/gpu/drm/msm/msm_gpu.h | 1 + 3 files changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/m= sm/adreno/adreno_device.c index 504174dbe6d6..002aaf365322 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -178,6 +178,26 @@ static int find_chipid(struct device_node *node, uint3= 2_t *chipid) return 0; } =20 +bool adreno_has_gpu(struct device_node *node) +{ + const struct adreno_info *info; + uint32_t chip_id; + int ret; + + ret =3D find_chipid(node, &chip_id); + if (ret) + return false; + + info =3D adreno_info(chip_id); + if (!info) { + pr_warn("%s: Unknown GPU revision: %"ADRENO_CHIPID_FMT"\n", + node->full_name, ADRENO_CHIPID_ARGS(chip_id)); + return false; + } + + return true; +} + static int adreno_bind(struct device *dev, struct device *master, void *da= ta) { static struct adreno_platform_config config =3D {}; @@ -188,18 +208,17 @@ static int adreno_bind(struct device *dev, struct dev= ice *master, void *data) int ret; =20 ret =3D find_chipid(dev->of_node, &config.chip_id); - if (ret) + /* We shouldn't have gotten this far if we can't parse the chip_id */ + if (WARN_ON(ret)) return ret; =20 dev->platform_data =3D &config; priv->gpu_pdev =3D to_platform_device(dev); =20 info =3D adreno_info(config.chip_id); - if (!info) { - dev_warn(drm->dev, "Unknown GPU revision: %"ADRENO_CHIPID_FMT"\n", - ADRENO_CHIPID_ARGS(config.chip_id)); + /* We shouldn't have gotten this far if we don't recognize the GPU: */ + if (!WARN_ON(info)) return -ENXIO; - } =20 config.info =3D info; =20 diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 87ee9839ca4a..40eb04bab35e 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -956,7 +956,7 @@ static int add_gpu_components(struct device *dev, if (!np) return 0; =20 - if (of_device_is_available(np)) + if (of_device_is_available(np) && adreno_has_gpu(np)) drm_of_component_match_add(dev, matchptr, component_compare_of, np); =20 of_node_put(np); diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h index 5508885d865f..56bd1a646b83 100644 --- a/drivers/gpu/drm/msm/msm_gpu.h +++ b/drivers/gpu/drm/msm/msm_gpu.h @@ -729,6 +729,7 @@ msm_gpu_create_private_vm(struct msm_gpu *gpu, struct t= ask_struct *task, void msm_gpu_cleanup(struct msm_gpu *gpu); =20 struct msm_gpu *adreno_load_gpu(struct drm_device *dev); +bool adreno_has_gpu(struct device_node *node); void __init adreno_register(void); void __exit adreno_unregister(void); =20 --=20 2.49.0