From nobody Wed Dec 17 08:58:10 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6982DA95E; Sat, 7 Jun 2025 16:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749312160; cv=none; b=ilihcx1U5IGOn7P5zUeQgyWXkDw1JmaOOfz1sAG6+PywK6uyzoRfNhERR6LdMThqqXLU6xMN12qsBuPE7/GEvzOgatnJSpwSescoDzhPH2PriesJkRciroeYvO6X33VfNACvi1ghnSWowhhpAOCwQ70S0xSC6yXjiKMSZNtPr8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749312160; c=relaxed/simple; bh=TboKj+n+JMofyR3StoxBtmki4DwVKXfKbO8hJ/yAM1I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uC2cJ8riPiM3NZcKTfkQNOGXqKDkNj3UoJYg5EZjotbX5WaDV+QGR4SWxMVEugOaF3RzsIlH6uHRh0DDKE1hF74k1199ef+FlD0sIG4ihfArIfCRGteezUnjQzu/NmZVjmfV0n1Exo3Wec8LQFSk7v0j9iuRfNcpc7Qs1k04Hr4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=hf6nk5Ci; arc=none smtp.client-ip=220.197.31.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="hf6nk5Ci" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=KB u/QHNze4ZdkHD8l42VpSgTfDV6Fy1D7Y0zPXIgzpI=; b=hf6nk5CihF7kMjhqyg 5Akw1mKIgJWxGICf//qXGlEXCV4C+Kziahc/Ydw8E/MFhfUyDZ5hiaXozTKzpvlP NUxtLwhSCgUZoIdSqfAal0KVcZZhMJH65VWRvjldGRZ/eRvWPh2XFEWg5V433N6T k0AnXYhWN3NnVLs7DVk0W/Lgg= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wBnk_V6YkRoJ9qHGg--.28203S3; Sun, 08 Jun 2025 00:02:04 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, heiko@sntech.de, mani@kernel.org Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH v3 1/3] PCI: rockchip-host: Fix "Unexpected Completion" log message Date: Sun, 8 Jun 2025 00:01:59 +0800 Message-Id: <20250607160201.807043-2-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250607160201.807043-1-18255117159@163.com> References: <20250607160201.807043-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wBnk_V6YkRoJ9qHGg--.28203S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XrWrWF4xXF15urWfJw1xAFb_yoWkZrbE9r n8u3W7Zw45KrW3A3Wvy3yIvryrAas09a1IkayftF1ayas2vr10q34v93y8J3Z8ur1DXF9r tw1qyF4xW3srZjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRNhL05UUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbBDwBlo2hEWUbcBwABsg Content-Type: text/plain; charset="utf-8" Fix the debug message for the PCIE_CORE_INT_UCR interrupt to clearly indicate "Unexpected Completion" instead of a duplicate "malformed TLP" message. This improves error log accuracy. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Manivannan Sadhasivam Acked-by: Shawn Lin --- drivers/pci/controller/pcie-rockchip-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 6a46be17aa91..2804980bab86 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -439,7 +439,7 @@ static irqreturn_t rockchip_pcie_subsys_irq_handler(int= irq, void *arg) dev_dbg(dev, "malformed TLP received from the link\n"); =20 if (sub_reg & PCIE_CORE_INT_UCR) - dev_dbg(dev, "malformed TLP received from the link\n"); + dev_dbg(dev, "Unexpected Completion received from the link\n"); =20 if (sub_reg & PCIE_CORE_INT_FCE) dev_dbg(dev, "an error was observed in the flow control advertisements = from the other side\n"); --=20 2.25.1 From nobody Wed Dec 17 08:58:10 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6ECD1FF7C5; Sat, 7 Jun 2025 16:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749312166; cv=none; b=Qh3mZaQsfGtvno9uadiU+HLxdBbjKKEqUWyF6rDoPPGktuDKvG+bfGUb71ZktmeUEkQIBuBrGwMse814udptSEREN/wqEfAYCGPd5xgE3EqvIKkm4bvKSMiYUyKj0vG1QTByhJ1puq9D4eS8NEfEFvvBubACrsazIIvngiqPEsI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749312166; c=relaxed/simple; bh=a/4uwrsPZgXYF17hEfJZOGKFRrRvrs6PPr5TJ8HkYi0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=icwtLqJ/np5JNc5vuD+hJyYpRF/lprDh4Yv8QRUigQLNEA86UxiXSL+FSKTromJANvW+KQx+H3VvBPg+No6knD3kdBTlcTGcEa0QC4Fi9KhXVI1CfWGpk6uSAtrdsVIcqW6V9osHoxfKPPSrr3XXbxhQW6O0DMKh5p5z42Qm7rY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=fmU3hE99; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="fmU3hE99" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=ie pwYhicwFdcRl1yUElPZ9m5c8epfncSb8mYKYdMO50=; b=fmU3hE99QWEFp0nC7k D7+kuIiEyiIGMyzSQf0eTHPDGJQ7dKijrzov+VlMPeZRz8XhpI7Ihln2aBN+DF4M VGdj4whiCl7iajlJlEZGDy1G/G4fLAqRCqKlKCSPvy58wZbU4oKtONeTj1Bh5rmG Xxk5+DAr44fuiS56SLwPjCXq8= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wBnk_V6YkRoJ9qHGg--.28203S4; Sun, 08 Jun 2025 00:02:04 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, heiko@sntech.de, mani@kernel.org Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH v3 2/3] PCI: rockchip-host: Correct non-fatal error log message Date: Sun, 8 Jun 2025 00:02:00 +0800 Message-Id: <20250607160201.807043-3-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250607160201.807043-1-18255117159@163.com> References: <20250607160201.807043-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wBnk_V6YkRoJ9qHGg--.28203S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrZr4ruF1fCr4DAry5tFyrWFg_yoWkArbE9r 1jva47Zw4UGr9ag3Zay3ySqr9xAasF9r1Iya18KF13Aa47Xr1Fq348Zwn8JF1kCr15tF9x t3sFyF45ur43ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRZJ5rJUUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbBDw9lo2hEWUbcLQAAsE Content-Type: text/plain; charset="utf-8" Correct the debug message for PCIE_CLIENT_INT_NFATAL_ERR from "no fatal error" to "non fatal error interrupt received" to match the actual interrupt semantics. This avoids confusion in log interpretation. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Manivannan Sadhasivam Acked-by: Shawn Lin --- drivers/pci/controller/pcie-rockchip-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 2804980bab86..209eb94ece1b 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -489,7 +489,7 @@ static irqreturn_t rockchip_pcie_client_irq_handler(int= irq, void *arg) dev_dbg(dev, "fatal error interrupt received\n"); =20 if (reg & PCIE_CLIENT_INT_NFATAL_ERR) - dev_dbg(dev, "no fatal error interrupt received\n"); + dev_dbg(dev, "non fatal error interrupt received\n"); =20 if (reg & PCIE_CLIENT_INT_CORR_ERR) dev_dbg(dev, "correctable error interrupt received\n"); --=20 2.25.1 From nobody Wed Dec 17 08:58:10 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9251B35957; Sat, 7 Jun 2025 16:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749312161; cv=none; b=CrFFyw1diQk45XqDg26VeBQUN9aYzU3PdAzQV2TXePA3NTJ7VA15ouNtriVreRxMFZF25DG+1REOZleu+JtFufugsPFw+A10jlLT8qf2UUz4490osLQ4KQDE166RNqVgDls5hnUJsiQi5F/xbtDFC9mBK81aMHJd383Y2aYIwXk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749312161; c=relaxed/simple; bh=Sy2qS/3HdXzg8WktgfhoYL1j7m4GS/3y9rwlz7NUVKk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nq/ML6r8uDeJm9Aad8QMhhyXBpJlVeEKrEpl2KS9xmAW+2Qu3xjOSyKdCFr/z/XpIkwURCw5P5bnN2fAP9rNhbQ/txFEm6A8mECY0MJdeaN4j5J4AMYCJC6lxWEmLmTg/sK5+OzAkkRW81NCy8f+/8HT3srtzTs9JgDmi/ItJsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=Mx7aTzqi; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="Mx7aTzqi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=dd 3PBYCBCfNw9lxWikWA//qjDIn1DUBtp6UcFhFb8M8=; b=Mx7aTzqiUh1rV4a9cG k1AiZXhyQMeAA4vSO7iNUePeU6R7754WAwonXzxTQxMU+GcHkTmsbXfqx4Kx5JI+ IF2NoXkRwBgKVTdbgqt0CGN1pYkg64liEj7BV+Mp2Uixy4ZdM4ypjyfF2J2fB6FN HT2NwkOmFNdA3B2RrfbgUdHlo= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wBnk_V6YkRoJ9qHGg--.28203S5; Sun, 08 Jun 2025 00:02:05 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, heiko@sntech.de, mani@kernel.org Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH v3 3/3] PCI: rockchip-host: Remove unused header includes Date: Sun, 8 Jun 2025 00:02:01 +0800 Message-Id: <20250607160201.807043-4-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250607160201.807043-1-18255117159@163.com> References: <20250607160201.807043-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wBnk_V6YkRoJ9qHGg--.28203S5 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZF1fWw17Jryxur15uw47XFb_yoW8Gw1kpF WqkF4xJrZ5AF1UCFnruF1jyFn0qa1DAr17J342ga47Z342yr1vq395urn3tr1DAFW2gF1U Cay3trs5CrW5XrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRk9NPUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiOhxlo2hEXNqDCAAAsB Content-Type: text/plain; charset="utf-8" Clean up the driver by removing unnecessary header includes (e.g., , ) that are no longer referenced after refactoring. This improves code readability and build efficiency. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Manivannan Sadhasivam Acked-by: Shawn Lin --- drivers/pci/controller/pcie-rockchip-host.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 209eb94ece1b..ba360ed62afa 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -12,26 +12,17 @@ */ =20 #include -#include -#include #include -#include #include #include #include #include #include -#include -#include #include #include #include -#include -#include #include #include -#include -#include =20 #include "../pci.h" #include "pcie-rockchip.h" --=20 2.25.1