From nobody Sun Dec 14 19:52:30 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4BAE1CEAC2 for ; Fri, 6 Jun 2025 14:20:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749219649; cv=none; b=UlcNmd4QY2M8mdzjEhYMiPFYBTOItbJdPtNtywP3Q5TAjNxI8mzTVyf6XYw3hOp416vXk2gbwLSMc1yAtRZ1vWJGdzpP/QwzwxffZLX6Moz1pGfZkEfVVJvFvEhvg5gL2MDPt+VKpl9CYRPISgA5RUIc2yi2rLNMRrUnaRpWo64= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749219649; c=relaxed/simple; bh=L/gwxvm6plajhtZUJBhnKB7CkU77xzODIZq6h41Wvi8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XGU+fam037Gs3yEFlhkxPFoQyYJf5/2CEf2YRh8Vd4Bv/2UXZt5zpbqbNdCFbgfm7Ape3NJvqCdK/nNx7G46COK2YN729w/m8YTaNfPqsKvMjlb9Inmz0do0FvtR4rjkn4k4CPy5dupKwdHxrlFpMjMy3IzLJrT6JB1VbazkVbA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=UZLVYr9z; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="UZLVYr9z" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-450cfb790f7so16998365e9.0 for ; Fri, 06 Jun 2025 07:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749219646; x=1749824446; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8HpQeVbRwMAK/HKOtbrEdsV8ikZIsnrbhJJIVEFRiLg=; b=UZLVYr9ztQa6BVFfwr3aiSB10sy0axQE0a3TBQBgJdgvoOT01bcbF9w7lf5YJNChCI 94BCa6EsDFNQV5At+nHN9o4ATVXdI+lWKKeNcHchwliO/Gglu35YTAJVxLqnjySFxYiy 1q7emvStVxmdRoE0+0duHjKJ3a+Yotyif/yn3SVJoCzEyfN5HO9mdATCDwqJC42hdX0L xMi0X0Z+NmYMVezqyVG0zLF2ZE0Q0DWZEbsUEN14CrMAmYWlhfZweuyNpBBrQqGvnJUB 3pIA7+epvNvhfWJWZlzfGlTiP8HH3VolCOsrn27dxWgBF7he3/LsAKt/lRXZU5ERtjjR vQUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749219646; x=1749824446; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8HpQeVbRwMAK/HKOtbrEdsV8ikZIsnrbhJJIVEFRiLg=; b=aXc3FYZ1O7pDZ1T7r+lhs6Q7gswNGXNBkAVO/+cxQjP7w1t3hzcfORjbEMIlJ0nuH5 W29LlKKZ4jczFHUUs8nja0ChH2T2FXlOdrAPT7Ejj2irj16ubVIJhhGUT7J1KiH8kdQu fuVNz9PfF0vRkywAyXthB2s9tuKLUB0rpWu1pf25O8loglAISfDt/Wl0Fs41qurdBItQ YPNiZe5+Udqjp1S1hQqLTFJMbkp9A4I8SVddaIeWpgLlxKvSbZJY4TSC05/TzYDGM9JI Uf2tj/pb4m/l/OF8yWROrAh6Px/N+RyEjPBhNFu+8elRDbcQ8i7JPRB66qcfFjImXsJX HL2A== X-Forwarded-Encrypted: i=1; AJvYcCWRqjLrAG16F/GXC8c4wnJeVpuH+K6HBtnKO4+HQvVY+pHcuOxxtEjpxJhpNrL64GbSk1H/t/1k59Sbk8o=@vger.kernel.org X-Gm-Message-State: AOJu0YzZ45HOF7muS1/mFpPZsCezGSnXImzlYQRLVWlG+yxLrgA8sNkQ nOpH6W4Rj+T4498/gjTr6sUa9321qNqUQumWbdlQUiaMzaEyoF1erGQ2jMCOkxzOGCw= X-Gm-Gg: ASbGncstaVH6uCN+gaX30YXvVJAWbl8SK1QsKdG64DvWxFduj0CbLRxlLQ8NM3gwczp 1avTH99DVvY1M3cYIQZzKQOSyOzPgF7gLcDKxaWtD/A847ndNCYbc/9jzjktSfJlGW5eFQGlJjv b1FYJF85F6cZkia4W9wDdr1Jm5xGGyNThdEoGvGCeUZwkBmIkU9a8n0q4i+0kAqt+PyeSU+e6ul MyRmqCc0K0HerYnaxGEgvUgxbibuvRtLHmIZMR+A26ztYPT5N6u3munFNgrnpMwK+9vPTD1xBAH 6uDLz6CE/hwalmv2AUpU+8wNlwaZbizrAy4e1b9kJ6n/DTTtDraV4PsH/jVMGU7j2T356MrLi2/ GSAcMVuNd6iyVpD/67D8yJWdtROGUvq8LYj624gkIIQ== X-Google-Smtp-Source: AGHT+IFkrVts+bEEPUp4BBAtLVZPot/aA/9X0oPRBOSSiEtVNiKU2TRV736+tfIKnO29f0u+64AR8w== X-Received: by 2002:a05:600c:a08e:b0:43c:fa24:873e with SMTP id 5b1f17b1804b1-45201391375mr39843995e9.13.1749219646003; Fri, 06 Jun 2025 07:20:46 -0700 (PDT) Received: from [192.168.0.2] (host-80-116-51-117.retail.telecomitalia.it. [80.116.51.117]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45213754973sm25686345e9.35.2025.06.06.07.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 07:20:45 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Fri, 06 Jun 2025 16:19:22 +0200 Subject: [PATCH v9 7/7] iio: adc: ad7606: add gain calibration support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250606-wip-bl-ad7606-calibration-v9-7-6e014a1f92a2@baylibre.com> References: <20250606-wip-bl-ad7606-calibration-v9-0-6e014a1f92a2@baylibre.com> In-Reply-To: <20250606-wip-bl-ad7606-calibration-v9-0-6e014a1f92a2@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Hennerich , devicetree@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5283; i=adureghello@baylibre.com; h=from:subject:message-id; bh=IKWt2EvUAc6fFAR+GqaSzL5Mis4xCa3ugoUhm+8Psbg=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYshw+vHs2gXb+MPrOrytJjwNkI28X7Y0uLH1//aN7De9i s4JPZvN1VHKwiDGxSArpshSlxhhEno7VEp5AeNsmDmsTCBDGLg4BWAiDy4zMtxgt1teuLT3rqGu 9Zrtq5u+T3mRsjCj5NCuAl824/A3Ux4w/NPRap+vuKLnh0zcy9Dv1YZKcTXu/Gdeiqr2VXotf5R 2kwMA X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Add gain calibration support, using resistor values set on devicetree, values to be set accordingly with ADC external RFilter, as explained in the ad7606c-16 datasheet, rev0, page 37. Usage example in the fdt yaml documentation. Signed-off-by: Angelo Dureghello --- drivers/iio/adc/ad7606.c | 39 +++++++++++++++++++++++++++++++++++++++ drivers/iio/adc/ad7606.h | 5 +++++ 2 files changed, 44 insertions(+) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index d19682186e7cd73a60541f62adf08d987ba24ec3..d9271894f091a837d29197f7de8= 92c022b7e4152 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -33,6 +33,10 @@ =20 #include "ad7606.h" =20 +#define AD7606_CALIB_GAIN_MIN 0 +#define AD7606_CALIB_GAIN_STEP 1024 +#define AD7606_CALIB_GAIN_MAX (63 * AD7606_CALIB_GAIN_STEP) + /* * Scales are computed as 5000/32768 and 10000/32768 respectively, * so that when applied to the raw values they provide mV values. @@ -180,6 +184,7 @@ const struct ad7606_chip_info ad7606b_info =3D { .scale_setup_cb =3D ad7606_16bit_chan_scale_setup, .sw_setup_cb =3D ad7606b_sw_mode_setup, .offload_storagebits =3D 32, + .calib_gain_avail =3D true, .calib_offset_avail =3D ad7606_calib_offset_avail, .calib_phase_avail =3D ad7606b_calib_phase_avail, }; @@ -195,6 +200,7 @@ const struct ad7606_chip_info ad7606c_16_info =3D { .scale_setup_cb =3D ad7606c_16bit_chan_scale_setup, .sw_setup_cb =3D ad7606b_sw_mode_setup, .offload_storagebits =3D 32, + .calib_gain_avail =3D true, .calib_offset_avail =3D ad7606_calib_offset_avail, .calib_phase_avail =3D ad7606c_calib_phase_avail, }; @@ -246,6 +252,7 @@ const struct ad7606_chip_info ad7606c_18_info =3D { .scale_setup_cb =3D ad7606c_18bit_chan_scale_setup, .sw_setup_cb =3D ad7606b_sw_mode_setup, .offload_storagebits =3D 32, + .calib_gain_avail =3D true, .calib_offset_avail =3D ad7606c_18bit_calib_offset_avail, .calib_phase_avail =3D ad7606c_calib_phase_avail, }; @@ -306,6 +313,7 @@ static int ad7606_get_chan_config(struct iio_dev *indio= _dev, int ch, bool *bipolar, bool *differential) { struct ad7606_state *st =3D iio_priv(indio_dev); + struct ad7606_chan_info *ci; unsigned int num_channels =3D st->chip_info->num_adc_channels; struct device *dev =3D st->dev; int ret; @@ -349,6 +357,14 @@ static int ad7606_get_chan_config(struct iio_dev *indi= o_dev, int ch, return -EINVAL; } =20 + ci =3D &st->chan_info[reg - 1]; + + ci->r_gain =3D 0; + ret =3D fwnode_property_read_u32(child, "adi,rfilter-ohms", + &ci->r_gain); + if (ret =3D=3D 0 && ci->r_gain > AD7606_CALIB_GAIN_MAX) + return -EINVAL; + return 0; } =20 @@ -1352,6 +1368,23 @@ static int ad7606b_sw_mode_setup(struct iio_dev *ind= io_dev) return st->bops->sw_mode_config(indio_dev); } =20 +static int ad7606_set_gain_calib(struct ad7606_state *st) +{ + struct ad7606_chan_info *ci; + int i, ret; + + for (i =3D 0; i < st->chip_info->num_adc_channels; i++) { + ci =3D &st->chan_info[i]; + ret =3D st->bops->reg_write(st, AD7606_CALIB_GAIN(i), + DIV_ROUND_CLOSEST(ci->r_gain, + AD7606_CALIB_GAIN_STEP)); + if (ret) + return ret; + } + + return 0; +} + static int ad7606_probe_channels(struct iio_dev *indio_dev) { struct ad7606_state *st =3D iio_priv(indio_dev); @@ -1630,6 +1663,12 @@ int ad7606_probe(struct device *dev, int irq, void _= _iomem *base_address, st->chip_info->sw_setup_cb(indio_dev); } =20 + if (st->sw_mode_en && st->chip_info->calib_gain_avail) { + ret =3D ad7606_set_gain_calib(st); + if (ret) + return ret; + } + return devm_iio_device_register(dev, indio_dev); } EXPORT_SYMBOL_NS_GPL(ad7606_probe, "IIO_AD7606"); diff --git a/drivers/iio/adc/ad7606.h b/drivers/iio/adc/ad7606.h index 26db8e3c724f47f68b7d5323f5d1db75b3334540..2951bb731354d64cbec6e8460b3= d841a22bb17ec 100644 --- a/drivers/iio/adc/ad7606.h +++ b/drivers/iio/adc/ad7606.h @@ -66,6 +66,7 @@ typedef int (*ad7606_sw_setup_cb_t)(struct iio_dev *indio= _dev); * @init_delay_ms: required delay in milliseconds for initialization * after a restart * @offload_storagebits: storage bits used by the offload hw implementation + * @calib_gain_avail: chip supports gain calibration * @calib_offset_avail: pointer to offset calibration range/limits array * @calib_phase_avail: pointer to phase calibration range/limits array */ @@ -81,6 +82,7 @@ struct ad7606_chip_info { bool os_req_reset; unsigned long init_delay_ms; u8 offload_storagebits; + bool calib_gain_avail; const int *calib_offset_avail; const int (*calib_phase_avail)[2]; }; @@ -92,6 +94,8 @@ struct ad7606_chip_info { * @range: voltage range selection, selects which scale to apply * @reg_offset: offset for the register value, to be applied when * writing the value of 'range' to the register value + * @r_gain: gain resistor value in ohms, to be set to match the + * external r_filter value */ struct ad7606_chan_info { #define AD760X_MAX_SCALES 16 @@ -99,6 +103,7 @@ struct ad7606_chan_info { unsigned int num_scales; unsigned int range; unsigned int reg_offset; + unsigned int r_gain; }; =20 /** --=20 2.49.0