From nobody Fri Dec 19 07:49:56 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21B6B2594BD for ; Sat, 7 Jun 2025 02:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264847; cv=none; b=Xl7GTAPFiZDXfLHY7kZsqJQAe9upgxoUMDPjuldh278G0spVk3+oCWCLvshBMZbWRdhjv+3t4wf2iHhu/m4+Fe46JIK9Znq+wSE5H4R5a1mc3afGH+G/RTpklGTibuh28aCTox9Z5kY1ZbdDNiHNvX65Ijy+7IIrOAvZr7nINu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264847; c=relaxed/simple; bh=8VuAOHFeqx5UMsNpvlh7ZAQit2VLidP6PcKmMQI0hl0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WWFFDvLF2GWJkA22qxR5iaAtG4uoyTxZNbGZPUaDXqhYwc9Q4K8E6/AlO1XcUlRbR8RSxKJRsg2/dwsKMcJr5KMo7YLE8dOWpKnHykwZ2+oXmiFG1D+hqRr3yzAd112qLQdbsG7IgjfvtwR6CAaRoY99b44ELndC8Oydd0Q/qT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=C/2/n8az; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="C/2/n8az" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-450cfb79177so14362975e9.0 for ; Fri, 06 Jun 2025 19:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264843; x=1749869643; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=079G7lwbZSdbFJvvw8wIKqroIeNsEJYLRsyPP7yIsHs=; b=C/2/n8azwKyJCTLNIgy7LVyV3KtP358RJIYCZzmXVpd+zfxPgWb8+6uQX7Qm2NzQ4a xA/pXilYEqd8T7TsvpqjWF2z6ij7EnqW0GGqJkK9+aSHj+KAfQ97OnISMuDI2E6ktRh8 mjhnITT0yT4YGOM2BmqzGSHK5pViWU7zVRcMAUoIgj+33M6UPEJ9zuLAaH1043OA6jS9 b2lsjGmcFTUci5jWRBy2d4nt5YUVwXj3QIO/0OOx8ceOEACqJVe5JaaV95XSm3lSHKkU 2PhKtFjI0vvEUoAwwQ4QhnkNwuJVzmHewTQDFp4zDQsUbY9X+DQta4qdKYRtuW607yhn N0Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264843; x=1749869643; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=079G7lwbZSdbFJvvw8wIKqroIeNsEJYLRsyPP7yIsHs=; b=AlzcYonnZVutp0uCakdekuef/fMU+lw5i+HXJhsD9JVaZjUKMR23HhwuGScy8d62Qa lUNjOYGwmV3kGM9YarWGG5k/wlC4d/IUx1+uzEFCQuuYrimTE0e9VyffHt8HbmhV3EAv 2C5Mb9VJdtOo/HZmDpEu/KZ8UvC0WLZgHSdSqBRUc3EXi2uxwWmATiVxNgvwyKM82sdp wQ6hUZ9eXgW2KbK2njCysDaX1llM9/O4mDEsSO/ZEzE1ANn+9ACNqPg9BbKqKfesRkEV Scp1pkP1sH756LyjifzEKaWedmiAEjStuHqEMneKzkZozfqWCFtRU+pW73yZX1MQ82NM 6LMQ== X-Gm-Message-State: AOJu0Yx+Q6RMHt+QWPt0417F+RQdJegJpzqXxZ0sJCLwIyzgcsJfgS1n VotoxxjxvPx3YqzCJQFoitEev8P4viqfQn5WU5rxfRzXddfFiKIs0j8iar6to7OLnFc= X-Gm-Gg: ASbGncvFjrcxD8sTSK7/yBHVv1T1mJETwRtA738t0YbCHuPmlA57TxvMV0fCBC+uF9x 5G3Xhn/srppN0wZvJRuHfF3b41+JTkRkcOGRwsEvaymQiknRLboRigoZ3PcK0gapmX9buGCGLJ0 r1rnNZj2VGuLIJXCeUhQBrwuye1rXieX2UjKnZxJiqXOFGoDH+eQLW+iCsUIEpL9ppNFutHlfz2 R3l7JGgM8Tfu4GF6zUnaXD1ZE+rkqV0ev0rML7dlBysjTjtbAWt7qoh/Vv486CinGpzsOXhiNfl BYvx/5rEsqHVgEiwFfwyNIelKajT9ZLlUWCS7hveh7S23Z2eBQskeGj+JlY= X-Google-Smtp-Source: AGHT+IEFMaOycz8paZH8Dwc7eB8/xeQCEwaltIN87YJjZdoV9BEkV0ZK9L7/PCQxBolImcH3wDz9CQ== X-Received: by 2002:a05:600c:8b08:b0:440:9b1a:cd78 with SMTP id 5b1f17b1804b1-4520141635bmr68757385e9.10.1749264843376; Fri, 06 Jun 2025 19:54:03 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:02 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:43 -0300 Subject: [PATCH 1/7] printk: Make console_{suspend,resume} handle CON_SUSPENDED Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250606-printk-cleanup-part2-v1-1-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=1467; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=8VuAOHFeqx5UMsNpvlh7ZAQit2VLidP6PcKmMQI0hl0=; b=T3wYMARjrMBrnSS0B53XQkjL8a0KEFURCPDHgsLUslXubhtqe5kSsdH3AVNiC4itsQepzSKEL bCiOgTyAtZ1BpRW6LdXAAFDz3h5mWwilxfoY0pptQZniRHvG6Kc9OCL X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= Since commit 9e70a5e109a4 ("printk: Add per-console suspended state") the CON_SUSPENDED flag was introced, and this flag was being checked on console_is_usable function, which returns false if the console is suspended. No functional changes. Signed-off-by: Marcos Paulo de Souza --- kernel/printk/printk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 1eea80d0648ed3583375cce3dfe60407894d659c..6d3cf488f4261a3dfd8809a5ab7= 164b218238c13 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3530,7 +3530,7 @@ void console_suspend(struct console *console) { __pr_flush(console, 1000, true); console_list_lock(); - console_srcu_write_flags(console, console->flags & ~CON_ENABLED); + console_srcu_write_flags(console, console->flags | CON_SUSPENDED); console_list_unlock(); =20 /* @@ -3543,13 +3543,14 @@ void console_suspend(struct console *console) } EXPORT_SYMBOL(console_suspend); =20 +/* Unset CON_SUSPENDED flag so the console can start printing again. */ void console_resume(struct console *console) { struct console_flush_type ft; bool is_nbcon; =20 console_list_lock(); - console_srcu_write_flags(console, console->flags | CON_ENABLED); + console_srcu_write_flags(console, console->flags & ~CON_SUSPENDED); is_nbcon =3D console->flags & CON_NBCON; console_list_unlock(); =20 --=20 2.49.0 From nobody Fri Dec 19 07:49:56 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18BF62417E6 for ; Sat, 7 Jun 2025 02:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264855; cv=none; b=nR9QdCaEqzyIP6F//acOfWABDG+kugpKm4uv++wPl6KzuzKeWN+uzvOL+izGIjf1BviinPmI7fR+ZPcytOSjUA2RVdnQ7md47jPmx1ENbVSPZKpUTGA1jriGvs+xdj6729LJ3Nn/AEX5C3I772L500gdKZcNj7tLWHjrdrjLY1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264855; c=relaxed/simple; bh=1gk8U8A9Tp8dYd1sZPBSwCndj58kUaiYwQ9Z81qrFXo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pE3Ewu2//E4FfBpwDyDoCd5NlaWouJ6bWAPvGui0OIDSFNbPuEq3cbd0zl0lyh3DqcExGTlUFd5s7+QiB51PKnykGNodGqytDKkGqkdBmuGpiAje0pch4ILg+g1RTQv3dhkbt2+C6eEGY+t/Ty+3tZpc/ZBNxziZ+p238bGntCc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=HrzHXgEU; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="HrzHXgEU" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3a4fea34e07so1570520f8f.1 for ; Fri, 06 Jun 2025 19:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264850; x=1749869650; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mX7Kpvr3d8Igbqg1Pi5Y0v9vR933SOfz9K97ZuvSH2o=; b=HrzHXgEU2yt4Pv3F4UD8ayJcVuMQmC4tISl5Fv8etbHyHuB/5ItjQMERxBhn/6CY7j 8WZN4g/L33MuU9C+KS9djt5EZaL01P5uPA7ASPMi8NiTiR5uzbytWF8/YK16XmwUnEV2 vNdJM4H9BLTNtXpZ4kIRHv2Th1eFTFP48VhzBjv0ySEozKeRDkoyvGK05Ct63iaaZ5NQ xkKBRm7DogdLmYnsAN2cd0E4zsdgwK3T+H1kTx/hg70DZc7sVyptPH/gMINzMkjsJsNX 35Dktci8FIt797QmIJDixyclxvHyAHXXc+eNaWfgLGw5tHfE56OJF+kw7HIt+aZWfCzc 1Eew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264850; x=1749869650; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mX7Kpvr3d8Igbqg1Pi5Y0v9vR933SOfz9K97ZuvSH2o=; b=Y1kncI2DDxWB4hrUXcHRkIOvpWeMEEG+rM9F04J53IogrGclC8Z7rSnHxx4Z9NLLMJ QQ8yFjI3GKP8kSxJTebqtLQXr8Ikn3RE6i9zg7jjaxJD2/zkBMt/WnkOaxLNYTpyd0cn 6SptX18t7t2HRJusYIJD3mRgmq/P0J9dvM0wvn82VawBzqXOqSVICGOaUL/MmbJJV5vD V0+eSGMFNqCfLOj6IjIwYcQ7+srqeLWw7edLFWWuDRYMFxXBn1sIE9RJmU9FxiC7LGYA M0THOHuTG8tr9x30v2B/D2LH/iLdk/s1BcAm0nN+JSaad6/zjxy842K2JyYshXR/UTVt 6mOQ== X-Gm-Message-State: AOJu0Yxi0NiRwtWa3IU7diUaT8M0gbi41En/R9SpZ3tApgWYJmBPl+qm lVX4fvPBtieTXl1dIw8uJrxtjKyr6kOhV4oVsuga/e34nGANYFxkBntXUX+5zVFVtYU= X-Gm-Gg: ASbGnct8cXnz5hHcp/vVnlTf1CMTpbJv7TOtrBbSz+28SYcxB3Ug1jDxmBKVu6DkzFi fnT1OUHG0o/SDWNHkurGdoOkLxNEy8dllF62EYua6qy2ora3ZjVJcCG+H83RLIfBdoYbe3koaQ3 wH0X6Ceg+EduAzPEI7cUJDX95645mTIsoQfTVTrP6bapTy4mgES8ExrUMkvGv0GVKvE3vYYWiim Q622JxaqQmJiM1IHyNYljIl3X//LGZHFwnhwDHVTYEDU7rG5I6a7Bk0ekLKgOg+V6YxyFlm72bY bKen4Eg8FCeBv5TNrv6xYLschMhwB2QGv/7K2p2HKT+guQjKSabAs/sWFq6l0MrSC4W7iA== X-Google-Smtp-Source: AGHT+IHTkyMEV1xuLGonC7LtgR95ygfYX+hJ/eUxGPUUwzB9N83jBsaILJv4Qv7aHZROQ6yhMrIkHQ== X-Received: by 2002:a05:6000:188f:b0:3a4:f7dc:8a62 with SMTP id ffacd0b85a97d-3a531453ce7mr4234829f8f.0.1749264850369; Fri, 06 Jun 2025 19:54:10 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:09 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:44 -0300 Subject: [PATCH 2/7] printk: Use consoles_suspended flag when suspending/resuming all consoles Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250606-printk-cleanup-part2-v1-2-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=6242; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=1gk8U8A9Tp8dYd1sZPBSwCndj58kUaiYwQ9Z81qrFXo=; b=wvHq6UkjGv8LUZFpyT85kU4YEf7UvDpnRljGGj2r3IAnPOf6zps3o5cncvffNGYqnHhCIQTlN 5oFz1z/ahtlC5MWr0tDhAmLDLFHk/lTOiZuZ/P7/OtnsVSS6Dx7AMqH X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= Instead of update a per-console CON_SUSPENDED flag, use the console_list locks to protect this flag. This is also applied to console_is_usable functions, which now also checks if consoles_suspend is set. Signed-off-by: Marcos Paulo de Souza --- kernel/printk/internal.h | 7 ++++++- kernel/printk/nbcon.c | 8 ++++---- kernel/printk/printk.c | 23 ++++++++++------------- 3 files changed, 20 insertions(+), 18 deletions(-) diff --git a/kernel/printk/internal.h b/kernel/printk/internal.h index 48a24e7b309db20fdd7419f7aeda68ea7c79fd80..752101904f44b13059b6a922519= d88e24c9f32c0 100644 --- a/kernel/printk/internal.h +++ b/kernel/printk/internal.h @@ -118,8 +118,12 @@ void nbcon_kthreads_wake(void); * which can also play a role in deciding if @con can be used to print * records. */ -static inline bool console_is_usable(struct console *con, short flags, boo= l use_atomic) +static inline bool console_is_usable(struct console *con, short flags, + bool use_atomic, bool consoles_suspended) { + if (consoles_suspended) + return false; + if (!(flags & CON_ENABLED)) return false; =20 @@ -212,6 +216,7 @@ extern bool have_boot_console; extern bool have_nbcon_console; extern bool have_legacy_console; extern bool legacy_allow_panic_sync; +extern bool consoles_suspended; =20 /** * struct console_flush_type - Define available console flush methods diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c index fd12efcc4aeda8883773d9807bc215f6e5cdf71a..72de12396e6f1bc5234acfdf6dc= c393acf88d216 100644 --- a/kernel/printk/nbcon.c +++ b/kernel/printk/nbcon.c @@ -1147,7 +1147,7 @@ static bool nbcon_kthread_should_wakeup(struct consol= e *con, struct nbcon_contex cookie =3D console_srcu_read_lock(); =20 flags =3D console_srcu_read_flags(con); - if (console_is_usable(con, flags, false)) { + if (console_is_usable(con, flags, false, consoles_suspended)) { /* Bring the sequence in @ctxt up to date */ ctxt->seq =3D nbcon_seq_read(con); =20 @@ -1206,7 +1206,7 @@ static int nbcon_kthread_func(void *__console) =20 con_flags =3D console_srcu_read_flags(con); =20 - if (console_is_usable(con, con_flags, false)) + if (console_is_usable(con, con_flags, false, consoles_suspended)) backlog =3D nbcon_emit_one(&wctxt, false); =20 console_srcu_read_unlock(cookie); @@ -1584,7 +1584,7 @@ static void __nbcon_atomic_flush_pending(u64 stop_seq= , bool allow_unsafe_takeove if (!(flags & CON_NBCON)) continue; =20 - if (!console_is_usable(con, flags, true)) + if (!console_is_usable(con, flags, true, consoles_suspended)) continue; =20 if (nbcon_seq_read(con) >=3D stop_seq) @@ -1795,7 +1795,7 @@ void nbcon_device_release(struct console *con) */ cookie =3D console_srcu_read_lock(); printk_get_console_flush_type(&ft); - if (console_is_usable(con, console_srcu_read_flags(con), true) && + if (console_is_usable(con, console_srcu_read_flags(con), true, consoles_s= uspended) && !ft.nbcon_offload && prb_read_valid(prb, nbcon_seq_read(con), NULL)) { /* diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 6d3cf488f4261a3dfd8809a5ab7164b218238c13..658acf92aa3d2a3d1e294b7e17e= 5ee96d8169afe 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -241,7 +241,7 @@ int devkmsg_sysctl_set_loglvl(const struct ctl_table *t= able, int write, /** * console_list_lock - Lock the console list * - * For console list or console->flags updates + * For console list, console->flags and consoles_suspended updates */ void console_list_lock(void) { @@ -383,6 +383,8 @@ bool other_cpu_in_panic(void) */ static int console_locked; =20 +bool consoles_suspended; + /* * Array of consoles built from command line options (console=3D) */ @@ -2755,16 +2757,13 @@ MODULE_PARM_DESC(console_no_auto_verbose, "Disable = console loglevel raise to hig */ void console_suspend_all(void) { - struct console *con; - if (!console_suspend_enabled) return; pr_info("Suspending console(s) (use no_console_suspend to debug)\n"); pr_flush(1000, true); =20 console_list_lock(); - for_each_console(con) - console_srcu_write_flags(con, con->flags | CON_SUSPENDED); + consoles_suspended =3D true; console_list_unlock(); =20 /* @@ -2779,14 +2778,12 @@ void console_suspend_all(void) void console_resume_all(void) { struct console_flush_type ft; - struct console *con; =20 if (!console_suspend_enabled) return; =20 console_list_lock(); - for_each_console(con) - console_srcu_write_flags(con, con->flags & ~CON_SUSPENDED); + consoles_suspended =3D false; console_list_unlock(); =20 /* @@ -3214,7 +3211,7 @@ static bool console_flush_all(bool do_cond_resched, u= 64 *next_seq, bool *handove if ((flags & CON_NBCON) && (ft.nbcon_atomic || ft.nbcon_offload)) continue; =20 - if (!console_is_usable(con, flags, !do_cond_resched)) + if (!console_is_usable(con, flags, !do_cond_resched, consoles_suspended= )) continue; any_usable =3D true; =20 @@ -3604,7 +3601,7 @@ static bool legacy_kthread_should_wakeup(void) if ((flags & CON_NBCON) && (ft.nbcon_atomic || ft.nbcon_offload)) continue; =20 - if (!console_is_usable(con, flags, false)) + if (!console_is_usable(con, flags, false, consoles_suspended)) continue; =20 if (flags & CON_NBCON) { @@ -4165,7 +4162,7 @@ static int unregister_console_locked(struct console *= console) =20 if (!console_is_registered_locked(console)) res =3D -ENODEV; - else if (console_is_usable(console, console->flags, true)) + else if (console_is_usable(console, console->flags, true, consoles_suspen= ded)) __pr_flush(console, 1000, true); =20 /* Disable it unconditionally */ @@ -4445,8 +4442,8 @@ static bool __pr_flush(struct console *con, int timeo= ut_ms, bool reset_on_progre * that they make forward progress, so only increment * @diff for usable consoles. */ - if (!console_is_usable(c, flags, true) && - !console_is_usable(c, flags, false)) { + if (!console_is_usable(c, flags, true, consoles_suspended) && + !console_is_usable(c, flags, false, consoles_suspended)) { continue; } =20 --=20 2.49.0 From nobody Fri Dec 19 07:49:56 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60D5A259CBB for ; Sat, 7 Jun 2025 02:54:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264860; cv=none; b=EFoYKQykuyhlaBzu7ZJiViU5041zAUTcGHiRbevbRFMS9gfVEP7Vy0MFCNRclekzMlz5B1HPmXt4Q69MH66GSMs8DCwHJao9JMTUl7zIiEDxEbt0NKcESojdS/MfOJo1qoLUJnXkKyuzDAva0NzxON1ZhkffYh3WHCkSrw3lh28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264860; c=relaxed/simple; bh=9kLsFVdVHZC1/N9aRdTRVFrJ42xC1c+3yhppaJpMsio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dArNPfMz3iN6RmZDRPi72DjPL5FW8V5LTm77HgrV93yTlkQSIi0KCC0KtyFpiArMUGq5a4PaTg3GlvMsnEPSielNHfE7+nsBvAYIX0IQ0l1awYV/6sAcdR8rhqZhfP0QmgwB5bnLtw1RAulR7u8QUVTlAmoNSHs6zdGkp/YR078= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=VzmvQCE2; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="VzmvQCE2" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a5123c1533so1503979f8f.2 for ; Fri, 06 Jun 2025 19:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264856; x=1749869656; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=blYZX9SALP3mKTtW5/j2PauIX7nPWCX8bAWtr1pxWl0=; b=VzmvQCE2peWp2L63NLmLKZMio1jAlZ9G1z+X6Ob6JvrVNq+IU9Cwqg2jED1w1JOvJB 2aqLmrdFnNG3+k66uqjzG3kqbCE0xCPSl8ajEWvMmrcNMpTLYLoAQhmNIKeNrQl7i0sC 0C54h12js4MVJElzAmPFzokO5BUswssMjV9Ih6n6ryBNVFMhocVlDa9ngIim5LAfatx2 oiw7KyBob3rFqQ0HBCH0hne2LwiEngoKJiKnjnHyPRVmUozo05Fnz20p8Eb1Qx4cw9BZ eE03TyKPnAIu2PMBxkFdufbHwlvRXFUrj4U+/gQtQ4zG5p6FILCNtjiATM6yR/F+5Jcj Tssw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264856; x=1749869656; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=blYZX9SALP3mKTtW5/j2PauIX7nPWCX8bAWtr1pxWl0=; b=leGxwP+LPFlPFww3nCMxmsQAKIrenKOoITu9pdplr6GQTmb5gkbiFzMNGT8RH739wN Jeolh96lHQnmPE+DGgwCa2ubN2+A7U3FJRMR/DKrT3MyCYa95qXc8s4zrLxibxt7tm3Z ZFupcHFClxMee7Ys4Gwc9h0KGj68/HQNxgTEIQCsZdzKI911PKNKOEDqatcWxuhFEION TillC5NwptTjx7RPj963kEZ8ggNg4JFEafcuAjWB9Yw7SYQdTy4zghwZfqWoxhq+vx7z xXtIJqtBNlEoY0St4SlG+LWTVHop9xFP6pBWHK6BvGjJ+ZqYOSA8GQ7BTV/YcEq45cqV Ff0Q== X-Gm-Message-State: AOJu0Yx+VP7yQ7e0XHsW3MuH6RaAIvy1QotK9kbppa8DUku0zMNspBPD 0jQlD84xcKvAi/TSxxSfAFIJ5f1TcyY+5+9lniHN6brRV1bnqpeEh08SuHossmrwg2s= X-Gm-Gg: ASbGncspnq5E1ZKBb/LV3UjV/kbEqFfB0BJuj9eF+/ExqPg4jLPAo3fefmFxdH+S+gT SZbxdGtlzICmIZO6ZEdZ8B+dbYU65uCwWC1RmfUdg0UJfIZU9brVs9JQAPKINlmUNfvH0+bV57D e5/SvoUALj3GcNm424yiBnNLONmpCEZ5Fu98fRnp9mXhYzHGqjcZfoTslMDJMHP/PQ97TPp1YSp kilX6wK+npAg59m3085hGBvi1uOCj9dz8arDzakbzYGcO50LUxIkhqxTcqeX6AAa/g6kkicVXXl cyECRH49npw8MdA7xqBYAFlYja34G15s88+C6tuc0IX9H3hA X-Google-Smtp-Source: AGHT+IHJ8LwIhaZRKIgzpbwHMvqzg7hdB3xBlwSSNm2xX/hnuxNAGse4PY3D/NNj8BudY/DwljmTRg== X-Received: by 2002:a5d:584c:0:b0:3a4:f024:6717 with SMTP id ffacd0b85a97d-3a531cec750mr4573998f8f.53.1749264855737; Fri, 06 Jun 2025 19:54:15 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:15 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:45 -0300 Subject: [PATCH 3/7] drivers: tty: Check CON_SUSPENDED instead of CON_ENABLED Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250606-printk-cleanup-part2-v1-3-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=849; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=9kLsFVdVHZC1/N9aRdTRVFrJ42xC1c+3yhppaJpMsio=; b=V7C9sb6tGmba5WbbzCCzgvis2cX9AK+EeOcGSXwItak8TkY+K+TnnSUrBrbGp4mQBLXbhFXa1 b5sMv8+wDMXDBlakfIx+M5fO23Lt7wo09cled0jB6DCtxtxEcDyqWTt X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console are registered, meaning that all of them are CON_ENABLED. The code tries to find an active console, so check if= the console is not suspended instead. Signed-off-by: Marcos Paulo de Souza --- drivers/tty/tty_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index ca9b7d7bad2b6807b29d3768bb655528ea162816..42f81573d8dfc668b38cd0b1c14= 962a7370cd954 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -3570,7 +3570,7 @@ static ssize_t show_cons_active(struct device *dev, continue; if (!(c->flags & CON_NBCON) && !c->write) continue; - if ((c->flags & CON_ENABLED) =3D=3D 0) + if (c->flags & CON_SUSPENDED) continue; cs[i++] =3D c; if (i >=3D ARRAY_SIZE(cs)) --=20 2.49.0 From nobody Fri Dec 19 07:49:56 2025 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73E4A25A2C7 for ; Sat, 7 Jun 2025 02:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264865; cv=none; b=SmPSHbCghmUHyMfsedNjdQIzMnY+GFcL5yWu4RJBziapPzratJWbGw7VA5Udjxo5A1D+frYqSaCp9ia0y0jgnepxKY5u/zCWLcGvZVi2737b1OHCnYGGE29CpstAffnXqqfqmIujOhblJOxFGyEILuYXe1duXjgMreRFA1A+Woo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264865; c=relaxed/simple; bh=YnwRdm6I1xYkzMWD2CGBnm+ACwq/qI6QghdxR3iROfM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DRbOjC22x9t5Ea5ZbTLO0Jpf4AYiCOhKizNVO7Rmb+4SCWXGOgZ1J5TdFKnGZ1t5anfkgwNGUMix6Zo3diEMRxLP8VcC3I1JpS/fjnPMn8mzWjiL6DYoXGRGSpqIYSnSg0Sb8UGiCaCYd3HC+g8aOKmK4rzSHpdLYK1zqk/AjQ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Qf5MZWxJ; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Qf5MZWxJ" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3a5257748e1so1869968f8f.2 for ; Fri, 06 Jun 2025 19:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264862; x=1749869662; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yF8FpTtagcV7Kwh1mn8c83YxOz5Y2vKGfOZjELVv36A=; b=Qf5MZWxJexFH2124i8pTNAGf8WOmsLQuRV0YRcPwUcHKnWCVLR/Ov9pMgu/CvpeoT5 /Av2Tn+Y5CbkHdil95WFsrvifakKs/Itn6GibO8NVHc5ib5wLOmCi4ZnYQu8Gwcl92LC 3aDkIu5/5u9YJBMdj6pY6bp+5FV4VnqRHBBUJOQ+/bG7IPzmnXzuV+1FYOw1dVX+gxuW i0vxwVhdZutMruF10HHARyj3Az+HR/k9FmNzs5tcjmoulbT3ljSf0hhWKSBZPnK7Dlt2 ZkGfIaALuoqAS5MVLtZwazrM5of55OcOB0olfKhpnjE9mpyH/4AlDC1XGC9/ILGSGqul n9MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264862; x=1749869662; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yF8FpTtagcV7Kwh1mn8c83YxOz5Y2vKGfOZjELVv36A=; b=NW2FDODGl4+psu4VEs2uWCHMKSj7S6K2xky3QqGvbUMhVsc6Wc+TK1mc/CRoN9D/ns dGUMEX7yrpNm2euDOgI3+jBVKFc/f5qPy7YoREQ1vTNwGIwN8IHSOpQrf2X2/7gy7NOm G4BK+m6P6+Jwfet5BKMKIa9F55xpc4hlUJlntu2PnzaS2H7Ehljwa4vVfGfoPybufvbZ Y2J/7+Ndx0l5KLH4HKhHQXmw/6TEAJJp+ggavghWKrWCaxdozUUNMbHlbkEBm5iI0oHE /fEAu57DrEeLDxCrN+M/iSs+Gv49gmJPpntg9hL3AISrsKiosEaA5Z/db1LA2K8Qd+Y4 XE/Q== X-Gm-Message-State: AOJu0Yz4/hplWqdZCgZ72+dDeTntjFf+XPS+a4qMsW2UMhImd8jW3uFn ipwU4ehyDL9cdYwR/+yw1XRvq7ha39g9r2V5U46cqcCXPykXp6slymPTfxi2FGlFBxs= X-Gm-Gg: ASbGncvZ6fgV9Oqgu83UH2BxXMTfylzU5iqOpB+U/1QZAqNYkhzJovERzQ6lngs+KHC 8UUA50tCMHrvD/9pgSrkd/hLRfpp+egZQPt9pecHFk6gHLwgAqd/irLSIaAqBhsWL51C7KqgbBy Frv2xTC2AyAF+DhTkDQ6lVIe/mVSYOFDzvB+bRtqvEP925Dem2thQWXW/3DUMXvP8iIOtiSeYdM b48QmF9JLHxRnIapNhjYMov68qt5KIbAIyiFiuy3wbP6BOGL2ILI3eI0H5BMhcypexJ6CLwTQcu BoTW5QXjPXqOuIJL4A7OS1OjDRsGi1D7uOU9CCQhPiROT81mvImBBW+ZgYA= X-Google-Smtp-Source: AGHT+IEkD+heqmJq9m8IHeuM06OadoFmpx1jvpTqHM7h9oaBrwao22/Hk/I57LZwA/2jHABWh1ERAw== X-Received: by 2002:a05:6000:1a8e:b0:3a4:d0ed:257b with SMTP id ffacd0b85a97d-3a531786a6cmr4798069f8f.22.1749264861807; Fri, 06 Jun 2025 19:54:21 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:20 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:46 -0300 Subject: [PATCH 4/7] drivers: serial: kgdboc: Check CON_SUSPENDED instead of CON_ENABLED Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250606-printk-cleanup-part2-v1-4-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=966; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=YnwRdm6I1xYkzMWD2CGBnm+ACwq/qI6QghdxR3iROfM=; b=cqiZ/O0p08p72ACNj+Qgo78sWzdqazBUHR38ZvlGqr0UR3ruYfxho4i+1leIYi6KW5or2wglX aqm/XqqSk0/Dl9v/iYzwAQDXRcTlLt/HqbQYzkxp32RFtqmxiFoy6EG X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console are registered, meaning that all of them are CON_ENABLED. The code tries to find an active console, so check if= the console is not suspended instead. Signed-off-by: Marcos Paulo de Souza --- drivers/tty/serial/kgdboc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index 85f6c5a76e0fff556f86f0d45ebc5aadf5b191e8..af6d2208b8ddb82d62f33292b00= 6b2923583a0d2 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -577,7 +577,8 @@ static int __init kgdboc_earlycon_init(char *opt) console_list_lock(); for_each_console(con) { if (con->write && con->read && - (con->flags & (CON_BOOT | CON_ENABLED)) && + (con->flags & CON_BOOT) && + ((con->flags & CON_SUSPENDED) =3D=3D 0) && (!opt || !opt[0] || strcmp(con->name, opt) =3D=3D 0)) break; } --=20 2.49.0 From nobody Fri Dec 19 07:49:56 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3C6725A2C4 for ; Sat, 7 Jun 2025 02:54:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264871; cv=none; b=ez8Gq5uLJDoy0ctZpNWgqhgfn9TXKrzyk5oWxYUiBsTdK1H4tHx5CAWNRrD1DaviH89v1mK9bAVnMowEPBsvrccjaaaV3gINAWoWAu6t54jnswDOypyq2c/PxYNdWb8ZJhm7gM2a0wvRkHnHOjhtJE8hAQBTqlGey4eUYa5QjbA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264871; c=relaxed/simple; bh=ZiQkH309SsPv8lN8ObW99ERD0AIPkQszerT12qHwgsk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iSrQM4zEdx5v6TwtKIUyNsYJR8i9H0S4qJQD02NdMrt5c6PFyXLFGZzB5n9aL5MTrVUYF86LnGqTeQGfOqRfQmFKN3uIFlGKAWQLt+WDOdO9qhs/2tnXA27+uDyQzXsGlJmV4+9BFag2jsUuC2r9Xvqs5OLhW43F1brqLVZ8GKg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QseZwSqS; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QseZwSqS" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-450cfb6a794so18448095e9.1 for ; Fri, 06 Jun 2025 19:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264868; x=1749869668; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X/JKVoHG52bM7iYj5PS7gTiSERcG5UqrCOig8DJiksU=; b=QseZwSqSj0+A5J2VqodR6bP8uCtr+YN/25CKSwPgCAYSqOaOq9nWxcTUNf26G4W72m 5nWvitpDE/jzkLGoDXgsOQ5EyKEC5fphVEWkOgTDaAX+KERF/Vz6hayl31vB55Pjo/Hc 5BHp3p+BQCeC0+Quo0/K+3MIUg17U0iLN+cnH+33Es34KDbOetvEKwwAVT2E1O3H5XoB i/3J9jSZ1PUgw3twgxNM6ZzwzgT3Z2S3vgSdvTZmVjDc7bGch1tAaSdkm+06eAxVZey+ f86/7ro+EGaVf0HlqSHH3oF4ywDmmoexk9KjMvYmLCY1bc5UMiMKlNPwk1gYrjhisnzP 7YMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264868; x=1749869668; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X/JKVoHG52bM7iYj5PS7gTiSERcG5UqrCOig8DJiksU=; b=f6r1T9XSViJacraWhG1khgzavPbjQlz1ajXkOkBhWXVF/jY9oyNMvwuJ4VdkZWaffJ kXzUsQBDDBC8/QEiqlKVr3ioSBF30DJm+Rd7bFiMiZfSPU/o5dCTLQ44CdCftGJDb2Hw O+1wBxOdW1KAeZy5mSeXOybic0oDkvBgVkRHhGHZrkf/OitibBhTcCoSux2UfVJ4T/1w fGqMo0Jov6zyeuns6/gPFOYcFN0aIWZH432WKLw+/HXgXeg5jpLD9PNjd2CWLiCKfTcr rVkXc/JMT90Fqh1hR7NPSWNkWF3DM7vNBCdRSsLSyrQ0EDQlCuosREr4dXuGcAjM58aY Objw== X-Gm-Message-State: AOJu0YwZVrOdIoLrtHL8+UMQwy4ZjuwULKuzuBDkJTy5hmjhUFett1V9 1sKuBcw9xqGe0hMCvZ5BXHCglIiASgVWeynUD5jq6RojqSaXt/9bmp7VEsSpcuuwLpA= X-Gm-Gg: ASbGncuWuEcI7QuMBx2VC8U4m8/DT3e0i9x0uenA8lDXx5WJGVeZixu/EUz04jdLqpD 1qBEEGAnZw87c34RJIFuH4N0EIdZEBwx9IdDtY4or1efmGTpw5FACoNNQzTx/TRataf0/Ueb+Le j5GM9Hq5bb3ISQK08sqxnMsWRjLDeOj1j9s0hKsF2xLZ+nV4Gk8Nf6fcnniXbwwfbyHtxe43hQc 5zP8OioViut7VbX1mSC0kFDsz8xB3PuNt+E5+owd7Abw7QMHU6n0+zp3osWIEbT7SD14x7UC7oF PyJWddRnfmZiv4825Ba2XIgvC3ScvLJyrKgydCBpp/YLhCpt X-Google-Smtp-Source: AGHT+IH5d/vDAJyZSz6fuV0j5C8IVfGiu/PKk0FvmAPHACrM59+l4DsDYjrQIDTW1PtMdxhQU8+9aQ== X-Received: by 2002:adf:e705:0:b0:3a5:39bb:3d61 with SMTP id ffacd0b85a97d-3a539bb41abmr1337284f8f.27.1749264868362; Fri, 06 Jun 2025 19:54:28 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:27 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:47 -0300 Subject: [PATCH 5/7] arch: um: kmsg_dump: Don't check for CON_ENABLED Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250606-printk-cleanup-part2-v1-5-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=916; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=ZiQkH309SsPv8lN8ObW99ERD0AIPkQszerT12qHwgsk=; b=jWqGiPKl/XV1kWO8hkwg925xr1q6tsYBxos9FuxBE92z/Pq14tW6oRTqYnah8nuO92j1JK2AA efZNwgbsN74BdsXUFSv+HbPRvTzvr8dhPJfS5pW4gOs10Hl/GEHry89 X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console are registered, meaning that all of them are CON_ENABLED. The code tries to find an active console, so check if= the console is not suspended instead. Signed-off-by: Marcos Paulo de Souza --- arch/um/kernel/kmsg_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/kernel/kmsg_dump.c b/arch/um/kernel/kmsg_dump.c index 4190211752726593dd2847f66efd9d3a61cea982..f3025b2a813453f479d720618c6= 30bee135d4e08 100644 --- a/arch/um/kernel/kmsg_dump.c +++ b/arch/um/kernel/kmsg_dump.c @@ -31,7 +31,7 @@ static void kmsg_dumper_stdout(struct kmsg_dumper *dumper, * expected to output the crash information. */ if (strcmp(con->name, "ttynull") !=3D 0 && - (console_srcu_read_flags(con) & CON_ENABLED)) { + (console_srcu_read_flags(con) & CON_SUSPENDED) =3D=3D 0) { break; } } --=20 2.49.0 From nobody Fri Dec 19 07:49:56 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7047125A343 for ; Sat, 7 Jun 2025 02:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264877; cv=none; b=DIrTfutFO/BM+1czsXddAxrptUwvM26X+7e0p8eAA/BqRAe6prdL0NxhkOX2TgsMuIdZl4730NIx8p/aPGiqaKc+8DdaTCYRW9Aml64Ip4aD4xZGqULmWhCmIvxI8P87Lp4MdBJU/gYTYi7OFm7IXpQN7UYZhiWrwMW9U7/3ick= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264877; c=relaxed/simple; bh=iLfgT9HQWZUDDzN0tovkdkdRnEgGdMwJcOWfpYFBuU0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hNUfgHIEMR9f1DBFObluU1q3qH/UjNRbiXloZi5pVe+/fxeNVocXZO3/PAsjkOIWRITcMggjIyWeojJitB+R+Bw6ZfAMWxzNGzJFDCN/abStz2CDwtdPmkGU22S8mKlqUv7UTaR9AD/ngukPkLNz9wDkWyHLq1EXiDP759PPGwA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=NOa0jP8T; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="NOa0jP8T" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a4fb9c2436so1376010f8f.1 for ; Fri, 06 Jun 2025 19:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264874; x=1749869674; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Cwhjr/MwOcrXAJEej0LaRMGIcO9EQcwPYBdM3grsn/c=; b=NOa0jP8TfuHGiGnE7hKL/+QAnBqOu8pKY/DhDXe5P9VJfjY7iRMfLnONAUSTr+Mvd4 B1Jlr95oEadJ5TCKALdU6JkMmFwGF3ENn1eQp7EN2Z/+4UvUiqQVI5W4PGUERz43Xlch hEnp024VJ6/Eij3jsd5E0f0003wZ/QVfEX4dk84yOlmGl9RoXvkjuxHIs7M87lMrAkSe mrjU7Dqrg0J/S8T8aP00xcasX0yogg40c2JNpJQVzmxb2ALn0RB9fumYFYHhdbm9aa5/ kBaWSE9U0GBO/SREpkKwC+YDCyXHRnkBmhJ1pMwxQ94Sk7rk6IKkn7ifO4ud1s1reKNY RWOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264874; x=1749869674; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cwhjr/MwOcrXAJEej0LaRMGIcO9EQcwPYBdM3grsn/c=; b=WDtrv6aSFnN5hALUfdnd33D7qNGUb2Jt9GdGGpDWlZAjXCj8GPGuKCWx1xisr60DtS DOv5PEntqVXgSKP0SUS1WA9PY5mbpImD5NhBWRl7LnpUKWnlpe3YcwRTCfuiRPBP6mhW txqMaP+AWSx+l+du3wHn0HQh6JJekY/A1/B1iq7ShYpjfdP+Oy2GNXldwo41OgKrJKAa CuXDQn8WDx9t1uQays4oxonGRVbZvNaIw8SRuJiuPRqm2nWBvLQ/iHq+n+oq48PbctkU 4kM5paeJ3qcJ7fDfWxI8ot7OanbCQpwKVhxdpKFeJuL8XjVtCRVrB3GZLmRmf8MTnICY Dxug== X-Gm-Message-State: AOJu0YzfiLats38IgxlvxuTAjah5jIf5T/z7LwybjWhuJyxZO2b4wgvm lspEwpyTxNgf5lYd+z41tVgFWXFBv2QH3XPJRX02nRiKcWbs2Y2rc4vbkoHbYJcSrSE= X-Gm-Gg: ASbGnctnNm32LZm42PnTvRm24UR9g5t31AajXhwasLbYrOwJkWWLxhP6X5oP5UPyxz8 CZvuENv5NoWLiAbA452DC/C0RgR0CnQ3ABK75CyyCL7i7vhNlSIzhuoQ0HdIwv6/NEET0t39LAT iC6NGc5uwo+egTC2NZn+6Mk1IQDPy/3X9XNSwOKJ1X2QEKye3ch2BvpsvLfFvHdmKsgWTnhv5Wg /Vl4IOMdAAbONlRyelX88Yp26kJXs8AiTWUWC7rnJCpY/5r/ike6hDLc/IxkbRXz9Typ6lwcONM GqjW9leDoEbS4OW2n1yC0vmc/ozVDEpRhdsYvYY8QYhy6Wou X-Google-Smtp-Source: AGHT+IHvN9wEy6EKNYkDxnnT81hoywOQZ08WI1JRYEWNl3eQSXHLiVXm+Dos5iynM7Sa+3YILwrh5Q== X-Received: by 2002:a05:6000:1786:b0:3a4:d452:fff with SMTP id ffacd0b85a97d-3a5318837d3mr4663312f8f.17.1749264873645; Fri, 06 Jun 2025 19:54:33 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:33 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:48 -0300 Subject: [PATCH 6/7] debug: kgd_io: Don't check for CON_ENABLED Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250606-printk-cleanup-part2-v1-6-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=912; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=iLfgT9HQWZUDDzN0tovkdkdRnEgGdMwJcOWfpYFBuU0=; b=lwh6KzwEyh2dinkiRzMgjAoctl1hygotlVKEbxBK2YgOdS8fCmLq/Q05gztFUdw0JdxCeH0Hs zy4lhvv4ZsBAeKV44NBYiajx6Sqj8Awb920ZzuYNMmySvPls0kFGTyP X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console_srcu are registered, meaning that al= l of them are CON_ENABLED. The code tries to find an active console, so check if= the console is not suspended instead. Signed-off-by: Marcos Paulo de Souza --- kernel/debug/kdb/kdb_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index 9b11b10b120cf07e451a7a4d92ce50f9a6c066b2..cdc1ee81d7332a9a00b967af719= 939f438f26cef 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c @@ -589,7 +589,7 @@ static void kdb_msg_write(const char *msg, int msg_len) */ cookie =3D console_srcu_read_lock(); for_each_console_srcu(c) { - if (!(console_srcu_read_flags(c) & CON_ENABLED)) + if (console_srcu_read_flags(c) & CON_SUSPENDED) continue; if (c =3D=3D dbg_io_ops->cons) continue; --=20 2.49.0 From nobody Fri Dec 19 07:49:56 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3130B259CB1 for ; Sat, 7 Jun 2025 02:54:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264883; cv=none; b=aKp+LyeULP7QNR3IJVdV+wD8uFqi8VBN/WB+ftM7LHWqzMcQHygmosfrk4IbEf/cZ69vMUf+9ihcnm8XswrKqlYTWAUGccVfWla+t+sTK44aO3q3tHL/RKP7wpwZDE9kSsA9OJINitdB3oiHpuwkfei2Vc37feseeth6pqfw+yQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264883; c=relaxed/simple; bh=KOAUnN3mMocWtW+iziCjb9nXWoqfOr6DrzuAgP6VLcQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AQWsoJCFmHra98TdW/OmZQPg6fb68adM22vjkJYio11wAz4b3wWXHknTwwTtUB5sLQf4/524SxRVjtSSEA0nKsR8D5NGFlu6scLab3kmo5R3CtlTP4137fzcRhb31Al2NzbZ4nBWUBZBQkMrxJyEmKG1Gx8OU2UFdjGkrEVzLJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CJcrzyez; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CJcrzyez" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a36e090102so1641765f8f.2 for ; Fri, 06 Jun 2025 19:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264880; x=1749869680; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YhevvUMxwyVlQTogYhSNRf8D9k2NBoggWts0KZ88AYA=; b=CJcrzyez/E1Usfgi01lgUL2c+RqAUQMQSrj1cIzoQrqQIbJOSbTJTBMMLLvOWrEPZQ wMLdQFQM0cQgDFfeHy8VfuY4MWMBBPAmkw/QkD97BIrhJR3J6/KAuxsmGdTZNvICkN0V zoxInN+bLGbvnZavRPCutHEoEXdvRDYQpH84PoYOGfPQWW3eB0PVtBfyoxQ7xjmF8zPf Xq1wosHczSVOmlu6HZvyttS/nEqBiOiBMUWSucrT9XvLPccRDgVSRRukDN5KHH8CYZpR rVm2eDrwRhiLKJKEPrATzX+odR7AQiaURMbgQpH1U/e1qmmDbf/NmvHyoesIKHCo1rLr uJKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264880; x=1749869680; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YhevvUMxwyVlQTogYhSNRf8D9k2NBoggWts0KZ88AYA=; b=nsFku7zXolK2QaYnWywVRMDLRMOgnSEb5jeeSbYmYklJBAvgTvZ//WQr4InOwpMi3o uUjHFrf4exVnxqYlcaFtjvp/9lI3ZPxLh2KLwyK3xtBzWuLHY+VCrAQ3eGGL67CFDpz+ R24PXP58yH+xphKO6TZiuOmXvHcBl2+y6F8bghLusWps2mbsJ2mbXoIaVC7BTcXSUMMg MS67inHuIw+7I97mS9HRckP6xGLoXrMBc0oIb+Xq6sCHSfhejEgKxVDqip7nQ5CBYBLx 4apLCZnppAfbSsGurBETjGg9W5xesfownWZZOIMQW7w2WXovz3LpLn1InHwI3avOoivJ g+Jg== X-Gm-Message-State: AOJu0Ywt81qfTC83XsZgBlP05lQPp26/NXy5NgDyvl54hs8690XEWHWW fBQoqcPBem5Xvwy8AwhQzVhOeoND5x1tSTS0KhstZd8B1AFfXJcWGvJSH6/fbwT/r4k= X-Gm-Gg: ASbGncu2I6QOeBE9028X3ZjMfrNM/HF1pGuyKCF8svXirgv3DAnxXWkbndZqhJZiKgH DZ+qT7WM60J12+RmSDne+a919EhXr14GTKncwS415t8rBxvVv98dz1GRITlMxCDH6Gttr0yW/f8 LTzYf1eg++Al/lfZ6eELY0wVD+KgJO5x9M2uGvVa21+7CcgOsh2itSilh1XUZAYcovSvEmCQ046 rLV6T2j2ck8QDS1SUhTpgCTJMJHzngtAF02M458INOme4HhaSSmfl+bQ/mbbuLpPHwDdXef+Zwt L7SVvOCLav5pf5PIw/PZ+5MwLTdv0QgEYixHJwkbBTuasgXqq3tH0mfMi5A= X-Google-Smtp-Source: AGHT+IESa5LLq7OFr0HT18MGGSGcdVKv/63HG++r/KCtTOueAXQ6KBohd01OZ9//J5xOfwZkn5rCSw== X-Received: by 2002:a05:6000:381:b0:3a4:e4ee:4ca9 with SMTP id ffacd0b85a97d-3a53189bb71mr4901248f8f.23.1749264879655; Fri, 06 Jun 2025 19:54:39 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:38 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:49 -0300 Subject: [PATCH 7/7] printk: Don't check for CON_ENABLED on console_unblank Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250606-printk-cleanup-part2-v1-7-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=938; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=KOAUnN3mMocWtW+iziCjb9nXWoqfOr6DrzuAgP6VLcQ=; b=GzfZv5dsvZ/BfI8fHIsSyKjTfbS5OZlYtux/fj2GG7XKCatBH6tyzKUHv0GzkPE/uoQqkVILv HIUpyd53iTgDChm4XdkV5M0tDGRMvQF8qArv0LcgKdpzVAZ3g/sR/hJ X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console_srcu are registered, meaning that al= l of them are already CON_ENABLEDed. Signed-off-by: Marcos Paulo de Souza --- kernel/printk/printk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 658acf92aa3d2a3d1e294b7e17e5ee96d8169afe..8074a0f73691cfc5f6373610480= 97ace1545c7c0 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3360,7 +3360,7 @@ void console_unblank(void) if (flags & CON_SUSPENDED) continue; =20 - if ((flags & CON_ENABLED) && c->unblank) { + if (c->unblank) { found_unblank =3D true; break; } @@ -3402,7 +3402,7 @@ void console_unblank(void) if (flags & CON_SUSPENDED) continue; =20 - if ((flags & CON_ENABLED) && c->unblank) + if (c->unblank) c->unblank(); } console_srcu_read_unlock(cookie); --=20 2.49.0