From nobody Fri Dec 19 15:01:58 2025 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54486202961 for ; Wed, 4 Jun 2025 17:46:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749059165; cv=none; b=CvEh52WI4Vx7fAZ90QvOWWshT0raLzHISx1GQBd2/583snNfc+vWZ9nf/B+LmmFOLwlibm+GiJBWVCXty9bDlsuZhmpixpQhkfdVDV+BGuIAR+KQ+anayOguCmsQmhuCMiekYX0vODe3FjLGDBWovtu3AqgV164DMvq8pVxzJDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749059165; c=relaxed/simple; bh=S9utMSb+whrJe0gkOQTuW/1uPCjCRXWgR0gLCJmW1jM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=WVHH/0Z9G7D0zwrMQKt3ny+qAxWcvA2+vQWa8LFMCaCXWIeY0a1ELb7DAXKtsT4rMCHyOIKksNLwhGx+I1AUQNS4vzHjPRnDi5EZXiJqUQD4AMgrcHkmBehi6QJYlLWkkPRnS2mx+8ft9rCC5/0Pu5SHJ4m3h+Pzvzyn824TFOI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NuSNGJaj; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NuSNGJaj" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-235842baba4so600255ad.3 for ; Wed, 04 Jun 2025 10:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749059163; x=1749663963; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=1cGGU1BmGlXJ3HaRLeYSvwuRRXCYMA0JWJw6BA2U8Uw=; b=NuSNGJajoRQbwMwNS70QJbC8oxVtHXg4NTcTHkAF1987wWQZoe+J0UF3/SPLFLNrpj YIXe+xRafzUvrzajF7RTRPJQtI+HKRcOTIax5aYnvT9B43rUc2rh8FWiPujdVSQBL2hH HoLT5iiWhVZ9nR7ixaWbr7h3pS93PIwLBwvvUsuAEUZySgbs1CClNxHxFQq3QCOUfdIV ec9dxMcGT4uBVR0LuToyxihTaJWvGChgu/SdSzT9L5HumE+m/jOoxduTz0XQzOA6eSBT 0JRzzRJC9anLy7N/Z5pXfs8B73L9WUPy3TDufsJJyXj/MhYNfPajP4bEDFc3V9wxzXrV v/vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749059163; x=1749663963; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1cGGU1BmGlXJ3HaRLeYSvwuRRXCYMA0JWJw6BA2U8Uw=; b=EeJWZl8wMHynRnAyGF6a73skg/oSGU1aFdo1j0ujtWTLQ+RxsDqc0gQ/84y/nhiVcG tpIVgb6e6X9TSo5FiaxQo3WbsPTxZSxnjTUZyCHBhWGjTkUJltdk4NQY7l1GXLp7qkT7 20tmw5nje3LsAQwCW4OsgJoDSAkd6XhoX6rV+EFYfBMmyWw8oAfIeuxc0kSd/XGe6wog HsNTPmLNzCuo6CR7Z47AuX9l87esROmQfqLlrfUg5V4nyKRLq+awxjjIYDU8bs8OxuHQ ff2qmEJEqC+Qllws4F70iX5f6h8MUYLsCo/Jh0Q8myrc4priGRz1D1EYkcDQSJ/ts3Gk 5iSw== X-Forwarded-Encrypted: i=1; AJvYcCWRkKPu4CvaRNMIJKScz/hrvnSd6HsLiKh6DdWu1qkxV5NP4vEsmtfLvIRqsoWy28lSktAuCF1aDddxN8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwVZMN3yL4naH4yO2xvuYcWC4fNPjQ+6kj4q01wsGo0WFWk6vZP qmoizQqidqV43pPMAN3do4S1GxrFAPyaK5AZRbIEyUYJ6A2SLAvune7ssfZat2gN59CL4izeB4K 3vuJf15CIVA== X-Google-Smtp-Source: AGHT+IHhRGqORi2SjAeTCWDEHvCnqLh5w62KrOnK8fc8S8eL6+gX+0p9t0Koi7Jd79p+//XZSTY0BOXW1KwQ X-Received: from pgct1.prod.google.com ([2002:a05:6a02:5281:b0:b2c:3d70:9cd]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:2f92:b0:226:38ff:1d6a with SMTP id d9443c01a7336-235e111f38fmr49110935ad.7.1749059163573; Wed, 04 Jun 2025 10:46:03 -0700 (PDT) Date: Wed, 4 Jun 2025 10:45:37 -0700 In-Reply-To: <20250604174545.2853620-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250604174545.2853620-1-irogers@google.com> X-Mailer: git-send-email 2.50.0.rc0.604.gd4ff7b7c86-goog Message-ID: <20250604174545.2853620-4-irogers@google.com> Subject: [PATCH v4 03/10] perf parse-events: Add parse_uid_filter helper From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Dapeng Mi , Thomas Richter , Veronika Molnarova , Chun-Tse Shao , Leo Yan , Hao Ge , Howard Chu , Weilin Wang , Levi Yun , "Dr. David Alan Gilbert" , Gautam Menghani , Tengda Wu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add parse_uid_filter filter as a helper to parse_filter, that constructs a uid filter string. As uid filters don't work with tracepoint filters, add a is_possible_tp_filter function so the tracepoint filter isn't attempted for tracepoint evsels. Signed-off-by: Ian Rogers --- tools/perf/util/parse-events.c | 33 ++++++++++++++++++++++++++++++++- tools/perf/util/parse-events.h | 1 + 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index d96adf23dc94..7f34e602fc08 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -25,6 +25,7 @@ #include "pmu.h" #include "pmus.h" #include "asm/bug.h" +#include "ui/ui.h" #include "util/parse-branch-options.h" #include "util/evsel_config.h" #include "util/event.h" @@ -2561,6 +2562,12 @@ foreach_evsel_in_last_glob(struct evlist *evlist, return 0; } =20 +/* Will a tracepoint filter work for str or should a BPF filter be used? */ +static bool is_possible_tp_filter(const char *str) +{ + return strstr(str, "uid") =3D=3D NULL; +} + static int set_filter(struct evsel *evsel, const void *arg) { const char *str =3D arg; @@ -2573,7 +2580,7 @@ static int set_filter(struct evsel *evsel, const void= *arg) return -1; } =20 - if (evsel->core.attr.type =3D=3D PERF_TYPE_TRACEPOINT) { + if (evsel->core.attr.type =3D=3D PERF_TYPE_TRACEPOINT && is_possible_tp_f= ilter(str)) { if (evsel__append_tp_filter(evsel, str) < 0) { fprintf(stderr, "not enough memory to hold filter string\n"); @@ -2609,6 +2616,30 @@ int parse_filter(const struct option *opt, const cha= r *str, (const void *)str); } =20 +int parse_uid_filter(struct evlist *evlist, uid_t uid) +{ + struct option opt =3D { + .value =3D &evlist, + }; + char buf[128]; + int ret; + + snprintf(buf, sizeof(buf), "uid =3D=3D %d", uid); + ret =3D parse_filter(&opt, buf, /*unset=3D*/0); + if (ret) { + if (use_browser >=3D 1) { + /* + * Use ui__warning so a pop up appears above the + * underlying BPF error message. + */ + ui__warning("Failed to add UID filtering that uses BPF filtering.\n"); + } else { + fprintf(stderr, "Failed to add UID filtering that uses BPF filtering.\n= "); + } + } + return ret; +} + static int add_exclude_perf_filter(struct evsel *evsel, const void *arg __maybe_unused) { diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h index ab242f671031..46e5a01be61c 100644 --- a/tools/perf/util/parse-events.h +++ b/tools/perf/util/parse-events.h @@ -45,6 +45,7 @@ static inline int parse_events(struct evlist *evlist, con= st char *str, int parse_event(struct evlist *evlist, const char *str); =20 int parse_filter(const struct option *opt, const char *str, int unset); +int parse_uid_filter(struct evlist *evlist, uid_t uid); int exclude_perf(const struct option *opt, const char *arg, int unset); =20 enum parse_events__term_val_type { --=20 2.50.0.rc0.604.gd4ff7b7c86-goog