From nobody Tue Feb 10 00:27:30 2026 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B47E11C1AB4 for ; Wed, 4 Jun 2025 15:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749050756; cv=none; b=OvpmCakFaSOmMhX7eXpFw6lN0e3LiT28xPQwKKtfAhOYcBUVEe50WJ5udv/UqXCrb2ttuFtUsTFpXfjaU+4OoaFEfdfAh2HfEmw9qIDWL+0KMs5yrTILsnCrfmliDh0fH7E+lIxcN/fEA5nBWiGHu4KzBPvXAXY/Q/0JgU6ga9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749050756; c=relaxed/simple; bh=c2aRLM4UNSTnoEX6tceyJE+UXM8XBojhYH6J3V4X4cc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SN+CjlMEGmEyfUnkaHF5G0bf/vfHasoHAF1W5YJUwWXn+pjxCjg4aYIXpGyH4zeaLlUISLskDPnPydezLWzxtpDLrDW9lT50cPIG6/RiFVRvBTjKvz/Unyt+OrXaakDZQ+pQLm415GsgVHw/VDvFW0sv1EX2U2W1/pbqkDYaCgI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RCTdkX5y; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RCTdkX5y" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-60702d77c60so1282740a12.3 for ; Wed, 04 Jun 2025 08:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749050751; x=1749655551; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Nr/ud4zCPtVSNmlxUwtSLJlr6giftd88C51EN2S0gME=; b=RCTdkX5y6y61cZ1/PjbmEFR4csWju1gNFmE54iz2BB5eDX4D1FXMr/SI6PQCIdqxJT SF412z/fJheyqeizghdYJMKsUFjck4D4FnZcP3RsxgMBhqj6Xv3+B3YsZqY4Z5f7VCvt dCaOUZ1RHULFMxVzzZdGyVZpeBDyS/8WKsyCbSvn3I+BcnuhTL4ZOyuI6bcUc9tisMr3 GN/zEaRCE95NokJO0KeXqcha40ceRDbwyZZ96PlgXAVNIJqvKuoF9U/2KhmFQ/8MPj4w Cfp7bHxSJjsjDpX9RZE4sYF5lP3NcxrXZGnlfTubwqgchwTOWE/fheqU3wasEaCzZBCq AZjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749050751; x=1749655551; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nr/ud4zCPtVSNmlxUwtSLJlr6giftd88C51EN2S0gME=; b=Epxr7wiIw9KVP6IUUh1zYciMTF4IAGrXruyq9lB75RWh1f3bdHQlAYPMIeRCYu9ST1 NaBW0ZzmgpMGhX1KTglPDF+BAhCfFeUYx76v7bZduW5Dy8LpuayJglFEgKYkpyIIppe+ DXBNbdhaTmiUMnzE+eN4uUu25H0jieNLsIjEKwoXyOWO/qciOBcZ4eFiE+cZt0MDFQZG U5gZd4vvQ0PUZ/WHH4gyuKgO4MAG7bUvAqbMFdIg09KSFGWhT4aVifBn2o4FDnKjZaz3 GFlSClroQpuonjz0oWGtFNlGHvEWGk5HGX7dkiSs29HVGg6zHAB2X7G9FLi6LwFTQETE z3DQ== X-Forwarded-Encrypted: i=1; AJvYcCU5mK3Q78nEAdjJ8pwZVgyJN7mS5BkOwx2+PMns0QsKI1UyWT+OPx7Hvlx37RgaFeLX42cqywGU6UNwlN0=@vger.kernel.org X-Gm-Message-State: AOJu0YyLkljSHwLC6OEc+rB8P/OOjvMerSauA76UXUFIXWbkxDJqVQCu nFakyDu+E9QaGHSbZF9NU1+yaCh+6cGh5j51/kmtycM6jWdiJk285fvhuoH0MTtZRLw= X-Gm-Gg: ASbGncvknL15Ytp7qjTOzjWIiSA1V4XQWyQUO+xK0S3BDA2t3LEBkersYB46BVz78Mu 9NuAFopeglsZ/sFoqjkxROLNNjMKq2j90Y1zaTxaw8UttMrg+8qbiBkae2ry/GdJf2EkLIIHCcV jdNSoSPdFXDt/AuvWg1cO2OtGcoBK0KUduH0fetn1G8Ebym5Z7i4gPg01qneZYbDEmcA/zPSFr9 yQNeKbI/euzgErEA1lct3Lw0EcFN0iHPbTBGa/mLLDPf87wLRf8l/ONAlW4AHfHp1WxfNVtD0WG W7dJfuiFeYpKgilTGJ0SaM1i01mjf4ZJvx4AEHV2MBJ91/GUNWhhFFST1PD98+Ae4Dbr3HFs+ua HTDRO/k870RG/dwbZtSyn0I8zB/B7pgxqyIs= X-Google-Smtp-Source: AGHT+IFqvldrqbeuGwwG4MXV9h4Mso8s2QOVanNgW1TR6F0t21NbLRfi956cnkhEqPoH4VqrXxVIDA== X-Received: by 2002:a05:6402:40ca:b0:601:89d4:968e with SMTP id 4fb4d7f45d1cf-606f0ed4379mr2974440a12.27.1749050750975; Wed, 04 Jun 2025 08:25:50 -0700 (PDT) Received: from puffmais.c.googlers.com (140.20.91.34.bc.googleusercontent.com. [34.91.20.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-606ed984f63sm1051640a12.58.2025.06.04.08.25.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jun 2025 08:25:50 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 04 Jun 2025 16:25:49 +0100 Subject: [PATCH 10/17] regulator: s2mps11: use dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250604-s2mpg1x-regulators-v1-10-6038740f49ae@linaro.org> References: <20250604-s2mpg1x-regulators-v1-0-6038740f49ae@linaro.org> In-Reply-To: <20250604-s2mpg1x-regulators-v1-0-6038740f49ae@linaro.org> To: Tudor Ambarus , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Lee Jones , Linus Walleij , Bartosz Golaszewski Cc: Peter Griffin , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. While at it, harmonise some error messages to add regulator name and ID like in other messages in this driver, and update messages to be more similar to other child-drivers of this PMIC (e.g. RTC). Signed-off-by: Andr=C3=A9 Draszik --- drivers/regulator/s2mps11.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 1f51fbc6c7b6e158f9707c04d9f030b9eee5e842..30586e9884bfb998ff07e314881= 3344b307506c0 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -1249,9 +1249,9 @@ static int s2mps11_pmic_probe(struct platform_device = *pdev) BUILD_BUG_ON(S2MPS_REGULATOR_MAX < ARRAY_SIZE(s2mpu05_regulators)); break; default: - dev_err(&pdev->dev, "Invalid device type: %u\n", - s2mps11->dev_type); - return -EINVAL; + return dev_err_probe(&pdev->dev, -ENODEV, + "Unsupported device type %d\n", + s2mps11->dev_type); } =20 s2mps11->ext_control_gpiod =3D devm_kcalloc(&pdev->dev, rdev_num, @@ -1290,21 +1290,20 @@ static int s2mps11_pmic_probe(struct platform_devic= e *pdev) devm_gpiod_unhinge(&pdev->dev, config.ena_gpiod); regulator =3D devm_regulator_register(&pdev->dev, ®ulators[i], &config); - if (IS_ERR(regulator)) { - dev_err(&pdev->dev, "regulator init failed for %d\n", - i); - return PTR_ERR(regulator); - } + if (IS_ERR(regulator)) + return dev_err_probe(&pdev->dev, PTR_ERR(regulator), + "regulator init failed for %d/%s\n", + regulators[i].id, + regulators[i].name); =20 if (config.ena_gpiod) { ret =3D s2mps14_pmic_enable_ext_control(s2mps11, - regulator); - if (ret < 0) { - dev_err(&pdev->dev, - "failed to enable GPIO control over %s: %d\n", - regulator->desc->name, ret); - return ret; - } + regulator); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "failed to enable GPIO control over %d/%s\n", + regulator->desc->id, + regulator->desc->name); } } =20 --=20 2.49.0.1204.g71687c7c1d-goog