From nobody Sun Feb 8 06:04:47 2026 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E547918FC92; Tue, 3 Jun 2025 08:35:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748939751; cv=none; b=I+Nt1Mcx2DJXgiUUNlXZn+NpwvEMUiTofS6NoPJAhX8rcYlAP4t8XQUCQC7k3p9CLA5Nb7iJmSajRjjDdCF0ETDwLak5AqPdMezGnnfsuLX7fIRleKSqZz+qK8cJXC2nfSk2Kf+g4ISwkFqYu5mkW0eWFye/MXNKy0QdTCHZY7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748939751; c=relaxed/simple; bh=iodA1TKQ/rp5dkp3P8YFyYWk1y8wZhPZffAodSc5e70=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PCy2UTUtSn533Us7E0ck3yDf65cRq/kbxfSY3/Z+AcjL3IuF5r/Z8FNaNKPAZ+nxjn6/xpz0ZZYY4P/bw9IWtySGA2FIfeiGf/mzeN7nSPgESeofROEpPsL2+/BPoOiPPOoMnkENGB5vDuN6+6GZjPeQH1t7SrmLJ2pSUJ9ouNA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=KSlLLa/z; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="KSlLLa/z" Received: by mail.gandi.net (Postfix) with ESMTPSA id 5F022431D5; Tue, 3 Jun 2025 08:35:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1748939747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=1srqlJJ+HV0tLpY/tiu7cWFoNzbjcxmBJOZW2g3nTFE=; b=KSlLLa/zTBpglEQ4+WRGl8m6hWvFQckutVPUKKherQtDW9EawdRjGZ4pGH+Im8l596QO5z zijbQoXjO+NH90VDrtmzNx+N6k0jw5mjJDITnJ3TKhOIpP9Sz0d3g1Uk1JBhY1cYspE3Ar fJYI4oywX9qyu+eqejFtmtpPXcPG1MsRVrTB9dg6M9mG7w9+GBXT+gUlyoCdO9IvSWlu/c EWqhqKNFJZ7SFPUGoTNfXlwUsoW0kMdJc9u2pCh5/i+icwDKYsVLZNRsNbLahWufB04iZX 7UXcGLjJNCBjamL470mhrmQl6wEIrT89lTiL2G9LSfDCaWIO3F9p4+w1P+pOJw== From: Maxime Chevallier To: davem@davemloft.net, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Simon Horman , Heiner Kallweit , Russell King , Christophe Leroy , Herve Codina , Romain Gantois , Jijie Shao Subject: [PATCH net] net: phy: phy_caps: Don't skip better duplex macth on non-exact match Date: Tue, 3 Jun 2025 10:35:40 +0200 Message-ID: <20250603083541.248315-1-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdegtddtjeculddtuddrgeefvddrtddtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepofgrgihimhgvucevhhgvvhgrlhhlihgvrhcuoehmrgigihhmvgdrtghhvghvrghllhhivghrsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeejhfelieehgfffiefftdffiedvheefteehkedukefgteffteevffeuueejiedtveenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecukfhppedvuddvrddutdehrdduhedtrddvhedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdduvddruddthedrudehtddrvdehvddphhgvlhhopehfvgguohhrrgdrrddpmhgrihhlfhhrohhmpehmrgigihhmvgdrtghhvghvrghllhhivghrsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopeduiedprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtoheprghnughrvgifsehluhhnnhdrtghhpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepp hgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehmrgigihhmvgdrtghhvghvrghllhhivghrsegsohhothhlihhnrdgtohhmpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-GND-Sasl: maxime.chevallier@bootlin.com Content-Type: text/plain; charset="utf-8" When performing a non-exact phy_caps lookup, we are looking for a supported mode that matches as closely as possible the passed speed/duplex. Blamed patch broke that logic by returning a match too early in case the caller asks for half-duplex, as a full-duplex linkmode may match first, and returned as a non-exact match without even trying to mach on half-duplex modes. Reported-by: Jijie Shao Closes: https://lore.kernel.org/netdev/20250603102500.4ec743cf@fedora/T/#m2= 2ed60ca635c67dc7d9cbb47e8995b2beb5c1576 Fixes: fc81e257d19f ("net: phy: phy_caps: Allow looking-up link caps based = on speed and duplex") Signed-off-by: Maxime Chevallier Reviewed-by: Larysa Zaremba Tested-by: Jijie Shao --- drivers/net/phy/phy_caps.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/phy/phy_caps.c b/drivers/net/phy/phy_caps.c index 703321689726..d80f6a37edf1 100644 --- a/drivers/net/phy/phy_caps.c +++ b/drivers/net/phy/phy_caps.c @@ -195,7 +195,7 @@ const struct link_capabilities * phy_caps_lookup(int speed, unsigned int duplex, const unsigned long *suppo= rted, bool exact) { - const struct link_capabilities *lcap, *last =3D NULL; + const struct link_capabilities *lcap, *match =3D NULL, *last =3D NULL; =20 for_each_link_caps_desc_speed(lcap) { if (linkmode_intersects(lcap->linkmodes, supported)) { @@ -204,16 +204,19 @@ phy_caps_lookup(int speed, unsigned int duplex, const= unsigned long *supported, if (lcap->speed =3D=3D speed && lcap->duplex =3D=3D duplex) { return lcap; } else if (!exact) { - if (lcap->speed <=3D speed) - return lcap; + if (!match && lcap->speed <=3D speed) + match =3D lcap; + + if (lcap->speed < speed) + break; } } } =20 - if (!exact) - return last; + if (!match && !exact) + match =3D last; =20 - return NULL; + return match; } EXPORT_SYMBOL_GPL(phy_caps_lookup); =20 --=20 2.49.0