From nobody Thu Dec 18 14:09:47 2025 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5CA0221FD0; Mon, 2 Jun 2025 19:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748893203; cv=none; b=Ijke6AhjatVPwPdJgJPoMU9EkjPeUPggx0SlD/qm1mexiJyKeyaW+AYQBzyeGUAU8aQmb/lGxCHCxfwVyTZU0rssSTG13k6T2VKGSVV6lVv+KawOIuHZzEoCpUrhhqAYp6YelHlkcDG0zAtvvHE7uaCeKL9RnkoDGbaM+FRewoM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748893203; c=relaxed/simple; bh=xGkaJcSVZIGZYDU20IlWkf8xu961WZ6N54Xce5GByBA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=c3WlhFMe/nJGrEfY49KhPJAao74W9hwYJuwmz251H7+4uIO9fB6ymBUOOr8QgTvA73fNraKbrpmeEE/oAKpeSqpq0cfGo6MIcVDijCcoCZtYEuLYjBNFlngEaAy6q9Wn0w2Bbrvj5amXacQiniw0MHe6cRRtCh5JuP/QWhpoOh8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ef+ggQyi; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ef+ggQyi" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-604f26055c6so11120694a12.1; Mon, 02 Jun 2025 12:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748893199; x=1749497999; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bchcVw16Rv9Ke6TBr+mieEKvbKHdwpSqUXH/kZd7AFk=; b=ef+ggQyiChSsjb7Idy34WlBbmRuiCE+hN3DmmaUCxLH0uvS69dajEt57eny1XhiVZ2 pjrq342VBL/kFfkNEEnQLh4SoDsk2AseEwO3Ki8UELQWPeTzR8hBs7VbwoOw8YlzQQEF b0S08d/m7P6zV/SrLIM3yuAAPS9lr7iG2SS2SJEEYDvm7actViS6w4N5+JN5kG9b8svR Vr4qCGUimBmXmk8qCIEu0jQ7Cfe0ord00LgPlRveBM2eLXLuShmQGeSnKFOL6kv1Hg1O ql17ICPh/jtK4wccoZDUmWVRRKOes4osdkcyYbKHaVL1beO5mmkgTFcwwuTE/CiWTlY4 337w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748893199; x=1749497999; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bchcVw16Rv9Ke6TBr+mieEKvbKHdwpSqUXH/kZd7AFk=; b=YTsFtVWsPVD652JIsd9wlycKx9o8WDG3UFcM6lbAih35J4ZTfIci1AGF7CwTQXbx/h Y+J/0hpR0jU2Il/ibEw27qs4yF/KIrrKIWiyPM+KoF8RAcWlcgR2kKqWApFe+VavyiWi En/wetJqyyeYtBSCFPdBpN8DS5RyAe/teG1JuugVDWVz1bxbIF7EnZeywbyKbg8oVYPc W3AIp+r+abgmxIGdMoVUt6FmQ0P3cB2gBn8VviSneGyazDv/eTkmq4NSvvvsV0GIrm99 7o67oYDMg38+M60kOMIbKLE8XcxU8lDworyGKkzQg3SiQ0Yw3+PzSQMbW2SLrxmA+1Ih nIqA== X-Forwarded-Encrypted: i=1; AJvYcCUEYsMCkm+nqnUKMfqPFS8lzi6uwSOR8d59nlxdAQdmb5s0zEqysDLd5qmsJyKWZqB/fNYZYXuFgDXzB4Y=@vger.kernel.org, AJvYcCXcHNZZwF6+iXLUAd6MPkmw044oDvapYl6GyVU02JhrLAytJ4c8Pn8OvtaYQs7zxBZLgLIkY2LT@vger.kernel.org X-Gm-Message-State: AOJu0YxFFI3QLX0wJNPzlc9JPn7jc+QbZMkndq8ErGaJf1+t8JtmHsPo LysmKaKg/+5HpuKCOVsazOEA97iwLNcmcpYDAz05QWpSZoazJBubdxqp X-Gm-Gg: ASbGncv6J/wfFF8mML9tqntmaFlbviTZB8VzfOTB8duzahERsbEzsyDMvVq/srW05KM ScNsHyk4A997iI1cvCMtbbLTLGzJGgXrE99Jq0VqyWWnbq2PqNZ4+nesUMAeNIj+OHNGspZURlI LWfKK8LQFl9vMwillwlC9uBOm1FzmcLVCOiJKmiqJalY9woOvz8l4PNRNz19e5cPwP0uqt+Vcrx U4g/I1GmVxrXTgEj0mFhGZo1GJgS7RkrdQ5q2AcxQ4E6D28Z5wUe2ALAoIwdQ3Ae197L1VWQ406 Q64/UMwBch1xDWmqH1maZoxbDouYHA5rUbE4EuS3azIUCebVfeyk2DP25fjPaNQn15CfDlOScSl HAalkx2DFsmf674xX5NSHSUsi/kZ1XfE= X-Google-Smtp-Source: AGHT+IHb/jsqEVAsc45ECKj+RtiMfmptnFT6BSiubYaBx6CB3I6qZSBCmHXuavZdxbsd0dNItTWoYQ== X-Received: by 2002:a17:907:868e:b0:ad8:93a3:29a0 with SMTP id a640c23a62f3a-adde0d54c7cmr69970766b.18.1748893198864; Mon, 02 Jun 2025 12:39:58 -0700 (PDT) Received: from localhost (dslb-002-205-016-252.002.205.pools.vodafone-ip.de. [2.205.16.252]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada5d82ccf8sm833259366b.44.2025.06.02.12.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 12:39:58 -0700 (PDT) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 1/5] net: dsa: b53: do not enable EEE on bcm63xx Date: Mon, 2 Jun 2025 21:39:49 +0200 Message-ID: <20250602193953.1010487-2-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250602193953.1010487-1-jonas.gorski@gmail.com> References: <20250602193953.1010487-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable BCM63xx internal switches do not support EEE, but provide multiple RGMII ports where external PHYs may be connected. If one of these PHYs are EEE capable, we may try to enable EEE for the MACs, which then hangs the system on access of the (non-existent) EEE registers. Fix this by checking if the switch actually supports EEE before attempting to configure it. Fixes: 22256b0afb12 ("net: dsa: b53: Move EEE functions to b53") Reviewed-by: Florian Fainelli Tested-by: =C3=81lvaro Fern=C3=A1ndez Rojas Signed-off-by: Jonas Gorski --- v1 -> v2: * add Reviewed-by, Tested-by drivers/net/dsa/b53/b53_common.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index 132683ed3abe..8a6a370c8580 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -2353,6 +2353,9 @@ int b53_eee_init(struct dsa_switch *ds, int port, str= uct phy_device *phy) { int ret; =20 + if (!b53_support_eee(ds, port)) + return 0; + ret =3D phy_init_eee(phy, false); if (ret) return 0; @@ -2367,7 +2370,7 @@ bool b53_support_eee(struct dsa_switch *ds, int port) { struct b53_device *dev =3D ds->priv; =20 - return !is5325(dev) && !is5365(dev); + return !is5325(dev) && !is5365(dev) && !is63xx(dev); } EXPORT_SYMBOL(b53_support_eee); =20 --=20 2.43.0 From nobody Thu Dec 18 14:09:47 2025 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4CDD225A3E; Mon, 2 Jun 2025 19:40:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748893204; cv=none; b=LeN479q9OdjSbVV3uD7MUSbV1mTsk5ZdZiQvpuwENMUR5jyFR4l3vJcwx8tmacYAZFxkmBcjp2X9Wqnxc1/E5rBhE+5X4gZxJDWY3zEDrvSX3p94nt/eaBmsnQsgQL89/NFegHHf9n7PqKdf3Hyd4zR02Ee9HGwrXqfMHGJdRoE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748893204; c=relaxed/simple; bh=68r3wPwjDt0zL8t3mh+K0SjtOAmg8KmOb8Icr5kChOc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YQ7siKmEjxrhvel2B+FjG+aF49yDtYoL1VIxEsnVC5c13tguhxRrjFkrT0zU276ZeHQKL3/53DLRUa7cxBMuJCnmTcEuD6tn6MfsoSWs/lxXU6a4czsw2+uhZ9Z8UHk9NRVWcDdswNrgT8mH0Gx+0EW7qCmQrYv4nONpsDcmWYE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I4tpRqSk; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I4tpRqSk" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-ad56cbc7b07so725922566b.0; Mon, 02 Jun 2025 12:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748893201; x=1749498001; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z1kdwLfxxgBxhd368S9lStLqHiV5zPBZeoferEx4nTo=; b=I4tpRqSkqITWMIVizjlhYqBMmiH6tks/Zq8+rrQC8UgVzavNJB34NGu6s1yYApYI29 q5l1xlGjHQ3svt1eRDUtYEnR9xCDCkSzrEEUBhyGE5AyWtepQbhfi5KQvU8wofFB3rWc HyPB2HgeGvxxFCmAICKF2vB+a/z2f+JtOUWuNwLnhY3jx5MFauZtfHRF66ginem5G/jH NiGIn8HYz7Nr/9kqe03op01RZPin/z7CJDqJz5AG50Qzq8mpUHm1933aqsiee9lsFVq6 kLc1vWA9bXjp8ynRRAO/xUyrOyLh5j4dkVKZeznvjw3kgrdYFOvQ8A0nU0EetpXcQYZN 19Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748893201; x=1749498001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z1kdwLfxxgBxhd368S9lStLqHiV5zPBZeoferEx4nTo=; b=WUpgk4I7qJAgMyhvzMDgLlJb2iTZcCLgawCO4tDKlqu4GYN0F351dQpPzCKRDvMHJ9 q8BgmS6JqizRpctlBha6e5kl4XqPictN+9M7bAKlZ+kjtK/h8jvyZhEmJ6V2vDE5GkjR l0tth0pXA6EoSn6a4w3PO3IKhRRbiCzX4yU516A7uzRaMSH5inq7SmcBoR0AwUVnld0t 8XLu1HXf8buzJS1txooS0QDQc2ASjBh60tYN2OHiMLvq+51kvH6OB8JllpThF5DGBWir nhYKV2vASVvdTyvR1I/zDuQdtx1Ii2O4a55Vjyk45RwfLhEJW88kbTuKv6G2k3SqsXQQ ahNw== X-Forwarded-Encrypted: i=1; AJvYcCVSmhm+ajjaWtADCJpmOYXid430qcTEce/b0qX9WURv3lZuL+kH3n7Uwa5JZboIG9aE9XtuzXp1DjgvXRs=@vger.kernel.org, AJvYcCWRll5d4xm59jbpZg9Pp8OfiEXlXNhvRIxliul62+X3yBcxcjBetpc9du6lzRrj4KtAvh+v/oYN@vger.kernel.org X-Gm-Message-State: AOJu0YxUGktPgKHu6Sy8Z27Q3KQ/eDo3bu0b5VSW8Tw/lRevqIaM0b4S OEbcyIAIZJlNxMNVPIoYoeDfz/lXMYKrzDqeHEyE64eUT0t13cH5W7So X-Gm-Gg: ASbGncv2pVDIlbk1gUcvNZtxIzOVlHzXq1o9Jc6Fgdobvw/NHVRbumXPTE+9pybeAC7 sOzhZS0FdvO1RcQyt/+tupoFo8dsYluqidyOtJLUQkvRVOlgqHzH9AC+nRcHA8xmth8m/pVea11 YkwZarr2u4J7RkcFUwRzLBzigGHq7ifP9j+6hEwWFlpFbxOnDRVenNqE60TUFC4ujvjwTzBNUvu gPDNoBV5onTcoX2JIa+xk/orvhcxHHX+16QxoQEsmQ6i55okyBBQ6qR8EvDD4zOLg/C90IASaka q3j4A8m7dVYNpHUPiY6KUp2sNvoeeqAeE8VIIn+C7TXoZmMbcATwC4YFrGzId5RQWq/4omy7++/ Os/ScZPXwfg911Z0L8ysH5Mrrwm6ZSJg= X-Google-Smtp-Source: AGHT+IGxPpwGJUoggNwpvH28ETsZWehMuBwg6JTvz0UkyKRTMkeeStmkImkTmsVVIjWD/XXBsnlFTw== X-Received: by 2002:a17:907:944c:b0:ad8:9257:571b with SMTP id a640c23a62f3a-adb493ca4ccmr1027885866b.16.1748893200751; Mon, 02 Jun 2025 12:40:00 -0700 (PDT) Received: from localhost (dslb-002-205-016-252.002.205.pools.vodafone-ip.de. [2.205.16.252]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada6ad39df9sm839053966b.131.2025.06.02.12.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 12:40:00 -0700 (PDT) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 2/5] net: dsa: b53: do not enable RGMII delay on bcm63xx Date: Mon, 2 Jun 2025 21:39:50 +0200 Message-ID: <20250602193953.1010487-3-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250602193953.1010487-1-jonas.gorski@gmail.com> References: <20250602193953.1010487-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" bcm63xx's RGMII ports are always in MAC mode, never in PHY mode, so we shouldn't enable any delays and let the PHY handle any delays as necessary. This fixes using RGMII ports with normal PHYs like BCM54612E, which will handle the delay in the PHY. Fixes: ce3bf94871f7 ("net: dsa: b53: add support for BCM63xx RGMIIs") Signed-off-by: Jonas Gorski Reviewed-by: Florian Fainelli --- v1 -> v2: * do not enable delays at all drivers/net/dsa/b53/b53_common.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index 8a6a370c8580..c186ee3fb28d 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1330,24 +1330,7 @@ static void b53_adjust_63xx_rgmii(struct dsa_switch = *ds, int port, off =3D B53_RGMII_CTRL_P(port); =20 b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl); - - switch (interface) { - case PHY_INTERFACE_MODE_RGMII_ID: - rgmii_ctrl |=3D (RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC); - break; - case PHY_INTERFACE_MODE_RGMII_RXID: - rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_TXC); - rgmii_ctrl |=3D RGMII_CTRL_DLL_RXC; - break; - case PHY_INTERFACE_MODE_RGMII_TXID: - rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_RXC); - rgmii_ctrl |=3D RGMII_CTRL_DLL_TXC; - break; - case PHY_INTERFACE_MODE_RGMII: - default: - rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC); - break; - } + rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC); =20 if (port !=3D dev->imp_port) { if (is63268(dev)) --=20 2.43.0 From nobody Thu Dec 18 14:09:47 2025 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73B06229B21; Mon, 2 Jun 2025 19:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748893206; cv=none; b=dVTa1Z6flCZ1dgf5S+6jEZ9xOvuF9T2EiWEzfSxkBBIdBhhH9w+iMO6hPZT1Fajpr/84o2qQcp+qCZcikQuMJA/CkI5RRm147Yy0Fbq+lbAJSYZdv4FsfA9HHLTml/I8kz6TLijeqYP3soPK8aI1s5O3k7MEs6BbkKLfEnuFLus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748893206; c=relaxed/simple; bh=FM1OIF5jyi3GYdMHYCF0YylKd/eZT9LkGNpp/L0y6EQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FhVJLEIcghh58lYG1wj7fjeUBxGOI9655jmqyXpBjlcGQRJu4/5B1hBz84EgxtQDLD4OENM6hsgtndDORdGrhSeUBUhS+3ItmxONIkOMqQWsRln94+fFqU+SNoFwqrfBxSmNz7F8Zh0io1fdKX+Q0Jy+jqGogNrz1PMx5G6iU3E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dG/c9lAS; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dG/c9lAS" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-6020ff8d51dso8185791a12.2; Mon, 02 Jun 2025 12:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748893203; x=1749498003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nrFcz0jrIGdyNJHISHvZtvCzGrxOG0pxjV0WsjejwPk=; b=dG/c9lASoJgWmimiUkxmuCRcDXZNRBzTr+XdD+HSp8yR/9MOupG0g6q2GDZJI7ULS3 vt1V4fyafWIyHC9lIimO0jm4KTU32QG2cHC2rIyaXut9Y1XjyRNKLrqrwJAiEeXwXl9a b0/wPq/7PwsP6wgjfkBBz5tQv41cKCALYsN6TEFOk0KAQY/hhai6UQsyS2BYNdmtsMy5 g5XbXDWciLo0iULFBbYtGfnbQOXyK4WokGTHkW87VDU2YqhWo4ZmqLsEsqkqmCzFoiEL td+4riOoVc8mfXXfM3v3TAd6/Loz9Pfj5maEwtYPVtdV0+D83mMWDgy7o0Fie3OWHWMK 9hrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748893203; x=1749498003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nrFcz0jrIGdyNJHISHvZtvCzGrxOG0pxjV0WsjejwPk=; b=dx/X6WEeWfFuX6eFQsMe+5R7RUdwwoXCeZO2TdwFV5Sap9c77TspBI/12VFQh7yI1c RRExmtqheV0cTk0DCDqnlyL+OZdvBRV8s0ZogqVTLL8Kxs3xJk+NqQD8p+QcAITgxfA7 YpUqdIKRktuRmQIibLtitreAR37grDwfPcgrEbFN1BoKSUOKmHUbaOhgJnfgBXRwCA4J ZIHlBGhmX8xkA5nmo7K9fWVlUEsLc2n4SiWFSzwtB35tBxuRilbVnOJlGn4J1Vk82VJk g91Ep4IKogtS1Sdn6vacrIZv+cEvdAMVgqWwS6EDf77Q29Z/JXnFK1GYT48TnxOfvXqX CsVA== X-Forwarded-Encrypted: i=1; AJvYcCU9SHvz1o0Kcl+cMvkwjQ9+PSCTXiits8gL4RCaTfK58gMs/mjoEGwIn1jMsTZ+ak1yTwTL3SIaaD8M3DY=@vger.kernel.org, AJvYcCVGiX7uJE3VkYssRJ8UnQtJ3YVQTBjjPKPTGp7/D2zIof+Wk2X0QCxwhHXRPvji5Bi/fqTId/gA@vger.kernel.org X-Gm-Message-State: AOJu0YwRccbIVhbgphoCDNsAaagd5qSfIMdHc5g5ffOIxx+3LkO5+Wd+ UeKOCEZHZvV+d4OfsuG3pjrjWsXXVgAaN/s09dYik7Yqwu3woVMXRKQQ X-Gm-Gg: ASbGncv6SRASrXY8+ZwMaZjf+dunWknnEFAqX5ZJAXa1oFobdn6rkhBLFmVTTJcLnyh V0Mkyak4A8rN1tR+zrn/YtlN4FljJniiAVUD6nGp4y414w/EXEcp2ppsncKwSqcNgkwgH43i2f5 jUOt6VP0PtzQTU94+1h+nxJq/m7miHEz956fWIpmLJ1hVvr6+PxkkDQDK0A+AAHma+ggYqEZotn XibYV+916zqyo5IL4NszQCbMbXLVQ3zbnY0xlQXCk6koTda1wIxp8N5mBo8e+YxAGeg/QJcffIQ i7qMGttpUuXZewEOEFOa3LY/YmBtto2JdQX2pVLIgYtf3kzE0LLogV92+6+2eK3Rmy5tEVIYbVt dOvlLl5gBQjFpYnst9ok8m3o0BhSWflE= X-Google-Smtp-Source: AGHT+IGr47poasSImkj54X863XNyqV2MwrfPoTrDvP0NBAw+QQ34FKdUMNXBbfeEjeiuYOBtR8RJdg== X-Received: by 2002:a05:6402:5189:b0:600:caf:51f1 with SMTP id 4fb4d7f45d1cf-6056ef01cb7mr13750942a12.28.1748893202626; Mon, 02 Jun 2025 12:40:02 -0700 (PDT) Received: from localhost (dslb-002-205-016-252.002.205.pools.vodafone-ip.de. [2.205.16.252]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60699731f06sm554420a12.27.2025.06.02.12.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 12:40:02 -0700 (PDT) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 3/5] net: dsa: b53: do not configure bcm63xx's IMP port interface Date: Mon, 2 Jun 2025 21:39:51 +0200 Message-ID: <20250602193953.1010487-4-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250602193953.1010487-1-jonas.gorski@gmail.com> References: <20250602193953.1010487-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IMP port is not a valid RGMII interface, but hard wired to internal, so we shouldn't touch the undefined register B53_RGMII_CTRL_IMP. While this does not seem to have any side effects, let's not touch it at all, so limit RGMII configuration on bcm63xx to the actual RGMII ports. Fixes: ce3bf94871f7 ("net: dsa: b53: add support for BCM63xx RGMIIs") Signed-off-by: Jonas Gorski Reviewed-by: Florian Fainelli --- v1 -> v2: * new patch drivers/net/dsa/b53/b53_common.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index c186ee3fb28d..3f4934f974c8 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include @@ -1322,24 +1323,17 @@ static void b53_adjust_63xx_rgmii(struct dsa_switch= *ds, int port, phy_interface_t interface) { struct b53_device *dev =3D ds->priv; - u8 rgmii_ctrl =3D 0, off; + u8 rgmii_ctrl =3D 0; =20 - if (port =3D=3D dev->imp_port) - off =3D B53_RGMII_CTRL_IMP; - else - off =3D B53_RGMII_CTRL_P(port); - - b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl); + b53_read8(dev, B53_CTRL_PAGE, B53_RGMII_CTRL_P(port), &rgmii_ctrl); rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC); =20 - if (port !=3D dev->imp_port) { - if (is63268(dev)) - rgmii_ctrl |=3D RGMII_CTRL_MII_OVERRIDE; + if (is63268(dev)) + rgmii_ctrl |=3D RGMII_CTRL_MII_OVERRIDE; =20 - rgmii_ctrl |=3D RGMII_CTRL_ENABLE_GMII; - } + rgmii_ctrl |=3D RGMII_CTRL_ENABLE_GMII; =20 - b53_write8(dev, B53_CTRL_PAGE, off, rgmii_ctrl); + b53_write8(dev, B53_CTRL_PAGE, B53_RGMII_CTRL_P(port), rgmii_ctrl); =20 dev_dbg(ds->dev, "Configured port %d for %s\n", port, phy_modes(interface)); @@ -1484,7 +1478,7 @@ static void b53_phylink_mac_config(struct phylink_con= fig *config, struct b53_device *dev =3D ds->priv; int port =3D dp->index; =20 - if (is63xx(dev) && port >=3D B53_63XX_RGMII0) + if (is63xx(dev) && in_range(port, B53_63XX_RGMII0, 4)) b53_adjust_63xx_rgmii(ds, port, interface); =20 if (mode =3D=3D MLO_AN_FIXED) { --=20 2.43.0 From nobody Thu Dec 18 14:09:47 2025 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9964322D4F6; Mon, 2 Jun 2025 19:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748893209; cv=none; b=X4y7lFgv59ISt8Nj/WFV9UW2FCT2fCMl1leIWVaKSWhLv++1D6zJR/KC6arQr9U4NZbZl4ogwt+2QBgRIZ5gZtLZTN/4dJedsnnU1zSZhdNlXFIc8uehEdthXCnqeKy1wSdPXX8RJQ86sMRhCIq3J0smvsVrhnkXcrZtg56D5bw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748893209; c=relaxed/simple; bh=kaMgHoWYLYvGbfKuyz8FjfIvHL93d78mxqSd9irxe/Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jzaYJQYkaXtErYvGr1/gVAfxHsRDWrKJbSJtg49ItLgHM4Yg8wBQJKo/laaet6aGW3FcMj500TR4xJPqvyh6jr3AB+PxwDC7qjoLTgr0DUVbX/IlwXb/Mn/JADpVAg0+mRC79kbSO112WJmDvvm/hf8r2ZJZN3mR+DRmil3LSv0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NdFOxf0K; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NdFOxf0K" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6045e69c9a8so9228967a12.3; Mon, 02 Jun 2025 12:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748893204; x=1749498004; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QUzxaG7r98wSKohMlOOAAhXemIOrwTNYnmCUuKws3h4=; b=NdFOxf0KjtRFLAA2Xhq38EoKda423tiQXWsYlmSK01M3nh4jRMXnoNdnyPlehgSErm xDCP3XACm03SSKCL5VjMaCBIcWxsQ1QapHnuttJ0UerpZYAneTIG10loY5Ce/RWUdd2B o1jSLNsmOrrFxFh+Rk2fmqDXU7+Z6ASeQ8QHgZYmvIMsKeCvbBDVLWJSm6B/9BYaaWEm GqXlYlEVx7fCJbGhXBt6EhBk5biczv14eob0yG4q30RwHjRBsjQbOyNCn6dBI5ZmCsTS /EwAvfvl/5fZxzjQW6v2grsS3nn4IBux0IjJPtv+rDaNXWo2SriajClAy2qv0A3+gaVc GZ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748893204; x=1749498004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QUzxaG7r98wSKohMlOOAAhXemIOrwTNYnmCUuKws3h4=; b=Hrhf3wV78f95bqu/Zb+akGX9s0NTjHF+MRU7JXW4VD5FcYjmyZwlBEZg/9wYq3Mqcp 69cEq8vA5NCxvWojsJadiNZ8DDdEC6IFYL1FegPvzhVhaDNiOMIbmcixb+NYtaW2ZkYp YkEWbgpphlBljh8uDf9phoqAr4Q/tpS7/7kcyjGpT4zMa83poorNT1HVdmPlcrs1RiJk Ge7LAEdvl6F9Pvm23jPFAlO/x5jMb/G2z5SKHiJ0qutxb/WdZdYoK+iutp/zZ3QVEL+p VWV+O/pKHn2Z9tfiVH9aE9cGhoNOO+xetHfWS+QVyur7mUORyA8pO5GOmP6ZbEotIhyd JIkg== X-Forwarded-Encrypted: i=1; AJvYcCWOfEVcgsQToKxBIOt2T8+Gj0+x/AqXjQvBjYTIaPM294xk1agDLpi3XOHTBg+XGCa0aF2hZwvhwruvp1o=@vger.kernel.org, AJvYcCWvICTiKZXJzcBkuQp93TUuudq1CjSnyFENm2Gje3TfryWD6pJ5NXuyFNq1TnJCOjeQV1ZVDJkm@vger.kernel.org X-Gm-Message-State: AOJu0YzMOvAFSSFkN1TWz57ES00HUCohmFxc/Sp9eed+LuS0Pn4U/lT8 LxfKm+pVC144iiwKjriGnfMbA3EuMPQ0jlXGpI9MFSFptAbhQd/6WgyU X-Gm-Gg: ASbGncv4Yc//NO4s05UQ2yexFYFRdS16fk3/OR3FOcQz4/YC0E3hnoEs9N5xLexABSm XKd+MQv/ZmV5+VKRAkpdB+ziH58IkQb4OYWHdCqKn8RqWLiPqOoi9hwQJaPQTZnhLgwSmw3v0uh wwRcpyJsxRmPmPpLFA402UwAuKAYFWPGx4bp9oW6XIOYi3bStwZNxse09kv/ZKPc8YgXlQLn2Vt o/Py2WCX+OVoRaBDzzrj4v2zGnVoc+kuFjT9D4H93gNvLjMLJgmYeLMt1yfqAX0A9xtsLuxihgg h7dkfSQ/B45fdwxf/BRUsuNnlL4GXko+4CDPADNKm9jDT8UmmAP8RbfgqS7mCZw9uNxWfCmRpGI oxxg2wUGYqOmpApHhmSE5a7fiARSzZ9M= X-Google-Smtp-Source: AGHT+IHfZPl4EHqdvcHEsmAE+HPej3McuF8SlAf973Eld7dW+ssySVbsuESuRGVDGhGTauQmWW1q4w== X-Received: by 2002:a17:907:97c5:b0:adb:2bb2:ee3 with SMTP id a640c23a62f3a-adb4954948bmr908599566b.46.1748893203784; Mon, 02 Jun 2025 12:40:03 -0700 (PDT) Received: from localhost (dslb-002-205-016-252.002.205.pools.vodafone-ip.de. [2.205.16.252]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada5d82eee2sm840999866b.73.2025.06.02.12.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 12:40:03 -0700 (PDT) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 4/5] net: dsa: b53: allow RGMII for bcm63xx RGMII ports Date: Mon, 2 Jun 2025 21:39:52 +0200 Message-ID: <20250602193953.1010487-5-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250602193953.1010487-1-jonas.gorski@gmail.com> References: <20250602193953.1010487-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add RGMII to supported interfaces for BCM63xx RGMII ports so they can be actually used in RGMII mode. Without this, phylink will fail to configure them: [ 3.580000] b53-switch 10700000.switch GbE3 (uninitialized): validation = of rgmii with support 0000000,00000000,00000000,000062ff and advertisement = 0000000,00000000,00000000,000062ff failed: -EINVAL [ 3.600000] b53-switch 10700000.switch GbE3 (uninitialized): failed to c= onnect to PHY: -EINVAL [ 3.610000] b53-switch 10700000.switch GbE3 (uninitialized): error -22 s= etting up PHY for tree 0, switch 0, port 4 Fixes: ce3bf94871f7 ("net: dsa: b53: add support for BCM63xx RGMIIs") Reviewed-by: Florian Fainelli Signed-off-by: Jonas Gorski --- v1 -> v2: * add reviewed-by * do not enable RGMII for CPU port (internal only, no rgmii) drivers/net/dsa/b53/b53_common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index 3f4934f974c8..be4493b769f4 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1439,6 +1439,10 @@ static void b53_phylink_get_caps(struct dsa_switch *= ds, int port, __set_bit(PHY_INTERFACE_MODE_MII, config->supported_interfaces); __set_bit(PHY_INTERFACE_MODE_REVMII, config->supported_interfaces); =20 + /* BCM63xx RGMII ports support RGMII */ + if (is63xx(dev) && in_range(port, B53_63XX_RGMII0, 4)) + phy_interface_set_rgmii(config->supported_interfaces); + config->mac_capabilities =3D MAC_ASYM_PAUSE | MAC_SYM_PAUSE | MAC_10 | MAC_100; =20 --=20 2.43.0 From nobody Thu Dec 18 14:09:47 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04D5822B8D5; Mon, 2 Jun 2025 19:40:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748893208; cv=none; b=ky/d9PChMVMYQGVS/Q6l7DLD3U7tJ66hdjEwhVIEIPpdOJVCSDLFIcEuk6d3zYAPRaO216Z37vh+ehmCtCY5JvzyKU7rIxRmjmmZonaGNy4mOPngA+woZ1jCoCJ9iw/Ap8lsBHZCcajwkDBNow2pMc9wsNBjp9mHLt2jm+WOtwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748893208; c=relaxed/simple; bh=W5lvTQJx8Rg2GZ2MP+aKOXYOVUr4A7PTN2EZRYjapYo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hRFvDTZHTT6f4Oo9R2wQISXCxNuXAXylcjJi7DWDY3eXYPQf3+MWaRKOf4O5FpwE08wYCM/Nga7nRjcdByZvXxbZmBf7h/Mxu+8ZdnqcHmkYLz/jYcsp3VuQM5HqtK+6k/mnSTWJu49y7TXhoMjSIhX6fQOa++4qWL99u8A/2j0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pj0V2lnB; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pj0V2lnB" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ad89ee255easo883048166b.3; Mon, 02 Jun 2025 12:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748893205; x=1749498005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+BTL5MAqEteMn2C6CJSs7Xxb84R1E6RDMzhMA/qaLVA=; b=Pj0V2lnBYvoGTPyZEzwGz6BaInBDqGEgAWOmMUb4Ye9bSpM0lEmRobvrNWARwYWDqB P/1gNjpxakg3U6WkUWBHp+cNQlNLzK2Loz/9ip9OoKaJ+8EamOf84UJEUdu/ss1YdCnK BxaKsn4/Jm3VoGBQy8Zu8pNOH95ieutLe5hS4y5MIW9sbvCqWEZo0BXUVJVXsvvz5/kO b8n4dCIcDptaPIZkQoY7YqjEWxqdDVzejhwLIFIygjQlm49ppQWW72Vga9UznUaZwHe/ 8IgP8L9nNOloRB2t6XpkW4vX5pOGrwmOWVcRHG9+SblWVh+3AuzTEGiw7x/IkS2L64xD arqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748893205; x=1749498005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+BTL5MAqEteMn2C6CJSs7Xxb84R1E6RDMzhMA/qaLVA=; b=pj3HyeGG1d7cxVG+zsWqFKWOmHrZzdPpURdZYSm3h74uFfH7j8R4KUca9H3vERzXFc XN073N7fQihxOIM7PnHfhacGMxkSzlnGw6j/MPYufFte9vb4RhTCk5ZfI+AzcXWK3U0L hteYqF5agjKqIN5fLuBQMhXhaJ+gjctjQNNG1RkZ2IVabhvKx3G/7AJJ5weO0Biv3zlA ubOuMl0bpc75+uoLTcCb/Yf1PhIr9kBlNG1qaMeuOPIfXKIhzfMDdmD3tolZ9onN0Z41 g5nRfZkUfg/+N4sX0Wa6AdbxgSaoIANFlrtfeEr4YDw2EwG09Mot8yl2GRxJBj1GyDac 1hMw== X-Forwarded-Encrypted: i=1; AJvYcCVchPVU8Elz2EAPFgKZ26FqOcRh5BkSCCgDIXlJB1htfWgDlag4LSTxcq/pIToLb4fg9DlIW+py@vger.kernel.org, AJvYcCX7Gd/RVrTxUthq3Zi1euAK6qJxOnGTEpuecQF5WnpkQUOu1zBNkaVyoHq84KocWHhJn3zUQLdhLOKunqI=@vger.kernel.org X-Gm-Message-State: AOJu0YykeVwbaRrztmXXQd+nv3NMZYsifhnlvmRZoqdc87b/u19N25B4 nbTf0aYDspCHoDmuh2vdIwyMe92LrzF+NOeE/nLec8kdVOuWKwFqzDvJ X-Gm-Gg: ASbGncuSuuNqY+2pIqVgQpGtAc+rX387hsNQ1P4/w31v3Hzp96pNOeZCJKB5N3dNx83 KqgOD52q/JGZ10aZZO+yxs2Qdxam40wr4MxE5kFweRDrKHKE4h+L6z2aQ0wx62m+5E/0dNq+VpW DLue0TBcl/RGrEBJbV5aMNQJ38K5grgeYG4Ps/BBLFOmlMwYYLxBLLGAhX9UYQ9HdArYCvD+YQh DWoJv5QEMOyln/3TGB5Y57terRuVAuI+9JW/u02hHhtUL7CrCwHJGt7O6YmmUt+Yu3dlpqZcaNL XLtSGb6YtiHyHD0mMeHL/fbiHxJH9B9evg4BtX6lCsVctFUsMsZj6u67Zp9via4hoOHRmdAzQxr jlZ9qpA03bmUn1tG6eGMVFXBFgIbzaZg= X-Google-Smtp-Source: AGHT+IEqz3Qmt4vvH+dy3OjSllvjqINR9VvmuImfx9Uc2G1BzrLLX4CcXXU1AXe+rWU4Oad0XWPB7A== X-Received: by 2002:a17:906:c143:b0:ad8:9428:6a3b with SMTP id a640c23a62f3a-adb36b05316mr1286729866b.5.1748893204835; Mon, 02 Jun 2025 12:40:04 -0700 (PDT) Received: from localhost (dslb-002-205-016-252.002.205.pools.vodafone-ip.de. [2.205.16.252]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada6ad6a76csm832322866b.165.2025.06.02.12.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 12:40:04 -0700 (PDT) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 5/5] net: dsa: b53: do not touch DLL_IQQD on bcm53115 Date: Mon, 2 Jun 2025 21:39:53 +0200 Message-ID: <20250602193953.1010487-6-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250602193953.1010487-1-jonas.gorski@gmail.com> References: <20250602193953.1010487-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to OpenMDK, bit 2 of the RGMII register has a different meaning for BCM53115 [1]: "DLL_IQQD 1: In the IDDQ mode, power is down0: Normal function mode" Configuring RGMII delay works without setting this bit, so let's keep it at the default. For other chips, we always set it, so not clearing it is not an issue. One would assume BCM53118 works the same, but OpenMDK is not quite sure what this bit actually means [2]: "BYPASS_IMP_2NS_DEL #1: In the IDDQ mode, power is down#0: Normal function mode1: Bypass dll65_2ns_del IP0: Use dll65_2ns_del IP" So lets keep setting it for now. [1] https://github.com/Broadcom-Network-Switching-Software/OpenMDK/blob/mas= ter/cdk/PKG/chip/bcm53115/bcm53115_a0_defs.h#L19871 [2] https://github.com/Broadcom-Network-Switching-Software/OpenMDK/blob/mas= ter/cdk/PKG/chip/bcm53118/bcm53118_a0_defs.h#L14392 Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch") Signed-off-by: Jonas Gorski --- v1 -> v2: * new patch drivers/net/dsa/b53/b53_common.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index be4493b769f4..862bdccb7439 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1354,8 +1354,7 @@ static void b53_adjust_531x5_rgmii(struct dsa_switch = *ds, int port, * tx_clk aligned timing (restoring to reset defaults) */ b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl); - rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC | - RGMII_CTRL_TIMING_SEL); + rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC); =20 /* PHY_INTERFACE_MODE_RGMII_TXID means TX internal delay, make * sure that we enable the port TX clock internal delay to @@ -1375,7 +1374,10 @@ static void b53_adjust_531x5_rgmii(struct dsa_switch= *ds, int port, rgmii_ctrl |=3D RGMII_CTRL_DLL_TXC; if (interface =3D=3D PHY_INTERFACE_MODE_RGMII) rgmii_ctrl |=3D RGMII_CTRL_DLL_TXC | RGMII_CTRL_DLL_RXC; - rgmii_ctrl |=3D RGMII_CTRL_TIMING_SEL; + + if (dev->chip_id !=3D BCM53115_DEVICE_ID) + rgmii_ctrl |=3D RGMII_CTRL_TIMING_SEL; + b53_write8(dev, B53_CTRL_PAGE, off, rgmii_ctrl); =20 dev_info(ds->dev, "Configured port %d for %s\n", port, --=20 2.43.0