From nobody Wed Feb 11 09:40:42 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB1B6218587 for ; Mon, 2 Jun 2025 13:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748869583; cv=none; b=kYlXlJYMg1cAdxyT8ehypuISskhZiksaWSuOfMeLuhMMTCqQftiWv/hd2Ixn2SFHxJ1ZBnpUNtV+n5zTQe1+Mb5hO6lmK1EgqKqJiAspInh/YT9JoieTnNA8Eb+/9PAqsMvSAfUzW8lCrA9xxrQcbFWMP04lEhBWlQ4jcsdWzAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748869583; c=relaxed/simple; bh=GiBxw+zm//U/C+YTQyovbdu6MSyJ+bZDAcgLx/2Kbzg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aNx8XL823E18qcRwvWVicR1JmMPae4yNMuWgA5AsWcBkFzMnKid/dfVCuQraVhKg3TTSdpS93e7A6st740EMUUsFTl0r8EP1SP3p7Tzo9ol66PADoIv13WEP5kBFeGoMt55o+t47mAdNuBcvdq6BRbtQT23E9V0nGAIxV8qo2aw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=SqF2Bqem; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SqF2Bqem" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-55342bca34eso2030102e87.2 for ; Mon, 02 Jun 2025 06:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1748869580; x=1749474380; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B3ix9DwpCMClF3M2JTkGqryLw82zMUUM9JySNSXWuyo=; b=SqF2BqemjlN3PyEv+6ysEqgBcANAIwdMs0x3RpDqVYrDPAv+yzO4nu5+xkZ664Q30h bDkGpGj0AnUENr/kC8EYkqk8Cy4iYOFkD9WgKafKH7HPKwzJKXZdS4kLzI0hyeXZEj+M 1xaXJZg7ar+y0PgitAHvnZLLFSJBWm6UjNaNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748869580; x=1749474380; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B3ix9DwpCMClF3M2JTkGqryLw82zMUUM9JySNSXWuyo=; b=tJ70qlbV2s606gMSF+X5BYcHzBm30Ef6Po+t4pNds6ROLYGltk+9pGGGYmNwN5pW+T 2F8bkYIaBWrqGsVb6rHtvXKCTrCwMTkufmjsL+4iKdUHnIbLKLkCYHDFsDh+dmAiVosK nIecz9vKsIEizaB9mBs7ENuYYqPd78O0XZXSKcOLNXNJcs2Jf2W/uQCBgXesHxPmqUoz SHZgHN+j64iiwZ/jpHmvNVt2/YBybd7Rjj5Gq+Lr45ICCG9tuMFZTYHFT1lAg2TTKM7T YHCBttjIHwcnt3no0g1wJg8rQtsuIXC3w+Ha4D5R0GzH22YJ9srjRBOcRBiCnDCvbVK2 WzRQ== X-Forwarded-Encrypted: i=1; AJvYcCVwR1TMDmu9qTLTw3iiTbWWGt7EbKKphtInp7Z3BfBaCmWp6tWhqOje0kTjVLL7QjK+KJiLoPi8idCIn08=@vger.kernel.org X-Gm-Message-State: AOJu0Yzgd7HqbBsAAdZd/3mE4J8pbs+7iSJ7Whbce1CC4iLJbcwU6zAW DFrwlOxDw1aFqpqdUA5HYD2NrOvBZG1YEnlM9lVFfIY7WthW0WNGfl/ZkSbBm8fY47FwiUcTl6y rOJI= X-Gm-Gg: ASbGnct5HseL7pbSKQ9lVhDt8t2ICVfIkE1zv8JKjIF4Dyjvn1N4A7eD9BQaTo/hdVG VMmU+GfJ5lHubx/4jhqCKBp2LDpxkkZWZIAxIRt8qOUD4F5HJ/gntt1m5+5rKgQ1bTTRpGMgGWk /6+7tFS7YYShJ+ege6Enx/5mdtLfAm5YCuuTMebV+OEvaUjLWG+HJmgPSz84hL/mAK8k+XHVAHQ KwctDoGm+r6NC80NjS8P1LOJGhcQxMp+mvZj5SYwDxcWb3uALmKfLOxNxeqMg6VcWOOc5K7cA9Y mYdiuxVY9QmwOyOdUURWcai9QsnDZnBWbc97H6Kf2b2XphcTmf3VSwhcd+C7TFZ+ynjLrD1n0X2 tX9dvqG41+PhXig67IydLcoDamg== X-Google-Smtp-Source: AGHT+IHaaeE2s/cM26BtGjZ20Lo2h4M+xB/fRejUpWThG9ibDbgdLRLCR7Fm2kvuEswuI/eNsNuKXw== X-Received: by 2002:a05:6512:1103:b0:553:2cc1:2bb3 with SMTP id 2adb3069b0e04-55342f9276bmr2219289e87.36.1748869579468; Mon, 02 Jun 2025 06:06:19 -0700 (PDT) Received: from ribalda.c.googlers.com (90.52.88.34.bc.googleusercontent.com. [34.88.52.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5533787d26esm1590160e87.41.2025.06.02.06.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 06:06:17 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 02 Jun 2025 13:06:13 +0000 Subject: [PATCH v2 1/9] media: uvcvideo: Refactor uvc_queue_streamon Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250602-uvc-grannular-invert-v2-1-c871934ad880@chromium.org> References: <20250602-uvc-grannular-invert-v2-0-c871934ad880@chromium.org> In-Reply-To: <20250602-uvc-grannular-invert-v2-0-c871934ad880@chromium.org> To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 Do uvc_pm_get before we call uvc_queue_streamon. Although the current code is correct, uvc_ioctl_streamon is allways called after uvc_pm_get, this change makes the code more resiliant to future changes. Suggested-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart Link: https://lore.kernel.org/r/20250509-uvc-followup-v1-2-73bcde30d2b5@chr= omium.org Signed-off-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_v4l2.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index 668a4e9d772c6d91f045ca75e2744b3a6c69da6b..862b4e34e5b629cf324479a9bb5= 9ebe8784ccd5d 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -853,15 +853,16 @@ static int uvc_ioctl_streamon(struct file *file, void= *fh, if (handle->is_streaming) return 0; =20 - ret =3D uvc_queue_streamon(&stream->queue, type); + ret =3D uvc_pm_get(stream->dev); if (ret) return ret; =20 - ret =3D uvc_pm_get(stream->dev); + ret =3D uvc_queue_streamon(&stream->queue, type); if (ret) { - uvc_queue_streamoff(&stream->queue, type); + uvc_pm_put(stream->dev); return ret; } + handle->is_streaming =3D true; =20 return 0; --=20 2.49.0.1266.g31b7d2e469-goog