From nobody Tue Dec 16 22:38:35 2025 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B049315DBB3; Fri, 30 May 2025 16:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748623492; cv=none; b=RtNRg1fhzY+n8HM//f72s6Us02nS88NqCUPi/QRY5KOvclDqcMgnX1I+dI6KFmxOQdwPz9bPzpFkmbJyigUHLDWhz2ujULm84aVraIzbucY+ZIzGV2X93h09i1NTm3i40MqHIjLcpWjnptiXmlAcweIEjBATjhjU4ta6za9WERE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748623492; c=relaxed/simple; bh=+ITI/lJciWXQ2zEFJZJYQzwqSQqACYyW4DyGzLZwJHk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jppi3rftereiGzz8xdM2LxlqWkakuPOSR95cPO0gRFkqlJx/0SgWuP2LMsZMrI17GgahZ9Jnf1ewPxXi9bWhGGR2DkVYIVhs9LOhR3EWRm2z8+nt/6QADhsjrNko18PF0OW7Uv/MorhySWSZlEySHlEQqm9XdRIi12HmnYvOYwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=oJEh+szW; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="oJEh+szW" Received: from fedora.intra.ispras.ru (unknown [10.10.165.16]) by mail.ispras.ru (Postfix) with ESMTPSA id 1597B40755EB; Fri, 30 May 2025 16:44:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 1597B40755EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1748623480; bh=hJKih8Dm6t83pwIHhRWysbIb0HcBG92LURaVZy9gSD0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oJEh+szW8UKbvRHMcqaPgwj9p0D+Nb6wS2z0fhr/30hz3GgJDi2i3e6MzMZlQqAkd bs1+VzwF4Jzs7ReQnS9lULPhoA5mjAGCBFOXg12im02aw+jhbOmrLfmUWakn6eJDae b//4ueSClqxU9PCkgkKTin1P5hCY16pSlqDk4NTg= From: Fedor Pchelkin To: Liam Girdwood , Mark Brown , Takashi Iwai Cc: Fedor Pchelkin , Jaroslav Kysela , Vijendar Mukunda , Ravulapati Vishnu vardhan rao , Pierre-Louis Bossart , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, stable@vger.kernel.org Subject: [PATCH 1/3] ASoC: amd: acp6x-pdm-dma: free pdm device data on closing Date: Fri, 30 May 2025 19:44:14 +0300 Message-ID: <20250530164425.119102-2-pchelkin@ispras.ru> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250530164425.119102-1-pchelkin@ispras.ru> References: <20250530164425.119102-1-pchelkin@ispras.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dynamic memory referenced by runtime->private_data pointer is allocated in acp6x_pdm_dma_open() and needs to be freed in the corresponding ->close() callback. unreferenced object 0xffff88813525a940 (size 32): comm "pipewire", pid 1238, jiffies 4294728195 hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 3c 03 00 c9 ff ff ..........<..... backtrace (crc 14400236): __kmalloc_cache_noprof+0x3a3/0x490 acp6x_pdm_dma_open+0x10d/0x680 [snd_acp6x_pdm_dma] snd_soc_component_open+0x71/0x150 [snd_soc_core] __soc_pcm_open+0x221/0xb40 [snd_soc_core] soc_pcm_open+0x99/0x110 [snd_soc_core] snd_pcm_open_substream+0x18b/0x4e0 [snd_pcm] snd_pcm_open+0x244/0x670 [snd_pcm] snd_pcm_capture_open+0x72/0xd0 [snd_pcm] chrdev_open+0x1eb/0x5e0 do_dentry_open+0x494/0x1820 vfs_open+0x7a/0x440 do_open+0x3d0/0xd30 path_openat+0x1d3/0x580 do_filp_open+0x1c5/0x450 do_sys_openat2+0xef/0x180 __x64_sys_openat+0x10e/0x210 Found by Linux Verification Center (linuxtesting.org). Fixes: ceb4fcc13ae5 ("ASoC: amd: add acp6x pdm driver dma ops") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin --- sound/soc/amd/yc/acp6x-pdm-dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-pdm-dma.c b/sound/soc/amd/yc/acp6x-pdm-= dma.c index ac758b90f441..167cd792d33d 100644 --- a/sound/soc/amd/yc/acp6x-pdm-dma.c +++ b/sound/soc/amd/yc/acp6x-pdm-dma.c @@ -275,9 +275,11 @@ static int acp6x_pdm_dma_close(struct snd_soc_componen= t *component, struct snd_pcm_substream *substream) { struct pdm_dev_data *adata =3D dev_get_drvdata(component->dev); + struct snd_pcm_runtime *runtime =3D substream->runtime; =20 acp6x_disable_pdm_interrupts(adata->acp6x_base); adata->capture_stream =3D NULL; + kfree(runtime->private_data); return 0; } =20 --=20 2.49.0 From nobody Tue Dec 16 22:38:35 2025 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ADE71BCA0E; Fri, 30 May 2025 16:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748623491; cv=none; b=F/29BQzSVLePTXOk9RTdkQUM0lMRyARteqbHfge6k2O2Zyh3C6b707cdvnjBWX+pJcj48dqRi6EO+KXJLFh2NPo3JoIvpKtJra7jpcThRF1NAUJS/IRY+JTHYVJpFpLp+YuPeppzqVzrT3OpYMIfVcwT6E51htRWJBgYpg4DvVY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748623491; c=relaxed/simple; bh=pnlJNPcUuqtCQJ0GorYkGddvDrovEEiy2acoompiKnk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OhHRAFEkicu1FFmds9JUDPhFecjN4FeiDipb2VUdU1bb/bXXJU+7GdOcMY0syQrjH9pAXgse474WIpRF0oe7CgaTLVrQm+3wf/GlsRhse9AAn00GP5UQ+lcxJZkEQahqPws6rmCZx/4jrqnqVqiWrrMxK2dXatSEFrqNaG1SZ80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=V6BBeaf/; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="V6BBeaf/" Received: from fedora.intra.ispras.ru (unknown [10.10.165.16]) by mail.ispras.ru (Postfix) with ESMTPSA id 2F3244076163; Fri, 30 May 2025 16:44:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 2F3244076163 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1748623481; bh=UNuEQvm7/1gsXQttRw7MHCKWoS1+gRNZE9/oQ9glN2c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V6BBeaf/jNuppOTjilT7ucd1b7EyOJtf5vYqhX9JgFc3KRXk4zWzhdpKczMWvCh4I YysttXLFMFagj+hZxo8VWqMuzqpPifhaW9yjD43DBjPmueiP0VAOCneMB83R0Sh7rY hz2GdrbmnyMCtAGUNq45gMDls65pKqTEBxnWxLqw= From: Fedor Pchelkin To: Liam Girdwood , Mark Brown , Takashi Iwai Cc: Fedor Pchelkin , Jaroslav Kysela , Vijendar Mukunda , Ravulapati Vishnu vardhan rao , Pierre-Louis Bossart , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, stable@vger.kernel.org Subject: [PATCH 2/3] ASoC: amd: acp3x-pcm-dma: free runtime private data on closing Date: Fri, 30 May 2025 19:44:15 +0300 Message-ID: <20250530164425.119102-3-pchelkin@ispras.ru> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250530164425.119102-1-pchelkin@ispras.ru> References: <20250530164425.119102-1-pchelkin@ispras.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dynamic memory referenced by runtime->private_data pointer is allocated in acp3x_dma_open() and needs to be freed in the corresponding ->close() callback. Found by Linux Verification Center (linuxtesting.org). Fixes: c9fe7db6e884 ("ASoC: amd: Refactoring of DAI from DMA driver") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin --- sound/soc/amd/raven/acp3x-pcm-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3= x-pcm-dma.c index bb9ed52d744d..90559c8304bc 100644 --- a/sound/soc/amd/raven/acp3x-pcm-dma.c +++ b/sound/soc/amd/raven/acp3x-pcm-dma.c @@ -353,7 +353,7 @@ static int acp3x_dma_close(struct snd_soc_component *co= mponent, adata->i2ssp_capture_stream =3D NULL; } } - + kfree(ins); return 0; } =20 --=20 2.49.0 From nobody Tue Dec 16 22:38:35 2025 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92CD41C6FE8; Fri, 30 May 2025 16:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748623491; cv=none; b=h7/Pi4PSV0jxC7jGwB1NLCGG2nmOfzBeFQ5wM0Ha2J0BEwT5LZf/Usv7SGhOnP18pM/IfqolJItdAx/+UPyjUeWZYejKrRi/cBjPJiiCHCVCeUOsjX5zo0Ja1GKQ/BDieg6vtjCec79PColrNhmb4qf1GBkeGQd9GOzfty/kvh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748623491; c=relaxed/simple; bh=N63jKpGiCSXNWDphomYejhXm4R3ctp0/FkZ77iqGKfU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e84gkhYYweglTqO939+skrDZCrvJgcucZPdCzYgqRhlVTymlzbIMc8IpAwX0AgW/A1a4fn4E6BZuhUNaIheP0xXh7wRn94yW8bC2/8QeQ6WH1w6ebPVACoJduNlxGtydd+Fi5MqdlZOcr8R68ukCdbKxlsWUdWdRSj/BI0by7Vg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=Hy0nElZe; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="Hy0nElZe" Received: from fedora.intra.ispras.ru (unknown [10.10.165.16]) by mail.ispras.ru (Postfix) with ESMTPSA id 01B994076165; Fri, 30 May 2025 16:44:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 01B994076165 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1748623482; bh=fPS9KLJ/Uc9OoO0w2alburJ4UW3qX59EuFMYSOSI0iI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hy0nElZeftqtkdS9jx271XZtlE7wOHh2eUSunioomRU4HmPCx6MqLHnkEBqAQKlCT Dq+k2QEU27qC64z/zyJ8yJbcQbnER/ouHR2vgAm0QK1TfjJiqGIW5986FcTKoYLsHf yvr6Wjcl1EKnbvyd7cUDQGTZQsnBSEi193MHAQWQ= From: Fedor Pchelkin To: Liam Girdwood , Mark Brown , Takashi Iwai Cc: Fedor Pchelkin , Jaroslav Kysela , Vijendar Mukunda , Ravulapati Vishnu vardhan rao , Pierre-Louis Bossart , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, stable@vger.kernel.org Subject: [PATCH 3/3] ASoC: amd: acp3x-pdm-dma: free pdm device data on closing Date: Fri, 30 May 2025 19:44:16 +0300 Message-ID: <20250530164425.119102-4-pchelkin@ispras.ru> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250530164425.119102-1-pchelkin@ispras.ru> References: <20250530164425.119102-1-pchelkin@ispras.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dynamic memory referenced by runtime->private_data pointer is allocated in acp_pdm_dma_open() and needs to be freed in the corresponding ->close() callback. Found by Linux Verification Center (linuxtesting.org). Fixes: 4a767b1d039a ("ASoC: amd: add acp3x pdm driver dma ops") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin --- sound/soc/amd/renoir/acp3x-pdm-dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/ac= p3x-pdm-dma.c index 95ac8c680037..6b294040e164 100644 --- a/sound/soc/amd/renoir/acp3x-pdm-dma.c +++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c @@ -301,9 +301,11 @@ static int acp_pdm_dma_close(struct snd_soc_component = *component, struct snd_pcm_substream *substream) { struct pdm_dev_data *adata =3D dev_get_drvdata(component->dev); + struct snd_pcm_runtime *runtime =3D substream->runtime; =20 disable_pdm_interrupts(adata->acp_base); adata->capture_stream =3D NULL; + kfree(runtime->private_data); return 0; } =20 --=20 2.49.0