From nobody Wed Feb 11 04:01:09 2026 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2083.outbound.protection.outlook.com [40.107.223.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5336163B9; Fri, 30 May 2025 05:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.83 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748583913; cv=fail; b=Ehf3DkD2PfCLpQxNztJB1ypM3HTOWsNrOCsoZe5zr7q7RrWyALzENMnvvyqE/7Z5L+vP4e6CbDPHMN3mpQc3/T4hfxydUqFlXdGZC4PPCbvRaxJuQJ2kwt3UWkvUsneZrIJwEv8EohkycgSuyETtohSDc5rKRra+S8q/BX0oW+s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748583913; c=relaxed/simple; bh=9kEwJastSr9UiSczctBOmEwgO/SMiwBcZ2keawHcJlQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XgmK3Sz2hQZj9yXnxdg59nBEgTBo9Wm+HsFNyC35M/qHiNatwJN997mazZh2snPZE0+pcV3sDWxZwCDYv6GhxTIDcDQ6HT3beGXrTuyS2dRLVePPss+ahcGjO34ZR/VJB028rnxiVK+AZXUksN1GFlsSRYaH+U05qLebL6VgHvI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=LLZYplyE; arc=fail smtp.client-ip=40.107.223.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="LLZYplyE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X7k8d2+CPElD1KOYFEz4hkIX8PJXfzI4kzeeqAke4v3+A4FyjBCwCfzmNBQ0gVn9x16OPvFyquLja85VIqFkVHZex3nTgLr3+HktnZn8iVpEIkmi4ucT9JNKNwIjZiXOni1dvK4V+EjkiiO+QpPyWM0jKQaVUunixKJGSvZ4H+8IEn8ubyqNb1gS761Y2aeUYLQ1/+t9Sd65NX1WMSPgNR4T1WJu5gbyY2lzGf6cVCcctGivbL5CJihcp/nrMMgb7CJmGBTCvLFrWGGCUGrpMFEAJDhAP1m4TSP5JtEVRf62U+nqRiddFpRClMokOGUftxgX5UXucRusdin8dgOYrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rupLOagtRgGGyYPdunw8RmSTkmuUjjM7q7k3OolFVXc=; b=IeRig+MmFp2NVZprm2J+AmHFFImGxRzTdDFcLzY450g1uyjH5CVsNRxr/ego2FPKT9JWKDLIio320Gz8SQ7UJyxD4u5im5hzUSvyvwLDtzDfDD/zfAYCCbM2BZeH9UrW33M8xGjzKRXiYG5o2FnYuKp5Yh7DuFhW1cj0HZGIhwb8kfU1tsbcFy8RP/R1bYaGOG6qNrQuuHR0ufKTrQH/83dTm/z/oC47qf3eZpGmRP3l75Geb/EmAYuN9lTDdaOaXb3Le5bMbPpBlYBNCh5RnYYWJpeITWV5PYiMunUhHw/O7KZ+/vRRLab/lBGSslMjbObC9OxmQEt059xfimfMTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rupLOagtRgGGyYPdunw8RmSTkmuUjjM7q7k3OolFVXc=; b=LLZYplyEumuSGhEs2bklDtsxvthZpVlEW2bH4uJk0+Cn5QjQBKe/kMlZCcJ2OvDNRz1ri5sswKnyHn1Vbgn3shqTCE0CGl7vV6xemaPAd7Ry2nNXegE69kFTqvi9hpitHp41Fjk0kbKBcUsbqkFfHfTakid7mtUbtS/pzpEe2nQ= Received: from BYAPR11CA0037.namprd11.prod.outlook.com (2603:10b6:a03:80::14) by SN7PR12MB8769.namprd12.prod.outlook.com (2603:10b6:806:34b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.27; Fri, 30 May 2025 05:45:08 +0000 Received: from MWH0EPF000989E8.namprd02.prod.outlook.com (2603:10b6:a03:80:cafe::6e) by BYAPR11CA0037.outlook.office365.com (2603:10b6:a03:80::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8746.32 via Frontend Transport; Fri, 30 May 2025 05:45:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E8.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Fri, 30 May 2025 05:45:08 +0000 Received: from vijendar-linux.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 30 May 2025 00:45:03 -0500 From: Vijendar Mukunda To: CC: , , , , , , , , "Vijendar Mukunda" Subject: [PATCH 1/3] soundwire: amd: fix for handling slave alerts after link is down Date: Fri, 30 May 2025 11:13:39 +0530 Message-ID: <20250530054447.1645807-2-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250530054447.1645807-1-Vijendar.Mukunda@amd.com> References: <20250530054447.1645807-1-Vijendar.Mukunda@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E8:EE_|SN7PR12MB8769:EE_ X-MS-Office365-Filtering-Correlation-Id: a297c352-8972-425a-327b-08dd9f3d22ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?3DBrFpS7+idDg9HuMLRv1Bjh03hO94C1+IyvYw3V3lYmiv/iQbvDAMrQriJY?= =?us-ascii?Q?n4tZx4mIYlNMAgZNrpg00HcX+opDkDAH0AmXfbnq5O4cCIVhGwDsMUZhNNVQ?= =?us-ascii?Q?SzT8Mqc8ycrCTmZQZJLLUsv/3RhB6HYzpz62oZ+fD8/XAdxpUtsjwSkEbEIs?= =?us-ascii?Q?+podwfopGG82HHgkJ8WGhhmHDbAOBn1tkw6rcmv0ONP7yOqBYHqTL5Bo84Eq?= =?us-ascii?Q?fwUoKTjnBeAZFXHvoWpnKnnL2QQy6AjOLlLi3S/dpjyfw5Lp/hodZ76oFPDz?= =?us-ascii?Q?8gQh/h/bg9j3zpkyFpBZ1kc3XsGpWSuZ16qOcWOynfPIIlizL+0K30H/pfqQ?= =?us-ascii?Q?bfrUh2PkaM6e5QtmnYserRKcNMqwPwD0ilOCZR1jMaILDX6Z4juluOH/fdh9?= =?us-ascii?Q?P/hLskIXsmXwjLOJAc5yWk6Bfr4upOQ6AcqHb/AEQ+HU2YeZY78RoM5JCl8a?= =?us-ascii?Q?3YHezFh6twzm05a/lx6v5HZN95ENAvukJacTN3CeIUaEYnBTjvxWodfcpwsw?= =?us-ascii?Q?1dvJJ2oKbE08RZarGyw6OxrRCCXnOlpGkaJpPR+OEWvAtbH7jmwamqg/Vuiw?= =?us-ascii?Q?21N9tQUw5VrSMv3QKThYPH1n7uxA/Z4LVoEHE1ZPpSCoA2xWPuqBHEBtufBJ?= =?us-ascii?Q?ceG0PluO/9zYxneCGDUZCsHJhwUUg0S7FiDcOpviE5lnoq4bMLkaI6ZYxVuR?= =?us-ascii?Q?4f47DAoO2AZYt/Cbvy5OIAF8dy5Fe2M3PStJIC9Cl2go32Qw4uJiQY3s5nAY?= =?us-ascii?Q?4CQpdikvi6GgF7gzyAcvpUC/HBkAo3fanMsLurbvCDaK/K22UgQCovkItvBv?= =?us-ascii?Q?Xf7DEf0EK0HgJnJN9m//EwinwFMMTy0s/Y4Ja55M6NFsfEzB3zr/b525ED81?= =?us-ascii?Q?nfrWGIJbnsdLLKw9F/vB2USJ9BK5CfysVAHvuSlpj7G9ExSWhRsSR7x97ndR?= =?us-ascii?Q?j+PfDmHz7Ko8JLUok5aTRNXwpbkncOx4rM3y2hB3cGu6+Qp3TFueTdQQyIcX?= =?us-ascii?Q?GcltWcWQ+b2ru/H5mv+vXzIXI4YIO9xOt5HjbXFZkN9aVK2q6xMNCiR6z46K?= =?us-ascii?Q?VlG933UNu2tffUzhjV6dx45liILDL4MZhtcdX1A4TO7mxmTOIHVarhL8r2eK?= =?us-ascii?Q?/LrWXcybF5XvO3IzaAv66CD6ss+20+oqfjJT1hTjl6xiDEWzjvAGW0tUcflJ?= =?us-ascii?Q?WZJDZhtyCkkYVb7WiwvdeFxgI2t3TeDjHQdvB28BXQx64TT5aUpa3dDVa0lH?= =?us-ascii?Q?Ex3SEDtJOtYiASUAOKHh24l652mEhCrst6x4VW+ialHZ48NHeWCXhXtemM0Y?= =?us-ascii?Q?L32SerWhanOJbHF9ujD6sz3AOrEtrgR+hV3gw5jQw9cJ+msO7Ne63Zqqsnp8?= =?us-ascii?Q?6SD5taVSphrK6Kex96QI3YAwOMvss1hgELc4IZ5vYLxehPO8Cafs8psveTfu?= =?us-ascii?Q?ZcTw4I40lckzclUlYCWxtW9HclZOahJGfcSZr92LRfAud+S7Oa+lA7DQu8od?= =?us-ascii?Q?FNBmTdZdOyp35CceiYP38UOmFz3LsWtp3UhX?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2025 05:45:08.2738 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a297c352-8972-425a-327b-08dd9f3d22ec X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E8.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8769 Content-Type: text/plain; charset="utf-8" Sometimes, its observed that during system level suspend callback execution, after link is down, handling pending slave status workqueue results in mipi register access failures as shown below. soundwire sdw-master-0-0: trf on Slave 1 failed:-110 read addr 0 count 1 rt722-sdca sdw:0:0:025d:0722:01: SDW_DP0_INT recheck read failed:-110 rt722-sdca sdw:0:0:025d:0722:01: Slave 1 alert handling failed: -110 amd_sdw_manager amd_sdw_manager.0: SDW0 cmd response timeout occurred amd_sdw_manager amd_sdw_manager.0: command timeout for Slave 1 soundwire sdw-master-0-0: trf on Slave 1 failed:-110 write addr 5c count 1 amd_sdw_manager amd_sdw_manager.0: SDW0 previous cmd status clear failed amd_sdw_manager amd_sdw_manager.0: command timeout for Slave 1 soundwire sdw-master-0-0: trf on Slave 1 failed:-110 write addr 5d count 1 amd_sdw_manager amd_sdw_manager.0: SDW0 previous cmd status clear failed amd_sdw_manager amd_sdw_manager.0: command timeout for Slave 1 Cancel the pending slave status workqueue prior to initiating clock stop sequence during suspend callback execution for both the power modes. Fixes: 9cf1efc5ed2d ("soundwire: amd: add pm_prepare callback and pm ops su= pport") Signed-off-by: Vijendar Mukunda --- drivers/soundwire/amd_manager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manage= r.c index a12c68b93b1c..a9a57cb6257c 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1209,6 +1209,7 @@ static int __maybe_unused amd_suspend(struct device *= dev) } =20 if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) { + cancel_work_sync(&amd_manager->amd_sdw_work); amd_sdw_wake_enable(amd_manager, false); if (amd_manager->acp_rev >=3D ACP70_PCI_REV_ID) { ret =3D amd_sdw_host_wake_enable(amd_manager, false); @@ -1219,6 +1220,7 @@ static int __maybe_unused amd_suspend(struct device *= dev) if (ret) return ret; } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) { + cancel_work_sync(&amd_manager->amd_sdw_work); amd_sdw_wake_enable(amd_manager, false); if (amd_manager->acp_rev >=3D ACP70_PCI_REV_ID) { ret =3D amd_sdw_host_wake_enable(amd_manager, false); --=20 2.45.2 From nobody Wed Feb 11 04:01:09 2026 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2065.outbound.protection.outlook.com [40.107.244.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6F58201006; Fri, 30 May 2025 05:45:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748583919; cv=fail; b=WoyQeUNrLel6ILZg7FIZR6Cpk6PlIQOFhrrIBlK+yM0BxRlcg0hWe5eZLYzEHuCOnWnTlXmLvWzrj+eF3kBEbILQb3SZqP1yQ6j8o72lM1gO4wC2TJoqS70qeac11CSVDOSQA0D+k8LuNBLybZQQAtSKAZgFvq1GqqNEMUBy4oE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748583919; c=relaxed/simple; bh=b1j3ryeGgdN9w7n5P3u/LD/ofKvYOb7IO3nrzDXMALM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O75w3AqwVEJlTnAeUOJ2yPSGTFSVeCMEcw5scsFaUqklUokXR9C1LLzzXVIGsjq3g0CEFDidAByo1uR96BZudUVF7IopJvPMIdXaBwf+lbPKFXZ1uonDDmiNlE5OtjdAa6f/lz+T/Gb1i/ZbJN3WKsQNpuA4QRoNr1E/fsf6TFs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=h+5rbugB; arc=fail smtp.client-ip=40.107.244.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="h+5rbugB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tOIevCyI87WFllC14w9Udp5xeoTgb+lsJNTFZpydhTJNhgT1WsYWNDwH+VT5GJjjihoTZfAVakxgPIxwNiTTbVVLmCrQBmCZhiLApPpPm58gcVAfp19nF8nufDu6wjQ29+oVX81tbFSkBCUWAqWuUzWUaA1HmRInuD/wagwuIzzl8vOjb9ZW+d0UDFyrTvqn59yqOv1TC8pGZBvLV+muP2Q6RqWcnYZ0xqd0TbbnLLXuwnJ80hOT2j8f6CzgFd3H49SzF3zjEP5kcmHz7S8SlhPg4O8qvPgF1jSl9456zBsWZlRjnYpJ3gBSi4D1rCtMxDtj2T/3PZBoLEpp6l3wVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dF+WF40QFPDmL3gixvagH5aH66oiJaShlZujnp+kxAc=; b=riVAynQulfnHTSxkhTGppixUgJ4SJ9UnCDJVUQSfa612/MRo1eCY7nUvKZ+Lj19ioBKGw3x4qB2bVrLEfjFiZU+Ga4xl2q1vyvTKmZJwSF6A7Axg0pPUZWelNp3bmYpdJ6Z0Soft1Rg7yG+PE4Bt6gFCzl5aX/+OJqPNgUva7njq9cFfw8iUSigDCV75hMXhWvID+KWqsAzw/nB0h7An6tkjmwBO2FdIX+xQinqub4hmZqLkdNuHmBxpEvu5azdfJO2oa6MAwW1REot/EfmAMnrp2HwaifIxrty8/CPXQWKm+ps5fWvWoPIPjAvww+AHe6tyGCOYlSaoCwO0Rx9bKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dF+WF40QFPDmL3gixvagH5aH66oiJaShlZujnp+kxAc=; b=h+5rbugBE4l6Wg9eukdlIo0ByzZHhfgKvO47xFZLKa7Xf+eb1FIgVGUf1LHJYKrUuM7LHURm8/V5r+qPcTN27o6D5vkQW4SGXss+zD//t93MQvu/wOErw5B3JhPTf383R2ATAizXfmYWMpPl2wbjXzEudg18SzjURovOSApSVas= Received: from BL1P222CA0004.NAMP222.PROD.OUTLOOK.COM (2603:10b6:208:2c7::9) by PH7PR12MB8828.namprd12.prod.outlook.com (2603:10b6:510:26b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.27; Fri, 30 May 2025 05:45:13 +0000 Received: from BN3PEPF0000B073.namprd04.prod.outlook.com (2603:10b6:208:2c7:cafe::9d) by BL1P222CA0004.outlook.office365.com (2603:10b6:208:2c7::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8792.22 via Frontend Transport; Fri, 30 May 2025 05:45:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN3PEPF0000B073.mail.protection.outlook.com (10.167.243.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Fri, 30 May 2025 05:45:12 +0000 Received: from vijendar-linux.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 30 May 2025 00:45:06 -0500 From: Vijendar Mukunda To: CC: , , , , , , , , "Vijendar Mukunda" Subject: [PATCH 2/3] soundwire: amd: serialize amd manager resume sequence during pm_prepare Date: Fri, 30 May 2025 11:13:40 +0530 Message-ID: <20250530054447.1645807-3-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250530054447.1645807-1-Vijendar.Mukunda@amd.com> References: <20250530054447.1645807-1-Vijendar.Mukunda@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B073:EE_|PH7PR12MB8828:EE_ X-MS-Office365-Filtering-Correlation-Id: 20538e36-08ad-4e5f-ff82-08dd9f3d2574 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ftl/v76nYqAg27MEatVf5QzT1jvF6kjjMkEfHgajHW8ZTWE69yCYcJg0Avgq?= =?us-ascii?Q?FY9MjWxIR69BbJeZx0WnFZmkAAR3fHJwsPi8tnX1TYM8+y/hzNrve4XX0sSR?= =?us-ascii?Q?1KcQJ9J8kxnqM60GRkxJPpQJXJazhmqrBdRzdY4sccS2YNHP+D8cQThf+UNN?= =?us-ascii?Q?Avs21sn/y1vuCNA17bqwbQrMaU8ITZW4e5NSUmJPKd5E8umKorcDc+26TMpj?= =?us-ascii?Q?Uc4aY0+jqAO+y5cdvMYC8g8H66TilN8qbVHf4rUw39x4bTCrdu5Oj4KKcOZe?= =?us-ascii?Q?++vdr4PgtmQjB8Z4fbJdIp8BFLiWqlblXtD9sYSyk8L2nTTnhOGPswpRyM7A?= =?us-ascii?Q?W6g5EtBE5OOntbGBnX66UqQwvyOiTq7/jgkzaV2BNJVUZ2Y4bBWvsXchCR2O?= =?us-ascii?Q?LHgTyr7GMozSvYAwmMWC/VQxQU4BbA+sTWtu3XQ8YzFuPH3YEb/ynnynQTU6?= =?us-ascii?Q?W5sMxPWqZEFPuo2ukuWL3gOJoINecYB2nVmCkfoggszg9r3g0P3HWzXll6Ou?= =?us-ascii?Q?XLWvrgZZEOlOB2GE3asJQSZPPEjm6WnaRbx1tVZ9kgoJ29eBYlKmu1dD9++t?= =?us-ascii?Q?ACxGW9rlyxJp/KljL3H6TIUWVuA2X+52w7jDz1keEvDm+Rk5JVCJ8V5Q5Lne?= =?us-ascii?Q?OcqI33Wtk2ZIIdcOiByekg0pZSlhMNLgXT/McjXOnQR1zsEsP/TXzsY2me/a?= =?us-ascii?Q?X3rIK+p3QiTlKNTbPrzN6SdW0uEQFpHENfr0UcuQ4QHVsIxa87oqOFH6lopo?= =?us-ascii?Q?RcMtmm3HaGf2kM+OXhrX5ARaK7UeAvDYtoV2KbPfY3c90m31hIoIvKkwV6yu?= =?us-ascii?Q?eihAL8FolUwLeMVNFiLXe+Z+CqTd+Ly/02b6OAXENplv4vAcmklTQHiLs07Z?= =?us-ascii?Q?TljBgm4pXQxvCNt7O9MmI7mKkr7lN+QOMbTol7nxAmLN83ji+FcULhyBYSQH?= =?us-ascii?Q?VK3ywnxUafj9Fk9SR0XArbmpwXh3KuSh9gP2L9YEKMAR9DRtkvYOw8t5ERZH?= =?us-ascii?Q?nP26NXlUpMCPbGXflN2GtUxqk/g9fdRlMiCY1geGsRpTWHOdiQditjSYVqai?= =?us-ascii?Q?zT/9PEZlmWUHy3uCinDu7erAntWGwfhJ7tQHFGqwpLBAB1cL7sIYP8NubERi?= =?us-ascii?Q?X5PpiZnaX39nYjdXyPhYmOHXo01nyO9s6IxW9ayGHQTCAA9jyARLq4E6KQaJ?= =?us-ascii?Q?HLBFy6WxqfUXq0UjJTjXVVwrvTTQ4+EZ56MTXVVuio/p6z1k/MTbz1IxTpGh?= =?us-ascii?Q?fvkzirBxjtOA1jENHcVBwLuuS6ziMBGHldH/4ijv0XkkQBazRqnq/6ugHgk+?= =?us-ascii?Q?ysvAeqq1dIRDe/qL4xjE4diSdkv2DSOT2UoOFodHDFAkxgtn9H1K5mgYDcdq?= =?us-ascii?Q?81Is1I6bD5VxANFCTkB19TIpMu+mXJCuL0Nc6w5zGPls1dh9LtDCh5qoiWL1?= =?us-ascii?Q?Pl8eC299y4+Buu6Ywsq+17Qnk+JNENiGnd3I3iwyZRJwKyr/IMMC+uLYfu1n?= =?us-ascii?Q?u4Fxn7eGAGBfmZHPxnX3IcMQ9SiZo3KKWfIT?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2025 05:45:12.6305 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20538e36-08ad-4e5f-ff82-08dd9f3d2574 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B073.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8828 Content-Type: text/plain; charset="utf-8" During pm_prepare callback, pm_request_resume() delays SoundWire manager D0 entry sequence. Synchronize runtime resume sequence for amd_manager instance prior to invoking child devices resume sequence for both the amd power modes(ClockStop Mode and Power off mode). Change the power_mode_mask check and use pm_runtime_resume() in amd_pm_prepare() callback. Signed-off-by: Vijendar Mukunda --- drivers/soundwire/amd_manager.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manage= r.c index a9a57cb6257c..b775ecab697c 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1178,10 +1178,10 @@ static int __maybe_unused amd_pm_prepare(struct dev= ice *dev) * device is not in runtime suspend state, observed that device alerts ar= e missing * without pm_prepare on AMD platforms in clockstop mode0. */ - if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) { - ret =3D pm_request_resume(dev); + if (amd_manager->power_mode_mask) { + ret =3D pm_runtime_resume(dev); if (ret < 0) { - dev_err(bus->dev, "pm_request_resume failed: %d\n", ret); + dev_err(bus->dev, "pm_runtime_resume failed: %d\n", ret); return 0; } } --=20 2.45.2 From nobody Wed Feb 11 04:01:09 2026 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2079.outbound.protection.outlook.com [40.107.102.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25E971FE455; Fri, 30 May 2025 05:45:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.102.79 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748583918; cv=fail; b=ohbBgNU27G1WwnNexk47F0kkZBLoHZrb4x5H4IjrGiriv/2Eh/STrLdK1BJCI4o64I7DDXLliWbsuBk3Uvt3ITl6GBs5rfJ7ZgL7Lr8Hqc/aS5jaLN1V4TxBOtOskqRwC5xYtleVNGE97pkRa2HMmrJJ15ROPnYNdTXLIwWqOY0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748583918; c=relaxed/simple; bh=xZUAly+0ygCE8pDqNS+3law5MILv5tTFSI0RFNmv86g=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=V9RZA4TWcoKpvIIXcH048BnNnfzQoypq6NRMgUcoyLDJT0o6VC76wvqZ6fnSLl8ly16pZVpOu21Xb6Z+c3J8vDNpuLGG5a0JThLOOXkKGoa6vWXgiXD9yXUDnhqUWjfCjFmC+oerPkOIlSxpzS7xvuF2IqwBXGCAgGka1cGaAjw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=tJLVV+07; arc=fail smtp.client-ip=40.107.102.79 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="tJLVV+07" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ect5ugFlcOHAJziyRxzr8tQbyoN799ab64+UFIwwyCTQwqrTEvGW1QJ6bQHzHqYC0wnWi68CsHFArs7bxxmXBFCNW1LY3pjXnpt3TBl1CxzGaVwYIUPcaOkzz3HnzVCZJAnMHmbvxTe9xzjzaDH6QOBObb8jhDtbZs0JQx9jEgnO9RBaKjn0Ymt8xdjzirpCJRWXTg8nK79ImTZlkUV4UpNUsB567ieXeaehl0lEOjjLjp7L5aJYnQ0638B7eofpfsTqyXapqotwzFGswo9FG3I84YKIguoHwLIyq36qKEw9fqS6QlgVnW4IdfBoQD8+kFjZDmdmmDymmAsooG5usw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gs+nJYuRxqJZCs0YRi7Oh9Ns7wPrLyQgoAQctng5T8U=; b=Z15FSUTwjF3nZ31Bpeuyiil4YFq9dvZeU+BWmHLmKWibrPIbFQhrGyXnk/z3dgBt7npOwscOEgAloxLGYk+ikokkrCM+UiieQVX1eyJbD3Uo1/NmdKb8n9L+JXXH/L1kLNSeMCShvmC6UwT8BahNn6+eYeKsPBg6z8rxvY2fMWqfXPA2WG4D4yNi2BVCryBSVFXmsrxZAir7T6HvBNHRvzWhP3p1ffI4DWRa+ZtXyJNwsZbQb1P6cSzKdF4obRYzGMeQt2lUt7eDRUesjPwAyX1sJ/JhfWSNHAOnzsP4ix0Nh2lRWt9+bL2/x8WRFm958kl227wxr/q4WceK+uqeFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gs+nJYuRxqJZCs0YRi7Oh9Ns7wPrLyQgoAQctng5T8U=; b=tJLVV+07+Pfu7nyvWOoHNfJ0/LpGx6VcXvp+tPCfmyRnKP8vEJS6/T5i4wEP1ldZIErjrOeYZdTsKU0yVSYZ8nxBQ/hAvG2wlo49QWPyxlCIhGwifUrlOgotiirFoaODvNBIl/xjO87sh4GbN4TgZ8cj8qfDbhxOX/qpcgvrxyg= Received: from BY5PR13CA0026.namprd13.prod.outlook.com (2603:10b6:a03:180::39) by DS0PR12MB6415.namprd12.prod.outlook.com (2603:10b6:8:cc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.24; Fri, 30 May 2025 05:45:13 +0000 Received: from MWH0EPF000989E6.namprd02.prod.outlook.com (2603:10b6:a03:180:cafe::28) by BY5PR13CA0026.outlook.office365.com (2603:10b6:a03:180::39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Fri, 30 May 2025 05:45:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E6.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Fri, 30 May 2025 05:45:12 +0000 Received: from vijendar-linux.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 30 May 2025 00:45:09 -0500 From: Vijendar Mukunda To: CC: , , , , , , , , "Vijendar Mukunda" Subject: [PATCH 3/3] soundwire: amd: cancel pending slave status handling workqueue during remove sequence Date: Fri, 30 May 2025 11:13:41 +0530 Message-ID: <20250530054447.1645807-4-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250530054447.1645807-1-Vijendar.Mukunda@amd.com> References: <20250530054447.1645807-1-Vijendar.Mukunda@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E6:EE_|DS0PR12MB6415:EE_ X-MS-Office365-Filtering-Correlation-Id: 825df425-7cc1-42a5-0566-08dd9f3d259e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KhLcQh4vMGtalK35wXUVTXs+PSPm/SLE+5zSNK2JiMScZMA8wD0T38ODThe+?= =?us-ascii?Q?QBrGV5vqDlmlboadI0eRwQv2aYvINKMB30ucJxfVm6cvjVFDo9uu7wLtAtRZ?= =?us-ascii?Q?6tWgUI8inQA7SC7uEcnxx9vKFhr1j+diLiGZqa1PjVfmOMEATJ0sIG0lahdn?= =?us-ascii?Q?CTUYwZuJbdKK152r0Hu2U7s3QWqQYHU8QngZ5xNfS+31Qgmmu2RXfF0NZnWv?= =?us-ascii?Q?jNWYyaojUVluK4hIlb4bEueBzUusz4bbEgvbSzVtxuwJJbHiZI4ThAsezd2j?= =?us-ascii?Q?FW+Y++gZ5LMDVSMTsd/T6q+yyCKVmi6oYOucPaP8N+10IgKrVffG6KYkiWRo?= =?us-ascii?Q?FcrKlMm2b8//k051y5xqztyxk0mLEXxdbLXW4e4HcmgV5qM6erWoAC32BJog?= =?us-ascii?Q?DnYrnr5XRaBL7KS4487FL/tbsVDt/7oqTReR+y1wjo3iNlVcddjemIHwLTTo?= =?us-ascii?Q?LmWE6u2orWCbnGFFNMsOji6MilrHq1T7p+Mkoajg9vCJKnrcWdJH8GrWck4Y?= =?us-ascii?Q?xbz1w7CPqp7cZSerNFtrShI4vdUoH/LOEhHhxuO7uaZmmbM1p8zdwt3iRL31?= =?us-ascii?Q?4cNcNznQHYp1vDjMp/yds5iS7DHMzcSfp7YuUHMtwja4CNRROA9S+N4gDpIf?= =?us-ascii?Q?iXfJH8utXAD+RfqojwKKANts8pLgpPce4hL47B9ZR4SBfu8RsEeSWTTQ+751?= =?us-ascii?Q?/6UGJQjRPz//oHbfcGpQgwPPerLdJHPVNDEiYBhj2InM9aKvPpZvgfIigQTT?= =?us-ascii?Q?rUUyXOvETVq7jKEnheonow3SAdYBL5K6InNMKN77/HtN91u7nZxD8ZEemE6p?= =?us-ascii?Q?iDR68pC2YPE571oPa4mcru2EWdaoveKvylOPwNq9DM/XCs+qRx34YIFCwYBH?= =?us-ascii?Q?27XDTcKIQ484ftAKUvqEqBATf3ngsZQhZ9jh3E6GOQyA/iNCnypUddLPVufc?= =?us-ascii?Q?2QnNxPW6smCn1zjnhbl4r81uPOGKTdH5pu1/axW+KiTg96IkFCCay+lvphQ9?= =?us-ascii?Q?eNUfZKvHtBe7XefakH/Hlg0bCsiKTe5S+JQoU7fh6TZ9eZ5yqiVoBIMuNbMd?= =?us-ascii?Q?Doh+rzE7psIEdNEdjKbpYbyhNJ4agUXav5bfscLrO7orrccVy+8a8Qv1Szj1?= =?us-ascii?Q?vTUxfvZ22b9wfO8Gxjk/DhmtrDac2rLoboGmORg8LeEwVKDWw3shQQsFM4VR?= =?us-ascii?Q?Y/7NT/GvuMn3YcAtpWKkji6Ed4BFal2sOxXHPTcxejYIka3+i1pNytabf45O?= =?us-ascii?Q?GllKNEZdlQzAuYa7QaB0PsoqhtgFu09gfF7c2s0dQDJ97A/Bv92k+5UDJ8vL?= =?us-ascii?Q?SZQOJvVyK5HOotKUznmURNloFxducpm1efXcNCyWgvLPpcmmwGeFlC6J1DBJ?= =?us-ascii?Q?91Ub0PZW0x6U3umwCLQSedM3GrlEm569eCp2XUoesZwegUNV+84XACdNxsZ5?= =?us-ascii?Q?r7LPuxcdirQjEvpfmeF253ZwzcCbcgaPIVO+MV6CBULQVRQ9YlKfvYi/2Rpe?= =?us-ascii?Q?dvgMIUhCPaoec/UJC9k51QYIgc+37eLxdB7a?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2025 05:45:12.8155 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 825df425-7cc1-42a5-0566-08dd9f3d259e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E6.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6415 Content-Type: text/plain; charset="utf-8" During remove sequence, cancel the pending slave status update workqueue. Signed-off-by: Vijendar Mukunda --- drivers/soundwire/amd_manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manage= r.c index b775ecab697c..8913a1a83007 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1074,6 +1074,7 @@ static void amd_sdw_manager_remove(struct platform_de= vice *pdev) int ret; =20 pm_runtime_disable(&pdev->dev); + cancel_work_sync(&amd_manager->amd_sdw_work); amd_disable_sdw_interrupts(amd_manager); sdw_bus_master_delete(&amd_manager->bus); ret =3D amd_disable_sdw_manager(amd_manager); --=20 2.45.2