From nobody Tue Dec 16 22:33:36 2025 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDE70268C49; Fri, 30 May 2025 17:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748627207; cv=none; b=j/PcUsT7jsIYClFnEMsFdyC4GxdfC8CIlcnzD3mJqC528Ndy23cqUdyAqpm3MIzZeO4BCGccrGZ7EuwlcKaV1DYeMTIejfaIjorpvnytdCM5jmbMTdNKjOhaZNJOop2KNpkyR7DUxUq7zTvPbAvfLvZCh7BJ5Ce8ZTYwFNJihq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748627207; c=relaxed/simple; bh=c8eMnEXkKj3KZv7pXFKJycXqfPtAZ8DjtUNQCxj7R9I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NIq20kl4pONbOjrvKXol297snj7sB4E/fOJBRyXtlFWjID4kwb6dbfGYyA7iBsCFE0yCKf09Jy23OMQ1pO4OC+Ghzw6QOL9ixIVQGeReps4xPKSEwpgfB8j01ilNmlwj05lsw5XKfYgm7YZ6dIQqhWqVf+gc/uEndRhfYjvhAqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TTr4FJDR; arc=none smtp.client-ip=209.85.221.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TTr4FJDR" Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-52413efd0d3so749788e0c.2; Fri, 30 May 2025 10:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748627204; x=1749232004; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=un/E/DEhIx+krru6ePBASrA8B37RqcZJZEYw5tmJ1+Y=; b=TTr4FJDRNp04sUOW2nPxU99Rr4PzEBA5MZ+3UENl7SAFmYndSLbq3qmRvcs7ER9JTV iX0lMjE7q9Hz7hP9gRG2VfdUWBwteKpvjND6wgwkPVIBkTaLTjyvaXz4XqrRAel9jA3/ RuBtukJuvADLWHBCQgKM84hVeOvWIJWxv1ExDEGrFhkA3OK8O/43ae6aYpfsGHeSvA5z AgrTx2k7Z6Z0zTbrvYDqPqnY3x9xPjbdvxOMcq7kR1rFHmChSilldBEw84lQlZ3m1bDh xRvpsFweDiG2B+xvHymDgBavUU2RNjeItexaPu83tjRqmp8XoQSnaPgCFP8Jhdo42v5b 1RyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748627204; x=1749232004; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=un/E/DEhIx+krru6ePBASrA8B37RqcZJZEYw5tmJ1+Y=; b=HF1Gv5Ook5DmBm0byc1LOJ4zbWh6I0a4mTaoLQPqqdh/lZn5reb9ZatzjISFoIk62I 4kLzeWs6Bkn+4VcOM07gisfUplg+lPKsuRI5AlpK2QR6VgRT1nil/f7bHlg56UzfPz44 W43XSygKB+MLQkkmwwJTStjtEw/lYA36hBZuQmgfZo/l+akmvFtGx5Hu320TO7mw9aSK Nl8O7lL9adHSV6wko16seIiqhJ3n36PtTPbBKJTQsJARRQxX7bQKUQWcw26TlFD5oKv/ 2vHEEa9UJ1oKcxklqHpbK5MMBbrK8rSjdICVV7CCx/oAcGGkQ/aJ9Ucxy25OZ+xg7p9O JnBw== X-Forwarded-Encrypted: i=1; AJvYcCWRLV3GG0q9gAP+WeSXAUmKS+V3+to1vPIac2a/e5LxovTn4ybI+xx/S2tAa3bmbnv1Rj/CD+w/XkHH7vdT@vger.kernel.org, AJvYcCWk1+6q6Z8j8ulaaPV6M4oPSja2npclkunDkqmkNpsKIo3XrwBNWJjnJEE9K0JR5/I5W8SnPqTXUeIy@vger.kernel.org X-Gm-Message-State: AOJu0YzRmPM67N9cDei2QASGBHGTlQZo150UG263+Vbr4cbe2XFODwqN GpSDeXYrf7KPgY5/cFXhkXcoB2Qd7Hr4E7LpwiJOZfCEqoR2L1DgYNe8BZfQDJHd X-Gm-Gg: ASbGncsQk4GLNp0cW/wv1EPuTgGDVxzsLrQZzNM1+8q3zmVZSxAUI50w5qrddQm4sz7 YSzPCfFMcS2+IGEoy6Z80oqRyo0NphBwygxJCQshPTanwB3uWwmP7+Xxwy5zVSOwDIN27N9ph3O 6O8MQV6j1diBjxTj0HdbfPpsRJvUv6Z8BsLRqwNV6C+jrFUejj8rkDj9CVMTRs62nqjC6kowUJv Sd72YLklu5K4NCf/AoqhmH3PcNt8F+UHGAHl9LUMpn+9JN4957iE+UCuDtaoItU4OFUvBNuRWR9 whRK9cvHHhn5LTAUEsDn/7GwwFITJ3bzAWkoppud4sqt1R/PWPus0wFAeHXE63eaq0dp9/h9/q3 +7wO5VIu7fu/b2il7hOp0 X-Google-Smtp-Source: AGHT+IH4V76m/Hf7vdE21xeBTvIMLCsL9QKgzOFnmhDedDYenCAyoRqzRaTj/o0/xnOLWhRO9VhpZA== X-Received: by 2002:a05:6122:4f83:b0:530:6dc2:ba9c with SMTP id 71dfb90a1353d-53084bbd2b7mr3090590e0c.2.1748627204284; Fri, 30 May 2025 10:46:44 -0700 (PDT) Received: from joaog-nb.corp.toradex.com ([67.159.246.222]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-53074ab0d37sm3578591e0c.8.2025.05.30.10.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 May 2025 10:46:43 -0700 (PDT) From: =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= Date: Fri, 30 May 2025 14:46:25 -0300 Subject: [PATCH 1/3] dt-bindings: hwmon: amc6821: Add cooling levels Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250530-b4-v1-amc6821-cooling-device-support-b4-v1-1-7bb98496c969@toradex.com> References: <20250530-b4-v1-amc6821-cooling-device-support-b4-v1-0-7bb98496c969@toradex.com> In-Reply-To: <20250530-b4-v1-amc6821-cooling-device-support-b4-v1-0-7bb98496c969@toradex.com> To: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Farouk Bouabid , Quentin Schulz Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= X-Mailer: b4 0.14.2 From: Jo=C3=A3o Paulo Gon=C3=A7alves The fan can be used as a cooling device, add a description of the `cooling-levels` property and restrict the maximum value to 255, which is the highest PWM duty cycle supported by the AMC6821 fan controller. Signed-off-by: Jo=C3=A3o Paulo Gon=C3=A7alves --- Documentation/devicetree/bindings/hwmon/ti,amc6821.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/hwmon/ti,amc6821.yaml b/Docu= mentation/devicetree/bindings/hwmon/ti,amc6821.yaml index 9ca7356760a74b1ab5e6c5a4966ba30f050a1eed..eb00756988be158b104642707d9= 6e371930c9fd7 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,amc6821.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,amc6821.yaml @@ -32,6 +32,12 @@ properties: $ref: fan-common.yaml# unevaluatedProperties: false =20 + properties: + cooling-levels: + description: PWM duty cycle values corresponding to thermal coolin= g states. + items: + maximum: 255 + "#pwm-cells": const: 2 description: | --=20 2.43.0 From nobody Tue Dec 16 22:33:36 2025 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4182D269820; Fri, 30 May 2025 17:46:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748627210; cv=none; b=Iweo+wQHu5saGPAISEtGSH4PPQ66V58JGNfu/RJ2gXz6zsGEKjzsCO2t7qYJBHR+KFOIKVVkV/HZ6AbvK8m+wed8+MZ8o5WhWZoluRmvsoPh69PWGjQifRwjPJbhV0ohO9ryj8bYlbfmli/Mmo12BPt0ZKHzJ7diTl4kmK6o8MY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748627210; c=relaxed/simple; bh=+JpBqXqJLKMDMkWO2vyVD4/soc6w0MN0sgT9vjot+nM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=b7ILwPKdG4agFs7Zzw+pPZ6d94siSA702UjM435rRirZom57aGS89uAT4Tr21+73Q8K0IhxF/EL2Tam4N5TKOEzWH2bbOXJi1cR7skYbOKSJFcTtS7e0Z174KE6SeKhGWg6Cvn3Gy0lMihxQ+45DHZmPMJW6lvXcz++rG5NMFm8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cO7udHtt; arc=none smtp.client-ip=209.85.222.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cO7udHtt" Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-87dfde2aea2so607173241.2; Fri, 30 May 2025 10:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748627208; x=1749232008; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RKUFBKXPLbw7kwilgIATyY6n6w0/znEVgC9+5Lfbtcc=; b=cO7udHttveTROaHDH+XT/Y7ifM+rC3zX+9qDmQAc+ZBLOWUy9NwlqyTVot9NQAmUzc ja9ra7fNQZWxfL+i+0GLrhDwdEwnFmodu+75Iyt77xs4TJnmgEGU/OhglTiDYqyQUz2F ryUFjFwd/7h5g85rbC1A7C2gOWcyMPDuKz/Up1yEMwLPYNDbD1Vs+T/YOqBC62oS9SxM cE8m2iyVKWSwjXi8F0TyGGxE71VpTnLOn7Y/hG0vVQD2n0Li2Mopjw7BEXixYstpbD8G 8y1yQoSzRI362d6aJ6+GWCSSMgoUpIWbuxAJxivAcKB1uyFY3ttTQPS7KbDz7CTkCRSb ZtxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748627208; x=1749232008; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RKUFBKXPLbw7kwilgIATyY6n6w0/znEVgC9+5Lfbtcc=; b=A8PbRtdF9EiOCFx5Omigbvr3zFq/u0JfcwxpDcM4AVyX/1KQe+kMOJHDNjflaOnWOi MbAXZcESVC0/XUWpOzg2Dob9TUusq3Kvhwux7ljad8AUcBcFI6P3KmiloCCTVI19bdHR h8di4JvUDP3dceGyi9iMPQzsEPGB65I+mOxZZSsCrSFWzgMb+1mB1WmPg+GMaQUTrVhz I4xYAgNtCshH0Lp4eauvNO/PPBoTlmtfoIv/OKYlWhpnRy75cUrepQ517tuMySTdzuuK nDgiInUn3oSwhBagXzdRQRlr7ITkHb7uogjAyv93zNnIqjXBtbsknptuPSozayKH18l5 MeJw== X-Forwarded-Encrypted: i=1; AJvYcCXY/mzr4hrCiSBsqvGMuc1Ccqss1o8FcPTsn9/OtDWpNWERY8gjAqQeX1Hit93KzW+n3S0NZRT5jP4e@vger.kernel.org, AJvYcCXbc0FilOlfcohZVYCc9K7mACMC6e69LSx550ogEnckk/eWhKQf3QyB1ZxcwtL/CWrWRcAPtoKqJVCOReSm@vger.kernel.org X-Gm-Message-State: AOJu0YyTCsOcV7sXWRQ0yDNDhmyQDR70oTJO/5dgMssFHDTka0YeSoNS +VRvQsp5/ke6tjfsmh3krb0pEncpL8tPwGHcMz9UAc384W7w4+3XbEgq X-Gm-Gg: ASbGnct9aDOeZOCWh7uOKU5y2lPl8+jojEjXJIyc3gu/sU6wCeGJbBr2vEtFT97mnGE SxJMw+44wG28eBARWwwErf9J9lLcrOwAYGiywihhhXgYJkZUk6K184IfpV8rbVm7aUmIGn/8+15 jLDGt//XY3vu1oEgLjuEkS3rkNUuIffqP+QGyhxGEuNdBbpE0odZJS/qulnQzl9XyCezYcZdFzG 3S+cAPTKVFsvPo9b5fsG7uVtY3OsCb7MQESspBN+FfkNowYqKpG2aGNqLE+VdXcfi+dDsIxYlPM kT3r9ggIetXgp5a0QjmYLbo+cMSomgVrCF+qVU4NUkRDQV20II77r+HDCCzlIu071WfSXu+II6r LA5fOY7xK1w== X-Google-Smtp-Source: AGHT+IGK3/Qcy/9QIOvx75XzyDA7Qqv7k7EdN1+r7RtcTe+8bWLWpkaUyuVLOrSbaffKsjjNRgV/mw== X-Received: by 2002:a05:6122:1350:b0:530:7e05:2009 with SMTP id 71dfb90a1353d-53080f73eb1mr4781899e0c.3.1748627207917; Fri, 30 May 2025 10:46:47 -0700 (PDT) Received: from joaog-nb.corp.toradex.com ([67.159.246.222]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-53074ab0d37sm3578591e0c.8.2025.05.30.10.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 May 2025 10:46:47 -0700 (PDT) From: =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= Date: Fri, 30 May 2025 14:46:26 -0300 Subject: [PATCH 2/3] hwmon: (amc6821) Move reading fan data from OF to a function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250530-b4-v1-amc6821-cooling-device-support-b4-v1-2-7bb98496c969@toradex.com> References: <20250530-b4-v1-amc6821-cooling-device-support-b4-v1-0-7bb98496c969@toradex.com> In-Reply-To: <20250530-b4-v1-amc6821-cooling-device-support-b4-v1-0-7bb98496c969@toradex.com> To: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Farouk Bouabid , Quentin Schulz Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= X-Mailer: b4 0.14.2 From: Jo=C3=A3o Paulo Gon=C3=A7alves Move fan property reading from OF to a separate function. This keeps OF data handling separate from the code logic and makes it easier to add features like cooling device support that use the same fan node. Signed-off-by: Jo=C3=A3o Paulo Gon=C3=A7alves --- drivers/hwmon/amc6821.c | 58 +++++++++++++++++++++++++++++++--------------= ---- 1 file changed, 37 insertions(+), 21 deletions(-) diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c index 13a789cc85d24da282430eb2d4edf0003617fe6b..a969fad803ae1abb05113ce15f2= 476e83df029d9 100644 --- a/drivers/hwmon/amc6821.c +++ b/drivers/hwmon/amc6821.c @@ -126,6 +126,7 @@ module_param(init, int, 0444); struct amc6821_data { struct regmap *regmap; struct mutex update_lock; + enum pwm_polarity of_pwm_polarity; }; =20 /* @@ -848,12 +849,23 @@ static int amc6821_detect(struct i2c_client *client, = struct i2c_board_info *info return 0; } =20 -static enum pwm_polarity amc6821_pwm_polarity(struct i2c_client *client) +static void amc6821_of_fan_read_data(struct amc6821_data *data, + struct device_node *fan_np) { - enum pwm_polarity polarity =3D PWM_POLARITY_NORMAL; struct of_phandle_args args; - struct device_node *fan_np; =20 + data->of_pwm_polarity =3D PWM_POLARITY_NORMAL; + + if (!of_parse_phandle_with_args(fan_np, "pwms", "#pwm-cells", 0, &args)) { + if (args.args_count =3D=3D 2 && args.args[1] & PWM_POLARITY_INVERTED) + data->of_pwm_polarity =3D PWM_POLARITY_INVERSED; + + of_node_put(args.np); + } +} + +static enum pwm_polarity amc6821_pwm_polarity(struct amc6821_data *data) +{ /* * For backward compatibility, the pwminv module parameter takes * always the precedence over any other device description @@ -863,22 +875,7 @@ static enum pwm_polarity amc6821_pwm_polarity(struct i= 2c_client *client) if (pwminv > 0) return PWM_POLARITY_INVERSED; =20 - fan_np =3D of_get_child_by_name(client->dev.of_node, "fan"); - if (!fan_np) - return PWM_POLARITY_NORMAL; - - if (of_parse_phandle_with_args(fan_np, "pwms", "#pwm-cells", 0, &args)) - goto out; - of_node_put(args.np); - - if (args.args_count !=3D 2) - goto out; - - if (args.args[1] & PWM_POLARITY_INVERTED) - polarity =3D PWM_POLARITY_INVERSED; -out: - of_node_put(fan_np); - return polarity; + return data->of_pwm_polarity; } =20 static int amc6821_init_client(struct i2c_client *client, struct amc6821_d= ata *data) @@ -902,7 +899,7 @@ static int amc6821_init_client(struct i2c_client *clien= t, struct amc6821_data *d return err; =20 regval =3D AMC6821_CONF1_START; - if (amc6821_pwm_polarity(client) =3D=3D PWM_POLARITY_INVERSED) + if (amc6821_pwm_polarity(data) =3D=3D PWM_POLARITY_INVERSED) regval |=3D AMC6821_CONF1_PWMINV; =20 err =3D regmap_update_bits(regmap, AMC6821_REG_CONF1, @@ -938,13 +935,21 @@ static const struct regmap_config amc6821_regmap_conf= ig =3D { .cache_type =3D REGCACHE_MAPLE, }; =20 +static void amc6821_of_fan_put(void *data) +{ + struct device_node *fan_np =3D data; + + of_node_put(fan_np); +} + static int amc6821_probe(struct i2c_client *client) { struct device *dev =3D &client->dev; struct amc6821_data *data; struct device *hwmon_dev; struct regmap *regmap; - int err; + struct device_node *fan_np; + int err =3D 0; =20 data =3D devm_kzalloc(dev, sizeof(struct amc6821_data), GFP_KERNEL); if (!data) @@ -956,6 +961,17 @@ static int amc6821_probe(struct i2c_client *client) "Failed to initialize regmap\n"); data->regmap =3D regmap; =20 + fan_np =3D of_get_child_by_name(dev->of_node, "fan"); + if (fan_np) + err =3D devm_add_action_or_reset(dev, amc6821_of_fan_put, fan_np); + + if (err) + return dev_err_probe(dev, err, + "Failed to add fan node release action\n"); + + if (fan_np) + amc6821_of_fan_read_data(data, fan_np); + err =3D amc6821_init_client(client, data); if (err) return err; --=20 2.43.0 From nobody Tue Dec 16 22:33:36 2025 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CFFA26C397; Fri, 30 May 2025 17:47:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748627225; cv=none; b=sZRgsrmO1VfcJSGSW1oS4MzzPkUwalZup2JC23ecWkSEXDPE61eHWNiMR1MjBmRzDFT4qyhz4FwkkozfsQlGpSKruNVtpHA8U3ej/0sGvTHxQQzsVTa2duOwIiTx5RNO9CqMX1yb26/DtxPIDYY/MG4F+VgaI5iBauFQ7pKbjkI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748627225; c=relaxed/simple; bh=zIxZUPINiB71fpjaRwMtAXcPO/BFOQTNAgmjWX4YAXU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I0q8H7MWw539KY0tmwBspAPpGIzKqGcJxExzfMT/EEZh2Ykt3PyWKiqN6cqSv4XuRXZv19m4oYLdmSrRDumSUjyLmPvF2eUO0N9BSuCUHzH/CCmbNwrLJGMNa52i8rweaNOp65ix1yvBIhtu6/wF90ADjwI2P5N115sO0Lav8dw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EcOxPqmi; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EcOxPqmi" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-735ac221670so1273212a34.0; Fri, 30 May 2025 10:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748627223; x=1749232023; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Q8jSrbzxTIV6JI6ROOZVNoqdJ8N6Uj17TZ6mBSovTa4=; b=EcOxPqmiI4NdnPPeESjnRNxU+IFPKzSHokjQl4dzo0tt4t0BZ6RyNTZHnlSJL/TohY MCoVofasV5lpRht05tOodYvo6BJJe/7TadH2VZ7oPeV6H3x2U1Ew7Y2FlXdaCYM+0600 YzICLd0gX3KPqK9OHBlwTQecVaruUXy8znjilM7xq1WuENxHkLXLu5mHeF83p2Ub8ei4 4jnfy2uPKG8qSN3jqAuXvGsHNsAVt86sQMUDTRN2arzsGYoFeRQPmXxnDn8MWe0rkAN6 nIrU2sEtiwNwIo+odaPYzr0QYkKakDsIu5mql/hNhjzPlkgM7n1Y9KNDGk0dUruVM6C+ le2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748627223; x=1749232023; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q8jSrbzxTIV6JI6ROOZVNoqdJ8N6Uj17TZ6mBSovTa4=; b=YTW5TOCqgwDiAeCe0Raa4Z9DZZfLYTMrcQ8dFals4ff8I4sQ76pqrfk2n8k6pys2nE bwERfYfNmX5M+h5YAVpT7EiueO1JoLAiGiSAPwsF2kDSxoiMW2onVp0BFJr8ipSob85N KAatuQcjgQtvuPJudErE4yNGvDX11j2f9fpA+H83gbfJMXWBunDHJYh7oJKGnIStdfQ1 HC4+lv2nU9H1JJrvnb+2QoUiu+Vhlsd0x/XFYSkV+G2kN1XVdsh4jjVu8ZYlXwEtc55d v44uBcmRnvuYjQ9GGTYD//cLRcnGGRerQkbtFzjG9mWIeSijFA82KcuO/XUPFQIHmm3m fsFA== X-Forwarded-Encrypted: i=1; AJvYcCWJphoVnR6q7d9qCkH2PqZvaEMOcGLIVOc+Urzj4pRFeG9tvcvkvgutPeXA/zAJ09IMPLgXR8o3HCjRm0kc@vger.kernel.org, AJvYcCXTLqoYrxNbg+XzyImq3vBF7qKaxFYhC4LVkR0JiAiT3HiICCaLdkZmoIMAr1/WkLSmt6W6YfHCSvLu@vger.kernel.org X-Gm-Message-State: AOJu0Yw+lRV5HBxD5hX4kXgkVzv/lsajR6xoGn1fBTy6BKnMuzpfJl9x EdRpDw3ZjJrM9712x7EgjUw0N92jBVP5WLlwdbCMIBCQpz2DNAlNzt2SLGsnfdVH X-Gm-Gg: ASbGncuyudOlxFpCFz/S9cg4HrCHNNODPnyUViNsrRqL/kdp6VrScOpUd1zQatWF/Ag oYMvMo9CF4cuin0CxLG+UbQZzvVTAifjGXkx2OZPBB2VWSQZmVP0HQIHrNRoLd02kafr0dDek1Z wrXLO1SFpBQip8LElc1Cug+wFL/R5t3AiT/scvwYdckLwmlXFx46GWPVuw6u/k9evSUOxQmWHl6 fawP6WBhVaMvGLJeovce1yK2aEqKvjqDdw4oMCYZ0mLiovXwDJTXqkNfGXfAZOSMcAgHYjBwXlj PazfBVUYu3msfq55KifIjRPCuqhKZTpavQrwYjxUG3crb5noy/IGMTB8BivK3D5BbiodA4n8P58 mOLDijwNU8A== X-Google-Smtp-Source: AGHT+IF8d8o2lQhmhY9V2rCtmPZaUMLenTO9/WFy67VF3R8YCRg5chd5WTUYrC4BhFSLSekT50xnSA== X-Received: by 2002:a05:6122:17a8:b0:50d:39aa:7881 with SMTP id 71dfb90a1353d-530810a550dmr5024998e0c.0.1748627211536; Fri, 30 May 2025 10:46:51 -0700 (PDT) Received: from joaog-nb.corp.toradex.com ([67.159.246.222]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-53074ab0d37sm3578591e0c.8.2025.05.30.10.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 May 2025 10:46:50 -0700 (PDT) From: =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= Date: Fri, 30 May 2025 14:46:27 -0300 Subject: [PATCH 3/3] hwmon: (amc6821) Add cooling device support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250530-b4-v1-amc6821-cooling-device-support-b4-v1-3-7bb98496c969@toradex.com> References: <20250530-b4-v1-amc6821-cooling-device-support-b4-v1-0-7bb98496c969@toradex.com> In-Reply-To: <20250530-b4-v1-amc6821-cooling-device-support-b4-v1-0-7bb98496c969@toradex.com> To: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Farouk Bouabid , Quentin Schulz Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= X-Mailer: b4 0.14.2 From: Jo=C3=A3o Paulo Gon=C3=A7alves Add support for using the AMC6821 as a cooling device. The AMC6821 registers with the thermal framework only if the `cooling-levels` property is present in the fan device tree child node. Existing behavior is unchanged, so the AMC6821 can still be used without the thermal framework (hwmon only). Signed-off-by: Jo=C3=A3o Paulo Gon=C3=A7alves --- drivers/hwmon/amc6821.c | 95 +++++++++++++++++++++++++++++++++++++++++++++= +--- 1 file changed, 91 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c index a969fad803ae1abb05113ce15f2476e83df029d9..f4c2aa71a0e68c071fa49155673= 27585c20ab5f5 100644 --- a/drivers/hwmon/amc6821.c +++ b/drivers/hwmon/amc6821.c @@ -26,6 +26,7 @@ #include #include #include +#include =20 #include =20 @@ -126,6 +127,9 @@ module_param(init, int, 0444); struct amc6821_data { struct regmap *regmap; struct mutex update_lock; + unsigned long fan_state; + unsigned long fan_max_state; + unsigned int *fan_cooling_levels; enum pwm_polarity of_pwm_polarity; }; =20 @@ -805,6 +809,56 @@ static const struct hwmon_chip_info amc6821_chip_info = =3D { .info =3D amc6821_info, }; =20 +static int amc6821_get_max_state(struct thermal_cooling_device *cdev, unsi= gned long *state) +{ + struct amc6821_data *data =3D cdev->devdata; + + if (!data) + return -EINVAL; + + *state =3D data->fan_max_state; + + return 0; +} + +static int amc6821_get_cur_state(struct thermal_cooling_device *cdev, unsi= gned long *state) +{ + struct amc6821_data *data =3D cdev->devdata; + + if (!data) + return -EINVAL; + + *state =3D data->fan_state; + + return 0; +} + +static int amc6821_set_cur_state(struct thermal_cooling_device *cdev, unsi= gned long state) +{ + struct amc6821_data *data =3D cdev->devdata; + int ret; + + if (!data || state > data->fan_max_state) + return -EINVAL; + + ret =3D regmap_write(data->regmap, AMC6821_REG_DCY, + data->fan_cooling_levels[state]); + if (ret) + return ret; + + data->fan_state =3D state; + + /* Change to manual mode (software DCY) */ + return regmap_update_bits(data->regmap, AMC6821_REG_CONF1, + AMC6821_CONF1_FDRC0 | AMC6821_CONF1_FDRC1, 0); +} + +static const struct thermal_cooling_device_ops amc6821_cooling_ops =3D { + .get_max_state =3D amc6821_get_max_state, + .get_cur_state =3D amc6821_get_cur_state, + .set_cur_state =3D amc6821_set_cur_state, +}; + /* Return 0 if detection is successful, -ENODEV otherwise */ static int amc6821_detect(struct i2c_client *client, struct i2c_board_info= *info) { @@ -849,10 +903,12 @@ static int amc6821_detect(struct i2c_client *client, = struct i2c_board_info *info return 0; } =20 -static void amc6821_of_fan_read_data(struct amc6821_data *data, - struct device_node *fan_np) +static int amc6821_of_fan_read_data(struct i2c_client *client, + struct amc6821_data *data, + struct device_node *fan_np) { struct of_phandle_args args; + int num; =20 data->of_pwm_polarity =3D PWM_POLARITY_NORMAL; =20 @@ -862,6 +918,22 @@ static void amc6821_of_fan_read_data(struct amc6821_da= ta *data, =20 of_node_put(args.np); } + + num =3D of_property_count_u32_elems(fan_np, "cooling-levels"); + if (num <=3D 0) + return 0; + + data->fan_max_state =3D num - 1; + + data->fan_cooling_levels =3D devm_kcalloc(&client->dev, num, + sizeof(u32), + GFP_KERNEL); + + if (!data->fan_cooling_levels) + return -ENOMEM; + + return of_property_read_u32_array(fan_np, "cooling-levels", + data->fan_cooling_levels, num); } =20 static enum pwm_polarity amc6821_pwm_polarity(struct amc6821_data *data) @@ -970,7 +1042,11 @@ static int amc6821_probe(struct i2c_client *client) "Failed to add fan node release action\n"); =20 if (fan_np) - amc6821_of_fan_read_data(data, fan_np); + err =3D amc6821_of_fan_read_data(client, data, fan_np); + + if (err) + return dev_err_probe(dev, err, + "Failed to read fan device tree data\n"); =20 err =3D amc6821_init_client(client, data); if (err) @@ -986,7 +1062,18 @@ static int amc6821_probe(struct i2c_client *client) hwmon_dev =3D devm_hwmon_device_register_with_info(dev, client->name, data, &amc6821_chip_info, amc6821_groups); - return PTR_ERR_OR_ZERO(hwmon_dev); + if (IS_ERR(hwmon_dev)) + return dev_err_probe(dev, PTR_ERR(hwmon_dev), + "Failed to initialize hwmon\n"); + + if (IS_ENABLED(CONFIG_THERMAL) && fan_np && data->fan_cooling_levels) + return PTR_ERR_OR_ZERO(devm_thermal_of_cooling_device_register(dev, + fan_np, + client->name, + data, + &amc6821_cooling_ops)); + + return 0; } =20 static const struct i2c_device_id amc6821_id[] =3D { --=20 2.43.0