From nobody Wed Feb 11 04:00:18 2026 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51B78218AB3; Thu, 29 May 2025 20:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748550508; cv=none; b=NuJA1rjdNKgRPJJQ2DAN1fQ85rz+CFhhyxrJxa0yt08M/dIY7Lqd4zCavXh1tL10L9PHpTYy/pxRFJzKBIYs810YRBbpUug9cFYy2RxAJJEUQhsmN/TG7V6VEleCm5154DoWwS9j/gchynEJY+UbRkwUiHGlNs333zg6cfyCOXM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748550508; c=relaxed/simple; bh=HktfipjCtbNhdpQdjG/jx9IyuttYJiKuu2cQchPP5AQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XyY4HkgI/GOa9EorEEUg3KNwt/RHrUQesP3yu8leiPSTXtTgvOWwpBf1d4qL/+Srfl75U+O1IMsq3vSE/7mxO5ZTMQe5/GNPGD4vTvMc3nOMf5Sjcdt+9BP6huMv080S/JEHtCx0UY+oJi3tFUPYUKJURwwz3vv0CTD2nFkrD98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jiB/cQhb; arc=none smtp.client-ip=209.85.167.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jiB/cQhb" Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-40337dd3847so821965b6e.0; Thu, 29 May 2025 13:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748550506; x=1749155306; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=80W2fxDPnqr3BsAdMQ1F8twH1xONkZpWztd0paXrfPc=; b=jiB/cQhb78Cq/MYQpECsAwKNcc/VqrvV1kSyA5phtElYnJF5Zq5322viBwAWczpy9a mEXL1BMYL26dAF8zG0cuJbmL3yQVegzpjfrV/rmuKhDI8oUcPcjS9qw/zsmHYcfTxD/j 7YonSClF09xNmF3XgF93Na4Ce0ol/yy/yEovyLdjufnftemAdsmuzZX79K+Qp5RY7/WH +wWo3B7X07oTl0lrtF1agOeTcSYPT/Zb+ihGTmtr91jrIuwVBCCML1XM6oTd2DxXlSZL /0RoEI73MVtWjc9XK1u72MtkjoJQDXgJOGCZtZcTzF3R6eja5uGBAUsSwkFLU48oHomp KFRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748550506; x=1749155306; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=80W2fxDPnqr3BsAdMQ1F8twH1xONkZpWztd0paXrfPc=; b=SKoDdUcmIs8aCrRVd5NcKb3Pod62/+6MQjrWaRO8HivoKLw1zqxnwO0BXyktJFBVgn FS8F9iiInplM1vaRueafTDQq+OqJvp19xqYaAr0WxinTHhIwj4CYCTNAxKGSmFY0G2bo 6l5vjkCVbK0BZE+ZXmL4PhvR/2Pi2LM01jKVYzxW0fy6JTBnWOGCSGw26AbqmRJEitrY 5cskn0550G5UkzOEe0IutsRnFkBBRlORdnS95YFmMMWNKYd4mqk7h9Um+etK0sAfsRZz HKN1kTOHkkX5xSML/k+kcmoeJDCBPh7RSN3C6RmwlDsIOx3HUAdcL+fk6r49K4qjvhOj ZZIA== X-Forwarded-Encrypted: i=1; AJvYcCWYdm9T9wHyhsy6W1m2J3LOPOw++Hs2Xl/zCom9ZTD45eEvCiwA6U2FwmdcWBcMRCigQY/MXb82jQqxyqqYD6WRLW1b@vger.kernel.org X-Gm-Message-State: AOJu0Yyqq5lXoyjhNIpyy10gDP/EtQOzpZDf0y3LPv9jEN6oGXJIBbIG 9h44/YuUV3fONELZWxJJyQU+7kk3RbWdfyXzufovnENnbE6KEsXU0nwozkukTA== X-Gm-Gg: ASbGncsa4jOztJjCosWS0HbJobXW/XqO3EnzQS8wPRvLgczS1MFVHolA9m0L9hH0yfq 5f5Fq/fe8YgNZKOArV9uT7cMGBoJ79hBEOSLEu2xxdmy9kGnYKWhKfSZUsAZDRktR5kvk4k9hDA JY5tQqbpg9eA+GroXqfl2dONLbeVNVri3WA9kML1cp9gdKkJa6OTvVqG414UI6wY2w0f3ydsTnC sMZvCT+lwDaYJltZVuehzYDJrSbwjfB5QB47SQUsbnL/lXJrOQXpukdf7nqXj/vbMEd86Rp4Hv0 1M15VIdtn3CxwqxTEwOh1EowEfINj2mmdwAGJL6n3rcHqB5v9/Yb4rqNkRu002ECw4SjwHOVKVo b0j2b2zA9gUpJz+lQlzS4fRxwveIH X-Google-Smtp-Source: AGHT+IHxaknsXmZ//EqapzVARMwWBL6kJPnekK+QuGfKiKPeEPq2HebqX/wW+TibfpKE9ZIKmGR5qw== X-Received: by 2002:a05:6808:3205:b0:3f6:abbf:bb88 with SMTP id 5614622812f47-406797191cbmr641215b6e.29.1748550506170; Thu, 29 May 2025 13:28:26 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40678bf36e7sm129240b6e.1.2025.05.29.13.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 13:28:25 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v3 1/4] platform/x86: dell_rbu: Fix lock context warning Date: Thu, 29 May 2025 15:27:55 -0500 Message-ID: <20250529202758.8440-2-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250529202758.8440-1-stuart.w.hayes@gmail.com> References: <20250529202758.8440-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix a sparse lock context warning. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index e30ca325938c..7b019fb72e86 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -91,7 +91,7 @@ static void init_packet_head(void) rbu_data.imagesize =3D 0; } =20 -static int create_packet(void *data, size_t length) +static int create_packet(void *data, size_t length) __must_hold(&rbu_data.= lock) { struct packet_data *newpacket; int ordernum =3D 0; --=20 2.47.1 From nobody Wed Feb 11 04:00:18 2026 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EBD223373B; Thu, 29 May 2025 20:28:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748550510; cv=none; b=tfzSuyzK5KMQqGZk22sCxCflBkl9DqXyBRBYgJVBH2BBJnSURctmRl9dU8IwZi8IhRavhIlKnBAq5pUo9cK1pZdvgzLIdyFBP5Jr6Ws6an7MfPuTbXBF9GzBFFUdUl/y3NtYVyZJ6rSZjYzphtCBwtcRW0UIDgzRQKJxaQLyG90= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748550510; c=relaxed/simple; bh=4QigIJJtFhfGtuvuRpNapzNIjz1K8h6hBpd96b9I0jE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RPqsJqF27p2KrX5zxiTNnJoWDt87QN1Xb1wliK9yV0yMmi9m1z6R6uYnNbPUPWr+zE1rBuotfztUeCc0Un2GfH2ohR2ZXd6Ulz0iyJPBWrT0W96kPaRJrp3BYNwU9y+k/K9ELd21Or9m7KFrXDJHNSfbr+qcWAv/qTNKe9lvmLw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LwpiUuzZ; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LwpiUuzZ" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-4064ec636a4so722216b6e.0; Thu, 29 May 2025 13:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748550507; x=1749155307; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4lAWOmPKQaPD4W7Jj0y6egQe+m1Gk8ZudifLKaUMwoU=; b=LwpiUuzZSrstJ8rZxSrhr2U/VmJrN4r5v0oHfd9/yPqJ8qLX+6R4TNVAt5bE8V5xp3 OO2VmUU1+sBuRjLco7zxrP1Aw8gk+/B0QfETMQYRGiMf6i7a1cThBGQxcB5339Xq1/oP 2ooehilPEz05bB8ErTufUtS6tz9ZE11qqyNVeH3vDmSSWhLPfpeDlIP8ib2Nm5x3RyIt T0NOcvPx6zhLhNcJq0686ZR9sPzcpDyRcbsP3wHy4/1ad2akvrvAepQWY/hLTph2RFE8 ch4tz7DWgcjeR9k/jQk2tHvGGQ3uQg8PtXhliEQhPKw2h9EhzVZ+kE7JfCeVMEp3ocnv WMNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748550507; x=1749155307; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4lAWOmPKQaPD4W7Jj0y6egQe+m1Gk8ZudifLKaUMwoU=; b=o+ygBUWLubpGMYfja0cq0CTTDJL76k6nUVeCHqebkmB3CRqBY8nHNHQuU/kvphW4+e cQOs0symzmbLCtgJYTJEGGdH1tWWRl8M4S4mTuFFoHIjlytudbcaGnxjeNLuaP58Sa9p NbsbGbQuwgz5S7CkUNLMPMQ+9/5qsIayc1DxHAPkozVZmxeuzNau9JVG02P3jkvBWYCN 53IdbyVfQZtducIUojPKTFN3HGWjqI1SyPagiBuWrtw9ORqWMGDuCQiSefgF6nl/9CxE hWfY8DbrxO/t+dfni1/85qZorm7bfCOMq/tuU7t7GsHUMKmbkXWT+wR+O/olpk0I/xo7 9vNg== X-Forwarded-Encrypted: i=1; AJvYcCW4jw5j/UWWPKyPg7NGQ9IzJ+HmJ1Wtj3kOMLSArur59pdwTNBbPycDh/SIoNFntodRqAPC/YU5HjMRhHkUHsFc7+KJ@vger.kernel.org X-Gm-Message-State: AOJu0Yx1oPvvno2frqbsrh5AS9B2yMrkq1ZnK+JOndE6RoacYFCAq9RI a8VEgkWpde4eT4RdsasRxtrxAGWN7uMLwbz8wuUrhx0+UYfy3m07y7wh/kF2Ag== X-Gm-Gg: ASbGncvXYd5sbduLHZ7ZxBxm5YFipm464Bwkz9ADSkV9Mq9Y6rKpx1hOkPlhcx4ES2L CMGVZoJJEqTlcqeYnHRnVCgXe1Jdt4tin7+D/7jBUO7/K1cQsCD6azY3kvhmMFCOuTLNthG0T8Q CS+MRrrYoX0qqRjOGRMCB0giUPr+ZlRyW4S2nf89T4exXITQNCsjJOblAR0tz9xGG18wUTRHrGw 2Y9vyw36b+OOHxVaUB7APO2R6wwht2236VF/tmUwCF4K+s7YQBC8xtEUFAh1o075GrRklHlPBep 7hTiFPSuJssrIsaRxnqr/vWh1yEWVzSPcCPTsDtQC/3VDUx7LVPPgfZ9s6KONPyIBQjKDRmydWE zyfX4lyGs6eWoqPmM9A== X-Google-Smtp-Source: AGHT+IGNACWi5LxDJXy/aCeVmiLM0LbcdHq7MlgqsaOxetl338Z3qCUReM7pf3CJypyJN9eUwCcokA== X-Received: by 2002:a05:6808:319a:b0:403:31a4:f3fe with SMTP id 5614622812f47-4067974f447mr657929b6e.32.1748550507380; Thu, 29 May 2025 13:28:27 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40678bf36e7sm129240b6e.1.2025.05.29.13.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 13:28:27 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v3 2/4] platform/x86: dell_rbu: Fix list usage Date: Thu, 29 May 2025 15:27:56 -0500 Message-ID: <20250529202758.8440-3-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250529202758.8440-1-stuart.w.hayes@gmail.com> References: <20250529202758.8440-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Stop using an entire struct packet_data just for the embedded list_head, and fix usage of that list_head. Fixes: d19f359fbdc6 ("platform/x86: dell_rbu: don't open code list_for_each= _entry*()") Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index 7b019fb72e86..c03d4d55fcc1 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -77,14 +77,14 @@ struct packet_data { int ordernum; }; =20 -static struct packet_data packet_data_head; +static struct list_head packet_data_list; =20 static struct platform_device *rbu_device; static int context; =20 static void init_packet_head(void) { - INIT_LIST_HEAD(&packet_data_head.list); + INIT_LIST_HEAD(&packet_data_list); rbu_data.packet_read_count =3D 0; rbu_data.num_packets =3D 0; rbu_data.packetsize =3D 0; @@ -183,7 +183,7 @@ static int create_packet(void *data, size_t length) __m= ust_hold(&rbu_data.lock) =20 /* initialize the newly created packet headers */ INIT_LIST_HEAD(&newpacket->list); - list_add_tail(&newpacket->list, &packet_data_head.list); + list_add_tail(&newpacket->list, &packet_data_list); =20 memcpy(newpacket->data, data, length); =20 @@ -292,7 +292,7 @@ static int packet_read_list(char *data, size_t * pread_= length) remaining_bytes =3D *pread_length; bytes_read =3D rbu_data.packet_read_count; =20 - list_for_each_entry(newpacket, (&packet_data_head.list)->next, list) { + list_for_each_entry(newpacket, &packet_data_list, list) { bytes_copied =3D do_packet_read(pdest, newpacket, remaining_bytes, bytes_read, &temp_count); remaining_bytes -=3D bytes_copied; @@ -315,7 +315,7 @@ static void packet_empty_list(void) { struct packet_data *newpacket, *tmp; =20 - list_for_each_entry_safe(newpacket, tmp, (&packet_data_head.list)->next, = list) { + list_for_each_entry_safe(newpacket, tmp, &packet_data_list, list) { list_del(&newpacket->list); =20 /* --=20 2.47.1 From nobody Wed Feb 11 04:00:18 2026 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC70729344F; Thu, 29 May 2025 20:28:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748550511; cv=none; b=Sxo+bAMhxNdW51LOKhtUyASeAYjXFz7/N3ud4tMSurnQi7bGVyFSKjNrwCcZV85F1mfpPUrYXzPx81yCwLkqL54ov01vcs3WFU6dKUf2F+KGEvSQmM8XzA+ahoBcySnkcjms13zCPOdRs0CxDnqsS9QhVTNmlAT88fonYMEPWwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748550511; c=relaxed/simple; bh=j4Rz+vKZeBfIclnN4tH4NBfCpbSSx+npFeWIyxOX1ws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vpop0FfR64UEzgz86FzRWs9OUZ1zg4WpsXdu8qVAwLCwzs+sVnDgNOEIJsuonITitghxtHSCrD0L+k/QFIKxEkJcxXOXX6LbkcYLz7n1eB3XOgkw8sEs8Tt/pr/XxSB9FM23SsgFl+ZJKOle1SimPFjoqOrrM5wBzCWYuCIcE9A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rsxl1NDw; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rsxl1NDw" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3fa6c54cc1aso836296b6e.1; Thu, 29 May 2025 13:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748550509; x=1749155309; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BDV8YPVZzgaow0FzJSxMsoVpPwzC55w9udNCWUvGvzo=; b=Rsxl1NDwM+PMVQijclVa9dnZe7XdpjD56tygFDKFCfkJnqSKoq/FE6fAc8mFBLdsIh b7A3lbezi+gDapR/K2GhB2ml+O3i1ld/yre852+TtEMe/G2YuPfL6yQBxR7MbQSST+kH sw0e2sDbTV/BcPqW2YwXwyY0d4uXRMuxRUN/bQ1/16MsF3E9fQwKvV+XuidNW0XSNm1q BDtt7ogad+LFJKsC9hIY4f7LXyRt+2DCRdpaBOcBYs2WU0XDIXQHcbMQeFPGwI3kPMd5 rApW5m0BK5vdw7U5NF7fsI6PKVd63I/upsPrnpbSfCJJKN/y+Ddr5jKyGiTTTU31gc1+ M0WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748550509; x=1749155309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BDV8YPVZzgaow0FzJSxMsoVpPwzC55w9udNCWUvGvzo=; b=qgwpJGB+ICk7yv0G2ps8cEBfVpVBfek7x4XOI2g2zh+r/rzsXrC3oa69U75j6Z1Zvf UM2vtphw6cf//cTQEmFUUMQmIewvVqIgKiIW/KDKql90ncp4cRdgLRClUGc7R/dPACQn Ws7MVcMbP6AuVQ8zyOxgHldm+mPfV2TAjvTCzQrhrcpHYYWUbhs3vz0qCSulvf9nXZwt F4x1mYwNMvGiuXfO4D84c9aQh41a4rDOi3gOtHVsecoiadescCQmxaDM9fLLuuNC8lml PmcgnGNzW3dGyLJXADa77YWof5CNTwmSk1uGNZyZmpDFcuy7zo+Rp1yUGEEXajqea/pd nyoQ== X-Forwarded-Encrypted: i=1; AJvYcCU7q5g2D3K37D6nPrS+Bg+on7Xgadw8Jta2NOUwvtX2zZFWVXo21rlvQktS7kX65lSV0tW+3E0muFhF9dMyvw0vVn2Y@vger.kernel.org X-Gm-Message-State: AOJu0YzFK1wjESyTcc/ErcpINWBWEP0E/V/RERwJKFPuEjPv4MrEty/i 4/RSlPvAjPs28XqNcTCjPgjc/+tTj+kzNOECdfsZrjyFu26CRT/LgkHmG7e8Ew== X-Gm-Gg: ASbGncv/POpGtw7GhYaJHB+j0pCjqsIqJJP/ayflxd/mJwfCi1iu2kMvvXfWWJ4jtk7 RjCwLTTvAcb0r2NN+UrzfUXnpNNCdm1Si/HB1B76Rmrg+98jlBQpTORlxWF15TG1v/CIeqLFZjb 6lSuB/NgRMRjULJoP0hwDpp/Zvg1sOw3bKB4BIEqgsHAReYo7N8JBbw0rFcn7bgxvuu3GSRrNJv beOVb3JY87HQ0bBrwn3fn39++oSCKYnDa/dEwwbCqSp8b+g2kRJkingm0MxBMRvuTWwW5EwLArQ au/tNbgozoLD7Cy9Chg1VXoHL3qLyo9+XX2ZvsilnNOzcuzTIeoyZxo9dXavsVeHaEMkPIrVaAR KAf/XVQpcULqRcwZ78Q== X-Google-Smtp-Source: AGHT+IH//Qn/Q627LmwtBoWMKKkwlc3ijdvxdDynb8jiZUe/1S98AeHj8C12hAeT75okkBa5b2tO2w== X-Received: by 2002:a05:6808:6a94:b0:404:e0b3:12f with SMTP id 5614622812f47-40679630b29mr637179b6e.11.1748550508695; Thu, 29 May 2025 13:28:28 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40678bf36e7sm129240b6e.1.2025.05.29.13.28.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 13:28:28 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v3 3/4] platform/x86: dell_rbu: Stop overwriting data buffer Date: Thu, 29 May 2025 15:27:57 -0500 Message-ID: <20250529202758.8440-4-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250529202758.8440-1-stuart.w.hayes@gmail.com> References: <20250529202758.8440-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dell_rbu driver will use memset() to clear the data held by each packet when it is no longer needed (when the driver is unloaded, the packet size is changed, etc). The amount of memory that is cleared (before this patch) is the normal packet size. However, the last packet in the list may be smaller. Fix this to only clear the memory actually used by each packet, to prevent it from writing past the end of data buffer. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index c03d4d55fcc1..7d5b26735a20 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -322,7 +322,7 @@ static void packet_empty_list(void) * zero out the RBU packet memory before freeing * to make sure there are no stale RBU packets left in memory */ - memset(newpacket->data, 0, rbu_data.packetsize); + memset(newpacket->data, 0, newpacket->length); set_memory_wb((unsigned long)newpacket->data, 1 << newpacket->ordernum); free_pages((unsigned long) newpacket->data, --=20 2.47.1 From nobody Wed Feb 11 04:00:18 2026 Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099B4293725; Thu, 29 May 2025 20:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748550512; cv=none; b=Ilp1LmibRQeOucOIYNYFynaPEw8mz34pc7T03SULTt338ZvtShR+53OyQ3u0Ke0jEevEWkrDhDhWmKNZApC4EU+c9t0+pDgbksvNX11XxtWYrNBM8FQ43cVlmmB4ZrDSZHwG9yYSzRqmtzCSOwtudut3yHX//Gz/moCQ6w3CJTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748550512; c=relaxed/simple; bh=QBX0wKas8hMg8UqxUJo8euFBcQTuFEJmE6HLDNOpMw0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fbD5ZIsVlEkUXcRTDP2osxhPaUpO7KV0TaPn9p3G7Wwdl9hZEb50qrS5hI8GtcRFIetFzf4xK2LSnokJOcy+UbKDgsJ4qC8qJwxfpkSi0YjtMI6rYlbErPwoJfbzTnoVehQCZHR1FTR9MBQRK9N1x2opRI+Wyf8Wbs9be0frcBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mgLlF2KE; arc=none smtp.client-ip=209.85.161.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mgLlF2KE" Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-60be827f2b7so649920eaf.0; Thu, 29 May 2025 13:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748550510; x=1749155310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DDwrjOc2P0lgnjjq9Q/Gy/AuUSnuvG7kFTIq26PL/EI=; b=mgLlF2KE4kiT7EeQNzUWohqOqKFzDWBpRcihOHrvD49Z3iwKGxbEOxhBnRijKtIpCh 5SjCdE0mioEnAyOtvYBFZIpIrLxde0dzFCo0zroEnSegDGT51SfxGt6sFTWTHhLF0Ks0 gmgCpEFgbeb4/1572Vn4fVlt2gfCxWnHMs4iWE3d6fOVcu652wDcryoNexdfS7XVkRhJ j2iO/Dwdp7WVkRjiPmgFKiaQsRvwyktuI6urdecR3PJlpfNvvhi3Ky4teDSZ3gXC5q/k 6/CpAMXTlhaNL5KFCaElNtgkWFP3txzlTIEwy/YqQcTUo8QM95P4pvPsOYUOMTDuAXPF aMTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748550510; x=1749155310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DDwrjOc2P0lgnjjq9Q/Gy/AuUSnuvG7kFTIq26PL/EI=; b=bmmxB4dH2PTOO4RoCzuSgUEmII0geOQ1kD4szDGD/3GA4IRxAvsxJvwpO53n1tg/as 3H/tglcDWQOCBLaJnW2RkSwrKUw3p1EOj9VmtxZX2TVx5chCBSc+k/wnRTKdWOza6Oej GR5GTIFsz9SmX+NBPBZWGn484JVh8SH4DH+hHkEwhISuLP1wIrV5DVsvaIHUZEftARst DjR//ZJydOhu1KRBdQBI7WH6y0551kUbH+8VyCgdJu7xqQ195+K9ARqTvaWJIIeisg64 1WaPZ3G2kvzCRxCJJj1P13KIqxm5bJLEf4Q2yBKpt6z7oUklD10oUMRPu13MzBq1eGZO iU6g== X-Forwarded-Encrypted: i=1; AJvYcCUA5g4jhglAjj0FDFGhBzHbonQ7zFwClmii6V3YkS+EAWMiTDVY7BaS2uqhiwdzfrluFDL7q2S6KWs9z3C5/HWCx9Jh@vger.kernel.org X-Gm-Message-State: AOJu0YxBU8hEEMf1/WY7OersqRBMhXfjo76xEibDhDT+KeNiRxembOSE EVLFJQDNdstdqKLQ11XfhdGGHipGq1oxlV4fpDIaO9xc/ZVVM+Ws9UWiQlXS/Q== X-Gm-Gg: ASbGncv5dIZV7UxHXXji3TDgenlz5Fji17vCi5fHoncsK+r7n40Ex3FDPnrLSfppcjx uaDNj1Hq1BU3Qcx+By5x2EB1J3Qj/P9TNW+Xc3vajmhPYb1RO60pMAD3Ap4UyhhV5jSCFXH9CJx 4roI46QpbGHaxI/O/D3t0RMFgvewqdh+7c58ap86wt8+0jVv0i+hhDJkjXGzw/aYPlzXCkk4tj4 1ktIu7U8QfxDwC/KgKa+ILp+fVYoOoFNRTnwWdNY3sXMDDxk1GhYKHrdG3ZeMNWuxYhXy09b+K8 +74kr+gt97nO0OKlInOsn9AIBhZjKJp3HEPrh52Hnlyav0P8eLa8ofoa36plk1/Gx5284UEeuV4 VQYT5M6iz7Pv6RnXr2w== X-Google-Smtp-Source: AGHT+IHF4HZ++L8kM1VGf0rEhKmV59LLBJotobAimHoIQQjkhamAF/oB3sGTdm8zOhi7vwQ9xI9hSg== X-Received: by 2002:a05:6808:6a87:b0:3f8:18a3:b1cc with SMTP id 5614622812f47-40679fd1c7cmr484415b6e.12.1748550509905; Thu, 29 May 2025 13:28:29 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40678bf36e7sm129240b6e.1.2025.05.29.13.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 13:28:29 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v3 4/4] platform/x86: dell_rbu: Bump version Date: Thu, 29 May 2025 15:27:58 -0500 Message-ID: <20250529202758.8440-5-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250529202758.8440-1-stuart.w.hayes@gmail.com> References: <20250529202758.8440-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Bump the module version. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index 7d5b26735a20..45c0a72e494a 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -45,7 +45,7 @@ MODULE_AUTHOR("Abhay Salunke "); MODULE_DESCRIPTION("Driver for updating BIOS image on DELL systems"); MODULE_LICENSE("GPL"); -MODULE_VERSION("3.2"); +MODULE_VERSION("3.3"); =20 #define BIOS_SCAN_LIMIT 0xffffffff #define MAX_IMAGE_LENGTH 16 --=20 2.47.1