From nobody Wed Feb 11 15:26:17 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 299FA1F19A; Thu, 29 May 2025 19:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748546472; cv=none; b=k8pGLarmKvBYiQ8/JrkfYLkIkbEhAKcYeMG+AVwEBbfQktNyGPWk15pFpOZFsq38t5wTW4eI7L27OCXnQ3WttEp12uHa+q1k9CLJGlUYOHJ5Vdj3OVf6EQxyRjeLilSCv0CtMOhBfqLCxESAozLYB6Zo/7pdehtUbJHt3h5pNd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748546472; c=relaxed/simple; bh=6/7lIB6NeUWu/dHkq3BraSNFkiBew2d2Z+vXCwbFpmY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=YNczyK4uJ8RuKoEsSeUQcx+moddDlO7GFIgU5XYJgsXa6R2m0HPirIPKsqD6DlAb8l/pYnrq3bvk6w7YYvP6JzSBtSrqYdMywEZnoQCRT4Q2oM73gBd8422eOFHrDsvGXItMPxja62GdjEGG4YXBmpNol6+952M2xQS/URgY7RE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F725C4CEE7; Thu, 29 May 2025 19:21:09 +0000 (UTC) Date: Thu, 29 May 2025 15:22:11 -0400 From: Steven Rostedt To: LKML , Linux Trace Kernel , nvdimm@lists.linux.dev Cc: Dan Williams , Shiyang Ruan , "Darrick J. Wong" , Ross Zwisler , Andrew Morton Subject: [PATCH v2] fsdax: Remove unused trace events for dax insert mapping Message-ID: <20250529152211.688800c9@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the dax_fault_actor() helper was factored out, it removed the calls to the dax_pmd_insert_mapping and dax_insert_mapping events but never removed the events themselves. As each event created takes up memory (roughly 5K each), this is a waste as it is never used. Remove the unused dax_pmd_insert_mapping and dax_insert_mapping trace events. Link: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.hom= e/ Fixes: c2436190e492 ("fsdax: factor out a dax_fault_actor() helper") Signed-off-by: Steven Rostedt (Google) Reviewed-by: Alison Schofield --- Changes since v1: https://lore.kernel.org/all/20250529150722.19e04332@ganda= lf.local.home/ - Removed dax_insert_mapping too include/trace/events/fs_dax.h | 78 ----------------------------------- 1 file changed, 78 deletions(-) diff --git a/include/trace/events/fs_dax.h b/include/trace/events/fs_dax.h index 86fe6aecff1e..76b56f78abb0 100644 --- a/include/trace/events/fs_dax.h +++ b/include/trace/events/fs_dax.h @@ -102,54 +102,6 @@ DEFINE_EVENT(dax_pmd_load_hole_class, name, \ DEFINE_PMD_LOAD_HOLE_EVENT(dax_pmd_load_hole); DEFINE_PMD_LOAD_HOLE_EVENT(dax_pmd_load_hole_fallback); =20 -DECLARE_EVENT_CLASS(dax_pmd_insert_mapping_class, - TP_PROTO(struct inode *inode, struct vm_fault *vmf, - long length, pfn_t pfn, void *radix_entry), - TP_ARGS(inode, vmf, length, pfn, radix_entry), - TP_STRUCT__entry( - __field(unsigned long, ino) - __field(unsigned long, vm_flags) - __field(unsigned long, address) - __field(long, length) - __field(u64, pfn_val) - __field(void *, radix_entry) - __field(dev_t, dev) - __field(int, write) - ), - TP_fast_assign( - __entry->dev =3D inode->i_sb->s_dev; - __entry->ino =3D inode->i_ino; - __entry->vm_flags =3D vmf->vma->vm_flags; - __entry->address =3D vmf->address; - __entry->write =3D vmf->flags & FAULT_FLAG_WRITE; - __entry->length =3D length; - __entry->pfn_val =3D pfn.val; - __entry->radix_entry =3D radix_entry; - ), - TP_printk("dev %d:%d ino %#lx %s %s address %#lx length %#lx " - "pfn %#llx %s radix_entry %#lx", - MAJOR(__entry->dev), - MINOR(__entry->dev), - __entry->ino, - __entry->vm_flags & VM_SHARED ? "shared" : "private", - __entry->write ? "write" : "read", - __entry->address, - __entry->length, - __entry->pfn_val & ~PFN_FLAGS_MASK, - __print_flags_u64(__entry->pfn_val & PFN_FLAGS_MASK, "|", - PFN_FLAGS_TRACE), - (unsigned long)__entry->radix_entry - ) -) - -#define DEFINE_PMD_INSERT_MAPPING_EVENT(name) \ -DEFINE_EVENT(dax_pmd_insert_mapping_class, name, \ - TP_PROTO(struct inode *inode, struct vm_fault *vmf, \ - long length, pfn_t pfn, void *radix_entry), \ - TP_ARGS(inode, vmf, length, pfn, radix_entry)) - -DEFINE_PMD_INSERT_MAPPING_EVENT(dax_pmd_insert_mapping); - DECLARE_EVENT_CLASS(dax_pte_fault_class, TP_PROTO(struct inode *inode, struct vm_fault *vmf, int result), TP_ARGS(inode, vmf, result), @@ -194,36 +146,6 @@ DEFINE_PTE_FAULT_EVENT(dax_load_hole); DEFINE_PTE_FAULT_EVENT(dax_insert_pfn_mkwrite_no_entry); DEFINE_PTE_FAULT_EVENT(dax_insert_pfn_mkwrite); =20 -TRACE_EVENT(dax_insert_mapping, - TP_PROTO(struct inode *inode, struct vm_fault *vmf, void *radix_entry), - TP_ARGS(inode, vmf, radix_entry), - TP_STRUCT__entry( - __field(unsigned long, ino) - __field(unsigned long, vm_flags) - __field(unsigned long, address) - __field(void *, radix_entry) - __field(dev_t, dev) - __field(int, write) - ), - TP_fast_assign( - __entry->dev =3D inode->i_sb->s_dev; - __entry->ino =3D inode->i_ino; - __entry->vm_flags =3D vmf->vma->vm_flags; - __entry->address =3D vmf->address; - __entry->write =3D vmf->flags & FAULT_FLAG_WRITE; - __entry->radix_entry =3D radix_entry; - ), - TP_printk("dev %d:%d ino %#lx %s %s address %#lx radix_entry %#lx", - MAJOR(__entry->dev), - MINOR(__entry->dev), - __entry->ino, - __entry->vm_flags & VM_SHARED ? "shared" : "private", - __entry->write ? "write" : "read", - __entry->address, - (unsigned long)__entry->radix_entry - ) -) - DECLARE_EVENT_CLASS(dax_writeback_range_class, TP_PROTO(struct inode *inode, pgoff_t start_index, pgoff_t end_index), TP_ARGS(inode, start_index, end_index), --=20 2.47.2