From nobody Tue Dec 16 14:56:03 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2089.outbound.protection.outlook.com [40.107.93.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC5107483; Thu, 29 May 2025 07:00:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.89 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502037; cv=fail; b=X5QNtGfCue5CfpoGlCRACBUSO1IkwrlWxigeCTV0dydLd3rShYP6AquJCuOrC775JiUmJDP3Or++132RlFZi4W+cnvXT/Kwq+pXnvloeu+jMb4nRot0ZdqRikKt8k2YyCguqQ9XXITLzE6EcnMS5oeuzY/Y9pU1YlAxMUj7wZpw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502037; c=relaxed/simple; bh=nVIF0CkYdk6JoFtwf0LQRby53RRu6IiYOUlFtdwtCok=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dic+4iksZ2II+ZR9wWJEaDYZU6w8zdX28fDHBtl1DmjEnNO3xCoookH8OV63xD7NwMiUPOjgA73Jgt4BAL56JxtZ/IMA9pH9UhVIYweKhTLv5oTPzWvav74TSjTZMH3nxa/eBY/wnBYRAk89AsAx/uAUrEW7TR0mkSqXzA1OgH8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=GaXwFQV8; arc=fail smtp.client-ip=40.107.93.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="GaXwFQV8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Mb35FEMgzZCgZOFOtFi6l2EAf6pVVn34eXcx/78saRIAs9FqtItm6/yFDeVsWUuIf+2NaWEVpHrKMfEuphfk4PFvDQDiF+uJUpRvtulhux8kVdcMQE7aPgcmgEzNgaccKfjzPWMs1GmIX5hYlyd8UN0PGHVHl6UxFGktjV4NDtipt4wbWfU90OR9KlQQMifhDSap0eANiIRwU6ZTjrkq9FsavnmmIqx/HiRuaGWRdP2QJmGnOuXMPW5XBilIWQxymDTnjlVh+0DeGNPuJBqnvi9NDuU5lsPs8kqgWHwleKmKXdD69xs+we3J03d+uRsdeI3tVG/aF0ymhoQZb09PKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NF+G9NSA0M+wvl4dnCjETwaxnGba04x8xmd7S2zuG18=; b=nJSa+sxfBl37IQpymPW5W1LPwnk3OmFoMIHliFDYx9UvocPYpbN5QOb8KlMXqzQFxR64IrS6vSvUGyg8jr4ilaWVsTykMxWf/ga5biznZS7JNom3zlqYqDRP31GDDwaxiOZHlP9y5kYC2FMAQBQ+aRP4CYtRUzVRhzz2zskUhM4FsIBfMBFIgFiULRRkM0vagiO8X2et/noFbd2VTc6rL/nJPfmQt0nB4nHA5c0nCusqJ+MU1A5wAUtNIwXHhuQ10LrBPD2+G7Bl9X+9FMfWUYd10iKxgmaq7qnzVo80gpxuQTPLNr6u61Q5Kv09XFRVet6O6rGJ05bYrzBtOIjR5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NF+G9NSA0M+wvl4dnCjETwaxnGba04x8xmd7S2zuG18=; b=GaXwFQV82JMCi2G9OpLWU1+v3n6NKTJZ5vsGOvEwiwUUPlrLE+v2BKePLPdkuTD1yPo3JT1Vftou/DlofAq/cLrcFEctX82tOItP7F8+Ne/bNN1uNGxGLYZjqwjpoDgCpbkLjEZt3hQpRZx1GKwKfAHkfILuuF9ZjQmQWRSwqf8= Received: from MN2PR16CA0001.namprd16.prod.outlook.com (2603:10b6:208:134::14) by DM4PR12MB6111.namprd12.prod.outlook.com (2603:10b6:8:ac::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.25; Thu, 29 May 2025 07:00:28 +0000 Received: from BN3PEPF0000B374.namprd21.prod.outlook.com (2603:10b6:208:134:cafe::15) by MN2PR16CA0001.outlook.office365.com (2603:10b6:208:134::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8746.26 via Frontend Transport; Thu, 29 May 2025 07:00:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B374.mail.protection.outlook.com (10.167.243.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8813.0 via Frontend Transport; Thu, 29 May 2025 07:00:27 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 29 May 2025 02:00:26 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 29 May 2025 02:00:22 -0500 From: Shubhrajyoti Datta To: , , CC: , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , "Robert Richter" , Nipun Gupta , Nikhil Agarwal , Shubhrajyoti Datta Subject: [PATCH v7 1/5] cdx: add the headers to include/linux Date: Thu, 29 May 2025 12:30:13 +0530 Message-ID: <20250529070017.7288-2-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250529070017.7288-1-shubhrajyoti.datta@amd.com> References: <20250529070017.7288-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: shubhrajyoti.datta@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B374:EE_|DM4PR12MB6111:EE_ X-MS-Office365-Filtering-Correlation-Id: f3dc4ea7-6e0c-43c5-c7f5-08dd9e7e7e51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|7416014|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?em09IyzFRdkwTer/sqAQnLEPfNH8oqHJFoML+EHwjR5AvYDFl4kblIc5w8Bg?= =?us-ascii?Q?yHJcMPTlHycHukz3OZsmUH0zHZ2uvPAobBOUKWzA1VpQVmPeL1CVLQC5hfhS?= =?us-ascii?Q?kkEBT6aixQQU18yQ4099HbtNZ5wazuRo97yKm+ODrq78UrDrIInp8TpCcZJ2?= =?us-ascii?Q?pr/pJGBugWKbifYOK7muzKuycP+p/cLQ1LT+f0b0xB1R/RwXN8IYrLxA/cVx?= =?us-ascii?Q?5Z7E2/GA/WjzLB+IejAzV0eEfp6C+9Oz2vyeMMgTKu54sMP+ehjxTwJ+xyyH?= =?us-ascii?Q?M3MtEU8uJRH8KfoGBWRNoR0NW4xqAadxKdIaZM3987DK/lxwiyfSTh1v+dZZ?= =?us-ascii?Q?TD977LU1aZd7eqYTlJ/ThARVpzA0P8S5StOzkGi0hdjLGqSS/qIvro65C0wp?= =?us-ascii?Q?4sSOb6uX6e1O8XUi1BDXzDfDhe8XsU2W2O5z1U3lllsil9jHv1z4Lz6BlTVh?= =?us-ascii?Q?zF+YkhZJu38E6gRsFo7Z+TeYcuLUEybE/FmzmmNuZELYQVNH1HkfK6e/xgDK?= =?us-ascii?Q?4lMwYmPglH1a5+Id6G2sYB34vKIeBhUc6DSPhVN+Ox/QEGfMqpaYBGmonp/1?= =?us-ascii?Q?GZxfo/Rsim9F5T6EOfcEDhc44hpCgFxI4bxXIOafD98BDdhNns95wa3Mt+6c?= =?us-ascii?Q?jLQuzLmbUYbMue6v4lsbaFxxAb8Fdts5oH4+iFTaFE1MfXpRt24Bdw4IChJa?= =?us-ascii?Q?Y/mQxe5Txdpkm3TTSV+3nFC5Tq6MqG+aGLqTDz4E0Osh6v2tZSZZigFobD3o?= =?us-ascii?Q?I2oHm362gVwZbK1gNxAiu9xalR7Ci0h7xe1QYizvcWvArWq8ldzCMQikmGcx?= =?us-ascii?Q?7k2ygsOQ2a4mZoWjVFOvzc3U5UmD54dpIT4ZzQLl1HiaB7FtdvC+PfrWG7I3?= =?us-ascii?Q?/DmmPPCDKGAR4GcNPs2Bc1gYYh+GeGjGLYFUGqa4RbzaTLhiqMaqUtywHzIS?= =?us-ascii?Q?vdFlbfdlrSxvuri092ooL2/ygNBzSeYT0TSq/MAjDVZsJKeVnHtebVY1exil?= =?us-ascii?Q?41mUAHSK5PujUxZnB9Wx6HFubdrKx3ECwt3sjML/Ndw/Zu5pXA28irgbswXd?= =?us-ascii?Q?JVJtboPw5KojTsqnhWbzpviDHxicz7AHUesw1bQfgVtGHkgu4Dv7o9S7eLNh?= =?us-ascii?Q?pQrer4Nhobn2Du54XS3JbianAz+CwfuD5tY/aB5+PMagRslURxEMfU6YphbW?= =?us-ascii?Q?2gEGfa4zZHg2PG/wrXmgGAJk+/FLYNu57PFZpsmctPTeZpJRL8/5x34c4OZZ?= =?us-ascii?Q?4+ou0dy+YBxDHSWx6fG7/88mo/kqfKqwruMF0lUTmfdIyg4+zAD7TPG4mnrB?= =?us-ascii?Q?yAkEA5AXHzpHin4n4jSpdO2LmZmyrRlU68Jg8yrgtJrAjr4Tt7GJn0rB4wUx?= =?us-ascii?Q?AbNW9spo9ggt3TI8F9/Q6SpjqKDkQo69BpRjionvcmWkUSN5l2rEQwrdMKys?= =?us-ascii?Q?iX7y6R7NIU8tcytVvcMY2/9GXvxQFJn61kWk3xTjd2goESM3VtvpVD+Q6FKJ?= =?us-ascii?Q?0/CB6VslRwPgcuStznGyHqVIMzViNaM9HFQB?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(7416014)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2025 07:00:27.8409 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3dc4ea7-6e0c-43c5-c7f5-08dd9e7e7e51 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B374.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6111 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a the bitfield.h and mcdi.h headers. This is in preparation for VersalNET EDAC driver that relies on it. Signed-off-by: Shubhrajyoti Datta Acked-by: Michal Simek --- Changes in v7: - add a minimal header instead moving them Changes in v6: - Patch added include/linux/cdx/bitfield.h | 78 ++++++++++++++ include/linux/cdx/mcdi.h | 192 +++++++++++++++++++++++++++++++++++ 2 files changed, 270 insertions(+) create mode 100644 include/linux/cdx/bitfield.h create mode 100644 include/linux/cdx/mcdi.h diff --git a/include/linux/cdx/bitfield.h b/include/linux/cdx/bitfield.h new file mode 100644 index 000000000000..3f0bf2dbb2c7 --- /dev/null +++ b/include/linux/cdx/bitfield.h @@ -0,0 +1,78 @@ +/* SPDX-License-Identifier: GPL-2.0 + * + * Copyright 2005-2006 Fen Systems Ltd. + * Copyright 2006-2013 Solarflare Communications Inc. + * Copyright (C) 2022-2025, Advanced Micro Devices, Inc. + */ + +#ifndef CDX_BITFIELD_H +#define CDX_BITFIELD_H + +#include + +/* Lowest bit numbers and widths */ +#define CDX_DWORD_LBN 0 +#define CDX_DWORD_WIDTH 32 + +/* Specified attribute (e.g. LBN) of the specified field */ +#define CDX_VAL(field, attribute) field ## _ ## attribute +/* Low bit number of the specified field */ +#define CDX_LOW_BIT(field) CDX_VAL(field, LBN) +/* Bit width of the specified field */ +#define CDX_WIDTH(field) CDX_VAL(field, WIDTH) +/* High bit number of the specified field */ +#define CDX_HIGH_BIT(field) (CDX_LOW_BIT(field) + CDX_WIDTH(field) - 1) + +/* A doubleword (i.e. 4 byte) datatype - little-endian in HW */ +struct cdx_dword { + __le32 cdx_u32; +}; + +/* + * Creates the portion of the named bit field that lies within the + * range [min,max). + */ +#define CDX_INSERT_FIELD(field, value) \ + (FIELD_PREP(GENMASK(CDX_HIGH_BIT(field), \ + CDX_LOW_BIT(field)), value)) + +/* + * Creates the portion of the named bit fields that lie within the + * range [min,max). + */ +#define CDX_INSERT_FIELDS(field1, value1, \ + field2, value2, \ + field3, value3, \ + field4, value4, \ + field5, value5, \ + field6, value6, \ + field7, value7) \ + (CDX_INSERT_FIELD(field1, (value1)) | \ + CDX_INSERT_FIELD(field2, (value2)) | \ + CDX_INSERT_FIELD(field3, (value3)) | \ + CDX_INSERT_FIELD(field4, (value4)) | \ + CDX_INSERT_FIELD(field5, (value5)) | \ + CDX_INSERT_FIELD(field6, (value6)) | \ + CDX_INSERT_FIELD(field7, (value7))) + +#define CDX_POPULATE_DWORD(dword, ...) \ + (dword).cdx_u32 =3D cpu_to_le32(CDX_INSERT_FIELDS(__VA_ARGS__)) + +/* Populate a dword field with various numbers of arguments */ +#define CDX_POPULATE_DWORD_7 CDX_POPULATE_DWORD +#define CDX_POPULATE_DWORD_6(dword, ...) \ + CDX_POPULATE_DWORD_7(dword, CDX_DWORD, 0, __VA_ARGS__) +#define CDX_POPULATE_DWORD_5(dword, ...) \ + CDX_POPULATE_DWORD_6(dword, CDX_DWORD, 0, __VA_ARGS__) +#define CDX_POPULATE_DWORD_4(dword, ...) \ + CDX_POPULATE_DWORD_5(dword, CDX_DWORD, 0, __VA_ARGS__) +#define CDX_POPULATE_DWORD_3(dword, ...) \ + CDX_POPULATE_DWORD_4(dword, CDX_DWORD, 0, __VA_ARGS__) +#define CDX_POPULATE_DWORD_2(dword, ...) \ + CDX_POPULATE_DWORD_3(dword, CDX_DWORD, 0, __VA_ARGS__) +#define CDX_POPULATE_DWORD_1(dword, ...) \ + CDX_POPULATE_DWORD_2(dword, CDX_DWORD, 0, __VA_ARGS__) +#define CDX_SET_DWORD(dword) \ + CDX_POPULATE_DWORD_1(dword, CDX_DWORD, 0xffffffff) + +#endif /* CDX_BITFIELD_H */ diff --git a/include/linux/cdx/mcdi.h b/include/linux/cdx/mcdi.h new file mode 100644 index 000000000000..46e3f63b062a --- /dev/null +++ b/include/linux/cdx/mcdi.h @@ -0,0 +1,192 @@ +/* SPDX-License-Identifier: GPL-2.0 + * + * Copyright 2008-2013 Solarflare Communications Inc. + * Copyright (C) 2022-2023, Advanced Micro Devices, Inc. + */ + +#ifndef CDX_MCDI_H +#define CDX_MCDI_H + +#include +#include +#include + +#include "linux/cdx/bitfield.h" + +/** + * enum cdx_mcdi_mode - MCDI transaction mode + * @MCDI_MODE_EVENTS: wait for an mcdi response callback. + * @MCDI_MODE_FAIL: we think MCDI is dead, so fail-fast all calls + */ +enum cdx_mcdi_mode { + MCDI_MODE_EVENTS, + MCDI_MODE_FAIL, +}; + +#define MCDI_RPC_TIMEOUT (10 * HZ) +#define MCDI_RPC_LONG_TIMEOU (60 * HZ) +#define MCDI_RPC_POST_RST_TIME (10 * HZ) + +/** + * enum cdx_mcdi_cmd_state - State for an individual MCDI command + * @MCDI_STATE_QUEUED: Command not started and is waiting to run. + * @MCDI_STATE_RETRY: Command was submitted and MC rejected with no resour= ces, + * as MC have too many outstanding commands. Command will be retried once + * another command returns. + * @MCDI_STATE_RUNNING: Command was accepted and is running. + * @MCDI_STATE_RUNNING_CANCELLED: Command is running but the issuer cancel= led + * the command. + * @MCDI_STATE_FINISHED: Processing of this command has completed. + */ + +enum cdx_mcdi_cmd_state { + MCDI_STATE_QUEUED, + MCDI_STATE_RETRY, + MCDI_STATE_RUNNING, + MCDI_STATE_RUNNING_CANCELLED, + MCDI_STATE_FINISHED, +}; + +/** + * struct cdx_mcdi - CDX MCDI Firmware interface, to interact + * with CDX controller. + * @mcdi: MCDI interface + * @mcdi_ops: MCDI operations + * @r5_rproc : R5 Remoteproc device handle + * @rpdev: RPMsg device + * @ept: RPMsg endpoint + * @work: Post probe work + */ +struct cdx_mcdi { + /* MCDI interface */ + struct cdx_mcdi_data *mcdi; + const struct cdx_mcdi_ops *mcdi_ops; + + struct rproc *r5_rproc; + struct rpmsg_device *rpdev; + struct rpmsg_endpoint *ept; + struct work_struct work; +}; + +struct cdx_mcdi_ops { + void (*mcdi_request)(struct cdx_mcdi *cdx, + const struct cdx_dword *hdr, size_t hdr_len, + const struct cdx_dword *sdu, size_t sdu_len); + unsigned int (*mcdi_rpc_timeout)(struct cdx_mcdi *cdx, unsigned int cmd); +}; + +typedef void cdx_mcdi_async_completer(struct cdx_mcdi *cdx, + unsigned long cookie, int rc, + struct cdx_dword *outbuf, + size_t outlen_actual); + +/** + * struct cdx_mcdi_cmd - An outstanding MCDI command + * @ref: Reference count. There will be one reference if the command is + * in the mcdi_iface cmd_list, another if it's on a cleanup list, + * and a third if it's queued in the work queue. + * @list: The data for this entry in mcdi->cmd_list + * @cleanup_list: The data for this entry in a cleanup list + * @work: The work item for this command, queued in mcdi->workqueue + * @mcdi: The mcdi_iface for this command + * @state: The state of this command + * @inlen: inbuf length + * @inbuf: Input buffer + * @quiet: Whether to silence errors + * @reboot_seen: Whether a reboot has been seen during this command, + * to prevent duplicates + * @seq: Sequence number + * @started: Jiffies this command was started at + * @cookie: Context for completion function + * @completer: Completion function + * @handle: Command handle + * @cmd: Command number + * @rc: Return code + * @outlen: Length of output buffer + * @outbuf: Output buffer + */ +struct cdx_mcdi_cmd { + struct kref ref; + struct list_head list; + struct list_head cleanup_list; + struct work_struct work; + struct cdx_mcdi_iface *mcdi; + enum cdx_mcdi_cmd_state state; + size_t inlen; + const struct cdx_dword *inbuf; + bool quiet; + bool reboot_seen; + u8 seq; + unsigned long started; + unsigned long cookie; + cdx_mcdi_async_completer *completer; + unsigned int handle; + unsigned int cmd; + int rc; + size_t outlen; + struct cdx_dword *outbuf; + /* followed by inbuf data if necessary */ +}; + +/** + * struct cdx_mcdi_iface - MCDI protocol context + * @cdx: The associated NIC + * @iface_lock: Serialise access to this structure + * @outstanding_cleanups: Count of cleanups + * @cmd_list: List of outstanding and running commands + * @workqueue: Workqueue used for delayed processing + * @cmd_complete_wq: Waitqueue for command completion + * @db_held_by: Command the MC doorbell is in use by + * @seq_held_by: Command each sequence number is in use by + * @prev_handle: The last used command handle + * @mode: Poll for mcdi completion, or wait for an mcdi_event + * @prev_seq: The last used sequence number + * @new_epoch: Indicates start of day or start of MC reboot recovery + */ +struct cdx_mcdi_iface { + struct cdx_mcdi *cdx; + /* Serialise access */ + struct mutex iface_lock; + unsigned int outstanding_cleanups; + struct list_head cmd_list; + struct workqueue_struct *workqueue; + wait_queue_head_t cmd_complete_wq; + struct cdx_mcdi_cmd *db_held_by; + struct cdx_mcdi_cmd *seq_held_by[16]; + unsigned int prev_handle; + enum cdx_mcdi_mode mode; + u8 prev_seq; + bool new_epoch; +}; + +/** + * struct cdx_mcdi_data - extra state for NICs that implement MCDI + * @iface: Interface/protocol state + * @fn_flags: Flags for this function, as returned by %MC_CMD_DRV_ATTACH. + */ +struct cdx_mcdi_data { + struct cdx_mcdi_iface iface; + u32 fn_flags; +}; + +/* + * We expect that 16- and 32-bit fields in MCDI requests and responses + * are appropriately aligned, but 64-bit fields are only + * 32-bit-aligned. + */ +#define MCDI_DECLARE_BUF(_name, _len) struct cdx_dword _name[DIV_ROUND_UP(= _len, 4)] =3D {{0}} +#define _MCDI_PTR(_buf, _offset) \ + ((u8 *)(_buf) + (_offset)) +#define MCDI_PTR(_buf, _field) \ + _MCDI_PTR(_buf, MC_CMD_ ## _field ## _OFST) +#define _MCDI_CHECK_ALIGN(_ofst, _align) \ + ((void)BUILD_BUG_ON_ZERO((_ofst) & ((_align) - 1)), \ + (_ofst)) +#define _MCDI_DWORD(_buf, _field) \ + ((_buf) + (_MCDI_CHECK_ALIGN(MC_CMD_ ## _field ## _OFST, 4) >> 2)) + +#define MCDI_SET_DWORD(_buf, _field, _value) \ + CDX_POPULATE_DWORD_1(*_MCDI_DWORD(_buf, _field), CDX_DWORD, _value) +#define MCDI_DWORD(_buf, _field) \ + CDX_DWORD_FIELD(*_MCDI_DWORD(_buf, _field), CDX_DWORD) +#endif /* CDX_MCDI_H */ --=20 2.34.1 From nobody Tue Dec 16 14:56:03 2025 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2072.outbound.protection.outlook.com [40.107.100.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 573B321ABC2; Thu, 29 May 2025 07:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.72 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502038; cv=fail; b=dXH+eMrqvgYTa8aBt23Z0WfkG3JeVGGK9A5e6fSjX36qXqNflti9hPZ5YgjxGy0dmUgP2GmDgL0ywhObrLrhnrLyHaat6zhAM1hMEfG+BIG1K8+gEq4kq15ReRHYtMMUh+89D02oZWSmPCLPcf/CbhRHKl6ZgAsfBbgB57WozCU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502038; c=relaxed/simple; bh=Zb4vFFeNNiQlESJ//tvai+WxYk/V9EcG5amDv9LQwEc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UgFvEMU9fou0mmnXGdHFSssaNBlSHVTEIIk6qxVIVIU01c1T51VUG9KhCG8GCpKz48XkZdIXbYrfK84jW3CSYovktk0QzYSVkyATcKDWm6vEfukmUKvMV1YcBbjjNLZOzqNAQxAOh58O5DKBzP6E624bN06ig9hnV/siolawi2w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=B6dak1Bu; arc=fail smtp.client-ip=40.107.100.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="B6dak1Bu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qjONoKGXKhjN4UnTisMx5mfvOoU0VD3No33pXW/f/ShDZhzZAACCTgIaE5+nsZkbBWUhYv54xiMteiFGNYLTfZLYuqUaqspMYkg1OFTa3cx+0Tpj6Yohtn5L8lB7fCx5Y7H8uW1TRStMITjVv2MWSmrpgV4YF36SuGLvKiTxD20dOCE9mv8gRq5ewVhSUi6xtJ04DDapmo7u2EeWgNO4QQ1KPAtHsigQ+3tktqkvMnzFb8T4IvJCvZ3umwgW9N1eYQ9lVHH8/HD0oSbidD3SSElkD8Ju5Trio+H9TJ668/UbPG+c5A/5drYQIVPFH6wf/lZCcLDuVUCOrretK9K0tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gCoJ7lNZ16ANmJoEzXub9qTrBcen1lrpDjoNpXA4ZsM=; b=uT0l1YYkOLNNK6yZ1AUCF7RrEitJlxfRxaUNb+tf5w53WyCDAuZvQXmRyQ0pWZ2J5kveh120+wlXsQqIAIumaBbf6G5E58jkTFfRZerp7sOP6oPT3rdEZm6oN1Bcodt3uSMhvXJuQXtF89oQ1pZAXLTUidxLt59jtaiM6R/qQu0119B29TqlvNc3eaHCLvvXx+K2TP/9X7zwyRc9TmTQWlM8r54L0HwWF6dU9b+eWVcFOHFR+QxQhmONRGboJzClNMNY228z2P4ExQyH1uJfmQzzyBzSryUZzzhj6vL1u9XvAOFuEFHLJYsXFzC9JsdpLZiYLKH+HcMhABlMm18eEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gCoJ7lNZ16ANmJoEzXub9qTrBcen1lrpDjoNpXA4ZsM=; b=B6dak1BuqHIExXDhCTkY3oBWvqSoX9rS1Kz5FtgtGGJD5UVidDV6T4F0Tc1xjEaz1sUwCJtLE6tM8FE7LdvwuOeknbRdyKW0HqO1vZnGYnfbcD/G6c6V940Fds2eVXZHEn92peJ7HI7Yq+NxTLEq2D9BDpm4tnsjYyzFSRZfSS4= Received: from BLAP220CA0019.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::24) by CY5PR12MB6527.namprd12.prod.outlook.com (2603:10b6:930:30::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.27; Thu, 29 May 2025 07:00:32 +0000 Received: from BN3PEPF0000B373.namprd21.prod.outlook.com (2603:10b6:208:32c:cafe::2a) by BLAP220CA0019.outlook.office365.com (2603:10b6:208:32c::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8746.29 via Frontend Transport; Thu, 29 May 2025 07:00:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B373.mail.protection.outlook.com (10.167.243.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8813.0 via Frontend Transport; Thu, 29 May 2025 07:00:31 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 29 May 2025 02:00:30 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 29 May 2025 02:00:26 -0500 From: Shubhrajyoti Datta To: , , CC: , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , "Robert Richter" , Nipun Gupta , Nikhil Agarwal , Shubhrajyoti Datta Subject: [PATCH v7 2/5] cdx: Export Symbols for MCDI RPC and Initialization Date: Thu, 29 May 2025 12:30:14 +0530 Message-ID: <20250529070017.7288-3-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250529070017.7288-1-shubhrajyoti.datta@amd.com> References: <20250529070017.7288-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: shubhrajyoti.datta@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B373:EE_|CY5PR12MB6527:EE_ X-MS-Office365-Filtering-Correlation-Id: 7be74010-5d91-469c-2244-08dd9e7e80c6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XUOYYSIQdf9dFnKYdwu1J7RMfTuFQz02hOkGd17oWfWmJ5RVq36dz2s1y/Dn?= =?us-ascii?Q?RR/C5cW0sJdOeFs2da24OZnE1wxLjYcB5Bvhqjdek5eFDZS74lnKz5rqozt9?= =?us-ascii?Q?hwJEHBhsEIXxi0bDfoDT0OMUu0obkxGsspThldsk1MC4sM1BETLLDMDv8Nev?= =?us-ascii?Q?oN47YugJkw9wo2gjlqUaf/V1QJtGalVTK4PfTDM4q54lArocSEGTZZXoXxuF?= =?us-ascii?Q?2ZIfvv2kX8iH0xuouFn7ZNVciQLRw7MbUSvCqB5SrhpC3aVFkrh3uaJGVxlv?= =?us-ascii?Q?H5jEUT06QVqpFMHskRCXyK/TL5YxiFLHWw3D09Xxx2w5clO+xIU47TDl6e7j?= =?us-ascii?Q?TEl4UBwQsOy4K6ReCKq/SHr//txuZnMvIaMpk4L3LDBc/JCenXgMzwJ5VYSq?= =?us-ascii?Q?9QFM/IYGB2TazqiBbghg4GazPkV1UcIHiZ0acHhuKpnqxy2LZF3kNmvwMO4S?= =?us-ascii?Q?d+a9j4cMAq4uMKAQNKDQQ10ilrBXTF02t3MAlGI/d2K+U/VXy1SGxawr3nuV?= =?us-ascii?Q?rCz1jySrOnbI0AHqxGcfgXdzNTGYlZUCEQXbvtkFYgm2sPJ8gKd5pawY+4cb?= =?us-ascii?Q?PjVj2Lw0yS+4Y/TpUptGHGkq8/+kijnMdRIUXncoLbBRmsTNiBgFcM6zNyuZ?= =?us-ascii?Q?GUdZHWy1scjWfxgyfGg6KPi3bH/pfJ995VRUUT8cOwVBNUWOvzfDcYw1HIvw?= =?us-ascii?Q?ofhp+IlcNzft0ABaze3mRq5vKu/LGnuXIvWYO8iYK9t8G8D8FFTPJgIYl2oh?= =?us-ascii?Q?y7CjpP2R85X/Kdh8lYpdJUgytSKmMvC7ukRgOJxBVBLz8hAcflzFynXCeDXO?= =?us-ascii?Q?1eB4bu9OOFFkkGHDbvi2doPB9XHLXrjX2jxMLTQhR7luMxm7Gi0SPKN7cGpU?= =?us-ascii?Q?JxwSn5Rfaw5n+GTOVGfKaMgOFSzPKQKV1c2wk7SHlBTeG8fiSH4udqx3lVlp?= =?us-ascii?Q?7oKuXqws19GZnCa1QtUKDhw6wN16LaXRM/mBZmXQM6306zzuN84EfP6g1aGR?= =?us-ascii?Q?IhL2VF8zHbBD2eQwIW/ZYakpdhe+PBQDiMLlhjjKgMna2qEvowQxJhTOJd4l?= =?us-ascii?Q?tX4h5SGdXG9FSyoU4VLKA5PgUfaSOYASAyy+Ch6aEWbuESwFpNqHEHZRxnR6?= =?us-ascii?Q?iMk73ta7B9vx7d/gFOdxHtGYOkKsbNxT+bYIXRWeN4kXxJ6dFegL6ozBcfCE?= =?us-ascii?Q?wNr4wq5fvppp6tfezvy/7Svu1M8tn4ZIujGCkUq2JtxdnMppcj2T/BMhZBxd?= =?us-ascii?Q?V/EVlbmxu4vaaOOCB3FGjp7wutYyWqgOaqUo0WmSB6edua1kn4VPdmJyh0bJ?= =?us-ascii?Q?+dsaEjvk6+W4bVF1tIQdDFhROiEMjuB0T5zVHxcNB6ApFktPK7kQCe1mkZTo?= =?us-ascii?Q?qIaamfxX+fK92YPgKBYNar8Sl0+/EKQCi8OsnkmTgP9EOlHW7zk2QdnpJK1+?= =?us-ascii?Q?YreBazh9Hef3AfCdPZY7HdVh8Q05EoHYt3ofLTazBXYEmm8EYZw4bEYe7qtY?= =?us-ascii?Q?AaxK0j0Sh8CnVt6S8er6vheh/gwXUwPnFhMl?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2025 07:00:31.9591 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7be74010-5d91-469c-2244-08dd9e7e80c6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B373.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6527 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The cdx_mcdi_init, cdx_mcdi_process_cmd, and cdx_mcdi_rpc functions are needed by VersalNET EDAC modules that interact with the MCDI (Management Controller Direct Interface) framework. These functions facilitate communication between different hardware components by enabling command execution and status management. Signed-off-by: Shubhrajyoti Datta Acked-by: Michal Simek --- Changes in v7: - Add the kernel doc description - Add the prototype from first patch to here Changes in v6: - Update commit description Changes in v2: - Export the symbols for module compilation drivers/cdx/controller/mcdi.c | 29 +++++++++++++++++++++++++++++ include/linux/cdx/mcdi.h | 6 ++++++ 2 files changed, 35 insertions(+) diff --git a/drivers/cdx/controller/mcdi.c b/drivers/cdx/controller/mcdi.c index e760f8d347cc..f3cca4c884ff 100644 --- a/drivers/cdx/controller/mcdi.c +++ b/drivers/cdx/controller/mcdi.c @@ -99,6 +99,19 @@ static unsigned long cdx_mcdi_rpc_timeout(struct cdx_mcd= i *cdx, unsigned int cmd return cdx->mcdi_ops->mcdi_rpc_timeout(cdx, cmd); } =20 +/** + * cdx_mcdi_init - Initialize MCDI (Management Controller Driver Interface= ) state + * @cdx: NIC through which to issue the command + * + * This function allocates and initializes internal MCDI structures and re= sources + * for the CDX device, including the workqueue, locking primitives, and co= mmand + * tracking mechanisms. It sets the initial operating mode and prepares th= e device + * for MCDI operations. + * + * Return: + * * 0 - on success + * * -ENOMEM - if memory allocation or workqueue creation fails + */ int cdx_mcdi_init(struct cdx_mcdi *cdx) { struct cdx_mcdi_iface *mcdi; @@ -128,6 +141,7 @@ int cdx_mcdi_init(struct cdx_mcdi *cdx) fail: return rc; } +EXPORT_SYMBOL_GPL(cdx_mcdi_init); =20 void cdx_mcdi_finish(struct cdx_mcdi *cdx) { @@ -553,6 +567,19 @@ static void cdx_mcdi_start_or_queue(struct cdx_mcdi_if= ace *mcdi, cdx_mcdi_cmd_start_or_queue(mcdi, cmd); } =20 +/** + * cdx_mcdi_process_cmd - Process an incoming MCDI response + * @cdx: NIC through which to issue the command + * @outbuf: Pointer to the response buffer received from the management c= ontroller + * @len: Length of the response buffer in bytes + * + * This function handles a response from the management controller. It loc= ates the + * corresponding command using the sequence number embedded in the header, + * completes the command if it is still pending, and initiates any necessa= ry cleanup. + * + * The function assumes that the response buffer is well-formed and at lea= st one + * dword in size. + */ void cdx_mcdi_process_cmd(struct cdx_mcdi *cdx, struct cdx_dword *outbuf, = int len) { struct cdx_mcdi_iface *mcdi; @@ -590,6 +617,7 @@ void cdx_mcdi_process_cmd(struct cdx_mcdi *cdx, struct = cdx_dword *outbuf, int le =20 cdx_mcdi_process_cleanup_list(mcdi->cdx, &cleanup_list); } +EXPORT_SYMBOL_GPL(cdx_mcdi_process_cmd); =20 static void cdx_mcdi_cmd_work(struct work_struct *context) { @@ -757,6 +785,7 @@ int cdx_mcdi_rpc(struct cdx_mcdi *cdx, unsigned int cmd, return cdx_mcdi_rpc_sync(cdx, cmd, inbuf, inlen, outbuf, outlen, outlen_actual, false); } +EXPORT_SYMBOL_GPL(cdx_mcdi_rpc); =20 /** * cdx_mcdi_rpc_async - Schedule an MCDI command to run asynchronously diff --git a/include/linux/cdx/mcdi.h b/include/linux/cdx/mcdi.h index 46e3f63b062a..1344119e9a2c 100644 --- a/include/linux/cdx/mcdi.h +++ b/include/linux/cdx/mcdi.h @@ -169,6 +169,12 @@ struct cdx_mcdi_data { u32 fn_flags; }; =20 +int cdx_mcdi_init(struct cdx_mcdi *cdx); +void cdx_mcdi_process_cmd(struct cdx_mcdi *cdx, struct cdx_dword *outbuf, = int len); +int cdx_mcdi_rpc(struct cdx_mcdi *cdx, unsigned int cmd, + const struct cdx_dword *inbuf, size_t inlen, + struct cdx_dword *outbuf, size_t outlen, size_t *outlen_actual); + /* * We expect that 16- and 32-bit fields in MCDI requests and responses * are appropriately aligned, but 64-bit fields are only --=20 2.34.1 From nobody Tue Dec 16 14:56:03 2025 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2052.outbound.protection.outlook.com [40.107.101.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D7DB256C88; Thu, 29 May 2025 07:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.101.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502047; cv=fail; b=MowoEbV+KmtJKEPfZIDKcEO1Bz+uBHpoA2kv+aElhHVLuZeLJHy52lg6CkWgmwyrl+l0cNXEAS6eS5GYXw2JrQC/izlkFRjtyjpbSpYav8pByv65/d8SON96STy/kds4tvpxtr6WZjG70oGpm7VjQp6YiZEs68iRGI459iFKUQU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502047; c=relaxed/simple; bh=Vez8BzG1oP9sCigc5wncTG4q6hxQm+ACqOBwO7N4lIc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NaODfhBb/bLpLwCZ8eb2QJhbPVJ0OuVwKbfl2pTatBPJrPx7kX8cHhMrrgupMOUJil+ulCIBPeGnCRuRjo5a4Zsf+qyy6yLwMVmkz26/V+HhiWM4fwGK6B0656MQPxCBVTngF/81+gCrdhhP0CsauQJalTJBBRycgPpRKD75mVM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=IMJs8JTL; arc=fail smtp.client-ip=40.107.101.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="IMJs8JTL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nnL+rbbYSoF+V1x9p5fdJhLiihJpCOdAjDpdITIUf2FMFCyWNl1GbfKCLYB834ESJu0CKMaACGeZM4MZRrzpLhZIztSDga1BG+vFbfnlL/7ghnuAeL9OLyLtVyHJuc7GC6y3V3gTxQbVhpAYOtr09D/GOkf02w2zz8R/s0r5GZj3xnfqtzZ79kAL99AflTjz8ekV9Xp/5/jfUyT0qMlGKrvjGmi0xzuQbGjHLhjNFzOr3HW8j93vU1svvmeouS4y+bPK+DI/JIHLGmti7F1CachWRXoZMf1s6h7fvVOEoeGahHgXg4PX49PRsox1mhbtdhSFbbytHsLC/4loG5j+dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HD9kjndkPJXMA57cjkQvMqJYkvfQRX1CyhBx8CDcBIM=; b=X9UNxwc8OBJb2AjnKJfjAdCXP5FKbGtm7j4JH8PWoLYl0AQONWxEziG1Qew1iyaJpw6rPXk+BYa0+EQfVjVWWjQiNNWoygyf/4kf8QtKXITIeknSRRmBwxd6UX21kDCjYxvlINl+2D7CuBEcn011LjUtAkujZQDNvIoRv3DXjtTV1axhtHkveHy7CsDYqCiB/BeXkiyusjzfUbSlLXj4aCg8rIwWeGZem5wNwgt+Lh9Pvg5ziOs0tdeJNDdDEXOPnBCuHMiI51aDq85N0F0RasUZ8dz2P8R+jXhbKLEr/GIt6rEmT0zttA50bPmzd4+6OKYVn6879aWvmyN0Z/F5AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HD9kjndkPJXMA57cjkQvMqJYkvfQRX1CyhBx8CDcBIM=; b=IMJs8JTLGJ+rCehoSgwWE28oGZnYZrue0l3qxxf8/c9lnJSqwyzLuj3BO6dOfdjNtHOizDZRbkGCmQSLDRKtgNjVI1x4s5zLoJQk4k9uk94G31EDz2g1haNbUJBkPbg8/ekGgCnix9RHFJmU3vuuuWp7lwqxBtaAL7Ce/2U42y8= Received: from BN9PR03CA0937.namprd03.prod.outlook.com (2603:10b6:408:108::12) by CH1PR12MB9647.namprd12.prod.outlook.com (2603:10b6:610:2b0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.26; Thu, 29 May 2025 07:00:37 +0000 Received: from BN2PEPF00004FBF.namprd04.prod.outlook.com (2603:10b6:408:108:cafe::b1) by BN9PR03CA0937.outlook.office365.com (2603:10b6:408:108::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8746.27 via Frontend Transport; Thu, 29 May 2025 07:00:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by BN2PEPF00004FBF.mail.protection.outlook.com (10.167.243.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Thu, 29 May 2025 07:00:36 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 29 May 2025 02:00:36 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 29 May 2025 02:00:34 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 29 May 2025 02:00:30 -0500 From: Shubhrajyoti Datta To: , , CC: , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , "Robert Richter" , Nipun Gupta , Nikhil Agarwal , Shubhrajyoti Datta Subject: [PATCH v7 3/5] ras: Export log_non_standard_event for External Usage Date: Thu, 29 May 2025 12:30:15 +0530 Message-ID: <20250529070017.7288-4-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250529070017.7288-1-shubhrajyoti.datta@amd.com> References: <20250529070017.7288-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Received-SPF: None (SATLEXMB05.amd.com: shubhrajyoti.datta@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FBF:EE_|CH1PR12MB9647:EE_ X-MS-Office365-Filtering-Correlation-Id: c1fc6485-1c3b-44e0-0884-08dd9e7e83bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ulS9vSEmupb86u5IcEFCOymNc5ShciiKu72u/EvYUWI5ZMw4EKoUpdCg+UHw?= =?us-ascii?Q?wOXJfHBLeDz3uU+nFfa+Mr+mHeD03YKrah+aEr+HrBsJRTcjvBjk1MZrfovq?= =?us-ascii?Q?f0H5dey0UX4PtTSk2qzeDoX/WQ08SPagePs2zryOltZLtAJNA3H+XHfdkiR9?= =?us-ascii?Q?JfALDX1KzdruZVlLtX9OyvzGEhV5gwbSF5ONvwc1iSQCjE2ohMqgiAtV/p73?= =?us-ascii?Q?eppuxyU8UpQJ1WD4OZDXpjJNWBBitSRPJB6w7fhQT6RtspQ3h2hs3mNXFnwd?= =?us-ascii?Q?6Ici2Mb20OuGhtzNg6qb4E07AEGVHS3RcK7P0J588lNI5fU1k+dbRbH4vROk?= =?us-ascii?Q?EAtggd0eD+TDama4KwVmTo7u1RB/eU5ChmBUstL83aH0HEfJkDn+07adrAMt?= =?us-ascii?Q?HElvZb09MfcGSakrWTBwvIwpr0KBHw+TDBn60rYtPz/7Fk9ATQfvrSr+Tgap?= =?us-ascii?Q?yjToI25FK4j/ArePfuz7Ovb01unqMid5yk8EiAD9Ek/92RtxQvTuVawGd6y+?= =?us-ascii?Q?pGZsv0jjfBB84rsw7uAckRPHXDAUVcHn3fFZujvjUNu6F99Yl00LYcGsvSK4?= =?us-ascii?Q?mllP67jcpjV2QSswYo29OLrq1QbBbTZEGYrAT6fXkFgQ4WzLKcebHV57q7PS?= =?us-ascii?Q?iev5Arp9zzb84Red23TvvSZq9uWMPQnKVotQi4ykjo3swIsWvDM5qABoYhRk?= =?us-ascii?Q?hHAeWJmsUf9i+v1n/vaBoLh8SSQG/HBZCy5LJhH7II/6osS1+a0GiVqE27XF?= =?us-ascii?Q?6xLZKNHuAqNhsJq5c2QK0cK4f77ci21D3qdO2HBoMp9TyAw1Z77r90c6PK+V?= =?us-ascii?Q?9yWwcdFjs+mU2320iFw9RSGokwCt7P8rm6Bpy4OohQg8Q3Vksbyij3pBiC8x?= =?us-ascii?Q?NLs0NtPs2CUn4Ng4Ng+BedD7YJsjPAaWejECmHmApozpCajZLn7Cshma6Sth?= =?us-ascii?Q?AQ34A2cKQPN2EeTTDmKUv55hOcYVMkj5nEnThccuhfm1Lm0AF4DnCjNnacuh?= =?us-ascii?Q?u3/NfDhDuTH0OW6XQvQERCLYm4JCph++B7SzSntFr/hr8PVHcjRsv7Ms0tpS?= =?us-ascii?Q?+U/3W0puk6U3MgDIM76YQp8GxMO/6/a/jtZk4PD1SitG7vCE6AaE6FXa3yV4?= =?us-ascii?Q?EQaig1gINgb8CiCF0ny0njbXs2kkXcLuKGo7HfjsLOYr64gv7XtgfrV3Po+z?= =?us-ascii?Q?9rDleur8/E4PCYxqdYtY3xzNaXubgMDmv7Hd0KcZrUfdypV81qvDe4vxZeAz?= =?us-ascii?Q?7ErpKWYR+UQPwNaJG8USu5V/iBB/o6Eosjq7ZRLCz3Xn7hdWQgecq5nPNV1Y?= =?us-ascii?Q?QdMaPot16AtRRw5KSoAvHNJAFmNdI30uO5NJYVIFKRwWrMzPJp3Sf99ywm5Z?= =?us-ascii?Q?jmaSQHnlG8D5IlWgKjXW0Hr/j0dfAfd69Pn5AszqYn6FNWew8wOtIUvdbceJ?= =?us-ascii?Q?n+KRQ28+FO/woAl+Up6VpxncdekS/91YJY27ba0xHJNc9DANTyLV7yNpHVQu?= =?us-ascii?Q?VANSFRMiORXzd41T2bsCN5EwEEJeUqiNxuHj?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2025 07:00:36.9301 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1fc6485-1c3b-44e0-0884-08dd9e7e83bd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FBF.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PR12MB9647 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function log_non_standard_event is responsible for logging platform-specific or vendor-defined RAS (Reliability, Availability, and Serviceability) events. Currently, this function is only available within the RAS subsystem, preventing external modules from leveraging its capabilities. log_non_standard_event is exported so that external drivers like VersalNet EDAC can log non-standard RAS events. Signed-off-by: Shubhrajyoti Datta Acked-by: Michal Simek --- (no changes since v6) Changes in v6: - Update the commit message. Changes in v2: - New patch addition drivers/ras/ras.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c index a6e4792a1b2e..ac0e132ccc3e 100644 --- a/drivers/ras/ras.c +++ b/drivers/ras/ras.c @@ -51,6 +51,7 @@ void log_non_standard_event(const guid_t *sec_type, const= guid_t *fru_id, { trace_non_standard_event(sec_type, fru_id, fru_text, sev, err, len); } +EXPORT_SYMBOL_GPL(log_non_standard_event); =20 void log_arm_hw_error(struct cper_sec_proc_arm *err) { --=20 2.34.1 From nobody Tue Dec 16 14:56:03 2025 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2088.outbound.protection.outlook.com [40.107.94.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0330F256C7F; Thu, 29 May 2025 07:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502046; cv=fail; b=u6HgJw/QM/4XKm/lbpRiLKg5cEG6OwaDATKBrp5RSfk1+MaIm0UeL/xcGCR8QotxXt7gkgzvQkKlH+rzhcibDUsPLSFmxz3t38dJ/9Yue//tg8Idg6bG4AQx/zQxV0w3fu9mZd81owKCeLaARB74/MZeTCoPoDhdeqYuscwHxgE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502046; c=relaxed/simple; bh=HaEkdTDYVHNFACbhWiJbM3ysv/aGx34TO6/i22ObuMM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Gze/Q0kQUpllQwY0vftcZV+oNWWAFyA/7AVOiX4iKIEtCTrVexrDbxMIFmTNkvNyZDxX8aeTvmdjQf3MER6QydGrN5v2g09DfSQGy+1nkMO2GvfwK77OIcdbo6gHedGAajQukqQQK0C53wxaKMeQKTmWv0OxeXZ2oCBzE62q+xw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=IH2PV6Ej; arc=fail smtp.client-ip=40.107.94.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="IH2PV6Ej" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=spoa/KIJxGQak1SMURFmdfNKEmj4okbAWASfqii3PZWLLWMxbJnOex7Z//C8zVsQfR7rs9mdta2G2KyoYns6b++lazYWk5IMRyssRSkbSzKB+yRU5WtnxbDL9fELZYYI8Tvwkk9H1CulxoUHhvgYHTco+ZbsJoE+GYf/ShlL9A1TbEqE+yszbmrTRMlLdeNYF5LTfAvHrGVI9UBT/0nxPDusUzCXjFx8SB4LrlRNhjx+0tEp+f7vESuHjvum9EiPCQjBwf5RZGhiLy353Q1BdxWWdQI7U4+XWUvNHpCXChW+6DOhUYI3tJEQMpWPi+eOnwtwIndoHNoBjPSsO++AGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0etD3lGWdGpX1h/vU6xfGdw1xOioXXe0NpB0yv+UuJI=; b=rz/WBtF95Ck57MSLO48yYWd+XdwD5BBqWjZFOW2yTEg1EVYORkgJ8es07nCFHEHaBmjBfF27yOCf/3ymOZlOBPi1JhDNtXdLqSSOxJXHlHY/6n2jCvHZQYRGiOF3q8/IK0If4ikEO4YK+QDdw+DGdnr8vAcpUff9iMrroWRbExXH35CYFXBrNZk0CxEBZCbvqdY2dtxsazS6Kq4pg6gmpb/ghzsOQjVwgC7r10QoyCsNegzv0TC+ThXob6UYWNb9wAdM8b+SjwvosRUs4BPdR0hQzRes7ne1G1QK7A8BBZjn5NYc02LzIMWcXQruRLixp52AULPQsbRE2WSJJGT6MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0etD3lGWdGpX1h/vU6xfGdw1xOioXXe0NpB0yv+UuJI=; b=IH2PV6Ejs8WBbZYjrEBhfKs0HM9as74OTrC/Hfx1SpaApfK0IECfWnPPNIFwJO7eme9/7NYSTPNM6/lEslqt4ViKhtrA8VYBQhjE5VnZunv+4j+X/Nckii2E48XdhXT7ZISWpAPFgiFnEBarbAqhSd/uGWCs8e7DSYuONyFwr9Y= Received: from BN9PR03CA0931.namprd03.prod.outlook.com (2603:10b6:408:108::6) by SA0PR12MB4496.namprd12.prod.outlook.com (2603:10b6:806:9b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.31; Thu, 29 May 2025 07:00:40 +0000 Received: from BN2PEPF00004FBF.namprd04.prod.outlook.com (2603:10b6:408:108:cafe::6d) by BN9PR03CA0931.outlook.office365.com (2603:10b6:408:108::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8746.27 via Frontend Transport; Thu, 29 May 2025 07:00:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by BN2PEPF00004FBF.mail.protection.outlook.com (10.167.243.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Thu, 29 May 2025 07:00:40 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 29 May 2025 02:00:39 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 29 May 2025 02:00:38 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 29 May 2025 02:00:34 -0500 From: Shubhrajyoti Datta To: , , CC: , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , "Robert Richter" , Nipun Gupta , Nikhil Agarwal , Shubhrajyoti Datta Subject: [PATCH v7 4/5] dt-bindings: memory-controllers: Add support for Versal NET EDAC Date: Thu, 29 May 2025 12:30:16 +0530 Message-ID: <20250529070017.7288-5-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250529070017.7288-1-shubhrajyoti.datta@amd.com> References: <20250529070017.7288-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Received-SPF: None (SATLEXMB05.amd.com: shubhrajyoti.datta@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FBF:EE_|SA0PR12MB4496:EE_ X-MS-Office365-Filtering-Correlation-Id: ffe86cf1-40b9-4df8-ab06-08dd9e7e85ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700013|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WW0QlvR7enudgktbUOhX2Dthbe4h6Lg08kedazag73QFs3h4Zh8flt+ip3T3?= =?us-ascii?Q?WdNh1Xfgj7P7mK3iCWWCtXBEbKivcS/gKGVRujR/sV4Eic9STGGdH+IqONd7?= =?us-ascii?Q?wsHkpHyFKKt/oRPb4rHWXfahW3fpLlV/O4J7DPszAXhfLNdyGdCg/jXbpK4F?= =?us-ascii?Q?CCrUqR2QXKOvOhhnzQ/BwVL9YzzMue47z/u9tsLZBwdTYVqiknSK5FsIdXC/?= =?us-ascii?Q?HEAHEtiOJ8eTWE6Zx8tvtUQLPi9bzz/bXYQBqUUEANqjrm3MX05cAlgIcNgI?= =?us-ascii?Q?cWS0SeXaDCuU4alt7jGWWAX1avJGnlcS32QxyiL/grnyZZ1hGuzSv6NfIPLE?= =?us-ascii?Q?EsFeMkyJxQ8E4LlC+ipXozMxza3fIlvjEZc2+tfdUF6intGs1bst5n1r47GN?= =?us-ascii?Q?b5z0B3r4l/ZYX+JSlPLr62VP0sj8Ggp20quMYNPDvCCRSqzjEOr9t/IUXvCc?= =?us-ascii?Q?K5VGPYCcZ8GRN1pC+1A8kSLVjtF7xncDzADWRYKFDpYCepTs8tfFT6BsbBqk?= =?us-ascii?Q?cWW43fXNQqVgMR/DTD00BuHvI/mBz73A/WBVfFPeYMaabW/WGSPBLhVxoxug?= =?us-ascii?Q?m3T4qTuILoJ+MQYts7vMe8sL1yZ+HsXXFDXb12gL7M7cmdmKtF5Cn67wIxlh?= =?us-ascii?Q?FENkoJbBIJ+7T1KT7fjfN64OAP3prclhQPZpVUSqhNIz1QHa5KhXKrvwiIX4?= =?us-ascii?Q?Wj5f2Y6InPBfyhitumYPPl5PKxotx6+enBBVgjYHkd5MN0G4dctAtPAeJXv4?= =?us-ascii?Q?eN3kgeAlqenQOydhdMdq/Vgf3dM/vGQ4F2dWnaxZDczrW2RcwcY71rqK9hjL?= =?us-ascii?Q?xVVPoBw5QdWt902gegmyXXwe4ApT8+/kAKEfJFIrrLtBeEz6Yg3G37nNLqB/?= =?us-ascii?Q?2HEyCXqCTWr/B60umn8dfHFZXxLs0JtCwvkpfXB94OCyfhtRWHhDQ8W7ciiK?= =?us-ascii?Q?wxRVeBgTRqeArlnNuEkBZlEU3VFCb94K5wnZwgEm3awCGdNi0P7Z0EkzOkT6?= =?us-ascii?Q?hkQwID0aKq3uCteVAqG0iK9O80AMklkfRvt2cayRZQo4g6iNrz0QMRUQ3hQ2?= =?us-ascii?Q?j1pLo+EQprzZ5+K9CYOPP8H1IM5OwQ9uKDEwgGpSsge02/fwOdZZGTpItoWo?= =?us-ascii?Q?IL6hwzQRKmc9FpqLxSaiqflY8Z73lFprRKk/jxsPVa/BTgxC/s1Vue0JIcKn?= =?us-ascii?Q?jCEz/hGvfxaRafUSU3qghqLmtSFfi0m/syeOfk4/9BhrjDy64fUUAXVW+K8l?= =?us-ascii?Q?x8tK66oDYroDQwJp2CH3n6121dHGL4fx859cPrFRZ6phzPfKC+Dqkb2Z0x9j?= =?us-ascii?Q?Jbp0qJg0rTpcncZvNiUjbeDjR8f74k2pG7VN2i9AbcSftEECUuZbkajjh/E5?= =?us-ascii?Q?CnZUiQtqhV1wUPQZQclGFQpDKGcCOzf9EoJoCOp6e1yPPvpvt32yKrhMdV2v?= =?us-ascii?Q?I/ZULB0ByqPOKg+qBlcaZZUYYNloLyCd0vXPL3V3tOTM6qsKYGzOnQ=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700013)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2025 07:00:40.1801 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ffe86cf1-40b9-4df8-ab06-08dd9e7e85ac X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FBF.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4496 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add device tree bindings for AMD Versal NET EDAC for DDR controller. Signed-off-by: Shubhrajyoti Datta Reviewed-by: Krzysztof Kozlowski Acked-by: Michal Simek --- Changes in v7: - Add the reviewed by tag Changes in v6: - update to the chip name as xlnx,versal-net - Correct indentation Changes in v5: - Update the binding Changes in v4: - Update the compatible - align the example - Enhance the description for rproc Changes in v2: - rename EDAC to memory controller - update the compatible name - Add remote proc handle - Read the data width from the registers - Remove the dwidth, rank and channel number the same is read from the RpMsg. .../xlnx,versal-net-ddrmc5.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/memory-controllers/xl= nx,versal-net-ddrmc5.yaml diff --git a/Documentation/devicetree/bindings/memory-controllers/xlnx,vers= al-net-ddrmc5.yaml b/Documentation/devicetree/bindings/memory-controllers/x= lnx,versal-net-ddrmc5.yaml new file mode 100644 index 000000000000..479288567d0b --- /dev/null +++ b/Documentation/devicetree/bindings/memory-controllers/xlnx,versal-net-= ddrmc5.yaml @@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/memory-controllers/xlnx,versal-net-ddrm= c5.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xilinx Versal NET Memory Controller + +maintainers: + - Shubhrajyoti Datta + +description: + The integrated DDR Memory Controllers (DDRMCs) support both DDR5 and LPD= DR5 + compact and extended memory interfaces. Versal NET DDR memory controller + has an optional ECC support which correct single bit ECC errors and dete= ct + double bit ECC errors. It also has support for reporting other errors li= ke + MMCM (Mixed-Mode Clock Manager) errors and General software errors. + +properties: + compatible: + const: xlnx,versal-net-ddrmc5 + + amd,rproc: + $ref: /schemas/types.yaml#/definitions/phandle + description: + phandle to the remoteproc_r5 rproc node using which APU interacts + with remote processor. APU primarily communicates with the RPU for + accessing the DDRMC address space and getting error notification. + +required: + - compatible + - amd,rproc + +additionalProperties: false + +examples: + - | + memory-controller { + compatible =3D "xlnx,versal-net-ddrmc5"; + amd,rproc =3D <&remoteproc_r5>; + }; --=20 2.34.1 From nobody Tue Dec 16 14:56:03 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2052.outbound.protection.outlook.com [40.107.92.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB79124E019; Thu, 29 May 2025 07:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502069; cv=fail; b=bRUe9ttYJI/0oXdGu+ujIfZeAAN72l7MEjaS6w1SuZG3p26yxjpEwnWRM19avL8USYeP1ndrtQoQhTUhjFCChogZOjbB1XjAg1n9NykggC7O5ukTsW6NH/1t1zjz+YeiwZqIKN7bgx9QIeXxK9LbjQuHW8zeNTSEwJEOc9N4t2g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748502069; c=relaxed/simple; bh=hkEaPO1plVlp6f5VS+52MJBeBlmB2/Ct6a3Sam6xifA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jExLGndCkPgtFvf4s0CGtsdRL0PBCbCpqLog6lFZ95S/YkntVkRQKOump86OH579WVU8HO5myDo+KyEm477Ou82M6/vLhT+ob8Wd5GFY799uJ2uLULcsGakrtgQlww3vXSOQRcZ+nuIhA4HU7nSYDltM598PcrrVMWCXfCRYmDM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=0TryVWRe; arc=fail smtp.client-ip=40.107.92.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="0TryVWRe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MXF9pfG9AF/3MVfAW61/Ys7kZ9k8GxDy1f96XB52LUjquP2kBKWjKtvLYR1rkVHKblXWou2DLKZ8Zc4+WnIzy5rtHqXEfdGs/k1taYpoRyIoIyUOwQfY6s1U19twJhnwbk8D7OJcF3mTzCWZ4/RCze9eZPYnLkxi6mCm5wwYY2+5FOJm6aKyDof04/bd5KelMY2wlSR045/+79K8toTzAWbPCNw/+CowiPJfgN53KABbDqsWzAqDL/IV20lWKrJ1aNpqMGkSCrhF8gc/7rcb60n4tEJe7z5bX9YudbFh49csg2RSMJqPr3t6HcR/l3JdRqcq61ClK3P7lX5+4IY0BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HcXeyVkoNuqdHm3rECTcnt4oMrnDJ0AqQKhIzOPsPKg=; b=R9orV6rUJQv+YmmkJTG14zaV/uS/w0GK3ctclVYcYHqkZbQLtbBpEg0jF4wzL5+p+mc8HFwhb41OGNPKHl8sCSCn2+VBYEsQTFKHkaKrnWSyf+ErBOtEusfSrnEMj0BkdPc350OMpOAI3uqYVkMW8YS898QrI5uZ4NmsbPlsjTq4u3KIhb6Nlr/iXOqml1fbIAlzHQ0l7FI3PhQoHkz1prMrhvl9yAPNj+UchFQvl0UZX7QKp4bLFD8kGu+dOuex9kTSAwPGdrn9f/iO8tKbg+PUIWucsZeohcTSvIKcCKZs3Ysz++nNDg5KTIvCa/EVJlet40I5zCS8JPDXZ9P/pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HcXeyVkoNuqdHm3rECTcnt4oMrnDJ0AqQKhIzOPsPKg=; b=0TryVWReU5O/yL/9Rndnb7tbIxo3eiZXRKDQUuDfnxzrLBaPZVbh7DVMUIeD14s5o5T22Lz7NHI5GiQ4BPLOYwj9qi+nI44QNCvKZqikp6m8vdTvyJuzy2h9XyvB1euf4wxUdw2Znmr7WjGShTaZltX4TlBQj5m9jhK8tddnYI0= Received: from PH2PEPF00003857.namprd17.prod.outlook.com (2603:10b6:518:1::79) by CY8PR12MB8195.namprd12.prod.outlook.com (2603:10b6:930:77::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.27; Thu, 29 May 2025 07:00:46 +0000 Received: from CO1PEPF000044FA.namprd21.prod.outlook.com (2a01:111:f403:c91d::4) by PH2PEPF00003857.outlook.office365.com (2603:1036:903:48::3) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8699.32 via Frontend Transport; Thu, 29 May 2025 07:00:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044FA.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8813.0 via Frontend Transport; Thu, 29 May 2025 07:00:44 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 29 May 2025 02:00:44 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 29 May 2025 02:00:42 -0500 Received: from xhdshubhraj40.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 29 May 2025 02:00:38 -0500 From: Shubhrajyoti Datta To: , , CC: , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , "Robert Richter" , Nipun Gupta , Nikhil Agarwal , Shubhrajyoti Datta Subject: [PATCH v7 5/5] EDAC/VersalNET: Add support for error notification Date: Thu, 29 May 2025 12:30:17 +0530 Message-ID: <20250529070017.7288-6-shubhrajyoti.datta@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250529070017.7288-1-shubhrajyoti.datta@amd.com> References: <20250529070017.7288-1-shubhrajyoti.datta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Received-SPF: None (SATLEXMB05.amd.com: shubhrajyoti.datta@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044FA:EE_|CY8PR12MB8195:EE_ X-MS-Office365-Filtering-Correlation-Id: 83bcf36e-d536-481d-7ceb-08dd9e7e8896 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8zo09n6KG5+gxg9Y1Uwe8n2fnKXYCkuY68RedCaI03+Qw57lNjs28uRkNCbu?= =?us-ascii?Q?Y9gBZebaRg4kQEqHkgTkZ3L0C2RrBGN0QNoeo1pnhITyxWkQqUKx1jerMmQn?= =?us-ascii?Q?Bem++NROfS2QY14Mw+FgMpjwxrp3LKKhzNolVB0AB9hCuA1qRtoKvz2Ij609?= =?us-ascii?Q?rxIluJF+MUUy9i6G59RE1uDwrioqtv+rdUcNGV3g/nb8JuyX9sq42r/ROSPw?= =?us-ascii?Q?XRj3HhSk4S+VhlrL9SbY1AwFVlCm7Mue6sVUEMgR3ot/FQO0waT0j2mriK5c?= =?us-ascii?Q?ETZRSDkjOUw/z64V+QWsA64OL9P7B3fZhQbECLMklVP26avdwUGxDZcEP2NW?= =?us-ascii?Q?DhwZIxLyjs/fyUxXW5K14aNcZ7+d3BG284JNl++iXIT/2qc8eQ1qIY6zdOJc?= =?us-ascii?Q?n24WEBhUDyYqQTlJtXu49F1LdoCXwQREAuU1XIoxxjmi/fwMXCbMRCk0Kyd1?= =?us-ascii?Q?1YymHMrKNbWZnfDwnUb6mcEmblGDsy0rxNW4qe/j4zP/o004v9jTum9dcpsg?= =?us-ascii?Q?w+hab93QJ/vYoWvpT3VzTMBpoyzzwk4IFSEbrFOaY7gu3fYqTteJSnrRGL9Y?= =?us-ascii?Q?kOEQ5r8GkLEomOe2PfNiedDoV5j7skGr4a0hcpKfAaf83drZ3oHu1fHQHL8l?= =?us-ascii?Q?vHXENGQTXFovnP2DfJlLNS7nYISdchFf9hMIWp/J/G7Gkq4L9xXvzENMx3R4?= =?us-ascii?Q?KE0Sr9Ya7YN1UwwumSQe9bi3vr56mMODZpHP/LqNomcNEfvWfDxpawS6qU5L?= =?us-ascii?Q?VuPYqgy1t34TbTk0Ef4sbcn7oyB9/u+00MALBNcr+hfKedOb/x4x1d6k1SgR?= =?us-ascii?Q?lbuOVIPoPY5kVoaGYbH8dnZ5FZGaF/nLB5+GbvrtJktUZkZYLc2Nxh905HAu?= =?us-ascii?Q?vlQOWfs76XNb9EdKZOU3cSNJK0QDE+t16lDvTq0ezl/VM8bzbJc8YVTyzHme?= =?us-ascii?Q?20/TJgMmYQ1EQtOHCgVlqoguX9hgFQ8LKyDf/jPJjX5d45WbqVjVQXoVXZZw?= =?us-ascii?Q?w/Qoy7LfXcwyWKqx5ojwuW+gfkKB8aPtXVKxoZbM3+QlWgQRaiOFM67WDxk9?= =?us-ascii?Q?ayvOlNS60HRANRNFjqaEJcomXk7p9bIgGoQwkpq4BMnWRUZPPCfhAUHoUEJl?= =?us-ascii?Q?mwBSqcXu7qbR9cPExTupDO3Nveppz3vets6ZZitk3L+SDPDFChzjBBtklm1y?= =?us-ascii?Q?jCGasQApCCAMQNbZQHDvExv61ps0bFIge9wodya01lGrtVuom+AtrGKGksw7?= =?us-ascii?Q?B1lidohpqROD7xUQuLm/tdLD4EQ0hfff/sMXMHazvqa+WwA8Yb+LV0f22/b+?= =?us-ascii?Q?oBr0xyBstQAlSPX6VhPKJmDmen8GO/8jNGB3vIp0HtSefbtHg8B6KfUWyUvd?= =?us-ascii?Q?DV8n/l/ov5dShYkHKOS4Nypt/MDyzGmK/oCu1brmlOg+S8fDwpKLSzo9xbjZ?= =?us-ascii?Q?AYqHuP+yJ9NggLtgHTyrl+g2mhkiE/Bvfq65nt9sJVa4/66AdluJBILJYJL4?= =?us-ascii?Q?Jj6+3IYy1A9oKpFVyQXnZV2PhK9oAsBhz4Bb?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2025 07:00:44.9641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83bcf36e-d536-481d-7ceb-08dd9e7e8896 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044FA.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8195 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hardware errors can corrupt the RAM or other system components, without detection it can lead to crashes and system failure, this driver helps in reporting of errors to user space, triggering corrective actions. Add support for single bit error correction, double bit error detection on AMD Versal NET DDR memory controller and other system errors from various IP subsystems (e.g., RPU, NOCs, HNICX, PL) reporting. The Versal NET EDAC listens to the notifications from NMC(Network management controller) on RPMsg (Remote Processor Messaging). The channel used for communicating to RPMsg is named "error_edac". Upon receiving the notification the Versal NET edac driver sends a RAS((Reliability, Availability, and Serviceability) event trace. This aids the user space application to decide on the corrective action. For reporting events driver registers to the RAS framework specifically: Memory errors are reported through the Memory Controller (MC) events. Non-memory errors are reported using non-standard RAS events. Signed-off-by: Shubhrajyoti Datta Acked-by: Michal Simek --- Changes in v7: - Update the header paths - merge edac_cdx_pcol.h Changes in v6: - Update to xlnx,versal-net-ddrmc5 - Update the kconfig message - Make the messages uniform - Add some more supported events - rename regval to reglo - combine/ reformat functions - remove trailing comments - Remove unneeded comments - make the amd_mcdi function void - rename versalnet_rpmsg_edac to versalnet_edac - Remove the column bit and use them directly - Update the comments - Update the mod_name to versalnet_edac - remove the global priv col and rows - rename edac_priv to mc_priv - Update the comment description for dwidth - Remove error_id enum - rename the variable par to parity - make get_ddr_config void - Fix memory leak of the mcdi structure - Update the spelling - Remove the workqueue Changes in v5: - Update the compatible - Update the handle_error documentation Changes in v4: - Update the compatible Changes in v3: - make remove void Changes in v2: - remove reset - Add the remote proc requests - remove probe_once - reorder the rpmsg registration - the data width , rank and number of channel is read from message. drivers/edac/Kconfig | 11 + drivers/edac/Makefile | 1 + drivers/edac/versalnet_edac.c | 1108 +++++++++++++++++++++++++++++ include/linux/cdx/edac_cdx_pcol.h | 28 + 4 files changed, 1148 insertions(+) create mode 100644 drivers/edac/versalnet_edac.c create mode 100644 include/linux/cdx/edac_cdx_pcol.h diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index 19ad3c3b675d..081bccd3405b 100644 --- a/drivers/edac/Kconfig +++ b/drivers/edac/Kconfig @@ -576,4 +576,15 @@ config EDAC_LOONGSON errors (CE) only. Loongson-3A5000/3C5000/3D5000/3A6000/3C6000 are compatible. =20 +config EDAC_VERSALNET + tristate "AMD Versal NET EDAC" + depends on CDX_CONTROLLER && ARCH_ZYNQMP + help + Support for single bit error correction, double bit error detection on + the AMD Versal NET DDR memory controller and other system errors + from various IP subsystems (e.g., RPU, NOCs, HNICX, PL). + + Report single bit errors (CE), double bit errors (UE) and + errors from other IP subsystems like RPU, APU, NOC, HNICX and PL. + endif # EDAC diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile index a8f2d8f6c894..8eca81f04160 100644 --- a/drivers/edac/Makefile +++ b/drivers/edac/Makefile @@ -88,3 +88,4 @@ obj-$(CONFIG_EDAC_NPCM) +=3D npcm_edac.o obj-$(CONFIG_EDAC_ZYNQMP) +=3D zynqmp_edac.o obj-$(CONFIG_EDAC_VERSAL) +=3D versal_edac.o obj-$(CONFIG_EDAC_LOONGSON) +=3D loongson_edac.o +obj-$(CONFIG_EDAC_VERSALNET) +=3D versalnet_edac.o diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c new file mode 100644 index 000000000000..2cc7c8681deb --- /dev/null +++ b/drivers/edac/versalnet_edac.c @@ -0,0 +1,1108 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * AMD Versal NET memory controller driver + * Copyright (C) 2025 Advanced Micro Devices, Inc. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "edac_module.h" + +/* Granularity of reported error in bytes */ +#define DDRMC5_EDAC_ERR_GRAIN 1 +#define MC_CMD_EDAC_GET_DDR_CONFIG_IN_LEN 4 + +#define DDRMC5_EDAC_MSG_SIZE 256 + +#define DDRMC5_IRQ_CE_MASK GENMASK(18, 15) +#define DDRMC5_IRQ_UE_MASK GENMASK(14, 11) + +#define DDRMC5_RANK_1_MASK GENMASK(11, 6) +#define MASK_24 GENMASK(29, 24) +#define MASK_0 GENMASK(5, 0) + +#define DDRMC5_LRANK_1_MASK GENMASK(11, 6) +#define DDRMC5_LRANK_2_MASK GENMASK(17, 12) +#define DDRMC5_BANK1_MASK GENMASK(11, 6) +#define DDRMC5_GRP_0_MASK GENMASK(17, 12) +#define DDRMC5_GRP_1_MASK GENMASK(23, 18) + +#define ECCR_UE_CE_ADDR_HI_ROW_MASK GENMASK(10, 0) + +#define DDRMC5_MAX_ROW_CNT 18 +#define DDRMC5_MAX_COL_CNT 11 +#define DDRMC5_MAX_RANK_CNT 2 +#define DDRMC5_MAX_LRANK_CNT 4 +#define DDRMC5_MAX_BANK_CNT 2 +#define DDRMC5_MAX_GRP_CNT 3 + +#define DDRMC5_REGHI_ROW 7 +#define DDRMC5_EACHBIT 1 +#define DDRMC5_ERR_TYPE_CE 0 +#define DDRMC5_ERR_TYPE_UE 1 +#define DDRMC5_HIGH_MEM_EN BIT(20) +#define DDRMC5_MEM_MASK GENMASK(19, 0) +#define DDRMC5_X16_BASE 256 +#define DDRMC5_X16_ECC 32 +#define DDRMC5_X16_SIZE (DDRMC5_X16_BASE + DDRMC5_X16_ECC) +#define DDRMC5_X32_SIZE 576 +#define DDRMC5_HIMEM_BASE (256 * SZ_1M) +#define DDRMC5_ILC_HIMEM_EN BIT(28) +#define DDRMC5_ILC_MEM GENMASK(27, 0) +#define DDRMC5_INTERLEAVE_SEL GENMASK(3, 0) +#define DDRMC5_BUS_WIDTH_MASK GENMASK(19, 18) +#define DDRMC5_NUM_CHANS_MASK BIT(17) +#define DDRMC5_RANK_MASK GENMASK(15, 14) +#define DDRMC5_DWIDTH_MASK GENMASK(5, 4) + +#define AMD_MIN_BUF_LEN 0x28 +#define AMD_ERROR_LEVEL 2 +#define AMD_ERRORID 3 +#define TOTAL_ERR_LENGTH 5 +#define AMD_MSG_ERR_OFFSET 8 +#define AMD_MSG_ERR_LENGTH 9 +#define AMD_ERR_DATA 10 +#define MCDI_RESPONSE 0xFF + +#define ERR_NOTIFICATION_MAX 96 +#define REG_MAX 152 +#define ADEC_MAX 152 +#define NUM_CONTROLLERS 8 +#define REGS_PER_CONTROLLER 19 +#define ADEC_NUM 19 +#define MC_CMD_EDAC_GET_OVERALL_DDR_CONFIG 2 +#define BUFFER_SZ 80 + +#define XDDR5_BUS_WIDTH_64 0 +#define XDDR5_BUS_WIDTH_32 1 +#define XDDR5_BUS_WIDTH_16 2 + +#define AMD_ERR "[VERSAL_EDAC_ERR_ID: %d] Error type:" +/** + * struct ecc_error_info - ECC error log information. + * @burstpos: Burst position. + * @lrank: Logical Rank number. + * @rank: Rank number. + * @group: Group number. + * @bank: Bank number. + * @col: Column number. + * @row: Row number. + * @rowhi: Row number higher bits. + * @i: ECC error info. + */ +union ecc_error_info { + struct { + u32 burstpos:3; + u32 lrank:4; + u32 rank:2; + u32 group:3; + u32 bank:2; + u32 col:11; + u32 row:7; + u32 rowhi; + }; + u64 i; +} __packed; + +/** + * struct row_col_mapping - Row and column bit positions in ADEC(address d= ecoder) registers. + * @row0: Row0 bit position. + * @row1: Row1 bit position. + * @row2: Row2 bit position. + * @row3: Row3 bit position. + * @row4: Row4 bit position. + * @reserved: Unused bits. + * @col1: Column 1 bit position. + * @col2: Column 2 bit position. + * @col3: Column 3 bit position. + * @col4: Column 4 bit position. + * @col5: Column 5 bit position. + * @reservedcol: Unused column bits. + * @i: ADEC register info. + */ +union row_col_mapping { + struct { + u32 row0:6; + u32 row1:6; + u32 row2:6; + u32 row3:6; + u32 row4:6; + u32 reserved:2; + }; + struct { + u32 col1:6; + u32 col2:6; + u32 col3:6; + u32 col4:6; + u32 col5:6; + u32 reservedcol:2; + }; + u32 i; +} __packed; + +/** + * struct ecc_status - ECC status information to report. + * @ceinfo: Correctable error log information. + * @ueinfo: Uncorrected error log information. + * @channel: Channel number. + * @error_type: Error type information. + */ +struct ecc_status { + union ecc_error_info ceinfo[2]; + union ecc_error_info ueinfo[2]; + u8 channel; + u8 error_type; +}; + +/** + * struct mc_priv - DDR memory controller private instance data. + * @message: Buffer for framing the event specific info. + * @stat: ECC status information. + * @error_id: The error id. + * @error_level: The error level. + * @dwidth: Width of data bus excluding ECC bits. + * @part_len: The support of the message received. + * @regs: The registers sent on the rpmsg. + * @adec: Address decode registers. + * @mci: Memory controller interface. + * @ept: rpmsg endpoint. + * @mcdi: The mcdi handle. + */ +struct mc_priv { + char message[DDRMC5_EDAC_MSG_SIZE]; + struct ecc_status stat; + u32 error_id; + u32 error_level; + u32 dwidth; + u32 part_len; + u32 regs[REG_MAX]; + u32 adec[ADEC_MAX]; + struct mem_ctl_info *mci; + struct rpmsg_endpoint *ept; + struct cdx_mcdi *mcdi; +}; + +/* Address decoder (ADEC) register information + * To match the order in which the register information is received from + * firmware + */ +enum adec_info { + CONF =3D 0, + ADEC0, + ADEC1, + ADEC2, + ADEC3, + ADEC4, + ADEC5, + ADEC6, + ADEC7, + ADEC8, + ADEC9, + ADEC10, + ADEC11, + ADEC12, + ADEC13, + ADEC14, + ADEC15, + ADEC16, + ADECILC, +}; + +enum reg_info { + ISR =3D 0, + IMR, + ECCR0_ERR_STATUS, + ECCR0_ADDR_LO, + ECCR0_ADDR_HI, + ECCR0_DATA_LO, + ECCR0_DATA_HI, + ECCR0_PAR, + ECCR1_ERR_STATUS, + ECCR1_ADDR_LO, + ECCR1_ADDR_HI, + ECCR1_DATA_LO, + ECCR1_DATA_HI, + ECCR1_PAR, + XMPU_ERR, + XMPU_ERR_ADDR_L0, + XMPU_ERR_ADDR_HI, + XMPU_ERR_AXI_ID, + ADEC_CHK_ERR_LOG, +}; + +static bool get_ddr_info(u32 *error_data, struct mc_priv *priv) +{ + u32 reglo, reghi, parity, eccr0_val, eccr1_val, isr; + struct ecc_status *p; + + p =3D &priv->stat; + + isr =3D error_data[ISR]; + + if (!(isr & (DDRMC5_IRQ_UE_MASK | DDRMC5_IRQ_CE_MASK))) + return false; + + eccr0_val =3D error_data[ECCR0_ERR_STATUS]; + eccr1_val =3D error_data[ECCR1_ERR_STATUS]; + + if (!eccr0_val && !eccr1_val) + return false; + + if (!eccr0_val) + p->channel =3D 1; + else + p->channel =3D 0; + + reglo =3D error_data[ECCR0_ADDR_LO]; + reghi =3D error_data[ECCR0_ADDR_HI]; + if ((isr & DDRMC5_IRQ_CE_MASK)) + p->ceinfo[0].i =3D reglo | (u64)reghi << 32; + else if ((isr & DDRMC5_IRQ_UE_MASK)) + p->ueinfo[0].i =3D reglo | (u64)reghi << 32; + + parity =3D error_data[ECCR0_PAR]; + edac_dbg(2, "ERR DATA: 0x%08X%08X ERR DATA PARITY: 0x%08X\n", + reghi, reglo, parity); + + reglo =3D error_data[ECCR1_ADDR_LO]; + reghi =3D error_data[ECCR1_ADDR_HI]; + if ((isr & DDRMC5_IRQ_CE_MASK)) + p->ceinfo[1].i =3D reglo | (u64)reghi << 32; + else if ((isr & DDRMC5_IRQ_UE_MASK)) + p->ueinfo[1].i =3D reglo | (u64)reghi << 32; + + parity =3D error_data[ECCR1_PAR]; + edac_dbg(2, "ERR DATA: 0x%08X%08X ERR DATA PARITY: 0x%08X\n", + reghi, reglo, parity); + + return true; +} + +/** + * convert_to_physical - Convert to physical address. + * @priv: DDR memory controller private instance data. + * @pinf: ECC error info structure. + * @controller: Controller number of the DDRMC5 + * @error_data: the DDRMC5 ADEC address decoder register data + * + * Return: Physical address of the DDR memory. + */ +static unsigned long convert_to_physical(struct mc_priv *priv, + union ecc_error_info pinf, + int controller, int *error_data) +{ + u32 row, blk, rsh_req_addr, interleave, ilc_base_ctrl_add, ilc_himem_en, = reg, offset; + u64 high_mem_base, high_mem_offset, low_mem_offset, ilcmem_base; + unsigned long err_addr =3D 0, addr; + union row_col_mapping cols; + union row_col_mapping rows; + u32 col_bit_0; + + row =3D pinf.rowhi << DDRMC5_REGHI_ROW | pinf.row; + offset =3D controller * ADEC_NUM; + + reg =3D error_data[ADEC6]; + rows.i =3D reg; + err_addr |=3D (row & BIT(0)) << rows.row0; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row1; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row2; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row3; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row4; + row >>=3D DDRMC5_EACHBIT; + + reg =3D error_data[ADEC7]; + rows.i =3D reg; + err_addr |=3D (row & BIT(0)) << rows.row0; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row1; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row2; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row3; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row4; + row >>=3D DDRMC5_EACHBIT; + + reg =3D error_data[ADEC8]; + rows.i =3D reg; + err_addr |=3D (row & BIT(0)) << rows.row0; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row1; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row2; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row3; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row4; + + reg =3D error_data[ADEC9]; + rows.i =3D reg; + + err_addr |=3D (row & BIT(0)) << rows.row0; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row1; + row >>=3D DDRMC5_EACHBIT; + err_addr |=3D (row & BIT(0)) << rows.row2; + row >>=3D DDRMC5_EACHBIT; + + col_bit_0 =3D FIELD_GET(MASK_24, error_data[ADEC9]); + pinf.col >>=3D 1; + err_addr |=3D (pinf.col & 1) << col_bit_0; + + cols.i =3D error_data[ADEC10]; + err_addr |=3D (pinf.col & 1) << cols.col1; + pinf.col >>=3D 1; + err_addr |=3D (pinf.col & 1) << cols.col2; + pinf.col >>=3D 1; + err_addr |=3D (pinf.col & 1) << cols.col3; + pinf.col >>=3D 1; + err_addr |=3D (pinf.col & 1) << cols.col4; + pinf.col >>=3D 1; + err_addr |=3D (pinf.col & 1) << cols.col5; + pinf.col >>=3D 1; + + cols.i =3D error_data[ADEC11]; + err_addr |=3D (pinf.col & 1) << cols.col1; + pinf.col >>=3D 1; + err_addr |=3D (pinf.col & 1) << cols.col2; + pinf.col >>=3D 1; + err_addr |=3D (pinf.col & 1) << cols.col3; + pinf.col >>=3D 1; + err_addr |=3D (pinf.col & 1) << cols.col4; + pinf.col >>=3D 1; + err_addr |=3D (pinf.col & 1) << cols.col5; + pinf.col >>=3D 1; + + reg =3D error_data[ADEC12]; + err_addr |=3D (pinf.bank & BIT(0)) << (reg & MASK_0); + pinf.bank >>=3D DDRMC5_EACHBIT; + err_addr |=3D (pinf.bank & BIT(0)) << FIELD_GET(DDRMC5_BANK1_MASK, reg); + pinf.bank >>=3D DDRMC5_EACHBIT; + + err_addr |=3D (pinf.bank & BIT(0)) << FIELD_GET(DDRMC5_GRP_0_MASK, reg); + pinf.group >>=3D DDRMC5_EACHBIT; + err_addr |=3D (pinf.bank & BIT(0)) << FIELD_GET(DDRMC5_GRP_1_MASK, reg); + pinf.group >>=3D DDRMC5_EACHBIT; + err_addr |=3D (pinf.bank & BIT(0)) << FIELD_GET(MASK_24, reg); + pinf.group >>=3D DDRMC5_EACHBIT; + + reg =3D error_data[ADEC4]; + err_addr |=3D (pinf.rank & BIT(0)) << (reg & MASK_0); + pinf.rank >>=3D DDRMC5_EACHBIT; + err_addr |=3D (pinf.rank & BIT(0)) << FIELD_GET(DDRMC5_RANK_1_MASK, reg); + pinf.rank >>=3D DDRMC5_EACHBIT; + + reg =3D error_data[ADEC5]; + err_addr |=3D (pinf.lrank & BIT(0)) << (reg & MASK_0); + pinf.lrank >>=3D DDRMC5_EACHBIT; + err_addr |=3D (pinf.lrank & BIT(0)) << FIELD_GET(DDRMC5_LRANK_1_MASK, reg= ); + pinf.lrank >>=3D DDRMC5_EACHBIT; + err_addr |=3D (pinf.lrank & BIT(0)) << FIELD_GET(DDRMC5_LRANK_2_MASK, reg= ); + pinf.lrank >>=3D DDRMC5_EACHBIT; + err_addr |=3D (pinf.lrank & BIT(0)) << FIELD_GET(MASK_24, reg); + pinf.lrank >>=3D DDRMC5_EACHBIT; + + high_mem_base =3D (priv->adec[ADEC2 + offset] & DDRMC5_MEM_MASK) * DDRMC5= _HIMEM_BASE; + interleave =3D priv->adec[ADEC13 + offset] & DDRMC5_INTERLEAVE_SEL; + + high_mem_offset =3D priv->adec[ADEC3 + offset] & DDRMC5_MEM_MASK; + low_mem_offset =3D priv->adec[ADEC1 + offset] & DDRMC5_MEM_MASK; + reg =3D priv->adec[ADEC14 + offset]; + ilc_himem_en =3D !!(reg & DDRMC5_ILC_HIMEM_EN); + ilcmem_base =3D (reg & DDRMC5_ILC_MEM) * SZ_1M; + if (ilc_himem_en) + ilc_base_ctrl_add =3D ilcmem_base - high_mem_offset; + else + ilc_base_ctrl_add =3D ilcmem_base - low_mem_offset; + + if (priv->dwidth =3D=3D DEV_X16) { + blk =3D err_addr / DDRMC5_X16_SIZE; + rsh_req_addr =3D (blk << 8) + ilc_base_ctrl_add; + err_addr =3D rsh_req_addr * interleave * 2; + } else { + blk =3D err_addr / DDRMC5_X32_SIZE; + rsh_req_addr =3D (blk << 9) + ilc_base_ctrl_add; + err_addr =3D rsh_req_addr * interleave * 2; + } + + if ((priv->adec[ADEC2 + offset] & DDRMC5_HIGH_MEM_EN) && err_addr >=3D hi= gh_mem_base) + addr =3D err_addr - high_mem_offset; + else + addr =3D err_addr - low_mem_offset; + + return addr; +} + +/** + * handle_error - Handle Correctable and Uncorrectable errors. + * @priv: DDR memory controller private instance data. + * @stat: ECC status structure. + * @controller: Controller number of the DDRMC5 + * @error_data: the DDRMC5 ADEC address decoder register data + * + * Handles ECC correctable and uncorrectable errors. + */ +static void handle_error(struct mc_priv *priv, struct ecc_status *stat, + int controller, int *error_data) +{ + struct mem_ctl_info *mci =3D priv->mci; + union ecc_error_info pinf; + unsigned long pa; + phys_addr_t pfn; + int err; + + if (stat->error_type =3D=3D DDRMC5_ERR_TYPE_CE) { + pinf =3D stat->ceinfo[stat->channel]; + snprintf(priv->message, DDRMC5_EDAC_MSG_SIZE, + "Error type:%s Controller %d Addr at %lx\n", + "CE", controller, convert_to_physical(priv, pinf, controller, error_da= ta)); + + edac_mc_handle_error(HW_EVENT_ERR_CORRECTED, mci, + 1, 0, 0, 0, 0, 0, -1, + priv->message, ""); + } + + if (stat->error_type =3D=3D DDRMC5_ERR_TYPE_UE) { + pinf =3D stat->ueinfo[stat->channel]; + snprintf(priv->message, DDRMC5_EDAC_MSG_SIZE, + "Error type:%s controller %d Addr at %lx\n", + "UE", controller, convert_to_physical(priv, pinf, controller, error_da= ta)); + + edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci, + 1, 0, 0, 0, 0, 0, -1, + priv->message, ""); + pa =3D convert_to_physical(priv, pinf, controller, error_data); + pfn =3D PHYS_PFN(pa); + + if (IS_ENABLED(CONFIG_MEMORY_FAILURE)) { + err =3D memory_failure(pfn, MF_ACTION_REQUIRED); + if (err) + edac_dbg(2, "In fail of memory_failure %d\n", err); + else + edac_dbg(2, "Page at PA 0x%lx is hardware poisoned\n", pa); + } + } +} + +/** + * init_csrows - Initialize the csrow data. + * @mci: EDAC memory controller instance. + * + * Initialize the chip select rows associated with the EDAC memory + * controller instance. + */ +static void init_csrows(struct mem_ctl_info *mci) +{ + struct mc_priv *priv =3D mci->pvt_info; + struct csrow_info *csi; + struct dimm_info *dimm; + u32 row; + int ch; + + for (row =3D 0; row < mci->nr_csrows; row++) { + csi =3D mci->csrows[row]; + for (ch =3D 0; ch < csi->nr_channels; ch++) { + dimm =3D csi->channels[ch]->dimm; + dimm->edac_mode =3D EDAC_SECDED; + dimm->mtype =3D MEM_DDR5; + dimm->grain =3D DDRMC5_EDAC_ERR_GRAIN; + dimm->dtype =3D priv->dwidth; + } + } +} + +static void mc_init(struct mem_ctl_info *mci, struct platform_device *pdev) +{ + mci->pdev =3D &pdev->dev; + platform_set_drvdata(pdev, mci); + + /* Initialize controller capabilities and configuration */ + mci->mtype_cap =3D MEM_FLAG_DDR5; + mci->edac_ctl_cap =3D EDAC_FLAG_NONE | EDAC_FLAG_SECDED; + mci->scrub_cap =3D SCRUB_HW_SRC; + mci->scrub_mode =3D SCRUB_NONE; + + mci->edac_cap =3D EDAC_FLAG_SECDED; + mci->ctl_name =3D "amd_ddr_controller"; + mci->dev_name =3D dev_name(&pdev->dev); + mci->mod_name =3D "versalnet_edac"; + + edac_op_state =3D EDAC_OPSTATE_INT; + + init_csrows(mci); +} + +#define to_mci(k) container_of(k, struct mem_ctl_info, dev) + +static unsigned int amd_mcdi_rpc_timeout(struct cdx_mcdi *cdx, unsigned in= t cmd) +{ + return MCDI_RPC_TIMEOUT; +} + +static void amd_mcdi_request(struct cdx_mcdi *cdx, + const struct cdx_dword *hdr, size_t hdr_len, + const struct cdx_dword *sdu, size_t sdu_len) +{ + unsigned char *send_buf; + int ret; + + send_buf =3D kzalloc(hdr_len + sdu_len, GFP_KERNEL); + if (!send_buf) + return; + + memcpy(send_buf, hdr, hdr_len); + memcpy(send_buf + hdr_len, sdu, sdu_len); + + ret =3D rpmsg_send(cdx->ept, send_buf, hdr_len + sdu_len); + if (ret) + dev_err(&cdx->rpdev->dev, "Failed to send rpmsg data\n"); + kfree(send_buf); +} + +static const struct cdx_mcdi_ops mcdi_ops =3D { + .mcdi_rpc_timeout =3D amd_mcdi_rpc_timeout, + .mcdi_request =3D amd_mcdi_request, +}; + +static void get_ddr_config(u32 index, u32 *buffer, struct cdx_mcdi *amd_mc= di) +{ + size_t outlen; + int ret; + + MCDI_DECLARE_BUF(inbuf, MC_CMD_EDAC_GET_DDR_CONFIG_IN_LEN); + MCDI_DECLARE_BUF(outbuf, BUFFER_SZ); + + MCDI_SET_DWORD(inbuf, EDAC_GET_DDR_CONFIG_IN_CONTROLLER_INDEX, index); + + ret =3D cdx_mcdi_rpc(amd_mcdi, MC_CMD_EDAC_GET_DDR_CONFIG, inbuf, sizeof(= inbuf), + outbuf, sizeof(outbuf), &outlen); + if (!ret) + memcpy(buffer, MCDI_PTR(outbuf, EDAC_GET_DDR_CONFIG_OUT_REGISTER_VALUES), + (ADEC_NUM * 4)); +} + +static void amd_setup_mcdi(struct mc_priv *mc_priv) +{ + struct cdx_mcdi *amd_mcdi; + int ret, i; + + amd_mcdi =3D kzalloc(sizeof(*amd_mcdi), GFP_KERNEL); + if (!amd_mcdi) + return; + + amd_mcdi->mcdi_ops =3D &mcdi_ops; + ret =3D cdx_mcdi_init(amd_mcdi); + if (ret) { + kfree(amd_mcdi); + return; + } + + amd_mcdi->ept =3D mc_priv->ept; + mc_priv->mcdi =3D amd_mcdi; + + for (i =3D 0; i < NUM_CONTROLLERS; i++) + get_ddr_config(i, &mc_priv->adec[ADEC_NUM * i], amd_mcdi); +} + +static const guid_t amd_versalnet_guid =3D GUID_INIT(0x82678888, 0xa556, 0= x44f2, + 0xb8, 0xb4, 0x45, 0x56, 0x2e, + 0x8c, 0x5b, 0xec); + +static int amd_rpmsg_cb(struct rpmsg_device *rpdev, void *data, + int len, void *priv, u32 src) +{ + struct mc_priv *mc_priv =3D dev_get_drvdata(&rpdev->dev); + const guid_t *sec_type =3D &guid_null; + u32 length, offset, error_id; + u32 *result =3D (u32 *)data; + struct ecc_status *p; + int i, j, k, sec_sev; + u32 *adec_data; + + if (*(u8 *)data =3D=3D MCDI_RESPONSE) { + cdx_mcdi_process_cmd(mc_priv->mcdi, (struct cdx_dword *)data, len); + return 0; + } + + sec_sev =3D result[AMD_ERROR_LEVEL]; + error_id =3D result[AMD_ERRORID]; + length =3D result[AMD_MSG_ERR_LENGTH]; + offset =3D result[AMD_MSG_ERR_OFFSET]; + + if (result[TOTAL_ERR_LENGTH] > length) { + if (!mc_priv->part_len) + mc_priv->part_len =3D length; + else + mc_priv->part_len +=3D length; + /* + * The data can come in 2 stretches. Construct the regs from 2 + * messages the offset indicates the offset from which the data is to + * be taken + */ + for (i =3D 0 ; i < length; i++) { + k =3D offset + i; + j =3D AMD_ERR_DATA + i; + mc_priv->regs[k] =3D result[j]; + } + if (mc_priv->part_len < result[TOTAL_ERR_LENGTH]) + return 0; + mc_priv->part_len =3D 0; + } + + mc_priv->error_id =3D error_id; + mc_priv->error_level =3D result[AMD_ERROR_LEVEL]; + + switch (error_id) { + /* GSW Non-Correctable error */ + case 5: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "General Software Non-Correctable error", error_id); + break; + /* CFU error */ + case 6: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "CFU error", error_id); + break; + /* CFRAME error */ + case 7: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "CFRAME error", error_id); + break; + /* Microblaze correctable error */ + case 10: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "DDRMC Microblaze Correctable ECC error", error_id); + break; + /* Microblaze Non-correctable */ + case 11: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "DDRMC Microblaze Non-Correctable ECC error", error_id); + break; + /* MMCM error */ + case 15: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "MMCM error", error_id); + break; + /* HNIX correctable */ + case 16: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "HNICX Correctable error", error_id); + break; + /* HNIX Non-correctable */ + case 17: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "HNICX Non-Correctable error", error_id); + break; + /* DDRMC correctable error */ + case 18: + p =3D &mc_priv->stat; + memset(p, 0, sizeof(struct ecc_status)); + p->error_type =3D DDRMC5_ERR_TYPE_CE; + for (i =3D 0 ; i < NUM_CONTROLLERS; i++) { + if (get_ddr_info(&mc_priv->regs[i * REGS_PER_CONTROLLER], mc_priv)) { + adec_data =3D mc_priv->adec + ADEC_NUM * i; + handle_error(mc_priv, &mc_priv->stat, i, adec_data); + } + } + return 0; + /* DDRMC Non-correctable */ + case 19: + p =3D &mc_priv->stat; + memset(p, 0, sizeof(struct ecc_status)); + p->error_type =3D DDRMC5_ERR_TYPE_UE; + for (i =3D 0 ; i < NUM_CONTROLLERS; i++) { + if (get_ddr_info(&mc_priv->regs[i * REGS_PER_CONTROLLER], mc_priv)) { + adec_data =3D mc_priv->adec + ADEC_NUM * i; + handle_error(mc_priv, &mc_priv->stat, i, adec_data); + } + } + return 0; + /* GT Correctable error */ + case 21: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "GT Non-Correctable error", error_id); + break; + /* PL Sysmon correctable error */ + case 22: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "PL Sysmon Correctable error", error_id); + break; + /* PL Sysmon Non-correctable error */ + case 23: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "PL Sysmon Non-Correctable error", error_id); + break; + /* LPX unexpected dfx activation error */ + case 111: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "LPX unexpected dfx activation error", error_id); + break; + /* INT LPD Non-Correctable error */ + case 114: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "INT_LPD Non-Correctable error", error_id); + break; + /* INT OCM Non-Correctable error */ + case 116: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "INT_OCM Non-Correctable error", error_id); + break; + /* INT FPD Correctable error */ + case 117: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "INT_FPD Correctable error", error_id); + break; + /* INT FPD Non-Correctable error */ + case 118: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "INT_FPD Non-Correctable error", error_id); + break; + /* INT IOU Non-Correctable error */ + case 120: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "INT_IOU Non-Correctable error", error_id); + break; + /* GIC AXI err_int_irq */ + case 123: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "err_int_irq from APU GIC Distributor", error_id); + break; + /* GIC ECC fault_int_irq */ + case 124: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "fault_int_irq from APU GIC Distribute", error_id); + break; + /* FPX SPLITTER error */ + case 132 ... 139: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "FPX SPLITTER error", error_id); + break; + /* APU0 error */ + case 140: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "APU Cluster 0 error", error_id); + break; + /* APU1 error */ + case 141: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "APU Cluster 1 error", error_id); + break; + /* APU2 error */ + case 142: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "APU Cluster 2 error", error_id); + break; + /* APU3 error */ + case 143: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "APU Cluster 3 error", error_id); + break; + /* Window watchdog LPX error */ + case 145: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "WWDT1 LPX error", error_id); + break; + /* IPI error */ + case 147: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "IPI error", error_id); + break; + /* LPX AFIFS error */ + case 152 ... 153: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "AFIFS error", error_id); + break; + /* LPX glitch Errors */ + case 154 ... 155: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "LPX glitch error", error_id); + break; + /* FPX AFIFS error */ + case 185 ... 186: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "FPX AFIFS error", error_id); + break; + /* AFIFM Non-fatal error */ + case 195 ... 199: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "AFIFM error", error_id); + break; + /* Firmware error */ + case 108: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "PSM Correctable error", error_id); + break; + /* PMC Correctable error */ + case 59: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "PMC correctable error", error_id); + break; + /* PMC Un-Correctable error */ + case 60: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "PMC Un correctable error", error_id); + break; + /* PMC Sysmon temperature shutdown alert and power supply failure errors= */ + case 43 ... 47: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "PMC Sysmon error", error_id); + break; + /* RPU Error */ + case 163 ... 184: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "RPU error", error_id); + break; + /* OCM0 correctable error */ + case 148: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "OCM0 correctable error", error_id); + break; + /* OCM1 correctable error */ + case 149: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "OCM1 correctable error", error_id); + break; + /* OCM0 Un-correctable error */ + case 150: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "OCM0 Un-correctable error", error_id); + break; + /* OCM1 Un-correctable error */ + case 151: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "OCM1 Un-correctable error", error_id); + break; + /* PSX_CMN_3 error */ + case 189: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "PSX_CMN_3 PD block consolidated error", error_id); + break; + /* FPD_INT_WRAP error */ + case 191: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "FPD_INT_WRAP PD block consolidated error", error_id); + break; + /* CRAM_CE error */ + case 232: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + AMD_ERR "CRAM Un-Correctable error", error_id); + break; + default: + snprintf(mc_priv->message, DDRMC5_EDAC_MSG_SIZE, + "VERSAL_EDAC_ERR_ID: %d", error_id); + break; + } + + /* Convert to bytes */ + length =3D result[TOTAL_ERR_LENGTH] * 4; + log_non_standard_event(sec_type, &amd_versalnet_guid, mc_priv->message, + sec_sev, (void *)&result[AMD_ERR_DATA], length); + + return 0; +} + +static struct rpmsg_device_id amd_rpmsg_id_table[] =3D { + { .name =3D "error_ipc" }, + { }, +}; +MODULE_DEVICE_TABLE(rpmsg, amd_rpmsg_id_table); + +static int amd_rpmsg_probe(struct rpmsg_device *rpdev) +{ + struct rpmsg_channel_info chinfo =3D {0}; + struct mc_priv *pg; + + pg =3D (struct mc_priv *)amd_rpmsg_id_table[0].driver_data; + chinfo.src =3D RPMSG_ADDR_ANY; + chinfo.dst =3D rpdev->dst; + strscpy(chinfo.name, amd_rpmsg_id_table[0].name, + strlen(amd_rpmsg_id_table[0].name)); + + pg->ept =3D rpmsg_create_ept(rpdev, amd_rpmsg_cb, NULL, chinfo); + if (!pg->ept) + return dev_err_probe(&rpdev->dev, -ENXIO, + "Failed to create ept for channel %s\n", + chinfo.name); + + dev_set_drvdata(&rpdev->dev, pg); + return 0; +} + +static void amd_rpmsg_remove(struct rpmsg_device *rpdev) +{ + struct mc_priv *mc_priv =3D dev_get_drvdata(&rpdev->dev); + + rpmsg_destroy_ept(mc_priv->ept); + dev_set_drvdata(&rpdev->dev, NULL); +} + +static struct rpmsg_driver amd_rpmsg_driver =3D { + .drv.name =3D KBUILD_MODNAME, + .probe =3D amd_rpmsg_probe, + .remove =3D amd_rpmsg_remove, + .callback =3D amd_rpmsg_cb, + .id_table =3D amd_rpmsg_id_table, +}; + +/** + * get_dwidth - Return the controller memory width. + * @width: data width read from the config reg. + * + * Get the EDAC device type width appropriate for the controller + * configuration. + * + * Return: a device type width enumeration. + */ +static enum dev_type get_dwidth(u32 width) +{ + enum dev_type dt; + + switch (width) { + case XDDR5_BUS_WIDTH_16: + dt =3D DEV_X16; + break; + case XDDR5_BUS_WIDTH_32: + dt =3D DEV_X32; + break; + case XDDR5_BUS_WIDTH_64: + dt =3D DEV_X64; + break; + default: + dt =3D DEV_UNKNOWN; + } + + return dt; +} + +static int mc_probe(struct platform_device *pdev) +{ + u32 num_chans, rank, dwidth, config; + struct device_node *r5_core_node; + struct edac_mc_layer layers[2]; + struct mem_ctl_info *mci; + struct mc_priv *priv; + struct rproc *rp; + enum dev_type dt; + int rc, i; + + r5_core_node =3D of_parse_phandle(pdev->dev.of_node, "amd,rproc", 0); + if (!r5_core_node) { + dev_err(&pdev->dev, "amd,rproc: invalid phandle\n"); + return -EINVAL; + } + + rp =3D rproc_get_by_phandle(r5_core_node->phandle); + if (!rp) + return -EPROBE_DEFER; + + rc =3D rproc_boot(rp); + if (rc) { + dev_err(&pdev->dev, "Failed to attach to remote processor\n"); + rproc_put(rp); + return rc; + } + + priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + amd_rpmsg_id_table[0].driver_data =3D (kernel_ulong_t)priv; + rc =3D register_rpmsg_driver(&amd_rpmsg_driver); + if (rc) { + edac_printk(KERN_ERR, EDAC_MC, + "Failed to register RPMsg driver: %d\n", rc); + goto free_rproc; + } + + amd_setup_mcdi(priv); + + for (i =3D 0; i < NUM_CONTROLLERS; i++) { + config =3D priv->adec[CONF + i * ADEC_NUM]; + num_chans =3D FIELD_GET(DDRMC5_NUM_CHANS_MASK, config); + rank =3D FIELD_GET(DDRMC5_RANK_MASK, config); + rank =3D 1 << rank; + dwidth =3D FIELD_GET(DDRMC5_BUS_WIDTH_MASK, config); + dt =3D get_dwidth(dwidth); + + /* Find the first enabled device and register that one. */ + if (dt !=3D DEV_UNKNOWN) { + layers[0].type =3D EDAC_MC_LAYER_CHIP_SELECT; + layers[0].size =3D rank; + layers[0].is_virt_csrow =3D true; + layers[1].type =3D EDAC_MC_LAYER_CHANNEL; + layers[1].size =3D num_chans; + layers[1].is_virt_csrow =3D false; + + mci =3D edac_mc_alloc(0, ARRAY_SIZE(layers), layers, + sizeof(struct mc_priv)); + if (!mci) { + edac_printk(KERN_ERR, EDAC_MC, + "Failed memory allocation for mc instance\n"); + rc =3D -ENOMEM; + goto free_rpmsg; + } + + priv->mci =3D mci; + priv->dwidth =3D dt; + mc_init(mci, pdev); + rc =3D edac_mc_add_mc(mci); + if (rc) { + edac_printk(KERN_ERR, EDAC_MC, + "Failed to register with EDAC core\n"); + goto free_edac_mc; + } + return 0; + } + } + + return 0; + +free_edac_mc: + edac_mc_free(mci); +free_rpmsg: + unregister_rpmsg_driver(&amd_rpmsg_driver); +free_rproc: + rproc_shutdown(rp); + return rc; +} + +static void mc_remove(struct platform_device *pdev) +{ + struct mem_ctl_info *mci =3D platform_get_drvdata(pdev); + struct mc_priv *priv =3D mci->pvt_info; + + unregister_rpmsg_driver(&amd_rpmsg_driver); + edac_mc_del_mc(&pdev->dev); + edac_mc_free(mci); + rproc_shutdown(priv->mcdi->r5_rproc); +} + +static const struct of_device_id amd_edac_match[] =3D { + { .compatible =3D "xlnx,versal-net-ddrmc5", }, + {} +}; +MODULE_DEVICE_TABLE(of, amd_edac_match); + +static struct platform_driver amd_ddr_edac_mc_driver =3D { + .driver =3D { + .name =3D "amd-ddrmc-edac", + .of_match_table =3D amd_edac_match, + }, + .probe =3D mc_probe, + .remove =3D mc_remove, +}; + +module_platform_driver(amd_ddr_edac_mc_driver); + +MODULE_AUTHOR("AMD Inc"); +MODULE_DESCRIPTION("AMD DDRMC ECC driver"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/cdx/edac_cdx_pcol.h b/include/linux/cdx/edac_cdx= _pcol.h new file mode 100644 index 000000000000..a72ec131f083 --- /dev/null +++ b/include/linux/cdx/edac_cdx_pcol.h @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0 + * + * Driver for AMD network controllers and boards + * + * Copyright (C) 2021, Xilinx, Inc. + * Copyright (C) 2022-2023, Advanced Micro Devices, Inc. + */ + +#ifndef MC_CDX_PCOL_H +#define MC_CDX_PCOL_H +#include + +#define MC_CMD_EDAC_GET_DDR_CONFIG_OUT_WORD_LENGTH_LEN 4 +/* Number of registers for the DDR controller */ +#define MC_CMD_EDAC_GET_DDR_CONFIG_OUT_REGISTER_VALUES_OFST 4 +#define MC_CMD_EDAC_GET_DDR_CONFIG_OUT_REGISTER_VALUES_LEN 4 + +/***********************************/ +/* MC_CMD_EDAC_GET_DDR_CONFIG + * Provides detailed configuration for the DDR controller of the given ind= ex. + */ +#define MC_CMD_EDAC_GET_DDR_CONFIG 0x3 + +/* MC_CMD_EDAC_GET_DDR_CONFIG_IN msgrequest */ +#define MC_CMD_EDAC_GET_DDR_CONFIG_IN_CONTROLLER_INDEX_OFST 0 +#define MC_CMD_EDAC_GET_DDR_CONFIG_IN_CONTROLLER_INDEX_LEN 4 + +#endif /* MC_CDX_PCOL_H */ --=20 2.34.1