From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96AD4BA3D; Thu, 29 May 2025 00:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477631; cv=none; b=XJ9kYwcHNHs4vVFF9cfRL+k32fNdjZW4TMRl0Lq9ME4JQrBUs0QKbCy+2ZN73Q0jgYL74/Ec0H6vVeqfUmnXXPn04ms0S1QVRnkGKvghtHGQpAQgywE0e4o3hh5EjND3eZuuzf7uYm7aNa8Sg/1PUuSpJnEX1dRmEz7gQ2gPJY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477631; c=relaxed/simple; bh=VlFnpcsdHQxDHPb4oV6QFvxYxzGrchCWD4dTCtFa3zk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uRT/7axXf8HdQE7Ua8x1MY246zWw0vJ79JzIBEXQ7hWuGaDUmwsd+1+W7HUp5chtWg7G4cbEntECc8eInK1PFpCOFePbc3xgneeXgGeuu7Y3rHEpABe+gM1imbT7cH4rzGtEvqWJkFJBhkQqpebDB089B7ZggJw41PrSkHWUZ34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=DXoPD5hg; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="DXoPD5hg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zIN0s/km0iueisreKfHC8QMZpfiOoTcx08RjbxWkD0Y=; b=DXoPD5hgLwelEIuQ4fIw97hygH ZoKX+7N5qN1YGICpApEFIx7QxFeOJUZXsuCRHR7f9q4nf74YCl64VUqEJA4YrA3wWCSZgj+A/3R+0 LOCmeBVl6p/vlprbmKNrGNHF2dXBqwkGG1RP6tZXvr45iMeDI1fL2lzmuEZvnXBC96INoFfrEriAP Y/6XHaNLB1fVOHjQIj6SKAUuSXVcqNoLp6i5hFwckhAx4ZTKv5dsyF1UanaZm4mCfV1r4CudaOa88 JWwl9vG84Q0H+1HMsCYZ5ryQBOQvPRCFzaCr2F0TjQZVfAiYm953zbxfiWKoVrMczsjRJEFLJFXa4 rJxRcPmQ==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQto-00EZvd-Uv; Thu, 29 May 2025 02:13:34 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 01/11] PM: EM: Add ENERGY_MODEL_NETLINK Kconfig. Date: Thu, 29 May 2025 09:13:05 +0900 Message-ID: <20250529001315.233492-2-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Define a Kconfig, ENERGY_MODEL_NETLINK. That enables the netlink interface, which allows a userspace program to read the energy model and receive multicast events upon changes to the energy model. Signed-off-by: Changwoo Min --- kernel/power/Kconfig | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig index 54a623680019..b45933370b4e 100644 --- a/kernel/power/Kconfig +++ b/kernel/power/Kconfig @@ -390,3 +390,13 @@ config ENERGY_MODEL The exact usage of the energy model is subsystem-dependent. =20 If in doubt, say N. + +if ENERGY_MODEL + +config ENERGY_MODEL_NETLINK + bool "Energy Model netlink management" + depends on NET + help + The energy model framework has a netlink interface to notify the + changes in the energy model. It is recommended to enable the feature. +endif --=20 2.49.0 From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD01772612; Thu, 29 May 2025 00:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477635; cv=none; b=iN5lXh4QJxMZlL22UXGpK0gi2OH37SFUUGSuZJ7C0xGmWPR5qm3rFUfao91XrRJK2NpN+pIvGO7mSK9x055crjtI5U5xu7xgphChC8zV1gQBX1rPk1coKtdy3yUFD0f5C0jVB8WzDTntEr/13h+x2Z9eNRVhyRgb1499PlKp/94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477635; c=relaxed/simple; bh=nCg5W9dlXEbA46hwwD/r9httGc2FjaboJW+5wP3K+0Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rf+XKN8vprfYYcW1HWfRVHbcqHV50u8xXZ0XxmjSCdvvUFXAmnUs3RHkzUjybLjuUC19FDcdxIJo1wmnJ/z3JlyXc09XOnFv8vg0vYwtkkTi1HFcQCnyaiMc2jRom7WwSoIIIEP8stTsfuo7zJOS6og8V7B8G+tDTL+apBRoezA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=YeahE2xi; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="YeahE2xi" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8kBDfSz1JRvxg2i18Iw+DUUmUuXlPvCrkucQA27DpK8=; b=YeahE2xieWD60T29EOwUMwT1uH WUF8P3ZSkxYfVkQ9a78Vy/ePGJGRP0QU8nA1PuDIGFTieurEOp7E/qUYEqbxHwS6FHuYfxbp9OMsW BDqKoigBwhpK80Osvqt/p/md5nwkSbXZVY3mH6hhiZrNCx/ppRAM/H4/9tLlQaICq7NsJQiwbJrr3 f5E9gDG4paHXv2FPx8jQtXqhSbl4mJCe0PUJaed+oGzYQJlljuheTtfKquZz7bFqgzQCld6qVYrD9 vujopOozo3U6KU5avLoYXlxuVgqPmA6amDqaEBjRhhromXTkOgwdmyv5brnednCfVT5uH1BJv8go4 jFrKZrjA==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQtv-00EZvm-NT; Thu, 29 May 2025 02:13:40 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 02/11] PM: EM: Add a skeleton code for netlink notification. Date: Thu, 29 May 2025 09:13:06 +0900 Message-ID: <20250529001315.233492-3-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a boilerplate code for netlink notification to register and unregister the new protocol family. It defines the supported commands and event types and adds the minimalistic code for the protocol family registration. Signed-off-by: Changwoo Min --- include/uapi/linux/energy_model.h | 40 ++++++++++++++++++ kernel/power/Makefile | 1 + kernel/power/em_netlink.c | 69 +++++++++++++++++++++++++++++++ kernel/power/em_netlink.h | 26 ++++++++++++ 4 files changed, 136 insertions(+) create mode 100644 include/uapi/linux/energy_model.h create mode 100644 kernel/power/em_netlink.c create mode 100644 kernel/power/em_netlink.h diff --git a/include/uapi/linux/energy_model.h b/include/uapi/linux/energy_= model.h new file mode 100644 index 000000000000..42a19e614c7d --- /dev/null +++ b/include/uapi/linux/energy_model.h @@ -0,0 +1,40 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +#ifndef _UAPI_LINUX_ENERGY_MODEL_H +#define _UAPI_LINUX_ENERGY_MODEL_H + +/* Adding event notification support elements */ +#define EM_GENL_FAMILY_NAME "energy_model" +#define EM_GENL_VERSION 0x01 +#define EM_GENL_EVENT_GROUP_NAME "event" + +/* Attributes of em_genl_family */ +enum em_genl_attr { + EM_GENL_ATTR_UNSPEC, + __EM_GENL_ATTR_MAX, +}; +#define EM_GENL_ATTR_MAX (__EM_GENL_ATTR_MAX - 1) + +/* Events of em_genl_family */ +enum em_genl_event { + EM_GENL_EVENT_UNSPEC, + EM_GENL_EVENT_PD_CREATE, /* Performance domain creation */ + EM_GENL_EVENT_PD_DELETE, /* Performance domain deletion */ + EM_GENL_EVENT_PD_UPDATE, /* The runtime EM table for the + performance domain is updated */ + __EM_GENL_EVENT_MAX, +}; +#define EM_GENL_EVENT_MAX (__EM_GENL_EVENT_MAX - 1) + +/* Commands supported by the em_genl_family */ +enum em_genl_cmd { + EM_GENL_CMD_UNSPEC, + EM_GENL_CMD_PD_GET_ID, /* Get the list of information + for all performance domains */ + EM_GENL_CMD_PD_GET_TBL, /* Get the energy model table + of a performance domain */ + __EM_GENL_CMD_MAX, +}; +#define EM_GENL_CMD_MAX (__EM_GENL_CMD_MAX - 1) + + +#endif /* _UAPI_LINUX_ENERGY_MODEL_H */ diff --git a/kernel/power/Makefile b/kernel/power/Makefile index 874ad834dc8d..6bf157b5fffd 100644 --- a/kernel/power/Makefile +++ b/kernel/power/Makefile @@ -22,3 +22,4 @@ obj-$(CONFIG_PM_WAKELOCKS) +=3D wakelock.o obj-$(CONFIG_MAGIC_SYSRQ) +=3D poweroff.o =20 obj-$(CONFIG_ENERGY_MODEL) +=3D energy_model.o +obj-$(CONFIG_ENERGY_MODEL_NETLINK) +=3D em_netlink.o diff --git a/kernel/power/em_netlink.c b/kernel/power/em_netlink.c new file mode 100644 index 000000000000..30d83fb5a3a8 --- /dev/null +++ b/kernel/power/em_netlink.c @@ -0,0 +1,69 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * + * Generic netlink for energy model. + * + * Copyright (c) 2025 Valve Corporation. + * Author: Changwoo Min + */ + +#define pr_fmt(fmt) "energy_model: " fmt + +#include +#include +#include +#include + +#include "em_netlink.h" + +static const struct genl_multicast_group em_genl_mcgrps[] =3D { + [EM_GENL_EVENT_GROUP] =3D { .name =3D EM_GENL_EVENT_GROUP_NAME, }, +}; + +static const struct nla_policy em_genl_policy[EM_GENL_ATTR_MAX + 1] =3D { +}; + +static struct genl_family em_genl_family; + + +static int em_genl_cmd_doit(struct sk_buff *skb, struct genl_info *info) +{ + return -ENOTSUPP; +} + +static const struct genl_small_ops em_genl_ops[] =3D { + { + .cmd =3D EM_GENL_CMD_PD_GET_ID, + .validate =3D GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .doit =3D em_genl_cmd_doit, + }, + { + .cmd =3D EM_GENL_CMD_PD_GET_TBL, + .validate =3D GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, + .doit =3D em_genl_cmd_doit, + }, +}; + +static struct genl_family em_genl_family __ro_after_init =3D { + .hdrsize =3D 0, + .name =3D EM_GENL_FAMILY_NAME, + .version =3D EM_GENL_VERSION, + .maxattr =3D EM_GENL_ATTR_MAX, + .policy =3D em_genl_policy, + .small_ops =3D em_genl_ops, + .n_small_ops =3D ARRAY_SIZE(em_genl_ops), + .resv_start_op =3D __EM_GENL_CMD_MAX, + .mcgrps =3D em_genl_mcgrps, + .n_mcgrps =3D ARRAY_SIZE(em_genl_mcgrps), +}; + +int __init em_netlink_init(void) +{ + return genl_register_family(&em_genl_family); +} + +void __init em_netlink_exit(void) +{ + genl_unregister_family(&em_genl_family); +} + diff --git a/kernel/power/em_netlink.h b/kernel/power/em_netlink.h new file mode 100644 index 000000000000..8cedc6495916 --- /dev/null +++ b/kernel/power/em_netlink.h @@ -0,0 +1,26 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * + * Generic netlink for energy model. + * + * Copyright (c) 2025 Valve Corporation. + * Author: Changwoo Min + */ + +enum em_genl_multicast_groups { + EM_GENL_EVENT_GROUP =3D 0, + EM_GENL_MAX_GROUP =3D EM_GENL_EVENT_GROUP, +}; + +/* Netlink notification function */ +#ifdef CONFIG_ENERGY_MODEL_NETLINK +int __init em_netlink_init(void); +void __init em_netlink_exit(void); +#else +static inline int em_netlink_init(void) +{ + return 0; +} + +static inline void em_netlink_exit(void) {} +#endif /* CONFIG_ENERGY_MODEL_NETLINK */ --=20 2.49.0 From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A138B67A; Thu, 29 May 2025 00:13:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477636; cv=none; b=moWxWPJPVP1VjSZ3oVY+fqpS8i03nes7+TwdwGfa90vIDQ1HcK/6vJHWsAfWjZ9WRaM+h2GqecZC2IWJdrE4+ghSlTliuX8T8YmVE2/BQh0kkRIIpOmuGxHHWxshyqEDq/rgeF8czpVd5e0ZbzOYIjBrub9lmDZoVzHxTtfume0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477636; c=relaxed/simple; bh=1y2ZVOmO3FcC6g3Y3xnbSPeJjAN/V4jgxqazxePXTGw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TUeLoYS+2oIAJrInZkPXOaxW3pi7B6IjyZCydVnmKybzyemkN6vwOBg0XV79E9kwShVZc811SO62aFKd+/YV89fDZpbeuwkcCWveRmODBfrTlzxye9s3VPsGfsHItO0b6+9XLsSi2zvsbpShj603ljFR1SNnc/GdZ4GTO1OAtRo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=P3gq4JA/; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="P3gq4JA/" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FuEWsFWgmso91gJ4yulhACnmewxC84ZRX7NRO2lsVAE=; b=P3gq4JA/bkRiQYJqt+sEsHNylO G62MYHbAbgA1dXRd0m0LYr9OEOtI4WmHONr+kb7rcs1VuHu+qZbIc8lm9icfohVpteaMqS7YTcdpq EyIIcG94gLThHM9cMV8qcGyOfol37hIeJP+ewBZep9O9fOxQuGaCW7btWFi47R6ucn9YYZGIstGav qjmDoW0lccTLNjADvyoL3hPWgXnjJTryC+FZSrjpEFJSDinTVo11TGg9cyMEiNkIn4880JgV8XdxG YRVYZJebFgNsKaiWON3hpM3uQqcz5sNB+l5t6UWXb+PIsj2PPiuOaOAwpab2NNh95zfeNI2INxeOA s4fhkegg==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQu2-00EZvx-5f; Thu, 29 May 2025 02:13:47 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 03/11] PM: EM: Initialize the netlink notification during booting. Date: Thu, 29 May 2025 09:13:07 +0900 Message-ID: <20250529001315.233492-4-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Initialize and register the netlink during booting. The initialization is called at the postcore level, which is late enough after the generic netlink is initialized. Signed-off-by: Changwoo Min --- kernel/power/energy_model.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index ea7995a25780..b15b685c22bd 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -17,6 +17,8 @@ #include #include =20 +#include "em_netlink.h" + /* * Mutex serializing the registrations of performance domains and letting * callbacks defined by drivers sleep. @@ -936,3 +938,18 @@ void em_rebuild_sched_domains(void) */ schedule_work(&rebuild_sd_work); } + +static int __init em_init(void) +{ + int result; + + result =3D em_netlink_init(); + if (result) + goto error; + + return 0; + +error: + return result; +} +postcore_initcall(em_init); --=20 2.49.0 From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DD2BB67A; Thu, 29 May 2025 00:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477642; cv=none; b=ept0c/pZ5LSsI1qsuJbMP9+TGWRGwekLkFrjC+crLvc1rJP8c/gEqnsX7hznT9yYeNn63JarJDu24EhvZzneGct85B3HoZqiOS9OhteqRztKR9hfDj8tWhKX2J5sdXivDsNUW3o4UP0p5NCNvLSAflqbihLQdjBqNooBsU67VQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477642; c=relaxed/simple; bh=s55kvL81M6t2dqvawvXlqAz6LmeznoRLQGOWTuBVP7Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YgEduQlkvpFv/8e05zBHXAAF9PTkqdzpIG7BsGlEkfNeLWJKf54CXIwDFbS3FoSH/Vk0YKDFTyzSDb5orbD17qP4xZIq0T6nUuy73QukPaj2nDczI29qgbqnQx6XVW/8c/mXg+s49tLk7dwRnFtcI3YhbjlUxMFu21p2Qmvqdd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=QbVhsw1N; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="QbVhsw1N" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1O+rcdio6J6uZHO+lAjIDTKwuWkhySxmjhn8uaYvZ90=; b=QbVhsw1NVyS553ik4iDulYMNTl hp2htG5zbhzNLZ+CYTdkhryFnEYs82rGFSxnu2IxSZ1Mtfjpvp4vxXB2R/wQiPV0uvUG2WpbD6X6e ah/6nyxj9+uoC4OwQy5QJoRqHlfb0hgCbMDqycXCapRmdI3v+GMkbhVlKOv1LO/r9P1L1p+EC8/mf 27BTPAVGIHrIUOXrk0xd6SmSLy6Vtyp5DfBeamd1mYhcupbjfwHTIHb986FBJpXn6ACE0FWTgfhh3 Qu1fV0FXRq8BYPip0oqblQAfPGNVC3eTCMZzjPBC3hcV5I84Y2Odaav7MqEuowQqJSN6HkE/nALu3 6ecGNWSg==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQu8-00EZwG-Gr; Thu, 29 May 2025 02:13:53 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 04/11] PM: EM: Add the infrastructure for command processing. Date: Thu, 29 May 2025 09:13:08 +0900 Message-ID: <20250529001315.233492-5-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The infrastructure for command processing receives a command from a userspace and calls a callback corresponding to the request command. Note that the callback functions are just boilerplates in this commit, and the actual implementations will be provided in the following commits when a callback for a specific command is implemented. Signed-off-by: Changwoo Min --- kernel/power/em_netlink.c | 53 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/kernel/power/em_netlink.c b/kernel/power/em_netlink.c index 30d83fb5a3a8..edbaecebd0b4 100644 --- a/kernel/power/em_netlink.c +++ b/kernel/power/em_netlink.c @@ -23,14 +23,65 @@ static const struct genl_multicast_group em_genl_mcgrps= [] =3D { static const struct nla_policy em_genl_policy[EM_GENL_ATTR_MAX + 1] =3D { }; =20 +struct param { + struct nlattr **attrs; + struct sk_buff *msg; +}; + +typedef int (*cb_t)(struct param *); + static struct genl_family em_genl_family; =20 +/*************************** Command encoding ****************************= ****/ =20 -static int em_genl_cmd_doit(struct sk_buff *skb, struct genl_info *info) +static int em_genl_cmd_pd_get_id(struct param *p) { return -ENOTSUPP; } =20 +static int em_genl_cmd_pd_get_tbl(struct param *p) +{ + return -ENOTSUPP; +} + +static const cb_t cmd_cb[] =3D { + [EM_GENL_CMD_PD_GET_ID] =3D em_genl_cmd_pd_get_id, + [EM_GENL_CMD_PD_GET_TBL] =3D em_genl_cmd_pd_get_tbl, +}; + +static int em_genl_cmd_doit(struct sk_buff *skb, struct genl_info *info) +{ + struct param p =3D { .attrs =3D info->attrs }; + struct sk_buff *msg; + void *hdr; + int cmd =3D info->genlhdr->cmd; + int ret =3D -EMSGSIZE; + + msg =3D genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); + if (!msg) + return -ENOMEM; + p.msg =3D msg; + + hdr =3D genlmsg_put_reply(msg, info, &em_genl_family, 0, cmd); + if (!hdr) + goto out_free_msg; + + ret =3D cmd_cb[cmd](&p); + if (ret) + goto out_cancel_msg; + + genlmsg_end(msg, hdr); + + return genlmsg_reply(msg, info); + +out_cancel_msg: + genlmsg_cancel(msg, hdr); +out_free_msg: + nlmsg_free(msg); + + return ret; +} + static const struct genl_small_ops em_genl_ops[] =3D { { .cmd =3D EM_GENL_CMD_PD_GET_ID, --=20 2.49.0 From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0822F28399; Thu, 29 May 2025 00:14:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477649; cv=none; b=czrA5imDemfS/yjrhpuoGzJLMWZ+CoHZ8UNQd5ea9RJN5RMWyPJpXHZZbm5esEZi6vgmB09+nfYEVedUJhdpRKxxS/V8lv7DVyIFzzwz0RnrjgkaxoR+UhwrSNLXGAaOigdR3dl9gOogqFRD7ENZcmK/BjUDwkhOOZDaXI7wb9Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477649; c=relaxed/simple; bh=5iBVIy5wRtyFD5+cTC9jW4LzEKxOwEnEgIoZzPZ0Jfs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TzR7ipNk60tXzAFrJF6h3FvJ26YlIY7nCPQ+wCIW40RmTKRoeY5H5veJ8Ga+lWAguYZxnFb+AGCQPfwkDXFmjeGYI6IjUbowm5tEolt+5l+GM/DUbyUYphE2i8u9IsCTwk+CIce9WNzLAtfmIvjqmN6iW44ixcmppUPXdUFvrYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=QVuFRpwy; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="QVuFRpwy" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wHytLi3no870oNIyiqfAuwXzU1eXG/sMChGK6ZBkjtU=; b=QVuFRpwyfIZ/nUYj7cIdOrKDfv 3M3RwmLpAzxSBz2DdeaXi7cwUazyCQ8ZEuHe2NLggq5199Qum1q55xJon/WOsLroTon77FB1EfWUA D/63q5RjG6z/1QPFIg5ZiLsomGf5x7F2hJQlIKk2embK4vvxA+9i9P3fBGrggrU8s42GMIJLPLqUv sUasbiO+tm1cK+kW4eP50faX19hF/Fxz3MbOug4EwwVTaR6Jnvh2bnr2yUjodxFSW2MtJniWu8RLb mOO/WC2eidCIUAcoXH6r5u+lsTQJizjfoEU9XRZidm/TYIF+KM2qwijOpyBfq/cYiwRqlCSrXVvko o7vtfVhQ==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQuF-00EZwc-2T; Thu, 29 May 2025 02:14:00 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 05/11] PM: EM: Assign a unique ID when creating a performance domain. Date: Thu, 29 May 2025 09:13:09 +0900 Message-ID: <20250529001315.233492-6-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It is necessary to refer to a specific performance domain from a userspace. For example, the energy model of a particular performance domain is updated. To this end, assign a unique ID to each performance domain to address it, and manage them in a global linked list to look up a specific one by matching ID. IDA is used for ID assignment, and the mutex is used to protect the global list from concurrent access. Note that the mutex (em_pd_list_mutex) is not supposed to hold while holding em_pd_mutex to avoid ABBA deadlock. Signed-off-by: Changwoo Min --- include/linux/energy_model.h | 4 ++++ kernel/power/energy_model.c | 30 +++++++++++++++++++++++++++++- 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h index 7fa1eb3cc823..2f5c73fcdfe5 100644 --- a/include/linux/energy_model.h +++ b/include/linux/energy_model.h @@ -54,6 +54,8 @@ struct em_perf_table { /** * struct em_perf_domain - Performance domain * @em_table: Pointer to the runtime modifiable em_perf_table + * @node: node in em_pd_list (in energy_model.c) + * @id: A unique ID number for each performance domain * @nr_perf_states: Number of performance states * @min_perf_state: Minimum allowed Performance State index * @max_perf_state: Maximum allowed Performance State index @@ -71,6 +73,8 @@ struct em_perf_table { */ struct em_perf_domain { struct em_perf_table __rcu *em_table; + struct list_head node; + int id; int nr_perf_states; int min_perf_state; int max_perf_state; diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index b15b685c22bd..529f8a63ab3d 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -25,6 +25,16 @@ */ static DEFINE_MUTEX(em_pd_mutex); =20 +/* + * Manage performance domains with IDs. One can iterate the performance do= mains + * through the list and pick one with their associated ID. The mutex seria= lizes + * the list access. When holding em_pd_list_mutex, em_pd_mutex should not = be + * taken to avoid potential deadlock. + */ +static DEFINE_IDA(em_pd_ida); +static LIST_HEAD(em_pd_list); +static DEFINE_MUTEX(em_pd_list_mutex); + static void em_cpufreq_update_efficiencies(struct device *dev, struct em_perf_state *table); static void em_check_capacity_update(void); @@ -398,7 +408,7 @@ static int em_create_pd(struct device *dev, int nr_stat= es, struct em_perf_table *em_table; struct em_perf_domain *pd; struct device *cpu_dev; - int cpu, ret, num_cpus; + int cpu, ret, num_cpus, id; =20 if (_is_cpu_device(dev)) { num_cpus =3D cpumask_weight(cpus); @@ -422,6 +432,13 @@ static int em_create_pd(struct device *dev, int nr_sta= tes, =20 pd->nr_perf_states =3D nr_states; =20 + INIT_LIST_HEAD(&pd->node); + + id =3D ida_alloc(&em_pd_ida, GFP_KERNEL); + if (id < 0) + return -ENOMEM; + pd->id =3D id; + em_table =3D em_table_alloc(pd); if (!em_table) goto free_pd; @@ -446,6 +463,7 @@ static int em_create_pd(struct device *dev, int nr_stat= es, kfree(em_table); free_pd: kfree(pd); + ida_free(&em_pd_ida, id); return -EINVAL; } =20 @@ -641,6 +659,10 @@ int em_dev_register_perf_domain(struct device *dev, un= signed int nr_states, if (_is_cpu_device(dev)) em_check_capacity_update(); =20 + mutex_lock(&em_pd_list_mutex); + list_add_tail(&dev->em_pd->node, &em_pd_list); + mutex_unlock(&em_pd_list_mutex); + return ret; } EXPORT_SYMBOL_GPL(em_dev_register_perf_domain); @@ -659,6 +681,10 @@ void em_dev_unregister_perf_domain(struct device *dev) if (_is_cpu_device(dev)) return; =20 + mutex_lock(&em_pd_list_mutex); + list_del_init(&dev->em_pd->node); + mutex_unlock(&em_pd_list_mutex); + /* * The mutex separates all register/unregister requests and protects * from potential clean-up/setup issues in the debugfs directories. @@ -670,6 +696,8 @@ void em_dev_unregister_perf_domain(struct device *dev) em_table_free(rcu_dereference_protected(dev->em_pd->em_table, lockdep_is_held(&em_pd_mutex))); =20 + ida_free(&em_pd_ida, dev->em_pd->id); + kfree(dev->em_pd); dev->em_pd =3D NULL; mutex_unlock(&em_pd_mutex); --=20 2.49.0 From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC5724642D; Thu, 29 May 2025 00:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477654; cv=none; b=ZxYaW7x1Jo7qZXYnkjHVOnRsibbR5zbtcpp3tU5s9RggIaRrwnALorIWyXatTsPUDD72Av34T8/QPPZ9GxrsLyunORn1dbD9XbHtmXeK8sYaDogknjhLa2iC83IEbUxVZu7X/1LCUdu5/a4DbUbP6WLxUnCJU145L5YJ2RNjN/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477654; c=relaxed/simple; bh=fPmC+sf7hFuSga3JaCOOR+pbWUeKdP8Mf+qdd4uZBmo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OfW4sBXfUwYRI+EOR3Zxfr6wyFxlKh2BQHMra9Av1luFKasOi74gZjT7ttjwza1Qkrdc/iEZy9IcI4ATtK7Es1tanx+8uyIRLucp6Ue7npNnhV39AujQbbZ46wYz2yoY8/qO2+nKpO/i1ydbSZUa/t8fSRhq0p3JSta93Gc3mWk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=hJEouFOe; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="hJEouFOe" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PyyfjXDDjNfrkft1ylxTCOBf1BYeXJ3sHB4l4H6orC4=; b=hJEouFOekqCXsE3Qdqn+7wJ/ln c7lxd7Uq3d3F/3YLN6+EABptRGVujWSosM2fBkZbwc2pulfd2i6YIcrmQ2xgXaD3iuIyoIqQVtrXM wj4mtaXBEchgrOk4BV4sY2kuh2a4FSRqUGlSzWHCtAb0tIw034tjwpMmfRLZ3rH/BJNWvDLtg/BDY wBir/SvkU4Icii6JgARXmE6bsfw5XkPWYwx1q4auNMf7n1RqpzIAt0X5W9xfFarpOYJv3PicBx7iS wcVmnYRqc6irB/2JFx7BL0QhlwdBm+hS4uLQe+gJgMH9CyeH5cJgRGLZw1nBCM0zoBPkKlZMXM6AW eenTShQA==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQuL-00EZwr-AY; Thu, 29 May 2025 02:14:06 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 06/11] PM: EM: Expose the ID of a performance domain via debugfs. Date: Thu, 29 May 2025 09:13:10 +0900 Message-ID: <20250529001315.233492-7-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For ease of debugging, let's expose the assigned ID of a performance domain through debugfs (e.g., /sys/kernel/debug/energy_model/cpu0/id). Signed-off-by: Changwoo Min --- kernel/power/energy_model.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index 529f8a63ab3d..f441c9c1b848 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -128,6 +128,16 @@ static int em_debug_flags_show(struct seq_file *s, voi= d *unused) } DEFINE_SHOW_ATTRIBUTE(em_debug_flags); =20 +static int em_debug_id_show(struct seq_file *s, void *unused) +{ + struct em_perf_domain *pd =3D s->private; + + seq_printf(s, "%d\n", pd->id); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(em_debug_id); + static void em_debug_create_pd(struct device *dev) { struct em_dbg_info *em_dbg; @@ -144,6 +154,8 @@ static void em_debug_create_pd(struct device *dev) debugfs_create_file("flags", 0444, d, dev->em_pd, &em_debug_flags_fops); =20 + debugfs_create_file("id", 0444, d, dev->em_pd, &em_debug_id_fops); + em_dbg =3D devm_kcalloc(dev, dev->em_pd->nr_perf_states, sizeof(*em_dbg), GFP_KERNEL); if (!em_dbg) --=20 2.49.0 From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E266313AA2F; Thu, 29 May 2025 00:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477660; cv=none; b=WEEzlB4Ifz/YRVp/gAsk9Psrt8iva2b37gUPSFhDUsALlQN8EFkZA+i50rcibo3d9Nw5BakfvTBvBkJWCnQzIUoCfB/6jsCXVTFAz2jjg5jAVBDA70Ces3CBJ6G+oJJCQxdry6DC2qUSoJDSKnRAFe7zo6zvNMH4dSDkvs8shOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477660; c=relaxed/simple; bh=oXphYnvlY0+nEh9xNPWCHJQ+4m75zEIMbGD0n144zME=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L3FGlLx9YNjxn0ZygaP0C70YtBp2qgYDr0EpjBikygBxDXy92ceG4f6dzu/gBbHM8ULwp4dhD6ucY61m7ULJwhjqJjYQtFp7Th4PK/TiD0isbp+O8M8/8qqN0yPxvsVkQVaxz62ujH2YjW6BhBLg2324xDM6q5bYfcW/9T6KZhM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=KNSiZvIs; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="KNSiZvIs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Qz1POfkhqnx5JYyDkFz+Zt8jRmnUywERG2QJlsPbBtY=; b=KNSiZvIs6ypOHr09TspWbso8wg NfrVGyrY4rr9vdxPCb5/m/a/IJN1qO2Xa2coOjYdVyalZ+R5sYCN+6npwQyXPkhF0lXTuiq4+G69n Xjxi1EElaJMkAY4zO0eNeIPWKnFIhwQ4MHRhDnv8ykD9ynMckzhdJHDBc0DjWqGyY44nABgjMUVJ9 exxYEFAV9/JQv/lXa1qqHWzEWZ43Azrtxo3INVECCtEvl56hYqrp3iweAuH837Bppnd5NdjddQmeu kD2CefmSgcO8Tsdo2yUFTK1+ImooBHbfgI/HjXeXQ5stoGcZfB2FN0zp0BeMS7sQji7VwsKzQpd66 vMJpChUg==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQuR-00EZx8-PG; Thu, 29 May 2025 02:14:13 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 07/11] PM: EM: Add an iterator and accessor for the performance domain. Date: Thu, 29 May 2025 09:13:11 +0900 Message-ID: <20250529001315.233492-8-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add an iterator function (for_each_em_perf_domain) that iterates all the performance domains in the global list. A passed callback function (cb) is called for each performance domain. Additionally, add a lookup function (em_perf_domain_get_by_id) that searches for a performance domain by matching the ID in the global list. Signed-off-by: Changwoo Min --- include/linux/energy_model.h | 16 +++++++++++++++- kernel/power/energy_model.c | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+), 1 deletion(-) diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h index 2f5c73fcdfe5..26ed475cd3c4 100644 --- a/include/linux/energy_model.h +++ b/include/linux/energy_model.h @@ -341,6 +341,9 @@ struct em_perf_state *em_perf_state_from_pd(struct em_p= erf_domain *pd) return rcu_dereference(pd->em_table)->state; } =20 +int for_each_em_perf_domain(int (*cb)(struct em_perf_domain*, void *), + void *data); +struct em_perf_domain *em_perf_domain_get_by_id(int id); #else struct em_data_callback {}; #define EM_ADV_DATA_CB(_active_power_cb, _cost_cb) { } @@ -410,6 +413,17 @@ int em_update_performance_limits(struct em_perf_domain= *pd, } static inline void em_adjust_cpu_capacity(unsigned int cpu) {} static inline void em_rebuild_sched_domains(void) {} -#endif +static inline +int for_each_em_perf_domain(int (*cb)(struct em_perf_domain*, void *), + void *data) +{ + return -EINVAL; +} +static inline +struct em_perf_domain *em_perf_domain_get_by_id(int id) +{ + return NULL; +} +#endif /* CONFIG_ENERGY_MODEL */ =20 #endif diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index f441c9c1b848..6ed847046a2f 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -979,6 +979,40 @@ void em_rebuild_sched_domains(void) schedule_work(&rebuild_sd_work); } =20 +int for_each_em_perf_domain(int (*cb)(struct em_perf_domain*, void *), + void *data) +{ + struct em_perf_domain *pd; + + lockdep_assert_not_held(&em_pd_mutex); + guard(mutex)(&em_pd_list_mutex); + + list_for_each_entry(pd, &em_pd_list, node) { + int ret; + + ret =3D cb(pd, data); + if (ret) + return ret; + } + + return 0; +} + +struct em_perf_domain *em_perf_domain_get_by_id(int id) +{ + struct em_perf_domain *pd; + + lockdep_assert_not_held(&em_pd_mutex); + guard(mutex)(&em_pd_list_mutex); + + list_for_each_entry(pd, &em_pd_list, node) { + if (pd->id =3D=3D id) + return pd; + } + + return NULL; +} + static int __init em_init(void) { int result; --=20 2.49.0 From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787684642D; Thu, 29 May 2025 00:14:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477668; cv=none; b=KqTbEziURHWfts8cT4JdJ7slaJrPVsMNHgnxQq/DUy6r/bpgzW4ghnMyG5G52cuShy30eEcRSO8jz/EA4acQtg8xHiW+DRp3i9DfisC05bD8iFSqsdqdaaA2NCzRYSoqnioVZ0ID93LJK/t0wgEHZds1T7Vosxu6Y5kaiuFJMRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477668; c=relaxed/simple; bh=nCkkIey/nFRJZRwYiHlHKYCl+yrqwz3iupT25TX1JnY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qaPK2HSv5ws0D9EhBofMJNaBpIEdXRbj7qZdjbCmrvc/gIQsEF+aq/NA+Nj/8PbDPxJRlA/zoFePt97gzG8M8YW03T2UGkv0Di/TzQrebMJfX/IhRnOeng0B/GfPF1mQNOa+Kxo2ZekxCYKhJkaZZ519RJtKFFzYsuZmSSUtw4Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=LJ4kbhq3; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="LJ4kbhq3" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Rl4FC04SxH0qZTjzKBJVM7yZ3pqq7wX9bu8amclj5Zk=; b=LJ4kbhq3GessY4D8u8p9PDFE9V jY3EUMMrGz9t2nQEyJXMKmXfeVET5ytPVJNmtrB8EAYthjoaZxK1GzVXv4oy3vBlcJLJLzYeeJGK7 3Ob68bUnEX1BHeuAX7kbe3eESe0s0aKc4sGhjuLXYzl7lduyGh+aZZHkptCGOsvs6Y0kkkgkcZUXc LJQQkhovDovVPvXFxqB/v1kZILIg1Xj9KWAQROAb2JPVHRaqLtDtoQ+UJ3hCNiqkIO0ekCxPdWgA2 OhTn66m06w4N2zoJU6qN9587j68jOU0IsewYtSMSHrVatRTYvHfwpWX8IpuI5o4QpF6JyiuDvkkrV iUTgnthA==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQuY-00EZxP-UH; Thu, 29 May 2025 02:14:20 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 08/11] PM: EM: Implement EM_GENL_CMD_PD_GET_ID. Date: Thu, 29 May 2025 09:13:12 +0900 Message-ID: <20250529001315.233492-9-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a userspace requests EM_GENL_CMD_PD_GET_ID, the kernel responds with information on all performance domains. The message format of the response is as follows: EM_GENL_ATTR_PD (NLA_NESTED) EM_PD_ENTRY_GENL_ATTR_PD (NLA_NESTED)* EM_PD_GENL_ATTR_ID (NLA_U32) EM_PD_GENL_ATTR_FLAGS (NLA_U64) EM_PD_GENL_ATTR_CPUS (NLA_STRING) Where EM_PD_ENTRY_GENL_ATTR_PD can be repeated as many times as there are performance domains, and EM_PD_GENL_ATTR_CPUS is a hexadecimal string representing a CPU bitmask. Signed-off-by: Changwoo Min --- include/uapi/linux/energy_model.h | 25 ++++++++++++++ kernel/power/em_netlink.c | 55 ++++++++++++++++++++++++++++++- 2 files changed, 79 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/energy_model.h b/include/uapi/linux/energy_= model.h index 42a19e614c7d..66339ace6fcb 100644 --- a/include/uapi/linux/energy_model.h +++ b/include/uapi/linux/energy_model.h @@ -10,10 +10,35 @@ /* Attributes of em_genl_family */ enum em_genl_attr { EM_GENL_ATTR_UNSPEC, + EM_GENL_ATTR_PAD =3D EM_GENL_ATTR_UNSPEC, + EM_GENL_ATTR_PD, /* Performance domain */ __EM_GENL_ATTR_MAX, }; #define EM_GENL_ATTR_MAX (__EM_GENL_ATTR_MAX - 1) =20 +enum em_pd_entry_genl_attr { + EM_PD_ENTRY_GENL_ATTR_UNSPEC, + EM_PD_ENTRY_GENL_ATTR_PAD =3D EM_PD_ENTRY_GENL_ATTR_UNSPEC, + EM_PD_ENTRY_GENL_ATTR_PD, + __EM_PD_ENTRY_GENL_ATTR_MAX, +}; +#define EM_PD_ENTRY_GENL_ATTR_MAX (__EM_PD_ENTRY_GENL_ATTR_MAX - 1) + +enum em_pd_genl_attr { + EM_PD_GENL_ATTR_UNSPEC, + EM_PD_GENL_ATTR_PAD =3D EM_PD_GENL_ATTR_UNSPEC, + + /* Performance domain */ + EM_PD_GENL_ATTR_ID, + EM_PD_GENL_ATTR_FLAGS, + EM_PD_GENL_ATTR_CPUS, + + __EM_PD_GENL_ATTR_MAX, +}; +#define EM_PD_GENL_ATTR_MAX (__EM_PD_GENL_ATTR_MAX - 1) + +#define EM_PD_CPUS_LENGTH 256 + /* Events of em_genl_family */ enum em_genl_event { EM_GENL_EVENT_UNSPEC, diff --git a/kernel/power/em_netlink.c b/kernel/power/em_netlink.c index edbaecebd0b4..ea975ca6272f 100644 --- a/kernel/power/em_netlink.c +++ b/kernel/power/em_netlink.c @@ -21,6 +21,8 @@ static const struct genl_multicast_group em_genl_mcgrps[]= =3D { }; =20 static const struct nla_policy em_genl_policy[EM_GENL_ATTR_MAX + 1] =3D { + /* Performance domain */ + [EM_GENL_ATTR_PD] =3D { .type =3D NLA_NESTED }, }; =20 struct param { @@ -34,9 +36,60 @@ static struct genl_family em_genl_family; =20 /*************************** Command encoding ****************************= ****/ =20 +static int __em_genl_cmd_pd_get_id(struct em_perf_domain *pd, void *data) +{ + char cpus_buf[EM_PD_CPUS_LENGTH]; + struct sk_buff *msg =3D data; + struct nlattr *entry; + + entry =3D nla_nest_start(msg, EM_PD_ENTRY_GENL_ATTR_PD); + if (!entry) + goto out_cancel_nest; + + if (nla_put_u32(msg, EM_PD_GENL_ATTR_ID, pd->id)) + goto out_cancel_nest; + + if (nla_put_u64_64bit(msg, EM_PD_GENL_ATTR_FLAGS, pd->flags, + EM_PD_GENL_ATTR_PAD)) + goto out_cancel_nest; + + snprintf(cpus_buf, sizeof(cpus_buf), "%*pb", + cpumask_pr_args(to_cpumask(pd->cpus))); + if (nla_put_string(msg, EM_PD_GENL_ATTR_CPUS, cpus_buf)) + goto out_cancel_nest; + + nla_nest_end(msg, entry); + + return 0; + +out_cancel_nest: + nla_nest_cancel(msg, entry); + + return -EMSGSIZE; +} + static int em_genl_cmd_pd_get_id(struct param *p) { - return -ENOTSUPP; + struct sk_buff *msg =3D p->msg; + struct nlattr *start_pd; + int ret; + + start_pd =3D nla_nest_start(msg, EM_GENL_ATTR_PD); + if (!start_pd) + return -EMSGSIZE; + + ret =3D for_each_em_perf_domain(__em_genl_cmd_pd_get_id, msg); + if (ret) + goto out_cancel_nest; + + nla_nest_end(msg, start_pd); + + return 0; + +out_cancel_nest: + nla_nest_cancel(msg, start_pd); + + return ret; } =20 static int em_genl_cmd_pd_get_tbl(struct param *p) --=20 2.49.0 From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C1C8DF71; Thu, 29 May 2025 00:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477677; cv=none; b=W9LENPqmrcTcih6OyyZduSZIzKsGkhApu0b6ODgmbzvPZ8Z9OuIf41ReMYLhCm90gy1Pwkzv6bCLxFc78YU2yhTqQGs8BNHMlfNMhhgZuXi4XfNtMeuPs2BW+cHrmgu+N7f6VR69ksbPlkP6LSYg0fQFM1SdZP2crg4mCALViIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477677; c=relaxed/simple; bh=/ES+ABK9zEHGOiaJ/G0/yuQFNEKGNHacmFDdoCsxCzc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=buyP9FgfsVKDU0y9FCbNLHkjbbE34bu5RN5HJ6KKfFQ+f+4XwA8myMBt83wd3BM9HseRHblchu6qYMJabQdSDtK+VHRX89a5E7mK4PtcmTFvJre5q7SLkPlaZEBpjjAOucDkMDT+AFCmYtXFeRcq8I2I1ZIBK76c7DDe5Rh7kOo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=oQvsKvhP; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="oQvsKvhP" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TeA43xMymAu112mHxv3Y5f68/jrcu3+91rnd9QVJ/JU=; b=oQvsKvhPpF6DZIYN1gJPezWyIl edBsLcc8rWG9/64dEiYlITw3r7p3zXtzYVMiQm95sdSgFCWNVZw+GufZxXIGcPC0MPSHpBDTKHVEy YfmVgBBp7K8Zk4UeYBt+R4rCcUKx+0t+hTh0MaUragU+m/F5qHN63pYrh9OB1gNwjj5pByILPPUq6 dkBgLgBOhYFY8+2FoBudRp5joNLX4VI8Jk1iuuecErsmT9PBA3KLasq6yeR7zFtelkDR0eQOt67BQ t/bQ0s5L4EA1xw9OFEA4PFD9A94kA3FBKYeimAaryakkfBawGLLWOfF8BynVet74AvF9gGchCCOf3 aVw5zE4g==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQui-00EZxi-7A; Thu, 29 May 2025 02:14:29 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 09/11] PM: EM: Implement EM_GENL_CMD_PD_GET_TBL. Date: Thu, 29 May 2025 09:13:13 +0900 Message-ID: <20250529001315.233492-10-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a userspace requests EM_GENL_CMD_PD_GET_TBL with an ID of a performance domain, the kernel reports back the energy model table of the specified performance domain. The message format of the response is as follows: EM_GENL_ATTR_PD_TBL (NLA_NESTED) EM_TBL_ENTRY_GENL_ATTR_PD (NLA_NESTED)* EM_TBL_GENL_ATTR_PS_PERFORMANCE (NLA_U64) EM_TBL_GENL_ATTR_PS_FREQUENCY (NLA_U64) EM_TBL_GENL_ATTR_PS_POWER (NLA_U64) EM_TBL_GENL_ATTR_PS_COST (NLA_U64) EM_TBL_GENL_ATTR_PS_FLAGS (NLA_U64) Where EM_TBL_ENTRY_GENL_ATTR_PD can be repeated as many times as there are performance states (struct em_perf_state). Signed-off-by: Changwoo Min --- include/uapi/linux/energy_model.h | 24 ++++++++++++ kernel/power/em_netlink.c | 64 ++++++++++++++++++++++++++++++- 2 files changed, 87 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/energy_model.h b/include/uapi/linux/energy_= model.h index 66339ace6fcb..9517ca957a78 100644 --- a/include/uapi/linux/energy_model.h +++ b/include/uapi/linux/energy_model.h @@ -12,6 +12,7 @@ enum em_genl_attr { EM_GENL_ATTR_UNSPEC, EM_GENL_ATTR_PAD =3D EM_GENL_ATTR_UNSPEC, EM_GENL_ATTR_PD, /* Performance domain */ + EM_GENL_ATTR_PD_TBL, /* Performance table of a performance domain */ __EM_GENL_ATTR_MAX, }; #define EM_GENL_ATTR_MAX (__EM_GENL_ATTR_MAX - 1) @@ -39,6 +40,29 @@ enum em_pd_genl_attr { =20 #define EM_PD_CPUS_LENGTH 256 =20 +enum em_tbl_entry_genl_attr { + EM_TBL_ENTRY_GENL_ATTR_UNSPEC, + EM_TBL_ENTRY_GENL_ATTR_PAD =3D EM_TBL_ENTRY_GENL_ATTR_UNSPEC, + EM_TBL_ENTRY_GENL_ATTR_PD, + __EM_TBL_ENTRY_GENL_ATTR_MAX, +}; +#define EM_TBL_ENTRY_GENL_ATTR_MAX (__EM_TBL_ENTRY_GENL_ATTR_MAX - 1) + +enum em_tbl_genl_attr { + EM_TBL_GENL_ATTR_UNSPEC, + EM_TBL_GENL_ATTR_PAD =3D EM_TBL_GENL_ATTR_UNSPEC, + + /* Performance table of a performance domain */ + EM_TBL_GENL_ATTR_PS_PERFORMANCE, + EM_TBL_GENL_ATTR_PS_FREQUENCY, + EM_TBL_GENL_ATTR_PS_POWER, + EM_TBL_GENL_ATTR_PS_COST, + EM_TBL_GENL_ATTR_PS_FLAGS, + + __EM_TBL_GENL_ATTR_MAX, +}; +#define EM_TBL_GENL_ATTR_MAX (__EM_TBL_GENL_ATTR_MAX - 1) + /* Events of em_genl_family */ enum em_genl_event { EM_GENL_EVENT_UNSPEC, diff --git a/kernel/power/em_netlink.c b/kernel/power/em_netlink.c index ea975ca6272f..5f3d5aaa97d7 100644 --- a/kernel/power/em_netlink.c +++ b/kernel/power/em_netlink.c @@ -23,6 +23,8 @@ static const struct genl_multicast_group em_genl_mcgrps[]= =3D { static const struct nla_policy em_genl_policy[EM_GENL_ATTR_MAX + 1] =3D { /* Performance domain */ [EM_GENL_ATTR_PD] =3D { .type =3D NLA_NESTED }, + /* Performance table of a performance domain */ + [EM_GENL_ATTR_PD_TBL] =3D { .type =3D NLA_NESTED }, }; =20 struct param { @@ -94,7 +96,67 @@ static int em_genl_cmd_pd_get_id(struct param *p) =20 static int em_genl_cmd_pd_get_tbl(struct param *p) { - return -ENOTSUPP; + struct sk_buff *msg =3D p->msg; + struct em_perf_domain *pd; + struct em_perf_state *table, *ps; + struct nlattr *start_tbl, *entry; + int id, i; + + if (!p->attrs[EM_PD_GENL_ATTR_ID]) + return -EINVAL; + + id =3D nla_get_u32(p->attrs[EM_PD_GENL_ATTR_ID]); + + pd =3D em_perf_domain_get_by_id(id); + if (!pd) + return -EINVAL; + + start_tbl =3D nla_nest_start(msg, EM_GENL_ATTR_PD_TBL); + if (!start_tbl ) + return -EMSGSIZE; + + rcu_read_lock(); + table =3D em_perf_state_from_pd(pd); + + for (i =3D 0; i < pd->nr_perf_states; i++) { + ps =3D &table[i]; + + entry =3D nla_nest_start(msg, EM_TBL_ENTRY_GENL_ATTR_PD); + if (!entry) + goto out_cancel_nest; + + if (nla_put_u64_64bit(msg, EM_TBL_GENL_ATTR_PS_PERFORMANCE, + ps->performance, EM_TBL_GENL_ATTR_PAD)) + goto out_cancel_nest2; + if (nla_put_u64_64bit(msg, EM_TBL_GENL_ATTR_PS_FREQUENCY, + ps->frequency, EM_TBL_GENL_ATTR_PAD)) + goto out_cancel_nest2; + if (nla_put_u64_64bit(msg, EM_TBL_GENL_ATTR_PS_POWER, + ps->power, EM_TBL_GENL_ATTR_PAD)) + goto out_cancel_nest2; + if (nla_put_u64_64bit(msg, EM_TBL_GENL_ATTR_PS_COST, + ps->cost, EM_TBL_GENL_ATTR_PAD)) + goto out_cancel_nest2; + if (nla_put_u64_64bit(msg, EM_TBL_GENL_ATTR_PS_FLAGS, + ps->flags, EM_TBL_GENL_ATTR_PAD)) + goto out_cancel_nest2; + + nla_nest_end(msg, entry); + } + rcu_read_unlock(); + + nla_nest_end(msg, start_tbl); + + return 0; + +out_cancel_nest2: + nla_nest_cancel(msg, entry); + +out_cancel_nest: + rcu_read_unlock(); + + nla_nest_cancel(msg, start_tbl); + return -EMSGSIZE; } =20 static const cb_t cmd_cb[] =3D { --=20 2.49.0 From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE26E17BA9; Thu, 29 May 2025 00:14:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477684; cv=none; b=aHkW4a4UbAKxgFkuA6EwT7k0QmV2vxBs4XGtJITWdCrZywNlg+texBgHIp/ggk+pw+diE60sFin591/Vt8f7MzT7gjDRfabLxI8jxvJKrK1K7POL1qKk6c0EEb5U1jn6WtOEeX707DQC87+vOi4/ruyF7MD0fJpTqOGerEP2mhs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477684; c=relaxed/simple; bh=X0P8NsBm9MK5saruMk+zNqWtPEhduASS/LBeohCers4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UIPOAhpwNHsZqqqlBGZjgzNM7ARt91vXJRNwPqRQkC9CyNn03Zwfe4c6fo4Cuj9tFW91a4z7/mTUAVLlHB7AQK37AgrNE6JilhKMh096H0ox+no4oar6QZuwrc+y0ycI0QrJtzKBEjrVYGx/M+wExuXj+ZhWtk3ZBzmnO/xGWmg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=TGUKc0Ew; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="TGUKc0Ew" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rm5DPgOafYtL2trHXuvux751Nivwif0r+wnhFh4M6Bg=; b=TGUKc0EwwXjQwc6eA/Atqlr4GA nIoqo717qqKcHdfsWlkw3IX8p5nlV1PBuY65gJYHLS98G3IxIrRG7AHH6tSfUc939iPU3dG59sORq 6bG3ZPMEih4H4O3KfqCdnlG52bNGBLbi4SsLSi674vaD2Kyh6tMwqkj/YpOqGvhs5O/Is0VNKKtwU 0Z8tnQcm1wLlYfW679l4jZZcjCcYh+QkQEtuUlg/Do8cQw4iWHYIdv6zKtdzRCzVNExJrryY2XC6F WujDt/tzT0L0b6uVM2Z8Nh+03jD16E57nHDadZa3g65c9Y+k2dwPMry2HrxfPAb64UveRRbUQAE9h vvMh/4Ew==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQup-00EZxw-Ny; Thu, 29 May 2025 02:14:36 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 10/11] PM: EM: Implement event notification. Date: Thu, 29 May 2025 09:13:14 +0900 Message-ID: <20250529001315.233492-11-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the event notification infrastructure and implement event notifications for three events -- when a performance domain is created (EM_GENL_EVENT_PD_CREATE), deleted (EM_GENL_EVENT_PD_DELETE), or its energy model is updated (EM_GENL_EVENT_PD_UPDATE). The event contains the ID of the performance domain (EM_PD_GENL_ATTR_ID), so the userspace can identify the changed performance domain for further processing. Signed-off-by: Changwoo Min --- kernel/power/em_netlink.c | 89 +++++++++++++++++++++++++++++++++++++++ kernel/power/em_netlink.h | 19 +++++++++ 2 files changed, 108 insertions(+) diff --git a/kernel/power/em_netlink.c b/kernel/power/em_netlink.c index 5f3d5aaa97d7..85d4077ec1b3 100644 --- a/kernel/power/em_netlink.c +++ b/kernel/power/em_netlink.c @@ -30,12 +30,101 @@ static const struct nla_policy em_genl_policy[EM_GENL_= ATTR_MAX + 1] =3D { struct param { struct nlattr **attrs; struct sk_buff *msg; + int pd_id; }; =20 typedef int (*cb_t)(struct param *); =20 static struct genl_family em_genl_family; =20 +/**************************** Event encoding *****************************= ****/ +static int __em_genl_event_pd_id(struct param *p) +{ + if (nla_put_u32(p->msg, EM_PD_GENL_ATTR_ID, p->pd_id)) + return -EMSGSIZE; + + return 0; +} + +static int em_genl_event_pd_create(struct param *p) +{ + return __em_genl_event_pd_id(p); +} + +static int em_genl_event_pd_delete(struct param *p) +{ + return __em_genl_event_pd_id(p); +} + +static int em_genl_event_pd_update(struct param *p) +{ + return __em_genl_event_pd_id(p); +} + +static const cb_t event_cb[] =3D { + [EM_GENL_EVENT_PD_CREATE] =3D em_genl_event_pd_create, + [EM_GENL_EVENT_PD_DELETE] =3D em_genl_event_pd_delete, + [EM_GENL_EVENT_PD_UPDATE] =3D em_genl_event_pd_update, +}; + +static int em_genl_send_event(enum em_genl_event event, struct param *p) +{ + struct sk_buff *msg; + int ret =3D -EMSGSIZE; + void *hdr; + + if (!genl_has_listeners(&em_genl_family, &init_net, EM_GENL_EVENT_GROUP)) + return 0; + + msg =3D genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); + if (!msg) + return -ENOMEM; + p->msg =3D msg; + + hdr =3D genlmsg_put(msg, 0, 0, &em_genl_family, 0, event); + if (!hdr) + goto out_free_msg; + + ret =3D event_cb[event](p); + if (ret) + goto out_cancel_msg; + + genlmsg_end(msg, hdr); + + genlmsg_multicast(&em_genl_family, msg, 0, EM_GENL_EVENT_GROUP, GFP_KERNE= L); + + return 0; + +out_cancel_msg: + genlmsg_cancel(msg, hdr); +out_free_msg: + nlmsg_free(msg); + + return ret; +} + +int em_notify_pd_create(const struct em_perf_domain *pd) +{ + struct param p =3D { .pd_id =3D pd->id }; + + return em_genl_send_event(EM_GENL_EVENT_PD_CREATE, &p); +} + + +int em_notify_pd_delete(const struct em_perf_domain *pd) +{ + struct param p =3D { .pd_id =3D pd->id }; + + return em_genl_send_event(EM_GENL_EVENT_PD_DELETE, &p); +} + +int em_notify_pd_update(const struct em_perf_domain *pd) +{ + struct param p =3D { .pd_id =3D pd->id }; + + return em_genl_send_event(EM_GENL_EVENT_PD_UPDATE, &p); +} + /*************************** Command encoding ****************************= ****/ =20 static int __em_genl_cmd_pd_get_id(struct em_perf_domain *pd, void *data) diff --git a/kernel/power/em_netlink.h b/kernel/power/em_netlink.h index 8cedc6495916..34d5a98eec72 100644 --- a/kernel/power/em_netlink.h +++ b/kernel/power/em_netlink.h @@ -16,6 +16,10 @@ enum em_genl_multicast_groups { #ifdef CONFIG_ENERGY_MODEL_NETLINK int __init em_netlink_init(void); void __init em_netlink_exit(void); + +int em_notify_pd_create(const struct em_perf_domain *pd); +int em_notify_pd_delete(const struct em_perf_domain *pd); +int em_notify_pd_update(const struct em_perf_domain *pd); #else static inline int em_netlink_init(void) { @@ -23,4 +27,19 @@ static inline int em_netlink_init(void) } =20 static inline void em_netlink_exit(void) {} + +static inline int em_notify_pd_create(const struct em_perf_domain *pd) +{ + return 0; +} + +static inline int em_notify_pd_delete(const struct em_perf_domain *pd) +{ + return 0; +} + +static inline int em_notify_pd_update(const struct em_perf_domain *pd) +{ + return 0; +} #endif /* CONFIG_ENERGY_MODEL_NETLINK */ --=20 2.49.0 From nobody Tue Dec 16 14:52:43 2025 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7886D219E8; Thu, 29 May 2025 00:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477691; cv=none; b=LUtzCBzfRZ6eVXxWbzw97TeH/MDVouBsiwwW5TMYQTP5zUri/aUP8oaCYQZ4pBU2kXS+YXTpxw9UMViI7VOVFlXEeQ5yS/0zD7wWlB5bRFCRMTapHUhMkB9r89NOqqcaXkBWW1fPT6fRn4TF6YSdReslVnu9MQTCkX5VEdrnTNc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748477691; c=relaxed/simple; bh=jcSTdB8cYTgK7fXz9q7Lo3F6qxZZiKZrm/tD702Jhbc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lg+FriAaDgssYgEkw8U4yp8ObVOTjKd0JXl75UZdSwg6YBgFR3L8AecT2Wx6P53cyxjDSHzqbpsdooXLTreboMZq00IOI7w5DeJfwaWzF+gyyF40a7OhfCw/lDJP1Yw6tw3YTn0aiux3YhVuvL1CGffw2Qa+ULjKLHOfYM4Vkho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=kEgaKK/Q; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="kEgaKK/Q" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sJHUUz+5d/oc9AFid9FJLsG4+QoSnBTtVC2wDx4OwSA=; b=kEgaKK/QRe4PmNcW+bdMI++Y56 TsYxIf0T0clOK4nlwWGsFxvC9d9rTqiWHICY50sIW/FO4UuaN6t1Q6cLE5daiUcxDQ/wz7BtTTRkL qSTm+q/ZUPydRjzPspDQ4b1dvHX2zYxgNeCIrlBzltJqERvXXVYyUmtbYjCtOlBaAtHV+GXE8RG5n ZO1Lqc5q9LXHB5Id8nGSo3GYkIIp00uGNW98PG1eiUZNLDcWHyTn9yivvOmmCHojcAnbUQrzRRkSw LRiiAxOqhqYeyQfGrsvPfCrFlMnPBXOZ0KeKkYMVtLL2Jam4I3hBhR41By3p+vAzg0872HvNlDmOj 0BRUi/xA==; Received: from [58.29.143.236] (helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uKQuw-00EZy4-2f; Thu, 29 May 2025 02:14:43 +0200 From: Changwoo Min To: lukasz.luba@arm.com, rafael@kernel.org, len.brown@intel.com, pavel@kernel.org Cc: christian.loehle@arm.com, tj@kernel.org, kernel-dev@igalia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Changwoo Min Subject: [PATCH 11/11] PM: EM: Notify an event when the performance domain changes. Date: Thu, 29 May 2025 09:13:15 +0900 Message-ID: <20250529001315.233492-12-changwoo@igalia.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529001315.233492-1-changwoo@igalia.com> References: <20250529001315.233492-1-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Send an event to userspace when a performance domain is created or deleted, or its energy model is updated. Signed-off-by: Changwoo Min --- kernel/power/energy_model.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index 6ed847046a2f..5764821faef3 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -352,6 +352,8 @@ int em_dev_update_perf_domain(struct device *dev, em_table_free(old_table); =20 mutex_unlock(&em_pd_mutex); + + em_notify_pd_update(pd); return 0; } EXPORT_SYMBOL_GPL(em_dev_update_perf_domain); @@ -675,6 +677,8 @@ int em_dev_register_perf_domain(struct device *dev, uns= igned int nr_states, list_add_tail(&dev->em_pd->node, &em_pd_list); mutex_unlock(&em_pd_list_mutex); =20 + em_notify_pd_create(dev->em_pd); + return ret; } EXPORT_SYMBOL_GPL(em_dev_register_perf_domain); @@ -697,6 +701,8 @@ void em_dev_unregister_perf_domain(struct device *dev) list_del_init(&dev->em_pd->node); mutex_unlock(&em_pd_list_mutex); =20 + em_notify_pd_delete(dev->em_pd); + /* * The mutex separates all register/unregister requests and protects * from potential clean-up/setup issues in the debugfs directories. --=20 2.49.0