From nobody Fri Dec 19 13:05:04 2025 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C90822D9F4 for ; Thu, 29 May 2025 16:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748537636; cv=none; b=UW0tnTXcU2GtlD1PLUqSu5jdnMY3u6zq7naxnFC+fAkshLAEKZw8nHX/NXMCJ6ywtfdEP83/TyYYRu9Kt1+Sjw0RdCifJZ3x884SbYUFnT3XDv94ar/+Re1IcZHv3QDQpaGGR4on+msUWNNgzXp16YetDLPlfQocFjlO8d1syiA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748537636; c=relaxed/simple; bh=m2++tAofmXWGUZrY+VkUzUvQUkMhh6m/iSTYLIecuYw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NhdVGU3vWuXQc7M1UAv8hsBmLMbVO5Eb24Zxc2+dAf2fJMb8ilSTJ3uNlNZSqLl6Mnq71zRQGt4lm16wwj1pFHNtL9i9l1cpy4lsUWdz+p/stOdEorNY98ETOvUde+aidvl23qAUn3loP2LNq9An/icn8y2Zc9QoWc1QltClGNg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=RgcOU+NP; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="RgcOU+NP" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-72ec926e828so293013a34.0 for ; Thu, 29 May 2025 09:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1748537633; x=1749142433; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dvZkXcKyoi2ZArZGC/DSueRrfUVGqS+N3BatqzSSLnI=; b=RgcOU+NPgs6AqqBJY/UiwFmFe8P1fDbCoHR0z86lAquamsSKcAruCDgG5nRUgDS5ET 97Eycjvz3L+vUcpkF0OGwQN9YaMmjRAjl8tAn/n7C2myN91Xv5o6lHHPox/4SJwNZrb3 CO5Iu6rxQh43YgMHKRMTHC0K44aqGY3msR3WIajDAVxzoRj17A4iQayJQ8SLCRokQrmP traVYdhIyanH94Vf7YTtXkxn4l5Z7wxSX3438tA2ACsZzxxhRJWA1obrRENVNqTrrHjV vNWMA8VftW57OlqosxrBcb1UZUMaCyFOGOW+zLPUCyAhvSl1sQ1U1l7JFEeI6vMIT7DK fc+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748537633; x=1749142433; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dvZkXcKyoi2ZArZGC/DSueRrfUVGqS+N3BatqzSSLnI=; b=KzpFKVJC4hJ+dUFftgC68jh90JRez3rHx7+4nMpCpWyFN0NOl8hp0IpJiHzImsQ6xr d28WET/GuMxPty0kTEe32VPHWqzT9+5Di37m3+s0XnUCt72cZGaDKPJ+CRy9Fo+V41zk iq6bQ5agWmk86iRnrdo5Pgv4tsGtzaWscdvnH8dgUagZc/GRlVIQIb7fMLwdulvIwfIy S2E5mGV84bISROL4y8B5hG2mbS91tfTSQhuVx/Gojzb/2r4KiOa4ec2B1Iv5hbTFmbnE oiiY2GnaP2wYj2yAdywgw8lOjEZKoUCyAQ0J1ERMuBnjzduphroCMfcN7VDDy3vnD1Ni nt+Q== X-Forwarded-Encrypted: i=1; AJvYcCWAr76B5/DJquzchdRCTRueBHwlD1ZwSHx52WfDx3n9K2k5IB7vQg5fI3v6yi0JgaBznNkUQ9d5rnNxC7w=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7P++mO1KpkBdOtcgVjNpmVx+YXxxIRFM42C+9L6Q7KZn5qXZv EEfPEC0ADu06r0amrCgVrRE3R6gmBhUW0XT3/RJV1UeGsoWASykmHRA7+N1rHfUDTG8yG9aTErg s6Dd2 X-Gm-Gg: ASbGncuBOPeM5wuc/nCKqH5rlrwNHBazgtzchB5ou3P5eoUXyenBNCA7SxniL3CPJlU aOT9mzFEU57wrTmWDJFwgL8Q8zTsHsL+hTDHawCgAyM6iyy3bLQFtSLQ6fLJGWA4rFUIUww+Cw5 1lbrQ5XT3i52VO6GYidE+qvsW4X4VLOW6/OCf8oKIfKpefLCR4GWWSZ9mNA8CK9fqhjDrXVyAyF 77qeXkUaxL+wDrLu0/2rIcDZltBdCtV70Nf3JpS0IZrOAIqGdtzOD6kqftiXgkLuCw/WWOJoKOq CW5ZhWQOCsuLJCwSObHwN/1JPK4tb/DH0MvwxOJMlQNXjDSOaCU4MOj/ X-Google-Smtp-Source: AGHT+IG4fIZm0J6PMyZg22loZMmxJxYbkdzOAE3YNy3sBQoYUzpwZdMfEk4mmrj7fzK98RObdcEQ9A== X-Received: by 2002:a05:6830:3c8c:b0:72c:3289:ab9e with SMTP id 46e09a7af769-7367d61d9e0mr4418a34.27.1748537633425; Thu, 29 May 2025 09:53:53 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:928b:5d5c:6cd9:1a4]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-735af82d2b8sm303265a34.3.2025.05.29.09.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 09:53:53 -0700 (PDT) From: David Lechner Date: Thu, 29 May 2025 11:53:19 -0500 Subject: [PATCH v3 2/3] dt-bindings: pwm: adi,axi-pwmgen: fix clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250529-pwm-axi-pwmgen-add-external-clock-v3-2-5d8809a7da91@baylibre.com> References: <20250529-pwm-axi-pwmgen-add-external-clock-v3-0-5d8809a7da91@baylibre.com> In-Reply-To: <20250529-pwm-axi-pwmgen-add-external-clock-v3-0-5d8809a7da91@baylibre.com> To: Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Trevor Gamblin , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Lechner Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1887; i=dlechner@baylibre.com; h=from:subject:message-id; bh=m2++tAofmXWGUZrY+VkUzUvQUkMhh6m/iSTYLIecuYw=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoOJESup4Vmlos5i9b6wR3bA0dBPjXStd6d95Xo IJODVKd0lOJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaDiREgAKCRDCzCAB/wGP wBV+CACOeHYAly2vTDSLtIbL22NA22l8/evjmXjwD2P1B6H6UPo7QhMTVKN+99BexVf7i7pOJtX G9Sw6czICNL7IkFgXXIyP+6lrfKkT9GUrzcG/PUuLMErfgnwEappBbRN5bxmXWrZhzzh6jrS7R1 UFXtfTiSGC6EzEzml4l1qdo4T8Qq4fBnyQSKfJadKznzJmKlxpWNeFl3NOM91KZwGIk+x0WMejS ppRJDUwju/0c8EiczCJPYaBV+tEvS3OZlYvw7id5gKWsZL1ibtnqFbSmAZer11GrfQ1PsWBpmox brCXbRfbYz/G6/9eCzzA9gkyGvJ5UPPwK6HMJ2Q4H2DlF/4Q X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Fix a shortcoming in the bindings that doesn't allow for a separate external clock. The AXI PWMGEN IP block has a compile option ASYNC_CLK_EN that allows the use of an external clock for the PWM output separate from the AXI clock that runs the peripheral. This was missed in the original bindings and so users were writing dts files where the one and only clock specified would be the external clock, if there was one, incorrectly missing the separate AXI clock. The correct bindings are that the AXI clock is always required and the external clock is optional (must be given only when HDL compile option ASYNC_CLK_EN=3D1). Cc: stable@vger.kernel.org Fixes: 1edf2c2a2841 ("dt-bindings: pwm: Add AXI PWM generator") Signed-off-by: David Lechner Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml | 13 +++++++++++= -- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Do= cumentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml index bc44381692054f647a160a6573dae4cff2ee3f31..e4c2d5186dedb18701af74bbc95= 7b82a2b0f8737 100644 --- a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml @@ -30,11 +30,19 @@ properties: const: 3 =20 clocks: - maxItems: 1 + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + items: + - const: axi + - const: ext =20 required: - reg - clocks + - clock-names =20 unevaluatedProperties: false =20 @@ -43,6 +51,7 @@ examples: pwm@44b00000 { compatible =3D "adi,axi-pwmgen-2.00.a"; reg =3D <0x44b00000 0x1000>; - clocks =3D <&spi_clk>; + clocks =3D <&fpga_clk>, <&spi_clk>; + clock-names =3D "axi", "ext"; #pwm-cells =3D <3>; }; --=20 2.43.0