From nobody Wed Feb 11 06:50:01 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D611207DFE for ; Thu, 29 May 2025 23:15:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748560526; cv=none; b=jnj1xgvetNv+dEX+IEvrcHHwEHpAis1D2f04FaOg1hY7TrtCHHFPON9jIKUSSmlQVdyQAUb6hvGIqLKga67kauoneAIjGjaAmRVQCjtWOo/tOw5m52aIPtKCog5EbRimdvHLsGUZL19cBeo/rc759z0qw4t8A009jBHssIi0z/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748560526; c=relaxed/simple; bh=ncFUgjCcjLVp47mdzw5AlWfZzY/iqv0NdO8zjQXSoI4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kt33MtsNaiCy0oxd0BjS/ctDDR6A46b7NsSs6KHyzJ3Pc4yemqq/aNk1rAFym8NpycX5NsCLSYMgeuHHQOQ5ZyBLNXQtnrcdgxwu6tYTStrhyIzdH74P97ODAq/0rDstFYaDGM3qZozfpaeNmKYQMYBStERgeeDSrkHbEuEP0J4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZcHQc3rv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZcHQc3rv" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54TC1WYr014290 for ; Thu, 29 May 2025 23:15:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= w9T6LjH71u9zQzlGudP+qBcjCF5Cn/3FIBo8ObljvB4=; b=ZcHQc3rvA7phTslz WQBad+h15HW1V9ljZeSKT6KzIE0xo4633oqLhZPzdLJbRnPtnfw5qc5BLc6cawzt 5CxoqKAvxiSZU7dEoULAmD0ohmR31RfZwo3Y1dNauszmHoGIsOFylGhJxGovR0pE 41Ryfa4f1DtYM7TDDkSWCppkuPUenm3nQWr+tc5FlwGp1lrVv0SkfyDs8RGI96ik avhGIhnNCOwFxV1fGXy1M4pL6ddHcKKHhed9QCvhQ1ha6UB1Oeq0c5Ly7H27Dmc/ AKxCcjk3HdYUjZ7jcPMSuCARjusr0B7oMCdgi+vkR/8antwimGlXAKx807SHbSyI L5Glcw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46wavm11th-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 29 May 2025 23:15:24 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b0f807421c9so953941a12.0 for ; Thu, 29 May 2025 16:15:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748560523; x=1749165323; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w9T6LjH71u9zQzlGudP+qBcjCF5Cn/3FIBo8ObljvB4=; b=kxBkLOLzctVwW2Berp3QXyPsbV0l4/vQ0J/b8ZmHVlt1PL+pU84l7mpnUUX5trP0ez CVyRYOjrt1NtX84z52S4svEMu6OBGgwYaiQT0Sk0ZoU6dAnL1wwx64XYWmNO4xPu3cG3 WHtpgxf6wZqFWtAkD9DbuWcdLA9Mk7GBrPBdKrdJoY2kRa6JnffRu52l6+1pyh9+c221 cDBq2kiwFncitqY3wJpvIwdUV+V5cIlucP6JZwfAASacmlJ+d2u2wPKJkUEBfuyta39L 9n6KzvazxPzZ3U9RSPJlPJYNI+quY4B7QpMxhQ3y0Yngo6ZeErGPi6fydZ3k50VmhY0s Z9OQ== X-Forwarded-Encrypted: i=1; AJvYcCVwEuo5r6jzlHDqThOBBJOcuTm04CCZAfqKpEqw8Y9II3/MXBtVYYJ89AdIASACylVgBotBoNrEU0c+L2I=@vger.kernel.org X-Gm-Message-State: AOJu0YzSmmfO2fgFyVhPjAfulVhyuseUBF8LKo12iwlNtdun2IhAPlO3 ru1JN3DhkcGGz1Ynq0a8+7iBvbYNBeCyxluEVBECbo71y1TNhfTJlg4TKFC8608KE6bOp1VVXda /KNQLkCR7QiG3Q7YZ4d/TY2WyQBjYIADkI+X1mT2E+Dg2SVq1uOKLr4cutcx1MtJxc36U9M/pIL M= X-Gm-Gg: ASbGncvX/ZKS9d3CLA6gFzuE+7jwhuKOoxhaGhea8TtT4Ndw0s65TFG65C1FQhbq2sd MAwJ2/1cM2vNagNgNMZpv7j5AQd+AqPFtgBf7MGP2cM4sNHDkbNfeifd3qzn5ceBbZ2VwkE5GdY 15t97BmKevzeR2HoaeCqT1wqUIIOnMYBpWkyOHozf5TlrTov9pIcoOeGGGHJ1snrChEQgy8TKbr CQp5KQaepOsChXyONgqbkJaCpNF/FxwZadCf8y0odIiWDDYCZjI/omkRleD/4bp+jRVIAJeYAIY DWbiNEQYenFU7Z1s7QOroivjhyAiUc0laj12s/7lWE00apZKhqSnXs6GU5mRWlUxDD1raGyc X-Received: by 2002:a17:90b:180b:b0:2f6:dcc9:38e0 with SMTP id 98e67ed59e1d1-3123efab981mr2365853a91.0.1748560523497; Thu, 29 May 2025 16:15:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGO6kVlTul5XfVExNVHlCfMfXtoSx3A+pScknURIeoMKwp8UajMgtsqcqSsCFhBesXHbzaNgA== X-Received: by 2002:a17:90b:180b:b0:2f6:dcc9:38e0 with SMTP id 98e67ed59e1d1-3123efab981mr2365796a91.0.1748560523026; Thu, 29 May 2025 16:15:23 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e1f3f22sm73581a91.0.2025.05.29.16.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 16:15:22 -0700 (PDT) From: Jessica Zhang Date: Thu, 29 May 2025 16:13:43 -0700 Subject: [PATCH 1/4] drm/msm/dp: remove redundant checks related to ST_DISPLAY_OFF in plug/irq_ipd handlers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250529-hpd_display_off-v1-1-ce33bac2987c@oss.qualcomm.com> References: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com> In-Reply-To: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com> To: Rob Clark , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Abhinav Kumar , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stephen Boyd , Doug Anderson , Johan Hovold , Bjorn Andersson , Abhinav Kumar , linux-kernel@vger.kernel.org, Yongxing Mou , Jessica Zhang , Dmitry Baryshkov X-Mailer: b4 0.15-dev-64971 X-Developer-Signature: v=1; a=ed25519-sha256; t=1748560520; l=2307; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=iZ6m38kGUh6Wu9/l4YZxdyErgIvmhQUC45GosLwQHF4=; b=JzwNwtaiIIBM44Wr7k3CgOFsd6RO8xdIk4KnRV24BqdwI98BPsxzhcx12py1hq5JImcnhpaHq ewjnk+F5+XNDjmSGQssJk40wWDDN1VwB18kGz3ZAu0MJUSg9qNEa3Z9 X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-GUID: 8RsKQ5CD3CdpcI7WnzB_Y6kOqJdz7rD1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI5MDIyNyBTYWx0ZWRfXxQmRMScl2D4I 9HkrVFI10yWXJfzQZTEnk8FbTIeeCbuMUFNQtAg7BosyRKaskj7uwUoIF98Ie6d6QVgw+q8Zd45 RvhcAgkHOwFB+GinAca+SGQOY5c1iAAD7KDw0c9Fd0aMia0/4mrUJ0HX6YxZXM3TerL/Lk9Xp9q a52qrSfso/XRTG3hGtJmztCv0RuZN9DIeYeRcyTWNNvIWUq0z1JM2frGC9+E1UT9p9WLkpT5vsW JMlmjt05KAjSUpR+FC8eDm+kGjWszGg/YTM2cY+EoR6FfVObctLZDlr7PxVEsgcFKapzjdj8QDk Jyntnt4art/5k0Fb9lidTQj4q91tYCHfxsmHI+Ldhx0QwLL5jMd7C36rcf+ktPNdR6+DxgplS38 KVnpyz7WP0g7FbCt+tZ07XlJrddd0RA/74R22clWrz1NLx7fJ5zhxyFwelqK89tPN/7uw6T1 X-Authority-Analysis: v=2.4 cv=fMk53Yae c=1 sm=1 tr=0 ts=6838ea8c cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=PbHRmTaTmGSOozFvvjEA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=TjNXssC_j7lpFel5tvFf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 8RsKQ5CD3CdpcI7WnzB_Y6kOqJdz7rD1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-29_10,2025-05-29_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505290227 From: Abhinav Kumar In commit 8ede2ecc3e5ee ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets"), checks were introduced to avoid handling any plug or irq hpd events in ST_DISPLAY_OFF state. Even if we do get hpd events, after the bridge was disabled, it should get handled. Moreover, its unclear under what circumstances these events will fire because ST_DISPLAY_OFF means that the link was still connected but only the bridge was disabled. If the link was untouched, then interrupts shouldn't fire. Even in the case of the DP compliance equipment, it should be raising these interrupts during the start of the test which is usually accompanied with either a HPD pulse or a IRQ HPD but after the bridge is disabled it should be fine to handle these anyway. In the absence of a better reason to keep these checks, drop these and if any other issues do arise, it should be handled in a different way. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 386c4669c831..1d7cda62d5fb 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -579,11 +579,6 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_displa= y_private *dp, u32 data) drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", dp->msm_dp_display.connector_type, state); =20 - if (state =3D=3D ST_DISPLAY_OFF) { - mutex_unlock(&dp->event_mutex); - return 0; - } - if (state =3D=3D ST_MAINLINK_READY || state =3D=3D ST_CONNECTED) { mutex_unlock(&dp->event_mutex); return 0; @@ -706,11 +701,6 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display= _private *dp, u32 data) drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", dp->msm_dp_display.connector_type, state); =20 - if (state =3D=3D ST_DISPLAY_OFF) { - mutex_unlock(&dp->event_mutex); - return 0; - } - if (state =3D=3D ST_MAINLINK_READY || state =3D=3D ST_DISCONNECT_PENDING)= { /* wait until ST_CONNECTED */ msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 1); /* delay =3D 1 */ --=20 2.49.0