From nobody Wed Feb 11 05:28:55 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D611207DFE for ; Thu, 29 May 2025 23:15:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748560526; cv=none; b=jnj1xgvetNv+dEX+IEvrcHHwEHpAis1D2f04FaOg1hY7TrtCHHFPON9jIKUSSmlQVdyQAUb6hvGIqLKga67kauoneAIjGjaAmRVQCjtWOo/tOw5m52aIPtKCog5EbRimdvHLsGUZL19cBeo/rc759z0qw4t8A009jBHssIi0z/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748560526; c=relaxed/simple; bh=ncFUgjCcjLVp47mdzw5AlWfZzY/iqv0NdO8zjQXSoI4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kt33MtsNaiCy0oxd0BjS/ctDDR6A46b7NsSs6KHyzJ3Pc4yemqq/aNk1rAFym8NpycX5NsCLSYMgeuHHQOQ5ZyBLNXQtnrcdgxwu6tYTStrhyIzdH74P97ODAq/0rDstFYaDGM3qZozfpaeNmKYQMYBStERgeeDSrkHbEuEP0J4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZcHQc3rv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZcHQc3rv" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54TC1WYr014290 for ; Thu, 29 May 2025 23:15:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= w9T6LjH71u9zQzlGudP+qBcjCF5Cn/3FIBo8ObljvB4=; b=ZcHQc3rvA7phTslz WQBad+h15HW1V9ljZeSKT6KzIE0xo4633oqLhZPzdLJbRnPtnfw5qc5BLc6cawzt 5CxoqKAvxiSZU7dEoULAmD0ohmR31RfZwo3Y1dNauszmHoGIsOFylGhJxGovR0pE 41Ryfa4f1DtYM7TDDkSWCppkuPUenm3nQWr+tc5FlwGp1lrVv0SkfyDs8RGI96ik avhGIhnNCOwFxV1fGXy1M4pL6ddHcKKHhed9QCvhQ1ha6UB1Oeq0c5Ly7H27Dmc/ AKxCcjk3HdYUjZ7jcPMSuCARjusr0B7oMCdgi+vkR/8antwimGlXAKx807SHbSyI L5Glcw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46wavm11th-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 29 May 2025 23:15:24 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b0f807421c9so953941a12.0 for ; Thu, 29 May 2025 16:15:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748560523; x=1749165323; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w9T6LjH71u9zQzlGudP+qBcjCF5Cn/3FIBo8ObljvB4=; b=kxBkLOLzctVwW2Berp3QXyPsbV0l4/vQ0J/b8ZmHVlt1PL+pU84l7mpnUUX5trP0ez CVyRYOjrt1NtX84z52S4svEMu6OBGgwYaiQT0Sk0ZoU6dAnL1wwx64XYWmNO4xPu3cG3 WHtpgxf6wZqFWtAkD9DbuWcdLA9Mk7GBrPBdKrdJoY2kRa6JnffRu52l6+1pyh9+c221 cDBq2kiwFncitqY3wJpvIwdUV+V5cIlucP6JZwfAASacmlJ+d2u2wPKJkUEBfuyta39L 9n6KzvazxPzZ3U9RSPJlPJYNI+quY4B7QpMxhQ3y0Yngo6ZeErGPi6fydZ3k50VmhY0s Z9OQ== X-Forwarded-Encrypted: i=1; AJvYcCVwEuo5r6jzlHDqThOBBJOcuTm04CCZAfqKpEqw8Y9II3/MXBtVYYJ89AdIASACylVgBotBoNrEU0c+L2I=@vger.kernel.org X-Gm-Message-State: AOJu0YzSmmfO2fgFyVhPjAfulVhyuseUBF8LKo12iwlNtdun2IhAPlO3 ru1JN3DhkcGGz1Ynq0a8+7iBvbYNBeCyxluEVBECbo71y1TNhfTJlg4TKFC8608KE6bOp1VVXda /KNQLkCR7QiG3Q7YZ4d/TY2WyQBjYIADkI+X1mT2E+Dg2SVq1uOKLr4cutcx1MtJxc36U9M/pIL M= X-Gm-Gg: ASbGncvX/ZKS9d3CLA6gFzuE+7jwhuKOoxhaGhea8TtT4Ndw0s65TFG65C1FQhbq2sd MAwJ2/1cM2vNagNgNMZpv7j5AQd+AqPFtgBf7MGP2cM4sNHDkbNfeifd3qzn5ceBbZ2VwkE5GdY 15t97BmKevzeR2HoaeCqT1wqUIIOnMYBpWkyOHozf5TlrTov9pIcoOeGGGHJ1snrChEQgy8TKbr CQp5KQaepOsChXyONgqbkJaCpNF/FxwZadCf8y0odIiWDDYCZjI/omkRleD/4bp+jRVIAJeYAIY DWbiNEQYenFU7Z1s7QOroivjhyAiUc0laj12s/7lWE00apZKhqSnXs6GU5mRWlUxDD1raGyc X-Received: by 2002:a17:90b:180b:b0:2f6:dcc9:38e0 with SMTP id 98e67ed59e1d1-3123efab981mr2365853a91.0.1748560523497; Thu, 29 May 2025 16:15:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGO6kVlTul5XfVExNVHlCfMfXtoSx3A+pScknURIeoMKwp8UajMgtsqcqSsCFhBesXHbzaNgA== X-Received: by 2002:a17:90b:180b:b0:2f6:dcc9:38e0 with SMTP id 98e67ed59e1d1-3123efab981mr2365796a91.0.1748560523026; Thu, 29 May 2025 16:15:23 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e1f3f22sm73581a91.0.2025.05.29.16.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 16:15:22 -0700 (PDT) From: Jessica Zhang Date: Thu, 29 May 2025 16:13:43 -0700 Subject: [PATCH 1/4] drm/msm/dp: remove redundant checks related to ST_DISPLAY_OFF in plug/irq_ipd handlers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250529-hpd_display_off-v1-1-ce33bac2987c@oss.qualcomm.com> References: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com> In-Reply-To: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com> To: Rob Clark , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Abhinav Kumar , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stephen Boyd , Doug Anderson , Johan Hovold , Bjorn Andersson , Abhinav Kumar , linux-kernel@vger.kernel.org, Yongxing Mou , Jessica Zhang , Dmitry Baryshkov X-Mailer: b4 0.15-dev-64971 X-Developer-Signature: v=1; a=ed25519-sha256; t=1748560520; l=2307; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=iZ6m38kGUh6Wu9/l4YZxdyErgIvmhQUC45GosLwQHF4=; b=JzwNwtaiIIBM44Wr7k3CgOFsd6RO8xdIk4KnRV24BqdwI98BPsxzhcx12py1hq5JImcnhpaHq ewjnk+F5+XNDjmSGQssJk40wWDDN1VwB18kGz3ZAu0MJUSg9qNEa3Z9 X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-GUID: 8RsKQ5CD3CdpcI7WnzB_Y6kOqJdz7rD1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI5MDIyNyBTYWx0ZWRfXxQmRMScl2D4I 9HkrVFI10yWXJfzQZTEnk8FbTIeeCbuMUFNQtAg7BosyRKaskj7uwUoIF98Ie6d6QVgw+q8Zd45 RvhcAgkHOwFB+GinAca+SGQOY5c1iAAD7KDw0c9Fd0aMia0/4mrUJ0HX6YxZXM3TerL/Lk9Xp9q a52qrSfso/XRTG3hGtJmztCv0RuZN9DIeYeRcyTWNNvIWUq0z1JM2frGC9+E1UT9p9WLkpT5vsW JMlmjt05KAjSUpR+FC8eDm+kGjWszGg/YTM2cY+EoR6FfVObctLZDlr7PxVEsgcFKapzjdj8QDk Jyntnt4art/5k0Fb9lidTQj4q91tYCHfxsmHI+Ldhx0QwLL5jMd7C36rcf+ktPNdR6+DxgplS38 KVnpyz7WP0g7FbCt+tZ07XlJrddd0RA/74R22clWrz1NLx7fJ5zhxyFwelqK89tPN/7uw6T1 X-Authority-Analysis: v=2.4 cv=fMk53Yae c=1 sm=1 tr=0 ts=6838ea8c cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=PbHRmTaTmGSOozFvvjEA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=TjNXssC_j7lpFel5tvFf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 8RsKQ5CD3CdpcI7WnzB_Y6kOqJdz7rD1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-29_10,2025-05-29_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505290227 From: Abhinav Kumar In commit 8ede2ecc3e5ee ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets"), checks were introduced to avoid handling any plug or irq hpd events in ST_DISPLAY_OFF state. Even if we do get hpd events, after the bridge was disabled, it should get handled. Moreover, its unclear under what circumstances these events will fire because ST_DISPLAY_OFF means that the link was still connected but only the bridge was disabled. If the link was untouched, then interrupts shouldn't fire. Even in the case of the DP compliance equipment, it should be raising these interrupts during the start of the test which is usually accompanied with either a HPD pulse or a IRQ HPD but after the bridge is disabled it should be fine to handle these anyway. In the absence of a better reason to keep these checks, drop these and if any other issues do arise, it should be handled in a different way. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 386c4669c831..1d7cda62d5fb 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -579,11 +579,6 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_displa= y_private *dp, u32 data) drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", dp->msm_dp_display.connector_type, state); =20 - if (state =3D=3D ST_DISPLAY_OFF) { - mutex_unlock(&dp->event_mutex); - return 0; - } - if (state =3D=3D ST_MAINLINK_READY || state =3D=3D ST_CONNECTED) { mutex_unlock(&dp->event_mutex); return 0; @@ -706,11 +701,6 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display= _private *dp, u32 data) drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", dp->msm_dp_display.connector_type, state); =20 - if (state =3D=3D ST_DISPLAY_OFF) { - mutex_unlock(&dp->event_mutex); - return 0; - } - if (state =3D=3D ST_MAINLINK_READY || state =3D=3D ST_DISCONNECT_PENDING)= { /* wait until ST_CONNECTED */ msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 1); /* delay =3D 1 */ --=20 2.49.0 From nobody Wed Feb 11 05:28:55 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 492E224C09E for ; Thu, 29 May 2025 23:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748560528; cv=none; b=g5QmOZCGMq9yoRH85+WA8XiWKtm9ajWBuI5I6jCSD36fIHRfXDp2HmMWgUlkhtsZsnxP8ojoBh8LDNPIUsVshUjPOvnBTwvYGdeHrnbKJ70h0BOSpQXhzf/zSKkHqPwUVIbyI4BYehiVNdixAFscsWy2zNHAePMUNUy/aYbOs6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748560528; c=relaxed/simple; bh=cT7lMKr8k0/w4t/Z5K5ELQ5zbFL0wwmPeLJNmXBBCog=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j6QF+wPwdYwyLGJxqexW8Q4mScYsiFwYFkYmXs0NJ1+/fLOBbGrVEGRqCvCxiVQIBGU0AiYxj1Zs6a74/DA5PAv1frnEIuxBiqbEucYfnrwLaIAehNfClpm5Y48f8keoXrycC32ADY0+Rpg5vx2CJiAoo5HbzhBjltxBIJEPhFk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VbZMlFDw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VbZMlFDw" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54TC1OqE024544 for ; Thu, 29 May 2025 23:15:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= H2gYUU1FXEsiCULrNF5KO3iQkScCDInHxHlMYEUiimg=; b=VbZMlFDwU2tYYnKb uEiZxqcsXus/ZntWMn00T7ghi53tFOg4pnzuV16bQwr5oO8ug3AQhSEBEGtTSnNU JETQGD9hmiIObOPuU2n3V4BW0UOif4fV8nvwk4lYKvApsOFtcdGyi3UqgmP3OkQl T6DHmtkM9sBv2UfIix/w7VFE8GZCBF5GggyN3HMmsbLyeHn+Xe6wjonGbdTjhEEW DYbvkyTv906Thz1XTn+kJEgsR6prbzmGeqoArJuSfcG0VFqaPr84GpVCxiTQdxNR B5HB4J19utmuPKVMxAvzdKGFfZRibe8S3XL7QrNM0JzP7oHLzJgPqTwFjsjuADQm Aw1Npg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46x03mwg0w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 29 May 2025 23:15:26 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3119ba092aeso2143874a91.1 for ; Thu, 29 May 2025 16:15:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748560525; x=1749165325; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H2gYUU1FXEsiCULrNF5KO3iQkScCDInHxHlMYEUiimg=; b=OgLYzDcXMm6bM9eDO6Cv8iOnySfMaHXelkXV0U2Ajfa9E3ZKaQNX/R3KgIY+uwvsUO Qtw8Sqcd55XC9FoHIP0bGcWbprIXFUzOM26cF7CR3EvZ/gNN8CZWKgg1atlIJNe+qZFg hjVUXqk0Wyempw91464IGkz9BCXaykZsgKzILw1OYQaZXommoSX7yYJA/Z4j1/lEmbSg 9mSrP0mDrnzIIUoTxTSMmCNE6XJnky1JjkhGCYkWULpDPBn60ZP/oIGbDoHy9Sj6VeYF +sDjGHApJjE1OIK/WEH+yLhha/1SHFATENAt2QAAZtNkKoqd4fJxAprRlmrM/Dln0Gfz aMxA== X-Forwarded-Encrypted: i=1; AJvYcCViMI87QFcyTD45mI5pGaWDbkglcObHaYf1n+FBULxwwcliLJlzHhILYbUD4V6fNlaRQw1izMWL4TxiKzU=@vger.kernel.org X-Gm-Message-State: AOJu0YyG/RAVlcNDR9rD28iTfR3awV9Ijnyw8U+cHPB4egxWerQ/4avh DODzvyO85MWrJVsU8giMDOa4mcJQKEfd6MlZa6zCFhE7agS84ub2eUrU0owhC85BLl4tur5nunP WglnYMCy8xWLHzeEQ2z4ZZAD77hVtH3vXgSytQLWEzFe8WjCw07MdTHo2zB7cR0lud2c= X-Gm-Gg: ASbGnctwXF73RntegSEh0WVGm+Bk+eJrgqe7crMpgA4TIb2qsuw+9td/7arkSD4PZvT dY4kcKRFJHyqYw+TF4B/v+tiFSZFNVIjRm1GC7CqsTX5EqbLbC2sdSemUZA+PrI0/fyWogKEgyS 7Pw1QrM/RoHqhRq7GPC4fg/eUbwDHrffr4GPmgqdM8PXk1rOO4if/t59mTssbkcp2l0CXkcldhi IrmaPcm44Ga8vjFQ66RUrBfIe+Q9aWKmyGJN3eUZ/4DDqN+pmI272N4IPlk/65/MgptnWPUUdYE 6gKktq6toSBS4JUN58DaADoRtuOuJOYLjyIFXzGg/fBpqPuTQvtK0K2rfveZo/KOH8JvNv/L X-Received: by 2002:a17:90b:2883:b0:311:e8cc:424a with SMTP id 98e67ed59e1d1-312415391b5mr2330065a91.14.1748560524999; Thu, 29 May 2025 16:15:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBfi+6PW0/stwfIr9Ji9/hRe9cqIN1QfL9pqez/UiTuvBmsR34ao61gV2YnPGnXd7GW1DHUw== X-Received: by 2002:a17:90b:2883:b0:311:e8cc:424a with SMTP id 98e67ed59e1d1-312415391b5mr2330034a91.14.1748560524621; Thu, 29 May 2025 16:15:24 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e1f3f22sm73581a91.0.2025.05.29.16.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 16:15:24 -0700 (PDT) From: Jessica Zhang Date: Thu, 29 May 2025 16:13:44 -0700 Subject: [PATCH 2/4] drm/msm/dp: Return early from atomic_enable() if ST_DISCONNECT_PENDING Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250529-hpd_display_off-v1-2-ce33bac2987c@oss.qualcomm.com> References: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com> In-Reply-To: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com> To: Rob Clark , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Abhinav Kumar , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stephen Boyd , Doug Anderson , Johan Hovold , Bjorn Andersson , Abhinav Kumar , linux-kernel@vger.kernel.org, Yongxing Mou , Jessica Zhang X-Mailer: b4 0.15-dev-64971 X-Developer-Signature: v=1; a=ed25519-sha256; t=1748560520; l=1455; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=DKkTNWpb363qNZIlJK/dgUyyIUKi4hoMvgukVRHWsxk=; b=G0e1TtIX/dBusekaqwSYgj13I+GIJGnSUpuKurLZzg63+cZlKtSuWTLfX9K/Jf3SvmoD7DKSO TB2zvTXe8WuDZqo5wU9ZF52ZD7BofrsrfxkwWe6WFZojdVn4OZxeNAI X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-GUID: c4UmVTQ8yH6F9YUXC-CYskt5ZqB_jkE2 X-Authority-Analysis: v=2.4 cv=FuAF/3rq c=1 sm=1 tr=0 ts=6838ea8e cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=-ysM04AIoonzMzE-3HQA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: c4UmVTQ8yH6F9YUXC-CYskt5ZqB_jkE2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI5MDIyNyBTYWx0ZWRfX4GhsCXm8gAY4 cIbK7gQUM5SfaQfQGvFPmon4YKCOEzhx/p0K05MzCcKd7pc/jvcbEvvy1FLiLar0gOgMKF3wT6K vUsAygolZ8XXJ28friIJZ5TBp9rQivMEIKo62Es5I1LvoZxht1HJq2ctZdbFIqEE6U25tTR1bEM IjZu8AU/l+aFiGPgTyFtFxkQG8xAH2B48BdXFPI8OP9kL1XSZv1MvNFoSV90RXFg7YKB1pF7kR4 /IoNO0SKdetKU9aBNXktAbEjiF9hBZreL2k5ebMKZeyangm2tnl8N29UFEw4GSoco7c72r+L0pb bX7fMnddLm5hv8lg15h3djkj61qF3v9uJLa3wbGHKArWqQ6iT773kQ+aMitmzw8N9LbJBCEH3SZ RogF+Td/6XkGdQUrPg69hxIg1Ql+XyRXzl9d0pBz5xqyJvc3X/501tG6FkOSRY2DQPfR0fqH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-29_10,2025-05-29_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 bulkscore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505290227 From: Abhinav Kumar The checks in msm_dp_bridge_atomic_enable() for making sure that we are in ST_DISPLAY_OFF OR ST_MAINLINK_READY seem redundant. DRM fwk shall not issue any commits if state is not ST_MAINLINK_READY as msm_dp's atomic_check callback returns a failure if state is not ST_MAINLINK_READY. For the ST_DISPLAY_OFF check, its mainly to guard against a scenario that there is an atomic_enable() without a prior atomic_disable() which once again should not really happen. Since it's still possible for the state machine to transition to ST_DISCONNECT_PENDING between atomic_check() and atomic_commit(), change this check to return early if hpd_state is ST_DISCONNECT_PENDING. Signed-off-by: Abhinav Kumar Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 1d7cda62d5fb..f2820f06f5dc 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -1512,7 +1512,7 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *d= rm_bridge, } =20 hpd_state =3D msm_dp_display->hpd_state; - if (hpd_state !=3D ST_DISPLAY_OFF && hpd_state !=3D ST_MAINLINK_READY) { + if (hpd_state =3D=3D ST_DISCONNECT_PENDING) { mutex_unlock(&msm_dp_display->event_mutex); return; } --=20 2.49.0 From nobody Wed Feb 11 05:28:55 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EA8E256C87 for ; Thu, 29 May 2025 23:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748560531; cv=none; b=Ca5ydXqNrK7PbZebCgz1ZBkO4GY8VotKoD57ueGQrXhawHCPAz5c2KijD2QqdtslIafrtMTWEXDKK+8xmF6il6uieVWIXHxzawAgm11zQPXDa1Mne7GCutNihBUP6i+HdfNDK+zgFes9BydhgqapQidltxIcgb0JmVXXNX31IO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748560531; c=relaxed/simple; bh=ZAGZk4Y8vogmDbZftZ++ijHWg2vj1zOvE7SDTgM361I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Qs+USZPzYs/kD2rtPzcD5O1zrY/WETvRHN7ZwF7CLP+fLb8WrHM6OKXiQOJ+IAxmlHY4GfoSem/FNnDIYhozCw7lLEv7IPg/v7nPEfOsjT0THs+qrcPlHmSM20UJmbm2QdgXQHswzD2C7kqRwFvd7p9xyCzNdGMdHkiE8ZFte3E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eSXkEdKV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eSXkEdKV" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54TC1UL4011736 for ; Thu, 29 May 2025 23:15:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kX7efsc+IS2/784jVqW415KcZ7V01+TYXKPRgFgJmG8=; b=eSXkEdKVaeU3v7Pp x5jGtq5KlfskOfsXmQ7UPlUErWjQ01zFJI7mP8oORmLZy96DYDA82kap14XFkI/L aQu4KaGOxcTdrv+pXUUhu//ti77g2G+ycy7kuf4vYY+39FtQJYjfAgWiA6dqEzgn Sw1k0vcUYUmUqC5ibN8c7LUdjlaO1SbX9k5ezZZgHLGnmN7RPSG4K9FYyVXzQn/P 59qICEAD6zD0y+Z1zu3U6XG1iwBNkErExbcjdVYup85kqGYN/YAsHE7wsYW5syRV h7in1HuTZqol5BkLTKANsLL3EL4UKQV5B/QNU3N7to7Vw/ie3LvFjco7HnqY0VKo X7bk1Q== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46u6g9785v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 29 May 2025 23:15:27 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3119ba092aeso2143892a91.1 for ; Thu, 29 May 2025 16:15:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748560526; x=1749165326; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kX7efsc+IS2/784jVqW415KcZ7V01+TYXKPRgFgJmG8=; b=O6a/XJe+5arJORn7P4HTOkt7swngJZdcDhXL+W4xF/7PI5j/lU5QSADFkhRnbE0qRZ 0MnqW5Qvody6oDMjaJFfjgC7hpplEZNtkb6HEiyY5L55frlDKlalIZChXuthE7rBPnwi R0Ptk2IRrLmiUjr31V1OFMdVjENR74QOf1fdaLSHsO932LC2suZ0wItbPLR7HPZAPavw 3VGFW7yWdgm+K+06162df3rALgs+SyizSGER3DoBggD9oh6hATaIoP5zI7sOrITe1PJf 1m+QUetDMQkU047LcnU2ICtLMXBDPNyx7jWlVd/t74S4beQONEVyZeBqzWQ1kHD5ZN74 jMKg== X-Forwarded-Encrypted: i=1; AJvYcCXUaTgCXIsk/3cA+PLluTBwAbtglDlyqzqeLhLe5zUoS0G6EB6isXzz5rDlNitkuehX5ve2BNFzrSq+Sy8=@vger.kernel.org X-Gm-Message-State: AOJu0YwTJiAcnAhF0e3DB5khGXZAWQjHxcIYyHzOjd/5MhQy+csKT+U4 BUcv95/PImUC2SRTTKlX9LxJjAHJ/v/vxjEk9JtQU+gE3Q3d2x38DdY4LRoVmV7fBa1sCcNwBtt T3dJjQ3FGlHyeV/zYN5Foh4h3y3/iAzLf1QWmB09Ltm9bsEgmJVseecZPI0wuQfDioDY= X-Gm-Gg: ASbGncslWO1NOki6+scDAzJja10zP8VbqdcTysDcspmCtMbLxQ3gw7njckNGa+FWnEq QauZ66zx3M4tbitWCtJ3Bsnk1tVcH1HP+vce0i8ZRSqAylglROMd2l0nP9a4hpF0VrqGqayzAME fq9x1b3ozWRDZ7WK5IkFwW/8KrKNHClsR8DvDLa1bWd6Gjn1Vsqb0EYceAV4NbmeTwfri4IR0OG MN5xC4KLHTKL0KMTs02fCTzc4tskxbOKLOsR8QrNggEIjRDaHrJrwBPkWh7h2/iaDCSMYT3FT7M cifP7apW3fZulj+dGphL42AHYWgXqNNFr1+8bz5Rdeu00S/9/UDLR3/+yIc0+IOGIazNzZMV X-Received: by 2002:a17:90b:3a85:b0:310:cea4:e3b9 with SMTP id 98e67ed59e1d1-31241ea0309mr1550085a91.34.1748560526427; Thu, 29 May 2025 16:15:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEA3THCormTux9QWIgYTb/ZoeNKtEa6RR3lUUxnW6L7Kha6SEXPkeVkPdWWJIZrBpa4PAFunQ== X-Received: by 2002:a17:90b:3a85:b0:310:cea4:e3b9 with SMTP id 98e67ed59e1d1-31241ea0309mr1550058a91.34.1748560526083; Thu, 29 May 2025 16:15:26 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e1f3f22sm73581a91.0.2025.05.29.16.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 16:15:25 -0700 (PDT) From: Jessica Zhang Date: Thu, 29 May 2025 16:13:45 -0700 Subject: [PATCH 3/4] drm/msm/dp: replace ST_DISPLAY_OFF with power_on in msm_dp_hpd_unplug_handle() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250529-hpd_display_off-v1-3-ce33bac2987c@oss.qualcomm.com> References: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com> In-Reply-To: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com> To: Rob Clark , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Abhinav Kumar , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stephen Boyd , Doug Anderson , Johan Hovold , Bjorn Andersson , Abhinav Kumar , linux-kernel@vger.kernel.org, Yongxing Mou , Jessica Zhang , Dmitry Baryshkov X-Mailer: b4 0.15-dev-64971 X-Developer-Signature: v=1; a=ed25519-sha256; t=1748560520; l=1160; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=fcV0U0JSd2Lf4fDNNX9R4rq8oAhewquvTnMKQsk4vw4=; b=L/EjQFUOVbqSjowt+2F3fUU1pQgDZXxeNd7PyBfGd52nFzJc3fw8rhldR4/xN61sS8wqJ+6KR nwQbP8lg2FaDS8cHgMf5lKPSyxMS6ZmgZItPDqtcoKXmLuD3U5u95KC X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=d4b1yQjE c=1 sm=1 tr=0 ts=6838ea8f cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=8oAJioj0-2SxPtK92HsA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=TjNXssC_j7lpFel5tvFf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: ZU5MK9gjjCzNmrfoA7nUiX-HY0V3g60G X-Proofpoint-GUID: ZU5MK9gjjCzNmrfoA7nUiX-HY0V3g60G X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI5MDIyNyBTYWx0ZWRfX193bNy3Hy+U5 Lnt/foFL2RLHf+J0cIjRTA+7PfOf3Uhy7Jg7kZishT68yJDqBDrH6aQnACmMUB958h1llcGkYNy JEBOyVmirbi/dOLQSA5IeDYcPzKaEiCfEc16w7PqHECR/3Rtu5QA3itJrQX44TUSxVPPHXNJk30 MHsUji4OYOyV0gxOEpYSAr3IBbEw/6dRgmijZ46FvxrXZuNQDGBBl7LrkHvzCEEJVq+QV7ShAm0 btdaM4zP2ivc3dAGGWYr7HoA2os1zz2bgbk8Q1D4Sl8k0RzqnB0FObid51qANHHWcn7JXTGaRV1 tSyUimKk9Var8Re6f/ptSxnQreBMJue1zhAxYSVS4HRfm+jn1ctGYNp69Wn96R+JK/rvwJyiqhv nTrC3st+nWFWo2fWfb5OeG96dmwlkHEHoR+L9hK8TwoRaSe031+EnSAbHV5iP+wOZt0UvYV+ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-29_10,2025-05-29_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=768 lowpriorityscore=0 priorityscore=1501 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505290227 From: Abhinav Kumar msm_dp_hpd_unplug_handle() checks if the display was already disabled and if so does not transition to ST_DISCONNECT_PENDING state and goes directly to ST_DISCONNECTED. The same result can be achieved with the !power_on check. Replace ST_DISPLAY_OFF with !power_on to achieve the same outcome. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index f2820f06f5dc..785c813d2b31 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -672,7 +672,7 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_displ= ay_private *dp, u32 data) */ msm_dp_display_notify_disconnect(&dp->msm_dp_display.pdev->dev); =20 - if (state =3D=3D ST_DISPLAY_OFF) { + if (!dp->msm_dp_display.power_on) { dp->hpd_state =3D ST_DISCONNECTED; } else { dp->hpd_state =3D ST_DISCONNECT_PENDING; --=20 2.49.0 From nobody Wed Feb 11 05:28:55 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2385257448 for ; Thu, 29 May 2025 23:15:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748560531; cv=none; b=aGRk9RVY9ZF2JjBG7w7uu/W7Xw+6tpRtUPQHY7XG3ZMvifbKB/21bTflm7ZkzcGPtPvIOxulwqxRQ1nA2FjzPWg+47E37KcXgY1tt4Xni6Ddc4GOFCmraruVBp3XhfWlCNzPgKOLfkoAzuU4mKygDfWUSVZANE6J7CmH+iHf8m0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748560531; c=relaxed/simple; bh=Qu9dpHlIRB4zOegYzAEmciE3+UoqCif4T5fM30oyon8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UFFnJlM0t31gScOOVJmoPYWLcpTLVCSYhgS0l2Z5Nw7acWE4+0Rym7eY8U5Md4X5HM4fEEi1ywUSlxvk9BX401huNSXDCHnx2Sc6RYh1HmUDnY2sZku3AQsRVVNiz0bs1QenPKIZn/hsvJB3injL56C8TFWbadYd8GK30VahBmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WlWWlbeb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WlWWlbeb" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54TC1Pgb008084 for ; Thu, 29 May 2025 23:15:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4vbVMjvU68KSE4FGI+lKVINOGIspYhFfmjickrGZhQg=; b=WlWWlbebHQXU7IaB t02zhGKFXbemRqNf/kw0uIQ2ao2KMbVnBK4Vp0zi47WsA4reWndY8e7xqQ1hojRB J+qGJNVIKrXM6i05AmGI5qhB2FhX27TRfxaoDjqrfZEwOg4LXY/NPfyVxIgfRMYF HqW7vcJgbKLWqj4jhP87dYB+Ztkmk4edDm/NOqrWZJqlzS0/ZGj0wzJF9O/5Nz37 hMYt2VK5NyXch9g8NMglhWP9YjGQdW/KatJnJ6fZPXkz1UZO2Jr5/dx9I8+PxxKE zL6nFpON9riyWpNQMTmq1NwpwQEVQ+8v/or1p7451QCXHI6xxJ5GvbEthnxk46ZC YJ8sUw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46whuf7jmx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 29 May 2025 23:15:28 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b0f807421c9so953981a12.0 for ; Thu, 29 May 2025 16:15:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748560528; x=1749165328; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4vbVMjvU68KSE4FGI+lKVINOGIspYhFfmjickrGZhQg=; b=waVaTJuvOMiFxwHWlyhNbNK4n6j/ds/hJym9jmv7Zt2vyPkEw0ZxNvphfiXphenjYI QdsiuoX1m/4aFkvA2KifALcmmpku5lU95dlJW0y/EIMtUx3S31W196IzCHMtcmAHIBAP UHMuo3TRlpfKv2dvvw+yl8nqU1vD0T2eOD0nW66C98E8qL+6X6wbuU2yQUPNzbUx45ob fdDF0uj84k5VI6adZYQzvH+ZyJsUtWq92KTwhUhqo2vxGeIZ8BKHT0rrgc+gIRLsJjrh 3MForKCdhBhyzM1X3BFucKyiCGb2lHqSlkHFQf7P7Mt/hasdVEq82nbKZYjYH7hVfRqU 3BrA== X-Forwarded-Encrypted: i=1; AJvYcCWPtBFrH85gdOALaFUTjJok/eAoOilSgBItVsJyzNbrXFhzVUZ1V8NjuKbVNvh9DjRStffgDztClCMStws=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0az97iTo8aWX6StVX075rNp7CVEQF50BFFbOTzFgdueRXNBI8 L4l5B41C/L8zPu6t7vRIipe0YjcXhwvCXH3umLwsbqzvSiy6Qht90up3b/WMSsqQX/MOUm5X7Ls lNjr5Scomy2wNkUvA0V4FXivh30cgkq1glkAc7dJ/OisBGB97pYvPnwE5hr7U43tXARw= X-Gm-Gg: ASbGnctA9RK+9jQAkZ6SscV4BueQI+UGI8+Hl4T9/CveDc8AVQGB4v0DJVExvrghRCk JrzKF90EwNzZTgUDA0SttQ4x55VXOaN41XdJyjOTd+5Qw9CSE8bfV/5PCDZaYIWmQYGQ4tw7A/i 8ADITlQ217pwvzUb8L7zgk9CX28Hoc55mAUAbBjy9zWOPwFG5lAOGqWO0EWMJNaUJITkZHynHzr fkzzaUwhr3VN16LDLip+eVweQpJIU42yI3KWiILlS0KS/uZqBKE0NPgW5mV7bW+6GOaLe2Edgge QuKWVaaLiMye1o3fz6XGLM+rlODEMbUlHiGNrr2Bs2n6hdxs0GNLAWA5EB4s12j/pexsYlYG X-Received: by 2002:a17:90b:47:b0:30e:6a9d:d787 with SMTP id 98e67ed59e1d1-31241532ec2mr2226129a91.11.1748560527842; Thu, 29 May 2025 16:15:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHKS8hP5QDpmvy9MOsu098RPR9jWdEHOkxDAW+2Xf6gU153iGKt6qoNGu8DVdUnTocC11rWTQ== X-Received: by 2002:a17:90b:47:b0:30e:6a9d:d787 with SMTP id 98e67ed59e1d1-31241532ec2mr2226080a91.11.1748560527405; Thu, 29 May 2025 16:15:27 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e1f3f22sm73581a91.0.2025.05.29.16.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 16:15:27 -0700 (PDT) From: Jessica Zhang Date: Thu, 29 May 2025 16:13:46 -0700 Subject: [PATCH 4/4] drm/msm/dp: remove ST_DISPLAY_OFF as a hpd_state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250529-hpd_display_off-v1-4-ce33bac2987c@oss.qualcomm.com> References: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com> In-Reply-To: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com> To: Rob Clark , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Abhinav Kumar , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stephen Boyd , Doug Anderson , Johan Hovold , Bjorn Andersson , Abhinav Kumar , linux-kernel@vger.kernel.org, Yongxing Mou , Jessica Zhang , Dmitry Baryshkov X-Mailer: b4 0.15-dev-64971 X-Developer-Signature: v=1; a=ed25519-sha256; t=1748560520; l=1865; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=LQos15gYFKCo04VJZ/As3557mLEuaumxqfi0RxOfo5Y=; b=ZyMmKPBhU5YA6EHWCvynOwpmKVsv3ib05zmarBy/e1MwPCLCy3gRO0/VTzFbpLW+pORd1zhqW Qr5/lo9J/i2Ci3LD8bTC68qtF6PkoPKgqziVkownWvT+mt52PpUs1pg X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=OslPyz/t c=1 sm=1 tr=0 ts=6838ea90 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=zUghIR52pHC5fQqyx9gA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=TjNXssC_j7lpFel5tvFf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: UTcJ6bcm0JfPOQJUL770zK-YeLfHctTb X-Proofpoint-GUID: UTcJ6bcm0JfPOQJUL770zK-YeLfHctTb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI5MDIyNyBTYWx0ZWRfX8wxzYTKHFA9Q yZQf7dotnQpwWpsYqebd3vCP40+lHZEj3Ocesf4VUvkQU59wdNYBCQS/scyAP+TzLturmWOJXkd pf6C2NpocesVdUH7Wr8nK64BGDKeC8278ZIkgeesom5hWr/zcIru3zQPXZ5qTCWxyjRiCtEOvNj yOu9VM7He2UOr5+o2xUQpENa/bDe+EFQq1YTWwYJquQd4jrnovu+16otcDaEcL+TYz4jP8b5R3W jRs3q73gaCML+dj85vJGpGB34ipGkWvxc3+GmPBnbYHmBKnO64u4rIpms1wvJrRjQvfu9iB8MPr BqsDuKAqDJpNYd2WzpzAmmmVq4f0FEuq7c0fFrnhkRnD85BWNrW2bFj/rzf0Yj44m9Bm2ZHR6TA esnWRfcBm7VjvTOeJjYKjTIGH800EDAZ5jQsyWvRC2ErxIz7nHI7lNjeQUPbb2hCaOI9TRoT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-29_10,2025-05-29_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505290227 From: Abhinav Kumar ST_DISPLAY_OFF check in msm_dp_bridge_atomic_enable() is used to check that if the display was disabled while still hotplugged, phy needs to be re-initialized. This can be replaced with a different check as it just means the hpd_state was still ST_CONNECTED but without display being powered on. Replace the ST_DISPLAY_OFF check with a combination of connected and power_on checks. Since all consumers of ST_DISPLAY_OFF have now been removed, drop ST_DISPLAY_OFF from the list of hpd_states as technically this was never a 'hpd' state anyway. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 785c813d2b31..6f05a939ce9e 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -50,7 +50,6 @@ enum { ST_MAINLINK_READY, ST_CONNECTED, ST_DISCONNECT_PENDING, - ST_DISPLAY_OFF, }; =20 enum { @@ -1526,7 +1525,7 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *d= rm_bridge, =20 hpd_state =3D msm_dp_display->hpd_state; =20 - if (hpd_state =3D=3D ST_DISPLAY_OFF) { + if (hpd_state =3D=3D ST_CONNECTED && !dp->power_on) { msm_dp_display_host_phy_init(msm_dp_display); force_link_train =3D true; } @@ -1584,8 +1583,6 @@ void msm_dp_bridge_atomic_post_disable(struct drm_bri= dge *drm_bridge, if (hpd_state =3D=3D ST_DISCONNECT_PENDING) { /* completed disconnection */ msm_dp_display->hpd_state =3D ST_DISCONNECTED; - } else { - msm_dp_display->hpd_state =3D ST_DISPLAY_OFF; } =20 drm_dbg_dp(dp->drm_dev, "type=3D%d Done\n", dp->connector_type); --=20 2.49.0