From nobody Fri Dec 19 17:17:44 2025 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8912F3FBB3; Wed, 28 May 2025 19:11:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459514; cv=none; b=IMzMvVIBjDEno3TRxeOvMSmV4H2eaTCH8mUkSbBroWkAHr+rxFOX/533sepI/vPr3MQkVyD9Xiqa1tOob4duq/lvONXGDeK9Xawdtw0Kw1vl4sZJ/UBrVIuXdyninHTvN+m4caoyJft181XIoyHYMOqThwdVu9nt8u0jlQhpj1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459514; c=relaxed/simple; bh=8TFIlL+9Nqb7USj2bx1x7nSvC+emH7rIhEN9SdoxRiE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=StCkCEveJbBleoG0DS7j3i4XdjV6MYgCBg12wFLy0OY/hOO8XgPawH9NBsH00SMEJcvLQGoqLLtwTeR908nVWKWY73Ndt+s7UZI0i21GbC4mOXZ569jE5i/zO+1JuOskzwEg8YyIu1pOg0eSVmMNtBB0WTk6qPUThP5CTFczJX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=enhU+Hlg; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="enhU+Hlg" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-234488c2ea6so2083445ad.3; Wed, 28 May 2025 12:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748459513; x=1749064313; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+Ujzt0Z1mlstm8/GkFppvnEuth0oQ41DBzEMpZiCaoQ=; b=enhU+HlgkxxbfDvV+aM6elNHOOzte6S3aNFJ3uHh7LMG0SINPHDLyeegv4uV2Hc4Oo mfh/rGQbITOnSvt+mQ3kRsjDZO8r0yy97vNkosJzLDbwgAV86RH2RR5T6p3DVwNvLdGl ETrFjdo9Xa1aBeuBaBJlVGQzLIC7tL/na6NFMgqVLHAIrWmojQxxaIa6H7WbBKj4R2P5 H8lMq+imqABjVSQG0Us6WKjWgOZbqPVyZsv1ADunP57mbcclm2lijnvxgMBCQQm/Ku5p FVGrKbdyLjrLqFue4my5tCj498H+Prc1O5LVoxnW3CBnSbdy7FXbeeCinihHFM0QuHAS dHLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748459513; x=1749064313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Ujzt0Z1mlstm8/GkFppvnEuth0oQ41DBzEMpZiCaoQ=; b=ikDni09GrnQZYkYOSWaezf9uSiJHbJ9r5KxSr0tz6pTvNgXk1On2/Y1BXIFh3l3mBa jBJOWuo5N25avfWf3ha1ZDEplbQ1YLQmChXOlltcqp53RqEv7aavhauDVrAQcIGzd2eQ dkCxO9mkJ/+QWkCWQxjkhmVPkbsypI4fhgRp8JIyEQeoo+70AAcH4wuxOVJ67JK8d5Cw A1VL2qP/+O6cSLpeoMnWNg+YCVp1vphEpSqlVyrm6Ht+SNpzejpKllKE4Y1S9XatLv7B NXVAwy9b6JMMiumJo6imYF5XAbV8mFsPkY9dGD4hVfsRnOlJ8i04dI8ukMfLbHyvsUKj T49g== X-Forwarded-Encrypted: i=1; AJvYcCVPxPvfmlcn7kZap7GEa1ihF6Sr+1crlG20ZahQftX9OMvbDNvCZHYNTMdSVhTPoe4kxBNc/tBlVdrWllc=@vger.kernel.org, AJvYcCXXAWpabTVxjo2r/t9HqlKq0XP4iU59DOw4NGPKua7pYH77uhIBIk5TcHPogxGFBXoiGZPKUCmJI8t8Im+o4zdcXA==@vger.kernel.org X-Gm-Message-State: AOJu0Yz5VmZ7iOqe+I1VHn+aejKLAOwzSZ0OvxbBtZIjPJsc2cxx3RmO 679ODrlZ4Zc9PK4n16PtTIStx825yzPOX/Euo1nn5xABgnFitcAVRM3b X-Gm-Gg: ASbGncv/T4FvYqIEdpzn9nWoeUYzgfUeHta3vaPEM/1Q9XvfBOfT5gVVRsyVS7Ua22W AwBw5C6XjiaMtiGe3AuDbLYf9KzpyedsGRyMa57dvoSmn7j0SY5qc6l6F0P6xZ2eAcmMXEIbn45 5bCZOqtxbp7s2vdYvlGPvxe0kdyMMql0sguUw8V9X2e6H3VvJ2pS1FQi7GhK1AHsX4iRJP756h0 gN43ZbVmHnx1fwxgVZBpteuZzqwyaYTjyrbsEVlVMDV8DxluArnFFAqTRqWlFdz97FzT/zJn3l4 l4wzBy+CsohDBzOL4wx71wzGk3tvKH3EROE4pEgndH/qrQsy85+lVr3CXeamGmZR9lN4JVYqHqV T3UgNPy0j3ESFvkvncEDl9g== X-Google-Smtp-Source: AGHT+IHHENbUvE1xyQR0GWXCL/LYwifJL9esyMdBjg8U22FGiu/zP5RTwtpJjvh3OeKLcWK9mbvoIg== X-Received: by 2002:a17:903:2449:b0:234:b12b:a2e3 with SMTP id d9443c01a7336-234b12ba39amr101995595ad.29.1748459512627; Wed, 28 May 2025 12:11:52 -0700 (PDT) Received: from howard.lan (c-73-202-46-50.hsd1.ca.comcast.net. [73.202.46.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-234d35ac417sm15172215ad.169.2025.05.28.12.11.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 12:11:52 -0700 (PDT) From: Howard Chu To: acme@kernel.org Cc: mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, peterz@infradead.org, kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Howard Chu Subject: [PATCH v3 1/6] perf test trace: Use shell's -f flag to check if vmlinux exists Date: Wed, 28 May 2025 12:11:43 -0700 Message-ID: <20250528191148.89118-2-howardchu95@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250528191148.89118-1-howardchu95@gmail.com> References: <20250528191148.89118-1-howardchu95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To match the style of the existing codebase, no functional changes were applied. Signed-off-by: Howard Chu Tested-by: Namhyung Kim --- tools/perf/tests/shell/trace_btf_enum.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/shell/trace_btf_enum.sh b/tools/perf/tests/sh= ell/trace_btf_enum.sh index f0b49f7fb57d..b3775209a0b1 100755 --- a/tools/perf/tests/shell/trace_btf_enum.sh +++ b/tools/perf/tests/shell/trace_btf_enum.sh @@ -17,7 +17,7 @@ skip_if_no_perf_trace || exit 2 =20 check_vmlinux() { echo "Checking if vmlinux exists" - if ! ls /sys/kernel/btf/vmlinux 1>/dev/null 2>&1 + if [ ! -f /sys/kernel/btf/vmlinux ] then echo "trace+enum test [Skipped missing vmlinux BTF support]" err=3D2 --=20 2.45.2 From nobody Fri Dec 19 17:17:44 2025 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DB9E21B182; Wed, 28 May 2025 19:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459516; cv=none; b=MjrrgNp1eIZWck4sTiGRbHukqV5N9vAxNAeY8K/RE8EayI2/g6LKQjiTNIqwjP/5X4X0D0B/iq+qYBv8c1D8H46SwE8S9llQ1MA1f4CLlBiZtcMvUOJ5vpExnFxKVLnsluktNf+MbdA+hmC19M/BNzOPestZFdDgCcvQdRGbsaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459516; c=relaxed/simple; bh=mVeS1DwLh3YN2Z8nLwdQ0FcDREC0Wysb9FnWiUZNLec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ihy7+UfkP+YQizIzcRyF35RstQQpamUZhHLmTPtM35H/Ypd/Y0mZWv5vMMAyJ9n6o4hoY9NunSB4tEFI7iJhu8WFSqYJHM2/AOqusE5uJPlB+QLoK4ItZsoVda9epLzYTmwJX0gnFDyeizWYvcKv09MAd5kWUCGpMS74RZdbXtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mMqNTmYp; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mMqNTmYp" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-234bfe37cccso3086645ad.0; Wed, 28 May 2025 12:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748459514; x=1749064314; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/NfU6lKh/CqCSh0qCEAauDus8fp/OoFPPrxMtpXJevk=; b=mMqNTmYpEWplNs8Bysy02dkiKeECEpL/H6dnEd9tM6T3qXEWixSNppficXD/0Sc7ao bDP6ttKS+Uhn6m/ruKtl61sqqeg1GpLAISkErQ/3cY9MwQvvPyJCOcsyt16nL84bUf4K lPqNAFICMakLZ5DYKR/OAMDazIIKxW2XXu02Ozvpw1RrRc6ey86mXLRAcrdrPRzoSi92 MkDEFKrs2GzXv5C+eo0kiuc+RGacMVfiPpMuc/JrM5s43a/7+TTHAP4WR8OyO5O2JJlc JmctScaEsGNF3aNRTPO3ecePoMoCnVryXXApfC6qxIM+1vsbUVokZHNfk9oJREDOfB1e tQPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748459514; x=1749064314; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/NfU6lKh/CqCSh0qCEAauDus8fp/OoFPPrxMtpXJevk=; b=kl2w4QZt/f6NJz07QVDXVeFUrfksqaLiU6p9NjYXpgdrjcWVzNOW8ZlJRWweIV51Tx a+GKY7KqBT1AMDDHNKnDHMS5Vmx9nPNijURYX+Gc5eU3b1hR/yzdHpjf48IhU7S6Gynt tXOdvWxSs20KUJmaOO1o5MWYUtH2Z8dJPzjfGDedndVLTRae7VYrqruPpEar1IqjDKiJ +wO/DxNTIAdV7NRcayHSGUXE/+Mm/3bGmZr4jJvy4vj1oDrHWquteJnuDPZYxngGvLix 95z56G3+12H+un25E5QauzzNRELE7zgIrb6CGPhpB4KO4d/ljq5Zgor9RBPYe9O1TkN3 PlCQ== X-Forwarded-Encrypted: i=1; AJvYcCVlgUTaDhpw95iEU16TZOuJcqi7pOwfNreCEc4H7LhzDlFoBBcbjzvTcxkAhPHVcOJhWvTsZXJQUDQ9B4imp9Up5A==@vger.kernel.org, AJvYcCXUFxGbai6naFdhtC4sAz3xvnsnQ6I2t/7r1/DuZFGZqqCxhFzz7WeleoeUX9je4Y2voxcfPuJ9IrY5qzU=@vger.kernel.org X-Gm-Message-State: AOJu0YwLySBxlKnWw//O+q0feu2FcqrqtUiiaIo3sysCgF2l9aiWuFtH KPDmq6d0TycmeDCIAgFXJTbBSNe5KsIN+UKq2xNg9Ur8Rt2Zxmfdpga0 X-Gm-Gg: ASbGncskdYT3s8BaQJKNP2b5rwl5FcSv6DefSYTZ6NujlCYDHVm5wiCfMC5l2fN2hie gyC8Y/2FG4KqqfKzLN9lK6c1uWh4D2CrZ+e+SZGqUYBtnJyAPRwG1FW1uoCboTwnpYSwih/24WP 78xwYpUk1FQUNRMmBOBydvFYl+mTjAgYwSWzcgOc9pw8YniYjfkIjmEUP/yX0T/DRFJWDNAU1eQ 0uFY53cAk/dXOpqBpqjGCxMwElJob/aBAwCzhvNX15Ph2e1n0Ho20FhcXDTjEBjxOqGH4DfqfhX zinygknSyOx/5gK0hJqj2csRIMS7T/uaKhYW9wyuqmEMrR1mcneWyfVNX+J9oM0EHH6cgbR6kTH InNNUkhTj3ak= X-Google-Smtp-Source: AGHT+IHyuSj3krDp+IbqWrLbMenuFyc8aPXLf+QPP3IwG1yAbhPpKo2qi5/KmvAj5wUbOYDkY26Agg== X-Received: by 2002:a17:903:187:b0:234:d41e:f0e6 with SMTP id d9443c01a7336-234d41ef29cmr60260685ad.34.1748459514153; Wed, 28 May 2025 12:11:54 -0700 (PDT) Received: from howard.lan (c-73-202-46-50.hsd1.ca.comcast.net. [73.202.46.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-234d35ac417sm15172215ad.169.2025.05.28.12.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 12:11:53 -0700 (PDT) From: Howard Chu To: acme@kernel.org Cc: mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, peterz@infradead.org, kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Howard Chu Subject: [PATCH v3 2/6] perf test trace: Remove set -e and print trace test's error messages Date: Wed, 28 May 2025 12:11:44 -0700 Message-ID: <20250528191148.89118-3-howardchu95@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250528191148.89118-1-howardchu95@gmail.com> References: <20250528191148.89118-1-howardchu95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently perf test utilizes the set -e option in shell that exit immediately if a command exits with a non-zero status, this prevents further error handling and introduces ambiguity. This patch removes set -e and prints the error message after invoking perf trace during perf tests. In my case, the command that exits with a non-zero status is perf trace instead of grep, because it can't find the 'timer:hrtimer_setup' tracepoint, see below. Before: $ sudo /tmp/perf test enum -vv 107: perf trace enum augmentation tests: 107: perf trace enum augmentation tests : = Running --- start --- test child forked, pid 783533 Checking if vmlinux exists Tracing syscall landlock_add_rule Tracing non-syscall tracepoint syscall ---- end(-1) ---- 107: perf trace enum augmentation tests : = FAILED! After: $ sudo /tmp/perf test enum -vv 107: perf trace enum augmentation tests: 107: perf trace enum augmentation tests : = Running --- start --- test child forked, pid 851658 Checking if vmlinux exists Tracing syscall landlock_add_rule Tracing non-syscall tracepoint timer:hrtimer_setup,timer:hrtimer_start [tracepoint failure] Failed to trace tracepoint timer:hrtimer_setup,tim= er:hrtimer_start, output: event syntax error: 'timer:hrtimer_setup,timer:hrtimer_start' \___ unknown tracepoint Error: File /sys/kernel/tracing//events/timer/hrtimer_setup not found. Hint: Perhaps this kernel misses some CONFIG_ setting to enable this = feature?. Run 'perf list' for a list of valid events Usage: perf trace [] [] or: perf trace [] -- [] or: perf trace record [] [] or: perf trace record [] -- [] -e, --event event/syscall selector. use 'perf list' to list avai= lable events---- end(-1) ---- 107: perf trace enum augmentation tests : = FAILED! Signed-off-by: Howard Chu Tested-by: Namhyung Kim --- tools/perf/tests/shell/trace_btf_enum.sh | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/tools/perf/tests/shell/trace_btf_enum.sh b/tools/perf/tests/sh= ell/trace_btf_enum.sh index b3775209a0b1..f59ba34fac4c 100755 --- a/tools/perf/tests/shell/trace_btf_enum.sh +++ b/tools/perf/tests/shell/trace_btf_enum.sh @@ -3,7 +3,6 @@ # SPDX-License-Identifier: GPL-2.0 =20 err=3D0 -set -e =20 syscall=3D"landlock_add_rule" non_syscall=3D"timer:hrtimer_setup,timer:hrtimer_start" @@ -34,22 +33,24 @@ trace_landlock() { return fi =20 - if perf trace -e $syscall $TESTPROG 2>&1 | \ - grep -q -E ".*landlock_add_rule\(ruleset_fd: 11, rule_type: (LANDLOCK= _RULE_PATH_BENEATH|LANDLOCK_RULE_NET_PORT), rule_attr: 0x[a-f0-9]+, flags: = 45\) =3D -1.*" + output=3D"$(perf trace -e $syscall $TESTPROG 2>&1)" + if echo "$output" | grep -q -E ".*landlock_add_rule\(ruleset_fd: 11, rul= e_type: (LANDLOCK_RULE_PATH_BENEATH|LANDLOCK_RULE_NET_PORT), rule_attr: 0x[= a-f0-9]+, flags: 45\) =3D -1.*" then err=3D0 else + printf "[syscall failure] Failed to trace syscall $syscall, output:\n$out= put\n" err=3D1 fi } =20 trace_non_syscall() { - echo "Tracing non-syscall tracepoint ${non-syscall}" - if perf trace -e $non_syscall --max-events=3D1 2>&1 | \ - grep -q -E '.*timer:hrtimer_.*\(.*mode: HRTIMER_MODE_.*\)$' + echo "Tracing non-syscall tracepoint ${non_syscall}" + output=3D"$(perf trace -e $non_syscall --max-events=3D1 2>&1)" + if echo "$output" | grep -q -E '.*timer:hrtimer_.*\(.*mode: HRTIMER_MODE= _.*\)$' then err=3D0 else + printf "[tracepoint failure] Failed to trace tracepoint $non_syscall, out= put:\n$output\n" err=3D1 fi } --=20 2.45.2 From nobody Fri Dec 19 17:17:44 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 806E821B9D8; Wed, 28 May 2025 19:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459518; cv=none; b=XRNa05FX2QsRRKXDbBbhUKbVrFYlTkDcSflly5zKbCDHKE+Nnzwdb2RsWjAzqQNCWUZH0Ex7ufsbfic5gMVklo/5oav2MM94brhRZImVsonHD0l/S1Z5coZPTx/hjSgzzruT8iLL80iD1Nm1zr6Tti22XFw0ohIWMmBXRrxygjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459518; c=relaxed/simple; bh=HG/dOz1lUTBRbsbrIN5BoAJntNUMI8JcyM3yL1TC0mg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XCD5amBvRcX5E3sud28Xo8vYP/tAWvMh7Ovo6j89iw4Ffdx/s0h+avKhWxMIkJ+6jJu9SO9S1Tq1xSjWe8xThAwJrNQ03u3o45pHzbONMOlDnHRmYU3bza+0irmMBj21gh0k796C0G0Fx1Vk6zAgBCbq4D74YUFosBLGSEWA+G8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X2FJsASX; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X2FJsASX" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2345c60507bso1754615ad.0; Wed, 28 May 2025 12:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748459516; x=1749064316; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=twBj1QB2d3zPEN2bcWML/rrXbWI+c5IxpKvrPzrniRQ=; b=X2FJsASX4G6r97j3Yoq9aBXkI5CNKE8KemHjAABzGLLhJslmdM6gveoHR9tsFxp78e /krgHyWT6Ua6l8+hSV9vkaCzB7q+AOEI7O53IhZ3mn8LbCGJLswScEiqOnvM6f4ee/zr PUkE7WrYlhWzDN+hYt/0MyVBcCYLYUFQhxhYdQYn6pZvPhZv6kmxuo/Oa72cIW84Qvoo WuRXanZDVks/jns0bK+Ibs4HFoptcQjHBtumUDqURJ0Di25o83p2bExAoDJVaNU84EX1 Nvl/QtowOr2z9Z6R0SbYbUPlU5ZPyHFdkx6MemK95u1ppAOyBC6soh4RX1hE7Kef9eCi 2JVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748459516; x=1749064316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=twBj1QB2d3zPEN2bcWML/rrXbWI+c5IxpKvrPzrniRQ=; b=ZEkwuZ7oiwQ4ghU5p/t7Fn9eOuWxmiKQkOXVK34FaOajvrXdZe/C/Vry10rehTWLIJ 0TDMW9t+gVs62ZcUvAV0rAhUl6PN608akkEuLc51LKrLhnip0+UixsaWBEz7t5ajWPGq Hlu3SZnsEbqPwdxMABGBPXgQEn28pJsiXMtkN5bIey8oH0HEVKb9flHNuOujiCwDIwJa jBArXHeWWdQIF+RuR5uDyTphoLzEutUMqDZygdb8EQda3aIZP95qTI/1JPewsU68DnrJ ziwzW0+wGYoNsxRWGODFW5PkBrVGd2GGdodILxP2sQthipGBv6a68YyGCqV8ZQZ/3s4b bTqw== X-Forwarded-Encrypted: i=1; AJvYcCX/BsDevVugyQmve2OCyFa02rbwMiqvkadBEVA9rFq3oyvI05+7C0i2FI04fmoNNxqr8Mx+U9crdF7EGmM=@vger.kernel.org, AJvYcCXCk1Tk36KnafeimZQ3cZcDD9blqtP+QhhyqnMGcpRcgsOQVNQoQphcieux/HulucS3GA5kVkaav/Fd8ZeFe5gvOA==@vger.kernel.org X-Gm-Message-State: AOJu0YzqEruH+T158XNTWv1ya5UR8o+VAXruIlZuPVHd01RQoDUPlq5E 0GqSVWZRWkSDOp3XftbGUjV9HtdcHAQsUINyZC/8Lkrvf0sxV1Q4u3zF X-Gm-Gg: ASbGncsdiC3KneRTI/rdUgpksB5PAwwK8gLG/71DnfmbQ5YSR0mGWRJG1RR7m43In6V 0/6ZQQVq6qSGaBuEUfVdDnAlRLf7uLVXebP/vtYoowfqqsHyUKcpm8kxQr2ujdqxWg1OqYiAaLI amZeFw3KwxiPvTac5EdyIJdS46bS1OefzGWPtx6ApJRYPJ+t+ODzKLuT2IX8FNrqSL0m7VT342W g7Xb38LhrkbLcS0gZvLy79xh2kdSucPgI1on4RxhVKaWOXiWJGJH7XlNDrr7UqpUvkfCZPl3EMj FliJ6kzwejcuWq4RXQFZgYEON/dhLvPHFv4zqzWm0/R/RgOCon9xvGZ1L6Q1ska7rGCajBw02Cs 3IBiu93+9JDY= X-Google-Smtp-Source: AGHT+IFSKJqYrzDEq0yFr0vnEyb3QGCo+SFpMf5205tduRWVj66BoOL2uuFmly9WlBuzA4C4GQzVhA== X-Received: by 2002:a17:903:19f0:b0:22d:b243:2fee with SMTP id d9443c01a7336-23414f5a9e6mr258801175ad.13.1748459515593; Wed, 28 May 2025 12:11:55 -0700 (PDT) Received: from howard.lan (c-73-202-46-50.hsd1.ca.comcast.net. [73.202.46.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-234d35ac417sm15172215ad.169.2025.05.28.12.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 12:11:55 -0700 (PDT) From: Howard Chu To: acme@kernel.org Cc: mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, peterz@infradead.org, kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Howard Chu Subject: [PATCH v3 3/6] perf test trace: Stop tracing hrtimer_setup event in trace enum test Date: Wed, 28 May 2025 12:11:45 -0700 Message-ID: <20250528191148.89118-4-howardchu95@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250528191148.89118-1-howardchu95@gmail.com> References: <20250528191148.89118-1-howardchu95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The event 'timer:hrtimer_setup' is relatively new, for older kernels, perf trace enum tests won't run as the event 'timer:hrtimer_setup' cannot be found. It was originally called 'timer:hrtimer_init', before being renamed in: commit 244132c4e577 ("tracing/timers: Rename the hrtimer_init event to hrti= mer_setup") Using timer:hrtimer_start should be enough for current testing, and hopefully 'start' won't be renamed in the future. Before: $ sudo /tmp/perf test enum -vv 107: perf trace enum augmentation tests: 107: perf trace enum augmentation tests : = Running --- start --- test child forked, pid 786187 Checking if vmlinux exists Tracing syscall landlock_add_rule Tracing non-syscall tracepoint timer:hrtimer_setup,timer:hrtimer_start [tracepoint failure] Failed to trace timer:hrtimer_setup,timer:hrtimer_= start tracepoint, output: event syntax error: 'timer:hrtimer_setup,timer:hrtimer_start' \___ unknown tracepoint Error: File /sys/kernel/tracing//events/timer/hrtimer_setup not found. Hint: Perhaps this kernel misses some CONFIG_ setting to enable this = feature?. Run 'perf list' for a list of valid events Usage: perf trace [] [] or: perf trace [] -- [] or: perf trace record [] [] or: perf trace record [] -- [] -e, --event event/syscall selector. use 'perf list' to list avai= lable events ---- end(-1) ---- 107: perf trace enum augmentation tests : = FAILED! After: $ sudo /tmp/perf test enum -vv 107: perf trace enum augmentation tests: 107: perf trace enum augmentation tests : = Running --- start --- test child forked, pid 808547 Checking if vmlinux exists Tracing syscall landlock_add_rule Tracing non-syscall tracepoint timer:hrtimer_start ---- end(0) ---- 107: perf trace enum augmentation tests : = Ok Signed-off-by: Howard Chu Tested-by: Namhyung Kim --- tools/perf/tests/shell/trace_btf_enum.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/shell/trace_btf_enum.sh b/tools/perf/tests/sh= ell/trace_btf_enum.sh index f59ba34fac4c..c37017bfeb5e 100755 --- a/tools/perf/tests/shell/trace_btf_enum.sh +++ b/tools/perf/tests/shell/trace_btf_enum.sh @@ -5,7 +5,7 @@ err=3D0 =20 syscall=3D"landlock_add_rule" -non_syscall=3D"timer:hrtimer_setup,timer:hrtimer_start" +non_syscall=3D"timer:hrtimer_start" =20 TESTPROG=3D"perf test -w landlock" =20 --=20 2.45.2 From nobody Fri Dec 19 17:17:44 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E5D621C188; Wed, 28 May 2025 19:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459519; cv=none; b=cT4vOmkxINj7iTBglBwRSQZvrXmFfNItQ6ZmxGjUw82FWmW/W8YmvJ8mD7ztVwYD+TWXHYCIQxkEZF/4btRvcByrDssVIe3ttjXjzhnNiNu9Lu/nMi4Wn0obcJJ2gF6ndqjFXSDyuft63UpfjTTu5ABYRMtyO8D9oG8p6Qc6nRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459519; c=relaxed/simple; bh=pYg8TLTjgS0BjbaSB6NlASqTqqK6Bkw6JNseF6OIUqo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bY/96FI+G3xcWBbffOd0/exav4KhBCMCF3wS10dto93U81Osl3xUvF//9r6L3K9na4m1kft4+zC615MnL/l3RDK0aJbK/RUZm9Yxm4fffJRMslBvCorywjYLKd93L9oRNSYi7t0BmUFDfQBvJsPDTF/alNZKtul1OrWvQETkLBs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fwVnAXpU; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fwVnAXpU" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-23461842024so2226245ad.0; Wed, 28 May 2025 12:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748459517; x=1749064317; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gg68t38uPzYyo7Ew0hkP+phW30lhRktPX+3plUsKhsk=; b=fwVnAXpUJoB1xVxlMauOuuSYc+PRdvRwSmkU45F5zlj0t808U7gTFIuZ4DspusjWlu JoJih/QtFQJA54jsnmPoeBiCg1vHAOE9ghYHYGx4nW3wNrScoxYqkXbN5UmsQTYsaftk x+VShgP0+8h6PsO3/jW43hsPOvSDhGeHpv6/BTnQ+CkPJvuKBDtJji2qqQhvxbu/dOia W0lPI5y+3FaRxI4sy834wnqWxU2Y5rJVlHhfWNLOIE+YTRCLNNZtPBHULRjJ4+LHgPXK GIlPiR4ZDZS5VY7adpwYieIpLxAdvmUe8FqO6hrb3T2NaVs2Vb7RxxAtkpnrcKD8Owjk qgzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748459517; x=1749064317; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gg68t38uPzYyo7Ew0hkP+phW30lhRktPX+3plUsKhsk=; b=TnsHOwvxADPmI4/f9W4uX5oAypp3DDLSW7X5w7YJ/BcnquE5VyzvvGPdFfkV9j+9t7 WyKZgV3O7me6UW5ODHF8pYUWOqu1d8PE0iRjfwcJuiRlxpCkYE1zDraQ33G8axUxomuX q2HZhTymLzBCC1O6GjedHkEMa5d2MAXbdZJdZaj3vuuEA0uB6tZRzSfQagU+n5R045Zy ZkFunl0+m0jGaJv6eYvbh86uAUy4RK07D+PMYNv9iIOCJqWdVPGAXbVWkWM1ork5SQSO IGHAxVgVHbzYl4QLNmcbPJFlHWSDOiM2NPrPgwJ61FLWDYIAhCrOjtoeq4Hzc2YIS7QM QYGg== X-Forwarded-Encrypted: i=1; AJvYcCXew3NSxNwaabr8gv+d8DAeOys+j8NTBSAA+kv+5nLTbHcgyDu3uVmbR88MvERmgegvQ/Zo2BVCVGgbOmg=@vger.kernel.org, AJvYcCXjz15P+REZ0BK3ifz7MV7u2gr7Y8ijO/H8M3OFSq1hmCrSA6fi55be1h4FKSN0Vilx6nUOuCYdcKfEKGxjclAMZg==@vger.kernel.org X-Gm-Message-State: AOJu0Yx1zLxxpK96aA9E7T1BEWrEEv36bGmfmKz82VFm7d51p/4E+rPR 65QemHDWEzUPTJbRhB+UXc1KF62jiRJjgVp2fbBsLR6qDfNcUWT0CYtG X-Gm-Gg: ASbGnctZ46AlhFCHOeV43uZqCtrWuxJMQK2FDwdgYj48NvUVHejpL7nV/FywAyospQK h+/y3gmTZLrXbKMDTWIhxxyp0bb6NXXWBVZvCzzrdpmT9W4OCHvRZnM1akE6DZuv7UzhY9mYxez 8EzrhwEmi02z1Z/QYOl9IbQOR3DPOjPY5t501nOaOuY0C6K0M+WCJr23phu2vRXQMYPl27OL3hW WiQHjiaMufrRR68enQH/IGjA0eY1Q9CYPJoF+LcGzeZlPNhD1UuAftHIpxsoG2bg5skQj+ENN3x EDFL1fbWYJAq3fLVh9etGGc8Sx7G7Lfw7stU6+MayucPj+Xf+Vebs563+h5w7DrpLJcd4+/9Qrx mqPRz+RZSa5I= X-Google-Smtp-Source: AGHT+IHg54B8ME0h/66c3zO4zLIROfXSjulX5yjdTcUyOVLMBcGQlPD4gqAX6TXV3N/6wrFFeLtpZQ== X-Received: by 2002:a17:903:2306:b0:234:e655:a62e with SMTP id d9443c01a7336-234e65635c1mr26256165ad.9.1748459517130; Wed, 28 May 2025 12:11:57 -0700 (PDT) Received: from howard.lan (c-73-202-46-50.hsd1.ca.comcast.net. [73.202.46.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-234d35ac417sm15172215ad.169.2025.05.28.12.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 12:11:56 -0700 (PDT) From: Howard Chu To: acme@kernel.org Cc: mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, peterz@infradead.org, kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Howard Chu Subject: [PATCH v3 4/6] perf test trace: Remove set -e for BTF general tests Date: Wed, 28 May 2025 12:11:46 -0700 Message-ID: <20250528191148.89118-5-howardchu95@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250528191148.89118-1-howardchu95@gmail.com> References: <20250528191148.89118-1-howardchu95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove set -e and print error messages in BTF general tests. Before: $ sudo /tmp/perf test btf -vv 108: perf trace BTF general tests: 108: perf trace BTF general tests : = Running --- start --- test child forked, pid 889299 Checking if vmlinux BTF exists Testing perf trace's string augmentation String augmentation test failed ---- end(-1) ---- 108: perf trace BTF general tests : = FAILED! After: $ sudo /tmp/perf test btf -vv 108: perf trace BTF general tests: 108: perf trace BTF general tests : = Running --- start --- test child forked, pid 886551 Checking if vmlinux BTF exists Testing perf trace's string augmentation String augmentation test failed, output: :886566/886566 renameat2(CWD, "/tmp/file1_RcMa", CWD, "/tmp/file2_RcMa"= , NOREPLACE) =3D 0---- end(-1) ---- 108: perf trace BTF general tests : = FAILED! Signed-off-by: Howard Chu Tested-by: Namhyung Kim --- tools/perf/tests/shell/trace_btf_general.sh | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests= /shell/trace_btf_general.sh index a25d8744695e..5fa50d815203 100755 --- a/tools/perf/tests/shell/trace_btf_general.sh +++ b/tools/perf/tests/shell/trace_btf_general.sh @@ -3,7 +3,6 @@ # SPDX-License-Identifier: GPL-2.0 =20 err=3D0 -set -e =20 # shellcheck source=3Dlib/probe.sh . "$(dirname $0)"/lib/probe.sh @@ -28,10 +27,10 @@ check_vmlinux() { =20 trace_test_string() { echo "Testing perf trace's string augmentation" - if ! perf trace -e renameat* --max-events=3D1 -- mv ${file1} ${file2} 2>= &1 | \ - grep -q -E "^mv/[0-9]+ renameat(2)?\(.*, \"${file1}\", .*, \"${file2}\= ", .*\) +=3D +[0-9]+$" + output=3D"$(perf trace -e renameat* --max-events=3D1 -- mv ${file1} ${fi= le2} 2>&1)" + if ! echo "$output" | grep -q -E "^mv/[0-9]+ renameat(2)?\(.*, \"${file1= }\", .*, \"${file2}\", .*\) +=3D +[0-9]+$" then - echo "String augmentation test failed" + printf "String augmentation test failed, output:\n$output\n" err=3D1 fi } @@ -39,20 +38,20 @@ trace_test_string() { trace_test_buffer() { echo "Testing perf trace's buffer augmentation" # echo will insert a newline (\10) at the end of the buffer - if ! perf trace -e write --max-events=3D1 -- echo "${buffer}" 2>&1 | \ - grep -q -E "^echo/[0-9]+ write\([0-9]+, ${buffer}.*, [0-9]+\) +=3D +[0= -9]+$" + output=3D"$(perf trace -e write --max-events=3D1 -- echo "${buffer}" 2>&= 1)" + if ! echo "$output" | grep -q -E "^echo/[0-9]+ write\([0-9]+, ${buffer}.= *, [0-9]+\) +=3D +[0-9]+$" then - echo "Buffer augmentation test failed" + printf "Buffer augmentation test failed, output:\n$output\n" err=3D1 fi } =20 trace_test_struct_btf() { echo "Testing perf trace's struct augmentation" - if ! perf trace -e clock_nanosleep --force-btf --max-events=3D1 -- sleep= 1 2>&1 | \ - grep -q -E "^sleep/[0-9]+ clock_nanosleep\(0, 0, \{1,\}, 0x[0-9a-f]+\)= +=3D +[0-9]+$" + output=3D"$(perf trace -e clock_nanosleep --force-btf --max-events=3D1 -= - sleep 1 2>&1)" + if ! echo "$output" | grep -q -E "^sleep/[0-9]+ clock_nanosleep\(0, 0, \= {1,\}, 0x[0-9a-f]+\) +=3D +[0-9]+$" then - echo "BTF struct augmentation test failed" + printf "BTF struct augmentation test failed, output:\n$output\n" err=3D1 fi } --=20 2.45.2 From nobody Fri Dec 19 17:17:44 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43EC621C9E0; Wed, 28 May 2025 19:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459520; cv=none; b=gD0muCOee5kRcj+7s68aUhaW7tT/WDqkiKgfboi5t2F+1YKnxAEIex/n+QbOrIItWGTgMVYBRAW3WRqgCb3upbHs+5NCkpuH09OEBO/6L7m9HZjUbK5RZyZa9Nw1L+/QnYOiSwdKKJL3oOpgVNEOE3+kgb3dlM7CrJrqeDbHysY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459520; c=relaxed/simple; bh=z0CasqAEvTfFdfOdHo4OuX7jWHBbJ5PPksEWEZz0WwQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oIBIS9LFIJJVSsnGLrcMgnrtHptXsZI1JuJyeEH670lZstU5tN4ja0nbw0nw3qnsDsODLnCUg9qS63fx6ELi9fcsbW8BVbZQVQFiWx0d2I87MgzOobvdm/6pSX4Izn6z6Tq1AEkcrHHZQFE0/xpRkykP70/4rvkow1UFMWlQHaw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VR6fG1Fd; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VR6fG1Fd" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-234f17910d8so2048385ad.3; Wed, 28 May 2025 12:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748459518; x=1749064318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UPASqWbwMcCUMi4ZOjE3DcJ6mOdKDFpi0lCkuF6a4EE=; b=VR6fG1FdZyrbSv8tsZurKS2TKaf+fcLRPwWPz12ieuqfEZdvAMtKjwcSo8/tfEwSzx anSngFcocQrG6UnUmL+vxcijy6csKiWazW2mp/s/H3UU3cXynEI1mzEjFZq0sdCmnazG SJbXsZLH/9t6REpfGwHYNa1vgoROG1YyniQXEVNR3Y0daLKegliPjrtK4CTxnxkyqI+3 mJcXqzqzOI0+TXBw1085ctiDxCQhFpI2bIn1yDnDlbDNRzBrXPx3yY8t291x1igBtRUK jybQO6lGqiWJWKFfgRXOn/gB+31hDNmB7tMxx04pXXMyWWwPPhMt7rrGN3oc7/DXvYxZ Gylw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748459518; x=1749064318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UPASqWbwMcCUMi4ZOjE3DcJ6mOdKDFpi0lCkuF6a4EE=; b=CxRYPMTc0mNaCqo7jQ8qEi0cpBdCIlfhe+ziHJlzG86ftHoUjL3KOaC6JQ9Fb8aJJr yexGBNu5uuYrc0H5SSp/hDfqZcKXy/kQ5Kl+tRjXqFh3/lc9VAnx+NicEMnKf5oeQ3zP dHTunf0yrIydTkdeSEM1cTg2bWvFRCpdCqnkw14ki4MS7T9iQB6T0QJ03G6p5W3+hdVB gF1ZehV4E16V+iaSP7tMvpKSmaKheINVx7Y3v2JLDzjSCHAod3ZwW6NyNxZmwsr4IeNJ 0/d2CvYBUioKdLgfyIgGBg4Kcap0nvaEaz/v/AD/WsDfdKaQ1QXz4zI2u10iLwsrKnIx fdmw== X-Forwarded-Encrypted: i=1; AJvYcCVz3DnTG3mSYFgHJTd2cSiw9oCW6A/qJh15TR7sip+mREATH01eMRCwQWdO8+Z3xMLe5fh/fpSPuEiJYO8=@vger.kernel.org, AJvYcCXLYzjHQM4/mA20R6Q+hzhNm4Cs22W4Mtr5pdH1ec3QttEwGzqVqi0dnlx6ABQnL7JX7sRJeQpxaK2f3kpv5WbgqQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwnWQ0rGMzheTw7tbXEglgz3KzzT08UBlKQm7DECdRYvACbXV/8 AR5XeSmmV1lfn/9smWsF6uiPzETca2KW/EtMGUEpwAbqjMS8jAObrILW X-Gm-Gg: ASbGncucXDdfg7lBee7R5NITVyscnFVHyRjKI4388iDcCzLy8eiwGjXCghmD4geZkJQ IhtyHcW3yf94+WFa8Ztvx4HvjGK0U6pEWqZt644bEExXoYxcHTSaBcRVIQOSHa1+AN54tJQsYwX +26tFKILExX7efdzMzvooxGro9F2qQmxZJLBFCIoxe3WhYoZ0SZuW1WeBbhRAFDWDsL7aBaJPlO 6OACkH1TIFz+Ro6wgx8btmDpDEHN3BjcQoUg+ZytXkycCIMnyWUl4UkikUWfBC10c7s1xC8J1CC uavAHu3XUrv4vCucb8DuK+NQMY7C9VNRrhut89Gg55oillutdEQCa+PjLmQ1+6Ka/NJVJ3/w6VE VoGXrjB0F8MU= X-Google-Smtp-Source: AGHT+IFNVo+OnHeeFkizMDit6woU+hKXUKf9ITrqjlo4oR9kFZG3EH+RCKYme07nPbuYwtPOq0PPlw== X-Received: by 2002:a17:902:e74b:b0:21f:768:cced with SMTP id d9443c01a7336-23414f3abb3mr235504275ad.8.1748459518550; Wed, 28 May 2025 12:11:58 -0700 (PDT) Received: from howard.lan (c-73-202-46-50.hsd1.ca.comcast.net. [73.202.46.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-234d35ac417sm15172215ad.169.2025.05.28.12.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 12:11:58 -0700 (PDT) From: Howard Chu To: acme@kernel.org Cc: mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, peterz@infradead.org, kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Howard Chu Subject: [PATCH v3 5/6] perf test trace BTF: Use --sort-events in BTF general tests Date: Wed, 28 May 2025 12:11:47 -0700 Message-ID: <20250528191148.89118-6-howardchu95@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250528191148.89118-1-howardchu95@gmail.com> References: <20250528191148.89118-1-howardchu95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Without the '--sort-events' flag, perf trace doesn't receive and process events based on their arrival time, thus PERF_RECORD_COMM event that assigns the correct comm to a PID, may be delivered and processed after regular samples, causing trace outputs not having a 'comm', e.g. 'mv', instead, having the default PID placeholder, e.g. ':14514'. Hopefully this answers Namhyung's question in [1]. You can simply justify the statement with this diff: [2]. Now, simply run this command multiple times: $ touch /tmp/file1 && sudo /tmp/perf trace -e renameat* -- mv /tmp/file= 1 /tmp/file2 && rm -f /tmp/file2 And you should see two types of results: $ touch /tmp/file1 && sudo /tmp/perf trace -e renameat* -- mv /tmp/file= 1 /tmp/file2 && rm -f /tmp/file2 [debug] deliver [debug] machine__process_comm_event [OVERRIDE] old :1221169 new mv str mv [debug] deliver [debug] deliver [debug] deliver [debug] deliver [debug] deliver [debug] deliver [debug] deliver [debug] deliver [debug] deliver [debug] deliver 0.000 ( 0.013 ms): mv/1221169 renameat2(olddfd: CWD, oldname: "/tmp/file1= ", newdfd: CWD, newname: "/tmp/file2", flags: NOREPLACE) =3D 0 [debug] deliver $ touch /tmp/file1 && sudo /tmp/perf trace -e renameat* -- mv /tmp/file= 1 /tmp/file2 && rm -f /tmp/file2 [debug] deliver [debug] deliver [debug] deliver [debug] deliver [debug] deliver [debug] deliver [debug] deliver 0.000 ( 0.014 ms): :1221398/1221398 renameat2(olddfd: CWD, oldname: "/tmp= /file1", newdfd: CWD, newname: "/tmp/file2", flags: NOREPLACE) =3D 0 [debug] deliver [debug] deliver [debug] machine__process_comm_event [OVERRIDE] old :1221398 new mv str mv [debug] deliver [debug] deliver [debug] deliver Anyway, use --sort-events in BTF general tests to avoid :PID, a comm is preferred. [1]: https://lore.kernel.org/linux-perf-users/Z_AeswETE5xLcPT8@google.com/ [2]: https://gist.githubusercontent.com/Sberm/6b72b2a1cf1c62244f1f996481769= baf/raw/529667bd74a2e7e1953bbd4be545bf875da8a3e7/unsorted.patch Signed-off-by: Howard Chu Tested-by: Namhyung Kim --- tools/perf/tests/shell/trace_btf_general.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests= /shell/trace_btf_general.sh index 5fa50d815203..30cd3a53f868 100755 --- a/tools/perf/tests/shell/trace_btf_general.sh +++ b/tools/perf/tests/shell/trace_btf_general.sh @@ -27,7 +27,7 @@ check_vmlinux() { =20 trace_test_string() { echo "Testing perf trace's string augmentation" - output=3D"$(perf trace -e renameat* --max-events=3D1 -- mv ${file1} ${fi= le2} 2>&1)" + output=3D"$(perf trace --sort-events -e renameat* --max-events=3D1 -- mv= ${file1} ${file2} 2>&1)" if ! echo "$output" | grep -q -E "^mv/[0-9]+ renameat(2)?\(.*, \"${file1= }\", .*, \"${file2}\", .*\) +=3D +[0-9]+$" then printf "String augmentation test failed, output:\n$output\n" @@ -38,7 +38,7 @@ trace_test_string() { trace_test_buffer() { echo "Testing perf trace's buffer augmentation" # echo will insert a newline (\10) at the end of the buffer - output=3D"$(perf trace -e write --max-events=3D1 -- echo "${buffer}" 2>&= 1)" + output=3D"$(perf trace --sort-events -e write --max-events=3D1 -- echo "= ${buffer}" 2>&1)" if ! echo "$output" | grep -q -E "^echo/[0-9]+ write\([0-9]+, ${buffer}.= *, [0-9]+\) +=3D +[0-9]+$" then printf "Buffer augmentation test failed, output:\n$output\n" @@ -48,7 +48,7 @@ trace_test_buffer() { =20 trace_test_struct_btf() { echo "Testing perf trace's struct augmentation" - output=3D"$(perf trace -e clock_nanosleep --force-btf --max-events=3D1 -= - sleep 1 2>&1)" + output=3D"$(perf trace --sort-events -e clock_nanosleep --force-btf --ma= x-events=3D1 -- sleep 1 2>&1)" if ! echo "$output" | grep -q -E "^sleep/[0-9]+ clock_nanosleep\(0, 0, \= {1,\}, 0x[0-9a-f]+\) +=3D +[0-9]+$" then printf "BTF struct augmentation test failed, output:\n$output\n" --=20 2.45.2 From nobody Fri Dec 19 17:17:44 2025 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3EED21CC52; Wed, 28 May 2025 19:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459522; cv=none; b=VP9YgBscQ1A2qxMRGo4/zhj7U0BUcNc6ph72oH2iXDW2iHXAok95+qtdJeXMSd1j/a8TTYatXy7tgfbNxRs/9nVqN5KmnYkmDbhKa/4/8WixOxqmvNjkK1K940AgY80gskT1sGWMWEoXtZQgvGXxQ8+yRQhuY7if9bFC/bKQxNI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459522; c=relaxed/simple; bh=cX550pISPQDK1DwgJ7QJM3dehdOu55JaKjaF8ro+544=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hBcgMidryUWTQRTeMTN2Y0cjMA8PfrkzzBpoQrhc4WIIjPOxMNIFlqCPkvrAgRKhxFGbNSuOmOXiUFeZ8OXodclHX4tQv9oRqGP2oh6Z5vh9sat4vkMVPJWlD6Er1AcP7gGwhZt0HqYTrgjc1EdgErDA3NjsiBl4HK25hLNARMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h+Kk4P/1; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h+Kk4P/1" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2346765d5b0so2271855ad.2; Wed, 28 May 2025 12:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748459520; x=1749064320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yWQbsbybo0AYiSDWMY4Ls7SImui0r/N9voyPkWzUhz8=; b=h+Kk4P/1kts58UpcDlhY+nUD1Ug1M0wsIOzrE4jYQhsXA94yE9AntJrxjgGbJpTpps gLEBo8qhrqrtA3mjVX0qcHlyxhibvY5JH/WicBRtiruDjFqv/ihX0Vj40fWYmgIFu7+Y ojkHhGxF0M9DAZqoeFIXcLrgX6TQrNG8jFW7IRe97kXLL7H9AgzpW/umoDCT7hLNy5Dk smq+ABHrmVSOOb9OlYDH8b90qsGWGg4iIRHPTJE4aoxHSMrNrcEpPPRbblZr74b8L+cx SccomBdxLhsmlZwDwNuCGzCI1eVx8G8I+LKd0yoxYC7VhGHZDc6SKcb59j56/tDGaGHb XGhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748459520; x=1749064320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yWQbsbybo0AYiSDWMY4Ls7SImui0r/N9voyPkWzUhz8=; b=sok5zzOrSDhDClvUJnNDtDoQ3uhQl4ZVKBSTXpVv3HfLWXESm8iwZ+vWDF/RFxRrw1 lz+JGNO/v1jRcE3EYZ1Mkp3AftWkRukoNWr9RNiklhf4dvOV+btwwsrygUi4ub6xwZmB uWkxHj8HKXZ2RkYob49JEDpwRhHvN+W3BB5GrWZN8imXqPO0fB4nTFyWVsgl9jOS5B3E I/5QC8E54trC6KGK0jYup6dpmorKztyaexw2UlxGsRVzUM75uUj1ydRPMgTnt1sjKkC6 IhVaYjINXxz1J22NQhnsMmQOAnksCLkzyHhfdIp15fh8oXgkqKDFmEA4YiR1gGSVo1AT CWNw== X-Forwarded-Encrypted: i=1; AJvYcCVxM+GsKlXj4qxSHfCOlvz5M6wNr/NB/sDvl9kL2M0Zwn8t/1f9lHiaS9aSIBOoZz5epvjsuQbKSwnCZP03RqpUIQ==@vger.kernel.org, AJvYcCWSZjpKFfcbVA6HGJ2WrmhCHUBulA1FtnGvR7NbNyBAtovCoEH+fyC1TrI5al89G9CVLoBEab2AqK/9zVk=@vger.kernel.org X-Gm-Message-State: AOJu0YwjI/Z0CYfAv74pQAT12xQLmkJww3o4RtrwfXYFKpBgNN5mhlEH gvYxh4r4Ck8bZgoL1Fhj/PCG2EYtP6df2kh859HBd2WNozcV8ewmNmzR X-Gm-Gg: ASbGncsvvkAWouB3zeqGWuRiq81Ox+E/Dnst7cVVFVnfIb6vM83N3g/X3VFqC0k/tGM mYEin631mlY90QtwDUa5o0ldC0zk0fclxmHWYp7+aA+KKm3pvSigUUon290gTXXDofQpbuj5Knv rMAIyfc/UEyS+0OSHOW56H5VEiF8QV7DjzGeRMc2vTAqMkXVqzo600gWl2VnX4Ch/IeVVYiqOTs LlQeoMGMrjT9nYrMSrQsicNrL+nzywIybrnLnv0DljIc7Nk1q32yJdjGDm3xCc+UNvARKWZ6iNB rrA9S7PDfsJQV6EnCMnPPqbM4O3SvKYez9OPgzpPVtskTYWkK5VZEU7Ct0ciAQVhK+t547rw5Rv oly8Youn30+xHDOymkyxC2g== X-Google-Smtp-Source: AGHT+IHYU4oZ9mQEkI4vOkU02K4lNP3QUSc8U901XQ2xdQK+jwkgCE2BGiA6OmUv8eYKqS7wKIt5KQ== X-Received: by 2002:a17:903:1a30:b0:223:fabd:4f99 with SMTP id d9443c01a7336-23414f334a2mr273797535ad.5.1748459520065; Wed, 28 May 2025 12:12:00 -0700 (PDT) Received: from howard.lan (c-73-202-46-50.hsd1.ca.comcast.net. [73.202.46.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-234d35ac417sm15172215ad.169.2025.05.28.12.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 12:11:59 -0700 (PDT) From: Howard Chu To: acme@kernel.org Cc: mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, peterz@infradead.org, kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Howard Chu Subject: [PATCH v3 6/6] perf test trace BTF: Change the regex pattern in the struct test Date: Wed, 28 May 2025 12:11:48 -0700 Message-ID: <20250528191148.89118-7-howardchu95@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250528191148.89118-1-howardchu95@gmail.com> References: <20250528191148.89118-1-howardchu95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ian mentioned a reliably occurred failure in the trace_btf_general test where he obtained trace output of: sleep/279619 clock_nanosleep(0, 0, {1,1,}, 0x7ffcd47b6450) =3D 0 But the regex pattern used for verification is "^sleep/[0-9]+ clock_nanosleep\(0, 0, \{1,\}, ..." This lead to a mismatch. The reason is, different sleep commands use different timespec data to call clock_nanosleep, on my machine, the value of tv_nsec is 0. ~~~ $ sudo /tmp/perf/perf trace -e clock_nanosleep -- sleep 1 0.000 (1000.196 ms): sleep/54261 clock_nanosleep(rqtp: { .tv_sec: 1, .tv_nsec: 0 }, rmtp: 0x7ffe13529550) =3D 0 ~~~ While Ian had this trace log: ~~~ $ sudo /tmp/perf/perf trace -e clock_nanosleep -- sleep 1 0.000 (1000.208 ms): sleep/1710732 clock_nanosleep(rqtp: { .tv_sec: 1, .tv_nsec: 1 }, rmtp: 0x7ffc091f4090) =3D 0 ~~~ Because sleep's behavior of setting 'tv_nsec' is not certain, and tv_sec is most definitely 1, this patch relaxes the key regex pattern to '\{1,.*\}' for a better chance of matching. Signed-off-by: Howard Chu Reported-by: Ian Rogers Tested-by: Namhyung Kim --- tools/perf/tests/shell/trace_btf_general.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests= /shell/trace_btf_general.sh index 30cd3a53f868..ef2da806be6b 100755 --- a/tools/perf/tests/shell/trace_btf_general.sh +++ b/tools/perf/tests/shell/trace_btf_general.sh @@ -49,7 +49,7 @@ trace_test_buffer() { trace_test_struct_btf() { echo "Testing perf trace's struct augmentation" output=3D"$(perf trace --sort-events -e clock_nanosleep --force-btf --ma= x-events=3D1 -- sleep 1 2>&1)" - if ! echo "$output" | grep -q -E "^sleep/[0-9]+ clock_nanosleep\(0, 0, \= {1,\}, 0x[0-9a-f]+\) +=3D +[0-9]+$" + if ! echo "$output" | grep -q -E "^sleep/[0-9]+ clock_nanosleep\(0, 0, \= {1,.*\}, 0x[0-9a-f]+\) +=3D +[0-9]+$" then printf "BTF struct augmentation test failed, output:\n$output\n" err=3D1 --=20 2.45.2