From nobody Wed Feb 11 05:37:00 2026 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CD8F17B50A for ; Wed, 28 May 2025 17:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748455096; cv=none; b=L3JWz08UU6bRmFhS55oik6xibILYtP+dqRj2x+SnGGgueB/kHDRUWBGw2HRxjgyICOBA59+xaBybFdPSoSlMSSuQugO5+NPp9utPIA+Uu87csuxoSTXsLEUCJZe+ExEihe8dcem0zbGgCptC3gCBCkvbBcnigdxtOxNCNIUijLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748455096; c=relaxed/simple; bh=GiBxw+zm//U/C+YTQyovbdu6MSyJ+bZDAcgLx/2Kbzg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KF7oP80z7de9zfFEdYBriLOnZHuJOTAOyiPoU5SIZxMY9y+ciFsybGp/KVIFMEut5n3a5qo8uyHWKwObt7Ixloe3y5j9lAmmBIJPCI0GVVHDsT2WXeS4DExVngPq+UuyZTf8BhenngRxFBFyRSWttYH6+QElrMU9ygHEY3RTZy4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=hEioQEYj; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hEioQEYj" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5533303070cso968090e87.2 for ; Wed, 28 May 2025 10:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1748455093; x=1749059893; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B3ix9DwpCMClF3M2JTkGqryLw82zMUUM9JySNSXWuyo=; b=hEioQEYj+rHQRZDZqjzH9Bftp1Av0E/CC5Ab8HjlwowUY6T0Pf78V6LKhtOontDeVT KL1AMkSKCCmuVvk+YyWYLu5d1pPBSSYIiSfqwjqeq/ewfDXnGPYoQah3sh6e3W8YUNcN GsdLtMz46mMay2HfVZn/Go9WPlcfi/bvORwxA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748455093; x=1749059893; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B3ix9DwpCMClF3M2JTkGqryLw82zMUUM9JySNSXWuyo=; b=Bil3KI+r0EgEbN+fNdvStVmNLuivd8PaAwSGXAfjl9Wlmm3I5Xguit8DjHQBmZmGS1 cG5JHti344iTcjfE9ZSsuqKNAhVVAupi3w78slVcseq2N1sA3xLj9I3iNAgJEJyFrUe/ oFPrfMhvZyNNudskSPTp40PivPb+G2QbAZv6TVX6HULd8WnrPZSK+Hl7KG89Unl4shHu Qxu1vPkykymkELwYhWBx/QM//xhg5vHsBaQ3ZxIDtwDTlDVvZCL0jrWmrWC+SAS1SHFK /er8vK22Y8vcxKeDlwXRXi/HlmS+q4sg/jZJmdYzfNUXa0ktnRYOxiVMHTGwf1deSazm z7Jw== X-Forwarded-Encrypted: i=1; AJvYcCW/XD3Oow+YHLvXh90rD9VKqbRnpaW5NfKtN1quYK/YC9jMfRt8H4kqnximvQ6RKubZeerdzOETqAGvYtw=@vger.kernel.org X-Gm-Message-State: AOJu0YxUb2y3xeyg8u7lFOU6kOArJoinXjr+r5/1KL2qbUpe/Lj3PY8V +nUaXhCiI8FeENStGulcF88EXkLJBsXAM/RALrmPUkdYM6iPJe+lToeVsQJwZbFPFQ== X-Gm-Gg: ASbGncubM+rtt4h58R0zNxVJkFbTJolFwNMJJziXBg1ec6gjHxz9Ru+R0BHRwHZS7Wo MPinKcVAKDj2BwmlHlr5Flo+dY8DEIGN9geWnS3xMKWgvzVJi7t55nOlkLbYEPePXPPUdDukhnN aZPhFxf2tnz+F6oJnOCRIWR9jN6JkMnjxOjw3BtoExeTe9a/0mwVKdzJSI0u5VPmtGQZV+OStHV NH704V+H0Zfj3CzNiqqiZFFOulYU5mNxsaadg+6sqr8CG8oc/v+ipwxssO+4nAVYfUDnGNRS4d9 Q15dlhE29ok4ZysrlUD5fBxql7IZRL8dR/vXtVQNdI/vzY7xYA8tFTNVeo8TW/OBtxsHV3J0YE2 nJtyfOsRH1JZZqJrd6LRpu0YNUQ== X-Google-Smtp-Source: AGHT+IG8Ik02jUgFA76IfXTO5TiYpbVuuWGX8ycRq2oZO4GvQe/uL9xzy0M7+OF/XwRGSYiVVuG2tA== X-Received: by 2002:a05:6512:31cd:b0:553:34b7:5731 with SMTP id 2adb3069b0e04-55334b7581bmr712001e87.3.1748455093108; Wed, 28 May 2025 10:58:13 -0700 (PDT) Received: from ribalda.c.googlers.com (90.52.88.34.bc.googleusercontent.com. [34.88.52.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5532f62a6eesm376805e87.98.2025.05.28.10.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 10:58:12 -0700 (PDT) From: Ricardo Ribalda Date: Wed, 28 May 2025 17:57:56 +0000 Subject: [PATCH 1/9] media: uvcvideo: Refactor uvc_queue_streamon Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250528-uvc-grannular-invert-v1-1-d01581f9cc25@chromium.org> References: <20250528-uvc-grannular-invert-v1-0-d01581f9cc25@chromium.org> In-Reply-To: <20250528-uvc-grannular-invert-v1-0-d01581f9cc25@chromium.org> To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 Do uvc_pm_get before we call uvc_queue_streamon. Although the current code is correct, uvc_ioctl_streamon is allways called after uvc_pm_get, this change makes the code more resiliant to future changes. Suggested-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart Link: https://lore.kernel.org/r/20250509-uvc-followup-v1-2-73bcde30d2b5@chr= omium.org Signed-off-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_v4l2.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index 668a4e9d772c6d91f045ca75e2744b3a6c69da6b..862b4e34e5b629cf324479a9bb5= 9ebe8784ccd5d 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -853,15 +853,16 @@ static int uvc_ioctl_streamon(struct file *file, void= *fh, if (handle->is_streaming) return 0; =20 - ret =3D uvc_queue_streamon(&stream->queue, type); + ret =3D uvc_pm_get(stream->dev); if (ret) return ret; =20 - ret =3D uvc_pm_get(stream->dev); + ret =3D uvc_queue_streamon(&stream->queue, type); if (ret) { - uvc_queue_streamoff(&stream->queue, type); + uvc_pm_put(stream->dev); return ret; } + handle->is_streaming =3D true; =20 return 0; --=20 2.49.0.1266.g31b7d2e469-goog