From nobody Tue Dec 16 07:08:16 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 60394248F48 for ; Tue, 27 May 2025 07:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748332273; cv=none; b=JkDb6TAEILp/GqyAOVqc33Rdyv7z0fy3PPnpV232DoJ/HX6JWJXzSlCAqfIawEpbdpSaHw3hjA8sM96c/REwKl5jQsyTfRX3KNwxnSZI8xu+sej5P406eHdqM64xojbvFVeSuwYUgs7JhnOubUjZma9q+oKXytcPLFcb2qeGokY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748332273; c=relaxed/simple; bh=ThUTx49ZOF/iAG3udI5kz7yIgv+0bAFOvYbE+pg1/Dk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fQCj1iXCUJxX63qOv+GxhTLhAsSxO9KtcPE5TBcWUdlGFBTOc65j95xm/D0HvcuoCHqrhpePvaKze8t7XykK5wt5P2U2yrFQSXyZrA54WoCqMs6npQhdx5z0sNJX6tzXRB783NkEMgzTwEaF6qvz638g6bw6MHKN3FNMKHkuJVE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2AA4150C; Tue, 27 May 2025 00:50:54 -0700 (PDT) Received: from localhost.localdomain (unknown [10.163.85.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8829E3F694; Tue, 27 May 2025 00:51:03 -0700 (PDT) From: Dev Jain To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, baohua@kernel.org, anshuman.khandual@arm.com, willy@infradead.org, ioworker0@gmail.com, yang@os.amperecomputing.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, hughd@google.com, Dev Jain Subject: [PATCH v3 1/2] mm: Call pointers to ptes as ptep Date: Tue, 27 May 2025 13:20:48 +0530 Message-Id: <20250527075049.60215-2-dev.jain@arm.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20250527075049.60215-1-dev.jain@arm.com> References: <20250527075049.60215-1-dev.jain@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid confusion between pte_t* and pte_t data types by suffixing pointer type variables with p. No functional change. Reviewed-by: Barry Song Reviewed-by: Anshuman Khandual Reviewed-by: Lorenzo Stoakes Signed-off-by: Dev Jain --- mm/mremap.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/mm/mremap.c b/mm/mremap.c index 7db9da609c84..0163e02e5aa8 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -176,7 +176,8 @@ static int move_ptes(struct pagetable_move_control *pmc, struct vm_area_struct *vma =3D pmc->old; bool need_clear_uffd_wp =3D vma_has_uffd_without_event_remap(vma); struct mm_struct *mm =3D vma->vm_mm; - pte_t *old_pte, *new_pte, pte; + pte_t *old_ptep, *new_ptep; + pte_t pte; pmd_t dummy_pmdval; spinlock_t *old_ptl, *new_ptl; bool force_flush =3D false; @@ -211,8 +212,8 @@ static int move_ptes(struct pagetable_move_control *pmc, * We don't have to worry about the ordering of src and dst * pte locks because exclusive mmap_lock prevents deadlock. */ - old_pte =3D pte_offset_map_lock(mm, old_pmd, old_addr, &old_ptl); - if (!old_pte) { + old_ptep =3D pte_offset_map_lock(mm, old_pmd, old_addr, &old_ptl); + if (!old_ptep) { err =3D -EAGAIN; goto out; } @@ -223,10 +224,10 @@ static int move_ptes(struct pagetable_move_control *p= mc, * mmap_lock, so this new_pte page is stable, so there is no need to get * pmdval and do pmd_same() check. */ - new_pte =3D pte_offset_map_rw_nolock(mm, new_pmd, new_addr, &dummy_pmdval, + new_ptep =3D pte_offset_map_rw_nolock(mm, new_pmd, new_addr, &dummy_pmdva= l, &new_ptl); - if (!new_pte) { - pte_unmap_unlock(old_pte, old_ptl); + if (!new_ptep) { + pte_unmap_unlock(old_ptep, old_ptl); err =3D -EAGAIN; goto out; } @@ -235,12 +236,12 @@ static int move_ptes(struct pagetable_move_control *p= mc, flush_tlb_batched_pending(vma->vm_mm); arch_enter_lazy_mmu_mode(); =20 - for (; old_addr < old_end; old_pte++, old_addr +=3D PAGE_SIZE, - new_pte++, new_addr +=3D PAGE_SIZE) { - if (pte_none(ptep_get(old_pte))) + for (; old_addr < old_end; old_ptep++, old_addr +=3D PAGE_SIZE, + new_ptep++, new_addr +=3D PAGE_SIZE) { + if (pte_none(ptep_get(old_ptep))) continue; =20 - pte =3D ptep_get_and_clear(mm, old_addr, old_pte); + pte =3D ptep_get_and_clear(mm, old_addr, old_ptep); /* * If we are remapping a valid PTE, make sure * to flush TLB before we drop the PTL for the @@ -258,7 +259,7 @@ static int move_ptes(struct pagetable_move_control *pmc, pte =3D move_soft_dirty_pte(pte); =20 if (need_clear_uffd_wp && pte_marker_uffd_wp(pte)) - pte_clear(mm, new_addr, new_pte); + pte_clear(mm, new_addr, new_ptep); else { if (need_clear_uffd_wp) { if (pte_present(pte)) @@ -266,7 +267,7 @@ static int move_ptes(struct pagetable_move_control *pmc, else if (is_swap_pte(pte)) pte =3D pte_swp_clear_uffd_wp(pte); } - set_pte_at(mm, new_addr, new_pte, pte); + set_pte_at(mm, new_addr, new_ptep, pte); } } =20 @@ -275,8 +276,8 @@ static int move_ptes(struct pagetable_move_control *pmc, flush_tlb_range(vma, old_end - len, old_end); if (new_ptl !=3D old_ptl) spin_unlock(new_ptl); - pte_unmap(new_pte - 1); - pte_unmap_unlock(old_pte - 1, old_ptl); + pte_unmap(new_ptep - 1); + pte_unmap_unlock(old_ptep - 1, old_ptl); out: if (pmc->need_rmap_locks) drop_rmap_locks(vma); --=20 2.30.2 From nobody Tue Dec 16 07:08:16 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0C9781FDA for ; Tue, 27 May 2025 07:51:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748332283; cv=none; b=Tl9rt2pB+Po2JCvX23hnFmjMl3VDEneATATIrEdCp3B3+C53mQod4+dUmP8cQBdgWkdOV7teNwI4uu6JejRhPk9vh493izpnUPoqQ3gXNaMdnKVEMZNYcTgvNQSTTM8NJzvJEwgS1CHqli/7AdaJhpGbbDO2oQLBPEXukb1jjbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748332283; c=relaxed/simple; bh=vYDQyzHSKBnSWwXwBVNZsHhXumIsta3zonGSrGMYiVU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sDoeIKuGERwO42KYunb3HHSLTtmaYbG9ytE0xT7H6HZrjte9x5D5bWI+LuR5FlgIiOihActuVGSWCIl/xGeQoHEyJxsRIMfYPaQv2dGZkDiGBSYyvJzkC2xDCqqmVeSYnjYUQsWtA/+pXWPe5EjKeZEs7pZtOmpugcHwDr1naMo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6626E14BF; Tue, 27 May 2025 00:51:02 -0700 (PDT) Received: from localhost.localdomain (unknown [10.163.85.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 185893F694; Tue, 27 May 2025 00:51:10 -0700 (PDT) From: Dev Jain To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, baohua@kernel.org, anshuman.khandual@arm.com, willy@infradead.org, ioworker0@gmail.com, yang@os.amperecomputing.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, hughd@google.com, Dev Jain Subject: [PATCH v3 2/2] mm: Optimize mremap() by PTE batching Date: Tue, 27 May 2025 13:20:49 +0530 Message-Id: <20250527075049.60215-3-dev.jain@arm.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20250527075049.60215-1-dev.jain@arm.com> References: <20250527075049.60215-1-dev.jain@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use folio_pte_batch() to optimize move_ptes(). On arm64, if the ptes are painted with the contig bit, then ptep_get() will iterate through all 16 entries to collect a/d bits. Hence this optimization will result in a 16x reduction in the number of ptep_get() calls. Next, ptep_get_and_clear() will eventually call contpte_try_unfold() on every contig block, thus flushing the TLB for the complete large folio range. Instead, use get_and_clear_full_ptes() so as to elide TLBIs on each contig block, and on= ly do them on the starting and ending contig block. Signed-off-by: Dev Jain --- mm/mremap.c | 40 +++++++++++++++++++++++++++++++++------- 1 file changed, 33 insertions(+), 7 deletions(-) diff --git a/mm/mremap.c b/mm/mremap.c index 0163e02e5aa8..580b41f8d169 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -170,6 +170,24 @@ static pte_t move_soft_dirty_pte(pte_t pte) return pte; } =20 +/* mremap a batch of PTEs mapping the same large folio */ +static int mremap_folio_pte_batch(struct vm_area_struct *vma, unsigned lon= g addr, + pte_t *ptep, pte_t pte, int max_nr) +{ + const fpb_t flags =3D FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; + struct folio *folio; + + if (max_nr =3D=3D 1) + return 1; + + folio =3D vm_normal_folio(vma, addr, pte); + if (!folio || !folio_test_large(folio)) + return 1; + + return folio_pte_batch(folio, addr, ptep, pte, max_nr, flags, NULL, + NULL, NULL); +} + static int move_ptes(struct pagetable_move_control *pmc, unsigned long extent, pmd_t *old_pmd, pmd_t *new_pmd) { @@ -177,7 +195,7 @@ static int move_ptes(struct pagetable_move_control *pmc, bool need_clear_uffd_wp =3D vma_has_uffd_without_event_remap(vma); struct mm_struct *mm =3D vma->vm_mm; pte_t *old_ptep, *new_ptep; - pte_t pte; + pte_t old_pte, pte; pmd_t dummy_pmdval; spinlock_t *old_ptl, *new_ptl; bool force_flush =3D false; @@ -185,6 +203,8 @@ static int move_ptes(struct pagetable_move_control *pmc, unsigned long new_addr =3D pmc->new_addr; unsigned long old_end =3D old_addr + extent; unsigned long len =3D old_end - old_addr; + int max_nr_ptes; + int nr_ptes; int err =3D 0; =20 /* @@ -236,12 +256,14 @@ static int move_ptes(struct pagetable_move_control *p= mc, flush_tlb_batched_pending(vma->vm_mm); arch_enter_lazy_mmu_mode(); =20 - for (; old_addr < old_end; old_ptep++, old_addr +=3D PAGE_SIZE, - new_ptep++, new_addr +=3D PAGE_SIZE) { - if (pte_none(ptep_get(old_ptep))) + for (; old_addr < old_end; old_ptep +=3D nr_ptes, old_addr +=3D nr_ptes *= PAGE_SIZE, + new_ptep +=3D nr_ptes, new_addr +=3D nr_ptes * PAGE_SIZE) { + nr_ptes =3D 1; + max_nr_ptes =3D (old_end - old_addr) >> PAGE_SHIFT; + old_pte =3D ptep_get(old_ptep); + if (pte_none(old_pte)) continue; =20 - pte =3D ptep_get_and_clear(mm, old_addr, old_ptep); /* * If we are remapping a valid PTE, make sure * to flush TLB before we drop the PTL for the @@ -253,8 +275,12 @@ static int move_ptes(struct pagetable_move_control *pm= c, * the TLB entry for the old mapping has been * flushed. */ - if (pte_present(pte)) + if (pte_present(old_pte)) { + nr_ptes =3D mremap_folio_pte_batch(vma, old_addr, old_ptep, + old_pte, max_nr_ptes); force_flush =3D true; + } + pte =3D get_and_clear_full_ptes(mm, old_addr, old_ptep, nr_ptes, 0); pte =3D move_pte(pte, old_addr, new_addr); pte =3D move_soft_dirty_pte(pte); =20 @@ -267,7 +293,7 @@ static int move_ptes(struct pagetable_move_control *pmc, else if (is_swap_pte(pte)) pte =3D pte_swp_clear_uffd_wp(pte); } - set_pte_at(mm, new_addr, new_ptep, pte); + set_ptes(mm, new_addr, new_ptep, pte, nr_ptes); } } =20 --=20 2.30.2