From nobody Thu Dec 18 04:15:50 2025 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 082E31FDA; Tue, 27 May 2025 06:34:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748327644; cv=none; b=I+qobeysZqcIvEcSGs1BFeL3zQbrs22eTX/nTBXuUuN0HTslOwFwalrjhG+po7I1va60M2/fIQLaeQCC4+TKbHSzIpfJf+W3hyxwvPLmW+s1WaqxcxW/Vip4wNgDT7fwpua/CTLXd+7s08wV343zHUhjCfgwSZ2fR+55eX5p3dY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748327644; c=relaxed/simple; bh=JV9uwfMeqS5yo5RlpTRU1f6m93bVKCkDBbcdJfcgAzU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=HGGU9WsQyKXaqUn+N5WPhCNhsDn5QqHOMjuz1feMsbz7pLNO6Q/OiQ/f3zS4LL6qxaCXL5HsXIXoLfzffE4PWsudV1NwS97jnbvmk2kzFGLNHWtLv0Co86ZuII8l6o131zRZITkQgKY0saQucBMTS9Q7gzTM6YwDcsPb7DPxDeQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=iTT/ha7J; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="iTT/ha7J" Received: by mail.gandi.net (Postfix) with ESMTPSA id C8FF0439C2; Tue, 27 May 2025 06:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1748327632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SFColjhD+ZIQe8shEgoNm7cyd5RsBR22PLT/iSw2KnI=; b=iTT/ha7JeUVtvvaV4TC0Yo2Iun82pKT2PWEea29/lNy8pcP+X/gsT258u8YZurLw9vXbwe ZxRJuBpfJ4MGd6c/dakV2MjDrfSi+2h24j+PLtkCqdB4ypuoBe52ryvYoK4qhsKaLa8Djn fhh7q8NLLpcMb9c5Jp4Vqx6418Ro9wZhFFe3pcP5NngrDg8UIewPys25oVfqWpD8us0Erg FdPZvXa5ogYrFzIXoEBQNlB5NIEW7xVZWc/vzpRF8dKWIMysZLAqYECEbp1gHTWktF/UZu BBstWqjtJawASZAU0RcV4+sN6oZstRMO8ikf2whqRrnQOvY5yuLRurA+pYbNdQ== From: =?utf-8?q?Alexis_Lothor=C3=A9?= Date: Tue, 27 May 2025 08:33:44 +0200 Subject: [PATCH v2] net: stmmac: add explicit check and error on invalid PTP clock rate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250527-stmmac_tstamp_div-v2-1-663251b3b542@bootlin.com> X-B4-Tracking: v=1; b=H4sIAMdcNWgC/22NQQrCMBBFryKzNpJMjVVX3kNKmaapHTBNSUJQS u9uLLhz+R789xeINrCNcN0tEGzmyH4qgPsdmJGmhxXcFwaUqKVGFDE5R6ZNMZGb256zGLRWCgd 5kniBspuDHfi1Ne9N4ZFj8uG9XWT1tb9a9aeWlVCiM3QmTRUd6/rWeZ+ePB2Md9Cs6/oB1TS4B 7QAAAA= X-Change-ID: 20250522-stmmac_tstamp_div-f55112f06029 To: Alexandre Torgue , Jose Abreu , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Richard Cochran , Phil Reid Cc: Thomas Petazzoni , Maxime Chevallier , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?utf-8?q?Alexis_Lothor=C3=A9?= X-Mailer: b4 0.14.2 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdduleeikeculddtuddrgeefvddrtddtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephfffufggtgfgkffvvefosehtkeertdertdejnecuhfhrohhmpeetlhgvgihishcunfhothhhohhrrocuoegrlhgvgihishdrlhhothhhohhrvgessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepudekveeftdeifedvfefgvdfgjeduieevudeltdeulefhhefgiedvhfethffgffegnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghdpsghoohhtlhhinhdrtghomhenucfkphepvdgrtddvmeekgedvkeemfhelgegtmegvtddtmeemugeiheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtvdemkeegvdekmehfleegtgemvgdttdemmeguieehpdhhvghloheplgduledvrdduieekrddurddvtdekngdpmhgrihhlfhhrohhmpegrlhgvgihishdrlhhothhhohhrvgessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepudejpdhrtghpthhtohepmhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomhdprhgtphhtthhopehthhhomhgrshdrphgvthgriiiiohhnihessghoohhtlhhinhdrtghomhdprhgtphhtthhop egvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegrlhgvgigrnhgurhgvrdhtohhrghhuvgesfhhoshhsrdhsthdrtghomhdprhgtphhtthhopegrnhgurhgvfidonhgvthguvghvsehluhhnnhdrtghhpdhrtghpthhtohepjhhorggsrhgvuhesshihnhhophhshihsrdgtohhmpdhrtghpthhtohepphhrvghiugesvghlvggtthhrohhmrghgrdgtohhmrdgruh X-GND-Sasl: alexis.lothore@bootlin.com The stmmac platform drivers that do not open-code the clk_ptp_rate value after having retrieved the default one from the device-tree can end up with 0 in clk_ptp_rate (as clk_get_rate can return 0). It will eventually propagate up to PTP initialization when bringing up the interface, leading to a divide by 0: Division by zero in kernel. CPU: 1 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.30-00001-g48313bd576= 8a #22 Hardware name: STM32 (Device Tree Support) Call trace: unwind_backtrace from show_stack+0x18/0x1c show_stack from dump_stack_lvl+0x6c/0x8c dump_stack_lvl from Ldiv0_64+0x8/0x18 Ldiv0_64 from stmmac_init_tstamp_counter+0x190/0x1a4 stmmac_init_tstamp_counter from stmmac_hw_setup+0xc1c/0x111c stmmac_hw_setup from __stmmac_open+0x18c/0x434 __stmmac_open from stmmac_open+0x3c/0xbc stmmac_open from __dev_open+0xf4/0x1ac __dev_open from __dev_change_flags+0x1cc/0x224 __dev_change_flags from dev_change_flags+0x24/0x60 dev_change_flags from ip_auto_config+0x2e8/0x11a0 ip_auto_config from do_one_initcall+0x84/0x33c do_one_initcall from kernel_init_freeable+0x1b8/0x214 kernel_init_freeable from kernel_init+0x24/0x140 kernel_init from ret_from_fork+0x14/0x28 Exception stack(0xe0815fb0 to 0xe0815ff8) Prevent this division by 0 by adding an explicit check and error log about the actual issue. Fixes: 19d857c9038e ("stmmac: Fix calculations for ptp counters when clock = input =3D 50Mhz.") Signed-off-by: Alexis Lothor=C3=A9 Reviewed-by: Maxime Chevallier --- Changes in v2: - Add Fixes tag - Reword commit message to clarify the triggering cause of the issue - Link to v1: https://lore.kernel.org/r/20250523-stmmac_tstamp_div-v1-1-bca= 8a5a3a477@bootlin.com --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/ne= t/ethernet/stmicro/stmmac/stmmac_main.c index 918d7f2e8ba992208d7d6521a1e9dba01086058f..f68e3ece919cc88d0bf199a394b= c7e44b5dee095 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -835,6 +835,11 @@ int stmmac_init_tstamp_counter(struct stmmac_priv *pri= v, u32 systime_flags) if (!(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)) return -EOPNOTSUPP; =20 + if (!priv->plat->clk_ptp_rate) { + netdev_err(priv->dev, "Invalid PTP clock rate"); + return -EINVAL; + } + stmmac_config_hw_tstamping(priv, priv->ptpaddr, systime_flags); priv->systime_flags =3D systime_flags; =20 --- base-commit: e0e2f78243385e7188a57fcfceb6a19f723f1dff change-id: 20250522-stmmac_tstamp_div-f55112f06029 Best regards, --=20 Alexis Lothor=C3=A9, Bootlin Embedded Linux and Kernel engineering https://bootlin.com