From nobody Mon Feb 9 23:04:18 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 188A8207A25 for ; Mon, 26 May 2025 13:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748266106; cv=none; b=dKCIFvmtOEReIz8hFjhdlbiekFn4oQQsoFw06y0Tw72HqQ/krHyO5IZA3jWx7nYkDd1Oq0+F5dJXbKIE5HmNhJty3UPxvTNYhrxQ2PgerfyMFG8kZGUX6/MuqvOQ2ywKEXt0YzIYP2iyYLFIhNQuAfwARdKxSjA/i+wNp1CIYgQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748266106; c=relaxed/simple; bh=7yRg+dfR8t8qM7YDN3CmiOT2bOidYPimlJooWf0iZlk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-type; b=CsoxnxyRDzji4uUHLEr1xrV77wj6LulvN26VFze81sHdVskA7cY/98z2j+v9ymJxyZH8SsOFspggq8lQPUTdBnv2cJOOi0tqHHung02NLs47x4iCeWQBv1tl/ae5CxeGVV4NZcRB6xToO+lSf+ORlh/6A8MyUvHyiXFKDyS9kM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IcyDshW5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IcyDshW5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748266104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i0YRJWOlICqCgS45Er6beMSN4o1Be1F4DIB5uq3fyIU=; b=IcyDshW5ZsjTmRzuOqRajmZIJwoXekddLuLWs2yQcQZk2WKkT43gTNX4I66FZ6bObhPORH NQVGJ7TPs3m8azfyuso8OWgfkKOYZ9b3s36K2ke7SamfWVoB4WRd6OGF6Gj0Gs7ALT4DoU Mzg39RU2VtS/Xgvao1kBq1jdAeGWD3Q= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-rRdZDhPnOG2RIm4XzXZ6_Q-1; Mon, 26 May 2025 09:28:22 -0400 X-MC-Unique: rRdZDhPnOG2RIm4XzXZ6_Q-1 X-Mimecast-MFC-AGG-ID: rRdZDhPnOG2RIm4XzXZ6_Q_1748266101 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4d95375c6so398364f8f.0 for ; Mon, 26 May 2025 06:28:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748266100; x=1748870900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i0YRJWOlICqCgS45Er6beMSN4o1Be1F4DIB5uq3fyIU=; b=OerURAc9XsSXz2SFmRWbgQR5CkpDeeBDjB72//F1Ut/QqhKbn4h8zwbWku4FRvjBEI mPxcrxwgZ/R+ayDPrehaAknMZcIJiEzSJ9T1Om+BwhE4Od6rcMM+Vp3zUO7k2Nzteo9i 5uTevsTrUC3bAJaJ/8WcdgThBeEUm6556Gq4xPBS2g4xTjqr3BxxxCFf3KwL9mgQVO5k H3fkuvVsggWjoBGB0riaDJ4dej4Qgg+f3Odtwt7T1vjoZqXwGXUZ7PlzQ3QI5SykJL+7 2cwwoz67idgh3H628YXNEo0y3+w8ECqx7bq/LK2LAC29nJJSGsjqyTb5OPjCux9L+hzL yx7g== X-Forwarded-Encrypted: i=1; AJvYcCWwJqvqYlAX3FVfGe/Zh0JqALxNlITZIroT7IACTN50heReCV5niLFgZmggjFz6uPFElI/lH4Lbh7so5Nw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx16XQwMuCQd3K1Q+BHq69yGZzBAXW3zXQRiBKWeWM02vjXdSAY a3YDb80IZoBBIthz1n5r8KasOAsyB6IlRLI3bp7CmT8pVm8IgTSama5Vdp9K7ZM5L/yo81hkWN0 Qsh3OaU1MksTCMTmQ0kHkDB9gROTRJnojGrS8MT4o+XZWOCyk/wrT6s53y4/xCjoUlQ== X-Gm-Gg: ASbGncuhr/L1ktraDfuWpwiPuPwq5CFkRs2fjEc3eP6bcJymCUZtq9Iemo0fWMbbc0j IufayebCrIMoFXI1tH17ZtGe89EcC+rUWgR/ThzwVjvKGDMAxmR9hgnZ1WBpvi6YjWiVKrZT4oI aI9pOUWJz/DsVLa7ahZnDSaYT62u2wb6icxTjouPE7k5BIfL5WP63kRm3hg69lk8bNOok/aBDi+ aXs6mHlemS9cBJa0f2quG5yesqLqok0C57Wjoh+H2EmhcJxBAF1ahQJ9r/DYTvDM3KoRfhL1KUL XjR3B5LHSXfLQkV6 X-Received: by 2002:a05:6000:4022:b0:3a3:7638:d754 with SMTP id ffacd0b85a97d-3a4cb454b98mr7833517f8f.21.1748266100568; Mon, 26 May 2025 06:28:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6pOAvbuHyLjhUOMwzoRe4s1Do1fW/hrkf0UqrCoecUCHTClHzHJUHZb8Hgf3W8Hzp8xWVNA== X-Received: by 2002:a05:6000:4022:b0:3a3:7638:d754 with SMTP id ffacd0b85a97d-3a4cb454b98mr7833471f8f.21.1748266100089; Mon, 26 May 2025 06:28:20 -0700 (PDT) Received: from lab.hqhome163.com ([81.57.75.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a4c8455e7dsm8836663f8f.9.2025.05.26.06.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 06:28:19 -0700 (PDT) From: Alessandro Carminati To: linux-kselftest@vger.kernel.org Cc: Dan Carpenter , Kees Cook , Daniel Diaz , David Gow , Arthur Grillo , Brendan Higgins , Naresh Kamboju , Andrew Morton , Maxime Ripard , Ville Syrjala , Daniel Vetter , Guenter Roeck , Alessandro Carminati , Jani Nikula , Jeff Johnson , Peter Zijlstra , Josh Poimboeuf , Shuah Khan , Linux Kernel Functional Testing , dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Alessandro Carminati Subject: [PATCH v5 3/5] Add unit tests to verify that warning backtrace suppression works. Date: Mon, 26 May 2025 13:27:53 +0000 Message-Id: <20250526132755.166150-4-acarmina@redhat.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250526132755.166150-1-acarmina@redhat.com> References: <20250526132755.166150-1-acarmina@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Guenter Roeck Add unit tests to verify that warning backtrace suppression works. If backtrace suppression does _not_ work, the unit tests will likely trigger unsuppressed backtraces, which should actually help to get the affected architectures / platforms fixed. Tested-by: Linux Kernel Functional Testing Acked-by: Dan Carpenter Reviewed-by: Kees Cook Signed-off-by: Guenter Roeck Signed-off-by: Alessandro Carminati --- lib/kunit/Makefile | 3 + lib/kunit/backtrace-suppression-test.c | 105 +++++++++++++++++++++++++ 2 files changed, 108 insertions(+) create mode 100644 lib/kunit/backtrace-suppression-test.c diff --git a/lib/kunit/Makefile b/lib/kunit/Makefile index 3195e861d63c..05fb19d69709 100644 --- a/lib/kunit/Makefile +++ b/lib/kunit/Makefile @@ -23,6 +23,9 @@ obj-y +=3D hooks.o \ =20 obj-$(CONFIG_KUNIT_TEST) +=3D kunit-test.o obj-$(CONFIG_KUNIT_TEST) +=3D platform-test.o +ifeq ($(CONFIG_KUNIT_SUPPRESS_BACKTRACE),y) +obj-$(CONFIG_KUNIT_TEST) +=3D backtrace-suppression-test.o +endif =20 # string-stream-test compiles built-in only. ifeq ($(CONFIG_KUNIT_TEST),y) diff --git a/lib/kunit/backtrace-suppression-test.c b/lib/kunit/backtrace-s= uppression-test.c new file mode 100644 index 000000000000..a3d5991b9b15 --- /dev/null +++ b/lib/kunit/backtrace-suppression-test.c @@ -0,0 +1,105 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * KUnit test for suppressing warning tracebacks + * + * Copyright (C) 2024, Guenter Roeck + * Author: Guenter Roeck + */ + +#include +#include + +static void backtrace_suppression_test_warn_direct(struct kunit *test) +{ + KUNIT_DEFINE_SUPPRESSED_WARNING(backtrace_suppression_test_warn_direct); + + KUNIT_START_SUPPRESSED_WARNING(backtrace_suppression_test_warn_direct); + WARN(1, "This backtrace should be suppressed"); + KUNIT_END_SUPPRESSED_WARNING(backtrace_suppression_test_warn_direct); + + KUNIT_EXPECT_EQ(test, KUNIT_SUPPRESSED_WARNING_COUNT(backtrace_suppressio= n_test_warn_direct), 1); +} + +static void trigger_backtrace_warn(void) +{ + WARN(1, "This backtrace should be suppressed"); +} + +static void backtrace_suppression_test_warn_indirect(struct kunit *test) +{ + KUNIT_DEFINE_SUPPRESSED_WARNING(trigger_backtrace_warn); + + KUNIT_START_SUPPRESSED_WARNING(trigger_backtrace_warn); + trigger_backtrace_warn(); + KUNIT_END_SUPPRESSED_WARNING(trigger_backtrace_warn); + + KUNIT_EXPECT_EQ(test, KUNIT_SUPPRESSED_WARNING_COUNT(trigger_backtrace_wa= rn), 1); +} + +static void backtrace_suppression_test_warn_multi(struct kunit *test) +{ + KUNIT_DEFINE_SUPPRESSED_WARNING(trigger_backtrace_warn); + KUNIT_DEFINE_SUPPRESSED_WARNING(backtrace_suppression_test_warn_multi); + + KUNIT_START_SUPPRESSED_WARNING(backtrace_suppression_test_warn_multi); + KUNIT_START_SUPPRESSED_WARNING(trigger_backtrace_warn); + WARN(1, "This backtrace should be suppressed"); + trigger_backtrace_warn(); + KUNIT_END_SUPPRESSED_WARNING(trigger_backtrace_warn); + KUNIT_END_SUPPRESSED_WARNING(backtrace_suppression_test_warn_multi); + + KUNIT_EXPECT_EQ(test, KUNIT_SUPPRESSED_WARNING_COUNT(backtrace_suppressio= n_test_warn_multi), 1); + KUNIT_EXPECT_EQ(test, KUNIT_SUPPRESSED_WARNING_COUNT(trigger_backtrace_wa= rn), 1); +} + +static void backtrace_suppression_test_warn_on_direct(struct kunit *test) +{ + KUNIT_DEFINE_SUPPRESSED_WARNING(backtrace_suppression_test_warn_on_direct= ); + + if (!IS_ENABLED(CONFIG_DEBUG_BUGVERBOSE) && !IS_ENABLED(CONFIG_KALLSYMS)) + kunit_skip(test, "requires CONFIG_DEBUG_BUGVERBOSE or CONFIG_KALLSYMS"); + + KUNIT_START_SUPPRESSED_WARNING(backtrace_suppression_test_warn_on_direct); + WARN_ON(1); + KUNIT_END_SUPPRESSED_WARNING(backtrace_suppression_test_warn_on_direct); + + KUNIT_EXPECT_EQ(test, + KUNIT_SUPPRESSED_WARNING_COUNT(backtrace_suppression_test_warn_on_direc= t), 1); +} + +static void trigger_backtrace_warn_on(void) +{ + WARN_ON(1); +} + +static void backtrace_suppression_test_warn_on_indirect(struct kunit *test) +{ + KUNIT_DEFINE_SUPPRESSED_WARNING(trigger_backtrace_warn_on); + + if (!IS_ENABLED(CONFIG_DEBUG_BUGVERBOSE)) + kunit_skip(test, "requires CONFIG_DEBUG_BUGVERBOSE"); + + KUNIT_START_SUPPRESSED_WARNING(trigger_backtrace_warn_on); + trigger_backtrace_warn_on(); + KUNIT_END_SUPPRESSED_WARNING(trigger_backtrace_warn_on); + + KUNIT_EXPECT_EQ(test, KUNIT_SUPPRESSED_WARNING_COUNT(trigger_backtrace_wa= rn_on), 1); +} + +static struct kunit_case backtrace_suppression_test_cases[] =3D { + KUNIT_CASE(backtrace_suppression_test_warn_direct), + KUNIT_CASE(backtrace_suppression_test_warn_indirect), + KUNIT_CASE(backtrace_suppression_test_warn_multi), + KUNIT_CASE(backtrace_suppression_test_warn_on_direct), + KUNIT_CASE(backtrace_suppression_test_warn_on_indirect), + {} +}; + +static struct kunit_suite backtrace_suppression_test_suite =3D { + .name =3D "backtrace-suppression-test", + .test_cases =3D backtrace_suppression_test_cases, +}; +kunit_test_suites(&backtrace_suppression_test_suite); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("KUnit test to verify warning backtrace suppression"); --=20 2.34.1