From nobody Fri Dec 19 19:16:42 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2073.outbound.protection.outlook.com [40.107.22.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 123D73594E; Mon, 26 May 2025 14:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.73 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748271251; cv=fail; b=e5Ab7NmmyQlCbcwII44g/mqqxyezJorHqKEvcmzmd86pplc+X8P5fNI/E8T/eLNRlZPEpM9cOG3X4Up0jxGvPS8oLiL5H3BhBpDM8Q5Xq0LmCT1C1GtLrQ5/p63tW5pQjBhL1km5Kam2EJ8TsU+XGCfRjE34e+W1TJ+clMgGvPc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748271251; c=relaxed/simple; bh=rpBEWzAMTtwOLzgJONSLm3+B6XKYf8u3EQiAzYtPVas=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=ZmvME3S7ZWpRhynvY/CrToYEHPJt8rGRd6GDW8JLMqH9pz78X9lPiirg2idMuw05FwDo2qGbJurVbgWaxke68ErBphANkZq96bvC3HJHFqmA2iWRZME3U3J+ivXM7nrhCIdATLCXWNJ3fVsNdaFvW+B9i6vRxVw/IKV1jdomD9E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=axis.com; spf=pass smtp.mailfrom=axis.com; dkim=pass (1024-bit key) header.d=axis.com header.i=@axis.com header.b=mPzvatbl; arc=fail smtp.client-ip=40.107.22.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=axis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=axis.com header.i=@axis.com header.b="mPzvatbl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tWBfEoUswBV1oKvxUWJBMUJr30OO+u/TYanHbgi4Ri7Ez4upAK2N7OTUiFmCYekm3hopsV2liStxB5b/e/+eEqbzeXj8WbsxzFRX1EcILYhXWXM5uDvgh7jZgl/AZFrCSTzXhSEYdEuy1hU9YfaySN0h/r0b5ENnJHaajwMJVZ28MMO1iQuAcwECR8pGDZT4RZuRgBoWW2UGfNIsTkxcUZpBV7np30e/MJkiAnTjQUiNDXrxEEQ+IEWz/u3jyZlc5Wu256bA1lZUNVWF7d/W3eznNJN0ytmgS2AIUPC3xU6anEgjZhkHHrZxrAppcnr+EhNRWspo+lGrDtWYFttQbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=St2MUIDS4Ve8WSUS/6sGoU0M7rest9FRet7CC4wN/U8=; b=ey2TqNZhZawr+10nWzLl+8auMIf1rZjp3sjLNVQ7y7xrArDLJFVZsRqtw6ulitIHAavklkgWLpSW1HOCwVvm8RjVtBB6wMhWA5cNZWNVR6jZoJu6fp0PEYlE5r9YD+JbuRDj/3AZ9Lr+nMvnLpGKiEemSCTz0mVHqyFsfcaqDi+Mz2NotPlsBBarlL8WEWQp/WSDxvb05xaYQGpjbSn/Z4cug1yNUyoHEZYmWLZx7A9hS1dyXLwFETVOy+Qn7Btv6k+1ZwgpFbZi64gno+A8jZae2/210o4bXdnslpOwC3V/0Wntc5PWQ/oH+VojpYFWUY8eOH+oqQnQDTS8Js2tlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 195.60.68.100) smtp.rcpttodomain=gmail.com smtp.mailfrom=axis.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=St2MUIDS4Ve8WSUS/6sGoU0M7rest9FRet7CC4wN/U8=; b=mPzvatblmVW5wFtiq9bqzd+8LiL3wsyd0esrZNX7oqEa9eI1b//nOswv3L3uYVuXFiNJy3NjsdZBZ9iJap0v5DdUlTkvvv3wEsuKC6mccsCD6dgyhaFH77wOwpP2vFARYzONWGtXh18A2yKx/uVqIjTDoZLz7gz0q4YORTAS7yI= Received: from AS4P250CA0027.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5e3::18) by VI1PR02MB6397.eurprd02.prod.outlook.com (2603:10a6:800:17e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.24; Mon, 26 May 2025 14:54:05 +0000 Received: from AMS0EPF000001AB.eurprd05.prod.outlook.com (2603:10a6:20b:5e3:cafe::b8) by AS4P250CA0027.outlook.office365.com (2603:10a6:20b:5e3::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.24 via Frontend Transport; Mon, 26 May 2025 14:54:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=axis.com; Received-SPF: Pass (protection.outlook.com: domain of axis.com designates 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; pr=C Received: from mail.axis.com (195.60.68.100) by AMS0EPF000001AB.mail.protection.outlook.com (10.167.16.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Mon, 26 May 2025 14:54:05 +0000 Received: from SE-MAILARCH01W.axis.com (10.20.40.15) by se-mail02w.axis.com (10.20.40.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 26 May 2025 16:54:04 +0200 Received: from se-mail01w.axis.com (10.20.40.7) by SE-MAILARCH01W.axis.com (10.20.40.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 26 May 2025 16:54:04 +0200 Received: from se-intmail02x.se.axis.com (10.4.0.28) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2507.44 via Frontend Transport; Mon, 26 May 2025 16:54:04 +0200 Received: from pc51235-2237.se.axis.com (pc51235-2237.se.axis.com [10.96.29.3]) by se-intmail02x.se.axis.com (Postfix) with ESMTP id 24F2B2CCB; Mon, 26 May 2025 16:54:04 +0200 (CEST) Received: by pc51235-2237.se.axis.com (Postfix, from userid 3319) id 1FD7040364CC; Mon, 26 May 2025 16:54:04 +0200 (CEST) From: Johan Adolfsson Date: Mon, 26 May 2025 16:54:00 +0200 Subject: [PATCH RFC v4 1/2] leds: leds-lp50xx: Handle reg to get correct multi_index Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250526-led-fix-v4-1-33345f6c4a78@axis.com> References: <20250526-led-fix-v4-0-33345f6c4a78@axis.com> In-Reply-To: <20250526-led-fix-v4-0-33345f6c4a78@axis.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Jacek Anaszewski CC: , , , Johan Adolfsson , X-Mailer: b4 0.13.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF000001AB:EE_|VI1PR02MB6397:EE_ X-MS-Office365-Filtering-Correlation-Id: c64b4ebf-a00a-4c8b-7672-08dd9c652942 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|7416014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WnptUmNScWJtRjA0NnNZMVdWd2RIb214bFZKd2RVQ3VhUTYyaTZzL1NZdFgw?= =?utf-8?B?SSthY0Q5YXFVcHh0SFdkS0dYK1ZzbHM5bnpub1FPVXNEdXkvbHUzMkl2MVM1?= =?utf-8?B?RVdKdjVHVlFka2IvenBRQjlQelcrelBuaDcrdGY2L1JCdDF5YVdGREtMdGw3?= =?utf-8?B?RVo3TVVrK0loVGRDenlvMjcvaWljaTRpdzdrUFFBVWw0ZWNpRjMwcFRQRkFN?= =?utf-8?B?MVZzREtwL2dVU2EyVmRoVk9ObG14eEluWGhSRG12MlBQZy9pcWduWmFmRGVO?= =?utf-8?B?OE00ZzNTTGVhZUVLOUltZzBnamMxWTVwYjI1bmRjNVdVenFySlZIZlF6RGpp?= =?utf-8?B?d2MrODZXVmwxa3c0TmRBZU4zc0p3elBibzc1T2kwMUFOR3UrK0QwNTE4Vjkz?= =?utf-8?B?bzArSzJMVHJDSWRJWnNrWlhnT2YvbDBLT0Fzcld6M2JudzlTUnFjbXhvclkz?= =?utf-8?B?TDJTVk5CWjlZUzcrUWVKUHdKdlJqTXYrVkVTbm5SMzFqUSt1bitVa1N5NGRW?= =?utf-8?B?eGJpbDhqejVyWHhnVGNrNFZtN0xEUkNLazFoR2w2eVNPYXhMdVBrcTdkUFlI?= =?utf-8?B?YW93SjNjUVpMOVVENi9hSy9lMnZHanpDd25RSXJPN3dqaFBGaVNrR1AzeHVE?= =?utf-8?B?ZVBPYWxvOVJoc1dqNXYyWTc4djJMWXJUOWlQbTIyZERZRGJnWjZBY2Frb2d3?= =?utf-8?B?ZSs0Z1pFSm9XSTNiTjFEb0t6a3VuTldoYWNpODFpRW5HcnNrSUNsOEpjQ1J4?= =?utf-8?B?bTRwYnd0blRKRjN2QVRwNHdTL08zR1VBYnJWTzJLM0xxQmN6K0NxQy9rT0to?= =?utf-8?B?K1Vmb1JrQUVGdncxUTFMNCtMcHY1d3hpZkg1Uml6djNhN2MzdS9yb1pUMTk0?= =?utf-8?B?REp0YU9UVTlDNUxFSG9uVTB1cTVWRU5Sb0lJbzlSSWlOZTQrQi9RNllrSlpr?= =?utf-8?B?RjdjREhDNjV5N3prVkpMK1FULzUxNC9hQ0lsMTdZZjY2ZVVhNlFoUzdUTFVX?= =?utf-8?B?TE9ZN3lIamhkT1l3aVdsL2ZCNC9pZHlOUk1lY3BsSi84b3lpelZYVlpyYUZ2?= =?utf-8?B?Y1dFUWVGRUZYQXY1VWtnNnlvbnQyMFMrUkNXQVFvMXJrVXJEcnMzdHdBQjhX?= =?utf-8?B?S3RMQysrOHBsdUpRL2U2L1B4OTd3L1RXQzhONEdKTmNjcjFNcGZRamtBMEVB?= =?utf-8?B?ZlNGUnh3bUlkaE5qL1RybmJnVzR1Unk4YWVkajQ1a0xtazAybW9rU3k0Y0xt?= =?utf-8?B?ZnJjTlh0dFdKTTM1NG1Yc3B0M3VnWFlURFRnSVVaM3hDNkdzN2UvV2svUjdr?= =?utf-8?B?TXIwQksyYThzYVpRRFpRS1RqREttb09pRTViNXl1bmxwT1ZqTWErZGp3cmd6?= =?utf-8?B?eWZrakdjTkZ2Qi9WaEZuMlFERmJJYk9Od2tLLzl1bmZOMDRsK0t4N0VyRFdK?= =?utf-8?B?bVhGMWtWa29MbzRnYzlxbldiMFNuWnAzL2c0Y3lJYkJSRnpNVG1vZnRoOFNR?= =?utf-8?B?Q0dScmpnQ3lyMEJzSlRod1praWl1YUtCL3EyVzZrOVRWaGpLSThScFl5VHFE?= =?utf-8?B?MnpVT3lBbFFaSVJzVktONTBwT2hVelo1TG5ZT1JEbDBWMDlJdnd5RDhKdnNN?= =?utf-8?B?SzB3U0JqZ2J0dnpUU1docCtzeURlaDJkOVAxdjB5akxWWW9Xcms0bUM3UjF3?= =?utf-8?B?NEx1UmhHVTFETS9BMDVTMVV5N0ZZOWx3RW9sbmpORUdCVXp6U212aGxRdVpE?= =?utf-8?B?V1R5S1ZpanBzNG9BRk4zcWZkSm1YWDN2S1R5MWdXNE5kNWFMdWQxOG5ZcjZH?= =?utf-8?B?NzBaM0swaGZSMTlpMEhQQjhhL29zL0R0ZTFrMWJybGF5NkF3eWEybjJ1SnNU?= =?utf-8?B?ckNNWXBzZFNtZVZJaUw4cXlVejBsUU9iUGtISWF2VTVPZGhVUW9oQTdCRmVt?= =?utf-8?B?L0lCTW9lamR2QngyWkVPVnA1cDBlcndRYXhBOWtEbnIybU5CbHhyekFZL3Vi?= =?utf-8?B?SDR5bitwaG1WbWY3K2JqNG5YK256SmRnRUJOODAyVllBVnpRalRPWTBFYWZM?= =?utf-8?Q?If9TON?= X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(7416014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2025 14:54:05.3901 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c64b4ebf-a00a-4c8b-7672-08dd9c652942 X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001AB.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB6397 mc_subled used for multi_index needs well defined array indexes, to guarantee the desired result, optionally use reg for that. If devicetree child nodes is processed in random or reverse order you may end up with multi_index "blue green red" instead of the expected "red green blue". If user space apps uses multi_index to deduce how to control the leds they would most likely be broken without this patch if devicetree processing is reversed (which it appears to be). arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-fuji.dts has reg set but I don't see how it can have worked without this change. If reg is not set, the previous behavior is kept, index will be in the order nodes are processed. If reg is out of range, an error is returned. reg within led child nodes starts with 0, to map to the iout in each bank. Signed-off-by: Johan Adolfsson --- drivers/leds/leds-lp50xx.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c index 02cb1565a9fb..8067aaa916bf 100644 --- a/drivers/leds/leds-lp50xx.c +++ b/drivers/leds/leds-lp50xx.c @@ -476,6 +476,7 @@ static int lp50xx_probe_dt(struct lp50xx *priv) return -ENOMEM; =20 fwnode_for_each_child_node(child, led_node) { + int multi_index =3D num_colors; ret =3D fwnode_property_read_u32(led_node, "color", &color_id); if (ret) { @@ -483,8 +484,13 @@ static int lp50xx_probe_dt(struct lp50xx *priv) dev_err(priv->dev, "Cannot read color\n"); return ret; } + ret =3D fwnode_property_read_u32(led_node, "reg", &multi_index); + if (ret =3D=3D 0 && multi_index >=3D LP50XX_LEDS_PER_MODULE) { + dev_err(priv->dev, "reg %i out of range\n", multi_index); + return -EINVAL; + } =20 - mc_led_info[num_colors].color_index =3D color_id; + mc_led_info[multi_index].color_index =3D color_id; num_colors++; } =20 --=20 2.30.2 From nobody Fri Dec 19 19:16:42 2025 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2086.outbound.protection.outlook.com [40.107.104.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A3CA6F2F2; Mon, 26 May 2025 14:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.104.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748271251; cv=fail; b=Yqhb1BIRD9IhGQ6EkNjDIs6/w3TRFRdPx8Hm4+bt1fkN+AgeIa6QQ7CqN2hHUI/Yq6IHSXPXDFkFKSd55p5pHrzBbmnEvTR+VDW0alUIyVGNnNEcTHK/0MeR9hk0hQPF9Hk64axwUdbjhHvhiVVmA/lysHr1BCkdugSASCO0SRs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748271251; c=relaxed/simple; bh=tAo3kTpL/K5SLo8tFVZ/ZOA2aNszk8+1hFZ8ofH3l3I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=CuoLO6yjWzP8zGuxFOdb/kYiNiKg80jHZFvWhXOLjsi3YodyEQk+f2yB5o6N6READHOD+q1uH1PU78oWRHo5t+EOgilxMWdmZ3t5tTSAYss2vNm5IolanGrc1NA4T74nulvE4vILrUYioYF3nae1QolAG3UwayQOU6F+r+h7p5I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=axis.com; spf=pass smtp.mailfrom=axis.com; dkim=pass (1024-bit key) header.d=axis.com header.i=@axis.com header.b=eHx+QQXP; arc=fail smtp.client-ip=40.107.104.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=axis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=axis.com header.i=@axis.com header.b="eHx+QQXP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NwiRD2kLUyp6AT/vx7g1r6NOsSLtXc48ophWESrMOFaH4W5aFZDEuI+ztc/3FkP1TlNvATxd7U17hRSw9u7KbtnHDmqhk2Y0aKnVqnMftBrU6/TpP9CGCSPYI9uAKEcg7lXiQDRcQIWFKk0YcS0X+aE5mcy7MpvAGcaG1TzP8g7jD5FFkkgoGWM0TJyuqLE9Wwn1iXNbscs+PwPCSY4W9f0oe47F0GAxAlkOPLEwWZqpzTlQSMW4uR+vwsoYUMhZul7cp0+iuo8DhFUvgS3Woax/ZUEJhtuGR4oyCFlTiEMkhVWqUgth8sXoOzNc0dK+CPQfLD3yKIy8amcjCRS6rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ihjC4ne/Ti+iDFOMsC7LEOdMYvyoE98Hz/Nrmnif4T4=; b=pceHh3w7MbQCCOuPTg/7O+kT1AXMm6UQYylh5oP4VlihpiOtTjiLSlQCo76pl+GTzKHpdoL1z1ISBTfRBc2p9j4g0yACoS5DNVqJSX/ALPv8cFXFxC8xcZLLWi7z1yZ+xTOmMXq5xuqD+WmUyjwcFTB4+NZPkasY+7nWCS9aE9piZ2dHEAFYAfmjx1+Op32vQu2Ur7+jWMUjEGFhxd4cHRBF+Qoxs6T3IPwe0dO79waXbRTuuSlS9lxC0aTkHIF0wG9e/en0Da2K68crjUsQddYAx0NOPpmRvooonP+3l8cIVX8jXWgVUrwfHZIPGjY64xtoQpJVdCUk9Cj1v/KVXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 195.60.68.100) smtp.rcpttodomain=gmail.com smtp.mailfrom=axis.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ihjC4ne/Ti+iDFOMsC7LEOdMYvyoE98Hz/Nrmnif4T4=; b=eHx+QQXPxwl6GTjuJZ4JtzN8isUG7R2El3awtlUe8iEVo8beEHbZz60Usqy1xwAtwizan5SsXN7KfCoyKMzlrqX0HwY1+sISi3Y0gZeSDOLF/QXB/2G16JmGhArdU1WXRD0UPQ8g2PYMICj4rVYKA+PNPV2C/aLWFEZqNRG7hNk= Received: from DU2PR04CA0011.eurprd04.prod.outlook.com (2603:10a6:10:3b::16) by PR3PR02MB6378.eurprd02.prod.outlook.com (2603:10a6:102:72::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.23; Mon, 26 May 2025 14:54:05 +0000 Received: from DB1PEPF00050A00.eurprd03.prod.outlook.com (2603:10a6:10:3b:cafe::e5) by DU2PR04CA0011.outlook.office365.com (2603:10a6:10:3b::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Mon, 26 May 2025 14:54:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=axis.com; Received-SPF: Pass (protection.outlook.com: domain of axis.com designates 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; pr=C Received: from mail.axis.com (195.60.68.100) by DB1PEPF00050A00.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Mon, 26 May 2025 14:54:05 +0000 Received: from SE-MAIL21W.axis.com (10.20.40.16) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 26 May 2025 16:54:04 +0200 Received: from se-mail02w.axis.com (10.20.40.8) by SE-MAIL21W.axis.com (10.20.40.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 26 May 2025 16:54:04 +0200 Received: from se-intmail01x.se.axis.com (10.4.0.28) by se-mail02w.axis.com (10.20.40.8) with Microsoft SMTP Server id 15.1.2507.44 via Frontend Transport; Mon, 26 May 2025 16:54:04 +0200 Received: from pc51235-2237.se.axis.com (pc51235-2237.se.axis.com [10.96.29.3]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id 25ACB4295; Mon, 26 May 2025 16:54:04 +0200 (CEST) Received: by pc51235-2237.se.axis.com (Postfix, from userid 3319) id 2121440364D0; Mon, 26 May 2025 16:54:04 +0200 (CEST) From: Johan Adolfsson Date: Mon, 26 May 2025 16:54:01 +0200 Subject: [PATCH RFC v4 2/2] dt-bindings: leds: lp50xx: Document child reg, fix example Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250526-led-fix-v4-2-33345f6c4a78@axis.com> References: <20250526-led-fix-v4-0-33345f6c4a78@axis.com> In-Reply-To: <20250526-led-fix-v4-0-33345f6c4a78@axis.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Jacek Anaszewski CC: , , , Johan Adolfsson , X-Mailer: b4 0.13.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF00050A00:EE_|PR3PR02MB6378:EE_ X-MS-Office365-Filtering-Correlation-Id: a904fccf-6d08-465c-b0a4-08dd9c65291a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UURFbmZSUVM5WmxmUXNKdmszL3NBaWRkL2RQUWtPZUFLWnpvSmh0QzBBcnF1?= =?utf-8?B?UlR2V2pmczB5YjQvWU93VUt3MkJkYVAxYkxabjV0S254Z0hwUTBXR3lLc25h?= =?utf-8?B?bEM3aklxR24vTkF3aGNXTnl2eVJ5bi9sK1RORXVNVU96Uk1BM0R5MkVPbEJB?= =?utf-8?B?K3JBblpnNjVpZjdzTlFTcjNjd1p6NlIyNG9tUWJndUc1TXhIT2p1K25ucHZS?= =?utf-8?B?cWh0STZYSTU4VlhsTC9NaXE2OGFEY1YxcDAvTVRmR25EckY1NW00c21lN0ta?= =?utf-8?B?N3ZjV09yMkxnRmtVOTQ1N2N5a2UveUtDN25BMk43MCtHYjI2VUM5S3A1dVdK?= =?utf-8?B?c29Ld2tua3VzVFBLR2hZMTNSUGkzVGNhYmlJcWhXdkZKVWFaeWlLSy82cEd4?= =?utf-8?B?aWs1d2JrVUtaSzg5UDU4NUhaSU15UURQdVRqZnpFMStqbXY1eE1yV3RsMzZt?= =?utf-8?B?czJxNXJOT0JhNis0S05qYTRENEpVMHpiUlNaUkh0ZHFLeFk4cy9lMlljN3Ay?= =?utf-8?B?RGpWU3VtTDZXcy9ydGNmRW1rc3VyUDVDdHFVZE51b254TC9IUFM3a3RBU295?= =?utf-8?B?REI0eDVYOXZlY2x0Mm5IdVJYR1BNR3lCNU10R2JSbzNMUnRRKzliNENrTGFL?= =?utf-8?B?T3Jod0hWRXZ2eDM0N05iUTMvcHNsdmZmZHdmVFlvbnZOeUZsM05GSUdxaklj?= =?utf-8?B?TWNCSEtCUFJsVThTeXBub3IyYkJiT3lKUE5pbmpmdk5IR1hZS0kyQWprSFNQ?= =?utf-8?B?VG9ta2J4MndYL3FFSzhvUmhmRkJOeGxwRk5UbjJCUjFCUDBrOVM2ZnZKbDVo?= =?utf-8?B?SzRSTG1DR2ZiMS9LSW1tcmg4aHhyRzJlY3BDdUs2YVBWVVFDSE5DUVFob0Rt?= =?utf-8?B?ZE9yazVnSmJRT2s5TERFZnRDd1FuNkJia0c3dmdJU2J2RlVTNTNqVXgvZm42?= =?utf-8?B?a1VvcnNZZW50MTUvei9OYTByTEEyRHB2cU5rWHVpa1ZhTzhscjQ1MU9rRXRW?= =?utf-8?B?cm1OUHkxZ1dNc1NpdXRZN3BpbERDQ0h2WDJxRTNqSlFqVWFFNUliTlhuN1pN?= =?utf-8?B?MFF6ZnRDUHFQQUk0cU5zVG1BUHhHUEFsb1RGZFhsdStvSmdwanBGRThodlVU?= =?utf-8?B?MS9NaE5OcmxhTkRLTVY3ZFlvL1lBaTVoNEkrSXNMWmVIaVYrWXkxTm9mRzRV?= =?utf-8?B?L3FxSDhNR2prZXpkdHg2KytPRkZHT2xibSt3ZW1Mdk02dis5U2NTSmZzaWpo?= =?utf-8?B?Z3NadDRhNkpTRWFwTXN2QXBScVVSdGxxMmUyOEJacStBRVBWRmNJazgvaGFv?= =?utf-8?B?K0I4SWU3SHZpMUtwT3hoVjRXNG9ieHAyaWlvS0llR3Rwc0hrRGFJdU9WbDB5?= =?utf-8?B?WEh4VGlvckViQmh6Wi9UUGVHM25yY0lHdWRscjV6RmlNTTBrRFY1b3BRV3VR?= =?utf-8?B?V01mK1A5T0NTWWZ1UmVRNXJRd25STmxKaWxxbUVrTFp5QW9FbXNRY2orRzJN?= =?utf-8?B?ZHF3N2pUTitnckdTdnRuS2lmVi83Syt4VklEY01UV0h3Vi9VdzdRbldXRmJI?= =?utf-8?B?TDFtSVZxUm53YjNCSVFLUUNaNUZ3cVk0M2wraFE3dzBlT3ZxZWlDbkRaSUd0?= =?utf-8?B?L1hMdFplNGZDUmh0SDBjUUxxRG15dVpBaHkwVFZlajZIR3ovUkVqSDNFTVVO?= =?utf-8?B?cE1ld1cwdmtxMjJGdmVLN0MvQmRsVTVOTi9wY05HK3NRbGk3SG1xQXplZTdJ?= =?utf-8?B?aituTEQ3TXBIOTRCeU9IKzV3eXZvS0JzWGVxL2xYZC9nSjdOem8rT1M5VjNn?= =?utf-8?B?aUh6VkYyYm02cStINVJpUjdxSWpydVNIdkUyZk92OTA0eWRzSEdrUm0yUGJq?= =?utf-8?B?MCs2S1pPdXNKQmwrU0JCTWpnOXREN0ZHQlFNc2lwZ3IyNVBtcWtncit4amtF?= =?utf-8?B?aTIra01mZHpPcTJxNnl4QzlZNEh3UjhwODVUaSswZXozaHdwRUdaSUk2MEg4?= =?utf-8?B?NEp2SjBsZXM0b2FVVU9jWFlHWDNpcFhVdHRQQVU5cEZOQWJvTHNLRWNTcElp?= =?utf-8?Q?vzFGR1?= X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2025 14:54:05.1199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a904fccf-6d08-465c-b0a4-08dd9c65291a X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF00050A00.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR02MB6378 The led child reg node is the index within the bank, document that and update the example accordingly. Signed-off-by: Johan Adolfsson --- .../devicetree/bindings/leds/leds-lp50xx.yaml | 19 ++++++++++++---= ---- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Docu= mentation/devicetree/bindings/leds/leds-lp50xx.yaml index 402c25424525..a7b2d87cc39d 100644 --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml @@ -81,7 +81,12 @@ patternProperties: =20 properties: reg: - maxItems: 1 + minimum: 0 + maximum: 2 + description: + This property denotes the index within the LED bank. + The value will act as the index in the multi_index file to g= ive + consistent result independent of devicetree processing order. =20 required: - reg @@ -138,18 +143,18 @@ examples: color =3D ; function =3D LED_FUNCTION_STANDBY; =20 - led@3 { - reg =3D <0x3>; + led@0 { + reg =3D <0x0>; color =3D ; }; =20 - led@4 { - reg =3D <0x4>; + led@1 { + reg =3D <0x1>; color =3D ; }; =20 - led@5 { - reg =3D <0x5>; + led@2 { + reg =3D <0x2>; color =3D ; }; }; --=20 2.30.2