From nobody Mon Feb 9 17:33:38 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 273BE1F5834 for ; Mon, 26 May 2025 10:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256607; cv=none; b=JmNOBks+gXX7m4CpTi5wcJf2QM4Xrdoo1Wv6AtZ4qalPHPGc+fstsL1zkiqq75fKRsrU0RPCsVck7Gp3a0+a2RcJp2EaTqrrhzA1jrEvKBr9vGUz50hGuxg8fai8e+oKM3mwehPW5jFZcJMyQXZ+ESCYGYDLkj4XMX9KWFYtUAc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256607; c=relaxed/simple; bh=XGChspJP5I3LQLqq5KcsHIKk69mbsIBA6WisBz3c/1c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LVQ5VgDGz70bMTyNxLnV+2qz2DxmUBwg+StnpgHDyhCYL4IinHxV+VHTF7AAsI76DArw9duyC/KD06r55sT/wYHEpcOtwhxb+gHTzAmxyNFjbTAtTCxTewukKfXweHJ3aBU/cK5IssJ6ELK0EKADGatVq3OL0fzF8NSKHpmIfMQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oFuxcXNc; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oFuxcXNc" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43d72b749dcso3633285e9.1 for ; Mon, 26 May 2025 03:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256604; x=1748861404; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qFXCm+Uh4tsObSJSuPLxOgv+0sGR9msvlsEdl0EYMLI=; b=oFuxcXNcc/xdNE57fPwx+5yg/aFrR2NQLLRslgRt6M0ulVYPUPHySHyqOvMmWw4PRG GTVcAz2luafG934MDWPjedSuhmHS6tCZExIOgo/7ZwuVLYRluv6wH8I3gAinhfPEhQgS hgcpIioEYfLdTUunBvnUrAGUUbuloGhYGdGLyNUvO6rJeMq+k+vJiBvSaUthEbTVhwL3 JAPcMNKme9JXoWqxAExUx8OJ9EYb8lyYuvBkV+wfVmeSWNVzZJkIv8iV7nejvKQKfYUf /ouSCb1TDWo/+IJzx70BDPJE/2qm4i7tBmuDLfEfQ7zRTrbrxYcorm4YYf53S6cAddNU jInA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256604; x=1748861404; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qFXCm+Uh4tsObSJSuPLxOgv+0sGR9msvlsEdl0EYMLI=; b=D18Z6gH0Ev2lvJwnT7YEQScGgXEbb/ShWupyIs7RR++4/7ONcEML82gqZBwyTpVXr1 Ia8rkoxzfgEsj5S+9oq3IAH+5MvdiSK2w+Bd1iwHbQgNgjQ1/Q4RnrsifRlXw3CE2Ftl 0RZEZg4No4G8J28Oc8ONXN0U4duseLYb9Hci2A3VYMsa8xeZFWNqqM1yyfiBLMpZjYED zaNl2owbBZpAU4mCybXK+ROmVsPn5aQHTV7cjFIC5fsG4P/VnqwP6LimrVchA41OUKVH xG6Z80k7XVQ9ieQoVesO4U/eGr0AqVcGlh3gbaLt4D4y41hZ5HRzPVAtF5s/i+lUHFm3 3XBQ== X-Forwarded-Encrypted: i=1; AJvYcCU3gdwPHjEnV7MjXaiVp+kHp5m9+sdxaaUkyA8LIRnim3RHoG4UYCXIvF37iTBSyQbD5AMCwTLXRQo+9yI=@vger.kernel.org X-Gm-Message-State: AOJu0YwcPvIMTkG5TXkO8P90JNTHsNswcCshwc3MSF7v2Kz2JoK3XepG N9V4witBgXCBvXSV4Ras+cklmV77ckRw7KSc9/2EsQMXjpu8FrMy7FdlUj6HXT+2pVP/NQFbV2s KKfkV X-Gm-Gg: ASbGncvAYfJkl2L40RAXj0jSBRWDM52Kgt7n61+OQRq86BuHr1gKHrEebHQnD0ukFQO gn45QlkrW3zSFVYZG7vtmaDJYICebiogrWqb6Niq8a5XGert7YokvR00RtR0m5Ne+Ukv4MbSIM9 +bVnoKuRC6ir3skn+2TTCr6W7aBgbrpy10VOXPUehJZyOAjv8XxJsGVlcBTGsq9BdyMao+wV5fk 3URrlZ54rh0+Tm7vF8eFjYideUFqqZ8F3oeDSFZ74o1msWnMpZMnmhgLpIZFSIaWk68w0RySOD7 OeHLhyw7DWSO6qrFDTZ7obz9FSrPGuzdgsyL4dwk8B+b2COTgQqXFRwshx2K0ERYx8ASZNU= X-Google-Smtp-Source: AGHT+IHYHftMvEfeiSKYWstcFFrN43xpqYIuFKIcRUyEfc0gwSeBaOs0vjH9Mu5CZOZZ/7pihewLcw== X-Received: by 2002:a05:600c:314f:b0:43d:fa58:81d2 with SMTP id 5b1f17b1804b1-44c939c15b7mr24735175e9.9.1748256604027; Mon, 26 May 2025 03:50:04 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:02 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:50 +0200 Subject: [PATCH 1/6] ASoC: codecs: wcd937x: Simplify with devm_regulator_bulk_get_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-1-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3852; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=XGChspJP5I3LQLqq5KcsHIKk69mbsIBA6WisBz3c/1c=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNEdSNq1JlnADTyFmOYOva9S2yE0qZLeRmm4Ke fgfaCsJr2OJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDRHUgAKCRDBN2bmhouD 11J6D/9AQADKnL5YeUoI8wafKTT22RpydZbuOjd0qKPDS3tzMmFKm1DhAr6ZUeFLfGbusE3Y2wC OC/4r9LWc7yKKAF2cZpQtQC9/s1FTB1g9rUrreSKKH+1X11uoJsfgJva2VN0rkUIm97G3MuguE4 U3GxzF/ExBW/ES5cCfThYZ8ABKxHrp2CdcLYu6ofFKKyd+epTFjI/196h+CVSdZVkFEHnxlUfz8 dHqpAz5wbGvwooH9fSME3CpZTqMxLzjYjfSJVet4lfLPR2Oyxps6KTUYnCiEAJeSZ9dMIywnNhF s6B3uvNgPd1Cr36Rve/zTIuY8MlIqjAxLLt1+X5c5qtn8Kz+j7gAaUSoLiaDxu9H+bAVVKk0Svl CkKVahcAvhU9RmDpmi9zYdaSkZSqoEuUd80vCw7PoM1F8321hBSdDK3rgH0gKMQu6rFbRSrhPP7 4o3xlPkhL2yOS5UPmMXU/aCAMSpc+XTSk0otabTcgJFgbeZIVbcpuaFhM2/PlNb3l7QTzu9Dq+h 7g6aWxVKofxbKpQsr4yqVJuGiXMhQEV5vCW1iGtqBfRXgkce8fdULzZ6nxXNN+5AfdJjiqa+1tH WE4R+OgaBl2oNLDuku6bU5Y3UNJfIdV0pTO6z12Gk3rvYHIW5yhkbSXw4Vdu2fBkP28Ko6v5stA vO5g48qsQ9i2FwA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Drop separate regulator get and enable in probe() path with devm_regulator_bulk_get_enable(), which simplifies cleanup paths and device remove(). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd937x.c | 31 +++++++++---------------------- sound/soc/codecs/wcd937x.h | 1 - 2 files changed, 9 insertions(+), 23 deletions(-) diff --git a/sound/soc/codecs/wcd937x.c b/sound/soc/codecs/wcd937x.c index b9df58b86ce953427e01ffb8c7eb7e52f9c2392a..92765a8693fbf87e2ba53fef756= 57ffb1b5fdb8f 100644 --- a/sound/soc/codecs/wcd937x.c +++ b/sound/soc/codecs/wcd937x.c @@ -90,7 +90,6 @@ struct wcd937x_priv { struct irq_domain *virq; struct regmap_irq_chip *wcd_regmap_irq_chip; struct regmap_irq_chip_data *irq_chip; - struct regulator_bulk_data supplies[WCD937X_MAX_BULK_SUPPLY]; struct snd_soc_jack *jack; unsigned long status_mask; s32 micb_ref[WCD937X_MAX_MICBIAS]; @@ -113,6 +112,10 @@ struct wcd937x_priv { atomic_t ana_clk_count; }; =20 +static const char * const wcd937x_supplies[] =3D { + "vdd-rxtx", "vdd-px", "vdd-mic-bias", "vdd-buck", +}; + static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(ear_pa_gain, 600, -1800); static const DECLARE_TLV_DB_SCALE(line_gain, 0, 7, 1); static const DECLARE_TLV_DB_SCALE(analog_gain, 0, 25, 1); @@ -2934,18 +2937,10 @@ static int wcd937x_probe(struct platform_device *pd= ev) cfg =3D &wcd937x->mbhc_cfg; cfg->swap_gnd_mic =3D wcd937x_swap_gnd_mic; =20 - wcd937x->supplies[0].supply =3D "vdd-rxtx"; - wcd937x->supplies[1].supply =3D "vdd-px"; - wcd937x->supplies[2].supply =3D "vdd-mic-bias"; - wcd937x->supplies[3].supply =3D "vdd-buck"; - - ret =3D devm_regulator_bulk_get(dev, WCD937X_MAX_BULK_SUPPLY, wcd937x->su= pplies); + ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(wcd937x_supplies), + wcd937x_supplies); if (ret) - return dev_err_probe(dev, ret, "Failed to get supplies\n"); - - ret =3D regulator_bulk_enable(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies); - if (ret) - return dev_err_probe(dev, ret, "Failed to enable supplies\n"); + return dev_err_probe(dev, ret, "Failed to get and enable supplies\n"); =20 wcd937x_dt_parse_micbias_info(dev, wcd937x); =20 @@ -2962,13 +2957,13 @@ static int wcd937x_probe(struct platform_device *pd= ev) =20 ret =3D wcd937x_add_slave_components(wcd937x, dev, &match); if (ret) - goto err_disable_regulators; + return ret; =20 wcd937x_reset(wcd937x); =20 ret =3D component_master_add_with_match(dev, &wcd937x_comp_ops, match); if (ret) - goto err_disable_regulators; + return ret; =20 pm_runtime_set_autosuspend_delay(dev, 1000); pm_runtime_use_autosuspend(dev); @@ -2978,25 +2973,17 @@ static int wcd937x_probe(struct platform_device *pd= ev) pm_runtime_idle(dev); =20 return 0; - -err_disable_regulators: - regulator_bulk_disable(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies); - - return ret; } =20 static void wcd937x_remove(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct wcd937x_priv *wcd937x =3D dev_get_drvdata(dev); =20 component_master_del(&pdev->dev, &wcd937x_comp_ops); =20 pm_runtime_disable(dev); pm_runtime_set_suspended(dev); pm_runtime_dont_use_autosuspend(dev); - - regulator_bulk_disable(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies); } =20 #if defined(CONFIG_OF) diff --git a/sound/soc/codecs/wcd937x.h b/sound/soc/codecs/wcd937x.h index 4ef57c496c37c555c8684d65249c53f6a8b645a1..3ab21bb5846e2c85520d67e7dc2= 48d4e7715dba5 100644 --- a/sound/soc/codecs/wcd937x.h +++ b/sound/soc/codecs/wcd937x.h @@ -487,7 +487,6 @@ #define WCD937X_MAX_REGISTER (WCD937X_DIGITAL_EFUSE_REG_31) =20 #define WCD937X_MAX_MICBIAS 3 -#define WCD937X_MAX_BULK_SUPPLY 4 #define WCD937X_MAX_SWR_CH_IDS 15 #define WCD937X_SWRM_CH_MASK(ch_idx) BIT(ch_idx - 1) =20 --=20 2.45.2 From nobody Mon Feb 9 17:33:38 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CA791F75A6 for ; Mon, 26 May 2025 10:50:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256609; cv=none; b=CUn5IUO6n5iBBL3yjNtRvSlNg/c3WJuuNnlbH7d+O7Lqp4BDs6qmPHXSO4cWT2l3Da2q5O2ZYjDNYtZFAljHqKLt+hVUwTcFLMYmCFb5442N4WZHUBMR+cPERwehZNViof9MqS15h5+qdM9yYybkLU/3Z3+2/gqlVAAvT9zRmZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256609; c=relaxed/simple; bh=FX2ZFjqB2aYhVdKNptGSxqmvCuZ9hZy30zaZX4GDw44=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PT4SYBsPZec+h50tvB0eBoo+CfRVSDd1cu4QzNTaCbdos23OnZRbxsHA8z3ZfVQRtmSjTpHywb3kiN341XPzwyIPi39XUQnfNpl0HyD5qVJ8ewHXyaEoo2lZae/x/FUldngVgFl4kSozvpTojyQ/NCMpb+o/F/KRawe1+GNfFK4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aGj5T5na; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aGj5T5na" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cfe99f2a7so3985445e9.2 for ; Mon, 26 May 2025 03:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256605; x=1748861405; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6OBa2xDaiXmKdEIq6qhKC9jrSr7c++QZFJ/xALZlOQ4=; b=aGj5T5nay07zznx8pR8v0dhboSodH1SsYkGEHtkYnkfJ4qIx+jrW9GT2sM2DFG/4HL 1CqzqPBJ7VMlaQwgVApNUww9d13ZS5PF6eKdgXJnuoCvlG5sDygrKrPwSscwlYUQrcCH msEvHED8ep5B77EEEEBImxFegE24jXNQrt5ND2/jn/OlPIhp0Ge/klfhjR+rhHtOtkfF /VedZBPyCFCQrvg9YdfaDxwhAkcwM4td2wpKW+2qz6JVQDteTHf6gmoELUWu5Ce0jiob KX3HL+oxCxjo04RAS1eVihxFt9ZQVgrZk7LLZUTawZIeI4fZkGvRp7mLf3N74kZMaocC yeZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256605; x=1748861405; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6OBa2xDaiXmKdEIq6qhKC9jrSr7c++QZFJ/xALZlOQ4=; b=PPaRSlrr9TgKwQ8dLUubw9UmyvADj1fbssYSdkkpDI/MNmZ2nGFHO8QVQfbV6JyPri usgkLIqDF3Ug0sZ+6y9NBP+6S/7P12oXQECrqN6RfSbVgSm8U+wfy4MhN5QwXg4WGWtp O7EH8yLuE18jhYC6CPW6zvSzIcIcBYFu66btGkdIjTSVn7qkECNABCtrMjOsQ3jX2RKs YLrxaIjRDglo6LeQIBKpe5RZ/Yp9BE5tns3NAh5fltf8fVcpHRT0fjfOEGLfdPDeWsqu Hg9fBaFeWdsBl9fSw0nNcZMuBDYQYwD6QAeiue3RudVs39sHmDUwqKmQfFkds0JVwEVb ednA== X-Forwarded-Encrypted: i=1; AJvYcCUMK4m20s5c4Ni1hqRkTzS2MnvoVkNBsnBa95lRGhTLHdCbJ5gMRe1Us5nFRwPntfzp6olfq2a39WgWpWM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxw/lYaYWsWXZ7KPCOJe6KMbwyjp5jLj35HWTWlqOiAD0vbQyjv tWEKV+jA7xkn/Nu5ZmOgtzewwQnabGKTrhof12QH25eEsptVoRAPZ0CLlvX8fDnB+jXAMU9XBaa mSiig X-Gm-Gg: ASbGnctyWotzTHdiGQ2IxGnBwr7ndxgtwhSLaLQTwSTcrds2xF5saAqAV1I811lXGgW rIX6WyHvCVaSaOM/Bk3hHCQG71u142eA54666lvtQ7uiO8zejogir1he+lmyH5VsqRUHHCgkhk/ wUGkANh4uzGDM99O4OfLreXfACKBmQR6H0BwReBpumM6+/UJr089ostUpjZZsyUGnEJWtY8sF++ 33BruRFF0Z+h56VIl5uE7Emhb9+HUnPUiKWrqd7IeHBw+CISeTLfL6+7HfduUYeOs6rKSCEZ4xv 9czCTsJQNKlMpeINNtb3yH0ABzQ8fKs7P23FjBSfQTG1suHdacEI1D0aBjVzApqw21LdfvcpCaD 2z5vdig== X-Google-Smtp-Source: AGHT+IFSOavn4OiSrSRdrm9EzdjRM1GrZSVArSnm26/rNTPuIKZdeK4R3ePwvsxF952fDQYtmip+zg== X-Received: by 2002:a05:600c:314f:b0:43d:fa58:81d2 with SMTP id 5b1f17b1804b1-44c939c15b7mr24735485e9.9.1748256605290; Mon, 26 May 2025 03:50:05 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:04 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:51 +0200 Subject: [PATCH 2/6] ASoC: codecs: wcd938x: Simplify with devm_regulator_bulk_get_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-2-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3617; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=FX2ZFjqB2aYhVdKNptGSxqmvCuZ9hZy30zaZX4GDw44=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNEdT4SZiF025Slz7VB0w5N98QbFUA1zL2sYW3 aTRyW0ou9iJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDRHUwAKCRDBN2bmhouD 1ymHEACD9dNrF5rGR+clcwGAMbhlbQKPvqR1x/XZrLX52FjAlS2Xm+SHUaHY6J38Y1vQaabhg5V URL5gaSkQEKGg20/QEZyFE7HPlWPhuPxqFsESzHfDQ+AqqCdsm1MkJbYnSeRfQ6q4A4UpqT6KwT iXPD0s8LES8fbpHLe3sEX0FE2RTmScWPBwbXo38Y8wFaJK8UcawkOQyFGL2jVbTknNi5pF0N1pz 40cSXezzh1ajx+7A/UcyvtN/Ki/AJLdMCF0Wzf1o/OEo/UUVoscDYExfZvCX3CwrSe6gohL+7/v 0u15LRbO7Iyp44OdB5jbq4WyNTrpYf8StE6rUsa2hGPC2Cxj6r3jd1GIjhkj+tC5HbPamB4jyRn 4g59xkDysKF7f4H4QJNrshH/AcQxwniurhYatLxTvbCL3x6EOwOwk1gbWz8MoX9Cl03ANV6zZ3o +2p6vN4E4i76zujMGBu7yM4gcbD9zEbKpwErt/v6TFD1N/UsHoU7uvzFagpMe7p8DHUVB07NAKa TbQ76qbV9ELcZVifL/uKPCrDKJs9IQrWUfj81j2ZWfiVeFZel1/QWQKFs/mVoFE6Z1a/SvK9uHK Ydbmsi87xMe+U989Gd4w6tOeyVjraXep06d6AfR8fE+q4b2OpnpViziFW3lkXProDFir1gUakys STMQ5yoE0ABiFTw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Drop separate regulator get and enable in probe() path with devm_regulator_bulk_get_enable(), which simplifies cleanup paths and device remove(). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd938x.c | 35 +++++++++-------------------------- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index b72dcd9d01720f44550d6e438498a2e7eab6dc1a..72c36c6138e1f0e33d5acb3972a= a26f7d2dd9b22 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -26,7 +26,6 @@ #include "wcd938x.h" =20 #define WCD938X_MAX_MICBIAS (4) -#define WCD938X_MAX_SUPPLY (4) #define WCD938X_MBHC_MAX_BUTTONS (8) #define TX_ADC_MAX (4) =20 @@ -161,7 +160,6 @@ struct wcd938x_priv { struct irq_domain *virq; struct regmap_irq_chip *wcd_regmap_irq_chip; struct regmap_irq_chip_data *irq_chip; - struct regulator_bulk_data supplies[WCD938X_MAX_SUPPLY]; struct snd_soc_jack *jack; unsigned long status_mask; s32 micb_ref[WCD938X_MAX_MICBIAS]; @@ -188,6 +186,10 @@ struct wcd938x_priv { bool mux_setup_done; }; =20 +static const char * const wcd938x_supplies[] =3D { + "vdd-rxtx", "vdd-io", "vdd-buck", "vdd-mic-bias", +}; + static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(ear_pa_gain, 600, -1800); static const DECLARE_TLV_DB_SCALE(line_gain, -3000, 150, 0); static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(analog_gain, 0, 3000); @@ -3293,20 +3295,10 @@ static int wcd938x_populate_dt_data(struct wcd938x_= priv *wcd938x, struct device =20 cfg->swap_gnd_mic =3D wcd938x_swap_gnd_mic; =20 - wcd938x->supplies[0].supply =3D "vdd-rxtx"; - wcd938x->supplies[1].supply =3D "vdd-io"; - wcd938x->supplies[2].supply =3D "vdd-buck"; - wcd938x->supplies[3].supply =3D "vdd-mic-bias"; - - ret =3D regulator_bulk_get(dev, WCD938X_MAX_SUPPLY, wcd938x->supplies); + ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(wcd938x_supplies), + wcd938x_supplies); if (ret) - return dev_err_probe(dev, ret, "Failed to get supplies\n"); - - ret =3D regulator_bulk_enable(WCD938X_MAX_SUPPLY, wcd938x->supplies); - if (ret) { - regulator_bulk_free(WCD938X_MAX_SUPPLY, wcd938x->supplies); - return dev_err_probe(dev, ret, "Failed to enable supplies\n"); - } + return dev_err_probe(dev, ret, "Failed to get and enable supplies\n"); =20 wcd938x_dt_parse_micbias_info(dev, wcd938x); =20 @@ -3570,13 +3562,13 @@ static int wcd938x_probe(struct platform_device *pd= ev) =20 ret =3D wcd938x_add_slave_components(wcd938x, dev, &match); if (ret) - goto err_disable_regulators; + return ret; =20 wcd938x_reset(wcd938x); =20 ret =3D component_master_add_with_match(dev, &wcd938x_comp_ops, match); if (ret) - goto err_disable_regulators; + return ret; =20 pm_runtime_set_autosuspend_delay(dev, 1000); pm_runtime_use_autosuspend(dev); @@ -3586,12 +3578,6 @@ static int wcd938x_probe(struct platform_device *pde= v) pm_runtime_idle(dev); =20 return 0; - -err_disable_regulators: - regulator_bulk_disable(WCD938X_MAX_SUPPLY, wcd938x->supplies); - regulator_bulk_free(WCD938X_MAX_SUPPLY, wcd938x->supplies); - - return ret; } =20 static void wcd938x_remove(struct platform_device *pdev) @@ -3607,9 +3593,6 @@ static void wcd938x_remove(struct platform_device *pd= ev) =20 if (wcd938x->us_euro_mux && wcd938x->mux_setup_done) mux_control_deselect(wcd938x->us_euro_mux); - - regulator_bulk_disable(WCD938X_MAX_SUPPLY, wcd938x->supplies); - regulator_bulk_free(WCD938X_MAX_SUPPLY, wcd938x->supplies); } =20 #if defined(CONFIG_OF) --=20 2.45.2 From nobody Mon Feb 9 17:33:38 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 986411F9F70 for ; Mon, 26 May 2025 10:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256611; cv=none; b=f+XwBSNtojk/9NMAQzA33A0H2Vu7cgDzs8IR3U5BBlSEIxhp7aKr02JJobBvxpRJpVjFKdhJ16tYGbxRjWxWaw4XSsamzwnoKT6hpvmOj036rky2zqNh7u0gxw8waI+M4p1JmIzDQs6w1HI5uLLG1254BJpKwHm5CD6Q9Z36Ibw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256611; c=relaxed/simple; bh=T1UmHGMEhh+HGHkTKffRpGf8EB6LiXyuaermIIJZ7Uw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O2P4wQoDw2z/O/k010Jhh0MRZI0tm9nBqG9D7SsR34yn9vG8jJE8zY/X4B51NQEd9w3GOFMkdHZmGD1pOSDGaKfpv6WvWK9Kp+R/+uSex24ZMsSKXa4NbYrYzZwkHtUE8Jov1sn08zfUWxFIqoJQxeZs6X6lExmgT5HJm80NB8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Neju5nb2; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Neju5nb2" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a4d855bed3so31972f8f.2 for ; Mon, 26 May 2025 03:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256607; x=1748861407; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GxdjNywcZoPk9rUuL+juhOPpZUTe7YyKpdPGQqOg0oU=; b=Neju5nb2tZOt+SIozvcHzX4RASBKqLNxYtLICyFhceHiRRFtr94xmrbQngzJLdvB6Z VEon1oQtLSS9j2Jldt0DZfonizB5BcoPQwxXjlkjuPB93VMoZSQNbpPtIYszg6R/iPS6 k/R+tb42ETk5ZI45EWJURNlMbXUhA+qDhUfDBSMF6P1AfKWqSfgjbzBoz84auxGsuKnD MIfbuGwTuoOxnxG/Td0s+O+UCQ6BYpMHPNz/Uxe3ORtkuGCuEYbcOTqTboOtHeQ/BLvD 1xaAT9A0mu9KziLV3dCvzwUCtnNItMjogBEjJsTWvDTEM+7O5G4Er3bLZs6bqCtSDWmU scjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256607; x=1748861407; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GxdjNywcZoPk9rUuL+juhOPpZUTe7YyKpdPGQqOg0oU=; b=Ikjy5srlI6JDiit2Ckgio71BqXmHRt6pxTTUVrk5u7Yo0bVCDqVrUU4c35jBgvOO43 7TDHbeT55cA9sDMqfmyB1PnOWlVZUaTGqowCyBiN2BkneluwPgvrheS1Pyt2NRRNBWA5 e9xWWwThcyFNpc1eUjyuWUzU7jrlTKH1daAQwkbvsR+wAZprf0s/r1vTH4PENB8dr4Eq YCyMbmI0l4tnXFnU9i6h3UcdtDHiMPZjrXE/gvrsImFFz+KAUhc5H4G7DtQ64pQvcfSm l77A/9tXDORUloC/CiBGHr9TKOagoKZZb5jcg60TFhvy5GhBaYWEWGQQPaQo2zze+tic +8mg== X-Forwarded-Encrypted: i=1; AJvYcCVAhJ1UzcIKu57ZV8ao+1RZpRIzwQ53zIRILw1A4qho3mnBPqI/VJV5xE6u2dhMr8PzClt/Hq/08yJzNn0=@vger.kernel.org X-Gm-Message-State: AOJu0YwtuINVJDrkAYzVfCPDP/cI/ELdSb0uU+As4mLDf1En7FnCC8Wy 0bFPf/tn/9YeJRx+6NAQO231ec2f2ENSQM3Jv4ZjPahu80DtlC3k4G6YHhTqXNaPpKDK5+fOjty jJ6wj X-Gm-Gg: ASbGnctlhzhHTX+IDIu/xgFRp1yIZCVxxeUjBmUImLPOeNLQAksa/He7vAH80uuM4Yj hKbbWyD/ba6h6W18MP7w+XJlyh/JCXoNtztxP9xS9XfD12m7pb1IA4HiDE9q946RmuudpsAFWUF 5I5txnnN2Y7bivAlGLpjTeGGTB3DBgHbLj3p2aJPilbJhiZyiAK4D5Zcou18hGzQ6NiqbGv20Ub d1ADCrx1IAdL9VJSFUhOAlpqYvKdofkWODkggZDpyGB0hBqj1ubU9RMcVVtXIBbI9UPwhM6OuFv IY6gzL7rCHy0oYTkYikoI+hXA6uwcPDcp5nwdfrGeqCtUn0x0eqXyb7ulUWLsFj/5W7qBIU= X-Google-Smtp-Source: AGHT+IGkrJ9NILdheV9RaN0QoLBtP4gK+AfGXmY1/vtQ2GjEgvHeVOK+paC1IUjYwHzNeti95HpQHQ== X-Received: by 2002:a05:600c:c0c3:10b0:439:94f8:fc7b with SMTP id 5b1f17b1804b1-44c90f4ccb1mr16989275e9.0.1748256607476; Mon, 26 May 2025 03:50:07 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:07 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:52 +0200 Subject: [PATCH 3/6] ASoC: codecs: wcd939x: Simplify with devm_regulator_bulk_get_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-3-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3822; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=T1UmHGMEhh+HGHkTKffRpGf8EB6LiXyuaermIIJZ7Uw=; b=kA0DAAoBwTdm5oaLg9cByyZiAGg0R1SjimkbkrXTp9xVvToa/7VuiXtcbsL/56oXOJnkwQ4nc okCMwQAAQoAHRYhBN3SYig9ERsjO264qME3ZuaGi4PXBQJoNEdUAAoJEME3ZuaGi4PXRKkQAIfo lSkuJhxgpdvo/1nZJ+/ngiqYillnf6Sw/lcFW7C1/Q87Zfu/Xz/6BReObA9Ry6mYhUDatZX4xhb sRQeNiXUcaJXiB2iV0FK960+gkdAilI0tS93SBXKvjegzbE6eNHWeKb+RtPZZ1VdCJBiiM8PHdA jyEuR95vUrbKFKTM5F6XCsFyAj1qRaR9abB74bYOAHou2Yp/nt2C9nE3TnaXW0UIo1yZPOm3rxA d83a+uKrGctHpm9Zp4kYVpOdAnLTH1IXr3JrQD0vKJ5APqRjdxbih9t3gs3M2gzmSceUSXuYOke NBAimw2CTRr2nr9+HXZhcOLqqEq9kvsCAJU0BhGKU6XNR5662SGDQCuIwMpM8+rMtd6ewxqW9BJ eq8JZtqEdBztEQxBv3G9OpDuQhl2J81gVweESupWIOZq3/cT0PedZJO64okYIBeoVXG5haN9KgI XKRYjAWz6Bbzc7Myul8vH3kRZ6VW8aOd31xkzijIlmrgkCDnYHvl0iF//y2VybZZrsO4XUg5CnP lxzluqcLap6Yh5UN6VtarEzf8W2/B22KUyp8wf0sv/4lPWRbzE/uJNqLsCOKnf6P0xkpDXiABcF TIAkd+NaYv3aEqgCnVE0ukrdJPBMAiAivd1/APHPFJl4rn127OGN2Mvg+fwBOePwW6UprsP4cRg aLJa/ X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Drop separate regulator get and enable in probe() path with devm_regulator_bulk_get_enable(), which simplifies cleanup paths and device remove(). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd939x.c | 38 ++++++++++---------------------------- 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 067d23c7ecf90ae06da1ad6cc89d273fb7f7f875..95cd88a37acb5ef455d4a409482= 84ae45e2dfb28 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -32,7 +32,6 @@ #include "wcd939x.h" =20 #define WCD939X_MAX_MICBIAS (4) -#define WCD939X_MAX_SUPPLY (4) #define WCD939X_MBHC_MAX_BUTTONS (8) #define TX_ADC_MAX (4) #define WCD_MBHC_HS_V_MAX 1600 @@ -192,7 +191,6 @@ struct wcd939x_priv { struct irq_domain *virq; struct regmap_irq_chip *wcd_regmap_irq_chip; struct regmap_irq_chip_data *irq_chip; - struct regulator_bulk_data supplies[WCD939X_MAX_SUPPLY]; struct snd_soc_jack *jack; unsigned long status_mask; s32 micb_ref[WCD939X_MAX_MICBIAS]; @@ -213,6 +211,10 @@ struct wcd939x_priv { bool ldoh; }; =20 +static const char * const wcd939x_supplies[] =3D { + "vdd-rxtx", "vdd-io", "vdd-buck", "vdd-mic-bias", +}; + static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(ear_pa_gain, 600, -1800); static const DECLARE_TLV_DB_SCALE(line_gain, 0, 7, 1); static const DECLARE_TLV_DB_SCALE(analog_gain, 0, 25, 1); @@ -3244,20 +3246,10 @@ static int wcd939x_populate_dt_data(struct wcd939x_= priv *wcd939x, struct device return dev_err_probe(dev, ret, "Failed to get reset gpio\n"); } =20 - wcd939x->supplies[0].supply =3D "vdd-rxtx"; - wcd939x->supplies[1].supply =3D "vdd-io"; - wcd939x->supplies[2].supply =3D "vdd-buck"; - wcd939x->supplies[3].supply =3D "vdd-mic-bias"; - - ret =3D regulator_bulk_get(dev, WCD939X_MAX_SUPPLY, wcd939x->supplies); + ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(wcd939x_supplies), + wcd939x_supplies); if (ret) - return dev_err_probe(dev, ret, "Failed to get supplies\n"); - - ret =3D regulator_bulk_enable(WCD939X_MAX_SUPPLY, wcd939x->supplies); - if (ret) { - regulator_bulk_free(WCD939X_MAX_SUPPLY, wcd939x->supplies); - return dev_err_probe(dev, ret, "Failed to enable supplies\n"); - } + return dev_err_probe(dev, ret, "Failed to get and enable supplies\n"); =20 wcd939x_dt_parse_micbias_info(dev, wcd939x); =20 @@ -3629,17 +3621,17 @@ static int wcd939x_probe(struct platform_device *pd= ev) =20 ret =3D wcd939x_add_typec(wcd939x, dev); if (ret) - goto err_disable_regulators; + return ret; =20 ret =3D wcd939x_add_slave_components(wcd939x, dev, &match); if (ret) - goto err_disable_regulators; + return ret; =20 wcd939x_reset(wcd939x); =20 ret =3D component_master_add_with_match(dev, &wcd939x_comp_ops, match); if (ret) - goto err_disable_regulators; + return ret; =20 pm_runtime_set_autosuspend_delay(dev, 1000); pm_runtime_use_autosuspend(dev); @@ -3649,27 +3641,17 @@ static int wcd939x_probe(struct platform_device *pd= ev) pm_runtime_idle(dev); =20 return 0; - -err_disable_regulators: - regulator_bulk_disable(WCD939X_MAX_SUPPLY, wcd939x->supplies); - regulator_bulk_free(WCD939X_MAX_SUPPLY, wcd939x->supplies); - - return ret; } =20 static void wcd939x_remove(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct wcd939x_priv *wcd939x =3D dev_get_drvdata(dev); =20 component_master_del(dev, &wcd939x_comp_ops); =20 pm_runtime_disable(dev); pm_runtime_set_suspended(dev); pm_runtime_dont_use_autosuspend(dev); - - regulator_bulk_disable(WCD939X_MAX_SUPPLY, wcd939x->supplies); - regulator_bulk_free(WCD939X_MAX_SUPPLY, wcd939x->supplies); } =20 #if defined(CONFIG_OF) --=20 2.45.2 From nobody Mon Feb 9 17:33:38 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDDEC14AD2B for ; Mon, 26 May 2025 10:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256613; cv=none; b=BnXEV+C6eIy9Psmt+mzaVBoWFSb1glIncYYnlTrR2hy2nZUzAAYzTba5GyAujLD4XiPfn/D57nqKx7ELjJSM6EAx5RqLrgwTkaOyvZOdwUbOO5mp8xOHeuru1fiwxdbYdwvzyfZ08vDT/B+VvHVioG4ZZqb1K9WNWtq/ovVAue4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256613; c=relaxed/simple; bh=ZrdzTcfjUGSR0yWCXEjXZS0NUv9q8i0Hdkr7tuUh74g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gFZotdnuTzoFT5LB9ukYh/yhhYzsCvAvHbiHA2KUeHyhBQHQFL7w63He6BrG26bx1Af0MPsRBEVa2W41K3iY44EL20MUIR8KnVk1mZjhQZxCkfcnCTj5UKHZXazHIerdb1QZBblW2bbssTjJKB3DF4l4P7buM+vrtwvoQF75OgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FrFKl1rp; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FrFKl1rp" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a4cfa5c8ddso340106f8f.0 for ; Mon, 26 May 2025 03:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256610; x=1748861410; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UVQ9CzZhsmaSNU4Qn5Q0sFWe1e8bN4jvT/YOnDNAKJI=; b=FrFKl1rpkeegaeITaVWPs/hoWaMxxZBm46My6D4c0X+v2ejkKel2bRZoJVPl0DNLIM idwXZfdx8XIc6nEqwDCzVfFCEQjK53gl6rlNJJe7uHQCoqpVHcVQV8O87vFPosMcO+gN 70wX6e2jNH2GH8lyRKPYJwQ3uUU/x4xIPMH5EpqP8dMnsfJ9xKPRDJp1nM+S048uS3eK dCRIDVHbO5twQNd7php48c73xADn9UypZY8ifMsxZa0GJ+4aaMANPpOKasEywrAN1ogk nh204lOBaGRBEb1Gy/u4wVhFn7vCtRcPrsnSYgj431F0Gii2Sux5FP4qXGuFcd1FuS6y jjGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256610; x=1748861410; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UVQ9CzZhsmaSNU4Qn5Q0sFWe1e8bN4jvT/YOnDNAKJI=; b=LFiuYHCMRTdsXpTeZwrVzTAj1t3pMJO074wAX60Vd9jbe+NFGZlR2KDz1F/7acwTgH BcIkV/qMgo+TQe0sBIBOvhzvZBTlvxAnvCkNulgRssR5cQdr6NJ7YqsC+mAqhkbbE2oX E/KTitc3ikIcg5G2/YjMGvUxk0i6ag8JRtoKD4dOrfJMmNdNem2nTEN2fGhIv4H2ZIgl OWYD6KOsy2mRAfdKkpugqSCeScI3hzsre9V06srgI+AHgbYZffviYwwO/s0sn3TdLLSK ZGzMl5vhgrg5XBUA74vjxlDC5uLxv6K5mAo34uwgQq+Z2UzaAc8b2d6xUGV9yoQ+auoe GWwg== X-Forwarded-Encrypted: i=1; AJvYcCUH1ONRP1tZ3GyqVacCxFqgbX6OxzToSvAzGsYnT8YqFCtnDODMjUI71b0wCu0JpBNS+c8afHHqgSE8uS0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxae5RNatIp8oFypEO85U5m2wnzAqEgEGfgucFKG658jvpuX5Go PE8qh/95y3hVpEsdfA0DUf4rByDEMh7kjncOZE3kaihBUjaxy9JCRuICIYEqIBKMvdJGkBa6F7Z 51eOg X-Gm-Gg: ASbGncuwTf432Wsicd0qLU1gp3AXu4Fae+b4U82iIYjqsj0Qx8+DtIP9NVOKUZVnFhS C1Gft7HICRBJ1x6cpjV7Y7BC4/Kwp9dA0QiHIZLLW2L8pH84mV9Gnsw6e+o2hFWyZa2pC3rhiBG 2hySKqZ7XzeUU7Y0D8Vzmf1O9Fl/HDAKWhtNn8BbjxnYEBNwBNn1KpY0aITkd3/w6PrnB2qXafd HOdlw9WLqXXc5KPHdE8knD/hN9q8oDwea8nj6sgE+saDfzGbgO0Ty9RQzH8Z9D82B/axEGnWOH7 xYMd8srDSb+pe3hmHwKdU/CVBXidv7EuEZm1d3Tct6aVUmvLXC3R48wgQW1OefjebCtAiQw= X-Google-Smtp-Source: AGHT+IHOsZcTI7UEfdgo1fLZAipybkP0owKVRNTuB1jpnww6CtR037zAeuvHuyQO/estCgAm7u+9Xg== X-Received: by 2002:a05:600c:1c24:b0:439:9ec5:dfa with SMTP id 5b1f17b1804b1-44c938cb1e6mr28426795e9.7.1748256609774; Mon, 26 May 2025 03:50:09 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:09 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:53 +0200 Subject: [PATCH 4/6] ASoC: codecs: wcd939x: Simplify return from devm_gpiod_get() error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-4-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1073; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=ZrdzTcfjUGSR0yWCXEjXZS0NUv9q8i0Hdkr7tuUh74g=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNEdVecFPbjX6JYFFxQlwwYCpkVFzD7vXFrX2D HYU/bWST+CJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDRHVQAKCRDBN2bmhouD 17c2D/9gaiXizasSYMwA+a5cJk7IpdYFuqPOoFSZHkcUbGVU5Q8psDMoUkI6yoXlqrytEwgpcbQ DFAZT4BFFFZx714wvQ6gatZfyDSP3lDfOA6YJw2fwyIskhqsBMKj2EL20bGu7SNSs9vgGZgcycK ZQ5A9OWQMoXAgyQpWwfcWdJed8pWUl6mZv983TIb7Le9Wxz4Me3c3rtNFXysG4JpE2q7P1Qylhi WJvdcyzbZTTUlyyCPhwEg/wnSiPViXWA5fjiwyOXhs5u6vQUycaDmjKRyF8Gshh8KpL55tcIrtG pVjvunBE6g9BQgv/eArB4u6biW5FlHW0ZWGsbMpdPpLJR5mwVcs0fKZXGItESzz6DE6zpnCUC6p MCQ8R3Dw5ZNLpmw0c8tBcSl/s+RXOm/PIfPt8Tve2TLaAF11EkdkeyoM0C/Ukfr3d450aUctTAD Ei1t8+9IbXgfLfRtIHd04rVJeohTXBv7odCdMOFzPniYKf7qAJo/s5XlE6GfJR/V33luDW03QM6 Dex/OAOwzhVjMsuOWE+TdghNegFnMp8dJn9R5jndluYmKe8YrmYFBfHc09kVdSLPUYHAvPcdUO5 nvItgqB3c2fnOz0/UlqDG8XcGruK35oPgVRP8mZ0lYFeSC8bqorts/av81nordMJE6gNvhVyuq+ H6y/2MMsedBCGfg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B No need to store devm_gpiod_get() error code in temporary variable. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd939x.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 95cd88a37acb5ef455d4a40948284ae45e2dfb28..9592462f2d6e3067a2ed3339ddd= 5f676eaf3b5ed 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -3241,10 +3241,9 @@ static int wcd939x_populate_dt_data(struct wcd939x_p= riv *wcd939x, struct device int ret; =20 wcd939x->reset_gpio =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(wcd939x->reset_gpio)) { - ret =3D PTR_ERR(wcd939x->reset_gpio); - return dev_err_probe(dev, ret, "Failed to get reset gpio\n"); - } + if (IS_ERR(wcd939x->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd939x->reset_gpio), + "Failed to get reset gpio\n"); =20 ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(wcd939x_supplies), wcd939x_supplies); --=20 2.45.2 From nobody Mon Feb 9 17:33:38 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 519171FDA89 for ; Mon, 26 May 2025 10:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256615; cv=none; b=tsnMQniwHCP+tmZzTkBD3sFnCrzruGuYaPQN/s2rYvQvUn5c9gUU9B/WZW/wUD29yJ7orligT21bNJO/jWY+fEc5DLStbtj10gerh82xE8K2wSUv934Whj+wPfu+slnhBWTVj7R0UrJpTCs9ygCOkjrjCFVcI7D4MEO/V+7uu1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256615; c=relaxed/simple; bh=yU2q2dc/+ye9DTxIWNsU5+R7KFc2SHPwmGkeguoT2DU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fkya9bhkFRWZs6JMqDsJncfgIz/EM5n3haOtCA6cJ1Ps91N021rCJIMgj7O7kEeop/c1LGBRQt4tcKMgZ0WwYBMC58/kR8mOoxStCBfoyynk/wr32/BOZsRpot/puUZxQ8uK21iCJC6F5NShKy2zPc+AoLPb/+QOQ9cuwmlKE4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZKi4Yxf8; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZKi4Yxf8" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-440668acbf3so3348295e9.0 for ; Mon, 26 May 2025 03:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256611; x=1748861411; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cG61swMbPld1iw/+98rFclnYQ/laAvEp49eN2rhhuD0=; b=ZKi4Yxf89MaoGNzI9gAkOxTWglmbyBLI4996/CmEmdSzBbM0Nuf8o3+NM2zvpBHC1b 3RjTtqarnBAhQjGoGngHcgIk24OIjREmN+oP0QaCsBBNmAVrNqzqfXOiYmsbhKXP/zM2 SbaJRnp37gQoQryqeicmpYBFjDwBx6YDPtp/ySpvI9Eq8gfkEjyK+BDgqaaOn4tyu2Qo sdZEncNoCZ/+CXZc22cWVU4pOViU0TJdxR6fEB6toKT67HbL0dWjqL9XEXBAd8CdnyhH TUdmlqS7/lFADfjvPLAyNrfmUveILIm4zO4cOUTPFgE/uy4QzlRwXjtpx7GQ9IIyq9Z4 lxAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256611; x=1748861411; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cG61swMbPld1iw/+98rFclnYQ/laAvEp49eN2rhhuD0=; b=MAC1eqK08hcVyX/azPDxS38x1IjMH6qQxOZgnhd2ujXAE81mDs3Q5fSgY5TzXq9D6J HBXGG+ITmnQWkNyXz2r64lyfdEb9bk/ULk1aysCxBRIJvbZkaiNJENh96KgK/rCe24AC WRefkAnyv7oXFDD/kHjF5U7sT27H3Rfra5akloeHbQhETHND9RNNEcvOQRtY5BC6X8uj 27YF3161CicrEG55HS7WQ7x+P+C2JYEOobOiWCxXEgKlnnUI4WNEo/6EVZq2SixK5UaT hOzoE/CvJHupZ1v4cYzoiKUFWi6h+5uVhY5llRL0o/944048oVkX4Fwq+iNq/Oee7BXQ dzeg== X-Forwarded-Encrypted: i=1; AJvYcCUeYSTuHhnp52s0Ft9DPdEb0y0G+MrXksuG+zgiWyUvjKnEAsKTVgD2T6X0KAz1ATm9bXGTz8U2jU7CUUM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/pTm67Ekm9QWSUE9T3bSOervYjEn2+vHR6RYJaQZFmtD1Fo9G skhxXA3R4Gs+iWuDa3glpQmN6SWU6/w8MIkIchXMW1Q4ktIIRbnxvZy3vF+yJPnMuqeeObF4zPJ a9sUi X-Gm-Gg: ASbGncup9zF50iD8SFBZ/lyFnH2jBv+GJpUtQTINZ5SNPt4xuRnOiLtWOvvukpobEsW GQmBs46c6Zf+pPImFa6b/D3iJxupgni2U6OKeMc3pM/0bD0/DnFo0Ogr6NmXXPfW5odkFUdFk3U mXfdeHxh7d79uMTJfxXgZS/CdeUCwa5vmStpXEGyDEsLGab2VxkAnRSg9zkF+WFXSVbSij0mST8 676ccFC+M8m1JS+Nrzfb1g0ybgTZCgbwHpNvllWyyk2cQxQZ2di1HGuWHpIwjS3NfgfNygR/EE4 WBxCvxzNSZ0bvIAocLQDN4WHlOtec73KiJ7JYw9LePEBch6Q1q1dXgCnTcIlf6j6Lm7IbAY= X-Google-Smtp-Source: AGHT+IGnwTHuuG+Jho/HJOTkFbKRV/f+Q8dqSHAsHXqa/3j8hdS8CB5qeUUJMIQv9Qhw06xYFkFQhA== X-Received: by 2002:a05:600c:c0c3:10b0:439:94f8:fc7b with SMTP id 5b1f17b1804b1-44c90f4ccb1mr16989755e9.0.1748256611031; Mon, 26 May 2025 03:50:11 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:10 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:54 +0200 Subject: [PATCH 5/6] ASoC: dt-bindings: qcom,wcd939x: Document missing VDD_PX supply Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-5-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=915; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=yU2q2dc/+ye9DTxIWNsU5+R7KFc2SHPwmGkeguoT2DU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNEdWT6Qq3CPHamy1JbqY3q1W+b8Ex7iNBmMFR d7LsD2+YDyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDRHVgAKCRDBN2bmhouD 12B/D/sEd9n9p/vaz9wGIctCYELj5BTiT1VBT+p/3XG3w0sikeA9hHKlajpwaNkPLykj+JVhtiR 0VFC96Bd624OTu+kG5aKf+uEOTLp1nNpgNDUNH+dJTH3oKVzNxOiuiDNLRgPcv9x8gwDaOGQNqP Zx+NAv01ezIz3XG9fTL3z9qLbAW0B4EHrbDPBIfK28+RAD0iZcoeI+HKUK7K4jvdZpqxjbNGt5w x1IGp9k8FJ1+vXURk+xEaAeaU7DxR2nTPxfrNiZI6JKCT5WLW0iZSpHljodiY/13UU6em8Y4g6P Bsfx5Zh+uNVNeNfLgkzzQ5rATWC7HYgs6xO5W0brj5TCejaI8gzVdz54gA9aYpaCQlI3mUaDT+G hJkRTic+gKhJo9Bx9jGAdbTFkx8fLsZUCGrn73p3CZR0CQaRBFIf7sjK2gl8HihFjLk8uEy8fpC VM9md59JrfKKIHjTe1cfu+2BwDk9QKevkMPeYcx/KkWc5nkbAtLGqZ59iAmPE4C+usboX4Wcr/I JZcWCjm+q/esf342a1C3qdlUGbLkzybQIobE12JBbYXuuCCO70m2rQma5WvtRk/AsDA1cm6Yd6R A2e5mQ3e0PTCCz2OEGyaOFjfKVWTkczXuz0duEjfNu/2p2oL8xImYLF9VZIfW1FAlHYnUrGBEzC q5bqf5AYmCAI5ag== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Document VDD_PX supply on WCD9390 and WCD9395 audio codecs, which was missed in original posting. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring (Arm) Reviewed-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/sound/qcom,wcd939x.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd939x.yaml b/Do= cumentation/devicetree/bindings/sound/qcom,wcd939x.yaml index c69291f4d575ca5b4fc037ac4d59c91f0df74cd1..85283f94465d4f1ae6ec7a250e0= c7f65d2fca172 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wcd939x.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wcd939x.yaml @@ -45,6 +45,9 @@ properties: purpose of handling altmode muxing and orientation switching to dete= ct and enable Audio Accessory Mode. =20 + vdd-px-supply: + description: A reference to the 1.2V PX supply + required: - compatible =20 --=20 2.45.2 From nobody Mon Feb 9 17:33:38 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 686741FE469 for ; Mon, 26 May 2025 10:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256616; cv=none; b=EwX6qEMj66FIkbhp4wtbsArkEX+R2DxIE/dSPYLfM+y+yJsv6yO7JH+leKeV0Qk5vuG/qF1ajC+CPTl+xBoU5p1bDDaX46GtGD6BR1xZuz7ycZvdLEbsGhygX8rzega2kS1gQpkvpwkSm2bgr52wRs0vHZD9aIW3M74PDzLmuEA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256616; c=relaxed/simple; bh=BxJ2y+p3e45IzKOg0vhlHvkapbzztQvH0zmQluqHJV8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gvnLDYLExjn/dJag9VgfVpZfWV9MiGogv9icWeQyHRD9+g+UC+kNocxLPwQrzUWD2r2A4C+4tBAsSob+epc7o2gfQtC/Q/usIGlSJK+lVneN7smU0Ej47aSz1R9E8sXYOwiVcd0ohFQfmJE1vL7hj/+VhpPksa5cKgOAnkDz374= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Y4vfCAsM; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y4vfCAsM" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a4db4d1bd7so95146f8f.3 for ; Mon, 26 May 2025 03:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256612; x=1748861412; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X1F0JJbw/NsRmxDzxcjla28hDif9xWhQF3zZnWHAIyc=; b=Y4vfCAsMjZrHMN/+FSpKWZMoZ1M4FS2/SxaugAteNgqjJrn00BpiCOcmGZ9gloVYcH CIGjzvkA3hc9WC4bPaVMEFJV1xCqx99xBuKol4Dj071ji2jpXFy6sjYct/LIPAyauIwb peV1X6ZN6F4b8FuTPLmWigJZSPnv4reJyCfUbe8CO9Zzuh7WrHpT44nltphS0GgmPJsf imk5QyatvnX+Z0OYFspzR6lLeuv7nROpsfrPOI4ak+PqsdZRflaa7Gc24J0UfkTCAw1l KOBFviExJPrOlKcI07CnrdS633qWgmfhNAb5hUJpkDEUuA0KvdFSGepgdvjt/nnyvRMA 7jdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256612; x=1748861412; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X1F0JJbw/NsRmxDzxcjla28hDif9xWhQF3zZnWHAIyc=; b=quNRwxKlXklOLQpCLnq+3SSzhpRK2ks1qciRqvAEESsbel6d43VFEz2nB+fjozYFia zoF/E9o6GvwA/IDyk8JYD6Ub/TTsthb1Rikc+89fXEtCqFBspl+NgKWDBt+DcLlGqB7j DA4YPFBz8SXVBdV/ObqkSmBPG3qpVwatMALXKyDBfac09OgWDMr6i94wmU6zJrwnNHHZ eV1aQkTZBkKoNkiYRIQw7ak3PzFHd8FewRUC+AeawbDfLbpnFSCZxH+fFKZ7/QxLTR8z ExW2Q8PTyt9rf0a7vKlDCMFrEbKNeC0gRb3+oz9Y/fyC15Grs8rtgTLkTuDXgIMwl2tw tVkg== X-Forwarded-Encrypted: i=1; AJvYcCXfPGrrbfSjXeSDFhlQcFTA6FQ08GmT62z1Moh2w6rVhujGJeMWvnntN+whUmLxCX3kPOmVXuNgaGwoi/c=@vger.kernel.org X-Gm-Message-State: AOJu0YymVBEi5N4P3eF2oGjEsXOMnIEH0dZe+Bhv/kIZNfhyrhZokQBd H+AehX8fKFSpN3FXbwlcezMfJi8p+6Q5D6hKul+KkWYXaDOpWT5JVVTjC5FACjQdWnwGUFePetQ WpnxQ X-Gm-Gg: ASbGncvLZOvv5jiYK1BSSTSw2+pX0HqkAfLJjwoxJgxAqavKPCQi6iv7Je2AnXz0A36 T57MHhcNEfO5MsqvvRLQyxbZaXp9cu+oiKNW1cJmnOhBXTTgjwJBB3HuOFOQo+hRBAks45uK8sN fd1CjoYpewDS0TkwZ4ULbmiksOSorOb530L7417Df7JS6q+PBq4fe33IG8GSzsduLCI2vO6FJAZ Ud3ijirN9Z+RY/285BhplCMvFsMhBTXwU70pMlcdFYB7ZqgMOD3BISLF/r4TrRIp4ezleSCZR2d jkmahyrvOR9aphDeoXGnMzuj/7CO4a56aufxkat89wJTJZua9oVBkkXFyH8rtEgG2fJgkEo= X-Google-Smtp-Source: AGHT+IEc+gSI4dz6PJb6XB2/tm1jAeKYruuziD5I3xYLt4dJi41VULpTVmWm9gG7qkHMbwUWLampxA== X-Received: by 2002:a05:6000:2082:b0:3a2:133:b1a4 with SMTP id ffacd0b85a97d-3a4cb48a237mr2078199f8f.13.1748256612330; Mon, 26 May 2025 03:50:12 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:11 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:55 +0200 Subject: [PATCH 6/6] ASoC: codecs: wcd939x: Add VDD_PX supply Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-6-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=881; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=BxJ2y+p3e45IzKOg0vhlHvkapbzztQvH0zmQluqHJV8=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNEdX6ua3vxOKUSyAOM3GRxHgAoDMRana3x+JM 90uDzTcvgGJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDRHVwAKCRDBN2bmhouD 13R7D/9pPE/aTDxvrefDXj5fjGmq+RVR1zaJ8Agf9aOCuT3EVvkdIo8lnsaXmJqllZsHEGXKfRY FFO/lYuKpmUDwSSgPRwij8JS+gidxWuCO8koyagq5HTwUNLPIuUl2k4m6k/KG12o31ALQsT/pMG L27VghMwOoDVf1EYL+2Te+O44EUiP/WqWSwQxHFi4Q+HuhynvtjGANzsz34PEapB9qfcdCORaez haOIa7lopyIwHUMFTkVfVkabOeMAK9E65AVzhmpB13eeOuKNtT3UT0jLBwA5XdGsgIpms9sqEAS /qwtNtbzrpDV0FbDqisgQwtpLbGlraj1S1yv9v7WMOQqQoZsx7Oc4xgWWGeNoaXd9yMSuWsh+Jw 4gdkx4407sADLbOJGwC55BU5EYiw8Sj2fd1ilSayJA2Lu7nm9WspJXuQkhOsaXTLPNFzEwDwH5Y g8Gmi2cTPKM1Ev9K1Q4wjJLf5HkwBToMfSPDpjtj3eeYIYh3Ykrl29xMmE87rXiZY/UGSh4bwEg 1kxK+BglD9gRf016XqgXa66rn5f9xzer/gUknqVSfTXZJiRgazqLzQu0Rcbp7Ma/Nz2q2nCET6D lC0eNpI12nxjFIgE4pupQr2AN+BjG9FqsfhgCvSv4vg4nv7H51ZLK/iQSje9VcZqi5UnubWVpn2 coOXn/LkmU9OP1g== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device has also VDD_PX supply, which should be acquired by the driver. Regulator framework will provide a dummy supply, thus the change is compatible with older DTS. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd939x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 9592462f2d6e3067a2ed3339ddd5f676eaf3b5ed..690832037b5dcee0722e118536a= 45cb70e5c61c2 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -212,7 +212,7 @@ struct wcd939x_priv { }; =20 static const char * const wcd939x_supplies[] =3D { - "vdd-rxtx", "vdd-io", "vdd-buck", "vdd-mic-bias", + "vdd-rxtx", "vdd-io", "vdd-buck", "vdd-mic-bias", "vdd-px", }; =20 static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(ear_pa_gain, 600, -1800); --=20 2.45.2