From nobody Sun Dec 14 19:27:53 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AF52F625; Fri, 23 May 2025 15:17:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748013459; cv=none; b=uI6EQ5TuQO3197N+nWr8DM4UqYd3plYciBfEkCgyTicm5J7e2HAmO4kqUkNEqTWp0YMh3kdWeUPMHTIQSLjnNpr/jW8hsPHsKfFhrQWxC+tSw6r76WzYU4JBh1B4Pr6ReM1zSfAUhUb+XMNH/oIoWX8ZqGr57QumuzJWXSaySHY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748013459; c=relaxed/simple; bh=grBDhLBnqrLejwb9yEY0MLDRtwM/n1iyGHbRGNy+k58=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=B5TkhzUycraGGcuChhsSnAS/8ZzpztqeZXLecTCnMlV2Qi0WLwsAkbBbl2NtDFEvP5+wc30rY391sNawCrz9dpzrOEErhsTLB8mazi4XhNUynb1YAZIkUO23BAhRmyzZysJREzbF7lWuOtMP3TEwAlsHPckoKGN+d54w+2iWMWM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=bBwVXnXV; arc=none smtp.client-ip=220.197.31.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="bBwVXnXV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version: Content-Type; bh=3aX8PUAXDaemiEQ3IrgJbnTZwuocxLWzcQByTZDngOU=; b=bBwVXnXV47gzp2czYWTvmcMKEgZrPMUK9feAAVxOgG4AOljD7u1FtJ/gbID3wl 5TC1szaWCRf19jfCuTR/VW5SEF5Epmr+km/g05ps82PrudkZ4Yvhzmc8Mt1TrWCD 6Jebflm7/aV9n/B/b9GcMaoiXetu2Kn3b8KGIMA2T9/L4= Received: from localhost.localdomain (unknown []) by gzsmtp1 (Coremail) with SMTP id PCgvCgCXbyELkTBoFV96Bg--.59745S2; Fri, 23 May 2025 23:15:35 +0800 (CST) From: =?UTF-8?q?=E6=9D=8E=E5=93=B2?= To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, jonas@kwiboo.se, rmk+kernel@armlinux.org.uk, david.wu@rock-chips.com, wens@csie.org, u.kleine-koenig@baylibre.com, an.petrous@oss.nxp.com Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?q?=E6=9D=8E=E5=93=B2?= Subject: [PATCH] net: dwmac-rk: MAC clock should be truned off Date: Fri, 23 May 2025 08:15:21 -0700 Message-Id: <20250523151521.3503-1-sensor1010@163.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PCgvCgCXbyELkTBoFV96Bg--.59745S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF1kXry3Kw4Dtr4DKr4Uurg_yoWkWFbE9w 1Ivrn3XF45XF40kF1DGw13Zr9agFs8ZFs5Ar42gFWSvFW7Zwn8Zr4kWrsrArn5Ww48AF9r Gr1xAF1Iyw1xtjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRtCJPDUUUUU== X-CM-SenderInfo: 5vhq20jurqiii6rwjhhfrp/xtbBMR9Wq2gwKoMmeAABs9 if PHY power-on fails, clockassociated the MAC should be disabled during the MAC initialization process Signed-off-by: =E6=9D=8E=E5=93=B2 --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/e= thernet/stmicro/stmmac/dwmac-rk.c index 700858ff6f7c..036e45be5828 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1648,7 +1648,7 @@ static int gmac_clk_enable(struct rk_priv_data *bsp_p= riv, bool enable) static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable) { struct regulator *ldo =3D bsp_priv->regulator; - int ret; + int ret =3D 0; struct device *dev =3D &bsp_priv->pdev->dev; =20 if (enable) { @@ -1661,7 +1661,7 @@ static int phy_power_on(struct rk_priv_data *bsp_priv= , bool enable) dev_err(dev, "fail to disable phy-supply\n"); } =20 - return 0; + return ret; } =20 static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev, --=20 2.17.1