From nobody Fri Dec 19 16:24:24 2025 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B183183CC3; Fri, 23 May 2025 11:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748000219; cv=none; b=B41Wdvb7uSXt0VYkPTGEdOauCm3npSGkWjM/hHqBpzNKyet08zHFpJgOGSCzAdMmwqtxS1zL2Vfawc8Pm7i0MYVFenAt9bxPwkeZSGFas2AbsL7BHqA6uF1b2ROYVYGMBr8FkaqSg+8k2PH/nIBXJZ8TH05iiJy90xxb6EQuhNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748000219; c=relaxed/simple; bh=XTCFovV6gRgjPh361438rq+kkBsjg1osqxNg/6PDdUo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=p5lNTRyYmwPCNbd77y5a/DgoWMjBSTxVqc99H3nTgpFqpHAnsZqE6f+/+I2H3sLfCdCZvRxbPsUHR6nrHtPtHv7Yy6qOfIEtRevs8VB6FafS1HLY1Shc/kCGynRu96PYK4GhSupw6ujsseiuJusqqVV6+I19SmLsuYFg15iWbf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=aymo7bCQ; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="aymo7bCQ" X-UUID: 372bdb7837ca11f082f7f7ac98dee637-20250523 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=tYIiwWGIKoPuKSFob4g15bxKNl60UEjmO24khtCJJDk=; b=aymo7bCQCXfMiJzaZbMrMoftOU10W9ETAUbRAW0iPqwRz7czD75BkIDRSMvQe+EI8AW8BmsTb4XLNuykHINppjG2rSpZJh74aq93uRf9f6m1h38j+Ddglf9rppIuw25Ge2k56tTE0J0FSxMqmAIaqhhPeI1tr8RFAFXSARvowB4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.2.1,REQID:a360be72-ded3-46cb-bebd-cb8696d30694,IP:0,UR L:0,TC:0,Content:0,EDM:-30,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-30 X-CID-META: VersionHash:0ef645f,CLOUDID:ae5b35f1-2ded-45ed-94e2-b3e9fa87100d,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102,TC:nil,Content:0|50,EDM:2, IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV: 0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 372bdb7837ca11f082f7f7ac98dee637-20250523 Received: from mtkmbs09n2.mediatek.inc [(172.21.101.94)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 475967441; Fri, 23 May 2025 19:36:49 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS09N1.mediatek.inc (172.21.101.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.39; Fri, 23 May 2025 19:36:46 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1258.39 via Frontend Transport; Fri, 23 May 2025 19:36:46 +0800 From: Sky Huang To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Daniel Golle , Qingfang Deng , SkyLake Huang , Matthias Brugger , AngeloGioacchino Del Regno , , , , CC: Sky Huang Subject: [PATCH net-next 2/2] net: phy: mtk-ge-soc: Fix LED behavior if blinking is not set. Date: Fri, 23 May 2025 19:36:01 +0800 Message-ID: <20250523113601.3627781-3-SkyLake.Huang@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250523113601.3627781-1-SkyLake.Huang@mediatek.com> References: <20250523113601.3627781-1-SkyLake.Huang@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MTK: N Content-Type: text/plain; charset="utf-8" From: Sky Huang If delay_on=3D=3D0 and delay_off=3D=3D0 are passed to mt798x_2p5ge_phy_led_blink_set() and mtk_phy_led_num_dly_cfg(), blinking is actually not set. So don't clean "LED on" status under this circumstance. Signed-off-by: Sky Huang --- drivers/net/phy/mediatek/mtk-ge-soc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/mediatek/mtk-ge-soc.c b/drivers/net/phy/mediat= ek/mtk-ge-soc.c index cd0968478..15dcf2046 100644 --- a/drivers/net/phy/mediatek/mtk-ge-soc.c +++ b/drivers/net/phy/mediatek/mtk-ge-soc.c @@ -1228,8 +1228,11 @@ static int mt798x_phy_led_blink_set(struct phy_devic= e *phydev, u8 index, if (err) return err; =20 - return mtk_phy_hw_led_on_set(phydev, index, MTK_GPHY_LED_ON_MASK, - false); + if (blinking) + mtk_phy_hw_led_on_set(phydev, index, MTK_GPHY_LED_ON_MASK, + false); + + return 0; } =20 static int mt798x_phy_led_brightness_set(struct phy_device *phydev, --=20 2.45.2