From nobody Sun Dec 14 06:34:44 2025 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 807EE2BF3D6; Thu, 22 May 2025 20:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747944606; cv=none; b=jAkOAtUe5ithigePh3pWguc86yryBHNrIXZt2HXfrnm+t9XrQjika7i/RDzyk4wPgjt2RiVZ9wKXcptFlmTclzt/QaVXKWBW4DgqOtptgMoP7H2FEe6Viu/KATWnh2uQp7m1LUyEuJbBCgfAO2XyMvGFLCEhtzx8C8DKsSH2zQI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747944606; c=relaxed/simple; bh=HktfipjCtbNhdpQdjG/jx9IyuttYJiKuu2cQchPP5AQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DVyzCIU0ibG6c4Zqd84i+oYLg1mYFQrAkwl7uI09hBCArq1zvLWtQa7uXhfCkr0GLbNObGm3yw6sNm1zHSAD6SG7qJ00lNBurIiuIE4s4UD0/Cymcsw++KJS6IrLl2lJMzR3aZIYZsmJ7CRWiEBH9BXnt9RSdDP3AQWsS8JLlzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AO+oBvOX; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AO+oBvOX" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-2cc89c59cc0so174457fac.0; Thu, 22 May 2025 13:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747944602; x=1748549402; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=80W2fxDPnqr3BsAdMQ1F8twH1xONkZpWztd0paXrfPc=; b=AO+oBvOXJWnxGRh2lvUL1o76YJG6HXDwsDfycZ18jMCiIKtsIo8o5AdTXfIjrKij8P hgrb/b6UMOk3YE457bmmTNyLm58HW2dfVHk7emWvVyIOcADxangWSlpsbgDUoku3n3ot D6ZYFeOmRZBn2G2zuvcQ8gQVdiQBVsU2bPs676iTJg2rLVwhXe5yKqeATYDRU3bF3nnB T5/m5T8E+6H/P0opv/x4CGqYLtStwxB8pIeZHSkZg0L93VyMArNc4FuxeH/MOsP0TNEV g8peueMICTIYd9fFkVtaovi/bMXy1Q22JO9W7tW00jV4Y4kaY1e2VSxIVYoiqzgAVUIy 4knQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747944602; x=1748549402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=80W2fxDPnqr3BsAdMQ1F8twH1xONkZpWztd0paXrfPc=; b=adtej17ueCQpxMjL5kJqaMNxHInCKZzEZAroQQrbH6uWqyM3UE7IIGEstWS0w9C1Z+ vEKOXMw/f1Hlfc0swq/cDUlbzrTr2nSM9RvRF80ztS/KlsOpsFfMemeC8tOPxPBe8E1F a39jispnAHRSyB/5MFOrddTFXi3uZ7PDoJky8UOEL8884a9a1bwdA4/5DW5SIMdXWRQ7 VdNwyGr2mleeI4IG6vaikD0hJdYNZFgl0Pd6tAZ/2XgZJi5NG7s8oy957AgyyT7WEM0b qZBrnl7Yt9H/KyvKCzNEsOlFjhoflTMPVwM1oZE8EOS536eGD/Ajx9n53wQfHcp5S+Cx eVdw== X-Forwarded-Encrypted: i=1; AJvYcCUVCLQvjuqR/HalgEiallaZqG4tef4T8/P6HuVevFKSYAZy+DFX5/WWLDo/9bN8Xt0HiyZMq0z4nYGA2nCardrZaDml@vger.kernel.org X-Gm-Message-State: AOJu0YwM2GlU+1vjrbIDNrHbu8lHXGknHlECvu/Jlgj4GCx7HAx8Xw5n frrGGZc7WMFehSNUGioLrZN5E3tXR2xaXdDuF5AsOQqm5daKlWrRw0NSJI9zsQ== X-Gm-Gg: ASbGncvQk2Lgsi3vV0PJ9iSlg/bdelMbpnpDe5fiXPnbrf+9ITtlgFda4NhYqCJ/9Fy vppPYtXaJAh9+XQra8qCY+N1Rr2P7hkMekT8vB4GUgxYw0FFSKlq3B/YA2fViJOv4pbsMh1iJRy 3AQhYkoiOPmw7uTNYiXOxo0RYxNmy0if5F0wpGv0FmfMB/4ubgiibXCqNU+JHYEcfICi3yqfT+q lxjAAJHVFz888L3rdEam63PWpOlEjOBspVwdhME5ZY/0oud0h4Z3Ct/2t4W1hXqWovBPb9o1L49 BNF2Ov3bTZNpnOIwQno3y9uhMLxoWBbMqcBsDvskZLgDXzHyr51wrUZfABXcMZTNR7Gk8Ss2BIf 1djfMjpkbmVXgCsbluA== X-Google-Smtp-Source: AGHT+IFNCaFEUdw9Q4Lhho49woOnZgOAPI9sRkEj7PjLf8sh5yHUiQTPttJdPwuecHTOCzVefmBBWg== X-Received: by 2002:a05:6870:600a:20b0:29f:bdf0:f0f5 with SMTP id 586e51a60fabf-2e83e9186cfmr427048fac.17.1747944602528; Thu, 22 May 2025 13:10:02 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-404d98b2762sm2651046b6e.32.2025.05.22.13.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 13:10:02 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v2 1/3] platform/x86: dell_rbu: Fix sparse warning Date: Thu, 22 May 2025 15:09:35 -0500 Message-ID: <20250522200937.9578-2-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250522200937.9578-1-stuart.w.hayes@gmail.com> References: <20250522200937.9578-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix a sparse lock context warning. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index e30ca325938c..7b019fb72e86 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -91,7 +91,7 @@ static void init_packet_head(void) rbu_data.imagesize =3D 0; } =20 -static int create_packet(void *data, size_t length) +static int create_packet(void *data, size_t length) __must_hold(&rbu_data.= lock) { struct packet_data *newpacket; int ordernum =3D 0; --=20 2.47.1 From nobody Sun Dec 14 06:34:44 2025 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FCCB2BF3EE; Thu, 22 May 2025 20:10:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747944606; cv=none; b=C7iqDbEr5Pdfk9SggfyN3oATuUGrJCRyJNbbuir/KeDcytMRkmDGK73YKYgm+vaSX/Qk/8YcvXmce3s/5GR8KmurQ5NuOilSeNCDJjTd4a8ySFp2G+8pd5Bt/MY5nZnjYOj7dq1ArdZYhn9939k1TAXVGChBx2bBNbYvdG8kTA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747944606; c=relaxed/simple; bh=TYOe1X4HiP2jLMtGTXfIjoVvkX+GkG3w3WtLiBjaWGA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rgcbAC7Us9K3jPW51ERG+JQxH2qP6h24DOXiYxmuxtBWbA4EIpaelsrvFdv6ISVCud7rZdr/dfT1wx3MmTcByuaAksH/ZL6BYmDlJP/Ta5Fjcr0F/sm2cFRVtq4vBxiEWL38dIXyTSyj7RrxmDt80IYhI1j1bzpZZHwSK5c2hPY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KWhX68xI; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KWhX68xI" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3feaedb39e9so2922383b6e.1; Thu, 22 May 2025 13:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747944604; x=1748549404; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OclIesw1izJi5DFMfy3FYc7UMLpb39l7085Lh8T/vJs=; b=KWhX68xIdPC9vznnRyhcLrNSsRo7FupojXZ7RvgiksuIXicA5lG+JfDS/vaK/XaEbu N40tquVEecdl86nOiUJ9Rj8ugqne4lP/ynsHZD+oTTuc9l0h1VPhDxsH5kpEA5t8sPtp s7HOkLS4gRH9/huyJ9piy/fd2OP1qGpoZt+VLyfrjJx4/vyGBHSQjJOJReufo4g85Lra IK4KuaocwmWPCeqg5cs1iZEVAAdermA7BIad5uYw/rMKYWTC+a1bV1ZscK+2nwt9STPW p3oVPswnxviS6oqtNXRLBvoIYmooCvqi2X+5X6Z6bw49WLquMqJcHrIoiTtbbMWyMrlh dCBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747944604; x=1748549404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OclIesw1izJi5DFMfy3FYc7UMLpb39l7085Lh8T/vJs=; b=NNZDcKlHHsCoC/z/HGtg9kcgkDWrJrn1KoU3UMLHp2JstFR1hwio4GQeGIdrPZ0HIP iSj6zNP0WN7BSElae6a8lTh4Y97dX8uRMbyOeg0Je7oi+jg6nyg8Djt+S65F7jGzUmem SlMFqzgQhKyiyvSbRmbXhim0xKUcB0Rl2hwWiWJxAa84mGjz3Qws1uVFIxnLoa8BL2CC 7iQ9bKG+Y0e1bHdgDppGHK55zRabkay3F9Tr3uFvjaR3mJ0Hztt6QKRef8PBTGEe1q5u FuYfaOARLLhFiiGtLi1/iRAV3WtHS3b986YWIuthas4GB8fNHFNEPDXPORhcV1q7F2gi PIng== X-Forwarded-Encrypted: i=1; AJvYcCVzVacj4JewFYZB6Aa3tSQLykCE/BHceRIQr2pHdYpwrHXHpPcwu56KYbenv2cD5C0QcbrfoFC/OX1XA9cGilFc91c/@vger.kernel.org X-Gm-Message-State: AOJu0Yza/8e7qLqaYKJzHQqNDq2R+bGuNti4ZtHfddzjDAvsaHYA2l2W mTBaxnAcwXK6dfh+1GI+V+iy6VqRaMiQxP5H4A5axZu+/hO24QsQneiHigosUw== X-Gm-Gg: ASbGnctgxXFlQYaaZ6YEJl98E7mL60m+dSbmxMy59CKITAtul1VXDkz/ZG4e22dnutF s4tT0sGrt1+90yEJ0n2Z6z1nAow3rA6WKa8BxwgBCNr51LFf4rRQrS3Q8L2aivY19EkyY3nfFpK BNVYufnAOTQAGO8r2nDBIZEY83bnDFL5FJXQ+rRcz2Q5q2uKSEcJP9kRBeZqPPP7zSAsL4yLhK7 /RdYAq33nHKf3sY0EtBdt6L4l0qm/eoj6bl5FKUScR2APf06QOc/2VM0NUkH1GdUGjn5nGC6yNB JfSD4Q/7O+HPBr+ZuFtLP1SIxAaXdZmI5eqWRp6UD2j9h05pvrWowq7lCS+KH6/LkraBh2YuI46 DINOm517fO4Hms98rXA== X-Google-Smtp-Source: AGHT+IHaY5C+RTiQ0OBFcQiLWXqgt1xCogRmKuxqTIXAywhfWrIAqdzAfiT8iSU5gehNbzChzapsTw== X-Received: by 2002:a05:6808:6c91:b0:402:a5c:906 with SMTP id 5614622812f47-404da80abf3mr18664225b6e.34.1747944603700; Thu, 22 May 2025 13:10:03 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-404d98b2762sm2651046b6e.32.2025.05.22.13.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 13:10:03 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v2 2/3] platform/x86: dell_rbu: Fix list usage Date: Thu, 22 May 2025 15:09:36 -0500 Message-ID: <20250522200937.9578-3-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250522200937.9578-1-stuart.w.hayes@gmail.com> References: <20250522200937.9578-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Stop using an entire struct packet_data just for the embedded list_head, and fix usage of that list_head. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index 7b019fb72e86..c03d4d55fcc1 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -77,14 +77,14 @@ struct packet_data { int ordernum; }; =20 -static struct packet_data packet_data_head; +static struct list_head packet_data_list; =20 static struct platform_device *rbu_device; static int context; =20 static void init_packet_head(void) { - INIT_LIST_HEAD(&packet_data_head.list); + INIT_LIST_HEAD(&packet_data_list); rbu_data.packet_read_count =3D 0; rbu_data.num_packets =3D 0; rbu_data.packetsize =3D 0; @@ -183,7 +183,7 @@ static int create_packet(void *data, size_t length) __m= ust_hold(&rbu_data.lock) =20 /* initialize the newly created packet headers */ INIT_LIST_HEAD(&newpacket->list); - list_add_tail(&newpacket->list, &packet_data_head.list); + list_add_tail(&newpacket->list, &packet_data_list); =20 memcpy(newpacket->data, data, length); =20 @@ -292,7 +292,7 @@ static int packet_read_list(char *data, size_t * pread_= length) remaining_bytes =3D *pread_length; bytes_read =3D rbu_data.packet_read_count; =20 - list_for_each_entry(newpacket, (&packet_data_head.list)->next, list) { + list_for_each_entry(newpacket, &packet_data_list, list) { bytes_copied =3D do_packet_read(pdest, newpacket, remaining_bytes, bytes_read, &temp_count); remaining_bytes -=3D bytes_copied; @@ -315,7 +315,7 @@ static void packet_empty_list(void) { struct packet_data *newpacket, *tmp; =20 - list_for_each_entry_safe(newpacket, tmp, (&packet_data_head.list)->next, = list) { + list_for_each_entry_safe(newpacket, tmp, &packet_data_list, list) { list_del(&newpacket->list); =20 /* --=20 2.47.1 From nobody Sun Dec 14 06:34:44 2025 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDB1D299A82; Thu, 22 May 2025 20:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747944607; cv=none; b=pI/Tl2JBPFLivThZ9jrJpa5BiCdFiFLr8l4hftcuS+W9MS4ENI3iHahl8GKXdegFmsRkHe9WBQn5voU4iKKeFCh8cERUu9TYYypMtYgIzaDdZ0JGFyC24tBEMODUc+uRYnRycDbVVfzVBj4mseErj4yPzKqfyoHesaI4I65hUq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747944607; c=relaxed/simple; bh=yErHsHeJjWcuHxho3mY47hFQuRX/I6iGr/Ifguem7hM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ogPSwcF+SRVe5hK6zBI5Z1GS4ShcNahQ++hFLlQdJUYmVK+Y0alqXgQ+lROEUN5cp9gJ7/y2vjPYQ7CUz0u160xVDcOiDx0DEF93YjzSlicHpm9XyMpQ/VO4FszIoIU1EGbeaKaO3F4EWaAji95zykfywrkd0wEP23jEv0SIFq0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GgxJA3Ab; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GgxJA3Ab" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-404da7584adso3475902b6e.3; Thu, 22 May 2025 13:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747944605; x=1748549405; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FkXwot3ZtDxYGxFh1Bb5xfVQC7W9CJxSBom6soP1diU=; b=GgxJA3AbWiqVgs1oxo0VYbPzOKdnQJvLhpHcOSFxshZM/QuF34eyYB12G/rBsPmgQc BbLw/E4Nbv/5gPYWD6xc2bLsq59ks0stWZu+Vf3JhhjzgO+6BzdJfGAjVzu2jqKaks2j CL6rtHFGpttofjV+nNWI3tJ/KUnoZs6UHILurjSJSBsDfudb4waSUhdAMDYXLnlCWX2v 4FYm8xl15WApCECPyOxfFdjdeVApL8hO9MiCiiAUrQYKwrTgjhDzuSAJ8PiQDqHkwy3H bqx2k2ANK2Gj2W5hUPH97VTn+dw5eOsLgWardH+E3rOv8FShTav1hkCkJluytILRNZUD lvdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747944605; x=1748549405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FkXwot3ZtDxYGxFh1Bb5xfVQC7W9CJxSBom6soP1diU=; b=jVqe6fHRPLozDyXDVeD8HU0H8zRTvstKteXIJrZ0P4qpOFHDMouXweDTcxc06RnTA3 VGbQq/Nd1H9wDh835TlTEjBFPrEXXZhIGHyRqjTNVz6VbVool4KeU8y1DNGJSML4821p vq0QN3aXh7zCcvoemR+pnQtoEN9jARe3T6m5vTh/bO+3y3t3dTPKm/IT5xmAfg1sZS4d POs1QC0ap9qWRId5inGYgCkL8RpNLcWFFNDuTn8d3+Vl8tqWCR8Ix+st3bMMMeuMI5Ld kFV1NZJm9A/MoHDQbetY7bU3+SAYI5CUkuIJMV5qjcHHqZ+vb/JTZ1hCGYWA29l28jMN BSnw== X-Forwarded-Encrypted: i=1; AJvYcCV5Ab+QAeCowU1wyWEM49+n5vdg2LiNHIwgCVEaQdihWip5az5NWieSrz4T/fbWOfqKT7iXP9Zmcf64AgHBBeXCfxid@vger.kernel.org X-Gm-Message-State: AOJu0YyFvUitTHcuijFUzo5skE9NgzeCvEeORrRklMyqJqWh2naMhLzX cS8j6LYCtjYkTaRKgj369s0cIXwY2Xc9twnvZoaLhSfZTJxXNY2OWshecfUEAA== X-Gm-Gg: ASbGncuQrPwbrSAgUGOzWORcj3lLN3dwB0kS8rEr7sug+LBO8a18HK0YdGgelzJgxUH sT8Vuy4HzEVWWO5OhIZ0jyk1SLUcfnAyzjMzS03mEkUPRWWGSl54LCl9lZ5KUqTS70sZ4wRUNwX cPeACXJrUUaY1CRMLrt42buG/IHRm1oU+1HFmKV1YyND+pKFS2WZdC3ux3n4QJCRTilKYIbg2P7 gdMB83oqkUk/dvOeHtwQj2Txw3a9CvmZb+KOhSYbcZ5+FrlH86YGQy8pi8b7RKUc857DMP/+L2L RBDk1gPUA6OomPsjPRdwNWrTwKg5lpA4ZZ0M4wA98u7nYlR5wljZY3uPTO6EMGEgJ3b+0NvRaZe gCQSzGZpUfNVbyWEfdDTj4/inw6Fa X-Google-Smtp-Source: AGHT+IH6ha5kvvBtNWk2XVpq5k0TXr5PkbekFejLm0LBd2r/JtF9zjhFNbUsW5Xjvw8N0fVUmGuTSw== X-Received: by 2002:a05:6808:6c8b:b0:3f8:e55c:16d6 with SMTP id 5614622812f47-404d87fe3c5mr17659445b6e.28.1747944604804; Thu, 22 May 2025 13:10:04 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-404d98b2762sm2651046b6e.32.2025.05.22.13.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 13:10:04 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH v2 3/3] platform/x86: dell_rbu: Stop overwriting data buffer Date: Thu, 22 May 2025 15:09:37 -0500 Message-ID: <20250522200937.9578-4-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250522200937.9578-1-stuart.w.hayes@gmail.com> References: <20250522200937.9578-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dell_rbu driver will use memset to clear the data held by each packet when it is no longer needed (when the driver is unloaded, the packet size is changed, etc). The amount of memory that is cleared is (currently) the normal packet size. However, the last packet in the list may be smaller. Fix this to only clear the memory actually used by each packet, to prevent it from writing past the end of data buffer. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index c03d4d55fcc1..7d5b26735a20 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -322,7 +322,7 @@ static void packet_empty_list(void) * zero out the RBU packet memory before freeing * to make sure there are no stale RBU packets left in memory */ - memset(newpacket->data, 0, rbu_data.packetsize); + memset(newpacket->data, 0, newpacket->length); set_memory_wb((unsigned long)newpacket->data, 1 << newpacket->ordernum); free_pages((unsigned long) newpacket->data, --=20 2.47.1