From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2077.outbound.protection.outlook.com [40.107.20.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D28AA1A0731; Thu, 22 May 2025 17:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936627; cv=fail; b=L2nlQhnSNcgqTO/g1MKIezrA8sxzsdcvxA3PBkk9048hSzrXkaeMe1uNw5/hh8IGvAQRcCWi30aJslevnGsxlwdBXDSt2KpI58fXeEfLPdGKPTYuU5wFyeoq20S6tlNk05BTK4ouOhiaQRbD/lrOppSvqUbUyrcYNXYIf1bwEJM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936627; c=relaxed/simple; bh=dBUlSJpzjbUmBTpr+2m1JOI/ns+3EB1YWtPIw2okfZQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=a/+g6/GbnHPWltnevz03TD4HrS/KsaAfzdLDo3y0vZnMYuvStlU19/S6qb/ICa6QcrobiDDE/8GnFbOWCQX30DnQEjfQzRaTpweNU5mrbZxX6R7J759vFIeryeQGgGIyKs2/vRi68m9uB+gptdokI9WYZqFMKJmHEByexuFC7jo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=FMUADXRp; arc=fail smtp.client-ip=40.107.20.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="FMUADXRp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wK8f3knRaup1h4mLMJIO0PsAT49ZpwuXXXdjb/V+zVhQfeGvAn5S7Cvgg0X3STG3miWL0CQxOCIUbW1/+zt9cjf5Ho/od2ZuaguNlt1mYP4NUnbteHagykufefBY2ElnCGR6+kXzJorpLrs/XKgojLozNhzYQs+mYOW6RT6M2PsjBtKygn5ZpQ6WekwNJ+sX7n6iVXtdumLq+8YEiFW4nLOsWLyAmyuY9g76FimVUllnjf1qekW5yltGiy1I83nzMs5UimKkxJX7yFVydS/wS+Wk5kpDZmpUM9ZI1g0OOfyu7aPaCpTLdiUTjuyKp3o66x+5WpuOQMDE70D2vGV/Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pqApBI42obYB3O3fG3EaQwfZiquOi9lcp1MJsN6Ortc=; b=OaUuHOCJJpHS42o+a678/iFnggS97UuIdhRo/JSuWm4HftZh5UdvBJebGdUFl+wgluOuGW1hcuOGZGg70AA9X30VDe3NX6hanAwRjzGG+81p/YVQxO/Eqj3DE81aj3aa800QVGEPJHIp2mrppuSAVSLQp2PiZkjBkjq72yzDm7Lqx69Fb7oZ+srj2oakDaCvXZIY3uTJKitErLPSNkcEPKg7uwAHie3cPSy5uEm1LpsxiYFKfktXfN6zztovxbj/15VkrQRWczbBLrlNRvN1Ens88Mv/S4UKalIR4VE9lD4OHWq+WIOEsZ5imcbMHL0y/4YyT65XrSjWnPvO6J/lKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pqApBI42obYB3O3fG3EaQwfZiquOi9lcp1MJsN6Ortc=; b=FMUADXRpZV6QbT5iX9oAawiMLrfLjgS3nMqcdI+OsAM/bvSGE8l2NKIeqhOh7m3d8WLp+ysCfRxqG0IY2+b70zff7mE2454uePpg6B3EOcmzS6zNX/Wq74MsZ6WqeR9Mx+wFrgldQ+RajG2Dy9UJDOfmI/c+Yx5vJjEh1vKxGy7BiOUrdgcA5hiiX6FF38H9NX7H/WL4yTV3vzt/wk5+/T45AQXR/sU/Xd5W34jAJ71ZZ/PJjCkNihG87INkreNCnOBXRkskHJAXQA6GXLl4iEsYSFzLCtViVj5i+3PEe4wa7DLVJEsaCpVxcc8yDcj6FSGkJa7sk85XTkBSWxiKbg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM9PR04MB8779.eurprd04.prod.outlook.com (2603:10a6:20b:40a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.19; Thu, 22 May 2025 17:57:01 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:01 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:39 -0400 Subject: [PATCH v5 01/13] media: dt-bindings: Add binding doc for i.MX8QXP and i.MX8QM ISI Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-1-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=8858; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=dBUlSJpzjbUmBTpr+2m1JOI/ns+3EB1YWtPIw2okfZQ=; b=Cs0TRZ5Or2Rl8IyxdSpev50bss5fxnKrWZYXPPaX0HHZc3UQylIJ8avK4DG0b+jqwdgxHCupp OoGvEPS7LoxDtN9n/cS5ej3ObP/4F0FCmiqdoDLDNn0Piu2WAOQGW+I X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM9PR04MB8779:EE_ X-MS-Office365-Filtering-Correlation-Id: a2ceba71-5664-478e-60eb-08dd995a0dac X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|7416014|921020|38350700014|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aXdtNjU2MVFLZWJQbUVZN1VZbXlLK29iMjRoRmppN2cwbnZoUVZyYkNtR3pq?= =?utf-8?B?Uzl3VWEyeE9xUnB6UHN0VGljcUNNeExMNVdEWG5pL1FDOS9MN2lZRFNHWWtB?= =?utf-8?B?bVB5K2F0Z081OTYvVnFOaWFiU2o3ampOSjA0WUtVeEs1RHRkR1BpeUVhTXJU?= =?utf-8?B?Qm1wRmsvcitCWURsQ1ZHclBsNDlTY2pxQS9XYm13UFVmd2p1ZTVzem4wM1k3?= =?utf-8?B?aHhWVm5QdURidU1QWnZsWDhiMWcyeTRrNTYyK3YzZnVscCtWNHgwRlI1WnNF?= =?utf-8?B?TFNaK0k4cmprMjh2WU1taG1MOWVaUEdzOUdlWC9qUnZmUGRVa2xBYjczZFhn?= =?utf-8?B?cVJ3V3ByTWhJVGV0ZkVpVGRrRVFRSUF6UjA3WnhYRVVPNkJaMjJvdSs1REx1?= =?utf-8?B?VXZBenlORnZqaGxRRzZDeXJwM2tudUZvUnFzYmxXZmJDaHlCWHpuV1d6VG5n?= =?utf-8?B?aW9ZdjFqa3NPZk8zYisyV2t4Wm1RT1N3QytlWllQWUlpY200aW9VZDQzSXBR?= =?utf-8?B?azFBdWczdUpjbnQ2a0lTbmsxdHI2RkRIVjhvSzNZQmsyN0kyMy93TU55T1l2?= =?utf-8?B?UE0vd0Fzdnk4UjdoMUhPbGg2Y2JpdlVpc2o1YURZVzFWZHBwQkVuWm1UczIx?= =?utf-8?B?K1VaRldtb2J6OUpGVytUSGk1SWJvWTc1Z2V5RlU0SXBtQzZ0V1lNQjluTkVO?= =?utf-8?B?YkRrQkNkdUJzS3o3cU5WcEtIWHk0NDB4QlUrOWN3L2VzUW5Xcm5sV2tjS05P?= =?utf-8?B?dU5jREgrd3ZxRlp5N05mcU1rV3lhY256c0crLzlxaUV2ck8zeWtBSUpJdUls?= =?utf-8?B?R21JdnBONjdOQkVWZ1hpeEVpaVViakoySGl5N1FXMTRIWmpTWUd3RnZUYzBD?= =?utf-8?B?R3VHSjVzSERDcHFEMmZkTWFPdEtqbFlSbHNwSjRqRzFSMWhRN1pXZnFBeXl1?= =?utf-8?B?VXM5NjBrUkxKQXNCSG9HQTdDZzNqMHBMbDNxaTRENjdiL3BobWFIcllzM2NC?= =?utf-8?B?SWVaZzZxQ2twZ3UzZjNFdFZHMkFQTU9lcHhGaC9wV0lEYm5ITjdvUnVNVWs5?= =?utf-8?B?Z2xsVzczNDRoRXBBcnpQTHhFbjliYkNEMlQzb3lnQUkyR2ZEVXVVT2xWdHMw?= =?utf-8?B?YVRvK2FDOWhpZ2FFQUZGaXc3blNiaVFKWGpzK0YxZytNdVNSWFMvbFBQOFN6?= =?utf-8?B?VHZVREY2MnFia05VL0JFOURxQ2U5S29naDhzWm9IcWZ3QUtnZ1U5bW04TmxX?= =?utf-8?B?WE41UCtDRGxLMTlEZTFSYXlOU3p4clZEV2RkdHAycEJPbzk3dTNEWWk5V3pt?= =?utf-8?B?blVValhVNEJITG94YVNiQ2xrMVRDL3lMWUdqdWdXZWkwczh3bTZJcE5GZTNR?= =?utf-8?B?U2lyekljMSt0WUE1NDl2eVZVQ2g4eDJLWlBFSjJib3ZRbWRCOWNRQVhudzYz?= =?utf-8?B?UlpIMTJ4WjM1aUFGZGxOMHpQWCs5S3Qzd0NOWGppcnZoQmZKRnB6R1VXMHY0?= =?utf-8?B?UHFaRkFCVEFMRlB4V3cwUHo1ZldCWWc3Z0NVOHVPTkl6QXRmWmpIQnF4dDZu?= =?utf-8?B?RUZvUndtSWNqOEtHOGppWXFpdENFaTdjTVhLK2hYcFlVNCs2UldwNGp3cjh0?= =?utf-8?B?enhGVk1iTVE1NVdEa0JNQ3lPSnRwWVd2YXMrc1JEdnMvbVR4NGdoOXh0UUZp?= =?utf-8?B?eFpqaGdFK1h0T200dVRNSlNDNWpXenhGdTJEZ3J5KzVRZkZ1VngraDhrYWVQ?= =?utf-8?B?WXMwVEFCOG8vR3pSKzZydzU1ckVjdDFueEJJOVFlUXpjRlNtVXhjL3VxMmor?= =?utf-8?B?T2JrRzdhNzVPelQ1dy9XTHJYME5aTWM4Z3VTNHJLQU9xYzZNV2tOOWJiVTlD?= =?utf-8?B?cFY1cnBjcGExeXNuRGd0dTlGSkhZOFpvMUJnWUpHcXF3TFZFWmwvd3gvcXc4?= =?utf-8?Q?uSyn2D5PsFRk/pr8t9QqWZiJQ9kAcbCy?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(7416014)(921020)(38350700014)(13003099007)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkpCZVBTaE82dy9JeFE0bUJBVWpHUnI3Q0paNFZyQ2wzSmcrR3ZaU2VXOGly?= =?utf-8?B?NS9DaVhqMk1nTHlGNGdUUlZ6MzhrNHFnYWFTZHBpblp6UGxLOXBJZHo5NFlS?= =?utf-8?B?dmFNVHB5cUNpcjZEUHAyMHBSUDJvc0dEcXk1VDFreFMvMk1Vb3J1WHEwMTQ4?= =?utf-8?B?aTlSWXZ5TGxJUStaaXBTZFJ5dnlscVpzYUhBWFVuUG40MVdrbUlQNzJhb0I2?= =?utf-8?B?RGhGV3dIRmpGRHZHVnp2WGxrTWlVVmc3YUN6dk42YUhrZVhGZUNVbGtwMUli?= =?utf-8?B?Q2VZYThIYW5ZSUtDMGNSL0dVeUZwSDdjNklMdytjZ3FhTStxdVk2TFFHN3Nw?= =?utf-8?B?cXBldkNEcHZWaTJIekhEeTdXUUxScXVOYnNxMWdPeUZncTVwZ2JIMTN4UjB2?= =?utf-8?B?T0ZyYlVRNnQvVWxEU1hVZDJwK1RQQUFDVW5HWjdadUw0TzI3NUp2VktEdXRC?= =?utf-8?B?RGsvMkN6d1pyTWhzb2JtbTA1bm4vRFdZUE5rU0xvTElJZVpPV0psY1RiS2lp?= =?utf-8?B?Z3Z0SDliR3BaSHI5N2xzZ1FsYzhzZk5iQnYzOEp3T1F5bVRlNFN6TmFheVhv?= =?utf-8?B?dUs5aVFZT3F0eStYWGpSK2crUktud0N2L0UvSisvbFJ0K2MrTUV4Y0xtK1Nl?= =?utf-8?B?WVc0cW05NGNSU3BYSFhBdnpRUDR2T0QrbGVVb2IxMUNTM093cDJhLytyUjlC?= =?utf-8?B?c0U5STc3VW1xZFp2dWhHV0dIY0t5aHBVY0o5Wm4wOEo1bTZhUjZXMUpmWG5U?= =?utf-8?B?TkNBRzN3ZmFjRkQ3Mjl1VHpwdGhXVFhqdDBtWEtUVzJaSU9oUVhOc0tjU3lS?= =?utf-8?B?VnU5R2pBeFVuMkRQWHNsSHFZQzU2LzhFLzMvREtCbVZRc0lpRE9JamFYaHdX?= =?utf-8?B?NFJ2MTdXNjhROHJDbStNTXNVTk9qWUFaeWE5L1NCdDYzdWZNTksxOTdqTnQ5?= =?utf-8?B?K3V2SXdIN1VKT014emREdmovZXA0Y0hNYzJGTDNWNWIyQzZ1Q1hudmsvWnBq?= =?utf-8?B?Y1ZSUzl5SFE4ZWNaNzM3WC9KQXZxVDY2VzFJbUpxR1cxV2tzRUVuRkhFVVZ2?= =?utf-8?B?aFg3VHM4dmo5SjNZSTJPMURPNDM4dDdlL3VZVlRQajBaWHRjR2ZRVEp1QU1E?= =?utf-8?B?bkdHVkFWRUhRbFJ6QlFvWXU5cWxYcEFMTW1CNXp3TFcwbWxZYXBKaXNlQW1F?= =?utf-8?B?WHMvWnVqMU5lb3RXSGRTcTAxd0piMmxMNFhIMHl2U3pwQ2k3RHVDT0Z0dTJE?= =?utf-8?B?cFB5OXI1R2pERzJ6czFkY2o1TXRZNVJwSnlXSy9kRjUzS3dJdzlFalpJd2FQ?= =?utf-8?B?bjNtRkVjRXJPaUlOMkhlRHpZNzAvRW9zaDVheWJQaVpZb0s4bU45Mk50ejhp?= =?utf-8?B?dzBsekVwUCtlKzU1MWFITWpiMFNnd1cySUsvVzBRbTJXM1NNbmxsaDlwM1pS?= =?utf-8?B?dFpidWFqNWVXY0V4NjE4aGFmRGM5dnNwVUtCeTRQNzhTaTIvZzNRU3VqV0xU?= =?utf-8?B?a2t6YnlGd0lGQjRzVUMxSllob1VxVEJ6NG1VcHNicmVkMUpJd20wZDhVamJj?= =?utf-8?B?R3VFNU5wUWVTQ1puQTJyUmtvUlNrOFVuWjdLOEFFWVBRek9SS1prVFdPY0hH?= =?utf-8?B?OXdsV0NIVmhnZitXV2xRRTFjVmVwMUF0ckNiTDNyZFd6MStQK21weVY2Q2JH?= =?utf-8?B?YkIzcUZOeVJ1ZUZXRXVZVjFLdzJqOXFhOVZkY3FFcjlRbi9KcXR4UWR5YVV1?= =?utf-8?B?ay96dWJQOXlodk96bDRLV2pyc3VJL0JIZmU2cFQ4TGVQcUI0OHAxNG5mL0ls?= =?utf-8?B?U0IzRklVNlZ6MGJ6MEE2MnpreFRPT3AwRkYwMzI2eDdxMU1iYUFLRzdxbVZu?= =?utf-8?B?ZGpYYUdxQWE5M1pCUzRSWWFwdTJqbmpHMmx2N21idTJFYlZVZnBqYkdJN2pu?= =?utf-8?B?NjZKRXRwc1dsRHVWOHYra1hNMy9uQ3lxY3hWakZwL1JVVXlzZjVPZmdrRGt1?= =?utf-8?B?cVhzUnc3OTZOVjNKek5nTzBXNmV5NjI3SGdyNHBTdWlVejZRV0FEU2lSN2N1?= =?utf-8?B?MWtrVmh1NFdCWSt6a3hFS080UmlaWC9DeXB6Z1JOb1Rpb1VzNWhxVmRweW5j?= =?utf-8?Q?HvSininHhAnNP22Ryh2OXuZwy?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2ceba71-5664-478e-60eb-08dd995a0dac X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:01.3495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A11vMwcS/gu1/RJw/A9208zlFWgqq+w7kUQXsuhz601QKMq+gwvt6AmRCvOihxxEJt8Ouv2auYs5C9iipGbSbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8779 Add binding documentation for i.MX8QXP and i.MX8QM ISI. The clock-names, power-domains, and ports differ significantly from the existing nxp,imx8-isi.yaml. Create a new file to avoid complex if-else branches. Add new file to MAINTAINERS. Reviewed-by: Rob Herring (Arm) Signed-off-by: Frank Li --- Change from v4 to v5 - none change from v3 to v4 - Add Rob's R-o-b - change qxp clock/irq/power-domain to 6. (QXP C0 change 0, previous chip have not production). - fix register size to 0x80000 for qm, 0x60000 for qxp. - fix qxp's irq number and clock change from v2 to v3 - none change from v1 to v2 - create new file for 8qm and 8qxp accroding rob's suggestion. --- .../devicetree/bindings/media/fsl,imx8qm-isi.yaml | 117 +++++++++++++++++= ++++ .../devicetree/bindings/media/fsl,imx8qxp-isi.yaml | 106 +++++++++++++++++= ++ MAINTAINERS | 1 + 3 files changed, 224 insertions(+) diff --git a/Documentation/devicetree/bindings/media/fsl,imx8qm-isi.yaml b/= Documentation/devicetree/bindings/media/fsl,imx8qm-isi.yaml new file mode 100644 index 0000000000000..93f527e223aff --- /dev/null +++ b/Documentation/devicetree/bindings/media/fsl,imx8qm-isi.yaml @@ -0,0 +1,117 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/fsl,imx8qm-isi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: i.MX8QM Image Sensing Interface + +maintainers: + - Frank Li + +description: + The Image Sensing Interface (ISI) combines image processing pipelines wi= th + DMA engines to process and capture frames originating from a variety of + sources. The inputs to the ISI go through Pixel Link interfaces, and the= ir + number and nature is SoC-dependent. They cover both capture interfaces (= MIPI + CSI-2 RX, HDMI RX, ...) and display engine outputs for writeback support. + +properties: + compatible: + enum: + - fsl,imx8qm-isi + + reg: + maxItems: 1 + + clocks: + maxItems: 8 + + clock-names: + items: + - const: per0 + - const: per1 + - const: per2 + - const: per3 + - const: per4 + - const: per5 + - const: per6 + - const: per7 + + interrupts: + maxItems: 8 + + power-domains: + maxItems: 8 + + ports: + $ref: /schemas/graph.yaml#/properties/ports + properties: + port@2: + $ref: /schemas/graph.yaml#/properties/port + description: MIPI CSI-2 RX 0 + port@3: + $ref: /schemas/graph.yaml#/properties/port + description: MIPI CSI-2 RX 1 + port@4: + $ref: /schemas/graph.yaml#/properties/port + description: HDMI RX + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - power-domains + - ports + +additionalProperties: false + +examples: + - | + #include + #include + #include + #include + #include + + image-controller@58100000 { + compatible =3D "fsl,imx8qm-isi"; + reg =3D <0x58100000 0x80000>; + interrupts =3D , + , + , + , + , + , + , + ; + clocks =3D <&pdma0_lpcg IMX_LPCG_CLK_0>, + <&pdma1_lpcg IMX_LPCG_CLK_0>, + <&pdma2_lpcg IMX_LPCG_CLK_0>, + <&pdma3_lpcg IMX_LPCG_CLK_0>, + <&pdma4_lpcg IMX_LPCG_CLK_0>, + <&pdma5_lpcg IMX_LPCG_CLK_0>, + <&pdma6_lpcg IMX_LPCG_CLK_0>, + <&pdma7_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "per0", "per1", "per2", "per3", + "per4", "per5", "per6", "per7"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>, <&pd IMX_SC_R_ISI_CH1>, + <&pd IMX_SC_R_ISI_CH2>, <&pd IMX_SC_R_ISI_CH3>, + <&pd IMX_SC_R_ISI_CH4>, <&pd IMX_SC_R_ISI_CH5>, + <&pd IMX_SC_R_ISI_CH6>, <&pd IMX_SC_R_ISI_CH7>; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@2 { + reg =3D <2>; + endpoint { + remote-endpoint =3D <&mipi_csi0_out>; + }; + }; + }; + }; +... diff --git a/Documentation/devicetree/bindings/media/fsl,imx8qxp-isi.yaml b= /Documentation/devicetree/bindings/media/fsl,imx8qxp-isi.yaml new file mode 100644 index 0000000000000..bb41996bd2e36 --- /dev/null +++ b/Documentation/devicetree/bindings/media/fsl,imx8qxp-isi.yaml @@ -0,0 +1,106 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/fsl,imx8qxp-isi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: i.MX8QXP Image Sensing Interface + +maintainers: + - Frank Li + +description: + The Image Sensing Interface (ISI) combines image processing pipelines wi= th + DMA engines to process and capture frames originating from a variety of + sources. The inputs to the ISI go through Pixel Link interfaces, and the= ir + number and nature is SoC-dependent. They cover both capture interfaces (= MIPI + CSI-2 RX, HDMI RX, ...) and display engine outputs for writeback support. + +properties: + compatible: + enum: + - fsl,imx8qxp-isi + + reg: + maxItems: 1 + + clocks: + maxItems: 6 + + clock-names: + items: + - const: per0 + - const: per1 + - const: per2 + - const: per3 + - const: per4 + - const: per5 + + interrupts: + maxItems: 6 + + power-domains: + maxItems: 6 + + ports: + $ref: /schemas/graph.yaml#/properties/ports + properties: + port@2: + $ref: /schemas/graph.yaml#/properties/port + description: MIPI CSI-2 RX 0 + port@6: + $ref: /schemas/graph.yaml#/properties/port + description: CSI-2 Parallel RX + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - power-domains + - ports + +additionalProperties: false + +examples: + - | + #include + #include + #include + #include + #include + + image-controller@58100000 { + compatible =3D "fsl,imx8qxp-isi"; + reg =3D <0x58100000 0x60000>; + interrupts =3D , + , + , + , + , + ; + clocks =3D <&pdma0_lpcg IMX_LPCG_CLK_0>, + <&pdma1_lpcg IMX_LPCG_CLK_0>, + <&pdma2_lpcg IMX_LPCG_CLK_0>, + <&pdma3_lpcg IMX_LPCG_CLK_0>, + <&pdma4_lpcg IMX_LPCG_CLK_0>, + <&pdma5_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "per0", "per1", "per2", "per3", "per4", "per5"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>, <&pd IMX_SC_R_ISI_CH1>, + <&pd IMX_SC_R_ISI_CH2>, <&pd IMX_SC_R_ISI_CH3>, + <&pd IMX_SC_R_ISI_CH4>, <&pd IMX_SC_R_ISI_CH5>; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@2 { + reg =3D <2>; + endpoint { + remote-endpoint =3D <&mipi_csi0_out>; + }; + }; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 0cb9e55021cb8..c4e0b88f58309 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17853,6 +17853,7 @@ NXP i.MX 8M ISI DRIVER M: Laurent Pinchart L: linux-media@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/media/fsl,imx8*-isi.yaml F: Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml F: drivers/media/platform/nxp/imx8-isi/ =20 --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2077.outbound.protection.outlook.com [40.107.20.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83F681A3148; Thu, 22 May 2025 17:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936629; cv=fail; b=Vpgu5qd1vzBRn4eD08/hLAOe/V81+TG4zGNYzYElMIXeUgk2ioIsk5C/4DIDdCXe/P+fXm9AIjz2R/EwjYiAfK3snD9FjOTkLhaym9RyTuAJBT2j5+QGNlGf2GeSCYSvMZzGUHVrlerxUZp0uAdI6Q3/btQJ4/C3jMkqUhlikcI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936629; c=relaxed/simple; bh=dbvfHs4Y1u0Z4nbcX83zBCGc85HmV+AR+iGjoQBpZS4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ppXh4oALThpcaLaYT3G7sElmq+aA10eJKgeim3KjesCkQzkuQ7uVOMQyemhHnpverEnxmCbhWfVRPNvCbFEPewaDp2i+AwgBlc8LkEkPoE3TLPAI6yE7qfdO8DP8Xf9zyvORBkMdar2V5BE/bnyouSOqjq4QBUGA+CY2okHVC/Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=C6HBtYL3; arc=fail smtp.client-ip=40.107.20.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="C6HBtYL3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VbZzQixfOaKS/399ARfEjuUfcop8QA3hgziLl+trWw6Lu/peCMoop5e6x2Cph2p+tTgWPe78pGCLFFs0/JGSAsoCzm+90/BBDW110MI0twSA1SaKGJ+zjx5zKq+sCL1QNuspkFQMHXopzL4k5Y9UA7HgJx33NYK0JGEOHzd8gxC4KqIGmd0WwGc3yK2xQXeuRlYZFK/CMF2RsHtM6wmjkhxmxvZK+FuLZnjgnUohjeEUUOuzqEZMWPjuzYaXINyuORY11ygs6TlLpzgz3m3Ey3CRNUeccc4PgCTYiMXsoelykN5AIFmY4rCh1kwwGvLhIM8DZYlnFP4Vx1UCyBCUQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+VETvqoxvgoeZOItDUdI81FqR1pnbi0KyE/AF7g8nYA=; b=RJ4CJdw13VVk/9BGJiv/HJ67neaUmsnM7Hqoq/0yTrbMhmcJUxh5/lknUfpYKyI28JppBXlZFCH60vI/je5WL+0tyg4FemHxY5GCnX2/qZWIm/hJNmgF0TRPMEQDuUYnBM5AfbSh2/CDFs4TeWpZdshRWnqBisLq6+H/yUFgbwIPGrhPglKKP41HAawfbIJlJ/DGKHLOvOfb9G2y4hB5+nu57dnuCcdBSfzGXcgJwE5E+JcQCJ7SrXdbX0s2WUJMs4xmnZ0KK6Gu9KisZlZA1yPu/YyW9AAaW6ir5kZarxIUE/KU3rkmF2hUasAyNMUdwdswBLNv/DDl6B7wXzZl+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+VETvqoxvgoeZOItDUdI81FqR1pnbi0KyE/AF7g8nYA=; b=C6HBtYL3d5D3HZQNgAlp90/kX65TbwWWe5yLtQDajys83vO/Zq1U20ZYPsMH2WxGoSQZEZCFqmgclgTDrSiYR18wV+MUlMELq4tuF5wyhRn/wDyIjlL06JJj8p/Z/WY18mDM/AAGFZ9vcucNmyw67gyosiWGXINqyLBoaHe7zLv0nqLZccXUIU4ajIewZsLrSbcwND4C6e1V+HVWSYtaSfqC1X7pG7ZT4+aw5PXDpgXQ+3+2XH24IJt1Sdf75A+WFnYWRcx1MIzVZXj20LUkB7/SV8Z9Ec3Bz+Ia1XXKXd0md9WS3DB3zNRFzauJzVc6c3IqwVpJmRQHmBK0szWaCw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM9PR04MB8779.eurprd04.prod.outlook.com (2603:10a6:20b:40a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.19; Thu, 22 May 2025 17:57:06 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:06 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:40 -0400 Subject: [PATCH v5 02/13] media: nxp: imx8-isi: Allow num_sources to be greater than num_sink Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-2-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=2343; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=dbvfHs4Y1u0Z4nbcX83zBCGc85HmV+AR+iGjoQBpZS4=; b=XYssoSUC7BG/I0OwAGTgjZnBdh8e6lnW7eHuduxdXMNhGZsqJ2Zv+/cdF1X6uHLyyjxbeTbda M+rfI0mnYYiACM3cn+SvJc+4q3uWdnF8t1rZmvqwdGf3+fr04PKZfwy X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM9PR04MB8779:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e70d656-1375-40c9-d9dc-08dd995a10a2 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|7416014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q3k0ZS9sNFNKbks3MmJwa0hxSmZzUHhOdGZvWHNlckZXK211d2kranZwWVRT?= =?utf-8?B?NWtvMjMyV09NcmU2OWtvTmhldDFLUVVLOGcxSFJQQUcxdExlR0pkYnM1Mjdu?= =?utf-8?B?SFFKbG5rcWwrTTRnVlhTRkplcHRwWm1kMHZ5d2pqOHd0cG1BZnR1V045SHpm?= =?utf-8?B?N0FlcmExV3k3MDdwMkx3dlFzZ0c4WjJLVldtZmNOQWZPMGJ3M21TK3JReDIz?= =?utf-8?B?L3ZIbzBDMXpTanRRWW5iZGVYdUt2V2dtNHA4VWp1UWxWSjBtcnk5azVTM0NN?= =?utf-8?B?WGx6Nnlvdi8vdkNjdERvTlJQSWV1eXE2VzVJaDJYVnZuMmF4LzVsUlk5MWlo?= =?utf-8?B?THk1b1Q0SkFQQmMwREZxVWh4aFpMMEU0aFpQckREZGVuN3h3UElSak9hVmtX?= =?utf-8?B?KzRqZllSbTB6dDdsVGVXbE5XajV5dU9pZm1TSzJJUFBCUmVITDgvZnhyMFZj?= =?utf-8?B?T1k3dE9HNzBlZmxwWmV2b2ljVGdQY1JMRzJvSU5GdDdPRm1lbXhTYkZOMUhW?= =?utf-8?B?N2RCcVdsQ1RIdlNiZ1RTM3F5WUR1TCtBemY2QkNzTjBlS2hkSXR0UWFHTnps?= =?utf-8?B?cWpPRCs3OWs4WEw4S3R4TVFjRHZxUWtDQ2RFK3pYWnhIWVp6NEhFeW9vUmQ0?= =?utf-8?B?cEpsZHRxTUIyZUEyMzZySnFHcWtTVXFqRS95VVhhZnRZT20vSUNEMEMxa2o3?= =?utf-8?B?ZUJJeXVDM1I1MzZ1YitNZC9jMnFjRlRNQ00vZHNPZ3hlWUJNcjg0WlFCV0M5?= =?utf-8?B?ZkVaVXdjWm9WTk9sUzZSWkRMMnRMWGl1SGdJTGhkbnlSak1SUXZCajR1ZnZR?= =?utf-8?B?NDJ5OGV4RFN4bVVKcWw4ZEZHMmNHOUZtdDZqRGd3cXpVRS9CRVArUjlnU2hZ?= =?utf-8?B?UjZURHVzcWZXWTU4dnlEYWg3SWhKdGxpUDhXS2xMUkRERzZ1VUE2S3Q3c3M2?= =?utf-8?B?M2JhTVpJanpXZnNpK2hGUHF5RlhpWm1YdGJHNWVFVmFaelFFUkZPaUNNeEtL?= =?utf-8?B?ZDhPblY0RU1xMkFHZm4xTnJHZzZrMk1yYlcreXNEYnh3cVlVdHBBdUFSdTgr?= =?utf-8?B?VkkyNW1KUTBmOGpSNUxJVVltOURBcC92WVcwZm83bm9YWDg4TzlmbFhGOWVv?= =?utf-8?B?ZGVnZnBSbERCcWU1Rm1ZUnJ6YmxzcndFZEQ3SUZnQ2FXZUVKSC80QUdEY21Q?= =?utf-8?B?MEhqR2kwVS9ob3BYbkZLckVzcmJKZVU5OGpVZ25ZVHkvZHZTUHNSUXdoc0Jx?= =?utf-8?B?a0Z5SWYramZRQTBEMnJMTWtJQzNxY2pXa3EreFpwL3FDcE53aVpiQWR5cFhB?= =?utf-8?B?SkxWTmthUUUyVkRmQnhqMUdMeURIenFZY1JZK1E3UUtjZktNMWhMcW9xd1Zz?= =?utf-8?B?YUwybWtHL05oQjRVVmdsMFZDWVFZSHdLTGdaRGRDNGVjVlhrTnNjektaOGRm?= =?utf-8?B?NGFmZHFrbXJZSDQ2Uk5NWGtVOGZHejlqSEtpUjJrc3FTd1ZzVENjWW5uSERH?= =?utf-8?B?VmFvQWVWTlJYOUh0OW12Q01aVHhiM05YWjJRdnRGL0J1UmFLZWkyejBDSEND?= =?utf-8?B?Yk93VXByL1U2eWxyOXp0V2lPbkt6c2I5NXFDRE00cThDZGVjaENDdENZR0FN?= =?utf-8?B?bXhYYWNBd0EvTEVLVTJsemdqS2JJeFRyczNNMkhJM2NtVWMrVmcrOGxWVStz?= =?utf-8?B?bFRtRkI3RW1ZVDJ4aUViVjQ1K004Sm4ydVNFenVqMm1LWnJhOU14M242Smxh?= =?utf-8?B?QjBtT0t0Qm9ZOGdmZXYzY2RpWEVqRkVQL3hjMFJqV2dFS2dXTSs3UlVZWVMv?= =?utf-8?B?Tzh1S1I3UnJhZGtBSFprRUdjekQ2R3daWitnZUpvMnJSL05YLzVQUjVscGov?= =?utf-8?B?MG5vZVd1dmdVNTNKdFIzbFpaZWdQS0pud2V0MXk0TjBCUGhqRU9OdVZ6c2F1?= =?utf-8?B?N0UvR3NBNFlyMGlLL1F5ZFlFM2pkNDlOZG85NndYZURyYUh6SmJHcFR0Nk5v?= =?utf-8?Q?fYDZuKooI8zoKcy8antjtPhkLAy4P0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(7416014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDhkMHB2c1lwdVhLTXpsU0ZDbFJ2Tk9QMEZjUnZYVnJlWEo2ZVBtMjVyWUdY?= =?utf-8?B?Ky9iQzFHYU5qZnRRM0VpL3RaVVdrK21rekh1Y0pkNFAxNlpsNjNmbGxNMzBv?= =?utf-8?B?WDJIem9KbDJabGNmMzZOUXFIT3JlVk05WGRsZ3ppZXAzRzZwcW5RZHpOeGdR?= =?utf-8?B?RWRlV2ErZWpRUmVNaEpES081ckw3emdsTkp6ZHRvRVdzSXFxN09DWkFzYnlB?= =?utf-8?B?bnNKeGFuTjdDQWFwZDVwcTVadDRGblNWTDFGaytxQzFmMGxuV1kzaW5Fenh2?= =?utf-8?B?dWMraDdUQ0xlVU9hb2tSMzJFNXFXYVRVOWk1RHZDSGNlSVJ5Ym5FYW8rV2o4?= =?utf-8?B?ODVmU2NtN0NsL3RHUWhRSythZ3dPeEJPeVFEZXByYmIxZ2puV3BnWFNIdlRF?= =?utf-8?B?dHMwYXpXWXZwZ1M1eXczTGRpTHo3ZTNRVUF3K2xSenp2Yy9XdlZSSGd1bGtU?= =?utf-8?B?OVYrOWVDanB2T0hnRDhESHFpOWlSbXFmNDNOcHZkc2tpaUZvVEc1R3VnVnVT?= =?utf-8?B?VVJxcFFpeXMzNW9BanNveE45NEdsbFRIRDd4VWl4QkliVkFpV1BEb2d4dndJ?= =?utf-8?B?VVR6anRvTjNqSHc0SjRMYkdZcDZUSzhJalQ3UXMxQ1FqNDQ0UXFmMU1Td1Jt?= =?utf-8?B?L3d3ODh5dFc3OGJaTnNvSmxTL2tnNUlDZnd4Z2pNc2JaNlFINDlTUlFMSy9I?= =?utf-8?B?YzdnVzlLK0IxcXNuN200VlRWQWhQd3lIaEY0NmljbzJnVUdnL2dXSE5XYnJw?= =?utf-8?B?MS8yM2pRS01mb2lGWUVoa1FvTi8xY0ZIdE1jOGtKd2VCdDhTV2cyQkc3Yjd2?= =?utf-8?B?RFBVL1NhQnVlNE0wcmVKTjYxQ3ZPWGZId09WanQwWlNZUDFxYTltdWtJSjVK?= =?utf-8?B?T1JERTl1K3hSRnVyaDdLdCtPUlc4dzRyQnRidEcrSnNvOHFzMUtWZkphZjMz?= =?utf-8?B?TmxZS3RSRXEvL0U3bUUzR3NZYVhTNzI5bGtXU0w1aEVCTytOZFVoaFdVOGxQ?= =?utf-8?B?ajJiVFZCMzA4SzBib0U0dm1HVzFHbndldTRsaGhTVkViSE1zVmJ0Y1ZqUTJn?= =?utf-8?B?eGxoM1p5YXFNSjZVSUhRMDB6M0NvU011SmlLT1RPZmtIYUw2VU01OXVRN2Rr?= =?utf-8?B?REV6OGJ1ZzNuV296UCs1SVlZSkdHbWVydzB6dlUxd1ZzaHhFK01Za0RUZm5v?= =?utf-8?B?S09SV2RUR1pLakpMVmhYY2ZkRzJLaUhxeUZkbTZYbUx1RmZZNEpDd0JmQ2E2?= =?utf-8?B?Y0R6VTN5R2FHaEYwNTNDdDJ6RTgxd0NQNnRzRHI2M09HMmdFNlRRa2p5bjhI?= =?utf-8?B?TDVuSWtJVkszMVhpbElqVlVTRGxTS3UvaW9CbGpvQWFrdW9HZlF0Qk5mRXlZ?= =?utf-8?B?Ykp2dkxNRUs0UVBQdGlXRTg1SDlvSENqVWF3azRsbUJnbVRTdFRMYWdNZThV?= =?utf-8?B?ZTdSYkxwd2dLdDBNSm1iR1hjZUJlNzhDeHV3V2hQcUhZRnJzdlZ1RlUwdDBo?= =?utf-8?B?bkNRUVBvU2FxajlVUmk3eUxpR2h0Y0Q5WFZZaG9KKytmTmNPNW5SZXZvTlVL?= =?utf-8?B?YVNEcHRKYmprZ2tLcldiK3JGUDRjK3c5WTZrdyt1ZFhLMlRIdjB0dXVReThQ?= =?utf-8?B?dEpZMW9xZy81d3JFbVIwOHBtSTJaWE90dDg3Vk56QzVXS2RLbG5iOXlVZFIv?= =?utf-8?B?MHRvdVZjUUhkc3RiZ29WS2VYck5DTlJXc01hSytWRXQyY25aQnNhMmpQeVlx?= =?utf-8?B?RDBNd2ltVmpaWVlaOUFDdERyVnpNNjdMRWJOYTd0eEE0NFd4eExvc0UwdTNz?= =?utf-8?B?RTU5N3U4dXdtdjcrZFExSC9VZnJKVXZDSzEvbXhhbDFpSjg1dk5aTklsYXlv?= =?utf-8?B?a09pbkVBb2R1TU5lczhtaW1hZENoL2pORE1NY1hGNUcvd05sd00wK09FOFJX?= =?utf-8?B?R0xRMFEwZWhNdnhpZlViSlV2dlRsNFIwZ00yOVl4RWQxYnRsTVBmSEI0OGxW?= =?utf-8?B?dUJ2U0VXVEw1U2ZTVWQwNWQrVVIxaW0zZDBOOVU3WnAxWGQ1TUdVelEwVm5K?= =?utf-8?B?OFdQc2JiRVpISklFTVlTNFFORTU3bmc4bVljR2JvWkVrTnpzdUlyMzIraFJJ?= =?utf-8?Q?bZMMUePYGvLZKdaRYWqNXlY13?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e70d656-1375-40c9-d9dc-08dd995a10a2 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:06.3060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XIkbaUYdSjULMyAfNaE4MxTbM+FB9om01OOXrmxE+AfrZoiIIuqsja86gtNZ7aGNESF1b9gjl3r4y+6sIYgthQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8779 Allow num_sources (drvdata: num_channels) to be greater than num_sink (drvdata: num_ports + 1). ISI support stream multiplexing, such as differentiates multiple cameras from a single 2-lane MIPI input, or duplicates input stream into multiple outputs. So num_channels may be greater than num_ports at some platform. Reviewed-by: Laurent Pinchart Signed-off-by: Frank Li --- change from v4 to v5 - none change from v3 to v4 - use routing.num_routes =3D min(xbar->num_sinks - 1, xbar->num_sources) - replace xbar->num_sinks - 1 with routing.num_routes change from v1 to v3 - none --- drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/driv= ers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c index 93a55c97cd173..55454445359f4 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c @@ -188,11 +188,12 @@ static int mxc_isi_crossbar_init_state(struct v4l2_su= bdev *sd, * Create a 1:1 mapping between pixel link inputs and outputs to * pipelines by default. */ - routes =3D kcalloc(xbar->num_sources, sizeof(*routes), GFP_KERNEL); + routing.num_routes =3D min(xbar->num_sinks - 1, xbar->num_sources); + routes =3D kcalloc(routing.num_routes, sizeof(*routes), GFP_KERNEL); if (!routes) return -ENOMEM; =20 - for (i =3D 0; i < xbar->num_sources; ++i) { + for (i =3D 0; i < routing.num_routes; ++i) { struct v4l2_subdev_route *route =3D &routes[i]; =20 route->sink_pad =3D i; @@ -200,7 +201,6 @@ static int mxc_isi_crossbar_init_state(struct v4l2_subd= ev *sd, route->flags =3D V4L2_SUBDEV_ROUTE_FL_ACTIVE; } =20 - routing.num_routes =3D xbar->num_sources; routing.routes =3D routes; =20 ret =3D __mxc_isi_crossbar_set_routing(sd, state, &routing); @@ -453,7 +453,7 @@ int mxc_isi_crossbar_init(struct mxc_isi_dev *isi) * the memory input. */ xbar->num_sinks =3D isi->pdata->num_ports + 1; - xbar->num_sources =3D isi->pdata->num_ports; + xbar->num_sources =3D isi->pdata->num_channels; num_pads =3D xbar->num_sinks + xbar->num_sources; =20 xbar->pads =3D kcalloc(num_pads, sizeof(*xbar->pads), GFP_KERNEL); --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2067.outbound.protection.outlook.com [40.107.20.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 038EE17D346; Thu, 22 May 2025 17:57:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936636; cv=fail; b=o88FfYp8f8u1PWoVsFPh7adlcOpaU0qTUaV5w/6qJ7A5L1fH3ttMXU3HLf6a2dJN6RptJE4A1G+qN8mfWjr4UNEdnEruvc1uRjNMUQjWZMEQJkqxRD97vmbR5bvtVPAXj95/Sm6PLjnJkRANmFnt1QYkoWFEHWtG4TOjAIEaFOY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936636; c=relaxed/simple; bh=eZpdbImXpboiQbV4dgRf9tPUfet/08V2CU0FiUVwLfY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=lB+doqOeqDJxl3+Rny0fEPTwXD8f1qvj85t9Uyx/Cw/KFVJHn/DZpKkNMcfK1CU9KTLsp/4xVS6DI9EmTnmjRRsIZJG3Vj2/23ZkXxHxmYBIvLbhJLClsI0ghO0CuxPyvo7mS0xsYtEoqbZpdUHYpRCD5d1/BJfeJgKDX+dnHAU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=kObw82zY; arc=fail smtp.client-ip=40.107.20.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="kObw82zY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JBYFITOlbimFRElJb4Kk5P+ZTaBZAMXXX4CMt4dderHyIJIJRN2iYLl/longXXqlHjpXhLj8v4vbEIAHp1DFxrOu2jkelh5PQSfiBWgizLh/T9ul3tkHBFWfsrXpWGKYJccasnrX45bRirL3q6ubEMvt9Xtsj86lVjpp+7vddQ1IxmGIXEajYBl9m/Scz/pbhISI+62jtfUiJnDut2i7J5/9FNa9lUwFo11n0dm91W9M8fioF4ba8WsExsP3fPA+lqkSc43lOeBjH19yo62xIvG7yG7zNCPrGE14CmEE2ttXkg/XEuq1jTfvSdgyy3jG106vnBpmaZUitln2mCsFsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wj7xc8CFWOZNDj0xY+8YEP2rkK4asDaZ75PnX8kjS4w=; b=a6/mHYDWgtoanooxh0mAoto+C2ryTY6PQuDJtl72by/JkMbqCThN7va7QGT1f4xyXYcflM7YkGgacrq74pNiEpQubaMybB+yLmZLJ02ZXOscbC7/QcJBCCUOlG15AivElMZGi5J+UheWkGxlu0ikMAdSwMNkJ7ZiapU4Pb+YlFW6IDsZYnBaoTIO9qq2K4pbNsZoukEBxAbyYL9cSPWsWMBRFh0IN2NpUgNYNeo1C6Q4vHSMqjHvce9mjpoD9p6uWbao/2A/NTMkNXDDsymJBI/K9X/BsWjYaEqhoEDOHttrM9OMiZ2EfIYRLrjwoiDaSvgpzuSj5WJF5P5OMctHqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wj7xc8CFWOZNDj0xY+8YEP2rkK4asDaZ75PnX8kjS4w=; b=kObw82zYkbUhkTB4m64FF8qE/TYb6WWGwzOvtPCajcxcX3+Y4efXlWK4uRf2X7dJcubLs+OMU7hYfPhB6EQQpOrdtP+z9fHxV07YkIwly60E7gMEwbvmvMU6GgDJhhN4jbslO/M/OPeMeaqlaUQ73sGsbl9t6STympqDoxzrrPYaG2iRn6LtFyfGSwp2+CgEP3NYP31tHtLthBv/YR4RMp+l6x8arOx2lUAR3Uu8Gan08yZtb0v5iL8Nw5aGzmsBDTaYOiE8FAWwUeHLvcEJG/wF1zRo39Vcmkgphhxv+OKcNFHoh+WXHZ6arit5EGYTlAZtpHNlQ/93mfgrn5WskQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:57:11 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:11 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:41 -0400 Subject: [PATCH v5 03/13] media: nxp: imx8-isi: Remove unused offset in mxc_isi_reg and use BIT() macro for mask Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-3-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=3023; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=eZpdbImXpboiQbV4dgRf9tPUfet/08V2CU0FiUVwLfY=; b=osFbEv3Yqu4jULu0AckRngosvlmAUohS5fOr/exZSJJA9f69z9Avo1Zj+13l3L/Py8gM639mO qeOtrO8tZyRAwGoTkiFpk2hY8XzJojkPA5LJlPExJZ6VaIKt0nfEKzf X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: 41d55c2d-d717-49cb-faee-08dd995a1390 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R1JaMVVhSmVoTGc3YW9MdmRRL1JhNkFSQ1kvVDgvd1Z4YUt4UkhuUEo5dExS?= =?utf-8?B?YWtWd0tWQUdUcUZUaGtBUEJSVXNHa3BlQWFWOC9rSTI1Vy8wdWxXY1cxOEdO?= =?utf-8?B?VjZaK29oT2JVT3NpcURJSXN4YlhLd1JhS3ZBdHlMZllFNjVqQzdieDFLOGtK?= =?utf-8?B?OENjd2JOWEpUY2xvZE1KWmFGQjJwZ004NGR4bElydjlZU2tVQTNvbm5TWnNz?= =?utf-8?B?MXhjc0ZNMEZuazZqdmt2WnE3bGZsWWVUS2EwZmVPci9CZFpJNC95dFIrbjJw?= =?utf-8?B?c24wYlJ3WjArNEVEQ3VIOENCYUp6V21GSG4yaHRUdSs5U0VRNnIvamRVUjVW?= =?utf-8?B?T1pialYvZUpZY2pwM3JBRDVGdjBWWEoxbmc2ak5tMUplendpaitWOGsxNmdK?= =?utf-8?B?dW15Qk82a25QSlBodFptREdWb3E0cGVtOTFlTjV1ZjQzaWZKSkx3aWJKbWpX?= =?utf-8?B?VHJRbzlDVk5JSytuV1lHN3M3d1ViUDhtREVBRnNsdGo4dXJxajJjblduUWtt?= =?utf-8?B?bHBKUzI0RHpzQ3NuOEFPVS9rY1lUNUJ2RlV2SDN6QTJwVkl6RGZQMWdRWEhT?= =?utf-8?B?RlJoNzh1Q0FTeGVwbkZuN0VYclEvU3VhbWphT2pWZVpRWldvTkpXMTdibTlE?= =?utf-8?B?aFkwZkp2WVJCY3p3ZElzbUhPQUtIdm1ac2N4OC9NaEcxVUlPUVJ2ekl2R3Jv?= =?utf-8?B?b2NPbUVVaDZsMnhBemRKK05VbzAxeEJnN1lRRkM3WXNxaVd2YU9aY2tkbHZK?= =?utf-8?B?YlQ4TU9MRk5ZcExDa3d0V3QxWnUzV09HS3JNcFdpY3EyeFJlcnI2UVZQd1p1?= =?utf-8?B?WXVkNFNWTDJ0MFpMemNjVlBMV0NiUnJBU3Q2VmN0VzdId01scWNHU3VESkNI?= =?utf-8?B?aFM4a045VUFsYkNmQlpPbFk1RzN3bWZ1UXRQLzdaZWNUZytVV3NHenNsR0Z5?= =?utf-8?B?RXNtKzRQakNXWk44TDYweWZyMEY1NWU2UGJvTFhjZnJhZURiMkFudGhYdWlK?= =?utf-8?B?cXdOUFRLZklXbTV1YVhpOGUxRGVaU2diYkVySGdiT1pYSFc4bGdqS1gwbXdi?= =?utf-8?B?Nm5xdXIyR0NucVZSMlhleEpzTW1zRWNqd1JFbmtIdmd1OXVhNkJLYThFM0VK?= =?utf-8?B?bFRtZFByMzRIdEVhbFM2c1BobXpuQzdpd2NrcFVXRlV5ZjdnVzRZM2VqdTRx?= =?utf-8?B?NG1NQTNEazRVSDltRTV1RXRMdGlFdytDd05JUmVTRWFWeHlTM2ladXlNbklw?= =?utf-8?B?eW5CVEtNc0Z6cHpsMUNXVHAycnVJZ05KMWpydjhVNmx6OU9tR0FZUERGZHVG?= =?utf-8?B?aVI0c1hmOTE4cFdNSXhJYXVnNWpGTzRFbVBXVEdqTng0RG1lU0lqR1dqUlQ1?= =?utf-8?B?R0p3ZFg0Umhqa01oczVzVW9GN3NieVhRU0dQMUV0ejRycGplZDlDLy85T0FS?= =?utf-8?B?WEt5Wjh0bXB0OU5MWTBKbGMrVWpIdnhGdWZod1hBTkNMSHBveEFDRFk0aGo5?= =?utf-8?B?eVBmSU5iRmNwT09jNlBOMlBvQWtFcHJLeGxuOFNuRUROSWdha0JlN3AxK0FU?= =?utf-8?B?d1hoa3J2SFFxMW1wRXRHSVZGZzhzakpqT2dlZkJmTUwrUGFpb1k4d0RGRkEv?= =?utf-8?B?RFlFTFZFYXd2NzBYTTcxOXkzckx0SmlycDA5eEpha2ZGM2Y5M0hNMG5lN1hr?= =?utf-8?B?cGtpU05TeU5LNkJTcWpvSzJvTGUyOVlKaGJFcUtkZzlmek15MlpBbjM2K1hW?= =?utf-8?B?d1U5ajM4N1V2NVZuSFpJamRKalBVQkpoMm53SmltM0gxeVFaRGJMbEFORjdF?= =?utf-8?B?VDc1NUt1WHNud3BFL0F5RUtwZmsxL1E2MVFVYXA1ZHVFK0ZIcWpwc0dEZ2Zu?= =?utf-8?B?RmpaNkkwaW1zbzhxSlBJQkh6ajAxUVdzK0NpWW9XcUpEUDNyQ25lRlRWQWFV?= =?utf-8?B?STJTYVRFaVhnbHVoWjJvYkRBRXFWelFTRXF5YUxvUVBCeEVrdlRlNlNNbU1N?= =?utf-8?Q?V4pnwCrCU8Ma9/43Q7iE0XV3L0cKbs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGVVN2RjSFpUeEwxZU9aQUY1VXkzRkdtaDNtODAzRTZneTJUeUhjdGlteEd3?= =?utf-8?B?MUhSOWpOZThsRWZ0amg1V0pJNXBPSHczam53bzBiSG02V3hIQWJkNTgvVytu?= =?utf-8?B?Sms3c09jb3MweDNpdkFSbDVDYzRIZ2JRTm5YN05lMkZHTWxXRHRRNFNxK3I4?= =?utf-8?B?UFJqRUxZT2t6OHh4RHl3M2VlYzB6WkFEL2luK3pUdTdONFg3Qlg0WjZrQWk3?= =?utf-8?B?alF0amE4Q05WT01waGgrc2cxUWxsemRsOVBYM2tmNjlUMmtnWitITlhwd0l5?= =?utf-8?B?NjJwcFZzMmxnNVFSRi9STFIzL0hGS0hRZXZCSkxMZlJkYVhhUCtaMS9FY3Z2?= =?utf-8?B?ZG1ObnZjYjBIR1JsNDBmQU5UM1hSOWVFc0ZjTUtPWWpPUHgrWUJtUFdVZDRZ?= =?utf-8?B?ejJoWkovRlhBYW5mMlVpblNvWHluYVZycWpmak9RWjV5dXQ4Y1RwRmV0aDk5?= =?utf-8?B?K0JPY3NmaFJsOU1lMlU0a2NKVWF6YU9kdmNRQjQwSnl6WGxQKzRJbjBxUDUx?= =?utf-8?B?UW9hcHhRblFra3lTUzVCOWwzVkpGVW5kblpYa3dFZ2QyMEFIK1hpZ3ZtQzJV?= =?utf-8?B?TlFyZE1VVjZ2bTROVHU4U1hUZFZZTGxXbDd0WHQ4UFVIQlZ2VkpWaGdBd1h0?= =?utf-8?B?eHIzUnVralc4SzFHQ1hUdTU5OG83VWtzcFF6N3pEbUM1ODFXeFhSQnIrVXRv?= =?utf-8?B?aVZSdHAwb0o2dDRGVEwxYlBrblplWVZjNFp3K3ZuRVFEYVpNaUtGUWh0cDZq?= =?utf-8?B?dUlSNGN3OGFpZEtQSVNpSlFDVmlhVmV2SnlDZmVFSWs4NHJCOUpEb0NGKy9G?= =?utf-8?B?cUVzaFFxUjRaMG9TSkVGY3VzeHkrbnpCd0JqR1RWMlVBN0hMQ2h2NzNGcEdL?= =?utf-8?B?ZUdBYU1rOWcrTldKMXdldHc1b1pQTTBRRFRFeTcxT05wSjJ5eWx6bk50Z0Uw?= =?utf-8?B?c0taelRmT3lnTTIxUXp4NlZOK1I4YXIrelNsSEdES29jUndGMTF0eURyOXJ2?= =?utf-8?B?UnFTcC9VakdkY3kyb2FpMEVoODMwTEJnd09GSXJxdTV0cFNCdGZnTHA5M2Y1?= =?utf-8?B?VFE3a1ZwaG9BUDk5RUwwb2gwL3NBSEpSbi9WaUV0RmREc3FUclFwSVdHWVRz?= =?utf-8?B?WkxyWEdYRXFtdlRBcDI4dUxWeHZJZ3V0cXZkZEFuRC9lSWVLV1VRaXhMVkVh?= =?utf-8?B?b3VEVUtWaDVlcmFCcUVmc3pYMWpZWVhxNk9MV1kwamJQUUp3N0RvSU9TUnNB?= =?utf-8?B?VUlzdFpYQXdyT2pqTnQ1NVFJMWptMnN5MjJCVUFGdnJyYzFuTGcvbVFEd0pM?= =?utf-8?B?MEN2bk5IVWNjZ3ZMeTB0WXBjcEgzNi8rWlJwTFJTeC9pa1VtUWswQnp1SlAw?= =?utf-8?B?eVZqZVM0MC8rZjQyeVpWODEyckk0RnQ1VVNWUjRCOWttZ2VCM3Vmc2xVU0xa?= =?utf-8?B?SzFjNG1kME5IZ0RoTnR1TkFJMHRWL2Zzd2NRcUJMSWtmd2pPcVpkUXZwS0FD?= =?utf-8?B?M1BUVzV6OHo1Ym12aW56RTV6cTVhV3dGZmJVU0FKL0JOYnp3RzZYVncxYkpl?= =?utf-8?B?NE9XdWVhVW5NZjNOeFJDVW5sSjdDenVpWlRER0lmWnRuQytiVHJ3ODhkNjJI?= =?utf-8?B?SFlzRTlYK1pmM0wxaCs4SEcwdjF5NmFEeFhtUis1RzVuUDBPY3puQlI1eXN2?= =?utf-8?B?UXlyNC9YRGJFejFvZkMrN0JiZFllNWhMbWNFTzgzeHU1TklCUjZPVGFGVTRE?= =?utf-8?B?Q1gvekRLMTROMVZTVzZva3dMbDRwYklKWW5GZk9jVWMvN2N6MWJFTFc4dHhz?= =?utf-8?B?N3BiekZaVXdzSGFZYmNBSVNiVThDVlp3N3ZNb2NOYTJIYWgwM0lJU08xMWNE?= =?utf-8?B?ZU04WWNaVmQ4Q2FiSGFxdE00TkJUVm1EczRVU2JLeDYvWWtwdUNvL1l3Zzcw?= =?utf-8?B?bUNZaEdua0g5elR3ajU4Ri9DZmlyckJZMyt0T1gzTEpLQzhhS3lYNVRWa3A0?= =?utf-8?B?akxOOU1zZGRMcDZwSzgzb3pqcksyN0pwRFRRcWhpSUN4TUVHcVlhU2xENVlZ?= =?utf-8?B?NXpwaXhPTkR3SHNlYk1iR3plMTQ1RDQ1b0YwZnpWM3h5TXRxaFZuamxmMXRD?= =?utf-8?Q?MD1lF8k9zDsWUWkBcbXHCVWZW?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41d55c2d-d717-49cb-faee-08dd995a1390 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:11.2598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IrmOfPOfgyVHWoYvOsu/4Vx0+P77U2zi6vrXghEGhbffVa8q6ZdYDUMZd5kif4qSYt9mIWoQpyOQVIZPrWlbfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 Preserve clarity by removing the unused 'offset' field in struct mxc_isi_re= g, as it duplicates information already indicated by the mask and remains unus= ed. Improve readability by replacing hex value masks with the BIT() macro. No functional change. Reviewed-by: Laurent Pinchart Signed-off-by: Frank Li --- change in v5 - add Laurent Pinchart review tag --- .../media/platform/nxp/imx8-isi/imx8-isi-core.c | 25 +++++++++++-------= ---- .../media/platform/nxp/imx8-isi/imx8-isi-core.h | 1 - 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 1e79b1211b603..ecfc95882f903 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -3,6 +3,7 @@ * Copyright 2019-2020 NXP */ =20 +#include #include #include #include @@ -247,24 +248,24 @@ static void mxc_isi_v4l2_cleanup(struct mxc_isi_dev *= isi) =20 /* For i.MX8QXP C0 and i.MX8MN ISI IER version */ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v1 =3D { - .oflw_y_buf_en =3D { .offset =3D 19, .mask =3D 0x80000 }, - .oflw_u_buf_en =3D { .offset =3D 21, .mask =3D 0x200000 }, - .oflw_v_buf_en =3D { .offset =3D 23, .mask =3D 0x800000 }, + .oflw_y_buf_en =3D { .mask =3D BIT(19) }, + .oflw_u_buf_en =3D { .mask =3D BIT(21) }, + .oflw_v_buf_en =3D { .mask =3D BIT(23) }, =20 - .panic_y_buf_en =3D {.offset =3D 20, .mask =3D 0x100000 }, - .panic_u_buf_en =3D {.offset =3D 22, .mask =3D 0x400000 }, - .panic_v_buf_en =3D {.offset =3D 24, .mask =3D 0x1000000 }, + .panic_y_buf_en =3D { .mask =3D BIT(20) }, + .panic_u_buf_en =3D { .mask =3D BIT(22) }, + .panic_v_buf_en =3D { .mask =3D BIT(24) }, }; =20 /* For i.MX8MP ISI IER version */ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v2 =3D { - .oflw_y_buf_en =3D { .offset =3D 18, .mask =3D 0x40000 }, - .oflw_u_buf_en =3D { .offset =3D 20, .mask =3D 0x100000 }, - .oflw_v_buf_en =3D { .offset =3D 22, .mask =3D 0x400000 }, + .oflw_y_buf_en =3D { .mask =3D BIT(18) }, + .oflw_u_buf_en =3D { .mask =3D BIT(20) }, + .oflw_v_buf_en =3D { .mask =3D BIT(22) }, =20 - .panic_y_buf_en =3D {.offset =3D 19, .mask =3D 0x80000 }, - .panic_u_buf_en =3D {.offset =3D 21, .mask =3D 0x200000 }, - .panic_v_buf_en =3D {.offset =3D 23, .mask =3D 0x800000 }, + .panic_y_buf_en =3D { .mask =3D BIT(19) }, + .panic_u_buf_en =3D { .mask =3D BIT(21) }, + .panic_v_buf_en =3D { .mask =3D BIT(23) }, }; =20 /* Panic will assert when the buffers are 50% full */ diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.h index 9c7fe9e5f941f..e7534a80af7b4 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h @@ -114,7 +114,6 @@ struct mxc_isi_buffer { }; =20 struct mxc_isi_reg { - u32 offset; u32 mask; }; =20 --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2063.outbound.protection.outlook.com [40.107.21.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 113241A239A; Thu, 22 May 2025 17:57:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936641; cv=fail; b=pyHSSZSCuZ4Aan6A2wu8a4W8LcvDwzT4SS03wFCGwsiGBkfEgLmdo0f0nhdXb9hX2oAG8+liDAT0tA3SbYSnt0812ELVGCPxeB/VP3ZH3zRpR27lCgB9D0BMm5L1wZxbgf8NEgDMvZgnXlXcKe6NnZMmsfP26lzlDLVnGdF+lgs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936641; c=relaxed/simple; bh=fqwXtCqUEC5fQ1kuDzhvENyE4RRLXfgHO0RIN9hrMBk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=I8l7iHaccUQRGhMc+aBAENgb8krc47KqcOy9p8smORFqIJZxXIzVxoX1ZikCO+E7OAZiLuJxNnvdm8CPqAayulNkYQzDsqnBlcytJv+LR5L1yeZLr0/8hNfvtoDPRtMA2awyZnsXi/f3NEFgSBOp/RmGJYCBqVLOhKd2izd4jr4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=OV3+VNoQ; arc=fail smtp.client-ip=40.107.21.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="OV3+VNoQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZuatY2+FZ42flr/MziXMlE1y662csWRqW+TpwuAq5BNqiIJ2xFx1DBb6vJQmp5WffKsrs83ZU9qxWmvL8EjCrIFt6QzmyOE00kUHL0AwO5CRDLk/u/NayNzIh2ggZyTvRUVfKpOJIa1Kj0CQiNiwxd8WRf/26KwSr4q1Sf44UB5KXwTjvYqNzzYSFOqa/+ZelF5XmINMufgDW6Dx8lSBuEQ9keNVmyKZO2sDVBm5/Uj+uOF5sqFklM0PGFrdxDmpxJAsr/QAQri0OukdaUSABQr3wvRQcC3OzXhKCE+wK+86/DqvdzTszhjVYV9RnQB8CH/hSW6dyjzgy8x7C0Wz7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GLCIfAQkZuA4HrGCxjFPi+uIvxtJ7dh4K2YNX0pskQk=; b=FoZYZIEsCqFcMd6EIdhd/+DCGfRekqfU2EcDy5uhjx4bKrnMLpiHlnYUHhVsXXfCcGqjSVmis1d59WIfGV64ZcDoa3qK5xtG6T5KO9+qfQVyCQ+6fWhFmhRjw3b/G3UlIyeoOEOigiWT2II3poh9zxV+thYZhplcVuE/+MEwyx6ZIxEwGU0AEtc1VkACPXJWBeyqZgODH6xIQSgSpN7JJOpKHq5nFdn1Bnzk0OyU81UOCRQ9pekCnWyfhEQLt3+wFODepWKvIGulXt3eaNI4NSCEdup2YkbAxXf6sLCGepErrTxQQjrJJOOktZmJRyo0HUkXDIOaZ5Zs3unzXLdgQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLCIfAQkZuA4HrGCxjFPi+uIvxtJ7dh4K2YNX0pskQk=; b=OV3+VNoQEquK+XCV/yXzg0mLUBo+EgauqRTlRuMH5loLhXBazdZWDy0eb90b4MYbXbaxzcTi1YkPzxJkaqc5U3HiRu5S/+7cMvxJrR+XIcvGUwY225zHlwnfo6XeXPeBp9tEXotbf6Q28JDaBTxZZAxnp1AcT6IZLkUzcVjCvm4TUzULoXvCTHO4WsZA5KcPwxz9+H7GCsFeHQ4tY67TYv7cnDjgLe6atSpHfCirKL/95vyWCAdudKi6J0MJwIONk64ftjakluKPExowK0Urtyrb27CaB2i5URPK4nLq9BYOrlsWzpxA1XYqFcSaewpxGJff6HzmdyvvnS92MLy5VQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:57:16 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:16 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:42 -0400 Subject: [PATCH v5 04/13] media: nxp: imx8-isi: Use devm_clk_bulk_get_all() to fetch clocks Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-4-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=4969; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=fqwXtCqUEC5fQ1kuDzhvENyE4RRLXfgHO0RIN9hrMBk=; b=nSZOiELzIVkLl9fyGCrV7RI0iLuEoLuCK/tYx+T5PtwkltfsOz2Oz4wQoQ4PWdeSODhUbfUQX 8uXy/ncsVdaBqwUqv4ofkT77SqVlN7IEwG8PREhAU069BTNrRdWeDPc X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: 897808e3-5065-4e3c-ee83-08dd995a168b X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?L2JPalZnVlpZWWJkVWN0Vk5nandQdUpoUTZ0QkxPcUY0SXJTWWxYaExVWE0r?= =?utf-8?B?UEFpdVZBUkQ1VjBCdm02Z0RoOFhRbDhYTEM2UU1rNE9GcVd2RGd0eXFDWGdH?= =?utf-8?B?Wk1taHdDVFVPQmxUc0x6VlIrSjJaR0lvWGFVU2dVOHhxTzhMQ2ZhS3BTa3hO?= =?utf-8?B?bEFOYVVOeEttMWk4L1FHRzBaVjJqM0kwTzBnN20yTm5scGQ0YWg0dXFxS0g3?= =?utf-8?B?QjIvcmlFVGV5NFM0ZEZoSHVJM3ArdWxiUzIybjlTekd4UTN5ODFDMHFYR3hF?= =?utf-8?B?YW5zaTU4cGxCVlM1MkZqSWo4d3lCdHN3UUNYSjU4ZUxrcHY0bkpFRDR5VjQ2?= =?utf-8?B?T3I2U3pDUkFHRCtTOS85a2tzVFJlMWlJM2dVby9uVysrWTFKTUs1STdSK3po?= =?utf-8?B?aVhvdW9uYllGbk81aDlFQVJrUmNzeU1hZ3l6NXoxRDkrZDZjSFp2ZzFIR0Fz?= =?utf-8?B?YmdaRmRlNjlpTHk4Uys3ZmZiRXEwcGRYOGxKYXdmSTJLOFFhMXNBUnlzMXVM?= =?utf-8?B?ZFpZd2N5ZVhXYko4ckRqS3NqWXVTa29oaGswMThpbjBkSUZ1Y2txZmtBem5K?= =?utf-8?B?d3EzZ3hhL1VIQnJRMGpuYWNyaEdhYUJQUGVqYTZJcWd0NXBncFQrUXIyaXVL?= =?utf-8?B?dlFSc0lxU0U3MjREdXE4aEsySzA3Uml2cTdEYUhxZEtNRWl2U2tXZ0t4b0xX?= =?utf-8?B?bzc3VVNZdHdXTkF6Unh2QWpiZjRNUjJ5ZlFlRTk1eE54bU4rTVFmV0lDS3oy?= =?utf-8?B?ODRCc0lhTHUvNXZGV0NSbmF3MFl5cTJveXFvVFdDTGtIMnBTZU9RUWpHQTFo?= =?utf-8?B?WXpsNXhYUUQveUE1a054Wm83K1hua3VDUTNla2J0dTloVnhObE9WektoSXZO?= =?utf-8?B?Z3lmK29na3lPZGQ2UGFvMm94RW9Md2dTQ3p4M29nVEw2K0FWd1RMeDJYV2hs?= =?utf-8?B?WWJFdk40NHlrR2c0QlFVWnYyckNBSUdaTHlVRERJdjRrcU9STmFKcko1NHdo?= =?utf-8?B?WUFNZGFZZStqTk1QWmZiYmQxV1g5ZkxySlBFeDVnSXN0Z25aZUNoMHFLQVhr?= =?utf-8?B?VGNOVmNERHVuanhIcGVaTnRaOFIvK3NONEI2eVBOYjRKMmVUZUcwV2tpT3kr?= =?utf-8?B?UFVxQ0JrSCt1dHdhL2haZnZMV28relZ0NmxuZXZhbTVYV1lqZUZVcENHSWVK?= =?utf-8?B?Q2lHYytyOThtb0JDODczZU9nSm94a0F4Y2UwVmFnL2dYUEF4K1RoUDRpRFky?= =?utf-8?B?dVNYL3B2bFFDTlUxNExIU0g0b1FDM3dvWE5IU3lnUzduZlJIWU10UkRIOXpp?= =?utf-8?B?WVpUd2JUYmFvcmxNVy91Y1dxSTdWbnpVY3h5YWROWDZkWWFFSjlINlBxcUJu?= =?utf-8?B?SkpGa0VZWjhQckRtVGUzWjRxRHFwaFQ5b3FUMWJGN1lMVWZ5OTJZVFIyR3Ns?= =?utf-8?B?UTE2RU5jRml4QTZaSGtMY1dZT3Bna1JvQlVIUFhEM3N2NExIS05kb3h4VGhu?= =?utf-8?B?d3ZkZXRnall3aE9jV0g5OEhOdGZWbTBZaGIyZWVuRlljazhzNjBtYnAxbFVx?= =?utf-8?B?enpDUE9pN0FaUlQvRldsWkYxT2JkOWhQWEVtaU1BUVVkVFhZVXV5NWpVMW1K?= =?utf-8?B?UXZMM1RGWjBISEFGQk84eFd0L1N0NDE5WmVrRngwZ3Z3OWtONFB1bEJEVTM0?= =?utf-8?B?RTN0amdRRmVYeHczKzljTWtINHl1ekh2QjV5bEpTeXJPWXd6MW83UXJEMTRM?= =?utf-8?B?Nk5JdFVGa3hvWWp4ZnczRWJJdy9XTmYycE9qUFdSZWhnMnM1NHozM3o1UjhW?= =?utf-8?B?SlVHWVA1YkU0SmhWT1BMSGppWGgrNGUyRldWLy90dURseUFkMVp5L0kxZXFU?= =?utf-8?B?aUlUclhydXRHdDVYS2NVNkh1cGdNT1R2NlRES2M1WXdKRFk2OHJSQlVvOWhS?= =?utf-8?B?RGpBd1IxcVNDOGhUdU1nS0RmWXIrVGRwUGZsQ0NIekx2SnVsVFVHTURJR0lV?= =?utf-8?Q?YUXItivkSESchvEz0uMXJ+Airzsu6E=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXFNM3ZscWphYzl2ZXVJejZnNUZMRGV0TG1VNFErYU9pNXcvc1FIMVhIc1Y2?= =?utf-8?B?L0FWaHh3dmtuVW9jRWVFUFlBQ1dvRVpCSVRpbXh2Q3NRZ3ppMmRacTJFSkZh?= =?utf-8?B?WE1QMVlMTVlsZHdSV3hKU2t5VkNMSXdUUTZ1MkJZcWhtQVJoKzA1eHJyTWx5?= =?utf-8?B?SzRHQmd0T2F3NGI5WmZwQVlqWXIvRlRaemoyYVYveVRCczBQWngvZjZhQ0k5?= =?utf-8?B?dUpnRnZ4TWs3Z245b3NzUGJZNm9TMlRRK205aU51R3EvUnhvMGg4bkFaNVVQ?= =?utf-8?B?RC9DSlcveldERi9aMFZ0ZVovQWE5Vm04RVdDQ21yYWRtSm52Z3h5N2JBVEo3?= =?utf-8?B?VFcvbmlEbW5RK1dBVnMvMGpsbXVvUjlKdmxpTXJQVDI2aHY1dzhULythejBi?= =?utf-8?B?K3hqSU1keWpSV08rTzV4ZmxpM1k2YXRSRW5INk4xRmFTeGVRZS9TTThCRkdN?= =?utf-8?B?WEk0bDNVUWtJaFlqdkZWVkZMU3hWRXlUUklhRHJ0d2ZUUWpBWE1SUE1nYjRC?= =?utf-8?B?c3ZGNmRONG1WejgrdW1UZG9wQzNEWGZCSFFGdndTdXIvOCs1Uzd3VTNoSnJ1?= =?utf-8?B?NzZNMmRwVW9FdE1pN0M5S2V3bllqbnpXR3VJUTdWbExtYUdYQ2RyOTBlNHBr?= =?utf-8?B?UHNhemFIQUpTT3B3cGZNNGk0WVF4YThSQVpLV3NxOEg4KzRvNDIwajQyRkxK?= =?utf-8?B?ZUZYY0hNQ0Q1bUZiaXBJQ3M4UU1YR1d0d29JWnNZK1VaODh5bGxXK2VqNEFM?= =?utf-8?B?KzNXckJCS2xDOWx2K2RPYm9WdHowYkxldzdlS05EYTJ3aWZ2QjF4WnJ3Zy83?= =?utf-8?B?d3llTnFrYURBQ2g5N3FDMHd1VWJUSkgwdGlnLzZ0bWZXM0wrR3dxRG53RVVL?= =?utf-8?B?S2lFaHM0UmhRZDR4aFJuVExESVNqbExIak9sR3lMSDQ5ZngwSlZqQ0NRdnUw?= =?utf-8?B?OVdmUVdZMlFtSE83a3U5OERJVGhVRTlnZTlqL0gxVS9RTnR1NkRtKzkwbjF5?= =?utf-8?B?ZW1jRUtIM2xrOTJWUWxxT3lmeUdQR1Rjc0RnRjhsRjdMU3dpNnN1VHNGVlBu?= =?utf-8?B?U2NTMDJFTFF0N3Ird3JLL0c1VDlSdmtsM3lLUGI4TndlV0VtUlluemk4ejR4?= =?utf-8?B?SmF2OWRxS3dVZ3JaTGcvKzVvZmh0TWNhd3E3OGxrV3duNWxQTklmMWdvRHY4?= =?utf-8?B?MGFLWHFULzI3NkNnTTd5ZVBkUEs1UkI4UFVWL2J3VktINk1rTlNSdEFLNWJa?= =?utf-8?B?TUtvNWJ3MElHMnhpQmJxcFRJdzkvVk1SaXY0UGlJODAxOSs3T0RmdEpYMGN5?= =?utf-8?B?UjQwZldHVVNMRFJWMkg5OWt4ay9IRk1CRForczhWTk41aTdMUHdLMVNrK0tX?= =?utf-8?B?T29md1lsa0RrR2ZvZDNiODNmQWIrVElJUE82RVl3M2IvdUt5MVRtNHVsZWRG?= =?utf-8?B?eXVsaTQzWUxqcTlvVkg0KzkrRkMrQzRWNE9BeVpoVmlzMWt1alR3TE9xdnN6?= =?utf-8?B?VXBIMjZUOW0yUTBXeDNSVWNxbW5nampZU3dtT250Qkt2U1F2Qyt2RDZoRnVu?= =?utf-8?B?TUZtZ1NKbHJtMGNFbGRGR1J1REVQRVM4b3FwSUhNdjhFUUtBdWpYSktobVQx?= =?utf-8?B?QlBPUU5iUGRiaWxMNUFDT3dBQThYOTFsd21CcGZ3Tm5kL0c5K2hoWk5VR1VB?= =?utf-8?B?Y3NHczBNU3ptM2FxcnE4WmtLNncyOXFWbmRnMEg4VWVtUzlpYkV6QUhUelhD?= =?utf-8?B?TU4zVlg1ZzVmVEFxTmFZSnJhVmtpODloM3FlKzc3R3dTYXl6Mkl3NFUyeUxK?= =?utf-8?B?a25VZ0xZd0YrSHpYNzNEazNxY3RPeUJYUk5DdnZhNFZ6STRiWncwaEZxWk16?= =?utf-8?B?emxtYXpvWVZiUDZ6V08xMVBUSVZHUUVza1Y0QksvZ016bGtiSkplWDJXTVlT?= =?utf-8?B?OU1rcmcvRjZwdVRuWWVVYWt6YzVmSjFFd1FFaUZhaXVoY2tyUGNEN01ySEU1?= =?utf-8?B?TC9uaWdFWHZ4S2h1RFU3cHBJUXJkMFZIL0NIaXFQY3BpbFNUblp2Ukozd0c3?= =?utf-8?B?K1ppRVhkcmN0OWp2VmdUaStkbUZxN0c1QUlpKzYwaHhXNm5IUWI2bEZWWFBP?= =?utf-8?Q?uAh6OPfJxIi5o9DD52R9qCD0I?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 897808e3-5065-4e3c-ee83-08dd995a168b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:16.2682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VRTivAfiFJCg7WlgixYeVxXP3nCA142gm+bkOvo5XeDcEXC+kw00R3N5ZAGDcE0e8nHLnJVpRrdTPTFcR4J3Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 Use devm_clk_bulk_get_all() helper to simplify clock handle code. No functional changes intended. Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart --- change in v5 - none --- .../media/platform/nxp/imx8-isi/imx8-isi-core.c | 46 +++---------------= ---- .../media/platform/nxp/imx8-isi/imx8-isi-core.h | 3 +- 2 files changed, 6 insertions(+), 43 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index ecfc95882f903..015350c6f2784 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -275,11 +275,6 @@ static const struct mxc_isi_set_thd mxc_imx8_isi_thd_v= 1 =3D { .panic_set_thd_v =3D { .mask =3D 0xf0000, .offset =3D 16, .threshold =3D = 0x7 }, }; =20 -static const struct clk_bulk_data mxc_imx8mn_clks[] =3D { - { .id =3D "axi" }, - { .id =3D "apb" }, -}; - static const struct mxc_isi_plat_data mxc_imx8mn_data =3D { .model =3D MXC_ISI_IMX8MN, .num_ports =3D 1, @@ -287,8 +282,6 @@ static const struct mxc_isi_plat_data mxc_imx8mn_data = =3D { .reg_offset =3D 0, .ier_reg =3D &mxc_imx8_isi_ier_v1, .set_thd =3D &mxc_imx8_isi_thd_v1, - .clks =3D mxc_imx8mn_clks, - .num_clks =3D ARRAY_SIZE(mxc_imx8mn_clks), .buf_active_reverse =3D false, .gasket_ops =3D &mxc_imx8_gasket_ops, .has_36bit_dma =3D false, @@ -301,8 +294,6 @@ static const struct mxc_isi_plat_data mxc_imx8mp_data = =3D { .reg_offset =3D 0x2000, .ier_reg =3D &mxc_imx8_isi_ier_v2, .set_thd =3D &mxc_imx8_isi_thd_v1, - .clks =3D mxc_imx8mn_clks, - .num_clks =3D ARRAY_SIZE(mxc_imx8mn_clks), .buf_active_reverse =3D true, .gasket_ops =3D &mxc_imx8_gasket_ops, .has_36bit_dma =3D true, @@ -315,8 +306,6 @@ static const struct mxc_isi_plat_data mxc_imx8ulp_data = =3D { .reg_offset =3D 0x0, .ier_reg =3D &mxc_imx8_isi_ier_v2, .set_thd =3D &mxc_imx8_isi_thd_v1, - .clks =3D mxc_imx8mn_clks, - .num_clks =3D ARRAY_SIZE(mxc_imx8mn_clks), .buf_active_reverse =3D true, .has_36bit_dma =3D false, }; @@ -328,8 +317,6 @@ static const struct mxc_isi_plat_data mxc_imx93_data = =3D { .reg_offset =3D 0, .ier_reg =3D &mxc_imx8_isi_ier_v2, .set_thd =3D &mxc_imx8_isi_thd_v1, - .clks =3D mxc_imx8mn_clks, - .num_clks =3D ARRAY_SIZE(mxc_imx8mn_clks), .buf_active_reverse =3D true, .gasket_ops =3D &mxc_imx93_gasket_ops, .has_36bit_dma =3D false, @@ -386,7 +373,7 @@ static int mxc_isi_runtime_suspend(struct device *dev) { struct mxc_isi_dev *isi =3D dev_get_drvdata(dev); =20 - clk_bulk_disable_unprepare(isi->pdata->num_clks, isi->clks); + clk_bulk_disable_unprepare(isi->num_clks, isi->clks); =20 return 0; } @@ -396,7 +383,7 @@ static int mxc_isi_runtime_resume(struct device *dev) struct mxc_isi_dev *isi =3D dev_get_drvdata(dev); int ret; =20 - ret =3D clk_bulk_prepare_enable(isi->pdata->num_clks, isi->clks); + ret =3D clk_bulk_prepare_enable(isi->num_clks, isi->clks); if (ret) { dev_err(dev, "Failed to enable clocks (%d)\n", ret); return ret; @@ -414,27 +401,6 @@ static const struct dev_pm_ops mxc_isi_pm_ops =3D { * Probe, remove & driver */ =20 -static int mxc_isi_clk_get(struct mxc_isi_dev *isi) -{ - unsigned int size =3D isi->pdata->num_clks - * sizeof(*isi->clks); - int ret; - - isi->clks =3D devm_kmemdup(isi->dev, isi->pdata->clks, size, GFP_KERNEL); - if (!isi->clks) - return -ENOMEM; - - ret =3D devm_clk_bulk_get(isi->dev, isi->pdata->num_clks, - isi->clks); - if (ret < 0) { - dev_err(isi->dev, "Failed to acquire clocks: %d\n", - ret); - return ret; - } - - return 0; -} - static int mxc_isi_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -457,11 +423,9 @@ static int mxc_isi_probe(struct platform_device *pdev) if (!isi->pipes) return -ENOMEM; =20 - ret =3D mxc_isi_clk_get(isi); - if (ret < 0) { - dev_err(dev, "Failed to get clocks\n"); - return ret; - } + isi->num_clks =3D devm_clk_bulk_get_all(dev, &isi->clks); + if (isi->num_clks < 0) + return dev_err_probe(dev, isi->num_clks, "Failed to get clocks\n"); =20 isi->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(isi->regs)) { diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.h index e7534a80af7b4..bd3cfe5fbe063 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h @@ -169,8 +169,6 @@ struct mxc_isi_plat_data { const struct mxc_isi_ier_reg *ier_reg; const struct mxc_isi_set_thd *set_thd; const struct mxc_gasket_ops *gasket_ops; - const struct clk_bulk_data *clks; - unsigned int num_clks; bool buf_active_reverse; bool has_36bit_dma; }; @@ -282,6 +280,7 @@ struct mxc_isi_dev { =20 void __iomem *regs; struct clk_bulk_data *clks; + int num_clks; struct regmap *gasket; =20 struct mxc_isi_crossbar crossbar; --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2081.outbound.protection.outlook.com [40.107.22.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E18D829A30F; Thu, 22 May 2025 17:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.81 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936645; cv=fail; b=q3yWSBDuTpO97cVPcEdhbuvFRmuMF5xTwQxfx05Iqst1Y18zVwj/SGeUul1R9wbw4ADC2XcyZ2HXxS2aSgZvaAhJh2RHj/IVcmQf8pPWZa16x5FxuLQ3CmUqLPid8Bugm7r2yTR5ZSl3M/f+/kGdAmih6RsSJzUywgKgTejPiso= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936645; c=relaxed/simple; bh=M5XM/YHCs7hQ+Ff6rR8b1y1zx8a6MAOiBT19ob+jZsU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=rJ8dY48Bm0dS0CdsIznW4ZcbmoktdIhMROVlOhwtYGDgwUO/KO94FxSwBtDr+bnB3rbnHvv3PLCzg2Za5JdzdDKu9frRXI4NgSf/aAyy679M4pRNHP22hfyKkFjNutg/YPNLw6GtT1d6sQyrl1RfARC9B42ipxqnOsxgg1alxJk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=YX3C4BfX; arc=fail smtp.client-ip=40.107.22.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="YX3C4BfX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HP6lf9VlQKThKqqjWTruX8Sbt3TG/1M+w8bGaA7uGshTFcOJxUpH0bzlzrwkORk63Nnq2ahdZeVbRJ4c4cP0ZpqV37+vDuDNRnqFYtd5d/cU6vRmYCF+etrzDIykHa4YCjDClAr+3twN45h/7QIeah7HVuTStjal1QexULTofwNPxN5rJtKonD/LhhMnr6DHb51LSF266KUa97WrtLdukHCnQaqDB92HZlX16fvwyi616ZxM7TYQEjc7s4W6gr5ev+6j7z9d/N3gMo+G7sb8mrkwcy7ZWUyYK9uRs0ctmBCjHKPiXDrkkHq94XZEGXIq5V93wVYsXJJkexRGhM6jnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tteai056XbV3OzPy+Rkggw645QzOE1nRe+uiqFWXFXs=; b=wUhq1uqTDh5fswCZqa7bgQpWHALsdKbWpMarqG65Tn6A+dymzHeMkcDLp4PK+KIxUKM5EZ/dDnkeO1TIb1TrI63boCU0n2BsPCOcP2No1rIJ7A9w2wBY54ooMV0tP5/H/IoIIRSDRJsJVrp28FO/hMEc2B5D072Lrulo3tTDsySESz5eqxnr0iDr3UKJ7eS1zVtT04MjtdGAflmCbokBWvSGGTY9ZIWjJ8C8d3wIHszHMV3MdQis6GuWhHmHacevA4zaxA0zT4SY6BNoynYvii2alRhvYSMM4t1rY1ROZuK7Q+fZajiGsK4Mt/Y0UPURAY5H8JL9zrVKeNkPqrOD4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tteai056XbV3OzPy+Rkggw645QzOE1nRe+uiqFWXFXs=; b=YX3C4BfXmimpTJ84XLtlZVVfugqp7Ba+MbRBvdxWG6AfGvaglbiwe5fVUkvLgLpzCA0PSioH9XrO+o3O5I1EVPkjgaqGsfb99FMEA0y2TiDRq0Zi/ZOW0+12c+4piEmX4m31oZzYK31uUVCZD8tvdvG+8M94++sQa1U55M5xL7uSQOR2LmQ7r+O8vYLDI64b1t54GnViv+rxZB0SlIIrRwiz/VD+bxACaz3Y4RRAKTAfdkpXINOtyutKzqysrnqQ8LEs8keVYczJ09pOd+EK0cxGQV21+OGLeP7APeRA72DvY/q//2Itq79Kj0axmgss/MSqVxbHq34f/3BOISMHnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:57:21 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:21 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:43 -0400 Subject: [PATCH v5 05/13] media: nxp: imx8-isi: Remove redundant check for dma_set_mask_and_coherent() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-5-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=1180; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=M5XM/YHCs7hQ+Ff6rR8b1y1zx8a6MAOiBT19ob+jZsU=; b=eOSlXelkWJ7Rl2WkawOeB4KGNgp8cIzuGbElATqCfdC7Upp3Qn5E11z+AsqNiNDTR6JS++CY1 UOkk4q0sTz0DoIIysRGd/zMiFWXmERjFyE0t7WoLRYJfj4vqInk3Byh X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: 176b9144-9d36-4af8-0c2e-08dd995a1982 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U04ydU1HY1JNdjlFM1I2VlpGVldFaDlzM3dxNkNEYWRBd1RzZ2loNXI4eG1H?= =?utf-8?B?UXZqZ3VEdDRIT0N6bzVySURUTUx5eWI3TWR2ZHl1RE5IUWZKalZWb2I2SEF4?= =?utf-8?B?dmIya21KbVpncThQdVBvclVNM3JzVUticWlLUWcwZmpXdDkrQTE3TmVzL0Ev?= =?utf-8?B?OGdwMHNJMW43R2ZjNDIybzdjY2NqOVVsVklUN1BJN3RobEFid1pxcDc1NDU2?= =?utf-8?B?czBLU1RRTENlQUErb1JGbnFsY3ZuYytBb0FBUVJFTlVHMExDVWdOUit5YVA3?= =?utf-8?B?aUxaeTgvQlRKOTV0N0tVSExHUXhNL25UNWJQcXZKdE5ZTDhDUjVVYXE1elA3?= =?utf-8?B?NFpvMlZUSU53dlZsTVlzS1VLQTJid045ZXNhNWlmVnk2RVZxWVBZaHlETlUw?= =?utf-8?B?SUxzamRSbXlBNGZtZncvZVB4My94SjhKeitSbVU1M1R1amdiWHprTzY3MnpC?= =?utf-8?B?L1k2dVlzZm9hL2V1SXJNTXd6S21RY1k3VS8zWnpOSXp1OEp3UERtalJVdWZG?= =?utf-8?B?bUZ1NlJVRWFBTHRMNzZIK1pib0o5Zk42ZE1XdkVWS0VOaGk1TXUvNGd5dGw5?= =?utf-8?B?TU9ZUWh6d3p4THJwMkI3UDE4bUJwWnMzZndJZlJEbFRaajRhUmdKamg2eUJN?= =?utf-8?B?NThXRnU1ZDFRTXlUVkYrR1NweXo4TVZvQlpva1VIblRNRStqMHUxdkxGV1Vy?= =?utf-8?B?dVBWd2RHVjVRanpCRytzMURtaStDUmYvSSs0eGR1SG10REl6Wjh4VDdvR2sw?= =?utf-8?B?elpiMDJYdGVuc0NvNC83QVpaMmh3b0ZkYzZ5OVEwZllRN21DVUF4ZVpxV1Fn?= =?utf-8?B?aFA3WnZ5NlFQYVloQTk5RXBReTdERFlhdnZBdjBxQkFwT0QxMnZQTWRpU1FL?= =?utf-8?B?SWQzTEJWQ3pPTWoyNWYyNVAwTEZiY3ZVdXB2WG5wRGszWHlpNVFnOVdsWUl1?= =?utf-8?B?M0hqMk80aDZ4b3BuS2t5T3NTSk0vQ0tEaDZSak1rb3MvS2JoSnpWQStDRU9H?= =?utf-8?B?OVdqRWZ3N2VCYVpHck9wY0pkVXMrY2s0L0VHWEZNRm56UWtwSU5vV2xyN3Iw?= =?utf-8?B?V05Fdmc3cERNZi85SU8vL21obkpsaDN6VFpWZGJjQW9IdDBqd21uNWtHcUlX?= =?utf-8?B?TFJFV0xKeExmeXRBMFA1czZVUFFRRGxORk5menBXZ1RnR0FsY2RkZzUya2xU?= =?utf-8?B?cS9TbTZoNzNvQlpYbCtEZ3ZsQlZXd0h4NVppSldYUHM4dWc3V2VYV0dSU1Vx?= =?utf-8?B?SUpQcXZ0R08vK09EdkNkUkpaVWF0aFE4czFOenVzaFBIN2hHTkl0ODdTbUVX?= =?utf-8?B?RXhTTUhXNEtXSDNoY3o0K3c5bVByTG01NUdyZCs4ZDN2cWU3TTltaWxNVzFx?= =?utf-8?B?QkVCT3J3Y2Z2Y01SVEY5T0tYRWh6NFNTQ2x4UEx1NC93eHZ5VWEreVVTeGFt?= =?utf-8?B?dUhwbFRUUWNWSG0rR25pc2RwNms2NjlLVy9Fd0I2VUwweUNJQ0lxaFBKMDNt?= =?utf-8?B?YzRra2xRQURSYTVPM3plR1JaRUJKVlVydzJnazdGUVJEcC95dHVhK1IrTUFM?= =?utf-8?B?b28wak53cjJsamp3VFQ5Y3lZdWNOU0RqK2R4TWJheXRlMTB3V1VkNW5IUVZJ?= =?utf-8?B?SzIybkYzSHBjeWVTYUF4MDJ1VXBzejBEOGJldjlOWEp4N2kvYVRoWnBibUNx?= =?utf-8?B?RGVCZzFORUFsb1RHeUxoeHh4VW1zZTc1MU5TRENVUmZCT2owYlBUOEJPQ29j?= =?utf-8?B?c3BkRkd6YXB5cGQvdWJmNVhCRytNd1hQM1RLS1lSbnJ3V1Y2R2hPVUwyek1Q?= =?utf-8?B?Tm1wRUNpWVpjeGRPQ1gvcGpyY0FQWDE4bGhVeXJUWWpEK3JyYlprTjNwQm85?= =?utf-8?B?YWpDUFFsS2htZkpvK2VtQ3VzeG9odXhyM3IrRzlrK0J0VUZyZ2FFUDFUVWY1?= =?utf-8?B?cjlRRXQvSEQ2akg0b2pIRVVjU3p3V1hWczErbStqblFLRHBJUE1LZXFoMldu?= =?utf-8?Q?Fs6oUEV2aDmgOuKjdst5kEgD6gzCtI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elVPYnppMGlKTklqN0RwKzdnQ3VXN3c4eDlzZXFBVFBwM3FQSmhuR25kdTZN?= =?utf-8?B?K0g4K1Iyb0NiTFhvK3RjVXlyVEE2UzVlNGRvNmNsZ1JUalovYXJXa216Vkwx?= =?utf-8?B?OEMwVW8xbmpvRDRIQ0FZNk10TnJRN1psNlhJMmFzcTJGYTBXUmsvSDdzcmox?= =?utf-8?B?enU1bUV3ME50dHdIclZQU1plUkluNUhpQm8zOXJENWFrVWpIY1lTSFFYajI3?= =?utf-8?B?bHhvRDJBUXoyWi8ydVpNZkgyR1BVeEhDYzk2aEpLQUNiUnBoY2t5cW1QYXJn?= =?utf-8?B?WCtUKzlGSWdHd3FkYk92VDB4ZVFyTmVtTHNMUThWMlJpZFA4TkVHRk92cmdO?= =?utf-8?B?U2U1L1FrZVNUdlBFeERXRkpDV0EzRGc1NGdycnNIMmsxSk1FRTdXaFpOUkFy?= =?utf-8?B?QzYxREhBZGl5N2s0ZWVZdWhtSG1QMTNTTWpjbUtBOEhPVFQ1dFVTSTRDQnRZ?= =?utf-8?B?U3hOamwvcFErY2tCUWgzMkJhcTJZUWdweElaZGhBUG9zSGJHTmZRN2NtVlQ1?= =?utf-8?B?QitDbEhCMHd1emFRUUFPNFc0UDlCN0xsSHk0RUZiK3U3NWtkZ2hjcmplZlBZ?= =?utf-8?B?ajR1ZkREa1NFSkZKRVowNVo0MFZXN044cEtYSCt5NzgrSkEvTnhkemoxT0c1?= =?utf-8?B?RGt3N3hmbTgrQlhDSENLZ3hmNkVuMENkRW95V3F1ZTNkRExzUE13VXNWZUxl?= =?utf-8?B?dkRpZWlvQm04SWJmcVd6WFhRM2l6SDhkZXYwQVc2UlZic2RRcHZ5NWczVE5l?= =?utf-8?B?NVJobGhtS0VJQ3prODNqb2pnYUZFZ0dqS21PcEFwSU8yV0hXaWxIWmFIL2Vi?= =?utf-8?B?cVdOdUZORCttN1VHMjErRXUvbDBWc2ZHTm5jQWNkRVBteVR5YTU2dGFCTFRr?= =?utf-8?B?aWJFdTJkODc4V2w0bCtOMlJmRXZxUVE2bGVFZnloMHY3WTNZdmFYWDliNFBm?= =?utf-8?B?NlpxZHhoL1Y2ZUJOVjZ2cGRBbVJQNEk4YVZtbDIzVEVBSUlqa29FZ3k0VUVM?= =?utf-8?B?S0hJV1p6ei9DVis1Q3k1UDRURW85WUp0MGFqcUVvbnZjR1NaSktGY1YrRlJE?= =?utf-8?B?SzZpS3NoY2hpOUgzVzV2ZHJETFkzZDBNK2JVYUdjRHhTaFo3ZDJNZnQ2MHFr?= =?utf-8?B?Yms4RGVIY2pZcjROb29OWFpod1FEeW52NkkrVTJOZ1JLQmVVdllBYkNCbG91?= =?utf-8?B?UzVkeTdTMVJFeGN6WG5iM1ZoQU9Cd3ZiYkJTWTNsNU1iL213bk5BOWhpZmw1?= =?utf-8?B?OExpbHNNbmpEaFhWbTFQT2xnUHAzTFExMnZOM2J0ZEhsMndtTWJ1NmlTTm1U?= =?utf-8?B?NHFLSWxRYzlQZVlVTHRZSXBvUHNXYlQwelZlL29EMEh3OWNYUS8wVHlvbXdQ?= =?utf-8?B?WDJwNzFqYi9IWGk4ZURldDgxMUcwYnM2K05kd0txUUFYRXNUamllNk1JZGxx?= =?utf-8?B?T3JjMlMraU9RRm1CREU2TTR3SXFzV0ZFSU5yVW9wa09uMTE2bFBTM1EwdDR3?= =?utf-8?B?Yi9ONHFaakJiT0h0eG5yV1MzLzZ5S3hkWUJpd1Z1MGFSU014d0sycGNVN1hN?= =?utf-8?B?MCtOYllHWHBzNU9Ec2xLL2xNN0JHazd3Mld6U3p3UXJuK2pRczBtc0tYdnFQ?= =?utf-8?B?aHgzcHFQeXRjbWJzYUl5UXpKTGRJU1lOY3BvNTgrVTU3NXdwMzZXT3JBWDdr?= =?utf-8?B?Tk5YUmJLNnNaV1c2S3hyNndrcW1wOGw2N0I4V1ZJUVpNSDlzSE45MFBCdjBs?= =?utf-8?B?Y3krMGdveDFvc3d1TUFySnA0aUJYcnZmQUtLL1kyZTNmRWtidVNhUUJBR3J2?= =?utf-8?B?MnZza2Q3aWtsQ2s1RDdna2Z3M01YdlR3UmYyMDdpZ2t1dUpKcmVtdGRxVXE1?= =?utf-8?B?Y1lBQzZNSW9TY21TM1JTS09jdXlwSzNqQWRtaVA4OU00VEQxMEI5RzBPUnNm?= =?utf-8?B?T2I4Y081SmpUd2owekpEblBMdmxGSFUrQlZ2ajI1ckZMT096czh6RnM4dDhL?= =?utf-8?B?WlZKd1pCamJXRVduRHh0ODlxMlRmdnFDbjY3d2xPSmF2WUFwaWcwWStIYmln?= =?utf-8?B?TGZYZUt2bi9hSnFmK0NaaXMySWtMbkZ5VzU5ajF6dm4yKys1QnlOL0dqVFVP?= =?utf-8?Q?o9ff4I5VuTzE78dqtzB3szLjj?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 176b9144-9d36-4af8-0c2e-08dd995a1982 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:21.2108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9qyncHeffX142k+TpADpJDkduR+GNiFLaYuSaslTtFfPsRVc+GNghI1Tieev2BzC9DijB/N/+7OoMiCjIZGpDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 dma_set_mask_and_coherent() never return failure when mask bigger than 32bit. See commit f7ae20f2fc4e ("docs: dma: correct dma_set_mask() sample code") So remove return value check for dma_set_mask_and_coherent(). Reviewed-by: Laurent Pinchart Signed-off-by: Frank Li --- change in v5 - add Laurent Pinchart review tag --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 015350c6f2784..073ea5912de3b 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -444,11 +444,7 @@ static int mxc_isi_probe(struct platform_device *pdev) } =20 dma_size =3D isi->pdata->has_36bit_dma ? 36 : 32; - ret =3D dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size)); - if (ret) { - dev_err(dev, "failed to set DMA mask\n"); - return ret; - } + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size)); =20 pm_runtime_enable(dev); =20 --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2073.outbound.protection.outlook.com [40.107.22.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4D2E298994; Thu, 22 May 2025 17:57:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.73 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936650; cv=fail; b=mqjFgfdM1YX8TEHGgp0vfX+SCsnV5kWeLQaPJKgqVGIzV0lL/K7f5z+C7sYvk/yy1nFNWl3vU7hL21Lx0OEYWYieJ9LJiNlhzPL4LUV+3Ourx8ZBcNkDksCXRJ3HVlt06YBowagId1lUEySPq20T9Tg68MsT5V4yXiNTLNu3JSg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936650; c=relaxed/simple; bh=1WOdk6X4SKbrjfoujDuYUBNioWb4sTvULnF6n9hwi2Q=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ivDGu1ZauRr/4jiSLDSp+6hd+QrRHDRTT+A6U00B3PVt+9Wx3ApIukRuNwe1dWPU7EtqLQ58Bj/aBvaHhYqdWiIYz0aIcO3a9jFTWV7dsitI2zOLKS5mj4SJLbGoniRb/u610ow61Fexb2vleZ2NkaK6a0/B+S0u5YpmJUWCIGs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=lL0f3AHj; arc=fail smtp.client-ip=40.107.22.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="lL0f3AHj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tcHpl0pUdbhgKLmjKyOrPcehL0pUG45rQL8mWjW2iRfUoGcBgztOiTBCWdhWdh/JglPKW+LEQaksdDCem8YdKvfZMu9DeV9zifMIWqOGNlzW3AoVeW/jNVOXjNv75Jm/p4xNM8YEFwbKy0178ETuS8YLSsIuYgDz5gI0QIzC2+naff0sBPMHyURLanZRUYiMqaM/iAVV/n5SwnHtqi9qeLiZtOWOSPIWvkyrWZuBUQuCv/e1e4FZKNvPcpy1q+Ew/kGn79UGKDN7do8JJQ17iCcW3n31qQtW+CnaP5hIH+Pu/G/ITREzg7WdObWpHQwxU02NPpkwzI4nqvCBRBIfOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yms8VojLzC6S+Hq/lXOhPH64QgJIIDIc/Ounz5olXtA=; b=SZtUqXB3cZ6ARXVMwoCrfl4bQpC1QpiRgM/3udDIfAmN/UbiwI2eA0KJ4S2V9G3uMfv1T5Lr3XvG0QpDONvR4QUmmqMNHEI/kWorLAraT+DZnwBIuMlAXlgWdadp711lR7XqXL3+hHf2ESuB8O0Z6HJCEDXIMY3OdOrh45h2NL6JyWA/xtwe3X53juDklFJSRxqjofrd+360jnlwfJanv6++WsaDObG4H7MJNu+edZ+VjwRa8Os2l9qAor5H/kOYzeP6dZotiDMIyaG4Jjs79WGkvvXEM2yRuOlFvAan+IJVrOVvsv12QIlYBtLFaq4MgMt6D6pa1gmWJ9hEiEUl6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yms8VojLzC6S+Hq/lXOhPH64QgJIIDIc/Ounz5olXtA=; b=lL0f3AHjKiZwrow2N8Mg+ZLzOw8Tpkon8Cmb+U8yaAguazZyOvUMFLHCIHGMdugB0kjySQcSgkpbGIXgQ4A3ubPf3XeWQvQgOwfcRYZAqKlaN9/tL5pGjrw/88HXVB8GkUnLpFERfew23MHP4jG/gfujlPNXMFB9OQWCCa69jNjceZaEeArfQk0HajoOf5+6zRvqeutrp8e8XL0WIZl2jQ9enDcbVIP7D6Z8LY1k8cdIF9xViVQIz0JU0Um4WDSaOgsPIcJvKA9nA5ABzg/HXpVrjjBzrLHmCLuK9XTwV1LZ88ZGbdscSQcF0hlOyhyCY7FLBqYgE5Fmam20t7pTkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:57:26 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:26 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:44 -0400 Subject: [PATCH v5 06/13] media: nxp: imx8-isi: Use dev_err_probe() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-6-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=1609; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=1WOdk6X4SKbrjfoujDuYUBNioWb4sTvULnF6n9hwi2Q=; b=VJQHr4/GHGBGqt8vc5Aqbup+5l9GBt7KcfAZ/LtA4XTZ4TaU8peShgEsv0pF3nWmr0C4J1Yae wV43Ys7tZ3XCztvmCNQNXi2Hes8/AbtjQzuNn09J5CS6F7COkJUqHgB X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: 417c3d6d-df5f-4839-f3dd-08dd995a1c72 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c25VaFlHV01SSUN4aExoOFR2TVNULzdGRjd0YURlSkZGdFpFeS9YUFVrSjVo?= =?utf-8?B?clNsY2hnY21EV0NIbEIrTnpYYlRvaGY2bUpBS1htN2Z4NzZTSlBvWXJlVzBq?= =?utf-8?B?VEF2ZldMcDhQRnpXcFQvL280REw3c01USkxsMkhEQk1aR1ZXS2kzOWowcW5U?= =?utf-8?B?R1cyWUhDN1hiK3ZQVTRUWjRiWmNkajk1UW5EaVFpZTh6QUpnSFNiVU9idmlq?= =?utf-8?B?NFdRVGREVUJ1anVjTlFScmMvTzZnZXo4U1NUdmkyZGQ1eWhmdWMyTUlnOVJl?= =?utf-8?B?MFB4aUZrelN5VHVveURUR1JoUVBVd0N0TEJ3clBFSzY0cXo4Y05Pcnhac1J5?= =?utf-8?B?bjNsZHh6QWNGSWpqYW9jQkJMWlMxQUlKN0tNeFhMNXlvR29kbmFEMmNPaVNn?= =?utf-8?B?a0F4NHBhQ3hqNXhPQ0ZUYjRtelppYVVCSUJQSlJOZmF5bkhDbUk5cCs3VFVx?= =?utf-8?B?Y2x6TWQyZERVZkVsSkZ0ZklVZHFzQk1jekpiTWxHdjVqMlByREFhWFZ0SUhj?= =?utf-8?B?cXVxeHQxeVMxMkM0bEh2ZWt2U1VseHR4MG5hRFhuenZKb3hEMDFwdTV6UWF1?= =?utf-8?B?S2grZHR4TnVmY2EzUndYaGZpb0dIYldRSnprcWZaZTNmNFNycUZCVEdtTzV4?= =?utf-8?B?Z2FFKzlHekk0NE1XTUlyRFNmMDlmVmx4SUZIL2loR0xRVno2c01DUWRLNlZN?= =?utf-8?B?OGZFMTBQdXFzVU5EQXpabldvUjJPWW1oWU42cmtuR01oSEhpT1V5dzBFMmNp?= =?utf-8?B?R2tpZmtYVVFNSkpjYk1PVnlQWEpkamVCRFhxemhROHZLbnVJQnJtaWp6YkRz?= =?utf-8?B?aEVGVnRGdzZ4R1FxZzIrMzQxYk54NHY1WlBYZmdOZ3Mvano0Y090OFlEeXFD?= =?utf-8?B?aE1sVTM2ZDFRVkpld1I2VGo1TkJGc1dzaFJ1OWpRSDhobzdLTjdoM0VkZzdG?= =?utf-8?B?eVhpa1gvdHFkc29ESWQ0TE04Ymc3VVBIRXdrajZ1UEdZRVQ0dFpSVEhlUjNz?= =?utf-8?B?UE5vNGszQXY4K0tmTFlBZC9IaDhiSjdDSUxZamtuWUh6SVd0d0FLVTlOUTh0?= =?utf-8?B?UEtRNloyTG1idVNFMGc0YTZsLy96WTNRR1k2VWxjTDJ6ODJNVldDcVVxbU9j?= =?utf-8?B?Ni9kTXJ4eGFBREplU21hNDFQcmYya2pvNUM1Z2lQVjRMSmVwOHBjek54SVRr?= =?utf-8?B?VFJmVFFqMW9pUDNoYm5ZdUVjendnektmWGlEYUFELyt4S2VVaWdDbGhTazQ2?= =?utf-8?B?UHpRbW4yUUhSaEdwd1BBLzg2WEI0WktDUU8xUXFlMDZ6dWN4ZmUrd3JURUs0?= =?utf-8?B?QUR1cVJ6ai80VnZrYUxUNXVSeFlmL3lMNEJ2WmhHYXBObmcrRmVIQ29hZXFo?= =?utf-8?B?OWEzcWRxeEVEZXU0MHJGZXB3ZHVKYXZBRGZQdW1mSzhzY3NNVldqOW5zZm4v?= =?utf-8?B?OUROU0RhMHNUK1g0Q2JpL0RiN0NqNHFPOC8xOWZJU2hVV05WZVBwMDRUL2sz?= =?utf-8?B?K2FmTU04ajRrSVdoLzI0S2lpQTlMTDVUZXMvanhNTWdlc0p3M21zVnlsbXht?= =?utf-8?B?b2swMU8xb1o2T2pZTEVTT1pSbDFndm9NZmtjcjZicHlNTGRmSmxXcFF2Q3A5?= =?utf-8?B?Skdkd2hVWHdMbFJHdnlXYTgzWVhTcG5qeFV4UStOOVF1a3JlOUplTnhoQ25s?= =?utf-8?B?bnRNTFJ2U3FtUW1aNG4wODkzTWUxRkRRemx3M0g3SHBQUUdzejBSblFYd295?= =?utf-8?B?dGErYjM1N0s1azNXZStRclpwMDBjQkl6em5rbVJNdnNNemFOYkk0ZmQ2eGZZ?= =?utf-8?B?WTlueDkrVzNUeVFGbjZleCtOc2FwODk1TnREQ1oxQ0QraDdha3lTNFA1VVNY?= =?utf-8?B?Q21ZWGgrMWxaSnVtMngzRUI3Wk51ckI2Tm13N0VRQUlMOU9YN1l5MzMyRGRF?= =?utf-8?B?ZnVUODlBc0l4SHZWam9VcEpTNm9yTlkwb3dzNFFDTnoxTDUwOWRjMlZNenZ3?= =?utf-8?Q?YnH0BLb8c+dnfqIk6c4ZUXJtXLQP4o=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVpQUFUzMnJhSzVMVFhYcXJYeUVHendldVFoNFNtMGxXU0lnUnpqWm4zbGlK?= =?utf-8?B?bjVhR09KcnlrN3pTNkhrNnh5UDRIYktPUVB4Qml2V2c1UGhpS3VuSjlmUlNn?= =?utf-8?B?dkNrTkNjTE5TR1pVTDdhQmQvRGt4bjMvNnhCNTR2MmRxTjczU2dndjRZcys5?= =?utf-8?B?YjlpMEo3NEtqeG1PMHFFV3ZTVlNqYm1TSVNrdlRGaVJCS1BHQVRhTmUraGQ4?= =?utf-8?B?V1hldkpsQ2hOZ2ppOWEzcGF5TUdVOVdCZ2xvYTRuZTR4Qks5b3pXa2tKdTE1?= =?utf-8?B?Vk9DZklLSmExTjVVa2YzcHBYR2trTFNyaEh3Z0Qya0pRNDNwY0UzYmZCQ2ps?= =?utf-8?B?bERjdDd4eW8yRnBQV3l5S1paeFBBZzBQQzVOVzd4NGMxVlp3NjE5R2QrYkRG?= =?utf-8?B?cVZ0UVVRTTUzWXQ2WVhnMDlUUEtHQVdkRXJLeUkrSm1xWHAraGhXdTBGUHVG?= =?utf-8?B?SHJxMjRMcis4b25SMXp5L3ByV3c4KzNCR0R5QjY0UTd6aHVSOWw3Q2p6VWhP?= =?utf-8?B?YWhXdWRCU0Z3aDVrb1NVU2hKZWpodW5SRDNxRmEvbW5TdExQWDJMd3BIZ0RM?= =?utf-8?B?VDh3NEw2bTBtNmtmNDFaMklSVzNydlZCYWR4ZVlUSnlVZHpYL1F3em9FcW5x?= =?utf-8?B?T0FyazhCYUI0QkVnZGErMHRZQ1NzQUJNRlBONzQ0TmlZUm04Rk40bTlJN21u?= =?utf-8?B?cTFCVms0RHZScHNERHNDaG4wK2tHaU1MSXZlYjI0SndMOTdTM2xHZEY1aE4x?= =?utf-8?B?Wno5ZHJ0aElwZjBrb1RmNW9EbkI3V1VGUTNKKzFpRmIyNkJXdGxCa0tVWDJT?= =?utf-8?B?blZCZHg5a1k5a3RHL1dTaU5BWEVwdFhoN2VhRGVCVk0vR3VrVGhBM2NKRUxr?= =?utf-8?B?QXV3eFBac2wxeWpXS3h3NWIrdmpoRWwvaXFZV1I0R21GQW53TFJHTmMzMkRN?= =?utf-8?B?VWZhcmkvUWdwb2JaUUJ2M1FsVmhSVnN6ZjAvTkRjbC9VNDhEdGZnMnBObDJw?= =?utf-8?B?SGRGZlc5ZWJ6VFdDYm50TEhzd2xhbDVuMnpEYlhsWFE2bFBkalZHVTh1RDZz?= =?utf-8?B?cGRTYW04U1dDeUtMQ1lidGljYXBSZkJnTUJ5eGRVbjUvVmFRdUM2NWszQ2hG?= =?utf-8?B?NHJTVkRiOWREaVJRNjZHeWQ5eHhOZXVzQSt5Vi9xRWdOZ0xJSnkybEdVd1Fv?= =?utf-8?B?Ykt3dWpVRmt5aVNEU0VocWJCTXdnY3VwZFpqSmhQVVNHTnVQM0JPRjMrc24r?= =?utf-8?B?WEJKV3JydkhxcXAxL3RHZjZCSjIrSnVyZmdWUldsajBkWnZIOTV2NGZodjM3?= =?utf-8?B?Z1BOaHdQbHZpYUZHQUJUdWo3bXNLK2tMQmJ0ajR2d3pFZlorUC8yVm8vN1Br?= =?utf-8?B?QzNtZFRhb2ZwMkNNU3F2bXRMWStXRVM4Vk9jN05DdFdHb3Y3MnhTNlJpaVRm?= =?utf-8?B?NTA5MFhVbWNiVHBtVlA2L1Y4K0pVeFB1UFE4eEpqYzMyLzhhejVCOTJXbVVp?= =?utf-8?B?S2RiVDJDWE1WQUdtTEZIRXN5N0FlZWcxOHJUVkxjTWR2UGtBemhab3RWVkwx?= =?utf-8?B?TGVaR0REL0NBVko3VFZBbFMvaFhZMjl5VXk3OHE3Vjl0RWc3SFRLd0VlVFJi?= =?utf-8?B?UVdlOU82RDRUV1BSKzFFN0JIOTBvdVlHNUNXUFlEQ2sxSW1GNmVDQXZDLzJp?= =?utf-8?B?cjd0Z3VDbTRPMGtjZTFQS29ZY1JMSjA1UHFTYXQxQ2tmOHJOcExseTZ6dE5Z?= =?utf-8?B?WVIvYi9MRHU3S2ttejdBY21YZUxiUHB1N1h6ZHd2THFuMGJlN3VzNnlzZG9a?= =?utf-8?B?U2MxMTZUVjBwQmJySmZJdVcwTUhlMngzc1pKclV0aEhGTFc0aGlRNTRwQm5J?= =?utf-8?B?NU5UbE9nbUJvS2NZaHZENXFrc0JwMVlwSzhNQ3ZKR2FUUmhsMmJ3SVNyY1VP?= =?utf-8?B?RC9heVlMdStKM1RWNnBJOFkrSnY2VXlrRUZHS0RFdURQVzZ0MkhDNitCaTN1?= =?utf-8?B?SEIzd3htOEdXcU9VaERLOWMrRmk2QkxRaWJud2doNFpiQXF2TURSczJ3NzBH?= =?utf-8?B?LzF1L2Rzb0RpRkFEajhNcjJmOVBBc2FpelZ1dVBFV3VUVmUxRTFmYytXOUZ1?= =?utf-8?Q?fUVvf3F9uWqLsA10Ccp2Q6dLW?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 417c3d6d-df5f-4839-f3dd-08dd995a1c72 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:26.1709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mr6dPoubkmRCThTGPUPq5arUQypC+Ff9nwLinzXahA66qM60JQmAmuFXJR01U6ZIl7thESRutfBh1aseQqxAVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 Use dev_err_probe() simplify code. No functional changes intended. Reviewed-by: Laurent Pinchart Signed-off-by: Frank Li --- Change from v4 to v5 - add Laurent Pinchart review tag - wrap error message to new line --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 073ea5912de3b..4ab2749e460d0 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -428,19 +428,16 @@ static int mxc_isi_probe(struct platform_device *pdev) return dev_err_probe(dev, isi->num_clks, "Failed to get clocks\n"); =20 isi->regs =3D devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(isi->regs)) { - dev_err(dev, "Failed to get ISI register map\n"); - return PTR_ERR(isi->regs); - } + if (IS_ERR(isi->regs)) + return dev_err_probe(dev, PTR_ERR(isi->regs), + "Failed to get ISI register map\n"); =20 if (isi->pdata->gasket_ops) { isi->gasket =3D syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,blk-ctrl"); - if (IS_ERR(isi->gasket)) { - ret =3D PTR_ERR(isi->gasket); - dev_err(dev, "failed to get gasket: %d\n", ret); - return ret; - } + if (IS_ERR(isi->gasket)) + return dev_err_probe(dev, PTR_ERR(isi->gasket), + "failed to get gasket\n"); } =20 dma_size =3D isi->pdata->has_36bit_dma ? 36 : 32; --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92BBD230BD9; Thu, 22 May 2025 17:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936655; cv=fail; b=c9JoUd9l2g6XcFwfl0Ov/8iMO9pRYfkV6wkB0++w8boqEICZyG9SoKV+jzSPAilK0XDzwzSf/prfXhn/U26e6nGvIK081uw0z/eXKGjxU6vYe8XOHxPCnWzk/blsEuZHEOgEY3GYgUfCdVgqnQ4ud9/ftBaZpkwqwbFVd+p1uC0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936655; c=relaxed/simple; bh=+kCTRZ6w4GyMFelMvQrhrck0JyjrDRzmefEn2XpTfoE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kL9S3MuSLTi+MrKFiDO6Nlhd7wHav4Y7TlRW0n0CeQhqeMhTOEHeeZpjcbVQ3Nxnt8sH1OGziC+8APuwASA9WO1RzMYwTmr/QRW0aQsLRM0KpacXayUpv0Qy8aE0sD+eXuCRPdCsrQegWcvWBAZJjgccOgtECrTYz9k5V3yupXA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=V2KMjngk; arc=fail smtp.client-ip=40.107.22.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="V2KMjngk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vgvocX2YVBdikYywuR8zvT/DiE05yXpB1LDRfnwbEKxSXABZS8QQZWFmgdaQwWrn0FVhYn/QZCAZL4J6B58Bv+flN0bRisbTK/bk1Lt68wrELPJP7kajAI0C0+KDP9RjM6MrtrunLW6jNDu422/SIXBN4t5rRXu/nQzf1gqcHCny17yhbSJFbZ8K/KXzfYNo3oFL35LsompbF0wfIEnWnlgPitUr01VVlM0AfF/E2SyPFLv9zOD/VjamiOs+TUlMV120DzysrXx8Kjcd09kjZETs44rwVkK8EkNnhQIjDd/bln0fOzFh5RhfyAbeEEaQS/rdPcuqKRW69f6UNXYCfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Htt1vyauUF/xMn9AAkaSqQ1qIg3yDI2adKn/6/NXL98=; b=amd8jlKz8aiA2XJxgTIeD15jlAWBblgRbeB4qPdDj0UkZVyRAkfY4dXzcz4ykhDaL7lf9NIOcOSQ5jx2EqAiMQ4VwhhmzQ97n0QGVzYyeAuingk+g6h23nGr6Dif/ziy102EgdTZ4VBhcjHSSrT4rkZM3fmUvz8DItHPEjb0GLaCWOqZ2jlNyCHEZTKzvrtM60xVd+dSETUtu3YVIog0zvitWzIevu0xO9ORjQrTPHiFRS9GMdRAWrKjx8/6bXpe1azD5UW29aGSqEpYaZEj15LDeNlINAlXKfWtauvh9aEsRXXT1g1QViUtLK//wPogibZ5jA6nGSZSRfwvYi/BcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Htt1vyauUF/xMn9AAkaSqQ1qIg3yDI2adKn/6/NXL98=; b=V2KMjngkDM5wJYfgBayFKAckxkZE0QD5qnuqg5uvlvypshjqODL+yvPsvuUOcYKU9kzSg5kf04F5bfKqOCDOKAFr/q4YxK0G127aljY6PG2kX1vCi76rN/As/n01ANCZZUmCATkfFEPt1fXh8dca4P3SmFXR29MDlivB1tvL/WG7ygJYBgfeUY/mq/cwtzL3Yzb4TDZn5+dWOGuVQpMz4DpKgqhVvEmXBqZC9iiwaJIq60tPrejxftRV8Dny8Z49/WKq7xVX6kLAD1rdW2c3YMrq4AQmEvNdgM73ASDDdrTBXVUaOTWj/2ubuz6AeixahkygvkFaFBNFB5f68tehMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:57:31 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:31 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:45 -0400 Subject: [PATCH v5 07/13] media: imx8-isi: Add support for i.MX8QM and i.MX8QXP Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-7-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=4449; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=a8IvWyJx6RysyxeOtjW00LJjcg1te1qvl0le1ZOYPGc=; b=/k3op4k5GkBRB5YfP5PLo6LuE9fJYDD11ZLu13w+QIUnTFXrV0dKfIaJHmGwGviRr6D7fdJ4V Wabogzg2Y+EAbghyRfrd1/xmnHVmcDOBDLr9yI6OXSFgmFyVbJRdx2w X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a5eea7e-f0a6-44db-85be-08dd995a1f77 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZjZaZ00rMVBzVEJoQ3RmNmpsUkU3Z3FlVVkvU1RFc0l3WmlTbEFKcW5pU044?= =?utf-8?B?dHAwWEs2cWRmMGRzQklZRkJKcnIxWUM2V1F0ckpvMUlCVTR5MU5OdWhHeUtP?= =?utf-8?B?UitFWklPa3A0dGg4UURmSEVwaEpOOVNLYzhOSW1QbHY1dGE4OG1DcElKYWxx?= =?utf-8?B?Y21hdW1nczdIOGxGeStybGNVMkRwcjlSeS9jS09IbTVNZHVlWU84Qm1qSkly?= =?utf-8?B?ZzEwQkswSWs3N1NoanowYUljS080YmZXYkZiUUtSTGxmQWhHQUU3N1EyV0hU?= =?utf-8?B?eEF5YnRjK2I1ayswalM1RWhLcVNNbS9oaThMOE1KMWlkMGFvWmFsclY4enFv?= =?utf-8?B?c0srdWpJT3pzVU1lckRRMTRhMEQzVlBlMk1SME52UTUzS1JiTTZCS1VvQi81?= =?utf-8?B?SWpqbzZKVU9rZElic0xMSThUdzJycXVrTVJicVVIR09ZeklRbEFnNld2NGpi?= =?utf-8?B?bERHVXhUUXY1QXRCVWIyWjlRbmRaRVVDbFpDMlBTcDU5cUtsVmZicm40akVJ?= =?utf-8?B?cmU1c1hsbGpwU21xdzZnZDBLdElkNmJFcHNiQ2M2RUJhUmx0MDROVlVwblk5?= =?utf-8?B?VWErOVZia1ZUM2Y5cnRXVGp4ZWZsUGRuRG8vNnNnMjZrSjJqaVVPVWtLbEFC?= =?utf-8?B?cjRBRTZsWW94V1JlMzF1dmdBVHV6UUg2dE5SRHc1SzltZzNRbEFnS0N0ZTN1?= =?utf-8?B?NjFxU21yTDVhc1B2ZXBUZDd4Sy9EU2Y4b2x4eTAxcmtjTDJBbEJYbXB3akRR?= =?utf-8?B?UXVDb01Zc2dTdVVPOXIvMFp0UisyMEY5WnJPcStJdTBMemdWMk5XblRabm1B?= =?utf-8?B?RFVOd09nb2ZhWmRPOE9EdGFDazlhQmVYSUFKSGppRk9TQ2ZqRjg5d1BJQXcr?= =?utf-8?B?djAwQXNQOStHQS85eTNlTHhINWJ6VmttZFFpZllVYStxVDhsNUhOSkV1RmE0?= =?utf-8?B?WG9nSDI2djZrVkxTVGQ0alZMbWRxeEI4Q0c2UityNUxoWFdPWGIyQmdjbkVC?= =?utf-8?B?a28xbm5qQjVNUWllQjlvT00zQVJIVjZpNVhleFIyUGlxRkJiMTIzQ1JGbE9l?= =?utf-8?B?VkMwSUtyN2RDc3VwRXhnb3FqSlJ3bkovakNQbEwzNmhFQkhKcDZoUXlEUnJO?= =?utf-8?B?MkgzZzc5ZWw3cFhiV05GQS9qY0JWY0lrQUVXN0QrQUZoajM2VkV0RGFPVWw3?= =?utf-8?B?S1lxWVhjU2NKbFdFMGZLYjdCNWc5R0VrTnlCRXlkdjZtazJpbW5IenBrMHdk?= =?utf-8?B?THpodUtIa3ZDMWZPYVlmaEtkRjhZNVN5WXZtWUFXSmxiWFJUV1BRNlY0akUx?= =?utf-8?B?S0tDUnpnNFNlNzFVRHZWOUkzVnlNNjMzZmxRcFoyU2VRY0t0UWV3TTZmejFv?= =?utf-8?B?TXpyTWJFcDVPT0FwMDlRc2FTaFdoZGU3S0hISjBRUDRnb2pyZzV0NldxTzIw?= =?utf-8?B?MWNNWStyUDBaZnRyWFVUT3FWRk1oUzAxM2RHai9sRFN2SGM4YUtxdURTZWNo?= =?utf-8?B?K0RGM2xsbUZ2dFAzM2xsbDFoUVQ3eHRjeUQ5TDlLdXI5S2J4d3ZDOHNwZUda?= =?utf-8?B?bVc1M3UwMEFhbG9uRStWTHBVU0VTcURrZFBJbUgvdVpWVDlKbi9rT0NidVlG?= =?utf-8?B?dElJcU02b1VDVEpud1JPa1FKMzJHWXVLMDhKdHVFMFpMV1N2aGpBMENmZ2VF?= =?utf-8?B?OWRHMlBIU3ZtZGRUYW5hcHY5bmt5aDJ6czJwZlQxeUdKbmMxTUJFQ2ZOb0tu?= =?utf-8?B?RGo2ZTRZd1d1OG5RYkE2K1EzbjREYkhSNWVZYVkwbmNQSUM5WFRDRnJqeXRP?= =?utf-8?B?SU16Yy8ya3FHOWt3ZEdDUFphcHVLZ1pTQVlXRzkyaDYwcjA2MEh6QStCMW1Y?= =?utf-8?B?N3RIQ0xvS042MStkY1ZVTW9jeTU4S1A3bWtSdjhTUkRuTjY1Q3FWWmxmTklP?= =?utf-8?B?YjkyZEJRaC90cDdWL1F3NmRIOGtBS1RtLzh4K0EzMGpyaUxvdk1DZHh5TlpE?= =?utf-8?Q?udtkqcW7ey19fQLGj65xaim2X10i+0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NCtBMDQveW9vNSs2dm1YUjJPRTkxYlNlU2Fqcm5ibVJOZUgzTE1XZU5UQmRu?= =?utf-8?B?dHNxaFZGTlQ3YU1IWUh1RURaMHRpdHZBZjIxb2IrVXhNV2V2ODAyblRJejRa?= =?utf-8?B?ejAzVXYrd05sWm1tdEFEbWxQNzZCWjlKczJkd0VnUG1aTnA0OC9KbXJTWWxZ?= =?utf-8?B?bkRZUVZQbUFvbWs0czk1dVdhMllRdmt1a0dVNjZ4UE91Rjhrc1hRUSt0MXBT?= =?utf-8?B?em9ib2E3UXZtdTdVdUZ0Nk0xZEQ2TVRaU3dWM083MHdrS0Q0bHBSc3NSTDlo?= =?utf-8?B?c3VncjdLOE9vMEp5VU9MUnI2b0hhUVZ1dWdxdlRUcXlyWkNiMU9sTmJyeFhy?= =?utf-8?B?c1FRbW9Gc1ljTVcyWDdaVnlYZEg4NXNTQUN0UnZBL1BBYUpaN2xuVkRmT0Vk?= =?utf-8?B?WllKY1Q4RWRWeHBSMllGTmpQYUg3bk9rdWN5UFptOGRPZm9PQjFNYUxpd3hx?= =?utf-8?B?aTVuMjhYSStqTkkrRGlBL1NlZStFOUt3UUt2a3BzZEhpeFc2RU1XSTRGS1JU?= =?utf-8?B?Nis1aTFFVEp1dnRCTDRRVjZSVDlmQlg0elFoRHl4T21MSmdNV0NXdjc5SnpT?= =?utf-8?B?MzcveVYwaThkS0dpZ0U0SmVKR040SlAweWpxaGsrd1ZYSzhrakNYZVJ1aDBE?= =?utf-8?B?RllCcFNKclVjQ3FpL3dzSkQ2K3phbTRySmkzL1AyeElQYmJSbnZPYWE4QnRB?= =?utf-8?B?NEJoaDg1M201R0ZYeXJWVm82Tk9xc1laVUxDcUVyN05CemhOb3FsRGdFbnVF?= =?utf-8?B?NjJaZk85Zjc4L3p1OUtnOGU1Yi9ZSkZkcmNsR0YyRTNjM0xzOXNacDc2WnE1?= =?utf-8?B?SnlCYytMU01XZkl2VEFJL2NJcmpPbHFOYnFtNytlaDk2eGhwTGRaVnV6QkNz?= =?utf-8?B?T0RxMzE2bWdDcVdNU2RNandvSzJZQlNTd09TS250cnh5TnRDSzFhaG9zTS95?= =?utf-8?B?QW5EVHBLMitYZysrYW5pTXBSWVhjVDRJdy8wQXBvdm1BV21UaUdVNEZPT3dC?= =?utf-8?B?ZUFGekYzQUJGRmRaK0FPcmkyZHE2RmRhMnZNSE53T1NqUmwrbndOK2RBTE9X?= =?utf-8?B?cGtEa1VoQkFBREd1dDc1cHQzUEg3TC9iK2ZtU0l4WUN3My90cFJ1ZVVsT0F1?= =?utf-8?B?M0kyRWpEeHhBZVhUNnVBdDVwTkVzUHA1cGNLRzFiVVMyUUE0MThCR3dmRFZX?= =?utf-8?B?R0lZeTJqZW9RWVQrRjdrQ2hOU2E3QTdpL1NWbXVrQ1B5ZlVLY05ZYTFuZ2Ry?= =?utf-8?B?WHUvNzA5aU9leHh3Qml5VGVWR2xLUTAwZS9aVnAzQUZhZFUvMER1SWUzak1C?= =?utf-8?B?VEI1SjRPbFFtTFlqa0pBdlBNMWJIeW9aMjlHRmtpTC9malI2TC8wRXQwVkxP?= =?utf-8?B?bDA2NjFOU2cydHNDd1B3Z1NnampJM0NCaFkrUjhncnpVRjlzOUU3MkhNNDk4?= =?utf-8?B?ZTJLZVJibEUxT0I5NkFiTWVwRzdLeXhkdmJCa1ZtUWtlZGRubDJEb0lkOVJk?= =?utf-8?B?d2xZT0JNaTF3d0hYaGN5ajZidDREcURnd1diRTJpcXVrSUdmdy94ckJkNDQx?= =?utf-8?B?N1hPT3h0Z0hLMWFtSzc3Zy9JdlczRmNiOUlDcUVTUzNlYnNERmhQUTNyY3Uw?= =?utf-8?B?cklTR01FWnYvK2d5UFBGZ0FXQXBjeUdacDNoSncydnk5ekpzL3drdmI2Zmc2?= =?utf-8?B?dEdHT3g5QXlGZWhBbm1PcDRVTTI2UkFVbXlKdTl0bHVoREtNRnM4SmdicmR4?= =?utf-8?B?Ky9lV0Y1YXI2YS9IQjZ0RnU2WlZrYlFXKzhPT2dtbVIxR2k1eFV4RVVJZHp4?= =?utf-8?B?V3hiVHppQ3VORlBCRmpaMEV4R05jRHMrY1FKMkNFN1VsaE5PL0FMOFNjK0pU?= =?utf-8?B?WUNxbFRXN0IwR2tjS3NCTjcxQzJmRVRJS0IyMmpSUUNGdVAzcTVOeXI5TXow?= =?utf-8?B?NXN1OXpiSmlJT3NkZTVlaWp3MkhVNEJ0L1ZLTFhKWmp5VHd4NjUxOE9aRHho?= =?utf-8?B?UHIzQkJhend3WXZRUWVkVy9qTEp5SmFVNEp1UCtVMnBvTXJuZFU2cjZZQUY1?= =?utf-8?B?N0FtbHljWTJLeC92RE50enkxMm5pZEk0TStndzFLSUJzVnBHdjAxVFVMMlBt?= =?utf-8?Q?ObJfwqmvX95rJu8aetfV9K75L?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a5eea7e-f0a6-44db-85be-08dd995a1f77 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:31.2003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TScKbIBZDFR6FzqufkzWxyoJ+9WC3Vr7rWt1j6UwyR+TwdQwv4VjnNEgFfK0bz/Gaug3CjTnQmaPZUf9jgqtsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 From: Robert Chiras Add compatibles and platform data for i.MX8QM and i.MX8QXP platforms. i.MX8QM's IER register layout is difference with i.MX8QXP. Signed-off-by: Robert Chiras Reviewed-by: Laurent Pinchart Signed-off-by: Frank Li --- change in v5: - add Laurent review tag Change from v3 to v4 - fix i.MX8QMP ier register layout - Remove clk-names array - Change 8QXP channel number to 6 change from v2 to v3 - none change from v1 to v2 - remove intenal review tags --- .../media/platform/nxp/imx8-isi/imx8-isi-core.c | 43 ++++++++++++++++++= +++- .../media/platform/nxp/imx8-isi/imx8-isi-core.h | 2 + 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 4ab2749e460d0..981648a031137 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -246,7 +246,7 @@ static void mxc_isi_v4l2_cleanup(struct mxc_isi_dev *is= i) =20 /* Panic will assert when the buffers are 50% full */ =20 -/* For i.MX8QXP C0 and i.MX8MN ISI IER version */ +/* For i.MX8MN ISI IER version */ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v1 =3D { .oflw_y_buf_en =3D { .mask =3D BIT(19) }, .oflw_u_buf_en =3D { .mask =3D BIT(21) }, @@ -257,7 +257,7 @@ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v1= =3D { .panic_v_buf_en =3D { .mask =3D BIT(24) }, }; =20 -/* For i.MX8MP ISI IER version */ +/* For i.MX8QXP C0 and i.MX8MP ISI IER version */ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v2 =3D { .oflw_y_buf_en =3D { .mask =3D BIT(18) }, .oflw_u_buf_en =3D { .mask =3D BIT(20) }, @@ -268,6 +268,21 @@ static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_v= 2 =3D { .panic_v_buf_en =3D { .mask =3D BIT(23) }, }; =20 +/* For i.MX8QM ISI IER version */ +static const struct mxc_isi_ier_reg mxc_imx8_isi_ier_qm =3D { + .oflw_y_buf_en =3D { .mask =3D BIT(16) }, + .oflw_u_buf_en =3D { .mask =3D BIT(19) }, + .oflw_v_buf_en =3D { .mask =3D BIT(22) }, + + .excs_oflw_y_buf_en =3D { .mask =3D BIT(17) }, + .excs_oflw_u_buf_en =3D { .mask =3D BIT(20) }, + .excs_oflw_v_buf_en =3D { .mask =3D BIT(23) }, + + .panic_y_buf_en =3D { .mask =3D BIT(18) }, + .panic_u_buf_en =3D { .mask =3D BIT(21) }, + .panic_v_buf_en =3D { .mask =3D BIT(24) }, +}; + /* Panic will assert when the buffers are 50% full */ static const struct mxc_isi_set_thd mxc_imx8_isi_thd_v1 =3D { .panic_set_thd_y =3D { .mask =3D 0x0000f, .offset =3D 0, .threshold =3D = 0x7 }, @@ -322,6 +337,28 @@ static const struct mxc_isi_plat_data mxc_imx93_data = =3D { .has_36bit_dma =3D false, }; =20 +static const struct mxc_isi_plat_data mxc_imx8qm_data =3D { + .model =3D MXC_ISI_IMX8QM, + .num_ports =3D 5, + .num_channels =3D 8, + .reg_offset =3D 0x10000, + .ier_reg =3D &mxc_imx8_isi_ier_qm, + .set_thd =3D &mxc_imx8_isi_thd_v1, + .buf_active_reverse =3D true, + .has_36bit_dma =3D false, +}; + +static const struct mxc_isi_plat_data mxc_imx8qxp_data =3D { + .model =3D MXC_ISI_IMX8QXP, + .num_ports =3D 5, + .num_channels =3D 6, + .reg_offset =3D 0x10000, + .ier_reg =3D &mxc_imx8_isi_ier_v2, + .set_thd =3D &mxc_imx8_isi_thd_v1, + .buf_active_reverse =3D true, + .has_36bit_dma =3D false, +}; + /* -----------------------------------------------------------------------= ------ * Power management */ @@ -499,6 +536,8 @@ static void mxc_isi_remove(struct platform_device *pdev) static const struct of_device_id mxc_isi_of_match[] =3D { { .compatible =3D "fsl,imx8mn-isi", .data =3D &mxc_imx8mn_data }, { .compatible =3D "fsl,imx8mp-isi", .data =3D &mxc_imx8mp_data }, + { .compatible =3D "fsl,imx8qm-isi", .data =3D &mxc_imx8qm_data }, + { .compatible =3D "fsl,imx8qxp-isi", .data =3D &mxc_imx8qxp_data }, { .compatible =3D "fsl,imx8ulp-isi", .data =3D &mxc_imx8ulp_data }, { .compatible =3D "fsl,imx93-isi", .data =3D &mxc_imx93_data }, { /* sentinel */ }, diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.h index bd3cfe5fbe063..206995bedca4a 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h @@ -157,6 +157,8 @@ struct mxc_gasket_ops { enum model { MXC_ISI_IMX8MN, MXC_ISI_IMX8MP, + MXC_ISI_IMX8QM, + MXC_ISI_IMX8QXP, MXC_ISI_IMX8ULP, MXC_ISI_IMX93, }; --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2065.outbound.protection.outlook.com [40.107.20.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E30E29B221; Thu, 22 May 2025 17:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936660; cv=fail; b=M9gM8PAB/1R2k91CLrv1PHNsrIM+RIurvoMPpIs8xDegPBEt11rYTqWRxBMXeu/DF+4ZOD9hm7oovv85I9wHOYETDKS/DpqiUGchMItFTBgcLZ4AaFRgONn3OzymFTHfL0oQhokQr98k7hpG3t7TFpqHymXwK/HVsPFA+H0By8c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936660; c=relaxed/simple; bh=dN8ODpN+tTAy8TgZSSH3Lz1SaGinboLijPzWlhqnxNI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=DLUvcV6DvrvW/DNGBKSTedenEznrVtQlqvuAIqorm7oP004L4AYwjAh/1fRIW0m4mEJYcko3URpOUCc5WU2/+u3cCwRckjCf2cmG0zajiA74KBj1aBn0BySUi/xBygEuvRJnsxquhLAcPTiIyNRBLVY+yIdS4KIFxKLtGTg9tJg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=EydrhKQf; arc=fail smtp.client-ip=40.107.20.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="EydrhKQf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ct84xf/B6Hr0v9KyH0NcTd4xIxNXoO72u6nkv88ig+++59eCpch12FjNUx/t0nZd4yQ99H5jCu1OxpHO/OCGVi3t0DCLH2C1/7KejAxTIaBz7PQuNPx+yP9lPSZ5aj7xMahgoGMYasOi6rRsED0ft1bNWdQmAfiohDkgPTiDPotj9RWwwyOWiESELYxoTihDUsLKk8Jc4nDvUi96I1YHeCEklCpwW9UDc3k5SCEZ+BmwjJ8gUTMTfN74fzBEKLMQYHilNT8Gqo0+DCTZ/NW2qcxyDan9IUYTKpcG+yaslRF4Dsv8Hnf/ZfV+FI7zY1UKVdT1xOpyozHTNQoWTTjiiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YvWS0oe93wfZfydGOkO4YkhPPDcZkq+glSSo3ZgQAOQ=; b=VZrRkobVawOp45qNKPvdoZ0Me8lD0ZQCTfr/yBlYLOphGiOrCjcIb1tilgsCYcZaevhwLGrl9V/EDsBgu3EQ1F3zlHWQT/U3nd9THI6WMtbOj+hNJ34UaNT4RYE+eQaTiL1h7Cwd/1XuB8zWg8m5q79IGSP2Wa9FRlBLFhxD+qDxtPLdt4aACwBVAq9c1mqNrURVxsM4o0b9IRAJ8UW5B8810jEyKzb47VIyh7yBnwK0o9VLsw49uzT+J8yslYrKVvoGijGM4RbfinhovL+CmjQGjgnuaccnMxqUmC0yG0a4XuwtqcdhAbJCBrgA/oMF3cA4B/OM7osJSRPoAGZF7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YvWS0oe93wfZfydGOkO4YkhPPDcZkq+glSSo3ZgQAOQ=; b=EydrhKQfuA8JSOECjKbhLuE8otUwGlooGc+kUaMPausA4RwRta1S/b4a66oEkCJVRAqiAd5g3I+jtllYHTDZeyoTWmvFXb5/LY96BHrQR4i1/u8FAY+xwR9C6pYyi013U/oV/oR6FcjN9eBBQHiKZJW/ajzynWBTTjIgVRiRcg8RXnR+JXhFWdtGfmzxMJftBofMhVMcNMXf622N/ncc+NRJHDfQg9w3RPK5zudkJcDWqB2KZxv/ZiLPcirfXiFuI6JeXxO1kvAZrV8pG1T/Q/Q5fbgkLSfNVIFqCaBOt7QiZv7GGtlgAYkqVjPJItvdvZU3MFfCKfa1TFV6g0+6+w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:57:36 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:36 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:46 -0400 Subject: [PATCH v5 08/13] media: dt-bindings: nxp,imx8mq-mipi-csi2: Add i.MX8QM(QXP) compatible strings Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-8-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=2983; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=zaB/XpRgTLtOf/8XnErKPHAjG6EGhnt3Df6Vz1XFRo8=; b=aQDp87hjJQODu+MaXk6bhbU2gWOL6r4ifrGS9B3ArrC9sLPnhjG2KZ7D5YF/AD5XIMb7hr7Hq Eid61iHRe7tBCHx1mxHI6m1z3hxH93sQAYr899LPlqqew3vCxxfpSFc X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: ef19b122-bd19-4b6b-5a19-08dd995a2267 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VFJoZ1NUeUZpRDlLeHowRGtvZDFsUDJrRTFUL2RuRHR1OGtqR29NL0ZnZUV5?= =?utf-8?B?QW1yTnd2VUdYMkZTa3M5akswUno2NDBmZUlVYzFSQTFkbkwydm9LMkNjRFAv?= =?utf-8?B?d0VMdnE4SW1Bc3B3SUdQZmNWOHFsN24vUTBYeVQzb1UxVHp3UnFqTFNpNDY2?= =?utf-8?B?ejIzZDJnOFpkWTY1MmZTYzQxNlhpUVlBd2FBQVhic2JSMUkrdWdXVXZlQnJT?= =?utf-8?B?ZG84bk5meU55N2VRaWxqbkZRUzl1S1BhMkl3MURqYUt5b0Nsd3FsTSt0RWdX?= =?utf-8?B?MGxROTRTSkNVMlJ2NEhvMXJDalNrcTlsNWVYNlBjbWpsSFVQemdGYW5DVXF2?= =?utf-8?B?YldaVXB4UFpvdkQzMFNZajZLbkpFMGZnYjVtRy9wOXpOalorbDY4Y0tnRE1w?= =?utf-8?B?SHVMREcvcEVwZEVPNmFDQ0NKelBPSG1VNmJZWUw4ZWs4TGVMSGlGM3JsVmNa?= =?utf-8?B?TUwvVjVhRzNJbXdhdTNpNm1ZenA2eW4vSnByakhaYWpKcHUwY1FvNDQ0M0JT?= =?utf-8?B?ZnRUYzY2YXBrTk9LRDJMZXViSkJva0lSWGlPTkRyRzI1OVFVR0pBbzFVV2Yw?= =?utf-8?B?VGxQRnRZeGk2TUdLdDZvY2lvMHk5Q0FtYTVUcklqVmJwTVY1TkFqdkx0NjRw?= =?utf-8?B?Mm1yYit0dmMxRm9qdGlsN2w0bXZXTElQQlRaNElPa01kMmdxN2gvZ0hmeko3?= =?utf-8?B?bXFNNVN2L1M5UkFDL3F2QmdMRHZmTjlPeHZ1N0had2krL2ZUVEM1ZjhOV0dG?= =?utf-8?B?Z0tJVnBPblFZOSt4R2J3dVFwMENheDVHTkFqbDlzM0FldmhPdkpGQlptYlg0?= =?utf-8?B?aGw4UTFldnh5Qkk5eG1UcXFGdUxUR1BBelRtazFpZkwyRG5UTG9UODZSV095?= =?utf-8?B?MWV3dE5UTkVEejhoYWpXTGtHVDd1RmRJUkNGYzdQYjAvbXM2SVl2OTB6akFX?= =?utf-8?B?a2hjeE9HMlp6cmVFSzBDU3FwQ1lqcFhrRkF0SUl2My90Tm03YVdkeU9XKzFy?= =?utf-8?B?a3BOQXlJVmNRZElGVjlmRzVoRjZ6cWovV1Q3Nk02cmQ5azk0K25SVURXaEZD?= =?utf-8?B?Wm40WlptRngrQVVGQzVQWjd2aXlETHU2VUlpYlljQldudlNmQ3FLT0ZrUEg0?= =?utf-8?B?VUxnaXFVelBMRHdIWEVRRUNvSVZxKytKNWJCY0Y3c0U3OEhPdUNqWXV5RW1G?= =?utf-8?B?Z2FsLzB1NjVqMURjWFVHdmpIdTVqRVU3ZkRVWlRRTFZ2djFyTDRXaDRobWM0?= =?utf-8?B?emRxR3k4aXB0QmFveVRwK09pYkpKVWJsRkw2cFBWTEtyQXgrRTRLV2c0OHho?= =?utf-8?B?STIvc0IwVU83OTVUaTNRenpFNGtBeThlRTRDZFFIdEdYdnd6U0luMHlSUlZJ?= =?utf-8?B?VitDc2Y2OUpGblc5cHlGYXVKMmtkN3JEcFBJMG10V2hFSlZuUkxPdnVYRTRW?= =?utf-8?B?NmVvUDdIRi9lb2F2NHBudEpzNzdpT1pvRld5YTRXdzl2V3ErQ1EyVzBNKzAz?= =?utf-8?B?YkpiY0ZiTnRxSXZONDdGWkZ0ZnorRG9xK0pDbnRLSExTZnZESXJJODZLeC8v?= =?utf-8?B?RXg5a2hySnZJb2k3SWtndUtMczhJZ0lYWVdXcXRZWitPQkJHU00vU1lNVVlX?= =?utf-8?B?L2hLQzQvN3pSQ3FoblYxQ3V3ektwVmlHM0FaUWlYenFnMzhuejJ3cGQ5WlAv?= =?utf-8?B?L1JvdzRDZFJYMnBBc2VFbERBUk5KTjZucTFlSW5wV1B4UVdwc2ZNOGZ4aWQ1?= =?utf-8?B?V3ZRWldZU0cvRyszSkVMTjYzT3F5REdFUzBZVFBJRmxZbVUzR3JiaFNUR2VX?= =?utf-8?B?em44V2hlam15Q3lmZlFpWXdoNVVBbGVIOUpIdmJaRStvRnJGOEVTREY2OVNn?= =?utf-8?B?RElLeGdUNm9lL1VQMnFmaFZ4R2ZwTWNVZWpsc29YSlhjQ1BvTm1MR2JpZStX?= =?utf-8?B?RXU3RlcyVDhlcm9sOTlEdmVWUEVHQjV4aDUreUQvQmhEdjcvZkt5SFNqZlor?= =?utf-8?Q?j97nNgl7+BMl9KMQutUann8uBUs79o=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(7053199007)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVoybWpOZHFOdzJBV3NydzdTMUcxY1hnY3NlSXRUa0FIb0pSTmd4VHkzL3Jq?= =?utf-8?B?Q2pyUDh2OUduTEJGZUVnUStlckd2L3BvbGNBR01PekY5N21ON3VRNVJ1TFZ2?= =?utf-8?B?eU4rQ0diMkZQSksrd1B5eDUzekZkZ0l6NUVIQk1Jb1B4cS9xbjMxN2M2eHFK?= =?utf-8?B?Z09MODNZYWhmelkwSGFTcVNKRms2cXM1ODVXbHpsL2tDNWRubVcxeXZld09w?= =?utf-8?B?TVZ0cHljQ1VLM1QxenBndzVOSEgwTXJwbXBzYVpNeXJyRDR6VnBxZzlYTVVI?= =?utf-8?B?MzR5ai9qZ0lOd29nMnFESWtYQWtWTjA0K01lRVhlUkhxUC9QVTNxc201VUIw?= =?utf-8?B?dnhxMDNYcXlxSzR2cmZxd2pTYnJxL2xKVXJINU1pUkNUMHVkRlhaeVJLQmlr?= =?utf-8?B?Nmd4MGR6aXg2WkpEWXJnT2I4QWhsa3I2ODN5L1ZmZGVGNllyMGQzV2oxSDZX?= =?utf-8?B?eHVGUG50Nk41eDFEajRVelF5OE5iSk55K3F0STdpVVNHR3dSNllteTJZVWl6?= =?utf-8?B?Ykd3KzBPMnZIOTRObFFZVE1WSk5neXE0Ym5MMFBYRWo2QmVsT0plWWxEVlFp?= =?utf-8?B?Y09BNHNOUE5qeWdqYitOSmhXUjl0L2Vza0toUXZZaW9FOGZHWnNsR0x0cTJ5?= =?utf-8?B?aVlsMzlkY3RQNWdTMU01TCt6YXd1TDU4QVBTUWhLSFIzSFBtb1FlM09vOVhE?= =?utf-8?B?OGZXOGUyYVYvMGFiZTNvVFlwQW9aRWlPWDVyWHlmSzhRNko3NzhXU2dtWGN6?= =?utf-8?B?M0k3SVN5Nng3V2piQ2RqVVRVNmZoOE9xMU5ZM29RTFBqSUJFZE0yR0JRNUJ3?= =?utf-8?B?Zm9iQ3d1emYxVFpocFRQbFJjMWEyWkxhbU1Weis0ZHpuVFdTbnJIR0UxRlpH?= =?utf-8?B?eEVadjVuQ3ZVUUxnZG1SWk4rUmtBNHowVTlaclk2TDNLQTBIQ1U5VFl1eWNs?= =?utf-8?B?UkFybGowSW1zVy93L212R1NGQWNZZ1ZXS1hkWkNQV0JzZVEvaUlvRXpGK0lu?= =?utf-8?B?SnY1WmtYMXBlV0N1SVJDUkNJMjh3NUk3Qk1pOUo2KzVWVXdhNU9DNDJqQXVk?= =?utf-8?B?T3BkWE9Kb0FEdU54ZmFZdWttYXoxdkIxQ1FyZkNHRnBlYU80QVdaTTJtTWJp?= =?utf-8?B?cmx3eGs5RzVFaFJZK1IwK3M5c1orN25haEl5SU52QWprWWJzRUd3QVpOZ3pR?= =?utf-8?B?M3c0dm9Ia0h3b0dmQnZiZ00zUFNNSVdIMno2WVFZWk1sSllsYjRPOTE4Skll?= =?utf-8?B?SXA2K056V0RreHFWaVVhRmVjYURoVEtpdlNFOGs2clBSUUg0VzB6ZUhjZzAw?= =?utf-8?B?WXNUZzVDeUd0QThKbjRZVDA5a04wMjB5dk54S20xZ05rTUNzMjZrZEFjVmUx?= =?utf-8?B?RlUyaVIybWhWcFFEOFFZaXd2NWJLTHZzenFRMkVvUHYvSjU0N1ljbUI0UTNQ?= =?utf-8?B?MC9FcU9ENUx5QlVMS2I5SWV2SENGeEhxNXYrNERZQjcvRlBnS3cwNmRkLzAv?= =?utf-8?B?THRMaDBaTjFDc25IblphQkY2UGhsOUYza3NMZWJxUnJFWGRHL1d4dloyVVJT?= =?utf-8?B?N1NJbGhCOEZHK2N1L3VYWEpoQ1BSc0w2enpOenJDMWtYNk11VjdrcXBMN1Va?= =?utf-8?B?ak0rSTNqcWdHS0txbkpCWENRL2dFYVNGVUNxenhmUkYrejJpVFRrVVFxdmll?= =?utf-8?B?d1YwV1VKa3RNQ3dBYWRsdWI3S1NXb2tUM3lURGh5YzYwcjJCNCszN3BRYWNT?= =?utf-8?B?NGVTQzFiQlE5VGNkZk14Yys0dDAzMnROejRRcCtBNVlWbkZ3djZPcUxnc2ox?= =?utf-8?B?UEFUWE5uWGlUOWFDTlZxb05Kc0lJRW1sWjFiWWNWUW9sSmxJYjBuZU00UTlC?= =?utf-8?B?MkNUN2pNOExGeVhsR2xESmpBSmw2OGxiU01xRGdkN24zMUlxdXplRjArclVY?= =?utf-8?B?VUJZbGpWZmVFbTRnQXBoMzJIdkptcTIrZTdWUTVwUTExZG5id21Scm5UUERO?= =?utf-8?B?c3dxajMxaDYzY3ZHQ2NwdTd2MjVxdnZJUzMwYkhUejdTcXZFK0JYSFRsbk1W?= =?utf-8?B?UE1iUS9Db3YxU0pTbk44Zm5nWDhCbGNHbUpzOXVOQ29xdkhwUlhCeHgxZEF6?= =?utf-8?Q?EjCi/y5B/rebR+OJK6OzpcaJO?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef19b122-bd19-4b6b-5a19-08dd995a2267 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:36.1638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +/PbSi34zE3iInH4Pq1Zqqzx5AuP55KExBv5ZRwAhplD0xWobck3jmJ8cFTAkgNQXEJTh7EkABYoPFL4Lhagvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 From: Robert Chiras Add compatible strings for i.MX8QM/i.MX8QXP platform. Remove fsl,mipi-phy-gpr from required properties and add new reg space, since i.MX8QM and i.MX8QXP use dedicate control and status register(csr) space. Keep the same restriction for other compatible strings. Signed-off-by: Robert Chiras Reviewed-by: Laurent Pinchart Reviewed-by: Rob Herring (Arm) Signed-off-by: Frank Li --- change in v5 - none Change from v3 to v4 - use MIPI CSI-2 - Add Laurent Pinchart reviewed-by tags. Reset description is not very accurate, but it should be good enough since use SCU reset. SCU reset do reset for PHY and controller. change from v2 to v3 - use dedicate csr register space change from v1 to v2 - remove internal review tags - remove reg maxitems:1 - remove 8ulp part - add 8qxp compatible string and make 8qm failback to 8qxp - limit reset and power domain number to 1 for 8qxp and 8qm - remove power-domains change because 8qm/8qxp only need 1 power domain --- .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 38 ++++++++++++++++++= +--- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.y= aml b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml index 2a14e3b0e0040..3389bab266a9a 100644 --- a/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml @@ -16,11 +16,19 @@ description: |- =20 properties: compatible: - enum: - - fsl,imx8mq-mipi-csi2 + oneOf: + - enum: + - fsl,imx8mq-mipi-csi2 + - fsl,imx8qxp-mipi-csi2 + - items: + - const: fsl,imx8qm-mipi-csi2 + - const: fsl,imx8qxp-mipi-csi2 =20 reg: - maxItems: 1 + items: + - description: MIPI CSI-2 RX host controller register. + - description: MIPI CSI-2 control and status register (csr). + minItems: 1 =20 clocks: items: @@ -46,6 +54,7 @@ properties: - description: CORE_RESET reset register bit definition - description: PHY_REF_RESET reset register bit definition - description: ESC_RESET reset register bit definition + minItems: 1 =20 fsl,mipi-phy-gpr: description: | @@ -113,9 +122,30 @@ required: - clock-names - power-domains - resets - - fsl,mipi-phy-gpr - ports =20 +allOf: + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8qxp-mipi-csi2 + then: + properties: + reg: + minItems: 2 + resets: + maxItems: 1 + else: + properties: + reg: + maxItems: 1 + resets: + minItems: 3 + required: + - fsl,mipi-phy-gpr + additionalProperties: false =20 examples: --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060.outbound.protection.outlook.com [40.107.21.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EC3229B780; Thu, 22 May 2025 17:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936666; cv=fail; b=Ighw/55720Rul/Ge5yKmSobnulmToBrXVLRh1eT9URC1TNu2A08pKEdRpyXk3f6LOxWymiipF+Ht9XV38VexP6ZUYJecc9YOjegwxivThEgMW2YrRUx+pSOlYQ0b2zxonc+LD0mL5xYU49fFvi8/e0msOuXsYtl9RklQYZa0LgU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936666; c=relaxed/simple; bh=BbYVA/dodS+lHlXVqhUCslwGlN1E7Tl/NRVv5MOVQJI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Hks8qw2EnOxE7x4+mUvWYfszvG4crtWirLTyo59ooH8SCeayNQndqiRgx0Gkrbmzm+8JqPdkzTm+ySkP9WRFmvE7tLtJu9qeug1px8h51KXzbVx1+3KG/9WLOLGKenAETHncJwxWq3Ecqtj+EGJE8LaKONIi17/AlBxmArQ2sj4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=XeJdtmaO; arc=fail smtp.client-ip=40.107.21.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="XeJdtmaO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iHNkOi17zn/Mp3pbVUYB/S1Q4HjgggZ1FJxR1S4Uy7BDta8ge/xnRTSnTnOnNKb7U1NbGjzltnXEtM0MmYybA+RFa32f7RLvSqY+JQYPtkFbjT+uGKiV2zzekn4JLM37yTXZicre7wnJqIabRRug+Eu/VItxjh5+aMHwNTwh0Bp4L4eHBpnWeC3nj3OWg48kha/VXj1NCBlAwGblBH+MeBEmV4kiTwET8ml/XYKzSJP6tbXMcF7jAp668VyCOTQdCIXyKfHA689BQQ5CJSbgL70J6Nq+i7WoVGn0WFON7/DYNX78HA+MVQygjAIjAxq8+nU6ih0cy0GO1DcTvdNOBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xyj6nzmMEoKA8hpEHVPHZ8lsoduUQUv0lukSfgLGyw4=; b=RgYYy0Kb4/hTQzCeyAjNglXq9CCa12vNt3hHfqOizLdjRh2F+mYhTolRI/xrL6exbZCPdWlmiqx/vqlWsZub3dDVudSoINGmOsPxqSRhfjc7rjAlIcfM8TIKca08FEFs79ozedls2qxV2ElAgRJvr+XJNyb3Tw5z8dlRGwsTLOVxIukNKvOKlrQOPDVytraZQYuN0KBvcdpL79lWPmEUYK+D/6+GZASpCT//mrjHzjreBSwvuHCvQoFTanRhocxBFVMzdMLGbwAMhDp6JzbqnU6UkrW1GNIHNu+9Jn0oVAXU8lwUMQ6YD0bpcnUv31OSdZH2ph8+mVEyxk6TQBjULg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xyj6nzmMEoKA8hpEHVPHZ8lsoduUQUv0lukSfgLGyw4=; b=XeJdtmaO8XvoY0dVf9P/F0Ge42N9/TH7K+KBKB9PXvywcoWeSq5yQ+LVh33loaGBcQgZPorXAFtNG2rIXCIZ3UNfnakhKxDR8aMZMmiaPPHvYzt/tbmZfptYYIsYc+PbzAt5w0+8kGvoNKy28Nn5JkjP0puLnTrzTKZEiGzst/hnNifXm43PZgdObuR5V5NPn3d1DyyaSCnbyMOkPJ8KYKeG4+zLbRyFDMUHfA/Xgn6Y+AIyl5u4JKWuXQNc8c5a6uBGbt2x54TmEtifxfo1C2SnGykK7c+Orjb0zK0A1jD2TWkGXXDeuKY9bShj5dko3y2yobK0+JctS7JoxgDjTA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:57:41 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:41 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:47 -0400 Subject: [PATCH v5 09/13] media: imx8mq-mipi-csi2: Add imx8mq_plat_data for different compatible strings Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-9-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=4436; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=rC0dKkjRxOYFvadzTuB0UEFSHcTAwY53ZKHtb+2qn2U=; b=mDrb36cEZRqIAmn5ELKmlsP/NfD3qAh/ou3OyNKiHiVQtd14grx1KpNE3OvS7fYR/MIaZrld1 /aGsJi83oRSDc3c9UR2KB4koeXMwcKZ42TkgOmMgt5GSouvN3P05WaC X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: 9980e99e-e856-41f6-5f17-08dd995a2566 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b2hVVlJ4M0FseVZvb2RCVTYrMjE2cnJXKzByV3U4ZC9uWTYxbUd2OVhDR1pX?= =?utf-8?B?N3hBOFRQeEJqTWVTcEZhSU1DQmZ4TzZ1T2VBd2ZkSWNPdzVaUTJ6aGFyT3Aw?= =?utf-8?B?ZnI5eHFmc0hsdUxtZWVpV3JBMUFVKzEyRHdvaGxYQ1dUV2k4dHNUM3JxZ0Ny?= =?utf-8?B?TlB1d0I3MDlFaXZPNGxCUGVtKzFjV2JDSVY0WGNlUTZ2alNSUHk5a3pUVzFC?= =?utf-8?B?ZWZ6YSs1cG1wZjVDcmZpMnZyZXZITkRWODBvU25WNGp0RUQ5ZTRZUlZReDVh?= =?utf-8?B?REV1V3RXS2Y1c1pvUFNLQW1MNEQyNEYvYlNBb2s3elpYTm5GZmtIZ3JpQzE0?= =?utf-8?B?M1dXR09YaERHdENzVkx4TURhamMvZlVQUDNKZzFpSjMvdFh1aFRiZE0wTTND?= =?utf-8?B?M0lMSjNwQWxUbnNxYzQ0T3J2ZTJPSkZIOE8wMVo1T0NEcFVNMmhISHlOd1B4?= =?utf-8?B?dnl2M2tkaHVKb2JXL2VDaklDZ2Y1ZTQ2WndwWjFLakF1Q29tWnRrMUZ3NTRv?= =?utf-8?B?U1FrdU1HWm1PQmxYWDh0U2NKbEJwRXBKL0xhSGE0MlhRajcyVXJUODkxdTFr?= =?utf-8?B?Q0h2eTJ1cnJqbENWZ09menI4MXAwR01FRmlqcEwrckF1S20vL09pR3FUVGJG?= =?utf-8?B?ZGF2NjR4SFpOTXVqQXQ1eVA2SStyZWxLcjVZSXhEZDVkY0FqOFRiQjFhWE9W?= =?utf-8?B?TExGSW1FRXZma25tdnF4cnlMTE1tMGZOYXVZS0l6NmN3YjUvb0EydlM3ekZ6?= =?utf-8?B?bVM0QWt3VlU3T2VDSUMzVXk1L3Y4VG9BMjFrb2VTUHRUcUJDN3hscnAwOXpa?= =?utf-8?B?V0F4MVZxZVpvelMxWUdBVGdyNkJyK2JLY2ZIS3gvSkNVdzBudnVEZ3BZWDFt?= =?utf-8?B?ZUJkQTJEOWJwbUEyZ3FBQlJiOThvV2hmTElOTDNSRlBYdnhQMVhFcnNsYmxx?= =?utf-8?B?STJ5VEJZejh3aWlUbHgwcW9WSlBFV2hoa05UZ1ZLK2ZFUmNhMTJaL0Evdmw0?= =?utf-8?B?eS9IbEc4VDJRS1NpbkFxVEp3OGlnN0VrazRUWjJaMjZlaU5rOG0yQ1pBUjBL?= =?utf-8?B?VGdCajFyKzN4cTl4NDkwcXlKWDN4MjVtbnZSRGlnTEtMZEdUbWdrdzc1Tkhv?= =?utf-8?B?Y0srS2FOVC9nbE9jNVk0S1JIOXlYV1FLNjBFL1FPNUhNRE5JaHBKS29YejZR?= =?utf-8?B?T0lBdjZrVU5GMS9JNEtyZDNlVDUvTXRBN1ZTMUZkRHJ3S1lPZEU0eDNwZmhB?= =?utf-8?B?dUlvQUFnUzNvSGNDZmlrK2ExU21TUDZmbjg1c1dmZy8wa3JYNmp3TGNLS241?= =?utf-8?B?b1pkQnhDT21wZE9JSGREVEdxZFExR3IxdnBJR2FqYklmeUV6MWV1OS9Id05R?= =?utf-8?B?OE8yR0FRTVVnWmdpby9SQjZvaGxJN0dPSjBOM2dtNk9HVzVCYjVlM1B5S09Y?= =?utf-8?B?WEtrY2NWeWhQRWJJUDNHa3dISkVrSkxYNjFTc25PNUxLeWs0cTI0ZDBTRjNE?= =?utf-8?B?MEtNTk5VZlFURTB0c1poUEJ6R0phb081TXI2d1BZR2ljYUorTTRKODZ4QzJS?= =?utf-8?B?RE1rRzVoZnNiMFFXYlczTWpmUVJieXF3aTYvcHNWN29CdGNmWHNIdnFuQklT?= =?utf-8?B?TVJYaWVzVmJIZE5qWVF4Nld2N1VKQXpRNU9xUmxXQ2JDOFZoeHVhWDk2c0pD?= =?utf-8?B?a3JRNllmSFBxYnhCMHRSdWlrR1hJVS9QSmhIZ202MXY5THdGRTBRdkVLRkR6?= =?utf-8?B?YnJqN2s5SC9vM1U1L01LaWtiUWo5MC9mSjRLOVlIOGZ5Z256ZkJyMjZzZTd6?= =?utf-8?B?SlZRWkdIMmxaSmVRQnUrbG94WnBmSGVaRkxNYkg2R043a1l0NWRKTzVnblYx?= =?utf-8?B?bWlOMnU1aFgrVDFJNUQyYkZrSlJ3eTVUU1Bwc2xOZW9sY3JNQkt1M3J6OGFK?= =?utf-8?B?YXF3UEU3d1NOUFN3U0pGdC9va1QwZlFBRm5oMmMwK3hGTVdtQWUyazR5VExB?= =?utf-8?Q?iV1NW24onz8iopVpvj2zddOQPosrPY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGVEWURoaEx6Qk1aRkNBVjA2UVFxOTZKUjlnbC95aG9xb0p0R1lwdkRJUmQy?= =?utf-8?B?MEc4MnhidkdXRW14a3dEakU3eEdTMElNYnByOTA1MkZFWk9Oa1V0QzNHaGpx?= =?utf-8?B?blRZTVAxaDhKTVBFM21IbHFxWHQrRlRNcmJ0WGdRYjB6R3BmQmZGOXNQYXJn?= =?utf-8?B?TWh6dkFkSTdWZHVKOHRKL2tIelZ0M3hMU2xYSitFRHlmK2lac1lkOUVId2tD?= =?utf-8?B?VEltNUpEQjE5eDYyK1JMMGZVaUl0b2lpOERLQW44ZXArYVhVNkZvUGh6S0FR?= =?utf-8?B?SjVld3c2bWp5L1JEbjQ1T2tKdTQzTjQzUDQ4T1RFN2lMNWtXNHZpRk9hRmNu?= =?utf-8?B?T2ttZE5yTWg2bTJzR1NLOEJoRk8xMzFndzg4L3RxcGJPNzgzZ1RxcFA2U2Fn?= =?utf-8?B?cXcyQ2hKY2xRNW1ORExIdC8xODBDNHdaMit4enQ2VFZRSGIwOEN1SXptaVFm?= =?utf-8?B?SGswNDRmVDc4ejhEQ1VJSy81Q1NKS2xSMWZwREUvaTZIQkhjM2c1RXdQUTRj?= =?utf-8?B?VkdvOUFhdzFSendrQWNPTHVjMm5MZ2d4YzdFdEhiZm5YM2IyYS9FakdGYVlG?= =?utf-8?B?ampTV2dycnV4eEtCSW5IQXRNTmI2YXpUT29sOVNGLzltYTlLUHYybmk0cHM3?= =?utf-8?B?MHo0c1JCTVBoQU5xOW1qYTRNY2FUaU9lc3QrUUdSaWJyMHdpanZBem1KM0Y5?= =?utf-8?B?K0JZUXhhSkZ1T3haWHBhRkNQa1pKRHlOeVdLWlBZZ0ZOUEFkQXJGdmtwZG5J?= =?utf-8?B?KytxR3RhaTc3MWlVVStVdlZNcXdrM21PZ1NydUJnaUloZTZmRFgzOENxTnov?= =?utf-8?B?TEZYNGdQcUl3UWJXeCtaRFdJNkhOeDF2M1FIUm5YbmFicEwxWG5JSUJMbGJS?= =?utf-8?B?SldURnZXTFRmL0hxRlBqRklWdi9VaE8rKzZvTnd6RHB4ZzBqVUxSTEhsMTRY?= =?utf-8?B?WWFDMmFPWnlIZVBEMk12bDRteC9zNVdKL0xRa1hTUkMrS1EraFdjL2pFTkhy?= =?utf-8?B?YkhzZXRQVkc0QjdFMUlKT3hPWllFU1JjVE5BU2dXcWp5SjlndXVGR3JWQ3Zq?= =?utf-8?B?QUNZZTJQdWxTbFByaEIyeVlYdTlHbXY1bG9uRnJhOEh2R3Z4cHllcWNvcEUr?= =?utf-8?B?UUErZFAzNkxDU2lGaElZVGV1RWRBYk8rWW43T0czUUxGRHVIVmRyYUpBT1Ur?= =?utf-8?B?YW1nc0lIRENrZ01SclU3TEdwY0IvREFsTXVQQjFtSWdrV0UxMVY3K050dmVQ?= =?utf-8?B?U0JPWUlDYm5yVUpYbTkvcEhsSmliMEdCSGtPVThmYTE3bUtOcStISTFBRENk?= =?utf-8?B?VGtKMjlqM2R0OGM4dThvN0hkdkJFTzg5SE1MVXFNV2U1M21ORzZ2d0V1eERy?= =?utf-8?B?WWNJMFVjeGsvRGJCZ1daTTNTeWlGZXJrbWtlRVhVVWlrWDhxVWpLenRvbHMy?= =?utf-8?B?akF5MWgxTFY4bUpqY0U1akRVaDVZTVdqWHVKc29wM0ZCVUlnR1JoeWdpaVBy?= =?utf-8?B?RzBKS0NNNDFiNlk3dFVVUXBETkhaUzJpYjZMSUUvOCtqVUVTdVVDcGN3T2h5?= =?utf-8?B?Tm5WOHFIbDhwWXNVQzlkNy9lVlZQY290ZHAxNGsvN0lueUJWS2NkWlpmRzRU?= =?utf-8?B?TG5ZV0tsL1lHY3NLMlVRVi9VMTZOSjZkbWVuMW0vcVdVRXFpU0hPVkVvUGhJ?= =?utf-8?B?TUNCWUt2aC9sVXdlRnFGaDBqQVd5REh1M1pKTWdOUFFFQzNqOHVxeUFNRlZ2?= =?utf-8?B?S281QmF6TmdzakpJak9OZnlsTVFDN0hPV3lwR09wbnhFdDJXWjhsNWs0MXpm?= =?utf-8?B?RVJ2cmdWTHlHUVMyL0V3ZTQwZkpMMFRsZUpIL0VKRXJUYnl3clA0MGF1Lzc4?= =?utf-8?B?a1pzWG1RZU4xYmh5NmJFcXh4eERDWG5Ocnd1dXg1WnJrbVhZSXZYMThtMkNE?= =?utf-8?B?TktlTlowTVArWnp2c1JVeU1sWnpGelVhajZSSFU3M3R5Ym5VUWs2dEQ3SXp2?= =?utf-8?B?dzV6T0Y3Um9NZFF1SU42byttN0E2YUhScHFGeldEMXp2dDVXUUlNWUFZb2hM?= =?utf-8?B?a0thdzN3d0dRRm5wVDBYVkFxV214L1JReWk1VVBDSnFnT2dMTjA5NTRMYk9K?= =?utf-8?Q?LX8i/KOoHHbIbyUyCkyWO5Ygc?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9980e99e-e856-41f6-5f17-08dd995a2566 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:41.1690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 64r+woHwxaJ0HrK+jqr5BEFQcRHh7peA6COwr6JXdYUw0RuHZo6NtsVpeZqHSVAY4KoIaBlkQsw7s4HlQoaK5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 From: "Guoniu.zhou" Introduce `imx8mq_plat_data` along with enable/disable callback operations to facilitate support for new chips. No functional changes. Signed-off-by: Guoniu.zhou Reviewed-by: Laurent Pinchart Signed-off-by: Frank Li --- change in v5 - none Change from v3 to v4 - Add Laurent Pinchart review tags - remove unused 'names' Change from v2 to v3 - none change from v1 to v2 - remove internal review tags --- drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 58 ++++++++++++++++++++---= ---- 1 file changed, 44 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/= platform/nxp/imx8mq-mipi-csi2.c index a8bcf60e2f37d..59ec7107b4508 100644 --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c @@ -62,6 +62,8 @@ #define CSI2RX_CFG_VID_P_FIFO_SEND_LEVEL 0x188 #define CSI2RX_CFG_DISABLE_PAYLOAD_1 0x130 =20 +struct csi_state; + enum { ST_POWERED =3D 1, ST_STREAMING =3D 2, @@ -83,11 +85,10 @@ static const char * const imx8mq_mipi_csi_clk_id[CSI2_N= UM_CLKS] =3D { =20 #define CSI2_NUM_CLKS ARRAY_SIZE(imx8mq_mipi_csi_clk_id) =20 -#define GPR_CSI2_1_RX_ENABLE BIT(13) -#define GPR_CSI2_1_VID_INTFC_ENB BIT(12) -#define GPR_CSI2_1_HSEL BIT(10) -#define GPR_CSI2_1_CONT_CLK_MODE BIT(8) -#define GPR_CSI2_1_S_PRG_RXHS_SETTLE(x) (((x) & 0x3f) << 2) +struct imx8mq_plat_data { + int (*enable)(struct csi_state *state, u32 hs_settle); + void (*disable)(struct csi_state *state); +}; =20 /* * The send level configures the number of entries that must accumulate in @@ -106,6 +107,7 @@ static const char * const imx8mq_mipi_csi_clk_id[CSI2_N= UM_CLKS] =3D { =20 struct csi_state { struct device *dev; + const struct imx8mq_plat_data *pdata; void __iomem *regs; struct clk_bulk_data clks[CSI2_NUM_CLKS]; struct reset_control *rst; @@ -137,6 +139,34 @@ struct csi2_pix_format { u8 width; }; =20 +/* -----------------------------------------------------------------------= ------ + * i.MX8MQ GPR + */ + +#define GPR_CSI2_1_RX_ENABLE BIT(13) +#define GPR_CSI2_1_VID_INTFC_ENB BIT(12) +#define GPR_CSI2_1_HSEL BIT(10) +#define GPR_CSI2_1_CONT_CLK_MODE BIT(8) +#define GPR_CSI2_1_S_PRG_RXHS_SETTLE(x) (((x) & 0x3f) << 2) + +static int imx8mq_gpr_enable(struct csi_state *state, u32 hs_settle) +{ + regmap_update_bits(state->phy_gpr, + state->phy_gpr_reg, + 0x3fff, + GPR_CSI2_1_RX_ENABLE | + GPR_CSI2_1_VID_INTFC_ENB | + GPR_CSI2_1_HSEL | + GPR_CSI2_1_CONT_CLK_MODE | + GPR_CSI2_1_S_PRG_RXHS_SETTLE(hs_settle)); + + return 0; +} + +static const struct imx8mq_plat_data imx8mq_data =3D { + .enable =3D imx8mq_gpr_enable, +}; + static const struct csi2_pix_format imx8mq_mipi_csi_formats[] =3D { /* RAW (Bayer and greyscale) formats. */ { @@ -371,14 +401,9 @@ static int imx8mq_mipi_csi_start_stream(struct csi_sta= te *state, if (ret) return ret; =20 - regmap_update_bits(state->phy_gpr, - state->phy_gpr_reg, - 0x3fff, - GPR_CSI2_1_RX_ENABLE | - GPR_CSI2_1_VID_INTFC_ENB | - GPR_CSI2_1_HSEL | - GPR_CSI2_1_CONT_CLK_MODE | - GPR_CSI2_1_S_PRG_RXHS_SETTLE(hs_settle)); + ret =3D state->pdata->enable(state, hs_settle); + if (ret) + return ret; =20 return 0; } @@ -386,6 +411,9 @@ static int imx8mq_mipi_csi_start_stream(struct csi_stat= e *state, static void imx8mq_mipi_csi_stop_stream(struct csi_state *state) { imx8mq_mipi_csi_write(state, CSI2RX_CFG_DISABLE_DATA_LANES, 0xf); + + if (state->pdata->disable) + state->pdata->disable(state); } =20 /* -----------------------------------------------------------------------= ------ @@ -876,6 +904,8 @@ static int imx8mq_mipi_csi_probe(struct platform_device= *pdev) =20 state->dev =3D dev; =20 + state->pdata =3D of_device_get_match_data(dev); + ret =3D imx8mq_mipi_csi_parse_dt(state); if (ret < 0) { dev_err(dev, "Failed to parse device tree: %d\n", ret); @@ -953,7 +983,7 @@ static void imx8mq_mipi_csi_remove(struct platform_devi= ce *pdev) } =20 static const struct of_device_id imx8mq_mipi_csi_of_match[] =3D { - { .compatible =3D "fsl,imx8mq-mipi-csi2", }, + { .compatible =3D "fsl,imx8mq-mipi-csi2", .data =3D &imx8mq_data }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, imx8mq_mipi_csi_of_match); --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2081.outbound.protection.outlook.com [40.107.21.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C60C29B8DB; Thu, 22 May 2025 17:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.81 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936671; cv=fail; b=KoXjdegrhyh+tdPOyGlfmOGQfGodkxW6MpH2hJpngqxZCjNtslhFcCGYPq0RqFYN2axiR94jv3hZ+8wqkrC36NCS0bawtwUpe160pCYlnS6ZLZT1i5nJXWyP09y+yBBJhTdkc7q7pPSlLZNgF0+YXmWEDdFfVUh9j06W7Ysrf74= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936671; c=relaxed/simple; bh=FPa4YzYlpLsluVUau8kaPkuqmo5jDaC+9IpQrQmhdAE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=m3vAO6Cv7UROvhATaPshnzuxNpP2RpPesJfEXbUlzVZsxVgTk1U/ESOpVPj674Rz0D/oXJlE9QEL3m28EvBG3qfBtzpqXc9YDpeySMgmw+fHrZazeMwiLs4rifGkWp/OaG7nRugxcAAzTffVc+/iM+mcIIkD0H2ZrGSQJuLinW0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=jNQrgQpr; arc=fail smtp.client-ip=40.107.21.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="jNQrgQpr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cisLzvNniZLuzUT6pYGvK/230WE6g/O8SDT2rzC4JE/aDGILolQj2R4RHjrUqkFz0BXqJRHDGV7HtyQYH6DYJFd2RMF7To1GQKUpShS1j76DK3vXo10p305Eb4gyMSUB5NHTPUOCt8+FsHf6svAzKTYON+YgzDhCMlWNSyR44SUfIfMeqCfX0+k/p3WZGSSfMnGhOqKRy9kdv7yGvjlzJIILm76thJsuayGu+4PLIXYFlKVmP05C10HpBoXZe+M+tQzgwjPr2981yKbn5ZuRUAeciavS2+R5EHWftMqyHWTK3qqPHprESQwqXcfUBQHPjtyIiTkuTJo/RR5RQqyC+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/MMt3cwDxpKSObS3qUWZGqRJJRxSNYTh00DQoNXLMuc=; b=qVVTReSD5tuIqKhaevzlr2QtslDbUST4PUdjlKK94f7AEu6GDYKdUK38nL+nqLk/ENIBJ9VIYdvr+FKgI3Dwef+9UBvnU9F+UXU1vcxsZiA1ujMKsSbeMyfsdwO6z9W5WmUep5v5MPpRaI6IazTZAWPOsIu0/9CV+FNIvbRlD6axWU3Xxq5NnteuXr530lCQh2uEbc2I/nRe+NC1bm+zBJNlv9tm9fuw8++l/z26RfSETk42Xz3h9gtikFLunz+ZEHrpV5/2PTxQKsmWb371vMFrfDLboPs3Y7kRQmnPUopMjpspQPQbyJrdukCBehwLra4VobWde37KOrUnS6db7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/MMt3cwDxpKSObS3qUWZGqRJJRxSNYTh00DQoNXLMuc=; b=jNQrgQproRQOPyNk35ETmBKCnZW/uELJW4Pm03W3zilYkn1S4TItaHCgocWZI0Bgo5wOJI2SxHAdrwpp5wYm4xojzJj6wuJBRgqgHt/elTZJRwFYXmSg6KFAt8+I2qkOVWLVDxxXN7De63HfHS4p1oRMM3HOKt3SJ4BHQW1lzOs/r3SipYmZ86D+zIVNjA39B+U2lEqqTaHej4X3MRAFyRKWlxTTtXsK5Sw+5760TKAA+Sn9MCGcGgQ/YKH1tD02dZxwap5ZR28q9AAfQtT2D5HQJh+vWIuQgnIGDHdOwHkJXg5h0fP4DLkPYSvVv2qnEne5cPZ/m5YNqD5/pI+sHQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:57:46 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:46 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:48 -0400 Subject: [PATCH v5 10/13] media: imx8mq-mipi-csi2: Add support for i.MX8QXP Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-10-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=6189; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=FPa4YzYlpLsluVUau8kaPkuqmo5jDaC+9IpQrQmhdAE=; b=43RmRaZd/pPjCZ1Xh/WtGWTMTBIFQwxsYHgOPtkAUrgsyv8Zo1GSGbW3attfaWJBvUJmPwYXN nyxDjZP6JT5DPIsg5u6W6BHZ0cwJaVTtLo9fA9B7E2k04O3EuXnjPpw X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: ef1d61e6-4b75-437a-19b7-08dd995a2858 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QWJZQ2NLcmtlTk5zZUlIZjVxMTRYdFhETERaNG1pZDAya05kNVRZZ3JwY3dR?= =?utf-8?B?TDJGOU5yRjVrK2kvWmt4RWlLV2pmOVBrVVBHVVIvQnJpL2Z1d0FQa2JYZ2tw?= =?utf-8?B?ekJORnRpcG5pQ2RlU3lzOGZXUFVoYXE1N0xBRERNYzNXMURyK3dOQkVVeGQ1?= =?utf-8?B?dEtsMitWalZ6MzFmRjZsNFBpZFhRbW50Sng4QnMwQ25IR0JRVDN2cUtiU3ZM?= =?utf-8?B?SmsrS29lQ096WCtVSEQzeXdFa0pJUmJOd2RwblVRWGJKUHc3elNaZkRHc3pQ?= =?utf-8?B?bEkvVWk0WmxSZHVqelFaRk1ZeGQ1NWZBSmZUK0FLVlNyZGozY211NXBELzZE?= =?utf-8?B?ZTE3aXZNNm1SS1YrUWJ5NGNnbnpxUE9VcVhUbUFWTGdhUHZWRCs3L1ZmRndS?= =?utf-8?B?NytkV0F1KzJzd1RYdTFYa0c4bGtYazNXUDVETG5GWEtOd1dhVHVxVjB3WDFo?= =?utf-8?B?R2NCbFh6ZnJhWjhsUG80U2lUOHZrb2FsMTc5RTlURnRucVBVYU1BVElpOEhC?= =?utf-8?B?N2tPT0E4RWtoL0hERmdJMlNQOG1tVzdzdHZZREhPTWhwMTJMV29jUmx5VjJl?= =?utf-8?B?VXR5V1NRV1FtcTZTZkhFZlByMyt1WE1Gcml3WWxWSXlOK0FYRCtIUS9jZWJm?= =?utf-8?B?RmNVcWVhQklFdjVjN0Zrb0RnU1B1U3FRanJ6T01JRGYvanhEamw2Q0YycTI5?= =?utf-8?B?Ty9OTHc0RW83eGtWU1hxRExoMTlyc1V1OWxoWUdrOU9iMFZKSmxGSFVMMEJ0?= =?utf-8?B?WFZCT2gzdDNPM0NiUmxGU1B1alFEaThNanVUa2RFOGhtL1F5em1DcU8vWjZ0?= =?utf-8?B?cXVYWlQwekVuMXZhNUpHcjl0T0RTSTBWMlZxRUdkYzAvT3hqTWZWOXRZYkNn?= =?utf-8?B?QWpYT2k5QlNFcHppTndZVFMyR29jbTVvUFJodllTNzVzNThaZG8rWmtna2pB?= =?utf-8?B?WUFnSDZzZCttS2t0cjZuTkVZbkM4QTltNVBIaGtQSmhkd2loY295YmlzcDRR?= =?utf-8?B?Ullma3dtYkRMbk5MTTNEVXYzSFg4enhWVHc1c0hGYlhoYytxWlEvYlZSaEhM?= =?utf-8?B?MlFEUWZ0eVptSHBRWFhyTDBUUGJyU29jWDlqblVXaW9QZlliYTNlZDhsTkFZ?= =?utf-8?B?UFovYlRmYWxMZHNFZmpHeURRUm1YdDY3Q0ZaUkJod2czVTRzZzRLd0t1am5k?= =?utf-8?B?NnNJZFhVSE0yM3FRTHpEMkhRbXk5eStCRm5mMnVoakJudDJ1TW9uVVl1Yzl0?= =?utf-8?B?OXVXZTEzeTZpd0xYcHZYRXN5aWorRFRWZ2NsMi9qNWV3SzN0dUpSVzVST0d5?= =?utf-8?B?OGhCMSsyUnBTY1J5blQwcmRIWDVGOUVnT1dzOXd5ZjZLbmJhL2FlQ0hFWXA4?= =?utf-8?B?ZHl0VXpON2hKQ0VHZDVEdWV4dXlTVzZ6R21ZeC93cW1DeUtuMEVNZGFrYTky?= =?utf-8?B?YXl5VzdJT1hhVVNWVEtoaFhhak50eXBWL0ZSVlFHWk5QaU5SaFNNdGhzNkNI?= =?utf-8?B?TUxrWWM0TmlvNGo5WW4yQTV2UkdKS1U2Zlk1ZnZObndVV253YjY1SUVKTmp2?= =?utf-8?B?SUN1ZG9aUzRtZ2FoSThyYnRsUnpPYjd2ZExmakVac3Q3RWtnMklMUWkvdm12?= =?utf-8?B?WWMySDduU1NoOU9FUzhiMnorOThuVWRReXJzNmNLdVZoNVE2R3JsWThKWkF4?= =?utf-8?B?Z1NsaWdqTkJhdFI3RjN2bk44ZXJ1WWxrY3FKdVluV3pRZjJmZ00rcm5hblpJ?= =?utf-8?B?emt0WTl3YmVTNk5vYUZYdTcyb3gwejNGalptVmNicys1QzNrSFNObHIxeGc5?= =?utf-8?B?MmFweXBaS3VRb2JnM1ZUOXB4NWRyYVA4SWV6ZllNNm93RnQzbWZIam1VTHlU?= =?utf-8?B?STRlNlkzbks4a2pRQ3A4UWhaSDg3emZJRzg0bVVVdFFPbXFmVVhra1E5em1Y?= =?utf-8?B?YnZVOTM2TnBIOGRia2MyQkMwV2czYzBOcjZJT2t6dnZCdkFxdnIyRStNd1NK?= =?utf-8?Q?/vKY3uGKvlYyOOHOKW2zWlSuEZhccA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDVXNEpTY1BROXlPSXFPRVhCU3FIQXUwQnJxZG95UnZleG5FTEtqVUFxQjBv?= =?utf-8?B?bWJlam1TT09CM0lEV0NkWkN1WWxJK295V2pUdERBTzdRU1dJMzg5d01YbkpQ?= =?utf-8?B?eTVmWHJxTkozalNiNldTVVY4cEgvd2JsenYvTkpYRXJlSXNZUFlWWDZnWGNS?= =?utf-8?B?RTJZeE1tdWFpMmF6SVVROS9iL2lxWHhqbEVOaEdMWXh4eG5yUFhZditERzkr?= =?utf-8?B?cm5vWmRkaGkrRy9jeHFQU0k0dldHdmhXckdFR1M3ZEZLUzVuenE1dHloZmtL?= =?utf-8?B?ZTcwR1FDNUF5dEtOSEtjS1hiT3JUeWU3ZUtjTHEzZWlhRU1zUmFZSkZGenFr?= =?utf-8?B?ZVJ5bWdoMHc5TUR1Vi9haHpXUmRRb0FvcVQyWnl5NUpGd2FTZHoyZ294dWZh?= =?utf-8?B?Q3FtWmw5Sm0xb0JYZmN3dGxmZWlEa1J0enZhNTY2OWhOM0s3Z29WM1dkaGlN?= =?utf-8?B?K0YvM2tUMFNSQW9WZ2pmWU14enFxWkpuMXVtWHhIMm9haklzaXhCYyt4U0w0?= =?utf-8?B?K0tjM3UxaURGNUhYTDNzRE9nTXlGY0xwU3FadEtTR0cxdVVvbHJ4a2Y0RWRR?= =?utf-8?B?ekpqWk95djVNTXBZVVIyMm5GaVJkakozT0ZmNGVnWUdyRVRqZ1k2SnNGZFF2?= =?utf-8?B?dDdVYWl2dXBxNDBzUWhJKzNxWEJxYWJFMWg1eTVVL0dKYnk1cEpLT3d5T2RD?= =?utf-8?B?TVhUejZCQVZiVXNvdlRYVFdJSWMvNXlCNlJqOXZmVVUza0twS1RYbUFtVWti?= =?utf-8?B?YkRuKzRCYXVWbnZkUXZpRGVnWDFvemZkSnBKWFZRZmtUZ3dyZHJFZms5WlZY?= =?utf-8?B?UFc2YW5FaG43L0k2bVBQd0tEcDRpa2RSTzlPTU5kMG5MWDVaUFU0dlVSTHN4?= =?utf-8?B?R1RmTW1UaVBsK3R4dkZubXcxY3RoMVNyY1d3cmlGZWJDOU16bnRvYzVzaXll?= =?utf-8?B?UFk1VjFuaGh3ZHkzWEVQMFRia3FHdndEd3A5WG1QT1pvZW9Fb2Zhd1oyRjE3?= =?utf-8?B?SzBlMTBxbnJ3RzVDMlVlRTBTZUlwT1hxZVVyMURudTRkdk9UWHN4cFVPcGxU?= =?utf-8?B?bHk0UWl4NE1rWFJXODlkQm5EaFVsL1poNTJESGU5QzR1eGxxSEM0S2RZNDQ3?= =?utf-8?B?R0NkZFdWeWFCRFRwV3JBdXM4cng1dWdib3cvZm83cmpBZnNyeE5OYTUvWVdM?= =?utf-8?B?eDBYOHlhZTdONkZiSXJvVkVSd2ZCbDNuNzhMbE5oRFVORzRMOHc0SXhvWUIy?= =?utf-8?B?UnF4RlIwZXEvTWcrb2g0ZmEvN0ZqSUdsZ0d2Rnl3WU40QXVmOXVZaHRDVUxZ?= =?utf-8?B?TXh5WHc4SEh6Z2M5Yyt4UE1pZHhiNUVHdHE2alAxa2J6amdFRXNEd0x1SXJr?= =?utf-8?B?SzJVNWRUdVF2VTNhQmdYdmZFM2ZOZ1dGS2Z0dkNLSUtMNFVWajVMNVFWQnpV?= =?utf-8?B?V1gzTjJYRHE5UVlUTTFWUUYrYTdUN2p3akx0WFBIUmpJTk1XRW84aDJaRzdE?= =?utf-8?B?WWdnVFNxQ2tjYUtKNTluMlY1QXl1ekFEU3JFUEtXY0lNSUkxalJ6TFNmclh5?= =?utf-8?B?cmNsR1g3dGZvSzZma2dwNG5ISHZCaUVNa0sweTh6SzROWlZDK3ZsZS83OTEw?= =?utf-8?B?Y3NNNWIrNnJaN3pIaHpWdHFtRlUyWVgvRzBBUExWbFE1Mi9XTVpFcHkrT1RC?= =?utf-8?B?NEZ2aHRVZ2cvUnZPcVUyRkR2bFFTb0xXeUwzLy9saWtiMkVTSFVseUN6QW9G?= =?utf-8?B?MWRsM25xSlZuL1hWWFg4M0REUTVHZHltbXZjTjZRaVloREczbWxEdGhmY1NK?= =?utf-8?B?dG5Jeit5blNhelZjTllQeFVTOXcxQUNEYWNxZWgrT1ZGSk1ITDhGVEhpYitr?= =?utf-8?B?T2cxY1B5TW1LMnJXcXB6KzlyMThjTjJPZ3Z0UVQ1K0k4TWJmRVRJUEZjdkg5?= =?utf-8?B?Ykd1SzFmRHhQeVk0L04wc21JN3dKcjEzMTRldjFSU0RqeXNSNFIwR3ErSTQ1?= =?utf-8?B?SVVma0htYWFGc0M2RHE1S2FsUlZoRnRha09GdGdPckNuTnVCU3A4VEtKcHNB?= =?utf-8?B?Y2dzS3hGNnRmVjlXTFVqdC9MQXVMVUpiTXFKUUJab1dWc25UbEV5Y0lpQll1?= =?utf-8?Q?4hp0lNiN6NYMayAbo2zK3C/ED?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef1d61e6-4b75-437a-19b7-08dd995a2858 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:46.1390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Howfv+0X/ygdAMcIheZgO1P1tZS9eKpSDmPa1vcTXCy2O0u2CN0Bobrv5G1/+VNmr1QWcBrmRklJXSGvSr5Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 Add support for i.MX8QXP, which has a dedicated control and status register (CSR) space. Enable obtaining the second register space and initializing PHY and link settings accordingly. Reviewed-by: Laurent Pinchart Signed-off-by: Frank Li --- change from v4 to v5 - add Laurent Pinchart review tag - wrap some reg_map functions args - add missed \n at error message change from v3 to v4 - remove reset_delay - sort register field defination - fix error messag in dev_err_probe - fix comments - use true for 1 - regmap_clear_bits(state->phy_gpr, CSI2SS_CTRL_CLK_RESET, CSI2SS_CTRL_CLK_= RESET_EN); in imx8qxp_gpr_disable() - use regmap_write to clean register at imx8qxp_gpr_enable() - remove reduntant CSI2SS_PLM_CTRL_POLARITY - rename register DATA_TYPE to DATA_TYPE_DISABLE_BF change from v2 to v3 - use dedicate csr reg to control phy and link settings. Change from v1 to v2 - change 8QM go 8QXP, 8QM will failback to 8QXP to keep consisense with phy drivers --- drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 111 ++++++++++++++++++++++= ++++ 1 file changed, 111 insertions(+) diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/= platform/nxp/imx8mq-mipi-csi2.c index 59ec7107b4508..6501843ae72db 100644 --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c @@ -5,6 +5,7 @@ * Copyright (C) 2021 Purism SPC */ =20 +#include #include #include #include @@ -88,6 +89,7 @@ static const char * const imx8mq_mipi_csi_clk_id[CSI2_NUM= _CLKS] =3D { struct imx8mq_plat_data { int (*enable)(struct csi_state *state, u32 hs_settle); void (*disable)(struct csi_state *state); + bool use_reg_csr; }; =20 /* @@ -167,6 +169,95 @@ static const struct imx8mq_plat_data imx8mq_data =3D { .enable =3D imx8mq_gpr_enable, }; =20 +/* -----------------------------------------------------------------------= ------ + * i.MX8QXP + */ + +#define CSI2SS_PL_CLK_INTERVAL_US 100 +#define CSI2SS_PL_CLK_TIMEOUT_US 100000 + +#define CSI2SS_PLM_CTRL 0x0 +#define CSI2SS_PLM_CTRL_ENABLE_PL BIT(0) +#define CSI2SS_PLM_CTRL_VSYNC_OVERRIDE BIT(9) +#define CSI2SS_PLM_CTRL_HSYNC_OVERRIDE BIT(10) +#define CSI2SS_PLM_CTRL_VALID_OVERRIDE BIT(11) +#define CSI2SS_PLM_CTRL_POLARITY_HIGH BIT(12) +#define CSI2SS_PLM_CTRL_PL_CLK_RUN BIT(31) + +#define CSI2SS_PHY_CTRL 0x4 +#define CSI2SS_PHY_CTRL_RX_ENABLE BIT(0) +#define CSI2SS_PHY_CTRL_AUTO_PD_EN BIT(1) +#define CSI2SS_PHY_CTRL_DDRCLK_EN BIT(2) +#define CSI2SS_PHY_CTRL_CONT_CLK_MODE BIT(3) +#define CSI2SS_PHY_CTRL_RX_HS_SETTLE_MASK GENMASK(9, 4) +#define CSI2SS_PHY_CTRL_RTERM_SEL BIT(21) +#define CSI2SS_PHY_CTRL_PD BIT(22) + +#define CSI2SS_DATA_TYPE_DISABLE_BF 0x38 +#define CSI2SS_DATA_TYPE_DISABLE_BF_MASK GENMASK(23, 0) + +#define CSI2SS_CTRL_CLK_RESET 0x44 +#define CSI2SS_CTRL_CLK_RESET_EN BIT(0) + +static int imx8qxp_gpr_enable(struct csi_state *state, u32 hs_settle) +{ + int ret; + u32 val; + + /* Clear format */ + regmap_clear_bits(state->phy_gpr, CSI2SS_DATA_TYPE_DISABLE_BF, + CSI2SS_DATA_TYPE_DISABLE_BF_MASK); + + regmap_write(state->phy_gpr, CSI2SS_PLM_CTRL, 0x0); + + regmap_write(state->phy_gpr, CSI2SS_PHY_CTRL, + FIELD_PREP(CSI2SS_PHY_CTRL_RX_HS_SETTLE_MASK, hs_settle) | + CSI2SS_PHY_CTRL_RX_ENABLE | CSI2SS_PHY_CTRL_DDRCLK_EN | + CSI2SS_PHY_CTRL_CONT_CLK_MODE | CSI2SS_PHY_CTRL_PD | + CSI2SS_PHY_CTRL_RTERM_SEL | CSI2SS_PHY_CTRL_AUTO_PD_EN); + + ret =3D regmap_read_poll_timeout(state->phy_gpr, CSI2SS_PLM_CTRL, + val, !(val & CSI2SS_PLM_CTRL_PL_CLK_RUN), + CSI2SS_PL_CLK_INTERVAL_US, + CSI2SS_PL_CLK_TIMEOUT_US); + + if (ret) { + dev_err(state->dev, "Timeout waiting for Pixel-Link clock\n"); + return ret; + } + + /* Enable Pixel link Master */ + regmap_set_bits(state->phy_gpr, CSI2SS_PLM_CTRL, + CSI2SS_PLM_CTRL_ENABLE_PL | CSI2SS_PLM_CTRL_VALID_OVERRIDE); + + /* PHY Enable */ + regmap_clear_bits(state->phy_gpr, CSI2SS_PHY_CTRL, + CSI2SS_PHY_CTRL_PD | CSI2SS_PLM_CTRL_POLARITY_HIGH); + + /* Release Reset */ + regmap_set_bits(state->phy_gpr, CSI2SS_CTRL_CLK_RESET, CSI2SS_CTRL_CLK_RE= SET_EN); + + return ret; +} + +static void imx8qxp_gpr_disable(struct csi_state *state) +{ + /* Disable Pixel Link */ + regmap_write(state->phy_gpr, CSI2SS_PLM_CTRL, 0x0); + + /* Disable PHY */ + regmap_write(state->phy_gpr, CSI2SS_PHY_CTRL, 0x0); + + regmap_clear_bits(state->phy_gpr, CSI2SS_CTRL_CLK_RESET, + CSI2SS_CTRL_CLK_RESET_EN); +}; + +static const struct imx8mq_plat_data imx8qxp_data =3D { + .enable =3D imx8qxp_gpr_enable, + .disable =3D imx8qxp_gpr_disable, + .use_reg_csr =3D true, +}; + static const struct csi2_pix_format imx8mq_mipi_csi_formats[] =3D { /* RAW (Bayer and greyscale) formats. */ { @@ -865,6 +956,25 @@ static int imx8mq_mipi_csi_parse_dt(struct csi_state *= state) return PTR_ERR(state->rst); } =20 + if (state->pdata->use_reg_csr) { + const struct regmap_config regmap_config =3D { + .reg_bits =3D 32, + .val_bits =3D 32, + .reg_stride =3D 4, + }; + void __iomem *base; + + base =3D devm_platform_ioremap_resource(to_platform_device(dev), 1); + if (IS_ERR(base)) + return dev_err_probe(dev, IS_ERR(base), "Missing CSR register\n"); + + state->phy_gpr =3D devm_regmap_init_mmio(dev, base, ®map_config); + if (IS_ERR(state->phy_gpr)) + return dev_err_probe(dev, PTR_ERR(state->phy_gpr), + "Failed to init CSI MMIO regmap\n"); + return 0; + } + ret =3D of_property_read_u32_array(np, "fsl,mipi-phy-gpr", out_val, ARRAY_SIZE(out_val)); if (ret) { @@ -984,6 +1094,7 @@ static void imx8mq_mipi_csi_remove(struct platform_dev= ice *pdev) =20 static const struct of_device_id imx8mq_mipi_csi_of_match[] =3D { { .compatible =3D "fsl,imx8mq-mipi-csi2", .data =3D &imx8mq_data }, + { .compatible =3D "fsl,imx8qxp-mipi-csi2", .data =3D &imx8qxp_data }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, imx8mq_mipi_csi_of_match); --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2075.outbound.protection.outlook.com [40.107.22.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B65F229B8FB; Thu, 22 May 2025 17:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936676; cv=fail; b=L0QVflmOaoI4tAekveSQT65pkBR59FhuIOwiD4pB/O6+dp3bvLGc/oBOIUwqZTD3R2LnIAF7TkFt+N+bB0MCqV6X3qRGFwaC0sDru4F9A2WCgAb+5RWJZEbuPWA+xBPyx45Ys9w08PPCt9pAmrkoISvzVS+HWLwPOcudWk57+UE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936676; c=relaxed/simple; bh=oW5ipeKWAHmosKFFGfvIRVJLzT1z/FcSu6Yka546tVw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=qA9oP4fiGKozxg5JhgEGXJqkUD8rcF7XdLYSWWznuVCZlb6Ei977tzW+QvMNEh6qSxFl4pqCbUBx83Fwc89nTcVGUxi+8CEptouwtyy19sHiWTk8UQEwhj3v6M5ZwXLJeJOwfKBYRVGIwFYmv3pP67kmcLIIvxnAaTOCEvjMxyM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=PBk/3T1l; arc=fail smtp.client-ip=40.107.22.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="PBk/3T1l" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JYzQz1TpNLTT4ZT8VAQVLDxmzLylIJuJWT2j5LqKzw46Uk3Qk72HkzoqJoUBW3Wm8NTQOsrR6Yv0kzT97x4pyCswfGiG4vZIgsGo8j0+FpC1MY9v+hrG8nZRvCYhtpHq8Jd24A5gentV2k2nk7q6Rle2Keo6ovrcS5Vem/ZyZkGMIcCg1Q+jxc2I47JP5WXWjJOjO46LmO0PiX+x1BsBGzs0iRLdXTeND+ot0EMTWh9CenJx/e5HbgEpxsVt/aXe3SdVSURDrpZMLU11UU1ASAsKNvogDTZnVV1pyokrSEm2zKIl6sgO/evJSISmxOrA6jIESZF6SlUM0r/gHv1Anw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OsmGa4p3hq8x8QvfgwAJcxEfigVWmO2iO73/gHLBBBk=; b=ymBxbf7+t4tCUTb9zH6BS7CstJPCgNCDwCKNTq/bIuGz9m0+qNV9OdBmT/EWaS6v5LbWwgg1dsROs4Jy3mmVGEhtNerbjAWrdjKGkRMszWqzKWqNO7M7nJkmDUCfwcWnUmeER6sifH5ZgDB9VRShvntIwnoskDBiomscHwKLL5FNZC6OtVavECdCqMNKPK6KcUUhGcUdfssqzy8ckAqSshGv0VM8iS0zuNLoxX36kZJX/NUVpcHtdofo9kYgjOiAgg4RQMYhQfCH/Ktvn40YEOPKMzm9ADX77T5ZhziUMaq2/VegmtXXcNoYUA7mI4tDQvW6RTgv/BhZYBNTi+vLEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OsmGa4p3hq8x8QvfgwAJcxEfigVWmO2iO73/gHLBBBk=; b=PBk/3T1lZvDoglmiRaNVv6ixdiMPU+LfkJcqZUmWqu1Z3+zs6O2COsAAO2upH9ef1U7bq/I9aUAPeR+kV+l1ZD1MbIU67DZXCn+acW+4+eMVmRdy66e/EzHVbwoVRglut+LDIXsyU6OcQZKoK8HDatsKw4RmcDi37618N4a3hT1XPuREeMIfacLZ4b8vofNxKPlkFshlF1fLwcxnAR2cqyJOQdZVOvS/0SuIudWq3r7oHdGfV5L5n+b81doWbjAVAxuHeOE+NajNqn/JsB2frGsiVoLTo5d6VUz0n8iZiDZc6vfLAWCkNWAKfzHeD3zyPp8riI9VCiFXYY0fQDEiwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:57:51 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:51 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:49 -0400 Subject: [PATCH v5 11/13] arm64: dts: imx8: add capture controller for i.MX8's img subsystem Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-11-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=17996; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=oW5ipeKWAHmosKFFGfvIRVJLzT1z/FcSu6Yka546tVw=; b=RAUy60Wwe5S6NB8hzDCVM/fyNeu3Usc/R1zNriZYdoL+VFMqJo5xJ79LyeD3Mwh4UZhldHNiE ggGbGbgBQv7BF+5AekpUQAGuZBcYYXRvf50+5CwWcLpm0WOvEj56VSX X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: b610eb57-dcfd-4bf4-26e0-08dd995a2b60 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a3RVOWVJZDAwbHZHNGl2WCtTTTdXWHZVSDJYbERnTjVMUnNsNGlBYnpGNk5t?= =?utf-8?B?YUFWaDhycE1oWW5PRXEwOHVUdWx4eHdDMVQxcEh0QkNjOGl1ZnJ2bVVtWFZI?= =?utf-8?B?RXhINGd2ZGRvdFBtS1F2am5KdjVIQ2RRM2o2d0NqTnRPWDg2S0F2ZXJQS0FY?= =?utf-8?B?VU5kdEtxMEdXK2dud3F5Q2RKdXVUMVIxNG5iNWdMYm1kSVlYOXRWTGtNL3Y0?= =?utf-8?B?SFlNQXg0cVpaNXJtSXhXdkFjM045c09QQi9VTXVkNnJCb3dRc3FGTlkwWm5z?= =?utf-8?B?ZTc5OU1vczFjWjR3MXVvODl3ZTNjZFg3T2NDaTJiQ3NPbEtJU0poQ3R6Q2Zz?= =?utf-8?B?dTNCTElkQmNzMnF6Y1hIMlQzamZ2QjFCaUlBeEdxU21QYS92ZGEvMUlRVjhE?= =?utf-8?B?M1VaeFRqN1p1WWFiL01SamZEd0x2cUFBbmhib2l4RllRZCtkbUJiNHdyUG1l?= =?utf-8?B?OXZIMlZCL2FFbmJpaTU5czFJT1NuOUhHMXhCUWp1Ylh0UXJ6SUtEUmlFQ1Zk?= =?utf-8?B?cVVUYWxVTzU2NmZoVTZCc216NVY2Qmc0Y3E0QkF4WCt6UGJSZmkzVzJBMlhv?= =?utf-8?B?RjFlU0NVL1VhRXZQVHl3Znc2bTRUVjhrZTNkdzlicXM4NW03YytPVVpZL2Jl?= =?utf-8?B?aWM0NFF2ZG5rTzR4U3F0eXQxYXllNEZuZUVBSUlHT1RDVGE5ZUJkb2hDbDNM?= =?utf-8?B?d3ViWURJMUNveHNldmNEazR0ODRHQkthbUhFTmVTNzN6dG9mc2J3MTVxR1J2?= =?utf-8?B?SWJwRDdmSG91YTFVZUlOekFLdTVEcXFMK3h1QlNBeXF6VTNDSlVMb3YycTdk?= =?utf-8?B?M1h6cGdJTHVqdHR3MTVjMzlKMFB4NFJTY0x1UjNrMC9TMFhSbWc2ZGtwWFBR?= =?utf-8?B?a0k2aCtuOE9Gem9KKzBQNHRER3k1VERqSEthcmpHWTV6L3hrNE53TVNWb0dO?= =?utf-8?B?dkRIUERBTDdjQWUzVHRhV3BYQTBWOFRmOTZnMmdiYW1PSjVXR0Y4VFNna29F?= =?utf-8?B?Yk9aTjM1eHVUbU1ZMzFTRUsybEZRMkJnUjB5VC9uUU10NENTV2k5ek5uMDls?= =?utf-8?B?dmxsbTloREd6bkVvRVJLaVZMLzk3TkVRTmRHUW91Nm8rNE5wZFR3OE5qSm1P?= =?utf-8?B?bW1MRm1GbW5pSUl4ejhUZC9WMFBCdVVObjkwUG5YQitGamdlRkk3NENXb1FU?= =?utf-8?B?aGpUTk9uZkRsRWgyRUg5MG5FQVplWm9paVBFUzBmRmtrTXNJclJiZkZ5WHMr?= =?utf-8?B?dFdvNkJkSzdEeWZiaVJVM2VQYkF1amFTbWdNNGdyV2lJTnN3NTU3aGxnM2Rs?= =?utf-8?B?UTRuZzZxdmVHNlRocUFWRDd3R2FJN3ZrVmE4dTA4OWx0MTdsdklIejN5d09E?= =?utf-8?B?SC9USVE1bEcvUDZJYTRQRytCMDF5TGpNeUM4UVBwOFRES25ydXBuNjVXSkNp?= =?utf-8?B?Q3lxRFphRFdGM2NjRUtXM1IwcktsWVgxQkNHTE9CRzhTTXpLRlR2dTBSK3Fy?= =?utf-8?B?Z0ViZ25RMjhWbVMxS0RZWkhMcFFqNzAvbWpqdWZZenJxanFDZHA0alRicHE0?= =?utf-8?B?akF3SXRTTForQ0U4dlNQQi9XUFRYcWptb21JdDFzYUhXaXo4L1NsVkhLbTcy?= =?utf-8?B?ZHljM2lOUEFiNlAvQ0hUclkzUnc0VHRGQ2haZlowRU1SdlNnUTlGelFVU29B?= =?utf-8?B?Z2FZb0pOekFIY3N1enpPamltcjlXUHh3OUcwZzZ3clA2UE9nZzlvY2hzV1g2?= =?utf-8?B?OHp4MEZsbkc1QTdCenFJME1Ba1dYbnluL3VwYU4wOVdSUU1WWklXdzZXWnYy?= =?utf-8?B?ZEhPNWZvUVAzRys2M1RkRXp6V1Y3NHRvT3V1OUErUTQxMjlFTkpzYnpQTkZC?= =?utf-8?B?N203R3JSYktoUDJ3WW02Ylpuc0hCTXFVeGl6TVZjZVZWdWgzaXFORE0zdVBm?= =?utf-8?B?ZDdTMUFYQ3JlRkt0UUZyczZaZzZUcGFKT01LaUF6QmhySkpjcndKOWIrTlNO?= =?utf-8?Q?tLCIxO9iSyY8RLClw4sHWf+vic7CgM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnRBQUo1bERzOVdRYVQydGRxNmNQYzh6Q3d6TzkvZVVTd0hEaHdYRmk1VUV4?= =?utf-8?B?dmwwYVl4T0ZaN3Q0SE5uWlIybjNkUFBZT2s2UytERmk5ZnN2TDR1ZXNWSHUr?= =?utf-8?B?RVB6c3RwcmdVc01qcVpxdnBaV0JFaXV4UUgvZjVEcUV3bnF3Sy9rQ3BGUkdu?= =?utf-8?B?aVJFdmVjTzF1M3NqVkdPQ2VEL3hEQS9UOC9LUFdUdDU3T0xEdy93LzBuSHlS?= =?utf-8?B?TFBQcGloRnczTTc4MzVTTXZFci93VVRBc0EzTExxQjduQVU1anZlbk9zSm5L?= =?utf-8?B?aFZpNG1waTd2U2NTbVRMdThqTE1QK2tZZnV3cC9rMEtBcFlCSW9KaytQN0FI?= =?utf-8?B?Z2p5aG9RSGRrYXpwaXZlQ3NaQ1gyeTZOdmtkUmpNZkFrTHFtUDNJMFRpYkh2?= =?utf-8?B?U2FnZVNTTFI5eHI2aEV5OGdNTTlBeEx4ZmF0NXZQL3pZTUhCS2lBMGF4ZkJX?= =?utf-8?B?VC9DK1A5eHA3YytpK0NiKy9TSGdKd2lwdWdqY3ZYZWxLWGREUlpNT0dpekxW?= =?utf-8?B?SDVJalQyTjM1ZUd6R0R1UllOMVZrc3hqZFV4RXlOZEVPM1JTK1U5S2ZuRy9Q?= =?utf-8?B?bVVjOHllSXFBci9nZXNXcm5yY2drMCtENE0wR3BoNHd1Mm9DSmFxRXJ4SkJN?= =?utf-8?B?d05SL3lySjJ2ckhUc05raDQ1R21kSWxYYkxiUUQ4MmtzRE1PMEVpZXAxTHdm?= =?utf-8?B?UHd1YVFFZzFPeVRLSVNZY29ZaXJuanlCY0ZYNlBFSTdSd2swRkZiVUhCWm4x?= =?utf-8?B?Z29WemxWeExVbnlzcWs1VkhKNWE0MUVqWjdaZk5lYUFDRm9mT09CTDllWUVY?= =?utf-8?B?TlhhcmlUcVAvWm05ZXF6NEUvdU4vUG5FY0xIbk5CRXhpN0RUVFI5R3dKazdo?= =?utf-8?B?WDM1R2VocFpkdTgyRmZEWlBucStXK1lFR1JVcG0xUDRRT0Z4WmZicEo4cTMw?= =?utf-8?B?VVQzOWJZbU1RWGlqNXhaQ1hqK1VUcXExOEkxUCs0VFVBWGNnS0dhSVJ3YXg5?= =?utf-8?B?SjNOdDg5cnRnd3B4Y3ViR0lhYWI2a3NhSGJpK3RYUU90MXVYZWY4Vyt6SCtZ?= =?utf-8?B?eWdVTHc0SVdBa1loRUlVRHM3WE9iVUVESFpTaEU3TFRxU29vWVFoUW4vbURy?= =?utf-8?B?WWZ6RmlTY0NOZ1FQR2hKYW9aYWJBTHAyUFFZWHpCQTVyVnM2bnFMQVJpaWZW?= =?utf-8?B?enlqQ1hwYzViRDcyUGN5YllOVm9iUjhsNWZxZ3NRTkhMLy9kSkhQSThhRjkr?= =?utf-8?B?cXp0NmZHTHJ0VWFqWkVtZWNIOFBOWlpxMjRYRU5aU0x6elE3T2ZYdDRzbTIr?= =?utf-8?B?UFd1UWhsUnJZU2Z4bTFkR0ZUcktHUlY5cUR5Q3B4WkpjYWhpaHQ4TEZkLzVP?= =?utf-8?B?d3lLMTYzKzJ1Qnl5WHJYSTJXRUwyMkdSNUZBdjYvalE3QUx1dGdKcS9rS1dk?= =?utf-8?B?Ly84Z0V1RFFFUGMxVWQxS0tFSmVoclZEcWxRb0lWY29xcHpPaVlEZ0p3ZXR4?= =?utf-8?B?L1Q2Q2NlUUxzNXdTSldBZHNJVzRDd1R1c01wOVFLT0J3b05jS0YraXI2ampU?= =?utf-8?B?TUhuYXQrV0lpSzZuRVBHSElFdDVnTi93ejAzZnBlZCtpQjE0MjdQbVhBelgx?= =?utf-8?B?aGZuWFo4SnZIQy9LWDNRdTFWRW1LbGZOYnNKZGFlOGlYT0hSb0FUVnZxM2Ns?= =?utf-8?B?ZG1oWGxieG9FQkNyK0FFL0s5K2E3VTdhOFQ1bzFEVW83V0RxR1hvSGduVkxT?= =?utf-8?B?K1o1MDBrNGd5QW4xYzlVZmxOQ3ZTdnVaK05WVjlaZmJpMmxYNHpKUUowN3h3?= =?utf-8?B?elo4Y1lLeTlDTm1HVXpQNVpjQkt1Sy83Z2RTemNBL2ljdXB3Vk9iZGN0cTVa?= =?utf-8?B?M0NWMzZhL2NRQjVrclgrRmVCeUlabytqaTYzWWdKQ0cyUGpYWEFrNmtwclls?= =?utf-8?B?b1Myd2hGWHdMd1hINEY5TVlMYVBuMjhhTFoxYVk1MVp0UlVYYnN3UkkvOGtm?= =?utf-8?B?OVlrQzIxcnI0bWF2MENTMzN4Ymo0ZVdQeDRmRFBlRlMyMmNWRVk5akwvVTkw?= =?utf-8?B?QlFQdHNQSG1PSDhjSVkxT3IwcHdicHpmODhzSGVZZ3FiU0Z0eEtmWkdCZ0Vh?= =?utf-8?Q?Kyg+wRHq2a+RiJxoQP2VY1mFy?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b610eb57-dcfd-4bf4-26e0-08dd995a2b60 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:51.2600 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ilT6WyOBW28pf8v5KYdsfVrAdzX/b8KKbyV06b58GqFjYRI3FJ93VRVbSs4ECsbl32KvfReX8/6XsREIQz0yFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 Add CSI related nodes (i2c, irqsteer, csi, lpcg) for i.MX8 img subsystem. Signed-off-by: Frank Li --- change from v4 to v5 - remove empty endpoint Change from v3 to v4 - remove unused clock clock-img-axi - add ports information for isi and csi - Fix 8qxp clock, irq and power domain - Fix reg size Change from v2 to v3 - remove phy and put csr register space under mipi csi2 change from v1 to v2 - move scu reset under scu node - add 8qm comaptible string for mipi csi2 and mipi csi phys. --- arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi | 362 ++++++++++++++++++= ++++ arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi | 79 +++++ arch/arm64/boot/dts/freescale/imx8qm.dtsi | 5 + arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi | 83 +++++ arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 5 + 5 files changed, 534 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/bo= ot/dts/freescale/imx8-ss-img.dtsi index d39242c1b9f79..2cf0f7208350a 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi @@ -10,12 +10,264 @@ img_ipg_clk: clock-img-ipg { clock-output-names =3D "img_ipg_clk"; }; =20 +img_pxl_clk: clock-img-pxl { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + clock-frequency =3D <600000000>; + clock-output-names =3D "img_pxl_clk"; +}; + img_subsys: bus@58000000 { compatible =3D "simple-bus"; #address-cells =3D <1>; #size-cells =3D <1>; ranges =3D <0x58000000 0x0 0x58000000 0x1000000>; =20 + isi: isi@58100000 { + reg =3D <0x58100000 0x80000>; + interrupts =3D , + , + , + , + , + , + , + ; + clocks =3D <&pdma0_lpcg IMX_LPCG_CLK_0>, + <&pdma1_lpcg IMX_LPCG_CLK_0>, + <&pdma2_lpcg IMX_LPCG_CLK_0>, + <&pdma3_lpcg IMX_LPCG_CLK_0>, + <&pdma4_lpcg IMX_LPCG_CLK_0>, + <&pdma5_lpcg IMX_LPCG_CLK_0>, + <&pdma6_lpcg IMX_LPCG_CLK_0>, + <&pdma7_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "per0", "per1", "per2", "per3", + "per4", "per5", "per6", "per7"; + interrupt-parent =3D <&gic>; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>, + <&pd IMX_SC_R_ISI_CH1>, + <&pd IMX_SC_R_ISI_CH2>, + <&pd IMX_SC_R_ISI_CH3>, + <&pd IMX_SC_R_ISI_CH4>, + <&pd IMX_SC_R_ISI_CH5>, + <&pd IMX_SC_R_ISI_CH6>, + <&pd IMX_SC_R_ISI_CH7>; + status =3D "disabled"; + }; + + irqsteer_csi0: irqsteer@58220000 { + compatible =3D "fsl,imx8qm-irqsteer", "fsl,imx-irqsteer"; + reg =3D <0x58220000 0x1000>; + #interrupt-cells =3D <1>; + interrupt-controller; + interrupts =3D ; + clocks =3D <&img_ipg_clk>; + clock-names =3D "ipg"; + interrupt-parent =3D <&gic>; + power-domains =3D <&pd IMX_SC_R_CSI_0>; + fsl,channel =3D <0>; + fsl,num-irqs =3D <32>; + status =3D "disabled"; + }; + + gpio0_mipi_csi0: gpio@58222000 { + compatible =3D "fsl,imx8qm-gpio", "fsl,imx35-gpio"; + reg =3D <0x58222000 0x1000>; + #interrupt-cells =3D <2>; + interrupt-controller; + interrupts =3D <0>; + #gpio-cells =3D <2>; + gpio-controller; + interrupt-parent =3D <&irqsteer_csi0>; + power-domains =3D <&pd IMX_SC_R_CSI_0>; + }; + + csi0_core_lpcg: clock-controller@58223018 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58223018 0x4>; + clocks =3D <&clk IMX_SC_R_CSI_0 IMX_SC_PM_CLK_PER>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi0_lpcg_core_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + csi0_esc_lpcg: clock-controller@5822301c { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x5822301c 0x4>; + clocks =3D <&clk IMX_SC_R_CSI_0 IMX_SC_PM_CLK_MISC>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi0_lpcg_esc_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + i2c_mipi_csi0: i2c@58226000 { + compatible =3D "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c"; + reg =3D <0x58226000 0x1000>; + interrupts =3D <8>; + clocks =3D <&clk IMX_SC_R_CSI_0_I2C_0 IMX_SC_PM_CLK_PER>, + <&img_ipg_clk>; + clock-names =3D "per", "ipg"; + assigned-clocks =3D <&clk IMX_SC_R_CSI_0_I2C_0 IMX_SC_PM_CLK_PER>; + assigned-clock-rates =3D <24000000>; + interrupt-parent =3D <&irqsteer_csi0>; + power-domains =3D <&pd IMX_SC_R_CSI_0_I2C_0>; + status =3D "disabled"; + }; + + mipi_csi_0: csi@58227000 { + compatible =3D "fsl,imx8qxp-mipi-csi2"; + reg =3D <0x58227000 0x1000>, + <0x58221000 0x1000>; + clocks =3D <&csi0_core_lpcg IMX_LPCG_CLK_4>, + <&csi0_esc_lpcg IMX_LPCG_CLK_4>, + <&csi0_pxl_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "core", "esc", "ui"; + assigned-clocks =3D <&csi0_core_lpcg IMX_LPCG_CLK_4>, + <&csi0_esc_lpcg IMX_LPCG_CLK_4>; + assigned-clock-rates =3D <360000000>, <72000000>; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + resets =3D <&scu_reset IMX_SC_R_CSI_0>; + status =3D "disabled"; + }; + + irqsteer_csi1: irqsteer@58240000 { + compatible =3D "fsl,imx8qm-irqsteer", "fsl,imx-irqsteer"; + reg =3D <0x58240000 0x1000>; + #interrupt-cells =3D <1>; + interrupt-controller; + interrupts =3D ; + clocks =3D <&img_ipg_clk>; + clock-names =3D "ipg"; + interrupt-parent =3D <&gic>; + power-domains =3D <&pd IMX_SC_R_CSI_1>; + fsl,channel =3D <0>; + fsl,num-irqs =3D <32>; + status =3D "disabled"; + }; + + gpio0_mipi_csi1: gpio@58242000 { + compatible =3D "fsl,imx8qm-gpio", "fsl,imx35-gpio"; + reg =3D <0x58242000 0x1000>; + #interrupt-cells =3D <2>; + interrupt-controller; + interrupts =3D <0>; + #gpio-cells =3D <2>; + gpio-controller; + interrupt-parent =3D <&irqsteer_csi1>; + power-domains =3D <&pd IMX_SC_R_CSI_1>; + }; + + csi1_core_lpcg: clock-controller@58243018 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58243018 0x4>; + clocks =3D <&clk IMX_SC_R_CSI_1 IMX_SC_PM_CLK_PER>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi1_lpcg_core_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + csi1_esc_lpcg: clock-controller@5824301c { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x5824301c 0x4>; + clocks =3D <&clk IMX_SC_R_CSI_1 IMX_SC_PM_CLK_MISC>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi1_lpcg_esc_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + i2c_mipi_csi1: i2c@58246000 { + compatible =3D "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c"; + reg =3D <0x58246000 0x1000>; + interrupts =3D <8>; + clocks =3D <&clk IMX_SC_R_CSI_1_I2C_0 IMX_SC_PM_CLK_PER>, + <&img_ipg_clk>; + clock-names =3D "per", "ipg"; + assigned-clocks =3D <&clk IMX_SC_R_CSI_1_I2C_0 IMX_SC_PM_CLK_PER>; + assigned-clock-rates =3D <24000000>; + interrupt-parent =3D <&irqsteer_csi1>; + power-domains =3D <&pd IMX_SC_R_CSI_1_I2C_0>; + status =3D "disabled"; + }; + + mipi_csi_1: csi@58247000 { + compatible =3D "fsl,imx8qxp-mipi-csi2"; + reg =3D <0x58247000 0x1000>, + <0x58241000 0x1000>; + clocks =3D <&csi1_core_lpcg IMX_LPCG_CLK_4>, + <&csi1_esc_lpcg IMX_LPCG_CLK_4>, + <&csi1_pxl_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "core", "esc", "ui"; + assigned-clocks =3D <&csi1_core_lpcg IMX_LPCG_CLK_4>, + <&csi1_esc_lpcg IMX_LPCG_CLK_4>; + assigned-clock-rates =3D <360000000>, <72000000>; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + resets =3D <&scu_reset IMX_SC_R_CSI_1>; + status =3D "disabled"; + }; + + irqsteer_parallel: irqsteer@58260000 { + compatible =3D "fsl,imx8qm-irqsteer", "fsl,imx-irqsteer"; + reg =3D <0x58260000 0x1000>; + #interrupt-cells =3D <1>; + interrupt-controller; + interrupts =3D ; + clocks =3D <&clk_dummy>; + clock-names =3D "ipg"; + interrupt-parent =3D <&gic>; + power-domains =3D <&pd IMX_SC_R_PI_0>; + fsl,channel =3D <0>; + fsl,num-irqs =3D <32>; + status =3D "disabled"; + }; + + pi0_ipg_lpcg: clock-controller@58263004 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58263004 0x4>; + clocks =3D <&clk IMX_SC_R_PI_0 IMX_SC_PM_CLK_PER>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pi0_lpcg_ipg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + pi0_pxl_lpcg: clock-controller@58263018 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58263018 0x4>; + clocks =3D <&clk IMX_SC_R_PI_0 IMX_SC_PM_CLK_PER>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pi0_lpcg_pxl_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + pi0_misc_lpcg: clock-controller@5826301c { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x5826301c 0x4>; + clocks =3D <&clk IMX_SC_R_PI_0 IMX_SC_PM_CLK_MISC0>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pi0_lpcg_misc_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + i2c0_parallel: i2c@58266000 { + compatible =3D "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c"; + reg =3D <0x58266000 0x1000>; + interrupts =3D <8>; + clocks =3D <&clk IMX_SC_R_PI_0_I2C_0 IMX_SC_PM_CLK_PER>, + <&img_ipg_clk>; + clock-names =3D "per", "ipg"; + assigned-clocks =3D <&clk IMX_SC_R_PI_0_I2C_0 IMX_SC_PM_CLK_PER>; + assigned-clock-rates =3D <24000000>; + interrupt-parent =3D <&irqsteer_parallel>; + power-domains =3D <&pd IMX_SC_R_PI_0_I2C_0>; + status =3D "disabled"; + }; + jpegdec: jpegdec@58400000 { reg =3D <0x58400000 0x00050000>; interrupts =3D ; @@ -40,6 +292,116 @@ jpegenc: jpegenc@58450000 { <&pd IMX_SC_R_MJPEG_ENC_S0>; }; =20 + pdma0_lpcg: clock-controller@58500000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58500000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma0_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>; + }; + + pdma1_lpcg: clock-controller@58510000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58510000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma1_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH1>; + }; + + pdma2_lpcg: clock-controller@58520000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58520000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma2_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH2>; + }; + + pdma3_lpcg: clock-controller@58530000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58530000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma3_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH3>; + }; + + pdma4_lpcg: clock-controller@58540000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58540000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma4_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH4>; + }; + + pdma5_lpcg: clock-controller@58550000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58550000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma5_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH5>; + }; + + pdma6_lpcg: clock-controller@58560000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58560000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma6_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH6>; + }; + + pdma7_lpcg: clock-controller@58570000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58570000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "pdma7_lpcg_clk"; + power-domains =3D <&pd IMX_SC_R_ISI_CH7>; + }; + + csi0_pxl_lpcg: clock-controller@58580000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58580000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi0_lpcg_pxl_clk"; + power-domains =3D <&pd IMX_SC_R_CSI_0>; + }; + + csi1_pxl_lpcg: clock-controller@58590000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x58590000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "csi1_lpcg_pxl_clk"; + power-domains =3D <&pd IMX_SC_R_CSI_1>; + }; + + hdmi_rx_pxl_link_lpcg: clock-controller@585a0000 { + compatible =3D "fsl,imx8qxp-lpcg"; + reg =3D <0x585a0000 0x10000>; + clocks =3D <&img_pxl_clk>; + #clock-cells =3D <1>; + clock-indices =3D ; + clock-output-names =3D "hdmi_rx_lpcg_pxl_link_clk"; + power-domains =3D <&pd IMX_SC_R_HDMI_RX>; + }; + img_jpeg_dec_lpcg: clock-controller@585d0000 { compatible =3D "fsl,imx8qxp-lpcg"; reg =3D <0x585d0000 0x10000>; diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi b/arch/arm64/= boot/dts/freescale/imx8qm-ss-img.dtsi index 2bbdacb1313f9..4b7e685daa024 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi @@ -3,6 +3,31 @@ * Copyright 2021 NXP */ =20 +&isi { + compatible =3D "fsl,imx8qm-isi"; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@2 { + reg =3D <2>; + + isi_in_2: endpoint { + remote-endpoint =3D <&mipi_csi0_out>; + }; + }; + + port@3 { + reg =3D <3>; + + isi_in_3: endpoint { + remote-endpoint =3D <&mipi_csi1_out>; + }; + }; + }; +}; + &jpegdec { compatible =3D "nxp,imx8qm-jpgdec", "nxp,imx8qxp-jpgdec"; }; @@ -10,3 +35,57 @@ &jpegdec { &jpegenc { compatible =3D "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc"; }; + +&mipi_csi_0 { + compatible =3D "fsl,imx8qm-mipi-csi2", "fsl,imx8qxp-mipi-csi2"; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@0 { + reg =3D <0>; + }; + + port@1 { + reg =3D <1>; + + mipi_csi0_out: endpoint { + remote-endpoint =3D <&isi_in_2>; + }; + }; + }; +}; + +&mipi_csi_1 { + compatible =3D "fsl,imx8qm-mipi-csi2", "fsl,imx8qxp-mipi-csi2"; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@0 { + reg =3D <0>; + }; + + port@1 { + reg =3D <1>; + + mipi_csi1_out: endpoint { + remote-endpoint =3D <&isi_in_3>; + }; + }; + }; +}; + +&pi0_ipg_lpcg { + status =3D "disabled"; +}; + +&pi0_misc_lpcg { + status =3D "disabled"; +}; + +&pi0_pxl_lpcg { + status =3D "disabled"; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dt= s/freescale/imx8qm.dtsi index 6fa31bc9ece8f..c6a17a0d739c5 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi @@ -333,6 +333,11 @@ iomuxc: pinctrl { compatible =3D "fsl,imx8qm-iomuxc"; }; =20 + scu_reset: reset-controller { + compatible =3D "fsl,imx-scu-reset"; + #reset-cells =3D <1>; + }; + rtc: rtc { compatible =3D "fsl,imx8qxp-sc-rtc"; }; diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi b/arch/arm64= /boot/dts/freescale/imx8qxp-ss-img.dtsi index 3a087317591d8..50015f8dd4e43 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi @@ -4,6 +4,85 @@ * Dong Aisheng */ =20 +&csi1_pxl_lpcg { + status =3D "disabled"; +}; + +&csi1_core_lpcg { + status =3D "disabled"; +}; + +&csi1_esc_lpcg { + status =3D "disabled"; +}; + +&gpio0_mipi_csi1 { + status =3D "disabled"; +}; + +&i2c_mipi_csi1 { + status =3D "disabled"; +}; + +&irqsteer_csi1 { + status =3D "disabled"; +}; + +&isi { + compatible =3D "fsl,imx8qxp-isi"; + reg =3D <0x58100000 0x60000>; + interrupts =3D , + , + , + , + , + ; + clocks =3D <&pdma0_lpcg IMX_LPCG_CLK_0>, + <&pdma1_lpcg IMX_LPCG_CLK_0>, + <&pdma2_lpcg IMX_LPCG_CLK_0>, + <&pdma3_lpcg IMX_LPCG_CLK_0>, + <&pdma4_lpcg IMX_LPCG_CLK_0>, + <&pdma5_lpcg IMX_LPCG_CLK_0>; + clock-names =3D "per0", "per1", "per2", "per3", "per4", "per5"; + power-domains =3D <&pd IMX_SC_R_ISI_CH0>, + <&pd IMX_SC_R_ISI_CH1>, + <&pd IMX_SC_R_ISI_CH2>, + <&pd IMX_SC_R_ISI_CH3>, + <&pd IMX_SC_R_ISI_CH4>, + <&pd IMX_SC_R_ISI_CH5>; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@2 { + reg =3D <2>; + + isi_in_2: endpoint { + remote-endpoint =3D <&mipi_csi0_out>; + }; + }; + }; +}; + +&mipi_csi_0 { + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@0 { + reg =3D <0>; + }; + + port@1 { + reg =3D <1>; + mipi_csi0_out: endpoint { + remote-endpoint =3D <&isi_in_2>; + }; + }; + }; +}; + &jpegdec { compatible =3D "nxp,imx8qxp-jpgdec"; }; @@ -11,3 +90,7 @@ &jpegdec { &jpegenc { compatible =3D "nxp,imx8qxp-jpgenc"; }; + +&mipi_csi_1 { + status =3D "disabled"; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/d= ts/freescale/imx8qxp.dtsi index 05138326f0a57..c078d92f76c0e 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi @@ -241,6 +241,11 @@ scu_key: keys { status =3D "disabled"; }; =20 + scu_reset: reset-controller { + compatible =3D "fsl,imx-scu-reset"; + #reset-cells =3D <1>; + }; + rtc: rtc { compatible =3D "fsl,imx8qxp-sc-rtc"; }; --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1D651A0BFE; Thu, 22 May 2025 17:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936680; cv=fail; b=ZibaPVvZt7vwccqiOFeqK0Geb7dkshHJcG9GENXCA4V0vczxHTbZRfgGwQxqGoi+XC/nX1S0Fc7XYRiP+KXVbWFlZz4WVvhS8ql3KoVu7sJA8yHTqCR8IFmJwcWMgPmxfbPRXE8puTCRzoD4hSCzif6uNCF4iLb2TLjFlOrQcWg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936680; c=relaxed/simple; bh=H2odYwzKjtISs7uP7SOMA3RDqcdl36SlVfsAu1fu3Qw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=L+Q0rIkQxoETPXdpViE5W02mMM1ZFBxg+bFwkQdDk79jqfF9kLaVnpzbws58q/VTB/NUFznrfYz4Zrcu73Qp7DWxHpeu5biCXhRmauMQCTP6pkLn7/SWwGlbHa+V+AkjPG0XG6SLG+qYA/PZVk8EKFvu3P/Dc9wONwiq2/+BTtY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=nrqHwoEL; arc=fail smtp.client-ip=40.107.22.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="nrqHwoEL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bH9ldbEWQQ4nk+OML8RL9BXEKY2mQ0r2eDWJFz1ANO3thunA4l9+LsWi+q/FwJx+zFov02xf/E2rBAZPeuzAQn7A8mAR7PqdmVC37ab70ZX2fhC/uzDt3aX/1y4Q2t4oOjoJIsHJVa5bBzAATo/pm0R6sl1xtotD5N45miXJPEEyuAroPNDknhepAObSAsUuRW5T0+tx0ULEUM8W2nFjU5OXECgIvhSfn4Kfm6RJF+lwyBLeoGdoNftI7G1gdgKHew3LZAF2WfmUN9ambi7XlqC2NGbVnCybQPz2mOjR2GMeFDXG9PuPXo6+w5DdqnaU3M4ybKrKP9/8jwio9kRurQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mg4vLCn9IW26ljIAr9900mrwyK6zczXhRUfFEm/PCUo=; b=ZZ2aRqEusCVd2SpZyY4DRqENz8rZ0iu4xP+F7/cAnJzjQvNxmzHTYph3q3w/uZIDu/jwo4CghFleVBeXxplyfrwj2NWfRkkPNatj8r8iHs7Hv6Zl2cJ969vuakrNZstleOkVYWspDKi1jqTQ2pFXRqOD3t/mubruJW+aeDf5v68sXtuw0PQzfGA3qwhgegDVkWU6acuJrkK2w3FHxoFKgoYFIJRLiOBVyfgTi8tzAR85+nWJWw6A6fSOADUk41uOyZe+Att3oyjX0BH4TsDDJ6JhIb5ubQrWm/IzsCE09KISGXbwGo1PMJkTufdx+xE6COX+jkUPE435PIjUEhhwIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mg4vLCn9IW26ljIAr9900mrwyK6zczXhRUfFEm/PCUo=; b=nrqHwoEL7/EO9AbXOFsLnKezklXH7M821AAc1SgH/QDT2M8uB5SjRPPklXSy5KFGKIgR5m9zcTMsmq6/W59cq0LNt5RX2D0Wbm+5npLqCIrT0xOmrSuJ+CCFuQQCNGkgrF/c00lkqxlUbwvq5GfGCbO5wnM8IPVbn6NL6BOOLVfykTzjHUD+Luqeo3GqVqe+UwxRv0yLxLYQvk3+kqdeZzseHQn9cXe1JJjcXMn9BjLn8Gh3QXDhokYoUZeTEzUOXq370n8hQomJRtF5XIOa5bPGH/y/d4KnFSlqmIaCOOrfEXqmXJDc98c79u9bEbWCE5ZiLroJtL4eGqb8UiEzSg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:57:56 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:57:56 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:50 -0400 Subject: [PATCH v5 12/13] arm64: dts: imx8q: add linux,cma node for imx8qm-mek and imx8qxp-mek Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-12-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=1691; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=H2odYwzKjtISs7uP7SOMA3RDqcdl36SlVfsAu1fu3Qw=; b=9MGlrT2Blxm/AH2mtiMSu+xUNIvnSfu+ylnUnaWpePf1nLD8yzED9F9UH7m2W8VjjNTxa2Q1V uuTch5UgHPIC222IpkGrsTDKVEz0cHjX1v1TZlXYLJ0NzBbHQBrdSIk X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bcb7772-5175-4f48-6027-08dd995a2e61 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YkFObktpNlFiV0ZJZGgzYm9vbFFVSC9SU0pqUXVLY0JUc2N4UUROQTFod241?= =?utf-8?B?d2RUZEEwWmNOUENOVUdHUmV4UEJ3YVhITHdwb0Q3MnA3U0MvanFPejVUODlK?= =?utf-8?B?eEtpQzNuRnFRWTAzaXErSGNPVDF3SGhvZG1jcUxZdGZKNnQ3cUI0MCtxQTdW?= =?utf-8?B?dmExU1ZLU2hIWkRzSFRpY0xRT2JkWSt3d2lheWovQ004Y3crUGxVRWluSFdq?= =?utf-8?B?aXdRZWVlalhFblFIa2pWa0h2S203d1A5S3hIYnRkOVZHYll2bGcxcFVqZW9B?= =?utf-8?B?cjhxQ0tlN29wNmZiV0R6UTdNZ2FnMHVxZ1BKc04zT1dxV1hLYWZETldUdE4z?= =?utf-8?B?TzJqWFdhQ094Z2VnUHI1TDM1Y3YzK05LUWQ0SDJVL3B4Qk9SR3dDMWFiSVdY?= =?utf-8?B?Nmo5SjUzME5yWGk4MlNJRGhFOC9jK0ZDdXdzajdsSTN5WFc0SDIyNDdsTWdM?= =?utf-8?B?U245cGl3akRUWWRKVUFoUytUdGJSb0l6VTFoSElNKzE3SjRIcXFDWXRyOCth?= =?utf-8?B?RTA2UUZCdFAzQXRuTS9oYVhsRUtrd1Jtb3BEa005c0l4ZkFWaEVaVkpXQSsv?= =?utf-8?B?am9MRkFYZUZ2L2tMM0FVN2prWlFhY0NKYkE4QjBnak5JOVRIRG94ZmV2Nllw?= =?utf-8?B?YUFhUy9uQVZBQkhIaCt2ZGtEMldjckdxQVVndHZocnlHcDYwWml0ZmgvYWxD?= =?utf-8?B?SCszSEFxb2U1ekJPbXVNMHY1UzRJcEk1d3hSRWhWKy9EQVRDc28vbDlQaXpQ?= =?utf-8?B?UTc5M1Bxd1VrRDlkUUV6YTJ2WDhNcjJ1T1g0eEZsOEhVSGUvZCtZSnRMN1B6?= =?utf-8?B?YTNDMnJPWHp4emc3UWI3OE1DRUg1ODlybGc2NTc1anZkZGdYblVyci94S2J6?= =?utf-8?B?c1cwZHZFM2Q4bFNndmFBa2lVQ1NyMktxSTBPbjNwOTdhQWVhclF1dzBGOERk?= =?utf-8?B?d1BJQjBvNkpoOHBvcE5Nd2RWVUpXMTJ0NjUwNDlhaGRzRWpyWGNHQ1NQUkJJ?= =?utf-8?B?THZ6SzBxcmlsdnBLQ2p6TFJwa29sRTk3VDJPR2xiM2dva1JaaHpIaE84VzE0?= =?utf-8?B?bFdmM0wxUHBTWXhqcDdCeCsrbmNxb3NCa2tLdUx0aTdNbXVxaWFaTU5ETkhS?= =?utf-8?B?cFg5WSttMEtJejlJZlNPcXJjMmRjdWlmelRGZ1AxZjlSMmNMTjhtd2VySXQ5?= =?utf-8?B?aUZ6SU5wL2xRUWVHN0N5Z1JnWkN6U1BrU0Uxdzl1REE2ZWNoK1pHeUFnT2tq?= =?utf-8?B?MWxDR2pNOFZBUWFrY1VxZmM2WFlSTkhxMzRyUmtjUGxjd241SmdVQ2ZDR3hV?= =?utf-8?B?a2JvMk5VQVpyTnk4L3l5bnYxWm5YUm9aSE13Z0tWQldJejhCR20zL0tTWkNz?= =?utf-8?B?aGFtWko2ZEZTNTVGL3lwUEpkYm5zMUswVHdiaDZUcnAwUWZjdjA0OUhBQm11?= =?utf-8?B?RmpFS1gzR1dTTkxOY0hZRWdDQjZCKzU1cGNqd0p6eTRTYVJ1QnFwSWEwallp?= =?utf-8?B?OEl4cm1HNzhkQk5hMDVISjF5NTcvMG1Zek94aEc0d2ZrazFTYlFwdVBpQnB0?= =?utf-8?B?a2M1a2JpSVozREJieVlFTnFRM0djSCtvZk03c0txejk2ZHQ1bXczZ3JGaWlL?= =?utf-8?B?cUdIS3B4amdRU29wZzk2YVR0UW8xTnE4OXczS1JacHZHNlFOZExxUkdmSkhB?= =?utf-8?B?YUpRREtjWmMzaUJyOXV0T1JYaG9hdk5yT0FOdXcrTXhwNVFRRHBidG9ySUo4?= =?utf-8?B?eEEzdk0yMzhmNXJlUktDQ0ptNTdJMVZPOC9OM3FsaVJDZitHTmNpUUtqTkl3?= =?utf-8?B?dCt0VU1ZSkhCUzJIdDlHVnBjekNaV0hwSmluTWFWVGExUktRYW8vY3gvUjYv?= =?utf-8?B?ZzBmbmhaOGFhTUthMnBZWGlLaVF5K2R2TE9vcmpONnlja084aDgyMTBBbWFz?= =?utf-8?B?anJpd0U3RjQ0RVJFVWZuYmhlWlZTWHNzc1Z2VVd3MEFsTGpWakxyR2N4WWFH?= =?utf-8?Q?axjlw/43ve2XKvvxAwkbLDgFCRF/Ko=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGNjSWNEcWhMeUxuRWlPcTJFNkFJektJeDdIellhSUQ0VVVrbzgvakZ2NHV6?= =?utf-8?B?a3lTNUVvU0RMbFFFRElXYXNNd3haK1R2clNMM3lvbFRSN2JTMnNoVVUyQ2xy?= =?utf-8?B?U1ZTTVFLVFlnazlyQ2xkSmlNbk5PQ2V4NS9rQkVxRkE0eEdDeGM0VTFBU2Nr?= =?utf-8?B?N1hRU1hGVUlFeVhTUjV6WlFRYzZYRXpzSzFuanZReks1dHB1UDNUTlJiZlBX?= =?utf-8?B?TGpvR2YxRlZBeXRMd3BiTlY0d3hGSzRsclR1MUJscDc3QXZhVzFkS3BzV0dv?= =?utf-8?B?ZjI5aWpOQkxzb1AzWldmcGRnWmpWVnZ5Nm9MaUFnS012SHdLZ0VIY0ZXMUM0?= =?utf-8?B?TjBnVk83TzdSZW4rNkJkSWpUWWtQMTRpMU5UQ1Byck9LWHBic3ExVkRqMEpi?= =?utf-8?B?anBHeURwWnp1bkpqV0xTQmljM1lhT1R2QmZaS0QxaVBQSmdvYzgrcDdRWlJP?= =?utf-8?B?NTlzdFB6Y2NOSlRuU2NGTElSNitNMmFLdDZUREI0YUwxUmdIT2s3ckpCcTlp?= =?utf-8?B?UzRveTY5L0U1cEp2TDV3M2xvclNVTklOM3U4OC9TMGp2QlVBd3JpNHF3K3VG?= =?utf-8?B?S2pVOWZuTTNZOEwwK01vNmZ5NHVqSVFZUGtNSHVHd1VqWmZodlJJZWdLaDdy?= =?utf-8?B?NXlURURsS2VWQ1lJcFAzd29GYitNczJMdmVwTmQwWmt2d0RXWDRkY3RXNzRD?= =?utf-8?B?SU1nQlBHSFBXV3lpMkxGVS9vUnZCc1puK0Ezanl3bjczVndMQ0oxa3JDR0hQ?= =?utf-8?B?ODhXMU1JMm1vaEZaQkx1NktEVm4rYjBCTlA4NjVRT09nMTR2cGVvVXNzYlk5?= =?utf-8?B?aDJQM0tCbEZCYkowc2MrNzQyZTJHMTZIbi95UjNYWGlsbVgwMUZaR0RweGJ2?= =?utf-8?B?NTliWE01NGUzeEdCNEVtbEpaM21qa2ZWMmN1RlNOZ0ZqMy9waklTbERBNWR0?= =?utf-8?B?VXdITklFK3hKalB2VXE4Um1DWWpENzd1amZvN1Q4YWw5OVZkbTNRY3dWT0FV?= =?utf-8?B?cjk5NzJ1MDdYZ1h2THo1UHkzL2tzZDI2MUFyeDJFNExlL2wxcllDcHZBaDI3?= =?utf-8?B?RVBMMEs3MCtQSzBxQk1XYk5jd08xYUZ2YlRlaktyYXlwOUVQRTV5am9QSHNR?= =?utf-8?B?OHlpQ3pRK0ZrS3pyOUgzKzZ1RGRlTzRIcVRvMThqcWJIdkI1WkxTRW5zelVi?= =?utf-8?B?eDRZNjhoTmliL2wvQXVacGVlRWxtYVliYkRNYnhmVHZpRzMvL3pNaHo4aFhR?= =?utf-8?B?Wnk5M2ZZTExMSjlSa21ML3k2MTl0UGErWTZqOWhzamovSVRzU1lMNkxMQ29j?= =?utf-8?B?ZDZUcUxERU05YjFqNzZRZWtScjFNemFOMnlLWFJ5R3QzczBheVdFWSt4dnRn?= =?utf-8?B?UjZONFlRNjN0ODBxcWhpa1NaZlRrbU5Dd3Jsd0daQ2hkWEtoUzFEWjFoVDZR?= =?utf-8?B?L2xmek0vV0FWM2tnekhxYmxNU1VrQW9KaEd1ZXdmczhoeUFya3VFYlAyMlQ3?= =?utf-8?B?bkhPZVRtSTVFV2QybXF2SEpDS1c1WXZScnVMTjR4aTJUL3E2QzVxb2dBOVkr?= =?utf-8?B?RENMOE5SUUcwamp3WXpNM3RVUjZJUnpYQk9IYzVad1BZcDVDQU9VT0JqUHJY?= =?utf-8?B?YjlpdE8vbm4rQ0JTOGRrU25URUZ3aHQrdG44YllBNlFQdFlnMnErRGRqV2xi?= =?utf-8?B?d2xJdUJGeG9YZ08vWU5SQzZieEZ4ZmN2RjVqYXhkdGU5WTJXbks3c3J4UlJq?= =?utf-8?B?WTQvZXd5V3NkNjJoY2toMGtoSUYyam9sMWFiLzArbEtiY1IvYk4yTlRRZnlI?= =?utf-8?B?VkZpekdqeTRsTUM5THIvallWcnFzMkFFMkZpTWlkUnpWSkszWEgweFc3aUVz?= =?utf-8?B?dkFRbEZPYkcxZVZtTHVqOGZpZm5oN2o1cnBmaWRjbC81QUIyOE00d0RWZE9M?= =?utf-8?B?UXRkMktyUWtXSTYwVFJNVFBJZzRRMjlybU83UzBjUFNGZ0FCbjhLdTJkV21K?= =?utf-8?B?RzBoTmxRd2NzSW9CUDJ3a1dXTElTd1d5eFdXNktQVllwNkoydWFMUHk4cjFm?= =?utf-8?B?R0JIOEtSa1crbXdnOHZGeHY5MmNZRVh1bGVyMXVOeU1sSkRmUHNrMjZ5UHI5?= =?utf-8?Q?y3gXjIV2V6Ek4s0CQF1dVUcJV?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bcb7772-5175-4f48-6027-08dd995a2e61 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:57:56.2749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vh4wC3Yu0EUV/a+d+/22SRAroykLKaAvegebN1huoPZLyeSrKAc+GfpvTz5BTHkKN76fZKHoS9N5g0JW+MjfXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 Add linux,cma node because some devices, such as camera, need big continue physical memory. Signed-off-by: Frank Li --- change from v1 to v5 - none --- arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 9 +++++++++ arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 9 +++++++++ 2 files changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot= /dts/freescale/imx8qm-mek.dts index 353f825a8ac5d..68442c8575f3f 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts @@ -113,6 +113,15 @@ dsp_vdev0buffer: memory@94300000 { reg =3D <0 0x94300000 0 0x100000>; no-map; }; + + /* global autoconfigured region for contiguous allocations */ + linux,cma { + compatible =3D "shared-dma-pool"; + alloc-ranges =3D <0 0xc0000000 0 0x3c000000>; + size =3D <0 0x3c000000>; + linux,cma-default; + reusable; + }; }; =20 lvds_backlight0: backlight-lvds0 { diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boo= t/dts/freescale/imx8qxp-mek.dts index c93d123670bd2..44bda183492cb 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts @@ -187,6 +187,15 @@ dsp_vdev0buffer: memory@94300000 { no-map; }; =20 + /* global autoconfigured region for contiguous allocations */ + linux,cma { + compatible =3D "shared-dma-pool"; + alloc-ranges =3D <0 0xc0000000 0 0x3c000000>; + size =3D <0 0x3c000000>; + linux,cma-default; + reusable; + }; + gpu_reserved: memory@880000000 { no-map; reg =3D <0x8 0x80000000 0 0x10000000>; --=20 2.34.1 From nobody Fri Dec 19 13:07:32 2025 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2074.outbound.protection.outlook.com [40.107.21.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70853199252; Thu, 22 May 2025 17:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936686; cv=fail; b=MoF5OK/AlRmejmNppdxIDlM8rPaIoNP/x7kl+5j+JYxTdceFYoI3jMGWDf1csy6xnFwH5ypm/pjIFTKpai1XdcFCHDLLsc9cZZW/cQfUzk2O46KakdSTv95HCWZF6oR/Cv5AgaBjuiHpIpXceq+dDs2v/ylEJfU+UlsUr4/aJfQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747936686; c=relaxed/simple; bh=L8Yl1POgxokxfkJXEyXHiVMQ7MBhX1CushJashNA5Dw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Th4BsKZU1N7Mxe6Z7IULsC830yr+StKnRaYJ28QSw6Ioy/6ptx3PsEwsGeUMmEUv/nx4orJAhV/6sR402lSi6KPJgCziacEVdqkOWLG40vbixmibMdjq6vOtqaJdMSt8mEaY6TDEHFEE4kb5grYk9oBhS8KSI7qBke8Lsr2WKKM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=bKac0BMT; arc=fail smtp.client-ip=40.107.21.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="bKac0BMT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kH/epAuKBKC2fCMHwjBxNvuJU4lPXcwh18GHXWzUrz8KDjcXLqOqQQyRHAxPyi71OqEqWrzly088ewiQXu6CiPkeHoWTxrEISU+v6hTXf6Dq8tNUu+LaY07UIJ7V3Y/I/qGKvVCMEk4lodbY4eoVK6VuJV4lpZKWD3HGsh4mt4PUkF9O47GG2RjIsGg0oXaT8uRnYT2uBRyDYuwpdZgOjgrsa3eDsZAF1Be13hellPVTe+841ER/VIDxAjl1w4I1u4O47IUquvqt4CwvATw+tZ1yy3wsW6NxtRtuCU5uDuITGT1MN2xntYu2CLhm4GA+hMudhLJYnyKeK2Ipnpo1Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4o0zU7p4ORmCEUYQmiNjUpswrffkkv0jFJVprY3Rci0=; b=OpWDLf2yNNQ83DWoYSqlGy3ztfD9hjLJQfyFkG0iGB2P1f39ad6x51uuJd+gtuW15naf+/QhdV532eSCS3aB1tLY+K/YL0P0qaUJFpFKF8lPBawIC/MvUWmynOTH5jJ/4CGNLc+vBGerwpzbiIfbYnO0QuF3TsrrwT5Dv/6yuuDDpvtafFWM21AodK3advhUHxTrBCuzkRJpAUEnQtKuTiCERHMnEFiAr8/Ru6j2Y3dP+el3XISBX3353Eye7+q8YsjH5wb9rqRUyBIT3vhUKXRE7enL6YVUqX0xJA3FMWJGMAm9SGcWgkYJVDtqXqDeRe+06MK7+9tkMA2GInPNsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4o0zU7p4ORmCEUYQmiNjUpswrffkkv0jFJVprY3Rci0=; b=bKac0BMT35qaRjZVa3FvJG0uJYpK+bMwCin/E2haf8iu+ZSVjNjbpJFv3zA89+Eq0qln2B6a6AWky+HaHWvQRP5+SpveOqYs4jIq1dx8cNcBAOQ+Moh9BVLAwWMefjbUCJxcVjVkQYPiA+x+pn7nvx/GL159MUQzA9gHct3EAWARCHTOfN6DpasRErtpE47oCTpL7lt/8S0eO18fXbNTvyb15oR5k8QwDnO/5oP6fBL4T8Muyu8TVUm/6yQtSaKCuUvVAI4Wj/Vp4UDUo9+UpeVZ7l+7st7ikwGEP1xUQ4hViM7GIdrFU0aRkQ5p2QMbL/dPFw7R63mWaf4vRWpGKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by FRWPR04MB11272.eurprd04.prod.outlook.com (2603:10a6:d10:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Thu, 22 May 2025 17:58:01 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8746.030; Thu, 22 May 2025 17:58:01 +0000 From: Frank Li Date: Thu, 22 May 2025 13:56:51 -0400 Subject: [PATCH v5 13/13] arm64: dts: imx8q: add camera ov5640 support for imx8qm-mek and imx8qxp-mek Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250522-8qxp_camera-v5-13-d4be869fdb7e@nxp.com> References: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> In-Reply-To: <20250522-8qxp_camera-v5-0-d4be869fdb7e@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1747936611; l=11637; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=L8Yl1POgxokxfkJXEyXHiVMQ7MBhX1CushJashNA5Dw=; b=ZOtKF3gL5H6DE+YsM9tVlHOJnGczgJzZi7NdiIG+Y4areNS9lIzHMSA09V+9ddBd0JLZxhmjJ JeUvXCC4b7vCFh9DU/RiG/A2cAl/9pKgcLzHcKlhyN0cJI7ua7k0WDT X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|FRWPR04MB11272:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b2e51e1-ddd6-462c-86f4-08dd995a3152 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WmhJQk9kVUpGb1JSQ1g2dTdkSkMwd1hNRTEyN1FBcG9leEEvUkpLdmpEVm1r?= =?utf-8?B?RVAyOXVCekFpVHhHbTBwNnhxQXd1L3NhTU85MjVGQ3p5b1lONVJ3L0N2bGJh?= =?utf-8?B?b3hxT3hqVEsvaXRTbW81Mjdlc0g0djRlUzZhdm1uNWhLUlNKY05vUENRYkM1?= =?utf-8?B?STB6bkhUU01FcU5URW5VYUYrb0IxajRSRzFwYTNxNlFta21NZFRoQzlmT0Zp?= =?utf-8?B?RFNpRCtvTG1RK2VQeEJnL3FvUFV4WTNaQWE1Zm0zRnNnODYwZnUxdGpEeDJV?= =?utf-8?B?QndXeU1US1EzaWhLbXdpaXZpWmd1VnF5OFArSC9ISFQ4UjdjSm1rbkJFa1gw?= =?utf-8?B?Sy9SM3RmdE5aU0ZHSVZ1ZjFIUU5iV0NmTEY0NVBVQkFGK1kycU5HNS9aZWQr?= =?utf-8?B?bmxvVzI1UytjTUxNUEFBenJQb2Z1UGR0bFR6SnNCWEJvaGR5eVNEdWt3WGtu?= =?utf-8?B?TGJLZ0h2Tm4zWEl4T2Z2QW92QnRkc2kvdXROU3I1dURLYTNvL0sxdmZBVW9R?= =?utf-8?B?THowbjVDUDdZNDlEdndWRmVQRGc2WElWUHFzK2FhcXd4U3RSVWpudHdtcTdu?= =?utf-8?B?VUMrTUhrWllzMjVMSEpIQ05BSXhoaE96OGtjNUI0bCtva1hic25iUmdudUVk?= =?utf-8?B?NDd5TDdyZXhGd2p6eUpYRlRmUVRCbDNYclg5dktsU2M1Zm1WSkI5bElWaExI?= =?utf-8?B?aXRGRUZtSVdHc044SCtsRno2Q3lnYjdub1d0MTB6bTgrWTBZNlJLdzFsYWNK?= =?utf-8?B?SjUzQUpUcFZuZjRSd2IzOHFLL0YxRGZ6RWo1eE1PaWZvakdsVGsvcEMyUnR3?= =?utf-8?B?WEUvNmNRdDd4MklGSXo2UDZyTWgxU2l2c1ZjelB0Y2VGQmdzWU1jVkQ0M2dW?= =?utf-8?B?R0hLNGo4ZnVaS3orekhWanRWZ0hhTjBEUW1ETkVYUlFHR1VVVnFmbDVWNlJ1?= =?utf-8?B?MkZvRnNEYkhoeFhDSktVQ0xBUkQ5bjRSZnl6YkgwTGRicW05VTNFYUNSYUhy?= =?utf-8?B?Z3RFUm1FQkxRY3BuWWFMTTJNK3ZOUjM2Z0pUMUtYS1JvWnlocWxiUVllMHFX?= =?utf-8?B?V3IyNElSRUFCRGhXaGJPUHJUbUNCUnhPM3VORXFOQ3ljQXN1STFyTEJSQmlT?= =?utf-8?B?RUhlei9rampLUmp5eE9jckY0RktwV0lnaUVkUFVubDBMNTZNOGJoRE4vVVFH?= =?utf-8?B?TkRxYXczeENzWHFnOEtHRnJsUUQvcWNLU2MvUHNrNlpHbFNVTkdxK1pseGMv?= =?utf-8?B?RUZpODdFR0dCcjRKNHFxTkswMzg1Z1NsUEJRd1BWdDlhUXVmU01oZWZCYm9j?= =?utf-8?B?QTlOekorQXlWaTJkRXZ0d01md3diV3M2bEx4YUQ5MW9PQ1hIcUM4RDMvenpO?= =?utf-8?B?L3M0R3pnWFVxUWdJbDVlbGdKYmZ3V1lFK2xxdG5HSVZVbjBpWEVFczFpK205?= =?utf-8?B?ZzNGVXZKSy9XUjR6bkZ6WUlwdnk4aE1SQXd4NFNzVUwwaHRTZU0xZzRyZjI3?= =?utf-8?B?MHhuZHQvcUl1NGkrdjlLd25seHFab0Z6aDRiV2VYVHg4dmU3VGR6SUo0RnlZ?= =?utf-8?B?RGhFWjFEWWlKN1JQOWYzbkh6YkdPWkZDODhzb1hKc1VMRW5MRzhpMXN1a1lU?= =?utf-8?B?MXVkbUVTamVLSnQ4dEFIRHdCK1NKZ01ZRUg3REtHTWdVVTIrU3V3RDh0czBu?= =?utf-8?B?eE93c3V5K3NTK0VmQTZxdjg5TjRnc3VtaHI3STM2NUM0cDBmd3VjWGF2eUxU?= =?utf-8?B?VVJIckNVQzBqaG1wZVFQZ0RWMVZ5bWZJZG1nTnE4c29sRFk0N2IzNWRQb29n?= =?utf-8?B?YWxpYVVQSCtqbFEyQkI2bHFHZjF2bEJzRlZ2Ky9PTHBBNWpESHc3aDA0N1FC?= =?utf-8?B?dkhWbTN3SEdvOXZEMDh1QWUzQVJlUmg4RGYxaEFSZnhJdlpJdmE2NG1WMFRp?= =?utf-8?B?TVBpM2d1cUxheWxrMWQveU94SjhZSDBGc0E3N2kwQWdIaXBjQkNiZERWNDZS?= =?utf-8?Q?fnKil0kOu1IBc1QJJ+LlhFlV33N0OM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1Y3R2V5OU0wTEhXZy9BZlgxVVRwVUt1T1pTcVFCaElPVzFCQ1JhemhvUHFW?= =?utf-8?B?MFdwVm9sbW5CYnpQcEhxN3g2M0tncENLTDJ1b2ZlRjlnWk9nWG5vWW5xb3Jl?= =?utf-8?B?QjlUTEZaclp1bmtWOExzcWlrSnUvWG9XNWRueXFNakdzU2p5eG9SV1p2aVB2?= =?utf-8?B?dlBVL1dKWCtSUXVZaXgzcjFEd3JwSkdndGZLd2NBS2dUWmdNMUltdGl3ekdi?= =?utf-8?B?cVpHSUVrK2lnUU1JanBuVmd3UDJoRzhFbGR1Yk5CYUZLYnRackRUNDlyVity?= =?utf-8?B?SHlRRStEaE00NS85dUxtbm5ncHRLVE5jUGNVSzYvNEM5a0d4VmpWTzM0RkJa?= =?utf-8?B?MURwdEloeWFINk9DU3lSYjQ4dFI4UGxKMm1pb204WnRhWm1LQWxLUDlhZXFM?= =?utf-8?B?Z2ZzQUVpZ1dvbjZnMFN3UE9OUkxUMVdZVU9LeDZoQkEzZ055WHdENE5tWS9Z?= =?utf-8?B?QzFLZVFPSmovUk1mZ3IvVGhXN0FBZWdzdTdSb0NLZ3NYcEU3dGtjQllmQlBN?= =?utf-8?B?Z3RmY2Z2Vjl2Vm9WVW9RQklvcHFacHJEN2RNZ1RuNnFjdGQ1VjNJdVl0aTAw?= =?utf-8?B?bjdhRDlTUUVzeExDYXdrVS9RRU80aDdLS0I2QTFVbDBsQ3NaalNnZW9BbkdL?= =?utf-8?B?VytkODhCeWdqaFgrd2lNY0pzZGZteEVxUzNacWhyczN5dVdyaXFpb1lUTHdv?= =?utf-8?B?bU96a2VDeHVsVzQwYVArRzk1Wm5pcFhaQkwzVFhrdUErY2J6UVhlUndiclhJ?= =?utf-8?B?Y05TalNMeUhnb2dUa1Eya0VEdUhtZExjTmVwWUVodnhrWkYzcHJJZFFzR1Z4?= =?utf-8?B?VkJKVTh6RnljeXVlMWhGSkVPUW81K3h1cVpQeE0vdWpMSHFIY1BiWkcrOUhR?= =?utf-8?B?VHAydks5amQ0YnZvaUV2Q0NUUStTVFN3RHZvYTlnb3ZRTW1ZdGo5aWJGUEZQ?= =?utf-8?B?NUY5TklNRjJaYzZ3RUZDVHNDSWJkVmRBZDhSOVJyanZGT1dkZUp4QXJUTXhM?= =?utf-8?B?VHpRc1ZFWDRkYldiNkpYQVNPdzFWSGk5bnBCcG1kbFBGR3FlL3BDbnphb2Zi?= =?utf-8?B?T0RhUGZWMXUvOGkwNiswYTFjODdselRzZmJvNG12dWZPWEIyazhrY2VObTFJ?= =?utf-8?B?bDJBcjFDTlN2M1VyM0liamkwVld5bGZwaUxBcVpsZFd2NlQ4K1ptdjMwZlJS?= =?utf-8?B?S2V3b3Z5bk1TZ2VxQ0poMmdyUzZmNkpIRW84alhrME12U0JPeERoVWtCdGsz?= =?utf-8?B?dlBJYWZWL2M5MC9DWWRpcmRIeWhHQ3cyV2dXWEluV0xJUzFNMXRkT3NSWDBX?= =?utf-8?B?K3lzRXByYXBOSWpuS0hYa3JPekdyL1dKTUZSR3FobXZkWlh4MWJsVkFpdTJB?= =?utf-8?B?d0o2YjNpVm1jSFNYUmRMVzdoWTVUckUvcDhKWVc5VjlWZHJQVXpSUm1jRzUy?= =?utf-8?B?OHFaLzNOVGN4NEg3UlE1Wjd3NWoyYWk4angvTjM2c0VkMjQ4WWVBcUc1eUZD?= =?utf-8?B?bEpGd0tVZDJCUnRHOFdTQzBSNjdwaUJ2c0N4RVluRHFIbzRkVXhwMmJhTGli?= =?utf-8?B?SVhPSWM1alRHYThTdXl2ZlY5Z2NpTXFkblRyNmlsYTRycWdad2FrR01qSUtK?= =?utf-8?B?MXVqK3FoeTk4akhaci9JYnZqN1ByUkhHNzNEVFJZUTFEdTdmUlhPV0sxR3pG?= =?utf-8?B?eTg1eEQyMyticmpzaFl2T0U4NVo4THB2T3h6c0VqbE5ISDBTWENZYldId2NP?= =?utf-8?B?Qndra1gyOFIwV0FoV1N4ZlArZ2p5TWw2NkNXYjRwQWIwaGtEcExLR3d2Rzlh?= =?utf-8?B?NFREZVlXMDhaWWlBVWpoN1FQSlR5c2ZrSlN0eS90N3ZxZTJkTVNqeFp3c1A1?= =?utf-8?B?MHBtRXM3RUJiRkxhZE9BeTVWU1VwL2VnU0RMTy9JZ2F6NE9VajB0RDQvM3BH?= =?utf-8?B?dnNOS0JmNDQzd014Skord0N0eitCTEdjMGk5Mjd2S0Y3NVJvM1dObloyVHdO?= =?utf-8?B?NjRaVTMrVjZ4VEV0dWwrN3ZTM2YyR2loc0FYNDJGYWd6Tm55WVViTU1QeDQ3?= =?utf-8?B?UjdIeFpwOEpPSm8yOHN3cVFianFKNWFkU1U5N29qNTdWV0ZzUS8vamowMFM1?= =?utf-8?Q?C+UfNAhDQe1Ab4DxT6mGUsa7P?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b2e51e1-ddd6-462c-86f4-08dd995a3152 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2025 17:58:01.1583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SK3XLO/ZwgidJ+MrKedDP0Ffzb9vSPm3AS8rGEa5RsE3B+1VPzFMHouUuXMNaNRtwJIR4+5bbeuCC0npkhzCxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRWPR04MB11272 Add ov5640 overlay file for imx8qm-mek and imx8qxp-mek board. Camera can connect different CSI port. So use dts overlay file to handle these difference connect options. Signed-off-by: Frank Li --- change from v4 to v5 - use fullpath for csi endpoint change from v3 to v4 - add board level xtal24m - remove reduntant ports information at dtso because chip leave already add it. change from v2 to v3 - remove phy nodes change from v1 to v2 - none --- arch/arm64/boot/dts/freescale/Makefile | 11 ++++ .../boot/dts/freescale/imx8qm-mek-ov5640-csi0.dtso | 64 ++++++++++++++++++= ++++ .../boot/dts/freescale/imx8qm-mek-ov5640-csi1.dtso | 64 ++++++++++++++++++= ++++ arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 58 ++++++++++++++++++= ++ .../boot/dts/freescale/imx8qxp-mek-ov5640-csi.dtso | 63 ++++++++++++++++++= +++ arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 36 ++++++++++++ 6 files changed, 296 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/f= reescale/Makefile index 0b473a23d1200..d376b4233fe8a 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -301,6 +301,14 @@ dtb-$(CONFIG_ARCH_MXC) +=3D imx8qm-apalis-v1.1-eval-v1= .2.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qm-apalis-v1.1-ixora-v1.1.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qm-apalis-v1.1-ixora-v1.2.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qm-mek.dtb + +imx8qm-mek-ov5640-csi0-dtbs :=3D imx8qm-mek.dtb imx8qm-mek-ov5640-csi0.dtbo +dtb-${CONFIG_ARCH_MXC} +=3D imx8qm-mek-ov5640-csi0.dtb +imx8qm-mek-ov5640-csi1-dtbs :=3D imx8qm-mek.dtb imx8qm-mek-ov5640-csi1.dtbo +dtb-${CONFIG_ARCH_MXC} +=3D imx8qm-mek-ov5640-csi1.dtb +imx8qm-mek-ov5640-dual-dtbs :=3D imx8qm-mek.dtb imx8qm-mek-ov5640-csi0.dtb= o imx8qm-mek-ov5640-csi1.dtbo +dtb-${CONFIG_ARCH_MXC} +=3D imx8qm-mek-ov5640-dual.dtb + dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-ai_ml.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-colibri-aster.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-colibri-eval-v3.dtb @@ -311,6 +319,9 @@ dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-mek.dtb imx8qxp-mek-pcie-ep-dtbs +=3D imx8qxp-mek.dtb imx-pcie0-ep.dtbo dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-mek-pcie-ep.dtb =20 +imx8qxp-mek-ov5640-csi-dtbs :=3D imx8qxp-mek.dtb imx8qxp-mek-ov5640-csi.dt= bo +dtb-${CONFIG_ARCH_MXC} +=3D imx8qxp-mek-ov5640-csi.dtb + dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-tqma8xqp-mba8xx.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8qxp-tqma8xqps-mb-smarc-2.dtb dtb-$(CONFIG_ARCH_MXC) +=3D imx8ulp-evk.dtb diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi0.dtso b/ar= ch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi0.dtso new file mode 100644 index 0000000000000..7510556323b1c --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi0.dtso @@ -0,0 +1,64 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2025 NXP + */ + +/dts-v1/; +/plugin/; + +#include +#include + +&i2c_mipi_csi0 { + #address-cells =3D <1>; + #size-cells =3D <0>; + clock-frequency =3D <100000>; + pinctrl-0 =3D <&pinctrl_i2c_mipi_csi0>; + pinctrl-names =3D "default"; + status =3D "okay"; + + ov5640_mipi_0: camera@3c { + compatible =3D "ovti,ov5640"; + reg =3D <0x3c>; + clocks =3D <&xtal24m>; + clock-names =3D "xclk"; + pinctrl-0 =3D <&pinctrl_mipi_csi0>; + pinctrl-names =3D "default"; + powerdown-gpios =3D <&lsio_gpio1 28 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&lsio_gpio1 27 GPIO_ACTIVE_LOW>; + AVDD-supply =3D <®_2v8>; + DVDD-supply =3D <®_1v5>; + DOVDD-supply =3D <®_1v8>; + status =3D "okay"; + + port { + ov5640_mipi_0_ep: endpoint { + bus-type =3D ; + data-lanes =3D <1 2>; + remote-endpoint =3D <&mipi_csi0_in>; + }; + }; + }; +}; + +&irqsteer_csi0 { + status =3D "okay"; +}; + +&isi { + status =3D "okay"; +}; + +&mipi_csi_0 { + status =3D "okay"; + + ports { + port@0 { + mipi_csi0_in: endpoint { + data-lanes =3D <1 2>; + remote-endpoint =3D <&ov5640_mipi_0_ep>; + }; + }; + }; +}; + diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi1.dtso b/ar= ch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi1.dtso new file mode 100644 index 0000000000000..080e31cdd7d3e --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek-ov5640-csi1.dtso @@ -0,0 +1,64 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2025 NXP + */ + +/dts-v1/; +/plugin/; + +#include +#include + +&i2c_mipi_csi1 { + #address-cells =3D <1>; + #size-cells =3D <0>; + clock-frequency =3D <100000>; + pinctrl-0 =3D <&pinctrl_i2c_mipi_csi1>; + pinctrl-names =3D "default"; + status =3D "okay"; + + ov5640_mipi_1: camera@3c { + compatible =3D "ovti,ov5640"; + reg =3D <0x3c>; + clocks =3D <&xtal24m>; + clock-names =3D "xclk"; + pinctrl-0 =3D <&pinctrl_mipi_csi1>; + pinctrl-names =3D "default"; + powerdown-gpios =3D <&lsio_gpio1 31 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&lsio_gpio1 30 GPIO_ACTIVE_LOW>; + AVDD-supply =3D <®_2v8>; + DVDD-supply =3D <®_1v5>; + DOVDD-supply =3D <®_1v8>; + status =3D "okay"; + + port { + ov5640_mipi_1_ep: endpoint { + bus-type =3D ; + data-lanes =3D <1 2>; + remote-endpoint =3D <&mipi_csi1_in>; + }; + }; + }; +}; + +&irqsteer_csi1 { + status =3D "okay"; +}; + +&isi { + status =3D "okay"; +}; + +&mipi_csi_1 { + status =3D "okay"; + + ports { + port@0 { + mipi_csi1_in: endpoint { + data-lanes =3D <1 2>; + remote-endpoint =3D <&ov5640_mipi_1_ep>; + }; + }; + }; +}; + diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot= /dts/freescale/imx8qm-mek.dts index 68442c8575f3f..503e0acd7963d 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts @@ -32,6 +32,13 @@ memory@80000000 { reg =3D <0x00000000 0x80000000 0 0x40000000>; }; =20 + xtal24m: clock-xtal24m { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + clock-frequency =3D <24000000>; + clock-output-names =3D "xtal_24MHz"; + }; + reserved-memory { #address-cells =3D <2>; #size-cells =3D <2>; @@ -155,6 +162,27 @@ usb3_data_ss: endpoint { }; }; =20 + reg_1v5: regulator-1v5 { + compatible =3D "regulator-fixed"; + regulator-name =3D "1v5"; + regulator-min-microvolt =3D <1500000>; + regulator-max-microvolt =3D <1500000>; + }; + + reg_1v8: regulator-1v8 { + compatible =3D "regulator-fixed"; + regulator-name =3D "1v8"; + regulator-min-microvolt =3D <1800000>; + regulator-max-microvolt =3D <1800000>; + }; + + reg_2v8: regulator-2v8 { + compatible =3D "regulator-fixed"; + regulator-name =3D "2v8"; + regulator-min-microvolt =3D <2800000>; + regulator-max-microvolt =3D <2800000>; + }; + reg_usdhc2_vmmc: usdhc2-vmmc { compatible =3D "regulator-fixed"; regulator-name =3D "SD1_SPWR"; @@ -824,6 +852,20 @@ IMX8QM_QSPI1A_DATA1_LSIO_GPIO4_IO25 0x0600004c >; }; =20 + pinctrl_i2c_mipi_csi0: i2c-mipi-csi0grp { + fsl,pins =3D < + IMX8QM_MIPI_CSI0_I2C0_SCL_MIPI_CSI0_I2C0_SCL 0xc2000020 + IMX8QM_MIPI_CSI0_I2C0_SDA_MIPI_CSI0_I2C0_SDA 0xc2000020 + >; + }; + + pinctrl_i2c_mipi_csi1: i2c-mipi-csi1grp { + fsl,pins =3D < + IMX8QM_MIPI_CSI1_I2C0_SCL_MIPI_CSI1_I2C0_SCL 0xc2000020 + IMX8QM_MIPI_CSI1_I2C0_SDA_MIPI_CSI1_I2C0_SDA 0xc2000020 + >; + }; + pinctrl_i2c0: i2c0grp { fsl,pins =3D < IMX8QM_HDMI_TX0_TS_SCL_DMA_I2C0_SCL 0x06000021 @@ -1017,6 +1059,22 @@ IMX8QM_LVDS1_I2C1_SDA_LVDS1_I2C1_SDA 0xc600004c >; }; =20 + pinctrl_mipi_csi0: mipi-csi0grp { + fsl,pins =3D < + IMX8QM_MIPI_CSI0_GPIO0_00_LSIO_GPIO1_IO27 0xC0000041 + IMX8QM_MIPI_CSI0_GPIO0_01_LSIO_GPIO1_IO28 0xC0000041 + IMX8QM_MIPI_CSI0_MCLK_OUT_MIPI_CSI0_ACM_MCLK_OUT 0xC0000041 + >; + }; + + pinctrl_mipi_csi1: mipi-csi1grp { + fsl,pins =3D < + IMX8QM_MIPI_CSI1_GPIO0_00_LSIO_GPIO1_IO30 0xC0000041 + IMX8QM_MIPI_CSI1_GPIO0_01_LSIO_GPIO1_IO31 0xC0000041 + IMX8QM_MIPI_CSI1_MCLK_OUT_MIPI_CSI1_ACM_MCLK_OUT 0xC0000041 + >; + }; + pinctrl_pciea: pcieagrp { fsl,pins =3D < IMX8QM_PCIE_CTRL0_WAKE_B_LSIO_GPIO4_IO28 0x04000021 diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek-ov5640-csi.dtso b/ar= ch/arm64/boot/dts/freescale/imx8qxp-mek-ov5640-csi.dtso new file mode 100644 index 0000000000000..153fca99af299 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek-ov5640-csi.dtso @@ -0,0 +1,63 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ +/dts-v1/; +/plugin/; + +#include +#include + +&i2c_mipi_csi0 { + #address-cells =3D <1>; + #size-cells =3D <0>; + clock-frequency =3D <100000>; + pinctrl-0 =3D <&pinctrl_i2c_mipi_csi0>; + pinctrl-names =3D "default"; + status =3D "okay"; + + ov5640_mipi: camera@3c { + compatible =3D "ovti,ov5640"; + reg =3D <0x3c>; + clocks =3D <&xtal24m>; + clock-names =3D "xclk"; + pinctrl-0 =3D <&pinctrl_mipi_csi0>; + pinctrl-names =3D "default"; + powerdown-gpios =3D <&lsio_gpio3 7 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&lsio_gpio3 8 GPIO_ACTIVE_LOW>; + AVDD-supply =3D <®_2v8>; + DVDD-supply =3D <®_1v5>; + DOVDD-supply =3D <®_1v8>; + status =3D "okay"; + + port { + ov5640_mipi_ep: endpoint { + bus-type =3D ; + data-lanes =3D <1 2>; + remote-endpoint =3D <&mipi_csi0_in>; + }; + }; + }; +}; + +&irqsteer_csi0 { + status =3D "okay"; +}; + +&isi { + status =3D "okay"; +}; + +&mipi_csi_0 { + status =3D "okay"; + + ports { + port@0 { + mipi_csi0_in: endpoint { + data-lanes =3D <1 2>; + remote-endpoint =3D <&ov5640_mipi_ep>; + }; + }; + }; +}; + diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boo= t/dts/freescale/imx8qxp-mek.dts index 44bda183492cb..c95cb8acc360a 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts @@ -64,6 +64,27 @@ usb3_data_ss: endpoint { }; }; =20 + reg_1v5: regulator-1v5 { + compatible =3D "regulator-fixed"; + regulator-name =3D "1v5"; + regulator-min-microvolt =3D <1500000>; + regulator-max-microvolt =3D <1500000>; + }; + + reg_1v8: regulator-1v8 { + compatible =3D "regulator-fixed"; + regulator-name =3D "1v8"; + regulator-min-microvolt =3D <1800000>; + regulator-max-microvolt =3D <1800000>; + }; + + reg_2v8: regulator-2v8 { + compatible =3D "regulator-fixed"; + regulator-name =3D "2v8"; + regulator-min-microvolt =3D <2800000>; + regulator-max-microvolt =3D <2800000>; + }; + reg_pcieb: regulator-pcie { compatible =3D "regulator-fixed"; regulator-max-microvolt =3D <3300000>; @@ -789,6 +810,13 @@ IMX8QXP_FLEXCAN1_RX_ADMA_FLEXCAN1_RX 0x21 >; }; =20 + pinctrl_i2c_mipi_csi0: i2c-mipi-csi0grp { + fsl,pins =3D < + IMX8QXP_MIPI_CSI0_I2C0_SCL_MIPI_CSI0_I2C0_SCL 0xc2000020 + IMX8QXP_MIPI_CSI0_I2C0_SDA_MIPI_CSI0_I2C0_SDA 0xc2000020 + >; + }; + pinctrl_ioexp_rst: ioexprstgrp { fsl,pins =3D < IMX8QXP_SPI2_SDO_LSIO_GPIO1_IO01 0x06000021 @@ -829,6 +857,14 @@ IMX8QXP_FLEXCAN2_RX_ADMA_UART3_RX 0x06000020 >; }; =20 + pinctrl_mipi_csi0: mipi-csi0grp { + fsl,pins =3D < + IMX8QXP_MIPI_CSI0_GPIO0_01_LSIO_GPIO3_IO07 0xC0000041 + IMX8QXP_MIPI_CSI0_GPIO0_00_LSIO_GPIO3_IO08 0xC0000041 + IMX8QXP_MIPI_CSI0_MCLK_OUT_MIPI_CSI0_ACM_MCLK_OUT 0xC0000041 + >; + }; + pinctrl_pcieb: pcieagrp { fsl,pins =3D < IMX8QXP_PCIE_CTRL0_PERST_B_LSIO_GPIO4_IO00 0x06000021 --=20 2.34.1