From nobody Sun Dec 14 19:32:32 2025 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B8DF22B8D1; Wed, 21 May 2025 16:17:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747844222; cv=none; b=e5d1bhItVNj1zG3+M2YGqvwhgs8SrbSxJndAKKZKpVBpCGI/eq2FdLopZsz17Tj/kVrYOQgMLUjwL+z1znAvGKz0BRo9S5xoieR56W+VvqauTCexYIHtHKxzWoLH4Xoh93llbu/h7OIm+1X1cd87ZEF+j9omIGnspGYCZpEJcRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747844222; c=relaxed/simple; bh=HyYC10+cmHPIFfp5MI8GIy37zCA+7WyuYe9ipa3HJ2g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J3WaJAZ5XIIqILJ8JyBTkYWDft6DQFblYY/zdrxkjHt8jAbrxpxr1C11VVR4fBvfWBZW+1+hohQEY5s3qUtUm1bS7EPIMSAtR2Ij8Jj+3mfihmJq4zaHa9e233rPJLLXlo25+uBDmPA/oYwmrGC1ZG0Cx3uxuf6vUSbnUGtMIhs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YLtnImql; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YLtnImql" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2cc89c59cc0so3337827fac.0; Wed, 21 May 2025 09:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747844219; x=1748449019; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qlyuxe0iXuDb4/CkEr8PEzYZZ4gXaPBKw8rPPD/nZJM=; b=YLtnImqlRgnAP24XIMx211Bu07xCd+pldNHo6lHvXUcVQxPTEaOYc8+VBf7A83rNN5 VF04ZHbW3D6GQBpnKnw4e+O69bLIsaslA9v0imtbd52b3uTz+NoOsOLEVbmJ0dBao2cN B8FWBf1tCkF6jike6m4t+tWQXxjb2eG284HZkZ7sZ1YTwMtiepkIIAgDvkB3DQEudaaW SvA17AeSnKU8P6OnasHgCVrguhTt3kMqXGwEqg88HhXDJtbCNp1M/IE8AKM77wMukMW4 FUpX6yDwlIor9jCYTDd+ITFATSm9Ak1rRtNppOYmqNuzzKlA9SEGpa7cfagIM9+3VrK0 uHGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747844219; x=1748449019; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qlyuxe0iXuDb4/CkEr8PEzYZZ4gXaPBKw8rPPD/nZJM=; b=sVuXmPtHRXz2haInrLgnOBksmEfbwOEm+kiCtkpGqYk14Nx/iuRF1Odo43MmZlvziu TDPkR1eNDlbKIS7+V3BOm08D2NzcST1eyUGAbrbXKr4AaZfMS3KPMpylOuD9aYjkXpAD DI07vDwoeYNwM7JDHMUfzYqTvwECvYuhoko7hmo1aO2qH+YGROUz2v+oCy/D/xtZNuHl BbO/FglPcX3L7j2zkzU9+/Pm5A8jDrg6WWLgPFbC94f7YnDg/d05C1pBGQrKuI2zFp9X DwFnb8glmuqji87fErBEFNDgPjhLrMkhjDGVYwjI0DCNevlTqhSPsOqt0DXgOq0pbgFw HQJQ== X-Forwarded-Encrypted: i=1; AJvYcCVZRCQFiFWQsZpFba026V7Cw6Uat1TZP92ZxzbggErhg/hT1d6qxBeYvGdvu/jHMEUO7rLQMN1B1yIWLVT47dp3TJAp@vger.kernel.org X-Gm-Message-State: AOJu0Yy0i6DjoHUwNk50CDZN2YIGQZdnTj0csR56eyS5CyUOcUHAqOGU NPxP2Jts38Q5VOt17bYL5SDIiWt6s5Y6vfW4KnfrXLRpTSIFAqD4HqwR5/bBLg== X-Gm-Gg: ASbGnct4ybl1569QnMpLmiQvekXFqideh+CD0P3d8f7+irrrt0sXvkmohdQNg8SH3eq G8Hx+4pM1XRqJ7PyENhkb8KaneTp5np1PiWqRgoS0pdYB/izczqSJEZZP4BjkxTA4k4IDexWOC3 XYz1v6HxLR0lHaZAIOd1d9Ya4PbSnfi7lejY+CgtJttv1t7NV1w1xclwqN9O7q9b/UGuDg1E8ur oe9kg26BVqvTBEdN7l4hk/ju5FbaHfosIK7mGsQu4cvPl4HsA+ZTBsoVs+aR7Y6788h4/JQXZ4F Ps/rV9LhRXB4rfFlmgGCk+e4jx9lhqGxj7U+qyJFW0cWBywNsAs0j/gXzUdhpGdv39hecqKe1zz gsYroulJwRF3qzd34Rg== X-Google-Smtp-Source: AGHT+IF41+uPMvlSyCLwpoeKoM++gP8xcY7T/VBGGT6PNWJ2zF+BgjWyKoOIRt9bT6mOCr7KUCa84g== X-Received: by 2002:a05:6870:51c6:b0:2d4:f2da:9bb8 with SMTP id 586e51a60fabf-2e3c274218fmr13657272fac.1.1747844219248; Wed, 21 May 2025 09:16:59 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-404d9809bccsm2180129b6e.29.2025.05.21.09.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 May 2025 09:16:58 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH 1/2] platform/x86: dell_rbu: Fix list usage Date: Wed, 21 May 2025 11:16:38 -0500 Message-ID: <20250521161639.47357-2-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250521161639.47357-1-stuart.w.hayes@gmail.com> References: <20250521161639.47357-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Stop using an entire struct packet_data just for the embedded list_head, and fix usage of that list_head. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index e30ca325938c..6a602a80160a 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -77,14 +77,14 @@ struct packet_data { int ordernum; }; =20 -static struct packet_data packet_data_head; +struct list_head packet_data_list; =20 static struct platform_device *rbu_device; static int context; =20 static void init_packet_head(void) { - INIT_LIST_HEAD(&packet_data_head.list); + INIT_LIST_HEAD(&packet_data_list); rbu_data.packet_read_count =3D 0; rbu_data.num_packets =3D 0; rbu_data.packetsize =3D 0; @@ -183,7 +183,7 @@ static int create_packet(void *data, size_t length) =20 /* initialize the newly created packet headers */ INIT_LIST_HEAD(&newpacket->list); - list_add_tail(&newpacket->list, &packet_data_head.list); + list_add_tail(&newpacket->list, &packet_data_list); =20 memcpy(newpacket->data, data, length); =20 @@ -292,7 +292,7 @@ static int packet_read_list(char *data, size_t * pread_= length) remaining_bytes =3D *pread_length; bytes_read =3D rbu_data.packet_read_count; =20 - list_for_each_entry(newpacket, (&packet_data_head.list)->next, list) { + list_for_each_entry(newpacket, &packet_data_list, list) { bytes_copied =3D do_packet_read(pdest, newpacket, remaining_bytes, bytes_read, &temp_count); remaining_bytes -=3D bytes_copied; @@ -315,7 +315,7 @@ static void packet_empty_list(void) { struct packet_data *newpacket, *tmp; =20 - list_for_each_entry_safe(newpacket, tmp, (&packet_data_head.list)->next, = list) { + list_for_each_entry_safe(newpacket, tmp, &packet_data_list, list) { list_del(&newpacket->list); =20 /* --=20 2.47.1 From nobody Sun Dec 14 19:32:32 2025 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8C541372; Wed, 21 May 2025 16:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747844223; cv=none; b=ZJOzs5fx7KE5AFe13+zsgV9dv5X0k0mm0vJzmeLby+V12beZtu2jkXKo0KLAatfVoXLlujdti4WUOn87UtJaCFQQufF26wlYwX85Fa+aP6y6Nt7e2/eQ3WrE3Ftn+OsJCRl1ntZZmF1JMcYDWuNmHzuXgOjAEVptIXNszpNVfZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747844223; c=relaxed/simple; bh=2dtOAUddtSvsu415GWAbHa+laloC6JCGcRZlcSsx8fw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o/ReQdNhFIFymBEXvbMOlNGcvm1bP65JY85IZMJEf7ecS2N8QW9/BXsOJ4yASQm0mZJio3c7uXLU9hAyqECUCiAB6x+7Xl6qKXpIPoEaIH8ETdaqyc0QEOpCIgJG3cygrjQfFIpm5PY2Ow2rCbeXbxIBJpxWVrVx3lEP3AH8P8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CRc3HZPQ; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CRc3HZPQ" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3fe83c8cbdbso2554709b6e.3; Wed, 21 May 2025 09:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747844221; x=1748449021; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S82yr5lePzBSesD0K5DFXc8OPBPiv5saKdlDUFM2LMo=; b=CRc3HZPQIG27tuXuuX2DcLWOKQW3aiVp410Xfifh9m7foAdNs1+HDaMPs/rOI8ORzF ETi36i3OoEWqg3I6RxbIur4GVE5N3Mmscn7Is4Ur9BrNhbkPU8hAgM6b08GmWop8mCiI rxs1HWhOhMxKbWXAvBUUBB6QJScE7Yb+0UnDLgfVw4/KBrQW6iws6nNNicyvWX4J7IYv WXUAzBzvy821zYM44zjrifE8O7Hhg9xj/mefIeJE40eTXRNWPqekfmKerS3MLR/KjNJk +EDBPa8xoI6kEan/W+EXMgNasMmecd+5CS5Vzv1ExiGxsjKtq2Ng87l4rzkHu/sIy+Ks HJxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747844221; x=1748449021; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S82yr5lePzBSesD0K5DFXc8OPBPiv5saKdlDUFM2LMo=; b=lZZkhljN8CQeCx78/Ozp52/X3MqWa3MVvuW0pSDhk6NrCfwXhd4cw93fKVyUg0Mvh4 1DNuIUo9DcBTRov6ndtQTClLOyiUqkfbDlQ5Ms/sT1afIUaCWWHi5F6gUKxUaLKegSbc aYjG3rbnt1KpJp7p+jaTcmwxcQjqdFWewwYV1BfyMgO3O3bfcl5bRNsCbURJZM3ixa18 eIPkBsV9d5WEyN8c+xFRK7a9L2fta4C+DcRNoNvtgP19yqt7X3pLbvx7OZpMT3A8CIdU z1OD2aPjuJQYuuQHm9UvR0U4j+BnAWNtqFFGtMeXhEXth9Jfv+QS8IZiDQM3AzeP5zes Pweg== X-Forwarded-Encrypted: i=1; AJvYcCXsoXw4Y0a9nbMxeH6l/u0CqyToMYXBA7PIIk7+VMVMaapDf7R1Sm4uAvuhDtEvbhK1oWm8rMarztELN069LjD/Crn1@vger.kernel.org X-Gm-Message-State: AOJu0YzrB2Y565thiUL55nSwHtPGhhC3Wv63kh1VwH6hk6A1/q0j2aiw qMXMSeR6W6WEtzi65tcPN3CkH9g4JiykAXJCGz4ch+MEqBOLOna/B1rLJfChBw== X-Gm-Gg: ASbGnctCXdpzhTEQPGQJYQHC8JhQSyx9ozD2ynZeXs2NaRCcqXWb3rXLuKfi4T8N56N +JZVAQ79N1zVRA2UMGrGJ+cJJj2lmVnGj+LRWRSXv1yK+euIKWo+MJNLdFIKOCbcJ+qQ4YlduDQ GtmPt3LrSIJkRO1UE5USWzdA0pCDVSvK/SgCY5rofQs7Lp3vDTPIS4vQjw/jAwRiXiC24sCdxzR tX7foMwWQtiaq3RLFr1wBoyqZCsRq28qR0QICRefNzrsXsEsDpoQ4zehgWhtduN6HFysFsnzu8Q tzRMnmqMUuqwQk4rTsyNXXy9t1f3h5Fi1NzkkY4mgDTVlZ+sWN+WI8QQoxgWfg+24jiF2kq/EqZ d+iHvvsLffsaFm+P27A== X-Google-Smtp-Source: AGHT+IFmzQsQ0bpXXAkiXBa+TSHO8qNIF6q/Ml7bs/9rjpm0CwHDGg5gOnsSjELLHCAw9jmGLfBG0g== X-Received: by 2002:a05:6808:624b:b0:3f6:8c64:8bc8 with SMTP id 5614622812f47-404da82c656mr9629207b6e.38.1747844220776; Wed, 21 May 2025 09:17:00 -0700 (PDT) Received: from localhost.localdomain.adc.delllabs.net ([143.166.81.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-404d9809bccsm2180129b6e.29.2025.05.21.09.17.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 May 2025 09:17:00 -0700 (PDT) From: Stuart Hayes To: linux-kernel@vger.kernel.org, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Cc: Stuart Hayes Subject: [PATCH 2/2] platform/x86: dell_rbu: Stop overwriting data buffer Date: Wed, 21 May 2025 11:16:39 -0500 Message-ID: <20250521161639.47357-3-stuart.w.hayes@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250521161639.47357-1-stuart.w.hayes@gmail.com> References: <20250521161639.47357-1-stuart.w.hayes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dell_rbu driver will use memset to clear the data held by each packet when it is no longer needed (when the driver is unloaded, the packet size is changed, etc). The amount of memory that is cleared is (currently) the normal packet size. However, the last packet in the list may be smaller. Fix this to only clear the memory actually used by each packet, to prevent it from writing past the end of data buffer. Signed-off-by: Stuart Hayes --- drivers/platform/x86/dell/dell_rbu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/de= ll/dell_rbu.c index 6a602a80160a..bedf03fa4f41 100644 --- a/drivers/platform/x86/dell/dell_rbu.c +++ b/drivers/platform/x86/dell/dell_rbu.c @@ -322,7 +322,7 @@ static void packet_empty_list(void) * zero out the RBU packet memory before freeing * to make sure there are no stale RBU packets left in memory */ - memset(newpacket->data, 0, rbu_data.packetsize); + memset(newpacket->data, 0, newpacket->length); set_memory_wb((unsigned long)newpacket->data, 1 << newpacket->ordernum); free_pages((unsigned long) newpacket->data, --=20 2.47.1