From nobody Sun Dec 14 19:30:17 2025 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2070.outbound.protection.outlook.com [40.107.101.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D950B222595 for ; Wed, 21 May 2025 15:46:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.101.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842383; cv=fail; b=fbw4myvTK/7v/40rT/LKSZMW7yEIGf6/dABQpE429IicTzZBta3MQJSSNAsN2W6VVetA2GTVx9trVGTQpDWLpSJK7pT/qsYI3crxhYjT1A78YNjj8xvRFx9ZrbJSO3nwzL67Alr9JMA7FhX6+2YDuVlGS2tbjIFZnLBBZ7NOsXo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842383; c=relaxed/simple; bh=vjmDnSkdlZt/DhCTho+/Avo1f7AVJwHzyIdzmT9zBKs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hwus9p515CSPOkzEmKkTg5n25c3S/HyywR14q2vOR6BXZcQEzokHC0WfrvFaK03rDt1VTqCFd9I6UkzNR100pxtlg3ndQNSK2qVweYZ2nS/EF8HLr3uk6uOYjbPE5usq2bIkjsVpZ39BJB6smP8r4Hee7RRSYz0TBlGtNianXtE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=hBRMPQMn; arc=fail smtp.client-ip=40.107.101.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="hBRMPQMn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R6r6IFfn7FrqlsH3hiw92nU8NFsZ5aLcGjz0njg/m50AaBy4E0AbE7WheAhuBPhrOPeJyVxSyCOXoVYXjkq/d0M0HkZxrETzXLlF4i6jfhlDTxdL2pxPt9+TX+Jzi/q76nHOPoFdYbDnbO96AuITiRpSrc0qnGvJ5yjAmB6iOBQEtKSzMXhVskgNOuWK2P1S1h2sNadTYTdXlGuyYYJE7bY69h1Xv4hlbR5v4BbgR82B8DD40hFTxF2zxyB2xmnzkxGOd/0SpYdELMiUN1hvXsvTpzLwjDQv6S2NZKSyo+HZenT78MVCVDevAwFjX84NJy56WM3Ule8MUGRkqBsvrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YExrLBNmjk0Jky++4o/V4jEROgJRqTpVnrXzJ5VrY0A=; b=xJegTT9XyijssmQ7dNppzfRNQVBjmWq52fBmeNiSv28A8SQuCswH5xUWwPuudNSyRTvmVzA+m+jCtwLmhA4vL7Otdm6PuM/kxDA1ClWwSaDKjWRTclBweDUrYUU4TyUBNGMvd5whvWdhpiJruv5p+MdhNRT/D/vGw9vrzS3KzlznAhmydDzlhPaaYIz+iflczRNqn9fOZQvVhf56KiURoU2EaVtMxGmVx2UW+2/1Ig69ro1ih1VikT13ySLIKt8uwwrW5gDvOxrvUZlT/238x3+Msq+OX0idFrblvQlXylVW4G7SFcSddotWtYp1FZAvd5uU36M5V7qSNcz3m4NjbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YExrLBNmjk0Jky++4o/V4jEROgJRqTpVnrXzJ5VrY0A=; b=hBRMPQMnr+jqkeSJAlED/tntt//5ApdIvnhpOd8v1GBh5bL8qUsCmmXkHdU/nPQJGLAlLJWjDcvqLn2bktpeMS0NP1vl3iUOBCt0Y2TgWSlDfoPsISw3uPcShv4ybBAiawvIhWQl7fX9Od69AbTjbVeySKIPb72eZOMl6OP0ysY= Received: from SJ0PR03CA0335.namprd03.prod.outlook.com (2603:10b6:a03:39c::10) by DM3PR12MB9415.namprd12.prod.outlook.com (2603:10b6:8:1ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.31; Wed, 21 May 2025 15:46:11 +0000 Received: from SJ1PEPF00001CE8.namprd03.prod.outlook.com (2603:10b6:a03:39c:cafe::9f) by SJ0PR03CA0335.outlook.office365.com (2603:10b6:a03:39c::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:46:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE8.mail.protection.outlook.com (10.167.242.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:46:10 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:46:07 -0500 From: Pierre-Eric Pelloux-Prayer To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Pierre-Eric Pelloux-Prayer , =?UTF-8?q?Christian=20K=C3=B6nig?= , , Subject: [PATCH v10 01/10] drm/debugfs: Output client_id in in drm_clients_info Date: Wed, 21 May 2025 17:45:03 +0200 Message-ID: <20250521154531.10541-2-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> References: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE8:EE_|DM3PR12MB9415:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a302347-a292-41e8-4132-08dd987e9bf6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MzRhdjBTSTZEbmRLVGFCWEliK0lVLzhtUDh3bjJzY2p2LzM2eWdEWm5URk9m?= =?utf-8?B?STNmYU9YNUo0cW5UWW1JSjNwakhxU01aQWhTbVhDN1daT3B3WmwrVGpReTU1?= =?utf-8?B?MzhZQm0xN0NmaEk1N0xLM3o1eXJCWXk0QVpUek5MbzJEUE1xSXRScjZ6WVIv?= =?utf-8?B?ekNLZ2orY0dkeEo0YllYSkQrcTVBQTNraWdNdERPMWdEZXJQZHJzVkVIV21G?= =?utf-8?B?WHRsNE9tVjJPMG5UNUhHNnZjbm11RFFjVmhxYU9MMzBtRUt3d2NJMThaOUJS?= =?utf-8?B?M3YvZTBVd0I5RUZOZk9UVEkxU29kM3N5VTl6K0p4bkpRMGJnS05rNzU5Z093?= =?utf-8?B?K3o2MnVRc2psbjNFaVRSa3VubGN6Yml1N2JpcFpTNGJrUklOR25Ld2xEKzhN?= =?utf-8?B?alMzeWpJcWpRNzNqYmwwL2xhTWNyQ1RMK3ArSSsvOS9FY0s4elA1NFRvM2Nk?= =?utf-8?B?cXBFcS9MaTZ6a2ZLV2kxcUdpOTVMS1ovLzlGd0ZiSlhoZmsvWGNwTnp0cnpN?= =?utf-8?B?aEJONytmN3E1NGlzOUV6Z2hSc1ZTVlAwWUVNQ3NvbU5lR3M3dlpOYU4wZ1hG?= =?utf-8?B?LzhrNXNybmNDaGJVTmNUTm11YmZYL213Uk5XekVRYTROWlVtNDF1S3piZ2FC?= =?utf-8?B?K3NqZXBKR3F6NW5GaWhPLzZyUEhiUzJodDJvUGNBSjlzOVRmQlhoUmlJYzU3?= =?utf-8?B?ODVUcUpQT2UvRlBoSnlEQmEwT2hyYmZUYU1hL3E1Y2ZjSUhLVHlkMmxrZk0y?= =?utf-8?B?L2tLVWNPVDE3a0N5SUxXZnI0VDFpM0Rzb0N6ZjdNd2FqSllIU0I4TThFbUdx?= =?utf-8?B?TGNudnJzVWE3bE4xRkhJdWpiS2hTVFFtMjYwL1RmSW1DWnFzTnFxZEZOaDVv?= =?utf-8?B?Q2hJN3BRcVBTSFVnK1dBaE9FV2I3RWJBdURrdzY2bGpyc2YrbVRvbS8rNEc3?= =?utf-8?B?ZTRUdDE1TEtKNGo5R1F1a0h5SXhORnpCY2NHTjFCbU9LQUFjTittOWFpdVlI?= =?utf-8?B?ajFYNFJpaThNbTlDSGw3VUg1ckRaRW54aWNFaU5VRHptUEJHcnpQbjVXMCsw?= =?utf-8?B?ZlpSZTBkRkQ1NEtNUUVUMkJYeGdRR0ZZWkNxRVhUakFrSklidENJWTJQSFJl?= =?utf-8?B?U3U3bGJ0c1VjYldEWHFqNWxOanhxYW5vdEtYNVZldDcvU3V3N1NydTBOMTU0?= =?utf-8?B?SXRvd2drVnR1T29sQXl2L1A3cGttYUNobHQrbWNyUnRWeE91eFRRSTlNaVIr?= =?utf-8?B?b0lOQk1yM0V3eEJyMmN3S1FUbFJ1K1prSUVKNHk3OUgvM3JYbVgzS3JJTXNU?= =?utf-8?B?WGVGWWNFdjRUYXpUeXR4dEhIVU5HT2FkZ3RQa2tMYWZKNTRPUFFtWktGZUI3?= =?utf-8?B?dVpJYkx2aEVJL0EzemNURUpUTURaVlliUTJaaGRVbHJSR09sTTEvVEVZb0s1?= =?utf-8?B?Y25ueWJHVWo4L2xPS1lVdTEvWnF5Umx1aUVKdzBXVnVmZ0xCQm13ekt5aHg5?= =?utf-8?B?MHV0T0J2OWFzSVBYaVMzK2FURVVlWXQwUjF0UWtrV1BBRUtrYjNpczJrNXVW?= =?utf-8?B?Q2FJYmYvY3U1RlBPRmNIRFBkejZ5VHNPbTMrRVZtWGxGVzNuRFcwbkxrVHNS?= =?utf-8?B?ajRMZTFJLys1SjMzTnBaVGdIUEFVeTFORXNxeUJMaTlTUHlDMTFEdDVNS2dz?= =?utf-8?B?M2tqa0Zmc1JJWVlXUGRPTUpMb0RuVjFWNGYzNXhoQ1JxYUFpTktrOFdFNzEz?= =?utf-8?B?K3ZocnpxMUE4ekNvckxFUGl5NVRjeGVQelJzWWs2MEJzUmtIZlFtZ1RqR1Av?= =?utf-8?B?ZHF4VitaV0hTdkJieHlWOWg3VUhIRUt3RE5kUmJqYkYzYnduZENIYjQxbE5y?= =?utf-8?B?dk5aaU1tYVRGL0NEaHF0bEt6NHdRNmcwTFBySk0zdHR0NytiYUNNNmRLVTJQ?= =?utf-8?B?cHRkZEx2NTRrbkZLQU5mZVZjM0tySWVlOHdwT2M0akp0Z25JT3pzTXZMVW5F?= =?utf-8?B?SEZ2bmZGVmwvRnkvajNTWmJDbTFPQVBKbDl0YmMvR3R4cGtDYnRtK1BCeFph?= =?utf-8?Q?Glvq0T?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:46:10.4419 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a302347-a292-41e8-4132-08dd987e9bf6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE8.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB9415 client_id is a unique id used by fdinfo. Having it listed in 'clients' output means a userspace application can correlate the fields, eg: given a fdinfo id get the fdinfo name. Geiven that client_id is a uint64_t, we use a %20llu printf format to keep the output aligned (20 =3D digit count of the biggest uint64_t). Reviewed-by: Christian K=C3=B6nig Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/drm_debugfs.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index 3dfd8b34dceb..abceb28b23fc 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c @@ -77,14 +77,15 @@ static int drm_clients_info(struct seq_file *m, void *d= ata) kuid_t uid; =20 seq_printf(m, - "%20s %5s %3s master a %5s %10s %*s\n", + "%20s %5s %3s master a %5s %10s %*s %20s\n", "command", "tgid", "dev", "uid", "magic", DRM_CLIENT_NAME_MAX_LEN, - "name"); + "name", + "id"); =20 /* dev->filelist is sorted youngest first, but we want to present * oldest first (i.e. kernel, servers, clients), so walk backwardss. @@ -100,7 +101,7 @@ static int drm_clients_info(struct seq_file *m, void *d= ata) pid =3D rcu_dereference(priv->pid); task =3D pid_task(pid, PIDTYPE_TGID); uid =3D task ? __task_cred(task)->euid : GLOBAL_ROOT_UID; - seq_printf(m, "%20s %5d %3d %c %c %5d %10u %*s\n", + seq_printf(m, "%20s %5d %3d %c %c %5d %10u %*s %20llu\n", task ? task->comm : "", pid_vnr(pid), priv->minor->index, @@ -109,7 +110,8 @@ static int drm_clients_info(struct seq_file *m, void *d= ata) from_kuid_munged(seq_user_ns(m), uid), priv->magic, DRM_CLIENT_NAME_MAX_LEN, - priv->client_name ? priv->client_name : ""); + priv->client_name ? priv->client_name : "", + priv->client_id); rcu_read_unlock(); mutex_unlock(&priv->client_name_lock); } --=20 2.43.0 From nobody Sun Dec 14 19:30:17 2025 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2063.outbound.protection.outlook.com [40.107.101.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DD0420CCF5; Wed, 21 May 2025 15:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.101.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842397; cv=fail; b=tnrUK59BdP0P5RI3i8cUnTF+Ld94vcKxyZlp92L6pxkBBe6+vldh2wEPEmf5R60+B7nllw/Dsbz47a29DPJaB49zvlMxa4HPE/PpgQWGTGGn3OEBXo50NHEqUZWbuEeGhvOh56qhl0gRT3IMPnY8ZvlWbiQID/eGG3j+xnU/eSc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842397; c=relaxed/simple; bh=yERumP7u7gENIvjyqngYgOq3lEXbpuzs8tIu3ckHuN4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m7EHaxDjlqkexUmlE23GTB4vi9p3yDd563JkhemT4uMnj0c7Mjs5ruCFwuTw4xgZHc/dJ6GAaeYA0oqVcc+6dCM/n9Tvs+3t8Uid3yVi+Rz0G7RZeVaXR3NzNOfWFRoOiSsotY0wnO4M/ttV55Lj4LKXzUCDEtBMtYCsS/9//jI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=dV+7xhRU; arc=fail smtp.client-ip=40.107.101.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="dV+7xhRU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ihpoZBWWfbLuqIx+coVKEulSDMFRosifjZZ+gJSTHT/7CV0S+JL9V85COaHPUdCsqxEsL6bNmOW9iUpvD0Vjcsvq2BcP+wWJTJHWHVNMe166WNosF+Qg2MN65ESH1KkkOnLnKEWsZCAXxdww3qRDA2a2UpFpnJFbNn8g0TAGwdB4TVDJWfePFRpU4Q4uCxewfKqBMK7D0Nuc7HDJYceHYgTJUVy38ac8hOL5CtMwkysOxAwAtZ8rclDmUIy/sIHxfnwIBBJx7S+HQaTO1BnsiEjEH9Ote8TNyIEhAPfXcsmT4qT/2OCIv64f8XCvwSblaORY5TgI1dmru6uAwqC2og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vHFOBh+KMLnECp2wCZwFZd/BmTBg98tYy7ffcp0+n8A=; b=Ut6EjckOc6bHqxg9D8vWp1+7xC2OVAT2JE/GwqMkfnUNI0ibGsDAz7xvwhBgt6226S6m3NZqYqYy68c9n2gA35sFOrz9uWFzlWRDHtehapK1bH+u7I23Tf+/jpDi4NKnXwRE0TxbazCRmeSsm9Sp4pJKM5mYq2OxFkXPMlyTZ0Yg6yOYPPW1W+t79JiKaWMHpTvlT9YwWjRJoQqdIN5VWZ8cnxO0KYBw5fSpTRzAX8FOK4df3GTfb+i9lVT0VOORZ22r7lnaypz8k2FeE9W3R3FS+PMnfleB5AH26rEnuQG5h7JcKH8PrYMpaoJNE1P5bFR+1HWtZQtbGvPPHPb6Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vHFOBh+KMLnECp2wCZwFZd/BmTBg98tYy7ffcp0+n8A=; b=dV+7xhRUNyT9fVU7joRcmnio1mUUMQc454bugyuYi7UijZzIYW8/G2jhNwgweX+7rQiwaoWOfZJVLTgMhry2FZIatNnkiMWPPMqlV/vmiAyQs66VvWOfsJ0DWsc/gmZX6vrZhmhb0wzXeTBr271OYMXhaskpKRCuvOtYYE5Iu34= Received: from MW4PR03CA0315.namprd03.prod.outlook.com (2603:10b6:303:dd::20) by MW4PR12MB7335.namprd12.prod.outlook.com (2603:10b6:303:22b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Wed, 21 May 2025 15:46:26 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:303:dd:cafe::4d) by MW4PR03CA0315.outlook.office365.com (2603:10b6:303:dd::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8746.26 via Frontend Transport; Wed, 21 May 2025 15:46:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:46:26 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:46:17 -0500 From: Pierre-Eric Pelloux-Prayer To: Min Ma , Lizhi Hou , Oded Gabbay , Felix Kuehling , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , Lucas Stach , Russell King , Christian Gmeiner , Frank Binns , "Matt Coster" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Qiang Yu , "Rob Clark" , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , "Marijn Suijten" , Lyude Paul , Danilo Krummrich , Boris Brezillon , Rob Herring , Steven Price , Liviu Dudau , Matthew Brost , Philipp Stanner , Melissa Wen , =?UTF-8?q?Ma=C3=ADra=20Canal?= , "Lucas De Marchi" , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Rodrigo Vivi CC: Pierre-Eric Pelloux-Prayer , =?UTF-8?q?Christian=20K=C3=B6nig?= , , , , , , , , , Subject: [PATCH v10 02/10] drm/sched: Store the drm client_id in drm_sched_fence Date: Wed, 21 May 2025 17:45:04 +0200 Message-ID: <20250521154531.10541-3-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> References: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|MW4PR12MB7335:EE_ X-MS-Office365-Filtering-Correlation-Id: 3736a5da-2d9c-4557-8124-08dd987ea538 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|36860700013|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U01ZRkloZjRPSmdXa1pJTkh4bFRoZlJEUUh4ako0UGVjWWVxTXJqbGZwZDhE?= =?utf-8?B?S3lwSU05aTFiNHdUMU5ycTBUTTQ5aFVKZ1RSVW1xWENuMFZnRHorU01RQzh4?= =?utf-8?B?VldRcXVLZFBEekY0U2ZHbTRlVy9KT3dReWVoNDlxMm1OblJSaUZnOVBlOGd2?= =?utf-8?B?ajM3WHhHSVdRd2JoYWNMZE5MNmxTSHRGNDRZRUMwQVFraVJoMWRmK1pWbUtW?= =?utf-8?B?Zk11czExVzhlZzM0aFRxcERVSnJnWExaWkF3SEtkeXhUNU5nNXBEYmRqMHRx?= =?utf-8?B?dDVQY0FoZkpMVXh0NHB6R291WWJ5aVUxaHZWOERsSUl3em5GK0w4YWw5OEdn?= =?utf-8?B?cVZMaTh4Rnk0ckJudFA2eWNXTm4wODlzeDM2UE5CRERTNDJKc1pRNkNJa1ZU?= =?utf-8?B?K3FmcXZ6N3VHQndYMHVlME1MVHpoclEwR1ZCbjJCSGlVUjNUUWpVeFJSMzVo?= =?utf-8?B?bTQ2bnRTSG9mbXFscjF5MmQ4eWVSNGRDdjYzc0lzQUVQYUIwUVpFMitNZU1w?= =?utf-8?B?cnVkT2thUUdVT3BRYXVmN1NYMVNsZ3k5RmQxNHpmR3NCci9DVHloV3lRZzJF?= =?utf-8?B?SUFuMUlUZHVzR2tHQk9CMTVlbXprSHJPN2RVZ2RRRGpKNGd1ZlBVY2ViM3lO?= =?utf-8?B?QVlnbzY3ZVp1YWhaaFcrL0t0WjVEeXhTL09aT1FORGhsODUxU1RNanozY2dz?= =?utf-8?B?VkFQUVJiR2IvQTBGZEE4QS9ORUJKWkkwVnNDcUQ5VnBkY0hxWWVDUEdTRnJs?= =?utf-8?B?R05BS2NtOFBuWEg2SGFBemw0NHo5SElJN2hQa1JUUnZIOWZleS9DL1phOHow?= =?utf-8?B?SEM4UVEvd2g5UnpkU2thdGZGZmZmb1lhOXpaVUpCZCtpSjRpb2g2WHBmaHNv?= =?utf-8?B?aHJUdkpKY2UyUUh2R2xvNnh6RVBIdGFPWEpGMHhOSGJGQWlhREw0TWF2b1l1?= =?utf-8?B?cXFuZE1JSkk0L2xhQ1Z0N3FOa29XbHF0cnRnbnNzaEV1YWoxdWpJcS9lRGgv?= =?utf-8?B?TlF2Q3NnalFka05IdmNHTTk0VHpwZkJKUERyS1JTM2dIRnIwb1F4Rnh0NGFa?= =?utf-8?B?UEhsSS9ZTzNuK1FrRlFjRGxPL2NtU3JmQWZlR1Q2N0ZDdG1PT3FKZlJTYjgz?= =?utf-8?B?WUxZOWVncUZjUjRtaWNObWJjK3hxNTF2cWF0N2JEUjduTlI4OWpzYXFEVlNu?= =?utf-8?B?T2VNN0hHTHlKRmJaNjRneHBMT0I0dFZWbm9ISjNpaUpVMkRySENYTWs1Vldh?= =?utf-8?B?SWFUSmlkdkJhY2NUV0xweVlpc3dwbE0vOE1CTHhUdlRLL3lpZTFZaFRhTDJV?= =?utf-8?B?aWROQ3V6OHRDU3M4dC9tQ2U3QS9jQTBzWkJmend3VmQ4OER2NW5LQ3R1VFg2?= =?utf-8?B?c1BOdUxESm1EVllnY3M0bEl2VVhnQnUvbWxvcGJ6TTBPc3hpT0p5eGh3Y0Vh?= =?utf-8?B?TUxtTnlWR1RYWUQrRFBmTHg5TDRHeGJvU3VYaWc2bk03TWV6NTZIMlFXb0Mw?= =?utf-8?B?a1p5amhiU1Nkb3AyVWtib0VjZHlERmNDSWhGaVZoQTZKYTd0YTFJOFVxbEFF?= =?utf-8?B?c0R6Und5R2pTQWV0QUFCSHlGcnhjV2RqQ3lhcHhOY1I3MVZOeGFWaTJqYWls?= =?utf-8?B?LzRNdDdxVXc5OUtwSDZmZzc2NXR6UkVoam41VFRRTExVandoNGRaSkdIaERP?= =?utf-8?B?Vy8yUlFLeWhySGNUaGNQcGovbDYvekRUVEMweENFTzZxOVFFQVV0SEU2ejhW?= =?utf-8?B?K3Q0dmNSNHFVUmxIWVgza2pFWk81NHlmeFhDazJXWEdINE1GenNhUTZLNldk?= =?utf-8?B?bXZubGhNK3o0dlY0S1Q4QSs5QU1uYTV5ZzFNOHRaUDVjeFR0SldWeEdETWN3?= =?utf-8?B?Y0d4Q0RWS2wvc25MbUQzUEJsZVlEbnd5UnRsandIUUZEazlKZm9NS05CUHNU?= =?utf-8?B?ODQzQnpnSGdzb2RERUlIZ1VXK3hFMHRDVDU1c1pWRllKaWFFeHRjVnQ4RVFs?= =?utf-8?B?OFlYc1RjcEpUaVZ6aVdOaEVmbXo0cUZONnh2dng0RmVEclB4Q0tGdlZ1MmVz?= =?utf-8?B?Zm4yWlE2NCtYODdVS2Q3VFJVL0pTM05yb0xkQT09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(36860700013)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:46:26.0458 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3736a5da-2d9c-4557-8124-08dd987ea538 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7335 This will be used in a later commit to trace the drm client_id in some of the gpu_scheduler trace events. This requires changing all the users of drm_sched_job_init to add an extra parameter. The newly added drm_client_id field in the drm_sched_fence is a bit of a duplicate of the owner one. One suggestion I received was to merge those 2 fields - this can't be done right now as amdgpu uses some special values (AMDGPU_FENCE_OWNER_*) that can't really be translated into a client id. Christian is working on getting rid of those; when it's done we should be able to squash owner/drm_client_id together. Reviewed-by: Christian K=C3=B6nig Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/accel/amdxdna/aie2_ctx.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 8 +++++--- drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 3 ++- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- drivers/gpu/drm/imagination/pvr_job.c | 2 +- drivers/gpu/drm/imagination/pvr_queue.c | 5 +++-- drivers/gpu/drm/imagination/pvr_queue.h | 2 +- drivers/gpu/drm/lima/lima_gem.c | 2 +- drivers/gpu/drm/lima/lima_sched.c | 6 ++++-- drivers/gpu/drm/lima/lima_sched.h | 3 ++- drivers/gpu/drm/msm/msm_gem_submit.c | 8 +++++--- drivers/gpu/drm/nouveau/nouveau_sched.c | 3 ++- drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- drivers/gpu/drm/panthor/panthor_drv.c | 3 ++- drivers/gpu/drm/panthor/panthor_mmu.c | 2 +- drivers/gpu/drm/panthor/panthor_sched.c | 5 +++-- drivers/gpu/drm/panthor/panthor_sched.h | 3 ++- drivers/gpu/drm/scheduler/sched_fence.c | 4 +++- drivers/gpu/drm/scheduler/sched_internal.h | 2 +- drivers/gpu/drm/scheduler/sched_main.c | 7 +++++-- drivers/gpu/drm/scheduler/tests/mock_scheduler.c | 2 +- drivers/gpu/drm/v3d/v3d_submit.c | 2 +- drivers/gpu/drm/xe/xe_sched_job.c | 3 ++- include/drm/gpu_scheduler.h | 10 +++++++++- 26 files changed, 63 insertions(+), 34 deletions(-) diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_= ctx.c index e04549f64d69..3e38a5f637ea 100644 --- a/drivers/accel/amdxdna/aie2_ctx.c +++ b/drivers/accel/amdxdna/aie2_ctx.c @@ -848,7 +848,8 @@ int aie2_cmd_submit(struct amdxdna_hwctx *hwctx, struct= amdxdna_sched_job *job, goto up_sem; } =20 - ret =3D drm_sched_job_init(&job->base, &hwctx->priv->entity, 1, hwctx); + ret =3D drm_sched_job_init(&job->base, &hwctx->priv->entity, 1, hwctx, + hwctx->client->filp->client_id); if (ret) { XDNA_ERR(xdna, "DRM job init failed, ret %d", ret); goto free_chain; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/a= md/amdgpu/amdgpu_amdkfd.c index 4cec3a873995..1a77ba7036c9 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c @@ -639,7 +639,7 @@ int amdgpu_amdkfd_submit_ib(struct amdgpu_device *adev, goto err; } =20 - ret =3D amdgpu_job_alloc(adev, NULL, NULL, NULL, 1, &job); + ret =3D amdgpu_job_alloc(adev, NULL, NULL, NULL, 1, &job, 0); if (ret) goto err; =20 diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/a= mdgpu/amdgpu_cs.c index 82df06a72ee0..5a231b997d65 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -293,7 +293,8 @@ static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p, =20 for (i =3D 0; i < p->gang_size; ++i) { ret =3D amdgpu_job_alloc(p->adev, vm, p->entities[i], vm, - num_ibs[i], &p->jobs[i]); + num_ibs[i], &p->jobs[i], + p->filp->client_id); if (ret) goto free_all_kdata; p->jobs[i]->enforce_isolation =3D p->adev->enforce_isolation[fpriv->xcp_= id]; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/= amdgpu/amdgpu_job.c index acb21fc8b3ce..75262ce8db27 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c @@ -204,7 +204,8 @@ static enum drm_gpu_sched_stat amdgpu_job_timedout(stru= ct drm_sched_job *s_job) =20 int amdgpu_job_alloc(struct amdgpu_device *adev, struct amdgpu_vm *vm, struct drm_sched_entity *entity, void *owner, - unsigned int num_ibs, struct amdgpu_job **job) + unsigned int num_ibs, struct amdgpu_job **job, + u64 drm_client_id) { if (num_ibs =3D=3D 0) return -EINVAL; @@ -222,7 +223,8 @@ int amdgpu_job_alloc(struct amdgpu_device *adev, struct= amdgpu_vm *vm, if (!entity) return 0; =20 - return drm_sched_job_init(&(*job)->base, entity, 1, owner); + return drm_sched_job_init(&(*job)->base, entity, 1, owner, + drm_client_id); } =20 int amdgpu_job_alloc_with_ib(struct amdgpu_device *adev, @@ -232,7 +234,7 @@ int amdgpu_job_alloc_with_ib(struct amdgpu_device *adev, { int r; =20 - r =3D amdgpu_job_alloc(adev, NULL, entity, owner, 1, job); + r =3D amdgpu_job_alloc(adev, NULL, entity, owner, 1, job, 0); if (r) return r; =20 diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h b/drivers/gpu/drm/amd/= amdgpu/amdgpu_job.h index ce6b9ba967ff..5a8bc6342222 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h @@ -90,7 +90,8 @@ static inline struct amdgpu_ring *amdgpu_job_ring(struct = amdgpu_job *job) =20 int amdgpu_job_alloc(struct amdgpu_device *adev, struct amdgpu_vm *vm, struct drm_sched_entity *entity, void *owner, - unsigned int num_ibs, struct amdgpu_job **job); + unsigned int num_ibs, struct amdgpu_job **job, + u64 drm_client_id); int amdgpu_job_alloc_with_ib(struct amdgpu_device *adev, struct drm_sched_entity *entity, void *owner, size_t size, enum amdgpu_ib_pool_type pool_type, diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm= /etnaviv/etnaviv_gem_submit.c index 3c0a5c3e0e3d..76c742328edb 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -534,7 +534,7 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, vo= id *data, =20 ret =3D drm_sched_job_init(&submit->sched_job, &ctx->sched_entity[args->pipe], - 1, submit->ctx); + 1, submit->ctx, file->client_id); if (ret) goto err_submit_put; =20 diff --git a/drivers/gpu/drm/imagination/pvr_job.c b/drivers/gpu/drm/imagin= ation/pvr_job.c index 59b334d094fa..7564b0f21b42 100644 --- a/drivers/gpu/drm/imagination/pvr_job.c +++ b/drivers/gpu/drm/imagination/pvr_job.c @@ -446,7 +446,7 @@ create_job(struct pvr_device *pvr_dev, if (err) goto err_put_job; =20 - err =3D pvr_queue_job_init(job); + err =3D pvr_queue_job_init(job, pvr_file->file->client_id); if (err) goto err_put_job; =20 diff --git a/drivers/gpu/drm/imagination/pvr_queue.c b/drivers/gpu/drm/imag= ination/pvr_queue.c index 5e9bc0992824..5a41ee79fed6 100644 --- a/drivers/gpu/drm/imagination/pvr_queue.c +++ b/drivers/gpu/drm/imagination/pvr_queue.c @@ -1073,6 +1073,7 @@ static int pvr_queue_cleanup_fw_context(struct pvr_qu= eue *queue) /** * pvr_queue_job_init() - Initialize queue related fields in a pvr_job obj= ect. * @job: The job to initialize. + * @drm_client_id: drm_file.client_id submitting the job * * Bind the job to a queue and allocate memory to guarantee pvr_queue_job_= arm() * and pvr_queue_job_push() can't fail. We also make sure the context type= is @@ -1082,7 +1083,7 @@ static int pvr_queue_cleanup_fw_context(struct pvr_qu= eue *queue) * * 0 on success, or * * An error code if something failed. */ -int pvr_queue_job_init(struct pvr_job *job) +int pvr_queue_job_init(struct pvr_job *job, u64 drm_client_id) { /* Fragment jobs need at least one native fence wait on the geometry job = fence. */ u32 min_native_dep_count =3D job->type =3D=3D DRM_PVR_JOB_TYPE_FRAGMENT ?= 1 : 0; @@ -1099,7 +1100,7 @@ int pvr_queue_job_init(struct pvr_job *job) if (!pvr_cccb_cmdseq_can_fit(&queue->cccb, job_cmds_size(job, min_native_= dep_count))) return -E2BIG; =20 - err =3D drm_sched_job_init(&job->base, &queue->entity, 1, THIS_MODULE); + err =3D drm_sched_job_init(&job->base, &queue->entity, 1, THIS_MODULE, dr= m_client_id); if (err) return err; =20 diff --git a/drivers/gpu/drm/imagination/pvr_queue.h b/drivers/gpu/drm/imag= ination/pvr_queue.h index 93fe9ac9f58c..fc1986d73fc8 100644 --- a/drivers/gpu/drm/imagination/pvr_queue.h +++ b/drivers/gpu/drm/imagination/pvr_queue.h @@ -143,7 +143,7 @@ struct pvr_queue { =20 bool pvr_queue_fence_is_ufo_backed(struct dma_fence *f); =20 -int pvr_queue_job_init(struct pvr_job *job); +int pvr_queue_job_init(struct pvr_job *job, u64 drm_client_id); =20 void pvr_queue_job_cleanup(struct pvr_job *job); =20 diff --git a/drivers/gpu/drm/lima/lima_gem.c b/drivers/gpu/drm/lima/lima_ge= m.c index 5deec673c11e..9722b847a539 100644 --- a/drivers/gpu/drm/lima/lima_gem.c +++ b/drivers/gpu/drm/lima/lima_gem.c @@ -341,7 +341,7 @@ int lima_gem_submit(struct drm_file *file, struct lima_= submit *submit) =20 err =3D lima_sched_task_init( submit->task, submit->ctx->context + submit->pipe, - bos, submit->nr_bos, vm); + bos, submit->nr_bos, vm, file->client_id); if (err) goto err_out1; =20 diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_= sched.c index 7934098e651b..954f4325b859 100644 --- a/drivers/gpu/drm/lima/lima_sched.c +++ b/drivers/gpu/drm/lima/lima_sched.c @@ -113,7 +113,8 @@ static inline struct lima_sched_pipe *to_lima_pipe(stru= ct drm_gpu_scheduler *sch int lima_sched_task_init(struct lima_sched_task *task, struct lima_sched_context *context, struct lima_bo **bos, int num_bos, - struct lima_vm *vm) + struct lima_vm *vm, + u64 drm_client_id) { int err, i; =20 @@ -124,7 +125,8 @@ int lima_sched_task_init(struct lima_sched_task *task, for (i =3D 0; i < num_bos; i++) drm_gem_object_get(&bos[i]->base.base); =20 - err =3D drm_sched_job_init(&task->base, &context->base, 1, vm); + err =3D drm_sched_job_init(&task->base, &context->base, 1, vm, + drm_client_id); if (err) { kfree(task->bos); return err; diff --git a/drivers/gpu/drm/lima/lima_sched.h b/drivers/gpu/drm/lima/lima_= sched.h index 85b23ba901d5..1a08faf8a529 100644 --- a/drivers/gpu/drm/lima/lima_sched.h +++ b/drivers/gpu/drm/lima/lima_sched.h @@ -88,7 +88,8 @@ struct lima_sched_pipe { int lima_sched_task_init(struct lima_sched_task *task, struct lima_sched_context *context, struct lima_bo **bos, int num_bos, - struct lima_vm *vm); + struct lima_vm *vm, + u64 drm_client_id); void lima_sched_task_fini(struct lima_sched_task *task); =20 int lima_sched_context_init(struct lima_sched_pipe *pipe, diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm= _gem_submit.c index 3e9aa2cc38ef..d9be0fe3d674 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -30,7 +30,7 @@ static struct msm_gem_submit *submit_create(struct drm_device *dev, struct msm_gpu *gpu, struct msm_gpu_submitqueue *queue, uint32_t nr_bos, - uint32_t nr_cmds) + uint32_t nr_cmds, u64 drm_client_id) { static atomic_t ident =3D ATOMIC_INIT(0); struct msm_gem_submit *submit; @@ -54,7 +54,8 @@ static struct msm_gem_submit *submit_create(struct drm_de= vice *dev, return ERR_PTR(ret); } =20 - ret =3D drm_sched_job_init(&submit->base, queue->entity, 1, queue); + ret =3D drm_sched_job_init(&submit->base, queue->entity, 1, queue, + drm_client_id); if (ret) { kfree(submit->hw_fence); kfree(submit); @@ -693,7 +694,8 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *= data, } } =20 - submit =3D submit_create(dev, gpu, queue, args->nr_bos, args->nr_cmds); + submit =3D submit_create(dev, gpu, queue, args->nr_bos, args->nr_cmds, + file->client_id); if (IS_ERR(submit)) { ret =3D PTR_ERR(submit); goto out_post_unlock; diff --git a/drivers/gpu/drm/nouveau/nouveau_sched.c b/drivers/gpu/drm/nouv= eau/nouveau_sched.c index d326e55d2d24..460a5fb02412 100644 --- a/drivers/gpu/drm/nouveau/nouveau_sched.c +++ b/drivers/gpu/drm/nouveau/nouveau_sched.c @@ -87,7 +87,8 @@ nouveau_job_init(struct nouveau_job *job, } =20 ret =3D drm_sched_job_init(&job->base, &sched->entity, - args->credits, NULL); + args->credits, NULL, + job->file_priv->client_id); if (ret) goto err_free_chains; =20 diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panf= rost/panfrost_drv.c index b87f83e94eda..d5c2c6530ed8 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -312,7 +312,7 @@ static int panfrost_ioctl_submit(struct drm_device *dev= , void *data, =20 ret =3D drm_sched_job_init(&job->base, &file_priv->sched_entity[slot], - 1, NULL); + 1, NULL, file->client_id); if (ret) goto out_put_job; =20 diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pantho= r/panthor_drv.c index 06fe46e32073..bd8e1900c919 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -989,7 +989,8 @@ static int panthor_ioctl_group_submit(struct drm_device= *ddev, void *data, const struct drm_panthor_queue_submit *qsubmit =3D &jobs_args[i]; struct drm_sched_job *job; =20 - job =3D panthor_job_create(pfile, args->group_handle, qsubmit); + job =3D panthor_job_create(pfile, args->group_handle, qsubmit, + file->client_id); if (IS_ERR(job)) { ret =3D PTR_ERR(job); goto out_cleanup_submit_ctx; diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index 12a02e28f50f..e0c79bd2d173 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -2516,7 +2516,7 @@ panthor_vm_bind_job_create(struct drm_file *file, kref_init(&job->refcount); job->vm =3D panthor_vm_get(vm); =20 - ret =3D drm_sched_job_init(&job->base, &vm->entity, 1, vm); + ret =3D drm_sched_job_init(&job->base, &vm->entity, 1, vm, file->client_i= d); if (ret) goto err_put_job; =20 diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/pant= hor/panthor_sched.c index 446ec780eb4a..2af860c9068a 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -3729,7 +3729,8 @@ struct panthor_vm *panthor_job_vm(struct drm_sched_jo= b *sched_job) struct drm_sched_job * panthor_job_create(struct panthor_file *pfile, u16 group_handle, - const struct drm_panthor_queue_submit *qsubmit) + const struct drm_panthor_queue_submit *qsubmit, + u64 drm_client_id) { struct panthor_group_pool *gpool =3D pfile->groups; struct panthor_job *job; @@ -3801,7 +3802,7 @@ panthor_job_create(struct panthor_file *pfile, =20 ret =3D drm_sched_job_init(&job->base, &job->group->queues[job->queue_idx]->entity, - credits, job->group); + credits, job->group, drm_client_id); if (ret) goto err_put_job; =20 diff --git a/drivers/gpu/drm/panthor/panthor_sched.h b/drivers/gpu/drm/pant= hor/panthor_sched.h index e650a445cf50..742b0b4ff3a3 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.h +++ b/drivers/gpu/drm/panthor/panthor_sched.h @@ -29,7 +29,8 @@ int panthor_group_get_state(struct panthor_file *pfile, struct drm_sched_job * panthor_job_create(struct panthor_file *pfile, u16 group_handle, - const struct drm_panthor_queue_submit *qsubmit); + const struct drm_panthor_queue_submit *qsubmit, + u64 drm_client_id); struct drm_sched_job *panthor_job_get(struct drm_sched_job *job); struct panthor_vm *panthor_job_vm(struct drm_sched_job *sched_job); void panthor_job_put(struct drm_sched_job *job); diff --git a/drivers/gpu/drm/scheduler/sched_fence.c b/drivers/gpu/drm/sche= duler/sched_fence.c index e971528504a5..d208d384d38d 100644 --- a/drivers/gpu/drm/scheduler/sched_fence.c +++ b/drivers/gpu/drm/scheduler/sched_fence.c @@ -206,7 +206,8 @@ struct drm_sched_fence *to_drm_sched_fence(struct dma_f= ence *f) EXPORT_SYMBOL(to_drm_sched_fence); =20 struct drm_sched_fence *drm_sched_fence_alloc(struct drm_sched_entity *ent= ity, - void *owner) + void *owner, + u64 drm_client_id) { struct drm_sched_fence *fence =3D NULL; =20 @@ -215,6 +216,7 @@ struct drm_sched_fence *drm_sched_fence_alloc(struct dr= m_sched_entity *entity, return NULL; =20 fence->owner =3D owner; + fence->drm_client_id =3D drm_client_id; spin_lock_init(&fence->lock); =20 return fence; diff --git a/drivers/gpu/drm/scheduler/sched_internal.h b/drivers/gpu/drm/s= cheduler/sched_internal.h index 599cf6e1bb74..7ea5a6736f98 100644 --- a/drivers/gpu/drm/scheduler/sched_internal.h +++ b/drivers/gpu/drm/scheduler/sched_internal.h @@ -24,7 +24,7 @@ void drm_sched_entity_select_rq(struct drm_sched_entity *= entity); struct drm_sched_job *drm_sched_entity_pop_job(struct drm_sched_entity *en= tity); =20 struct drm_sched_fence *drm_sched_fence_alloc(struct drm_sched_entity *s_e= ntity, - void *owner); + void *owner, u64 drm_client_id); void drm_sched_fence_init(struct drm_sched_fence *fence, struct drm_sched_entity *entity); void drm_sched_fence_free(struct drm_sched_fence *fence); diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/sched= uler/sched_main.c index 829579c41c6b..9cd3b591f3c2 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -764,6 +764,8 @@ EXPORT_SYMBOL(drm_sched_resubmit_jobs); * @credits: the number of credits this job contributes to the schedulers * credit limit * @owner: job owner for debugging + * @drm_client_id: &struct drm_file.client_id of the owner (used by trace + * events) * * Refer to drm_sched_entity_push_job() documentation * for locking considerations. @@ -784,7 +786,8 @@ EXPORT_SYMBOL(drm_sched_resubmit_jobs); */ int drm_sched_job_init(struct drm_sched_job *job, struct drm_sched_entity *entity, - u32 credits, void *owner) + u32 credits, void *owner, + uint64_t drm_client_id) { if (!entity->rq) { /* This will most likely be followed by missing frames @@ -810,7 +813,7 @@ int drm_sched_job_init(struct drm_sched_job *job, =20 job->entity =3D entity; job->credits =3D credits; - job->s_fence =3D drm_sched_fence_alloc(entity, owner); + job->s_fence =3D drm_sched_fence_alloc(entity, owner, drm_client_id); if (!job->s_fence) return -ENOMEM; =20 diff --git a/drivers/gpu/drm/scheduler/tests/mock_scheduler.c b/drivers/gpu= /drm/scheduler/tests/mock_scheduler.c index f999c8859cf7..09ffbdb32d76 100644 --- a/drivers/gpu/drm/scheduler/tests/mock_scheduler.c +++ b/drivers/gpu/drm/scheduler/tests/mock_scheduler.c @@ -35,7 +35,7 @@ drm_mock_sched_entity_new(struct kunit *test, ret =3D drm_sched_entity_init(&entity->base, priority, &drm_sched, 1, - NULL); + NULL, 1); KUNIT_ASSERT_EQ(test, ret, 0); =20 entity->test =3D test; diff --git a/drivers/gpu/drm/v3d/v3d_submit.c b/drivers/gpu/drm/v3d/v3d_sub= mit.c index 4ff5de46fb22..5171ffe9012d 100644 --- a/drivers/gpu/drm/v3d/v3d_submit.c +++ b/drivers/gpu/drm/v3d/v3d_submit.c @@ -169,7 +169,7 @@ v3d_job_init(struct v3d_dev *v3d, struct drm_file *file= _priv, job->file =3D file_priv; =20 ret =3D drm_sched_job_init(&job->base, &v3d_priv->sched_entity[queue], - 1, v3d_priv); + 1, v3d_priv, file_priv->client_id); if (ret) return ret; =20 diff --git a/drivers/gpu/drm/xe/xe_sched_job.c b/drivers/gpu/drm/xe/xe_sche= d_job.c index 1905ca590965..f4679cb9a56b 100644 --- a/drivers/gpu/drm/xe/xe_sched_job.c +++ b/drivers/gpu/drm/xe/xe_sched_job.c @@ -113,7 +113,8 @@ struct xe_sched_job *xe_sched_job_create(struct xe_exec= _queue *q, kref_init(&job->refcount); xe_exec_queue_get(job->q); =20 - err =3D drm_sched_job_init(&job->drm, q->entity, 1, NULL); + err =3D drm_sched_job_init(&job->drm, q->entity, 1, NULL, + q->xef->drm->client_id); if (err) goto err_free; =20 diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index 1a7e377d4cbb..6fe3b4c0cffb 100644 --- a/include/drm/gpu_scheduler.h +++ b/include/drm/gpu_scheduler.h @@ -305,6 +305,13 @@ struct drm_sched_fence { * @owner: job owner for debugging */ void *owner; + + /** + * @drm_client_id: + * + * The client_id of the drm_file which owns the job. + */ + uint64_t drm_client_id; }; =20 struct drm_sched_fence *to_drm_sched_fence(struct dma_fence *f); @@ -629,7 +636,8 @@ drm_sched_pick_best(struct drm_gpu_scheduler **sched_li= st, =20 int drm_sched_job_init(struct drm_sched_job *job, struct drm_sched_entity *entity, - u32 credits, void *owner); + u32 credits, void *owner, + u64 drm_client_id); void drm_sched_job_arm(struct drm_sched_job *job); void drm_sched_entity_push_job(struct drm_sched_job *sched_job); int drm_sched_job_add_dependency(struct drm_sched_job *job, --=20 2.43.0 From nobody Sun Dec 14 19:30:17 2025 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2057.outbound.protection.outlook.com [40.107.95.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24E44220F51 for ; Wed, 21 May 2025 15:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.95.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842404; cv=fail; b=SVFwnY0MfTyQjT7T6kdr7kMgZ6a2mAQtrvfLHEBYq5+BtsNDhV3PXAUXdi4y0UjmFhLYzGO99V+m4Y3elgqhjSPwX6UBlv+YnG5XcFWWkK2d6+ufoKSifvNTHv4+VPs+YqkqqRs0sVA2PgJtBSo1nDrSX3BA7zfqXQQvyguP858= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842404; c=relaxed/simple; bh=lCCXy60KwtKZ+v4z0Jj+v1jX++nUlG7Cr4/rJdJQkn8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TV426ILL6u93YDuv6HKqWm8Ak/05gFvBChH4HCmWua9ZULfDMh0zi2/6Q6BwkEqUHtgy8SBkaCQ+gYFPRutjVRj55MV0Rfb902+4uSSbOAcDVA/+dEGq+tj6DoDcslSsZhea0URUwCGXQL12mMw0MQYqaA1EoWCifODcFm4ZCSw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=aKuyCe+q; arc=fail smtp.client-ip=40.107.95.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="aKuyCe+q" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JHqQ4Ofqt/t2CpKkAfuWUNGQVWE9dEa9yYHjWix2McBSnMJapwqmVyYpciLOqmHGGBEPuh7T6Cj6dpXPYz9l1Vt3hzQsRfUsajuk1P07EOo4+lbtL9Bc54KGukcB5IGX26EYFug5SAAxuZiBb5m20ZKDNoD6eAnJwfESt1C6D3z+mFLa3XOoTBZAtnMTRGVuatBhKwjKDteXbSXY/JWmbgsqGJYMzSVLceH0hT4XU53wkYO//btzgBNJRB5LjmG1KTlAZIcq0d3+m1BW5GSHYjMwtLYk8OADAm7wigFJ0OT/Ga/hRuijsFIoXiXqXqWCLkRSk95BDjgKFFx47TH+LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BRHfJWdBNDdbJgIotWKTW+P1jKDophQih4cbrUQesh4=; b=VXBiCJvGQbecH1FA/4pr5Dp2VebFr7ZxlYNp1dX+sb02G8O4I2AVEto4UmUoyFHpsqBi3Mo10pp6s+ufPObw7cHKHYUDr7KC940pdbCr/NWi2lOk7P2liJG6m1offlF8S80iSUPMFw3+5BQhsOQapNKikxF56cU9LWgmj28aLGO7Xbf8fu6SN3SnZPSExT/3YzhAwxmxpqaJTsryY/9BrWQdrck8wXbNeMt1XQoZx+9FobZ/oLLinUC7NpjFvJE4Wd7YQc2GzVkCiLdRhUOmPlaUHT+s86h5zgcZMqLMm2CoEOFDH/Fz8dXZEUiSWgkt20N2mw47UzMw42gVcQRAkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BRHfJWdBNDdbJgIotWKTW+P1jKDophQih4cbrUQesh4=; b=aKuyCe+q38LATTKP6aQAwdQLX0JNJ83IZWQCyf19SNt2iFCigT9v71ZsSk94gPrRABYrcz7KpzW9Sqoo95Rs/qDrXHISJp+M2S7FfDoKAg3ug1nsoo9PC8UKvTOmzsBxJLfxLis8hw5g275nAw7bca3YTlhtix+xrOv1e9c+Nu0= Received: from BYAPR05CA0066.namprd05.prod.outlook.com (2603:10b6:a03:74::43) by DM6PR12MB4338.namprd12.prod.outlook.com (2603:10b6:5:2a2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.31; Wed, 21 May 2025 15:46:35 +0000 Received: from SJ1PEPF00001CE9.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::38) by BYAPR05CA0066.outlook.office365.com (2603:10b6:a03:74::43) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:46:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE9.mail.protection.outlook.com (10.167.242.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:46:34 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:46:31 -0500 From: Pierre-Eric Pelloux-Prayer To: Matthew Brost , Danilo Krummrich , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Pierre-Eric Pelloux-Prayer , =?UTF-8?q?Christian=20K=C3=B6nig?= , , Subject: [PATCH v10 03/10] drm/sched: Add device name to the drm_sched_process_job event Date: Wed, 21 May 2025 17:45:05 +0200 Message-ID: <20250521154531.10541-4-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> References: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE9:EE_|DM6PR12MB4338:EE_ X-MS-Office365-Filtering-Correlation-Id: f0d6668f-b419-4e02-ecfb-08dd987eaa5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WlE1SG51cTlTSmJ0VGJhT2Z1Nko1djhabStuUkhFZzdjN2dPRTAvbEl3K1gx?= =?utf-8?B?czdPV04zdHNUY0VWT0pLSTI1eFh5VU9RRFIxM0p1QVg2ZitWejdGMjVSd2xz?= =?utf-8?B?TFpBd1cvbWJxTVRZN251UDRmaFBlSk1ac1FTRGFkdStOTERLZ20xSytCNEd1?= =?utf-8?B?eTZJV0RZK0pQbDdqYThUOGhzS2VNbDhzNkJrbWhJNTdZNmplMExBVWNJTFVG?= =?utf-8?B?ajRSczdPQ1NxYm43b1dHWXBTV0NKQWxkd3N5MXN3cm9xbEFjU3NMaTcrOEQw?= =?utf-8?B?TUs3dXk4TkNwWGV5VHNrUEpCckJScXV4RjJMbGFnMVdIZmNvdHhmTkZRQ25M?= =?utf-8?B?ZkZnS2daV1dJWk9kVFYxOENwOHBVSEpwdmx4SlJkZSt0NkpqRnRhdzQyUFFX?= =?utf-8?B?QkcrdnptNnRlVTAvUE1scDUzUXpKYUtBd1lOQlFMaVg2Y3lUeE90WW85V2hk?= =?utf-8?B?S0ZpeHlpRE1xS3p1WmNqVXF1S0g3bktLTlBsL29XYmk5TU9NTG43bXBvWnZ2?= =?utf-8?B?bitVVnd3OGxHT0NXa0dnbWpzY21hdUIvZEJ6RjdYL203UDlXUHpWNzZCRCtY?= =?utf-8?B?ZUl4b0JsNWxRTVFNclZRNGZPeXFMWDIvR3dWNHdtWDhhMUI0aStNTDJVVXhq?= =?utf-8?B?N3QwUnliRmxEelljcVdtSzhFS1lFRGQ5aEkvbzVWNmN3VDJ1TnN1ajErSExD?= =?utf-8?B?dHpXR3JRZ1hIc0ZpUElGbTNTbkhPNkxwUVJTSXBtMHpyQXErWGhHSEYxY3Rw?= =?utf-8?B?U3lNdStBWEJzcUJhY0N5bHhWdC81bkRBZVVLRXprSWpoMmp5V05OZmVBTzBD?= =?utf-8?B?ck54RXF6WEhmUFhQeGY5SkR0SXppRnlKY0EreWFGUjhEcFpHL3hDYkljK1oz?= =?utf-8?B?UG5qWEVVenYyeWY4QjRwYXEyclA5OEpjMEdNV2ZqeGtLMEliQ3A5RWlpL3ZX?= =?utf-8?B?ZVdpdExpdENiV1hXMW8yL2ZnQWZQa0JyL2VGaUlpZXgyS2V1WUNDTGNUWHQ3?= =?utf-8?B?YWtqY3dNTnhiaUhVNzUwR21iMElWdUxiY2Fobm40SGRlSnVPWUNoc3hmd05j?= =?utf-8?B?OWVTM0sxMkxBM204b05JK2Roc1NoMWQvWEZVYm9NRVdJSDBwMnNKd1ZoN1Zv?= =?utf-8?B?cHZrd1dkZmFRMVIzWXZiZGtqQ2tCUzNIL3ZIazB1cVkyM2FkbW95cHJGMndz?= =?utf-8?B?bVIwVXVibDFjc0JNYmJ4cmVxdGVNL2tXbHRiSzFUbFJ5bDJ2SHQwdURhTkZD?= =?utf-8?B?YmVMdXBnRUJiSnJtdjNXYkVkOVUrY1ZLRWlXRis5ZVhOc0hnMHRsRk5TcDdx?= =?utf-8?B?K2xHRlNKSEQzNGh2Zm5tRFNsUERYaDYzYkttNVo5dXZhcnR4MXhwTzBhK2RS?= =?utf-8?B?VTU1M1E4dkdVcnNDMUVuNmFPTnE0VDJmaEhGaWxpU2x1ZFpRMG11V2RrVXdM?= =?utf-8?B?UFpxS00yTGRCM0dFUU9PVkZmQ21tR2lBamJxcGE1cE93Ri9kQWxVNWNyRWhx?= =?utf-8?B?OWdXM0N2NXhWQXJPUnZFRklDazRZVjg4dlFkdzRvRzgxeFp4WlRlWUt5L25h?= =?utf-8?B?aVZFQksxYzdvbllBNWp0Wk90bktrMFZRM3JyaVBIcG5iWTk1N2F5ZGFWL0NO?= =?utf-8?B?U1lmd1hOM0VqaVJ0TkkzbjN2YkNkUjRVR0RrS2J5ZFh2ZTVpZmIvZGxNVkpR?= =?utf-8?B?WmxQaWxSckwwWVdWdHlPMGwzc25EcTZXMXBrZzQ1UDZselAyUVhGSmFJNDhy?= =?utf-8?B?TkpLRGxiMnd0aFYxZmQzbzJEZUR5enA5NFZkSGU2UFJjQjNObmJRQjYrOXor?= =?utf-8?B?SFdpY0pFY0tQamlrN3g0bWFEcVRnYzdQaEZtdUxYZWpPV28wWDZJL3p1em1a?= =?utf-8?B?YjJWVWoyM25YZjVHTFVPd1RwQmd3SitjMnhleGtDT3hBYVJTbzZOaVNWc1g2?= =?utf-8?B?N3FFYVhROE5vQ1orRHJTS2NvSTV4RGxZaFhWVkVwaXFDdFFhaHRTTXArQmxG?= =?utf-8?B?WkZzcWljdWJZK0xzQkwwZllvYmtsd0sxMGhpc3p3eGY3T1hWVmNXRWhNSEUx?= =?utf-8?Q?5lRNje?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:46:34.6660 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0d6668f-b419-4e02-ecfb-08dd987eaa5b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4338 Since switching the scheduler from using kthreads to workqueues in commit a6149f039369 ("drm/sched: Convert drm scheduler to use a work queue rather than kthread") userspace applications cannot determine the device from the PID of the threads sending the trace events anymore. Each queue had its own kthread which had a given PID for the whole time. So, at least for amdgpu, it was possible to associate a PID to the hardware queues of each GPU in the system. Then, when a drm_run_job trace event was received by userspace, the source PID allowed to associate it back to the correct GPU. With workqueues this is not possible anymore, so the event needs to contain the dev_name() to identify the device. Reviewed-by: Christian K=C3=B6nig Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/= drm/scheduler/gpu_scheduler_trace.h index f56e77e7f6d0..713df3516a17 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h @@ -42,6 +42,7 @@ DECLARE_EVENT_CLASS(drm_sched_job, __field(uint64_t, id) __field(u32, job_count) __field(int, hw_job_count) + __string(dev, dev_name(sched_job->sched->dev)) ), =20 TP_fast_assign( @@ -52,9 +53,10 @@ DECLARE_EVENT_CLASS(drm_sched_job, __entry->job_count =3D spsc_queue_count(&entity->job_queue); __entry->hw_job_count =3D atomic_read( &sched_job->sched->credit_count); + __assign_str(dev); ), - TP_printk("entity=3D%p, id=3D%llu, fence=3D%p, ring=3D%s, job count:%= u, hw job count:%d", - __entry->entity, __entry->id, + TP_printk("dev=3D%s, entity=3D%p, id=3D%llu, fence=3D%p, ring=3D%s, j= ob count:%u, hw job count:%d", + __get_str(dev), __entry->entity, __entry->id, __entry->fence, __get_str(name), __entry->job_count, __entry->hw_job_count) ); --=20 2.43.0 From nobody Sun Dec 14 19:30:17 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2078.outbound.protection.outlook.com [40.107.93.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B48C61EB18D; Wed, 21 May 2025 15:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.78 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842432; cv=fail; b=aUtPrehhlqsEUDWxhVHTWSVE9GwF4dSSzQSuMCnrz4kTMfVz0rTqwr90zeDsWcaLwm/liXvwFKlGKgnAGJ6AqK6vsxOgwXKhup3y9/ywvrfUr8xpRP7/AOnT/aujSH6xHtgOiC91swTLOwjb3o4DYlRFzhLnmytwj2aqBOpAPXU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842432; c=relaxed/simple; bh=BOJiSPR9gVl84am5Ce4/Wlx6acYj5DFl55XO6P2VLZY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qics0D/CRvOsNlbvxfJNMvD0KlfFy/9vV0bldzGbli+9Yd+u7Z/A5wml+4fLkrrjA9kMXg4VVQ9csLEbComvoLXrBFZQuI9iMkDAm3C/c/op4UiMVOW/l3dL1QUBeS8zfYD4dw6G4Y3grM3CrSrO6aGxMHG2i3vEC9IxdWx8nHk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=TDdXT1pd; arc=fail smtp.client-ip=40.107.93.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="TDdXT1pd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o2jBcnDMtKjPqzX3UiVjSX5mFawkTM718LN52NuKj+32XpdQjeBxp3F/jKIttWXduhoytvE5TkxO+v4UZGrC8+klhcxbPemVtnfLLa8SHlG6dt8jjwhfJnuedCHu4M7cuC4ZjDA6Dd2PvBSEZVemwT3wqVzvG/ipE94LuKSLt7sKm4hQPmFBvbulmEBtanhftfEUtLrHlK2kuSfVYOitCfYJqa5+8mllBNFIJCGgh2TK5wZarBXk32Q4NtHAQSEK8kZq3U6f53NmVxBO95szVrxLlgW3sVLGPGulz97jBqoz7Jx834bQhMb8Vh3HVj1f8EKqDzpLoU9V3+OpcjNlNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b7VuIb1G7UqMbLW/iM7ebBG0Y8fEKiuWshqnMvhc8GI=; b=OwuB0TOyM42prjY6f7mfbrkwd6ee9NiIRCHABzN49Lj3n4U7lB5rlkyxzn0bOQ+3/EMRagpYIhpOx7QGzp+YmoYcihElQzVymkII2Heg4QFzxd4niZMZrxwagyaQHKs2UKkHSO2u6HaS/KWAxLyFBLrCm74tplobFt1LDkaEJIM9rTgYg7vm7PAmCQe3gbfGMOVCbp0ZlJuB+sN/Qt8svOIJvlMjrl8SF8uWnRz8ru2rM5HIht5i4iAICBpML8uHUxiDCKVax5OJ1Tb82s6ZYAQaAXqcgTMdcZ/SIU3Ogc5UAEbLf+EAsF6ulmwYmHCSMzFwHfO83qBeFKZM/JKB1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b7VuIb1G7UqMbLW/iM7ebBG0Y8fEKiuWshqnMvhc8GI=; b=TDdXT1pdZrSRD4lPH/GzpEsQVDKA6CfhAeqNo+XvbyaX5eNAg32QCe2t+pECLbc2aUjcDc9Dke1Hzh8BoPo7VE10cEvvJBb17iAKsIgmwa2z3A6QraV/d1+zqO6e/DjQPDmfhgjr9xUXdI5hDTuSe4Muynf8QyBzMdLLKHfEalc= Received: from DM6PR01CA0010.prod.exchangelabs.com (2603:10b6:5:296::15) by CYYPR12MB8962.namprd12.prod.outlook.com (2603:10b6:930:c4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.33; Wed, 21 May 2025 15:47:02 +0000 Received: from DS1PEPF0001708E.namprd03.prod.outlook.com (2603:10b6:5:296:cafe::f4) by DM6PR01CA0010.outlook.office365.com (2603:10b6:5:296::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:47:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0001708E.mail.protection.outlook.com (10.167.17.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:47:01 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:46:58 -0500 From: Pierre-Eric Pelloux-Prayer To: Matthew Brost , Danilo Krummrich , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal CC: Pierre-Eric Pelloux-Prayer , "Tvrtko Ursulin" , , , , Subject: [PATCH v10 04/10] drm/sched: Cleanup gpu_scheduler trace events Date: Wed, 21 May 2025 17:45:06 +0200 Message-ID: <20250521154531.10541-5-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> References: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001708E:EE_|CYYPR12MB8962:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e95d067-0d50-4601-1878-08dd987eba98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?liAp6Ioeu5wfRXJ9l2czGCdndOoH5PYDyFZaO5TTzz7mMvh+hWY12/r48Czp?= =?us-ascii?Q?Kcw8ZuZBZELU7UJ2/yd4sOBnAR8v9sSEFxtA4nVOXv9s8EsjAii8Wn29Drl2?= =?us-ascii?Q?GilGpZ8HYEk1M6HyeyVkD3vs2yHI0vOfOxQEbLy3gbWaDuUChpngk07Vtu17?= =?us-ascii?Q?y/Clii8I7oC6tVmxMAHc622OOa9RSo+wa5XXXZoxGol8JRdG/m+WTx+g/lW4?= =?us-ascii?Q?sfbjFrNM/Ae7J5UCUxKo5hDU/3qq/6STQeIf8JKUYzjzluR4MnpQHxtlt/9q?= =?us-ascii?Q?z48WDZXitlmTrPxtaDWbdquOjOFKHQqAv8Qp5SXe7VwbyrgUHzdVT1vfOoUg?= =?us-ascii?Q?xph/oPYIb2/RxTfrQdAdAv2t31P5SXczTbGNfoaaaujvwMEWONb8hB0Vi1O5?= =?us-ascii?Q?rp/gcHGW854CPwrxh7O/v9RtyyOBIJobWOXeD4I/Csiv65MoGUAxg3rlrGqx?= =?us-ascii?Q?rTUijxWgrKE3+5DnF0BQI83cU4SM2gu0V6whN3cdOFrO0k/E8BN0an7qVWOz?= =?us-ascii?Q?B6SwQZN1HmPA/wHOJVYAt8LEWTV5WDAnzhfuQQNoBP0rc6a/nCobZAucsqDh?= =?us-ascii?Q?LP7zjHjlZ64PZCtcnUiAmisu4WH8uvY70R7KIjlEzK5mOIv30g/m6vCo1Ddx?= =?us-ascii?Q?iP/Y3+rRSMvRkPuw64wDKo4dVTEYJdWYKyI5dQNolOCMiEQYdIgN7jrxhpjT?= =?us-ascii?Q?yjJA4Gph2Ey8wvy3BpFLcRGQoex1vffw00Kgeib5ibHo/z4z2R6u9bg6PRpA?= =?us-ascii?Q?zUjCqjiK2DWvC2cArjUhCjPqw8nYu48L0Xrx6VGJ5AoPHqPAPE6VrF7481Hc?= =?us-ascii?Q?PQlggTLYB4fbVjY7+IwEQfjbt92exo+4Tt7/MAbYa058j3mR3UQzPhToVShY?= =?us-ascii?Q?leoQUTuHC7R8fr+8liB4+rl4VhNqpfRM7zwpGA3Fx96EDscwrIOqg1Udwfrp?= =?us-ascii?Q?h/fmlNsLR+0iDHaczA45bc8FjH0DLtfdV/nGPU2f+21HNjOKtjf68e5L5M5r?= =?us-ascii?Q?6fLjjD2q+k5ZErqkVl0r+NlKtp/fO3MKI+IF6PAAsUjy9OYwIApYJtzyPjC2?= =?us-ascii?Q?nZpXpAWEJKYYQ2ouywosV4UphxC1QEuRvisDs6qef3kcgiPSPcIDljgRBxE3?= =?us-ascii?Q?b51U9NKRtB60fyOwQjTKW1RdV9vQrnto5dQ8GddF9K5UXQ/QC0sKYUeIxaJA?= =?us-ascii?Q?1Kyc/23+hp2u4l8JYYkL45KG+G8UZKz9CS8K23OhHWHr6mntCClF5dJ1jRVI?= =?us-ascii?Q?XmtwGC2fruj5afpePoC5M8QHRbR2dQiqsdy+vW7g3QgAmo52f5WRehlFNGVi?= =?us-ascii?Q?PvBIBo6sgJLSLaJ9XxqXloXgoyel0Au6JxjEdQ3TKnKVh9PEU4nPwTqCbWkZ?= =?us-ascii?Q?n36SARw41o93VemOfx5WswVG5mGUCYUJ/YH1WHS7cVwy7b+QAcgKlDpOOlh1?= =?us-ascii?Q?E1vhy4c1MnCqveEL6/bgsoXOLDqkDp7LTlLGAsxfLDtsdr9+/XMDgnxv8mm5?= =?us-ascii?Q?dqB70Qw33TKFpOg6e6wylR4WdjybVU0WMyU8rXP7Sd1cYNX0Hycg9HGIMA?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:47:01.9389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e95d067-0d50-4601-1878-08dd987eba98 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001708E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8962 Content-Type: text/plain; charset="utf-8" A fence uniquely identify a job, so this commits updates the places where a kernel pointer was used as an identifier by: "fence=3D%llu:%llu" Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Tvrtko Ursulin --- .../gpu/drm/scheduler/gpu_scheduler_trace.h | 44 ++++++++++--------- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/= drm/scheduler/gpu_scheduler_trace.h index 713df3516a17..6f5bd05131aa 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h @@ -36,28 +36,28 @@ DECLARE_EVENT_CLASS(drm_sched_job, TP_PROTO(struct drm_sched_job *sched_job, struct drm_sched_entity *en= tity), TP_ARGS(sched_job, entity), TP_STRUCT__entry( - __field(struct drm_sched_entity *, entity) - __field(struct dma_fence *, fence) - __string(name, sched_job->sched->name) __field(uint64_t, id) + __string(name, sched_job->sched->name) __field(u32, job_count) __field(int, hw_job_count) __string(dev, dev_name(sched_job->sched->dev)) + __field(u64, fence_context) + __field(u64, fence_seqno) ), =20 TP_fast_assign( - __entry->entity =3D entity; __entry->id =3D sched_job->id; - __entry->fence =3D &sched_job->s_fence->finished; __assign_str(name); __entry->job_count =3D spsc_queue_count(&entity->job_queue); __entry->hw_job_count =3D atomic_read( &sched_job->sched->credit_count); __assign_str(dev); + __entry->fence_context =3D sched_job->s_fence->finished.context; + __entry->fence_seqno =3D sched_job->s_fence->finished.seqno; ), - TP_printk("dev=3D%s, entity=3D%p, id=3D%llu, fence=3D%p, ring=3D%s, j= ob count:%u, hw job count:%d", - __get_str(dev), __entry->entity, __entry->id, - __entry->fence, __get_str(name), + TP_printk("dev=3D%s, id=3D%llu, fence=3D%llu:%llu, ring=3D%s, job cou= nt:%u, hw job count:%d", + __get_str(dev), __entry->id, + __entry->fence_context, __entry->fence_seqno, __get_str(name), __entry->job_count, __entry->hw_job_count) ); =20 @@ -75,37 +75,39 @@ TRACE_EVENT(drm_sched_process_job, TP_PROTO(struct drm_sched_fence *fence), TP_ARGS(fence), TP_STRUCT__entry( - __field(struct dma_fence *, fence) + __field(u64, fence_context) + __field(u64, fence_seqno) ), =20 TP_fast_assign( - __entry->fence =3D &fence->finished; + __entry->fence_context =3D fence->finished.context; + __entry->fence_seqno =3D fence->finished.seqno; ), - TP_printk("fence=3D%p signaled", __entry->fence) + TP_printk("fence=3D%llu:%llu signaled", + __entry->fence_context, __entry->fence_seqno) ); =20 TRACE_EVENT(drm_sched_job_wait_dep, TP_PROTO(struct drm_sched_job *sched_job, struct dma_fence *fence), TP_ARGS(sched_job, fence), TP_STRUCT__entry( - __string(name, sched_job->sched->name) + __field(u64, fence_context) + __field(u64, fence_seqno) __field(uint64_t, id) - __field(struct dma_fence *, fence) - __field(uint64_t, ctx) - __field(unsigned, seqno) + __field(u64, ctx) + __field(u64, seqno) ), =20 TP_fast_assign( - __assign_str(name); + __entry->fence_context =3D sched_job->s_fence->finished.context; + __entry->fence_seqno =3D sched_job->s_fence->finished.seqno; __entry->id =3D sched_job->id; - __entry->fence =3D fence; __entry->ctx =3D fence->context; __entry->seqno =3D fence->seqno; ), - TP_printk("job ring=3D%s, id=3D%llu, depends fence=3D%p, context=3D%l= lu, seq=3D%u", - __get_str(name), __entry->id, - __entry->fence, __entry->ctx, - __entry->seqno) + TP_printk("fence=3D%llu:%llu, id=3D%llu depends on unsignalled fence= =3D%llu:%llu", + __entry->fence_context, __entry->fence_seqno, __entry->id, + __entry->ctx, __entry->seqno) ); =20 #endif /* _GPU_SCHED_TRACE_H_ */ --=20 2.43.0 From nobody Sun Dec 14 19:30:17 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2041.outbound.protection.outlook.com [40.107.92.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D5FF221F0D; Wed, 21 May 2025 15:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842437; cv=fail; b=HzJ1akrJDOhGpNPssbr1fOy3WbzIkxR2FtC19AnElJNuWium5BVCRaESeh+1zqwqaHr5ZLxHd31SLRPIDfws29CSt2tp405Nm20aHEHkCn+D/mOHCFkJ+AqxmQl3IkcnyRdrFPcUtVejxAZmmeD1zQLgZvCLHLu4VgEadyTE85Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842437; c=relaxed/simple; bh=O0CwZt+7H+MQFldTjXuiyxYlCez+w7LttflFoKcdV/4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZKfcSbHgud/tPZoZlxO4GuZvqLmMAQwIuq5Lg0hh+jbZWxM7wMNAtl2qR/nhXcLtSzLTxMdnIM7zdcoSGKHMhiQMLoRumrCKS2dO7WYUQ0GHVxp5xYDJn42p7sHKmZvd0BQvHj1St3Yc29RJOSrisn2YaBnDd4+nglCKkrgeux4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=O3cL0oHo; arc=fail smtp.client-ip=40.107.92.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="O3cL0oHo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m4ZXk6tKWqPGQORv25Q9hcvGPzz3X8dQHcF6Q8kuZP0cl2XjYUo0bCXLloR0rgstt0bVuJGy4dHySYa1FO8Ij6s1kVrRmd4Pa11b0L2cWIUMJ/2nC7kc6zCyEPgERklRJQ+UzHMWv66iSP2MZEvt6CTBmgNKIDd6gpoZ0ImVdT1hM3C8dfJKIlTpnfOWbHMNv31IFmVblkZk/O5YYXkuDxZ/rwg4YVaoqes5xx4MUQpgT+Hj0S7g2/ipg6dXo+3Y59EPEDgFu3jbB/5i1FjqR2nLDXwdp8HE+MZLvE3jkWqU0sxN+XyZrobxIlsU6MyOM3uvpmLAbdN5eLo4ViUCaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EHYMYNGFF9uKuQ3khXkbLAwz3Hd5pM8+94Ze52BPEZA=; b=tBDIjp6HByrP9ou/OIGe3+oMVtL/8vcB+mqf7PKM9JH9X/rNOmP7TBP11Vepb5DAC2BbhE5TWBA1f32eDNTlRGPRLKbhxs+lyOdBQr3p37uE+TGY1Zw3lSdvDTA7FMO6yD2oudyZtf5GObGKpxB7/6IaTxv9VF8kLDMCmCXdBPWyJgTKY97GExufL/4Se2/mvUgWJtq2raCDUQ3FbYDD8zz1OM4kKKzK1E093rAAMxWnDC/vKUbrysQSRUQtzmISnRwAjHlQXj/AW031SvTsHZhTWWeqtLNJyUbFrM7WIaIpHZ9/Cb0qXDVc8QC2pMJWrpkRJvqixz2xc+o8E10hLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EHYMYNGFF9uKuQ3khXkbLAwz3Hd5pM8+94Ze52BPEZA=; b=O3cL0oHoE1XnnWvhYo/G9h356tMWoX2vATtF7fMmLYlFl3zazbT5NQDbPEGWW3QuaXmHu0Z93IS/Jwdjvrd9n1alCzZlB2iVYXTQ/PQ+Cl0XM5bVoh6OO2OQFoCRTG68s/LeZVRd/Qn+E/tvZTSV1HZQqd1XKado8vPfo8O//58= Received: from DM6PR01CA0004.prod.exchangelabs.com (2603:10b6:5:296::9) by CYYPR12MB8855.namprd12.prod.outlook.com (2603:10b6:930:bb::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.31; Wed, 21 May 2025 15:47:10 +0000 Received: from DS1PEPF0001708E.namprd03.prod.outlook.com (2603:10b6:5:296:cafe::a9) by DM6PR01CA0004.outlook.office365.com (2603:10b6:5:296::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:46:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0001708E.mail.protection.outlook.com (10.167.17.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:47:10 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:47:07 -0500 From: Pierre-Eric Pelloux-Prayer To: Matthew Brost , Danilo Krummrich , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal CC: Pierre-Eric Pelloux-Prayer , "Tvrtko Ursulin" , , , , Subject: [PATCH v10 05/10] drm/sched: Trace dependencies for GPU jobs Date: Wed, 21 May 2025 17:45:07 +0200 Message-ID: <20250521154531.10541-6-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> References: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001708E:EE_|CYYPR12MB8855:EE_ X-MS-Office365-Filtering-Correlation-Id: b7d90d36-0849-4abd-c576-08dd987ebf8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|1800799024|376014|36860700013|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VmpsoM0w0hyUyddkAGO/qv/WYGPKyn3K9uTzw1Up8rTjjck9CqpgEVn4gH2d?= =?us-ascii?Q?t+TGP+nWoUEtZ8MMxVUK9NWbLdj4XtDvJKY22ow6FVWtObv6km++OdWpZx0Z?= =?us-ascii?Q?vCAH6gOqC+d+cjRxXdBWMtZXhGPkyst3giZdPctvOpCoe47z5LrCNX73MRaR?= =?us-ascii?Q?vd4rqiHC/xu7B4K0tUsElluoadGomv6INdanbRRtF5s7NluHcZukk83Ifzeg?= =?us-ascii?Q?eZ+5cjTp3ohIu65447laqmBpO8ojrBj1a3gbKhIqJvBwlZ2pRxeWPZ/KfKCZ?= =?us-ascii?Q?pY1wf2u7KOOgzWOqsta15Lysw561yl9wSu8mJ9kT8gLDuTIti96h9O4VXR9c?= =?us-ascii?Q?OyUZlJtZ1lSaQHJMEwxMN7OZjGgizYP1dQ/6n+NKETI4oO6imjAujQkcomDt?= =?us-ascii?Q?zxzru0pqr2GYab3rtJQLF8N0ArXnMTsThDg9Ga2a+kbBRmq7Wi1WvcOntDr5?= =?us-ascii?Q?rlE27IVKQpUfKaizKhnAvbb757nuiCOD8tboFGG0jJ9QqLjVEFz7/1zlw0xB?= =?us-ascii?Q?oFdsvsHdu5EKfYkdWlz4K33u2WsMulKdazikvJ5qjUefq80qya4mW36LiXdg?= =?us-ascii?Q?7GsvdfeJbsKLfywmqlne5Oa8he9OOJf6hq1EkUSzKjs+4PngN4jNJQa0rFlr?= =?us-ascii?Q?TBZ0KgshNmK2t45jTf+Mtll0kUU2SBKmWLVjf1a/XKjvzKgkOLzAXeWO7Pkx?= =?us-ascii?Q?syfgg3el6e5A9NmbfwlB67g+SV50Z4GXNPO1orEvbHnHJppfxmDqqvIRAEul?= =?us-ascii?Q?D1Mwa+MoH9WzzfmShWARCNrxINZjdJsYq7az9AzpyKPX3w2B5Fbk8trfJaw+?= =?us-ascii?Q?SdqHGlvgJM5hM9azV1FRM6QOYR/oT5RSoxVMTfxrwbdpFRufh6QZyxGwNRbL?= =?us-ascii?Q?S9+D4sHn4h4xJd/NCf10n+RH+f8AGnrtK0qMACluiiYMBG73e1z9yahKCd99?= =?us-ascii?Q?364e9Zr6rbW1oLUjOufCElhKdPIxgPX8p6Q063GCiLTes2ZlMHXSKsJ7DE8I?= =?us-ascii?Q?koRcjIjx39IFvvO34BjiUvw8cVOAiKFXMR5Icl+T4WUG6xqz5JxrstPayiws?= =?us-ascii?Q?NpH1usBcEGXtDXXmZLCHTUIsnCGEPGTsvNzK17H4VYrDFBjQnWNj66g1KUwS?= =?us-ascii?Q?YmRmhw7SRVIlgjGSNCkzksS1RhFb1M4OSSr05Eq4TpHxCFm1gg29xqH/R5CT?= =?us-ascii?Q?eLNf8S+1sfyB936S2/9dQbHAAMY242BDmKVR0lyxBgBF5wpFOg38FS92g2wY?= =?us-ascii?Q?xYvXkxl7sHXO8viyvDviVp5Ev+JFs+VQab+6e3KPIDJSBQstF3adBhh7HuCL?= =?us-ascii?Q?RNeoLniZWr6x0+8O4bSBR1ayLynypcW9CyTyDgdquW2sTG1CyjNjeNKVq+nV?= =?us-ascii?Q?emtPy5H1JSgRNTP6bXHK6b6bUZh4hqW1D1Z/1OEhemf2Ep5ytzt1dJEVZals?= =?us-ascii?Q?cdirdb+avBxFF0VC+Ipg5qmePBBt1M3LbZZgw6in7MFTxja5TglOHMgKKLw8?= =?us-ascii?Q?9bAT1JEIV7iPLGA8ctoBNwkcpFoGNaGBywwCvN249cC4PaMwyxkmx44QAw?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(1800799024)(376014)(36860700013)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:47:10.2585 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b7d90d36-0849-4abd-c576-08dd987ebf8b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001708E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8855 Content-Type: text/plain; charset="utf-8" We can't trace dependencies from drm_sched_job_add_dependency because when it's called the job's fence is not available yet. So instead each dependency is traced individually when drm_sched_entity_push_job is used. Tracing the dependencies allows tools to analyze the dependencies between the jobs (previously it was only possible for fences traced by drm_sched_job_wait_dep). Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Tvrtko Ursulin --- .../gpu/drm/scheduler/gpu_scheduler_trace.h | 23 +++++++++++++++++++ drivers/gpu/drm/scheduler/sched_entity.c | 8 +++++++ 2 files changed, 31 insertions(+) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/= drm/scheduler/gpu_scheduler_trace.h index 6f5bd05131aa..5d9992ad47d3 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h @@ -87,6 +87,29 @@ TRACE_EVENT(drm_sched_process_job, __entry->fence_context, __entry->fence_seqno) ); =20 +TRACE_EVENT(drm_sched_job_add_dep, + TP_PROTO(struct drm_sched_job *sched_job, struct dma_fence *fence), + TP_ARGS(sched_job, fence), + TP_STRUCT__entry( + __field(u64, fence_context) + __field(u64, fence_seqno) + __field(u64, id) + __field(u64, ctx) + __field(u64, seqno) + ), + + TP_fast_assign( + __entry->fence_context =3D sched_job->s_fence->finished.context; + __entry->fence_seqno =3D sched_job->s_fence->finished.seqno; + __entry->id =3D sched_job->id; + __entry->ctx =3D fence->context; + __entry->seqno =3D fence->seqno; + ), + TP_printk("fence=3D%llu:%llu, id=3D%llu depends on fence=3D%llu:%llu", + __entry->fence_context, __entry->fence_seqno, __entry->id, + __entry->ctx, __entry->seqno) +); + TRACE_EVENT(drm_sched_job_wait_dep, TP_PROTO(struct drm_sched_job *sched_job, struct dma_fence *fence), TP_ARGS(sched_job, fence), diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/sch= eduler/sched_entity.c index bd39db7bb240..be579e132711 100644 --- a/drivers/gpu/drm/scheduler/sched_entity.c +++ b/drivers/gpu/drm/scheduler/sched_entity.c @@ -587,6 +587,14 @@ void drm_sched_entity_push_job(struct drm_sched_job *s= ched_job) ktime_t submit_ts; =20 trace_drm_sched_job(sched_job, entity); + + if (trace_drm_sched_job_add_dep_enabled()) { + struct dma_fence *entry; + unsigned long index; + + xa_for_each(&sched_job->dependencies, index, entry) + trace_drm_sched_job_add_dep(sched_job, entry); + } atomic_inc(entity->rq->sched->score); WRITE_ONCE(entity->last_user, current->group_leader); =20 --=20 2.43.0 From nobody Sun Dec 14 19:30:17 2025 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2058.outbound.protection.outlook.com [40.107.100.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A456C1465B4 for ; Wed, 21 May 2025 15:47:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842451; cv=fail; b=G0I6yyoSrCACPvhEb7BRIR2LeMyeTLjCkVzwzrNAVQ5XTOFk0HlnLCqIsU0cviQUHN4olrwCu7n/jVMOZoEyexzgsXUkhGWvKLb9nC4cuy2X9hpuXs+iOQYDbRCv5m+RUIlA+b9Zn989fzJAAKkJJcGCPwQkkDrGj9pPi1GNE/A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842451; c=relaxed/simple; bh=sPU6I5qFZSIYB1HFIIkGmyq/fnr4Borz3jLMN7SOVBY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Gqmag8F/iQ2C2qPrgdh/LfSoK/Po+s//nisGOhXnaXo97uS5B3jfLNdNd5kitzf9/P4mc8iqrRDz5OEGNfzK2cL/hYEmcVgLLOS1ky21WFRgKkYuQlAP+WTqqtQtAHMcA9GpZrs26iZlOwszASPnFHpvk4QGDttTiBqjyu/J5sM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=fKYr1dcY; arc=fail smtp.client-ip=40.107.100.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="fKYr1dcY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K1A2oH+irlOjaowcWUUDl0eimfzL3tTH18/S7iGVXIDpUx4w7tndDtcmC/7MzIVXE1v6eHa7/L4XfafJC3Z+Ol1VpfbUWSDKiDcLNyDOLJYqKGZ++axhV4y3ty4NcZyvt4zPUPMtWZAQZvr78OpUgX336M0zddvgMsdaxuI9zzQa6xd39+r5K8/QvzqVN1BbMpHClvl3MsJLZC/8BvjsyUQWG7V9S7a3QTa+LTw9f9dk0DYXFkmYimbGDRI6ZJ9VTWP+PFFPgCv1/S3O5alnDbHqxg2X5Vjn7JEC3uX4gdefY+z11FmgRtVi0yqDb+nc2LDz0+zr1gSZcncZIl1RHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lFXFoCODN4SBN7bXLAC2jHegIZHMz/4Vz8lWODQmisY=; b=tqDpn0YoQF5vBiZj43+u9enZ+2a+LhXyaFTuztjjAL7/q1CScF3n+7B+pjTNXi8rPm2GNlycYGpAzLEz+rtUlI0FojL7C4u2JSe8vukwbXAtRjSzwvFbbfTs53wbQ0wuNBsMmJpigKOV+VXE/VbnB5jr90LyQiKilRtVK/1PN3v7+f+YVOZTMhzCSNdFROdyyEonxbsEz9neJ4/PcAUErYcu5qoyQQZqn70NBHrfe2KlK/2SujhgrvrFjVBmzcfE0WGpXe5ApYEXv8hi2hvhtVYx6Excq65tr6dCtGhVlCfeBVYC+ri8UGf2Hmh/5umVkrG/rZxmaPKyJINc4UmhjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lFXFoCODN4SBN7bXLAC2jHegIZHMz/4Vz8lWODQmisY=; b=fKYr1dcY+bzadYxUbUK3jHzobMIut7iDTkjnIKue0sC3TywyvqTPuqoj1WwepuefDMtXhAEOyDcDCsDCjVsB6CBBQ4JgDKjX+bP7lNvRBLwx7PbSvEPfbTCgEg78SxYkl2rAh5rcAovbUfL2CL9KrAZyjc52esnNBvrjFcSAZv0= Received: from DS7PR03CA0248.namprd03.prod.outlook.com (2603:10b6:5:3b3::13) by LV8PR12MB9154.namprd12.prod.outlook.com (2603:10b6:408:190::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.21; Wed, 21 May 2025 15:47:25 +0000 Received: from DS1PEPF00017095.namprd03.prod.outlook.com (2603:10b6:5:3b3:cafe::7e) by DS7PR03CA0248.outlook.office365.com (2603:10b6:5:3b3::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8746.27 via Frontend Transport; Wed, 21 May 2025 15:47:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017095.mail.protection.outlook.com (10.167.17.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:47:25 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:47:22 -0500 From: Pierre-Eric Pelloux-Prayer To: Matthew Brost , Danilo Krummrich , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Pierre-Eric Pelloux-Prayer , =?UTF-8?q?Christian=20K=C3=B6nig?= , , Subject: [PATCH v10 06/10] drm/sched: Add the drm_client_id to the drm_sched_run/exec_job events Date: Wed, 21 May 2025 17:45:08 +0200 Message-ID: <20250521154531.10541-7-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> References: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017095:EE_|LV8PR12MB9154:EE_ X-MS-Office365-Filtering-Correlation-Id: 43436c66-784e-434f-eabe-08dd987ec874 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?K3oyV0RKU1Y1SFBPOEVkc3hqa1BzVXRLamNJZVBRZ2xBVFNWeWJPUnlNQnZW?= =?utf-8?B?emN4MU4waUVLUjJsb1pJbHpGdXF1dzFNb3ZmWS9HMmpwRWFad2pkdTdSditE?= =?utf-8?B?UzNZMTFvVzAvS0w0THBkTEZnNm53SVlMKzJpTXV3eWRrT01oSVJ1MUI5V1l2?= =?utf-8?B?ZnhldTFTWDFrZnUyZmtZT2xaSTFpRmR5TFNUd3FtTUpaTE1LQ3hXU1ZGQmtG?= =?utf-8?B?WWpIaTdiWmJWc3B6S1NISTBuMjNKL2ZkcDNKK2tVVTJreXFGMmMzR0Zsa2RR?= =?utf-8?B?SndaV283MGRseHYyVWY3RXJJaEIwSmhPakNDeUt5Yk9FMlJTakNMS2Jtellv?= =?utf-8?B?N0dObG9laGxFeSs4LzBidllveU85YVljQ2owY040LzgvblVyR3U0NWhZOE9U?= =?utf-8?B?Q3Z1ekFkQmNVcm9VcGRlSEtLNytLZWFsak1DS21PKzZIWjdWeVcyTWxnYTFR?= =?utf-8?B?MDlwenpBdzBDeldSQWN3UHQyVjUrdWR0b1pZRVpMYUplc1preDQ1U1BxclAv?= =?utf-8?B?ZnZGeTc1QXJ4OGViY0NVaU5DOGw3alY3OUFFZHNFK0pJakJLazdDN1p3QWJQ?= =?utf-8?B?K1U5RERGUWpUZ0h3NE0xVEcxNktxR3pqNExTdVpHMVlXa2lzR3M4Y3BQYTlU?= =?utf-8?B?dHFpWnEyb0s3U3Nlbk5JZ21pbnN2N2JxMEVYeG5tMzFUOFBFbmNDblJnUXNl?= =?utf-8?B?Sm9wVkZ4Y01NemI2Zy9yTmtYa1ZFSWcxRWhtdXdyOElJeUtORVZHT0hkeTZF?= =?utf-8?B?a2dvbll4emVVeWFieDh1SUxUOTBmNStsN0dpSE5iSnptVlJiQTNueDg4eGdY?= =?utf-8?B?S0prL3pQSGRHZ2FBSm1CaGExZTltdEhjZ1EzOUpvZEFtellnZzF6MElYaEc2?= =?utf-8?B?cGJtbm9wUWlCSEMxbmEwMWdzN0NCL3NRN2pORk9hMVNQNGVIWllVTHNHZmsv?= =?utf-8?B?ZGdZeFFYYmhzdlZKc0d2RXc5SXdkRlBBemtrR01KbjRXdUJPWXQzNnI1QnNa?= =?utf-8?B?empRdHRnS0R5MXA3eCt4MXV2aWpveWRieFhXYmFiRWFZL1lYbnAzNlM2MXBS?= =?utf-8?B?cmVTSDBiSlFJdWNmanY3a0tlOE5QWkp2VkF4ektzOEQyWlFSVUVLYXNvenVo?= =?utf-8?B?eTZ3RXVIR2M4Skg2WmpqU0ZUOTZUN1Q4VjFDOUlzZlg5Nmw0L1hPS3RZU0Ra?= =?utf-8?B?UVRUS2lCWW5GM0VGQUMwQUJXa3VHRlVNbjFVSUpac1l6eGs2R3hIY2V2TUNu?= =?utf-8?B?a2FocnNpa1JHbmtsOHFRaUcwNkxQY0hyc0plVmlMbE9uTzNzV0QwTzFIMXEw?= =?utf-8?B?dlAwbkJtN3ZaUUxjTWF3UUUzVCtDNEdCVUpFZkR4Qm5CbVRIaGg3by80RVk5?= =?utf-8?B?UlRxNjR5TTVkQWgyWHNxM2c1VkV6L1htWHlmWkpSNnphdkNDKzN1aWtUOE9l?= =?utf-8?B?dDgxdkJoZXVQUDNpK0UzelhBMVNaRnpNMWZ1czR0TVpQdHVtOEhzWFFNNElk?= =?utf-8?B?Z3ZaUlcrQTVML3ZCQndvNzFuVG1pWjJ2dmE4U2hhQzJCb1BkZDhFUHlvdjhy?= =?utf-8?B?N0xwcENMb09OUUIzTjJsM1l1Q09NQklyMWt6azdDbisvWGlFczI4WTd3SE02?= =?utf-8?B?b1NBNVN3a3E3UnRyQkh5eko3ZCtoZ0tpY0JLUnE4VlBVb2hiN2J5WkRUQnBh?= =?utf-8?B?WkJwQUhoenhJOCtqZ2dISnVodk01d2NKUEJVSFREbm5LV0VxcXUrTmhROXFB?= =?utf-8?B?SFRIZkRmQnhJR3I0Ylp1bkQ5aHhIeEVXUk9XNnJvMG5UUUZLOFVQZDlEMXQ0?= =?utf-8?B?YStRaXlvTSs5d0tEeU5IeHNoZWhUakZOWldjUnd2eURTSlpBV2pIQW0rNkNT?= =?utf-8?B?SkJJS2R4OTFLNllzMjZGM0hwNXNvSUhaUHduTFpZK2FheHdGN0RTY1g0TVh3?= =?utf-8?B?T05nMXZjQzdLRU5KaVBzdmJPTHVLQ3pFZ1QwOTg5SVMvSjZvR3BxQlNUK3Ns?= =?utf-8?B?K1cybjM2dzdGZTZwTklGRGVHNXBjT0ZSa0hZQXh6bXZwdWtWUkVKZTdORkNR?= =?utf-8?Q?Ick01T?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:47:25.1981 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 43436c66-784e-434f-eabe-08dd987ec874 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017095.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9154 For processes with multiple drm_file instances, the drm_client_id is the only way to map jobs back to their unique owner. It's even more useful if drm client_name is set, because now a tool can map jobs to the client name instead of only having access to the process name. Reviewed-by: Christian K=C3=B6nig Acked-by: Philipp Stanner Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/= drm/scheduler/gpu_scheduler_trace.h index 5d9992ad47d3..38cdd659a286 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h @@ -43,6 +43,7 @@ DECLARE_EVENT_CLASS(drm_sched_job, __string(dev, dev_name(sched_job->sched->dev)) __field(u64, fence_context) __field(u64, fence_seqno) + __field(u64, client_id) ), =20 TP_fast_assign( @@ -54,11 +55,12 @@ DECLARE_EVENT_CLASS(drm_sched_job, __assign_str(dev); __entry->fence_context =3D sched_job->s_fence->finished.context; __entry->fence_seqno =3D sched_job->s_fence->finished.seqno; + __entry->client_id =3D sched_job->s_fence->drm_client_id; ), - TP_printk("dev=3D%s, id=3D%llu, fence=3D%llu:%llu, ring=3D%s, job cou= nt:%u, hw job count:%d", + TP_printk("dev=3D%s, id=3D%llu, fence=3D%llu:%llu, ring=3D%s, job cou= nt:%u, hw job count:%d, client_id:%llu", __get_str(dev), __entry->id, __entry->fence_context, __entry->fence_seqno, __get_str(name), - __entry->job_count, __entry->hw_job_count) + __entry->job_count, __entry->hw_job_count, __entry->client_id) ); =20 DEFINE_EVENT(drm_sched_job, drm_sched_job, --=20 2.43.0 From nobody Sun Dec 14 19:30:17 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2081.outbound.protection.outlook.com [40.107.92.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDC9E21D5AA for ; Wed, 21 May 2025 15:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.81 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842457; cv=fail; b=nAJmFsxqiM/FUen9DPlJRmLYMt0Zh+SPTEnaLGBwEJ2XJ2+oWBoWe/PuYlZrdCLcXjspH6bdfZoDqMvpQSLCyxFrfwP6a/Xq7wQ2Lwyl9QgeGwGbDotf1HRWe27XBesyf4axNaEjCq/l7vsbqwCVrNAgfZlnvRP7gUd/qvqbZkw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842457; c=relaxed/simple; bh=gVrH4YnE1JsmvF8ZXauOkDdy06CwZbKWYIsMFnyTiYI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HB+VIgXQdzy3P0HVIGvf6f94A0PAtV53Xgzrxo0b6LBnb1GDWdQpDvp6XZVkuZRYlHjHw1SK37gMKQ7P1GgWTulkw4eJVo9czeeZaY90YKrr/IcGEphs+d/QvpfWR6HTgMjNG8vF74/uJCPF4PU4gR0xeeX56lGd15StyRvQQvM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Ls4Z4Bex; arc=fail smtp.client-ip=40.107.92.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Ls4Z4Bex" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p0l+n5kRgOcOOr3/Lv7QIHtbi6pyniDTrS4h0SnIAb2u3/D0w7lbGyp5WX5qrZdWHRm5LuqK1w/C5axgBXM5Oc9lJH3vuUqNzprV7/YDL/ijhhj39MgyIcX52FWTxdI1KYCXGc1NLLPz6olIfuFXvm3AFoAuXMlkLypKTK3X1ruG6/KAc7+60MG5ezOQSnXpfxrtwgnl08tSoXCNRYUxGMQrmx9kMtZ/RMQrIjGKH2p556ujI54HfvvQ8HizmFXhAcMjk6+6KPvMyThL6rhMG1u8iY1MduhgLV0DmGRfiQy1bRljUbClsvLNAiutvTlspNvwOW3NA24HPnWzAo8seQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0uhU5XaefJHn0gza9zHXOLLuQv4JeQSuuMqMgnbKoCw=; b=vCLPAlh7pb4FFbN+qFTIwVP01IGWTbuCSYl2HGRXQos3eEYSFFpO/II4/TVs1/93zOgckub31SMhXodqut5NZ9Nxq2U05YVH6TiJU0gshJx6Ae43MD62wXQF3474tSdzR00Dyeu/MFtqmbfQwmSunaulliKx+d+SBhazNEKcnVtSzq6qf3ARNjXhx1P4mFsuRhgitmw9XEC/UOfk9tGOvtHMO+UnBZhRRu7nRybBjq8zsIHfHBdou1sS/sFhS1g7fP/nZxGd7MfH0AnZZWSkbZZ+5NK5GikeG0w8yB0AsThKm8+ICqbB0atBwCOXMSByDKhPBJCOB7hzcX3uac1PxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0uhU5XaefJHn0gza9zHXOLLuQv4JeQSuuMqMgnbKoCw=; b=Ls4Z4BexNIQNIuhTDOdPrKErIqaDwN9/XLzdOiOiOHZCbuLosJCME1xLxOuxRtgtlpQUgW2BrkMGV/o6eQf37QI0QhOEvX7Rpwg7Z/h1Hl5g9XJkaZGrZXmfLixY9USAWefA0ff3PZTyC95Efhn926zsHPrW98czyqp3haO/E4k= Received: from DS7PR05CA0073.namprd05.prod.outlook.com (2603:10b6:8:57::27) by IA1PR12MB9032.namprd12.prod.outlook.com (2603:10b6:208:3f3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.19; Wed, 21 May 2025 15:47:32 +0000 Received: from DS1PEPF00017093.namprd03.prod.outlook.com (2603:10b6:8:57:cafe::71) by DS7PR05CA0073.outlook.office365.com (2603:10b6:8:57::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:47:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017093.mail.protection.outlook.com (10.167.17.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:47:31 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:47:28 -0500 From: Pierre-Eric Pelloux-Prayer To: Matthew Brost , Danilo Krummrich , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Pierre-Eric Pelloux-Prayer , "Tvrtko Ursulin" , , Subject: [PATCH v10 07/10] drm/sched: Cleanup event names Date: Wed, 21 May 2025 17:45:09 +0200 Message-ID: <20250521154531.10541-8-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> References: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017093:EE_|IA1PR12MB9032:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d98a0aa-0f5d-4e19-9d98-08dd987ecc45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|7416014|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+y2E3FmGyX+ZkMLkm8lW3+WuSpK1wuMfGGOyeMvKaqPpljWwdiJkGaJeSOpB?= =?us-ascii?Q?nzuMuAekLH1csobdhi6Qg4o0dw6qikWDdl05TKwn3tuIeYUITREVVg40IO+9?= =?us-ascii?Q?iPS0tTnD73rTp+vBLvFYv3nTztpkLF3BQYTnmNM2Izb7Rx4dqQwirpgj3mUM?= =?us-ascii?Q?NCjtoLywll/9AXb3ckkGZioRXmvHougCjLsOebzVUocuWfW+Wy1Fv1APlpgY?= =?us-ascii?Q?DNQSjDcuJbkocSOX83baJaVYl9GAvqfDrsb03ezHhJsMfAL2jkmTnSIlV75X?= =?us-ascii?Q?seXNtpanp+6bpMP4BfdHcQmpIDhujit+kSK8+oJqVXRwYh6AsLRCIbx3X7bo?= =?us-ascii?Q?sHXWaaOz/ecyqbfHYhFvb1xg1QACkxf0Yve1RMa7/9EnGjdxU3w2F9IS0eVo?= =?us-ascii?Q?t/BTAhVB4cI4/GTnKK43z+nQtyDXnDwbQz4ulhGRXAOSoryQBGIf+zCxceaD?= =?us-ascii?Q?fMT3sA/Xr5EoD/pxeBeIzI4FSAgcLy2FuK64Kc2ktXf/rWAs0U4+kVfmCctm?= =?us-ascii?Q?xHQNDdgel87+otuNKQKEIXchOzWjCY4DMfTIT04uU1XBJgSim92pwRplmto5?= =?us-ascii?Q?hFAF4Xw8T25cxNCnycfLA8wXtOp8gOPwzLGCosrudCC38mVKXy6MfNdvW6Nw?= =?us-ascii?Q?wXicJhvwbjx1BR1MozKfGbJ3OVh3GCEZPqz3NMA7plihBkFiA1J5bbS2hjwa?= =?us-ascii?Q?3QEx9XznzpJToKoWpzE77SUzvtrS5j5UlRdVxdvXBR8kOY7iDjde71mVuhV8?= =?us-ascii?Q?EFNQRYUSrxq/CKTq1/vYhMXFp+tjIRWKK48XXJUPajBfPEbbTBBCaprf07Zo?= =?us-ascii?Q?Nnuoj3KEMToKzjly9XSbcUCJGm7wHqCMConRg838FV8B4OrTxzJMLoQbcREp?= =?us-ascii?Q?n1glm9p2v3nITtpoyE9O8/pTlBFRgorJKs8rp3aIAnwxMLAhbQVoZUsUa4QH?= =?us-ascii?Q?CVIcHZjvqZ53rrvmZR1lBa0ZZiFqoRGma4SiA7Z4+c42Oan5NYNvcI1SW7ns?= =?us-ascii?Q?oiufvLiFplX85FeCSEB7Qx/gACt/7bxUzx5gUS8wq27TM6SPwfiYlspqF26D?= =?us-ascii?Q?iXzziVj27K463MrmBgmYdELpBnFHX7MEmc68GQVpqHzT/u5kv5oV81HDhqLd?= =?us-ascii?Q?4ctT4NGtScxjtgQrUeb/j7/DbAtaydWb8mhBty7/jdtVHHSvgTDeHNaQguHO?= =?us-ascii?Q?MTRL8Yg+7jG3KJPdYOti5o3fUElGoAwrTZ8H5Tz10cooLbxHZjUtOhoFnvgc?= =?us-ascii?Q?syxtdyCwapSBfKnIXWELO9tFQBjhgy2fFLJdLNwmnE0KUGr/QNYvTpv22K8u?= =?us-ascii?Q?3kXLBFP9YBsUvZ6z6JrHagCUSrCbyT7Rid2pz/i8/J0Crr5/KRhrY/2TI2e9?= =?us-ascii?Q?/zxkBuIoZMikVSKG2EpdVeROom1w6jRxEWt7YoH/bZ+8G5FB2z8e8QDgLlR8?= =?us-ascii?Q?f/JeVf4Zpo9Pi1rHCGnS1FIRN/AchUAvMAWvU2JX/MHNBv6gnXDyDcBjFgQE?= =?us-ascii?Q?n3jnFj2McNHY+Q+ORRnl61XMeX82rUWsxvjZ?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(7416014)(376014)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:47:31.6092 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d98a0aa-0f5d-4e19-9d98-08dd987ecc45 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017093.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB9032 Content-Type: text/plain; charset="utf-8" All events now start with the same prefix (drm_sched_job_). drm_sched_job_wait_dep was misleading because it wasn't waiting at all. It's now replaced by trace_drm_sched_job_unschedulable, which is only traced if the job cannot be scheduled. For moot dependencies, nothing is traced. Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 8 ++++---- drivers/gpu/drm/scheduler/sched_entity.c | 8 ++++---- drivers/gpu/drm/scheduler/sched_main.c | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/= drm/scheduler/gpu_scheduler_trace.h index 38cdd659a286..4ce53e493fef 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h @@ -63,17 +63,17 @@ DECLARE_EVENT_CLASS(drm_sched_job, __entry->job_count, __entry->hw_job_count, __entry->client_id) ); =20 -DEFINE_EVENT(drm_sched_job, drm_sched_job, +DEFINE_EVENT(drm_sched_job, drm_sched_job_queue, TP_PROTO(struct drm_sched_job *sched_job, struct drm_sched_entity *en= tity), TP_ARGS(sched_job, entity) ); =20 -DEFINE_EVENT(drm_sched_job, drm_run_job, +DEFINE_EVENT(drm_sched_job, drm_sched_job_run, TP_PROTO(struct drm_sched_job *sched_job, struct drm_sched_entity *en= tity), TP_ARGS(sched_job, entity) ); =20 -TRACE_EVENT(drm_sched_process_job, +TRACE_EVENT(drm_sched_job_done, TP_PROTO(struct drm_sched_fence *fence), TP_ARGS(fence), TP_STRUCT__entry( @@ -112,7 +112,7 @@ TRACE_EVENT(drm_sched_job_add_dep, __entry->ctx, __entry->seqno) ); =20 -TRACE_EVENT(drm_sched_job_wait_dep, +TRACE_EVENT(drm_sched_job_unschedulable, TP_PROTO(struct drm_sched_job *sched_job, struct dma_fence *fence), TP_ARGS(sched_job, fence), TP_STRUCT__entry( diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/sch= eduler/sched_entity.c index be579e132711..59162cb81c4e 100644 --- a/drivers/gpu/drm/scheduler/sched_entity.c +++ b/drivers/gpu/drm/scheduler/sched_entity.c @@ -477,10 +477,10 @@ struct drm_sched_job *drm_sched_entity_pop_job(struct= drm_sched_entity *entity) =20 while ((entity->dependency =3D drm_sched_job_dependency(sched_job, entity))) { - trace_drm_sched_job_wait_dep(sched_job, entity->dependency); - - if (drm_sched_entity_add_dependency_cb(entity)) + if (drm_sched_entity_add_dependency_cb(entity)) { + trace_drm_sched_job_unschedulable(sched_job, entity->dependency); return NULL; + } } =20 /* skip jobs from entity that marked guilty */ @@ -586,7 +586,7 @@ void drm_sched_entity_push_job(struct drm_sched_job *sc= hed_job) bool first; ktime_t submit_ts; =20 - trace_drm_sched_job(sched_job, entity); + trace_drm_sched_job_queue(sched_job, entity); =20 if (trace_drm_sched_job_add_dep_enabled()) { struct dma_fence *entry; diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/sched= uler/sched_main.c index 9cd3b591f3c2..abe8eae752e5 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -401,7 +401,7 @@ static void drm_sched_job_done(struct drm_sched_job *s_= job, int result) atomic_sub(s_job->credits, &sched->credit_count); atomic_dec(sched->score); =20 - trace_drm_sched_process_job(s_fence); + trace_drm_sched_job_done(s_fence); =20 dma_fence_get(&s_fence->finished); drm_sched_fence_finished(s_fence, result); @@ -1232,7 +1232,7 @@ static void drm_sched_run_job_work(struct work_struct= *w) atomic_add(sched_job->credits, &sched->credit_count); drm_sched_job_begin(sched_job); =20 - trace_drm_run_job(sched_job, entity); + trace_drm_sched_job_run(sched_job, entity); /* * The run_job() callback must by definition return a fence whose * refcount has been incremented for the scheduler already. --=20 2.43.0 From nobody Sun Dec 14 19:30:17 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD12F21D5AA for ; Wed, 21 May 2025 15:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842466; cv=fail; b=B3q9G+HpBJgveNUdz8RVm4X6s9HC/hbyL0LPfMazObTGKPh1JDMSFTOhbZsPACrIIs+EetXdDz5K+r33YwXJvqgUvXuYwilAIThMNR7/M/AuJxDFwhDVo0swYQw0kzlrZSS4gmARCf+shyavE2Ii8WVnsJQx3chLuUun+fpRRYU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842466; c=relaxed/simple; bh=8rgEFeo6h9J/1PD2OyHavzEu9lAyKmKuRYK+maC0iY4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MwAX2VvwGNa6XYyjILaMCRfd9wOkvxWkJQJnAtdt5aUYNPAVXm2iWVekoe1K2knMQr4PGQdTtA9VnTnD7cbeql1DLi7nSHiKjvVJOAziKwahas0yrGE7akyQKkdzOIJDZVhOYsKS6v7E7q9cZouvCRrnC/GqwmbzpcpilK7Dncw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=kPG3J/k8; arc=fail smtp.client-ip=40.107.93.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="kPG3J/k8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ndqhxHWkSPhF0VANcjIlqyk8slyeCjsQmfTjaggS+S4KWvpdQQ4siyWLvrkaw7czkI80Pdtdg2XKlsmxCoquB0uTlTBNuf6XqS85z9kPOsJ9KxthdX0lDud7W3ARPhjlAej3QZ9Rfr5Nt5K+uxr7FlZnbThYZeC3rvQLhJAiKuzbA4bII52NBTE4tBDnLv0vzf9R+Ta801e3WhfdQx/xnBm2mx0LgMYMxX2JukP5EACDUe6WjVTm8Z/bmC8Cbejo/0VCqEhElpPQnngonqoaU3JCAfaPaD/F2eQXKljn2ThLfcbxlTDmIh901C6CQ2ePtL9zr/4/8n10iNSEn+Hw9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vOnLoFOpLRz6Gj2tBAha/TmS17lgyunKFrLXL2KStYY=; b=fS3j1WtFl4Yy8V9Ymg6//NjlBmkzc5g2KXYDh1q/JZDb5KBWig5YIOl4o2Gh++PGXWlTxg3O0oE/zTZF8oFwarMiVXp6qix9D1l5vypM8B1r+IcEqVlxmeJ1WaM+whrx5bmpqgpKexeP0w+3sY8mA/ib32scGCN4ZhIbTEQwX8YPDXNuJHTZzFvSoAct0CS6KJxN8RGwQ6urZ6sq5cljSpytI4e24IjwbuPxo4I8cEGFr7O40OmPyUNlh/EQ4JwNBde9DBqN8FSlK4r+ZZW66IpnD4n0YVGoGurJITeKjfejbS1ocYfuYwTL2PLHW7OP1Pcw0qtbTUiMfM1kBH8YCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vOnLoFOpLRz6Gj2tBAha/TmS17lgyunKFrLXL2KStYY=; b=kPG3J/k8++Qgtu0ZL/smrfaVDg2y2NG/RUkv2NGhNyM+kKtzhuF5T8aQAtdcqAmVXm1uQtozhlNmT3yoUCwTH8yxkHt736WPkJAPv6kSxhy8T5ZrU63yFzGcin3bHkAHmoGNzhLOS4Ko9Secf7w8gr9rjpiIaVwz7Ot1v326Qac= Received: from DM6PR08CA0044.namprd08.prod.outlook.com (2603:10b6:5:1e0::18) by SJ2PR12MB8649.namprd12.prod.outlook.com (2603:10b6:a03:53c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Wed, 21 May 2025 15:47:42 +0000 Received: from DS1PEPF00017090.namprd03.prod.outlook.com (2603:10b6:5:1e0:cafe::3e) by DM6PR08CA0044.outlook.office365.com (2603:10b6:5:1e0::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8746.29 via Frontend Transport; Wed, 21 May 2025 15:47:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017090.mail.protection.outlook.com (10.167.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:47:41 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:47:37 -0500 From: Pierre-Eric Pelloux-Prayer To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , Matthew Brost , Danilo Krummrich , "Philipp Stanner" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann CC: Pierre-Eric Pelloux-Prayer , "Tvrtko Ursulin" , Arvind Yadav , =?UTF-8?q?Christian=20K=C3=B6nig?= , , , Subject: [PATCH v10 08/10] drm: Get rid of drm_sched_job.id Date: Wed, 21 May 2025 17:45:10 +0200 Message-ID: <20250521154531.10541-9-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> References: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017090:EE_|SJ2PR12MB8649:EE_ X-MS-Office365-Filtering-Correlation-Id: 7268f07b-1852-491d-52d1-08dd987ed22c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|376014|7416014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b0gvKzRzRUhFVFFPaytJeTJsL2U2alIvUkM2UnJaZTAvdnhmanpLZDdvcWR4?= =?utf-8?B?c0V5VHNyTGh1VEVWR0lidGt0b0JwZElGcGM5TkdvcEZMOWN1UWtIL1I1c1dT?= =?utf-8?B?UGIvM1RPeWxxU3pENzduMktCaUJhSnpqeGlrcjFVRFV3SFk3NC91N09JR3Bq?= =?utf-8?B?UHRFbGhsNFZPdTBQWkpCT080VE9yOVFPRmI4RG54Wk0zWW1mNTFtK3BZRWtZ?= =?utf-8?B?ajFTRVc5a3RIcjBpVGF4Z09nTUlxb2syc29qWEtzcjRlZk90ei9oa0tBdkFh?= =?utf-8?B?UC9USko0TDdqUWhNUzNIMWNaa2ZpdmMza0w0cVF2SmZSQms5ZVREc3NCbVBh?= =?utf-8?B?NzBQcnVWNkNWWGRBWThqS3ZLTGRuZWc0YTVaWTcra2xwT2hWSFFnMisrbitV?= =?utf-8?B?UFJld0Y3MUNrMWljQ1lEVE5JdmFoekgyMzBhSFlqblFldzhTelc4d1VsdkRF?= =?utf-8?B?Mkw4QVM2L0kyb0ZJa3c1amdPUlNmNmZFMjl1aUlqZUdkaG9xM1dWZUpsakdB?= =?utf-8?B?Rk9EMFhLZXNEWlk1d3NKVGNlWFpUQytOaFY0a0RtVU43YzFhQWZaTEcwbXIy?= =?utf-8?B?d0xsTzdjWDdJR0dzcFpianpoVnpaRHRvRGE4ZXVUQUJoR0t4TnFLUjgrY1Rh?= =?utf-8?B?MDRxWDBtSWVBTFQ4cHNpWmVOWmdhbmFTRDBWUzVJMHBrMjBOemxxOUFYMTNM?= =?utf-8?B?Q1FQZ3QxQjc0U3dFSVd3Vld1ZVIvOXg0SmdQTVkvTm11Wm5acWxBZjNGQjRH?= =?utf-8?B?NUJHNm5xeUdHNHI2TkVRaFJqOWZUMndxdkl4SmZVM0RkYVdjei9pK2tnd3FH?= =?utf-8?B?bmJhQ1dxOFJrUTVoZE8zeTV1d0xoUzYrU24xdmNsUTVicStRRUhTVTR4UTRp?= =?utf-8?B?eVQrOHNxRGVtRlZEQmZVTGgzYXRzTTM1MFZNajVaSHRVRTFZY1ppWHZnZmRF?= =?utf-8?B?UDliRm5yWWRMczlvbFJ6TitrNDJ5Zng4dFVtRUJHRWVwL0M1Wk1FYlZxU0dm?= =?utf-8?B?S01KNHF1YXhFdi90VU51ZTRyRVVLVkQycW1BbFNRYVRXUXJPU2lWMHU0dSto?= =?utf-8?B?NHg5SklSTnc4Wm0wQzJrRnc3Q3ozeUFtUDdqMUxCSVEySCtSMTZkTUFFZEVL?= =?utf-8?B?NThIbmkvcUVnVG5NOUoybEhGQm9vKy91eDc2d2gvaEM1N1BPZjNycmZiNHFQ?= =?utf-8?B?Zm1TbDlVb1J2aUJZY1h1N1J1ZXE2UnFqQlo5L3RkK2t1SkVuTXpKMU9mWUpk?= =?utf-8?B?d1AxS0pDTi94aHp6UEZCZDlOL1lnZ1FEeWZRYXY4QmI4M1c3REJ5REovbi9M?= =?utf-8?B?VFVuOExvdGdEenNXbmlUVFU4eDFHaW1Od2ZYZWtPMCthdlhSVjdhVDIxRHNq?= =?utf-8?B?OG43eGQybFhyeXFOcWNXS0hXYWtIc3dIWFpFNWpjSkRYNEJOVmpxejlnUU5N?= =?utf-8?B?KzVIR0JBRkZXN3Fla2J3SVVZaGdqd0x2bFJCdFQvMU8yTURVOHJjWlQ3ZWpX?= =?utf-8?B?Q2ZiYUxVVUd5Tmw5WHRlazhvZmZjbW1NcUZEdkc0TVBjb2h3cUUxYWJDRDhq?= =?utf-8?B?eXBnWXNtOUg4SjlTc3dZdHpYeXJHMGFVS2lIcWlhMWwwVm9Hd0RrSFFQN0Yy?= =?utf-8?B?Rk9xcUJMbUFXdDhmbk0xaEtsYmtlZi8xVS9mekh0MFZPNHdaNndkUm5KWEQ1?= =?utf-8?B?bmtBQVk0dUFoQXhNWXVBZlFuSldLdkZ5cFY0bHlPaVBZQTFQL0dWNE45T3Zm?= =?utf-8?B?RUhsUnhOaXhuWEVxS1E0UnNaRXd3MmV1RCt5SFBBSnNOWThuUU01bHpxYVdT?= =?utf-8?B?TGJBRi9rYUJpSnkxS3hsN1NrdzZ2MU9PTXlhbU10ak9xSmxKNEVpSysxVDYx?= =?utf-8?B?Y2p3eDIxZ2Fzdm9seW9haGswVHg3WEFOUlpKZFhjaURRYnFBRnQvUXBCRjRW?= =?utf-8?B?Vi9BT0JqbXViV3ZzT3RWdDlsUHNESjRhQytUR1hpM3NkOVI3K2xSZE5iNW45?= =?utf-8?B?RVNyNHlucnFaZFhUSUQwTlNtbUs1aWRham44OEJQdm8vV1lNb2phdHZpdkJR?= =?utf-8?B?T29PZytSeTdqa0dTMkNyQkpveEhKYVRHQURNQT09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014)(7416014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:47:41.5090 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7268f07b-1852-491d-52d1-08dd987ed22c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017090.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8649 Its only purpose was for trace events, but jobs can already be uniquely identified using their fence. The downside of using the fence is that it's only available after 'drm_sched_job_arm' was called which is true for all trace events that used job.id so they can safely switch to using it. Suggested-by: Tvrtko Ursulin Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Christian K=C3=B6nig Reviewed-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 ++++++------------ .../gpu/drm/scheduler/gpu_scheduler_trace.h | 18 ++++++------------ drivers/gpu/drm/scheduler/sched_main.c | 1 - include/drm/gpu_scheduler.h | 3 --- 4 files changed, 12 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/am= d/amdgpu/amdgpu_trace.h index 11dd2e0f7979..4fd810cb5387 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h @@ -167,7 +167,6 @@ TRACE_EVENT(amdgpu_cs_ioctl, TP_PROTO(struct amdgpu_job *job), TP_ARGS(job), TP_STRUCT__entry( - __field(uint64_t, sched_job_id) __string(timeline, AMDGPU_JOB_GET_TIMELINE_NAME(job)) __field(unsigned int, context) __field(unsigned int, seqno) @@ -177,15 +176,14 @@ TRACE_EVENT(amdgpu_cs_ioctl, ), =20 TP_fast_assign( - __entry->sched_job_id =3D job->base.id; __assign_str(timeline); __entry->context =3D job->base.s_fence->finished.context; __entry->seqno =3D job->base.s_fence->finished.seqno; __assign_str(ring); __entry->num_ibs =3D job->num_ibs; ), - TP_printk("sched_job=3D%llu, timeline=3D%s, context=3D%u, seqno=3D%u,= ring_name=3D%s, num_ibs=3D%u", - __entry->sched_job_id, __get_str(timeline), __entry->context, + TP_printk("timeline=3D%s, context=3D%u, seqno=3D%u, ring_name=3D%s, n= um_ibs=3D%u", + __get_str(timeline), __entry->context, __entry->seqno, __get_str(ring), __entry->num_ibs) ); =20 @@ -193,7 +191,6 @@ TRACE_EVENT(amdgpu_sched_run_job, TP_PROTO(struct amdgpu_job *job), TP_ARGS(job), TP_STRUCT__entry( - __field(uint64_t, sched_job_id) __string(timeline, AMDGPU_JOB_GET_TIMELINE_NAME(job)) __field(unsigned int, context) __field(unsigned int, seqno) @@ -202,15 +199,14 @@ TRACE_EVENT(amdgpu_sched_run_job, ), =20 TP_fast_assign( - __entry->sched_job_id =3D job->base.id; __assign_str(timeline); __entry->context =3D job->base.s_fence->finished.context; __entry->seqno =3D job->base.s_fence->finished.seqno; __assign_str(ring); __entry->num_ibs =3D job->num_ibs; ), - TP_printk("sched_job=3D%llu, timeline=3D%s, context=3D%u, seqno=3D%u,= ring_name=3D%s, num_ibs=3D%u", - __entry->sched_job_id, __get_str(timeline), __entry->context, + TP_printk("timeline=3D%s, context=3D%u, seqno=3D%u, ring_name=3D%s, n= um_ibs=3D%u", + __get_str(timeline), __entry->context, __entry->seqno, __get_str(ring), __entry->num_ibs) ); =20 @@ -551,7 +547,6 @@ TRACE_EVENT(amdgpu_ib_pipe_sync, TP_ARGS(sched_job, fence), TP_STRUCT__entry( __string(ring, sched_job->base.sched->name) - __field(uint64_t, id) __field(struct dma_fence *, fence) __field(uint64_t, ctx) __field(unsigned, seqno) @@ -559,13 +554,12 @@ TRACE_EVENT(amdgpu_ib_pipe_sync, =20 TP_fast_assign( __assign_str(ring); - __entry->id =3D sched_job->base.id; __entry->fence =3D fence; __entry->ctx =3D fence->context; __entry->seqno =3D fence->seqno; ), - TP_printk("job ring=3D%s, id=3D%llu, need pipe sync to fence=3D%p, co= ntext=3D%llu, seq=3D%u", - __get_str(ring), __entry->id, + TP_printk("job ring=3D%s need pipe sync to fence=3D%p, context=3D%llu= , seq=3D%u", + __get_str(ring), __entry->fence, __entry->ctx, __entry->seqno) ); diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/= drm/scheduler/gpu_scheduler_trace.h index 4ce53e493fef..781b20349389 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h @@ -36,7 +36,6 @@ DECLARE_EVENT_CLASS(drm_sched_job, TP_PROTO(struct drm_sched_job *sched_job, struct drm_sched_entity *en= tity), TP_ARGS(sched_job, entity), TP_STRUCT__entry( - __field(uint64_t, id) __string(name, sched_job->sched->name) __field(u32, job_count) __field(int, hw_job_count) @@ -47,7 +46,6 @@ DECLARE_EVENT_CLASS(drm_sched_job, ), =20 TP_fast_assign( - __entry->id =3D sched_job->id; __assign_str(name); __entry->job_count =3D spsc_queue_count(&entity->job_queue); __entry->hw_job_count =3D atomic_read( @@ -57,8 +55,8 @@ DECLARE_EVENT_CLASS(drm_sched_job, __entry->fence_seqno =3D sched_job->s_fence->finished.seqno; __entry->client_id =3D sched_job->s_fence->drm_client_id; ), - TP_printk("dev=3D%s, id=3D%llu, fence=3D%llu:%llu, ring=3D%s, job cou= nt:%u, hw job count:%d, client_id:%llu", - __get_str(dev), __entry->id, + TP_printk("dev=3D%s, fence=3D%llu:%llu, ring=3D%s, job count:%u, hw j= ob count:%d, client_id:%llu", + __get_str(dev), __entry->fence_context, __entry->fence_seqno, __get_str(name), __entry->job_count, __entry->hw_job_count, __entry->client_id) ); @@ -95,7 +93,6 @@ TRACE_EVENT(drm_sched_job_add_dep, TP_STRUCT__entry( __field(u64, fence_context) __field(u64, fence_seqno) - __field(u64, id) __field(u64, ctx) __field(u64, seqno) ), @@ -103,12 +100,11 @@ TRACE_EVENT(drm_sched_job_add_dep, TP_fast_assign( __entry->fence_context =3D sched_job->s_fence->finished.context; __entry->fence_seqno =3D sched_job->s_fence->finished.seqno; - __entry->id =3D sched_job->id; __entry->ctx =3D fence->context; __entry->seqno =3D fence->seqno; ), - TP_printk("fence=3D%llu:%llu, id=3D%llu depends on fence=3D%llu:%llu", - __entry->fence_context, __entry->fence_seqno, __entry->id, + TP_printk("fence=3D%llu:%llu depends on fence=3D%llu:%llu", + __entry->fence_context, __entry->fence_seqno, __entry->ctx, __entry->seqno) ); =20 @@ -118,7 +114,6 @@ TRACE_EVENT(drm_sched_job_unschedulable, TP_STRUCT__entry( __field(u64, fence_context) __field(u64, fence_seqno) - __field(uint64_t, id) __field(u64, ctx) __field(u64, seqno) ), @@ -126,12 +121,11 @@ TRACE_EVENT(drm_sched_job_unschedulable, TP_fast_assign( __entry->fence_context =3D sched_job->s_fence->finished.context; __entry->fence_seqno =3D sched_job->s_fence->finished.seqno; - __entry->id =3D sched_job->id; __entry->ctx =3D fence->context; __entry->seqno =3D fence->seqno; ), - TP_printk("fence=3D%llu:%llu, id=3D%llu depends on unsignalled fence= =3D%llu:%llu", - __entry->fence_context, __entry->fence_seqno, __entry->id, + TP_printk("fence=3D%llu:%llu depends on unsignalled fence=3D%llu:%llu= ", + __entry->fence_context, __entry->fence_seqno, __entry->ctx, __entry->seqno) ); =20 diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/sched= uler/sched_main.c index abe8eae752e5..bc465ee9072f 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -853,7 +853,6 @@ void drm_sched_job_arm(struct drm_sched_job *job) =20 job->sched =3D sched; job->s_priority =3D entity->priority; - job->id =3D atomic64_inc_return(&sched->job_id_count); =20 drm_sched_fence_init(job->s_fence, job->entity); } diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index 6fe3b4c0cffb..48190fdf661a 100644 --- a/include/drm/gpu_scheduler.h +++ b/include/drm/gpu_scheduler.h @@ -326,7 +326,6 @@ struct drm_sched_fence *to_drm_sched_fence(struct dma_f= ence *f); * @finish_cb: the callback for the finished fence. * @credits: the number of credits this job contributes to the scheduler * @work: Helper to reschedule job kill to different context. - * @id: a unique id assigned to each job scheduled on the scheduler. * @karma: increment on every hang caused by this job. If this exceeds the= hang * limit of the scheduler then the job is marked guilty and will n= ot * be scheduled further. @@ -339,8 +338,6 @@ struct drm_sched_fence *to_drm_sched_fence(struct dma_f= ence *f); * to schedule the job. */ struct drm_sched_job { - u64 id; - /** * @submit_ts: * --=20 2.43.0 From nobody Sun Dec 14 19:30:17 2025 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2082.outbound.protection.outlook.com [40.107.220.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DEA9220F57; Wed, 21 May 2025 15:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842474; cv=fail; b=nzDF0eEVYsW4AkCKmPbAQ3XKUmldwmrvRR2AEulHo7henh/HQyIKheH4DabQQwtmwZfvt0f0cWrg/PUjDlAwADrGYZvHBNgByRDIPQ5JuX/ZRwQZ1MmzXEpFUGJX3JR0UpTA+EvPPZmF6T42f/PzK07nT8J2/QMljcK5r3qDFR0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842474; c=relaxed/simple; bh=jhpGfvv6CWUzPoQCHO3Atk0OtyqOuJlyW3j0S+K3L1o=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EH1QgOsZzRUUOYjYEM4HG2N5g9d734yfggyBlLkVvyQP2+/gTOP7WdtzoY0Rpm90bbKtb62q7jT7lYl5vNi6BnNvgXUgE3AcTibD4wjUsuEjQbkbWdOVMEQncP2V67ahkafOvG3sq3cgUC/rVwbex3h6glDrYSEfZ24HAf0b9gM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=0vemNurX; arc=fail smtp.client-ip=40.107.220.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="0vemNurX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DrOxjw0Hg4gPt5nab6D73dB9MLsysGIGQxG9ebylqzsbiK9n6V1osdY8ieVvQyggsYPdV0K1hVB8ySfTuqxJJ+XWNhZYPk/EeEeOEt2jUzdYK662Lh0J3xC3DKPkXpkCzxkBm0JIgWrQkp11qEx6pt8YutqEzn/iAgmLZT8emnU3KhImNRIVzM5RnWq90QfcGojRx0hbdh2OWNfokKt2fvYQfjDG0ZOU6+BJT+lyNvk3FuNIew+Dn8QwTUnvAjibZqjnrlgJ7xH6UMQpTj5d2uOM2zOMI5eWTs/W+mp9qcV+fnxEz8IoU1/Fc2XBPc3TBlvt6C8B/mUMZ/3nHWrRqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zw2huqsza4q5J5wpoyqjqOyZRA3CmN84hy7iWKy+kRo=; b=nqbKFO059KkRT14+F8izeNXRFsyaXq6vEOe1pvVvc1faA/rm/At94CRAvoaCPqEH7ICPgUog6V3NG2GOjK+odBJFoSQH7CF6FKyNfUeQ6qciTsSgsG+d6CgtKxK4ymd3FBJuuQHl3R2JM5AAZfzJ1655DCA+GUMSDte00xM9x8dWvl21npmvL/zTdf/zrLXO2az0di7qYrRyJqxwnlDhuQ8jRuW4rLz7/cLyeohuzqw8ZoVqNAZw+bmtpG7wGhFWtUTs6IlfwzT1tzDRoAqNHO3WCs4fSVhS0IkZYSdZByVuX6qj7LN8DtJ0YPPx4bJeJ1KjShXMuoR7j9iNXJvCTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zw2huqsza4q5J5wpoyqjqOyZRA3CmN84hy7iWKy+kRo=; b=0vemNurXepMuTJfrnSSQg4YZiYryBPqDASCZu/Kz3PquREWSgI3ZN7auo3d0/t+7vS3IaKQEnkh8xyhlBj/iD/9YW6shLlr00dBIzUwUnWRI7elDKOCarZQGECKI7gJQt8+q2l8+s7OS2WAj26p12rj0RIXk34Rt3uvQ6+RbSKA= Received: from DS7PR03CA0268.namprd03.prod.outlook.com (2603:10b6:5:3b3::33) by CYYPR12MB8921.namprd12.prod.outlook.com (2603:10b6:930:c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Wed, 21 May 2025 15:47:49 +0000 Received: from DS1PEPF00017092.namprd03.prod.outlook.com (2603:10b6:5:3b3:cafe::18) by DS7PR03CA0268.outlook.office365.com (2603:10b6:5:3b3::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:47:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017092.mail.protection.outlook.com (10.167.17.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:47:49 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:47:46 -0500 From: Pierre-Eric Pelloux-Prayer To: David Airlie , Simona Vetter , "Maarten Lankhorst" , Maxime Ripard , Thomas Zimmermann , "Jonathan Corbet" , Matthew Brost , "Danilo Krummrich" , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , "Sumit Semwal" CC: Pierre-Eric Pelloux-Prayer , "Lucas Stach" , =?UTF-8?q?Ma=C3=ADra=20Canal?= , =?UTF-8?q?Christian=20K=C3=B6nig?= , , , , , Subject: [PATCH v10 09/10] drm/doc: Document some tracepoints as uAPI Date: Wed, 21 May 2025 17:45:11 +0200 Message-ID: <20250521154531.10541-10-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> References: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017092:EE_|CYYPR12MB8921:EE_ X-MS-Office365-Filtering-Correlation-Id: b0d82ef2-6a9e-4d56-b781-08dd987ed724 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014|7416014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MFBqcXlKVXM5aFlyQUxkSHFNNUpyS3Znam15TCtXTFVlT1lGNkdWMVFodUdW?= =?utf-8?B?ZFZqdEt0QVVPK0FEUFprbnpFeUlOcEV3bSswRm52TzlsNXZkN3RuSVNIZXZ4?= =?utf-8?B?am8wR05SS3puVXpGeFNHamllTXp4UGlvdWdYeFVnWnI0aC94NkNaMXdLWUxS?= =?utf-8?B?UE1LZXhPWWlyZHNROEEvMUNYR255Rmg3c0h0VDVRWURhODFDRGRaUFQ4SDFr?= =?utf-8?B?YmczcEowQW8wS3BwNFpZdnRXVEhoZlNMczhrdWNJcVNFdlVkN2o1cTFLUk5E?= =?utf-8?B?MVRZd2pTUzFZd29Va0ZDWVQ4Q2Y5aGxDWWRKc3VxL3ZUUVVsSUxUc3FhM0ww?= =?utf-8?B?VjJHTUxjcXkxeXpCOW82aHlBcUlnK3ZGRHZFYXArV2p5ak5XdGpNTlB4WFRk?= =?utf-8?B?QjQ0T2J1OFY3OWZtR29HTC9WN2xSK2xiUlFONlFOUFh2YWs0M1dMV1pzYmln?= =?utf-8?B?c0h6RU9pbllteC9ObTVPb1pBZWtBc0NMa3lINlcybnBOMlZReHNMM3k3czZW?= =?utf-8?B?ZnhEVVVzUUFlM0lMY3NETlNmbjJWMDdTdXZZd20yWkdLUHFwS1ZBZ1JqcFJK?= =?utf-8?B?OUpUbkdiWHBPR1ExVUxjODVlZm96aUtQUEJvUWNncEpWU1NXYVV1Qk40WjhF?= =?utf-8?B?blFzcStUaWVvL2s2ZDdIenRNRnJ3VThvRlFmQXVxNzNSRy94MnF2dXpMVTJV?= =?utf-8?B?T2YxZ3lySWxtOGNqdFgxTjVtVzhoN2JVeHFod0dMYjdIOFBEQ3JsYTNHczZ1?= =?utf-8?B?VTlJT3dQbXdJZlgzWnZKQ3pVMllkUFllYUdJVWZzd3V1YjJpQVQrSy8ybjZt?= =?utf-8?B?Yjl1QXh1OUVWNXpFRVRLK1AxbUZuVTJqdHVjVUJmZFZHM3RQQUxNMTRXeG5X?= =?utf-8?B?YzZsOGpzbWF3eVVoaWhldDl4bEFudDF1T2FGSjlCYWtJZm03K0pkWUdIdjhE?= =?utf-8?B?UXBJeUZHVUF3WUdSeG4wN1Z0TjNDamVaZTJtQno2d1JtckJ3blJpL0VGS1hX?= =?utf-8?B?cDU5UlhibjdkL0JzSVV0aWozSWN6REtTOVNwZlJRVXFOR3dyTGF3UXUxU2Z5?= =?utf-8?B?SDhyOFlicC9qc0NabmkrZmRNMmJmeFV6K09UVVd1VW5mZVBhcy8wTHNiWG5J?= =?utf-8?B?VGhjSklMTXQzMTlIZTcwOWtIdHczVEpGc3lRQ0Q0cisyc045ajYyWGtUVDB6?= =?utf-8?B?ejVodkw3cUdqWC9OU0lDN1VwaTlPRm5wK2VybTcxelNVZ0c1Y0NGdnBMVm5V?= =?utf-8?B?cjFRK09mTVVKM09qOVU5YWJmUkV0ays1RnVNVy9Jc01hQlNZVVExSXdBVnZY?= =?utf-8?B?UDB4NTRZaUJ3UVB5emtmcm9XcVlUb3d3dVg1WDlSZ2oxUXBNbFFxTGN3cFdz?= =?utf-8?B?UlFsemlheDhYSnQrNjNHY0Q5d0p0VHZqN0ZraHFrVlNzNm9nRTA3NFdBWFlI?= =?utf-8?B?azVLU0p3RTVnZ2Y4eXJSZERxWFZVOUZiYUpVVm9nelhHcXM4b0piY3FpNDRn?= =?utf-8?B?TVpxZGRvT3lZcnhjMkJJSzRKNnRhZXNwWEFrTncvU2VyS2p6Y0d2ZGMwSklP?= =?utf-8?B?MWZnYldrWURUdGkzSzFNNkhSbXZsWE41bSs3Qk1wUEhSWkZkRitiSTNETGxr?= =?utf-8?B?WUFla3ZMbUlvc25nSzhtV0pub1JUUE92TjhzSlowRlJDNWxKN3hpWi9yazh4?= =?utf-8?B?emFTeWtUbFF6VXZTaklaSnBJYUNmMkhsNCs0RWJLdzJ6bXBFbWNaTFlFUlJG?= =?utf-8?B?TFF0K1R3M1pBS2JnK2laL2JQWmF3N2ZveG5jbkR6ajM1L3I3UTJWSGo4aEdl?= =?utf-8?B?dERTSFM4L3d6WmYxT01vNmJHU1crcGRHYkpjUVNFcjA1aG9tQUV5YTE2UkRm?= =?utf-8?B?cUdvS1BPOGFtMFNSaTlYRjh0dUlrSjI1RHdoanhpMjZBNkdMRUU5dUFFSy9W?= =?utf-8?B?MGpIQWo0TlhtbU9FN2JqSHU5WWRWRFE1aVdHVlIxKzdIZzRMUk00ME4vQ0pP?= =?utf-8?B?eER6bVJCREpmQ1c4ekxob3VvR3JtaFArblVZaXl2bzVMVk5DMkFvamF2TVFp?= =?utf-8?B?Nk1INFJxT3padWFXaFBHUlhkejNDUDZwRFAxdz09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(7416014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:47:49.8476 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0d82ef2-6a9e-4d56-b781-08dd987ed724 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017092.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8921 This commit adds a document section in drm-uapi.rst about tracepoints, and mark the events gpu_scheduler_trace.h as stable uAPI. The goal is to explicitly state that tools can rely on the fields, formats and semantics of these events. Acked-by: Lucas Stach Acked-by: Ma=C3=ADra Canal Reviewed-by: Christian K=C3=B6nig Signed-off-by: Pierre-Eric Pelloux-Prayer --- Documentation/gpu/drm-uapi.rst | 19 ++++++++++++++++ .../gpu/drm/scheduler/gpu_scheduler_trace.h | 22 +++++++++++++++++++ 2 files changed, 41 insertions(+) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst index 69f72e71a96e..4863a4deb0ee 100644 --- a/Documentation/gpu/drm-uapi.rst +++ b/Documentation/gpu/drm-uapi.rst @@ -693,3 +693,22 @@ dma-buf interoperability =20 Please see Documentation/userspace-api/dma-buf-alloc-exchange.rst for information on how dma-buf is integrated and exposed within DRM. + + +Trace events +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +See Documentation/trace/tracepoints.rst for information about using +Linux Kernel Tracepoints. +In the DRM subsystem, some events are considered stable uAPI to avoid +breaking tools (e.g.: GPUVis, umr) relying on them. Stable means that fiel= ds +cannot be removed, nor their formatting updated. Adding new fields is +possible, under the normal uAPI requirements. + +Stable uAPI events +------------------ + +From ``drivers/gpu/drm/scheduler/gpu_scheduler_trace.h`` + +.. kernel-doc:: drivers/gpu/drm/scheduler/gpu_scheduler_trace.h + :doc: uAPI trace events \ No newline at end of file diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/= drm/scheduler/gpu_scheduler_trace.h index 781b20349389..261713dd7d5a 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h @@ -32,6 +32,28 @@ #define TRACE_SYSTEM gpu_scheduler #define TRACE_INCLUDE_FILE gpu_scheduler_trace =20 +/** + * DOC: uAPI trace events + * + * ``drm_sched_job_queue``, ``drm_sched_job_run``, ``drm_sched_job_add_dep= ``, + * ``drm_sched_job_done`` and ``drm_sched_job_unschedulable`` are consider= ed + * stable uAPI. + * + * Common trace events attributes: + * + * * ``dev`` - the dev_name() of the device running the job. + * + * * ``ring`` - the hardware ring running the job. Together with ``dev`` = it + * uniquely identifies where the job is going to be executed. + * + * * ``fence`` - the &struct dma_fence.context and the &struct dma_fence.s= eqno of + * &struct drm_sched_fence.finished + * + * All the events depends on drm_sched_job_arm() having been called alread= y for + * the job because they use &struct drm_sched_job.sched or + * &struct drm_sched_job.s_fence. + */ + DECLARE_EVENT_CLASS(drm_sched_job, TP_PROTO(struct drm_sched_job *sched_job, struct drm_sched_entity *en= tity), TP_ARGS(sched_job, entity), --=20 2.43.0 From nobody Sun Dec 14 19:30:17 2025 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2070.outbound.protection.outlook.com [40.107.212.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72EC7220689 for ; Wed, 21 May 2025 15:48:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842489; cv=fail; b=FWJQaKS2ZtTWq+uaqT1VBj7sHabIHcJFEI33+ghEam2e5uczVSimXbxU9LO4C/nDmEtcOWyFyOELoZK+PuvTUTH1svsIzsvlYHe+TQsSy49k1ZKYm7mhUmR5D8UJ/Z4VAR645MmIyeftO1RNd75eOvgwXTmHyds8FTjxoDl6XCs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842489; c=relaxed/simple; bh=S4exrgp6nCCnjpU75pvGfnP76/5r83VUA6Fzx6/riZQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PDCdGg8GQmbIB41AR7aCcANU2Ccf0Vepb323O060WB6eHT0rsR5U5sdWUj92nnVEoup6Y4t958WuEfjuJXlec+oKzyZHSykLLG+jZWh95+bg/EPx5EMkvp2v14hKK6wzTf76WSmBboyjFgRewzkhNxE/bgy3QvCRYbGvcfKMtnw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=iNAxYDQr; arc=fail smtp.client-ip=40.107.212.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="iNAxYDQr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kFu0BR29RSCNRFiSJnatLygHG3OkWbfRBRtcqbUpWUr2BhElBMM6OQk8fUGilozymIyUctm/d0K4qcptlSNb1OBSoKWDDat3+h0qD9ZqzNUmxzG7zhQPZHSkQdhRBXKtAMRlrusupoOuCxTeVXgXegj2EgAAJ9l0tTIYSp7xHSr+xA7LASeIQp6/fYKBp+CMlBNcgNy3J1MGIuIoGbvPVEmL4WEM5/PMb4fCifVb8fbxmjWRJvSJ3yS7TZmUbIivANlZY3vTie/Da9jNU3a0L1S/C76AC7nF3b+AEmun/zQwcuQu8DYE51esb6Zlt44tsY0bG4Wi33KmO+cAnLGYkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9+D/MixmJoxbu9aKCUjkmWdqscb9PVWuTnt6HvTbnqQ=; b=AGOlyxt52u5koJh82tIv5Yj7KkTYrMquJMPMcRnS03XqcQdw7OVpJG/DUiKunbdgWTiNL2en7GMvfSZ+zYfYdQUOPnIRfh/l3F1GvJxJC1MjPGqnP/yZXb5xeyT3Dcu+250+Q9MOgoXk5HZPcNUdYOCO+I3OwK7R2NrogaV193feABxbGb82b58daRUkj1ArCJsxKLYgWNfoQmIV3CIptH1xXfc6PSc4CUnN3Ob83Qj8viTf/I/qN4VgYqfUNhGzXZcGdJ8AB0nb/TwFCAcctIQ1beUA0d8/OJZrr6U4FgvVm6AEagdj9h1EbDNt+eMwREwVI2biQR5SkxGJD+Wv4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9+D/MixmJoxbu9aKCUjkmWdqscb9PVWuTnt6HvTbnqQ=; b=iNAxYDQroRgfoY6jHLkFq0sot9O0VvE+9VsWlqVadT3k3mEli2NmSFot3gJqfMXm9ECogXfBWkKSoaSUEiiKxcWx4ooZ7FXBTQ10qVT9BbGggUqQORApmNHOQ2d+MpSJIHovCDhx2Uonb/Ax6AhOQs0yO2e2yeHb6cdd91jNoY8= Received: from DM6PR01CA0016.prod.exchangelabs.com (2603:10b6:5:296::21) by IA0PR12MB7626.namprd12.prod.outlook.com (2603:10b6:208:438::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Wed, 21 May 2025 15:48:02 +0000 Received: from DS1PEPF0001708E.namprd03.prod.outlook.com (2603:10b6:5:296:cafe::e3) by DM6PR01CA0016.outlook.office365.com (2603:10b6:5:296::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:48:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0001708E.mail.protection.outlook.com (10.167.17.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:48:02 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:48:00 -0500 From: Pierre-Eric Pelloux-Prayer To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter CC: Pierre-Eric Pelloux-Prayer , "Arvind Yadav" , , , Subject: [PATCH v10 10/10] drm/amdgpu: update trace format to match gpu_scheduler_trace Date: Wed, 21 May 2025 17:45:12 +0200 Message-ID: <20250521154531.10541-11-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> References: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001708E:EE_|IA0PR12MB7626:EE_ X-MS-Office365-Filtering-Correlation-Id: 2113e563-295a-4374-4a47-08dd987edebc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aXZSN3VSL0xZN1dnSDAxR0tsQVpXak11Q21ab1dlSE8xU2taSkVhdHJoNitu?= =?utf-8?B?M3lhei80S0cxUVo3Q0hRYjlCQnl6Unduc2ZOYTh0S2t6eG5QSHh6S2sxSnhp?= =?utf-8?B?M2lWb2R1N0N6QlFpTHZ4OGZweWk2cVZORXdBbFV0d2hMWTZyRXFBYmorOFRr?= =?utf-8?B?SlN3YTlTMVdnWmRJOHFPOGxJU3UzWU13RHA2OVAyVEVTWlFJYWl2V1ArUTlp?= =?utf-8?B?VWJ1MnR2bUdFdmYzYzFMY2FMYXBKN2JyaU84NUk3Y085RDJCRHMrQWsxME5r?= =?utf-8?B?SW11N3RrODJ4b0o5M0VjY0JxaGtWQjFkOU1VanNmczlPRUZPNk56MHprVWtZ?= =?utf-8?B?a3o2QzR1a0Ixb2ovMko0QkllU1dsMWt5K3BWOFQyWnZ2ajd4OWw1YVR4UUtI?= =?utf-8?B?Zmw2VkFTSWx0QmlLcDVlUVU1V3dZY2VrMVpKNFY2UzgzcERBRWxZeEZ6dStD?= =?utf-8?B?NmFyTGFkZC9NMHFqMWw1ak5GSTlBbTJBUE5EOVJ2NThBMnRaZHRxa0tjency?= =?utf-8?B?alBOVy85SGc4bks0alVIUjg4enhhT2s3MWdEY1hPSXE3bmoxaUVYMU8yVE1k?= =?utf-8?B?MGdVcytqNnVpZXNCVjhyRkhBZXNkMVprMXk4a3l5NW1VUzZ0ZEJtWXVIT0Vs?= =?utf-8?B?MzZvWDhkOGhocDU5elBkRmQ5ajF1a3VwUjk1U1NWU3kxYzBJbVR4QXZWa1Yv?= =?utf-8?B?UUVDQWZRbktmdHI3czFtWEVjQjhyZWRlekx3emM3TDk1Y0FTY1psY1NiT2VS?= =?utf-8?B?QUc1Q1cySElESjNMT3JZRnhBY21iRFhWd21raHoyZGJFYWpxWDhHUndPWGdQ?= =?utf-8?B?RHA2VVdQc0JWcWR1UXpHN05NSGdnS05wbDJBSFFBYzdGOFJTY3FPRVB3TjNx?= =?utf-8?B?OGdRcWVLUzZzbWE3azNoMDNUM3NCSFhYRFBKTjZSNk5oMGlaVDcwRVdFTEV5?= =?utf-8?B?bnpkLzY0aGR4Z3hTU2gxVkVNYXUxTVRaU09rdTVQWmJFd3pxZ1hOcm5zRmNy?= =?utf-8?B?eUJXTFhPZDNFLzkwQi90cld4QkNXZzBiVHlydUpRdS81RlBIS3pad2VFVFo3?= =?utf-8?B?QTB0QmxXelBLbVcvZXNkMCtnYkVCL1lPY2tKWlhMaXMveEFKY3FnaDBvcmJW?= =?utf-8?B?RDBubXI3dnh5RVlUMkxSbmZHOGFCOFlyR1JQY0k1elRjMG1HVEgyTWRZZ29r?= =?utf-8?B?OW9HekpzbzQzK0JrQVNmdWxxYzZmKy9DbC9ONzZ0MUQvNHFNeUdwbTkzVDVu?= =?utf-8?B?NjhZNnVFMjZBUWUrOXU1TnY2RXhsSUVqdlJUanBvTm1ldEZCRzNDazQyWVhp?= =?utf-8?B?SnFNMEFtOE1FZlJleEkxcHN0Q1Q2YkR1eTIzR2xHaEhRcmRUUHg4Vm5melNV?= =?utf-8?B?UE96bUpEZnhqa3VMMFB0aTlJSTZONStvd1ptdS83M1Jjc3FWcUJSeHZYY1dk?= =?utf-8?B?anRyaXpQNU00L3Z3K0VNK0pYZ3U4VG1sV2wralNSTEZDQXRMRmV4SU9lYnV2?= =?utf-8?B?aEp5TU0xN0ZORkI3MHovdnN5RkIxUEozR1BrR1NhbGJNdUl0dTZ2UXBueXRl?= =?utf-8?B?SVhKT21Idy9VSHZIZWNyU2IvV3pUTm14RU9XUTdsRERpdXZpRDNURENnaG1Z?= =?utf-8?B?MFFmMFNDM2NlaEs3N0NHdWYvU2lTVjJMR21GSjMrQUdVRVB6TUF1ZWlZQWF3?= =?utf-8?B?S1A1b2ttYk5KMDF1RlpnWDBhRXZ2eVhMS0xodFFtZU9DeTN3L2xyM1kzOFNl?= =?utf-8?B?KzVnOGEvTmNIdmZGT1FNRXRDdU5EdnpMZFp6L1RaNFNSZ0NRVmtrQ09USHhD?= =?utf-8?B?SmRNS1RFM3pQOXlXaThIMVNvaEpjMFhMZzlHUjFHc3FJTlI4dHY3cmF0RlhF?= =?utf-8?B?bnVRbnpjQjFsYlBYbWVkWFpsV1c5Q3FxUm50SXhxZ1ZkTVNoU28yaklkQUxr?= =?utf-8?B?RTlnUzVwTDR5SmwxTFFheExBTHZJNTBwNHg5dEZ1WEFQdWFUR2FCd2NaSFFQ?= =?utf-8?B?blBhQUlNb2NBVURKVmZkSnpQeHpKRU83OU9QaUxDVGNaSVlUcjhWK1ZpVjVP?= =?utf-8?Q?8h7fiP?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:48:02.5852 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2113e563-295a-4374-4a47-08dd987edebc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001708E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7626 Log fences using the same format for coherency. Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Christian K=C3=B6nig Reviewed-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/am= d/amdgpu/amdgpu_trace.h index 4fd810cb5387..d13e64a69e25 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h @@ -168,8 +168,8 @@ TRACE_EVENT(amdgpu_cs_ioctl, TP_ARGS(job), TP_STRUCT__entry( __string(timeline, AMDGPU_JOB_GET_TIMELINE_NAME(job)) - __field(unsigned int, context) - __field(unsigned int, seqno) + __field(u64, context) + __field(u64, seqno) __field(struct dma_fence *, fence) __string(ring, to_amdgpu_ring(job->base.sched)->name) __field(u32, num_ibs) @@ -182,7 +182,7 @@ TRACE_EVENT(amdgpu_cs_ioctl, __assign_str(ring); __entry->num_ibs =3D job->num_ibs; ), - TP_printk("timeline=3D%s, context=3D%u, seqno=3D%u, ring_name=3D%s, n= um_ibs=3D%u", + TP_printk("timeline=3D%s, fence=3D%llu:%llu, ring_name=3D%s, num_ibs= =3D%u", __get_str(timeline), __entry->context, __entry->seqno, __get_str(ring), __entry->num_ibs) ); @@ -192,8 +192,8 @@ TRACE_EVENT(amdgpu_sched_run_job, TP_ARGS(job), TP_STRUCT__entry( __string(timeline, AMDGPU_JOB_GET_TIMELINE_NAME(job)) - __field(unsigned int, context) - __field(unsigned int, seqno) + __field(u64, context) + __field(u64, seqno) __string(ring, to_amdgpu_ring(job->base.sched)->name) __field(u32, num_ibs) ), @@ -205,7 +205,7 @@ TRACE_EVENT(amdgpu_sched_run_job, __assign_str(ring); __entry->num_ibs =3D job->num_ibs; ), - TP_printk("timeline=3D%s, context=3D%u, seqno=3D%u, ring_name=3D%s, n= um_ibs=3D%u", + TP_printk("timeline=3D%s, fence=3D%llu:%llu, ring_name=3D%s, num_ibs= =3D%u", __get_str(timeline), __entry->context, __entry->seqno, __get_str(ring), __entry->num_ibs) ); @@ -548,8 +548,8 @@ TRACE_EVENT(amdgpu_ib_pipe_sync, TP_STRUCT__entry( __string(ring, sched_job->base.sched->name) __field(struct dma_fence *, fence) - __field(uint64_t, ctx) - __field(unsigned, seqno) + __field(u64, ctx) + __field(u64, seqno) ), =20 TP_fast_assign( @@ -558,10 +558,8 @@ TRACE_EVENT(amdgpu_ib_pipe_sync, __entry->ctx =3D fence->context; __entry->seqno =3D fence->seqno; ), - TP_printk("job ring=3D%s need pipe sync to fence=3D%p, context=3D%llu= , seq=3D%u", - __get_str(ring), - __entry->fence, __entry->ctx, - __entry->seqno) + TP_printk("job ring=3D%s need pipe sync to fence=3D%llu:%llu", + __get_str(ring), __entry->ctx, __entry->seqno) ); =20 TRACE_EVENT(amdgpu_reset_reg_dumps, --=20 2.43.0