From nobody Wed Dec 17 06:06:56 2025 Received: from baidu.com (mx22.baidu.com [220.181.50.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8979B125D6; Wed, 21 May 2025 03:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.181.50.185 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747799257; cv=none; b=IGLIQAiiMJD9+MWqgx9jb/zckJHqLLQj71i4ZwM5kBkQZGfoQm2QrUqoqeQZjp5Bq5NlP1G9zKKFP0WW1ovPItJneFBrTdedo+AkoBLj50VTtcW5LBtlQOB7jPtaUKtuKkBOdflREJFz8FZDTj1cG4X9pdrRr6CCkX2ZGFMESE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747799257; c=relaxed/simple; bh=scoXlmc+F0clhdkke8G66hbM+VSuWs0kzFoGtA/DhT0=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=l51vr5yaWLianragFEFmvaprhrthYppE4Pqy9V1vfygIZ28p90dAEdSTpS5R1KJoKw7sMN61ibq115MqBUnq/WFc1XX5haE3RPeGAJa+PH+13xdqtRLn058hWoHhBxmX3v35JF6/3aMHYbhv0wqAQQ25juRYV6o5AAJ6voSyt+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=baidu.com; spf=pass smtp.mailfrom=baidu.com; arc=none smtp.client-ip=220.181.50.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=baidu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baidu.com From: lirongqing To: , , , , , CC: Li RongQing Subject: [PATCH] vfio/type1: fixed rollback in vfio_dma_bitmap_alloc_all() Date: Wed, 21 May 2025 11:46:47 +0800 Message-ID: <20250521034647.2877-1-lirongqing@baidu.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: BC-Mail-Ex15.internal.baidu.com (172.31.51.55) To BJHW-Mail-Ex15.internal.baidu.com (10.127.64.38) X-Baidu-BdMsfe-DateCheck: 1_BJHW-Mail-Ex15_2025-05-21 11:46:54:611 X-FEAS-Client-IP: 10.127.64.38 X-FE-Policy-ID: 52:10:53:SYSTEM Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Li RongQing The vfio dma bitmap of p should be freed, not n Fixes: d6a4c185660c ("vfio iommu: Implementation of ioctl for dirty pages t= racking") Signed-off-by: Li RongQing --- drivers/vfio/vfio_iommu_type1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type= 1.c index 0ac5607..ba5d91e 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -293,7 +293,7 @@ static int vfio_dma_bitmap_alloc_all(struct vfio_iommu = *iommu, size_t pgsize) struct rb_node *p; =20 for (p =3D rb_prev(n); p; p =3D rb_prev(p)) { - struct vfio_dma *dma =3D rb_entry(n, + struct vfio_dma *dma =3D rb_entry(p, struct vfio_dma, node); =20 vfio_dma_bitmap_free(dma); --=20 2.9.4