From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5723327E1AB; Tue, 20 May 2025 18:17:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765037; cv=none; b=jh0U1NOpeBHy5JPnwALBqwSiiKuE/klhNy+pKWHbRZOYHz9b53795I1YkpKM9JXEugx/H/UEY+ZMeeKvbWmZwCcm8J7kYEhlvmLpDQ24k5TPVzRu0gLrEzeYTrqPeLgaPgkrEAV8G76FjAvGYly8H9CJTUI/gLlWQdNGAoX8rIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765037; c=relaxed/simple; bh=RhWTWrmTfiwk6pJE65tbJb5g6Dca08aHeW4obh7IKQs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YLPLHJbMftOWivrIkxrqWcSqOCfzVhVLNjZ29LNe7zKjW3AZxL1iRE4f1nd/fpth05cNc2MzrwJRvck75jpKuXU2lsiFVWfBahpM2cUyOMdKiNTpkDQoisu96X1cz9+/XW6J/ZQ2ceUx41rzHM0KHmf1Xv5YQNvZmDbyJdmUCn4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fXchJYJZ; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fXchJYJZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765035; x=1779301035; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RhWTWrmTfiwk6pJE65tbJb5g6Dca08aHeW4obh7IKQs=; b=fXchJYJZA1FRDGDTNSKYy8Tg9is1VEy9iKfmzlBjBmj1Kwz3YM6a1ZeK Y3uC1HGWMcRKvh3udVXH6qdTgRvFtlK6USQxTI0n9IbdYjlSpciIdWSg8 SH0OVFd7FdjgHydiNbp2FQrwGNvyNd1xID24OGL0CNfPPhwx8KNZ2S2EO frX6d6R9iHDZ9jX8cwiiWg5C5y4WmN5eKN9yQ6b+ciyEGXnvT1m00I9fo p6jJkFOMhMwDGlEDhO8DIogXPV6+yCJar6GARnnsOlKCAws1GPjtWZiSC alQ4lQQCCAIQof0Cnav6hyJiKgikTEuTSFmSb1b1sNcUoKiJo0Z7Hj92N A==; X-CSE-ConnectionGUID: 0jJqY7erR8Kql1JUgPPD5g== X-CSE-MsgGUID: s5yhNLx3RIK69C8OL98yrA== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49847943" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49847943" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:12 -0700 X-CSE-ConnectionGUID: M3vc2tqnQTarATGdY60rSg== X-CSE-MsgGUID: zfPrytPLRJSWcnBeYCLA0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514704" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:12 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang Subject: [PATCH V4 01/16] perf: Fix the throttle logic for a group Date: Tue, 20 May 2025 11:16:29 -0700 Message-Id: <20250520181644.2673067-2-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The current throttle logic doesn't work well with a group, e.g., the following sampling-read case. $ perf record -e "{cycles,cycles}:S" ... $ perf report -D | grep THROTTLE | tail -2 THROTTLE events: 426 ( 9.0%) UNTHROTTLE events: 425 ( 9.0%) $ perf report -D | grep PERF_RECORD_SAMPLE -a4 | tail -n 5 0 1020120874009167 0x74970 [0x68]: PERF_RECORD_SAMPLE(IP, 0x1): ... sample_read: .... group nr 2 ..... id 0000000000000327, value 000000000cbb993a, lost 0 ..... id 0000000000000328, value 00000002211c26df, lost 0 The second cycles event has a much larger value than the first cycles event in the same group. The current throttle logic in the generic code only logs the THROTTLE event. It relies on the specific driver implementation to disable events. For all ARCHs, the implementation is similar. Only the event is disabled, rather than the group. The logic to disable the group should be generic for all ARCHs. Add the logic in the generic code. The following patch will remove the buggy driver-specific implementation. The throttle only happens when an event is overflowed. Stop the entire group when any event in the group triggers the throttle. The MAX_INTERRUPTS is set to all throttle events. The unthrottled could happen in 3 places. - event/group sched. All events in the group are scheduled one by one. All of them will be unthrottled eventually. Nothing needs to be changed. - The perf_adjust_freq_unthr_events for each tick. Needs to restart the group altogether. - The __perf_event_period(). The whole group needs to be restarted altogether as well. With the fix, $ sudo perf report -D | grep PERF_RECORD_SAMPLE -a4 | tail -n 5 0 3573470770332 0x12f5f8 [0x70]: PERF_RECORD_SAMPLE(IP, 0x2): ... sample_read: .... group nr 2 ..... id 0000000000000a28, value 00000004fd3dfd8f, lost 0 ..... id 0000000000000a29, value 00000004fd3dfd8f, lost 0 Suggested-by: Peter Zijlstra (Intel) Signed-off-by: Kan Liang Acked-by: Namhyung Kim Tested-by: Alexei Starovoitov --- kernel/events/core.c | 66 ++++++++++++++++++++++++++++++-------------- 1 file changed, 46 insertions(+), 20 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index af78ec118e8f..915698f47682 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -2739,6 +2739,39 @@ void perf_event_disable_inatomic(struct perf_event *= event) static void perf_log_throttle(struct perf_event *event, int enable); static void perf_log_itrace_start(struct perf_event *event); =20 +static void perf_event_unthrottle(struct perf_event *event, bool start) +{ + event->hw.interrupts =3D 0; + if (start) + event->pmu->start(event, 0); + perf_log_throttle(event, 1); +} + +static void perf_event_throttle(struct perf_event *event) +{ + event->pmu->stop(event, 0); + event->hw.interrupts =3D MAX_INTERRUPTS; + perf_log_throttle(event, 0); +} + +static void perf_event_unthrottle_group(struct perf_event *event, bool ski= p_start_event) +{ + struct perf_event *sibling, *leader =3D event->group_leader; + + perf_event_unthrottle(leader, skip_start_event ? leader !=3D event : true= ); + for_each_sibling_event(sibling, leader) + perf_event_unthrottle(sibling, skip_start_event ? sibling !=3D event : t= rue); +} + +static void perf_event_throttle_group(struct perf_event *event) +{ + struct perf_event *sibling, *leader =3D event->group_leader; + + perf_event_throttle(leader); + for_each_sibling_event(sibling, leader) + perf_event_throttle(sibling); +} + static int event_sched_in(struct perf_event *event, struct perf_event_context *ctx) { @@ -2767,10 +2800,8 @@ event_sched_in(struct perf_event *event, struct perf= _event_context *ctx) * ticks already, also for a heavily scheduling task there is little * guarantee it'll get a tick in a timely manner. */ - if (unlikely(event->hw.interrupts =3D=3D MAX_INTERRUPTS)) { - perf_log_throttle(event, 1); - event->hw.interrupts =3D 0; - } + if (unlikely(event->hw.interrupts =3D=3D MAX_INTERRUPTS)) + perf_event_unthrottle(event, false); =20 perf_pmu_disable(event->pmu); =20 @@ -4393,12 +4424,8 @@ static void perf_adjust_freq_unthr_events(struct lis= t_head *event_list) =20 hwc =3D &event->hw; =20 - if (hwc->interrupts =3D=3D MAX_INTERRUPTS) { - hwc->interrupts =3D 0; - perf_log_throttle(event, 1); - if (!is_event_in_freq_mode(event)) - event->pmu->start(event, 0); - } + if (hwc->interrupts =3D=3D MAX_INTERRUPTS) + perf_event_unthrottle_group(event, is_event_in_freq_mode(event)); =20 if (!is_event_in_freq_mode(event)) continue; @@ -6426,14 +6453,6 @@ static void __perf_event_period(struct perf_event *e= vent, active =3D (event->state =3D=3D PERF_EVENT_STATE_ACTIVE); if (active) { perf_pmu_disable(event->pmu); - /* - * We could be throttled; unthrottle now to avoid the tick - * trying to unthrottle while we already re-started the event. - */ - if (event->hw.interrupts =3D=3D MAX_INTERRUPTS) { - event->hw.interrupts =3D 0; - perf_log_throttle(event, 1); - } event->pmu->stop(event, PERF_EF_UPDATE); } =20 @@ -6441,6 +6460,14 @@ static void __perf_event_period(struct perf_event *e= vent, =20 if (active) { event->pmu->start(event, PERF_EF_RELOAD); + /* + * Once the period is force-reset, the event starts immediately. + * But the event/group could be throttled. Unthrottle the + * event/group now to avoid the next tick trying to unthrottle + * while we already re-started the event/group. + */ + if (event->hw.interrupts =3D=3D MAX_INTERRUPTS) + perf_event_unthrottle_group(event, true); perf_pmu_enable(event->pmu); } } @@ -10331,8 +10358,7 @@ __perf_event_account_interrupt(struct perf_event *e= vent, int throttle) if (unlikely(throttle && hwc->interrupts >=3D max_samples_per_tick)) { __this_cpu_inc(perf_throttled_count); tick_dep_set_cpu(smp_processor_id(), TICK_DEP_BIT_PERF_EVENTS); - hwc->interrupts =3D MAX_INTERRUPTS; - perf_log_throttle(event, 0); + perf_event_throttle_group(event); ret =3D 1; } =20 --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5729E27F16F; Tue, 20 May 2025 18:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765036; cv=none; b=UebOKJWYK6I6jHXNrbtCcKlwnJHJi6ZceyuAJb4o2exoaN4eGmy53u6QbkYl3qBntSWWpbR/r+lpS8aaa7b0uwC2Py4ncQNQNQyNubjXfLX+rb1/KfUniEd33YmS/xk9SxxUnsAFOcXUl5e6LexXEfSHM4j6m2jRVs9ohE/UPwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765036; c=relaxed/simple; bh=Ogh1PdF0JAlJWO/+lBOhxSFsXjnxR2nDdagy97sp5ig=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ux64e6NoS9Be322QVp/wktYcle9KUhN1zTcJ1qPR7OLgHgD6xKknobiWYa5iDHNwKeWk8u4ZMQ35OqRteC+96sid1QS+3WyVPzSmxFn9ho5PpEdnjX8t7vXdcm4Yq/KimK/cib2TualEoFOuIR+v2lflyPzeKEcxAcc/0kN5V0A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eMXTpW2s; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eMXTpW2s" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765035; x=1779301035; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ogh1PdF0JAlJWO/+lBOhxSFsXjnxR2nDdagy97sp5ig=; b=eMXTpW2sU8XJVDt4wtaI5YY/FFnAzQmmJMvzIxki48KEtj9MHR43XIIf /PrkbX8uyTHPY3gjoif8u8qGNBoPrylLEoPVLBb6wA3ru+je79HTWnUaw TtXMmIl8HT2LpRUokTtdUlFr8Yj3yfFmBBl28KOej18IE5Xc0leOcYIsw WT2caGqbYV4zzCa8cBdeVYWuiUzQ+G7QCF+bmyny617iKIU3jMP8GLZai 3nwcSi7ixTuEwI52zrYiHjHHmdcN/+Wf5HyD4UqrLGPln1oixBGqouH8c 2QATGfzze5SLDcIR4eVltyp30BtuPXL6HQII5cF3p/JJ6QLPdipiaRn8D w==; X-CSE-ConnectionGUID: kuELNmGWRzCLmU9LfIrezA== X-CSE-MsgGUID: fwr61FsvQty8dezjMxRHTw== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49847953" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49847953" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:12 -0700 X-CSE-ConnectionGUID: BnETvbfGR+aQlXw8/jHg9w== X-CSE-MsgGUID: 0v6oyintSmi29JxEe0p8ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514705" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:12 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang Subject: [PATCH V4 02/16] perf: Only dump the throttle log for the leader Date: Tue, 20 May 2025 11:16:30 -0700 Message-Id: <20250520181644.2673067-3-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The PERF_RECORD_THROTTLE records are dumped for all throttled events. It's not necessary for group events, which are throttled altogether. Optimize it by only dump the throttle log for the leader. The sample right after the THROTTLE record must be generated by the actual target event. It is good enough for the perf tool to locate the actual target event. Suggested-by: Namhyung Kim Signed-off-by: Kan Liang Acked-by: Namhyung Kim --- kernel/events/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 915698f47682..cd559501cfbd 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -2744,14 +2744,16 @@ static void perf_event_unthrottle(struct perf_event= *event, bool start) event->hw.interrupts =3D 0; if (start) event->pmu->start(event, 0); - perf_log_throttle(event, 1); + if (event =3D=3D event->group_leader) + perf_log_throttle(event, 1); } =20 static void perf_event_throttle(struct perf_event *event) { event->pmu->stop(event, 0); event->hw.interrupts =3D MAX_INTERRUPTS; - perf_log_throttle(event, 0); + if (event =3D=3D event->group_leader) + perf_log_throttle(event, 0); } =20 static void perf_event_unthrottle_group(struct perf_event *event, bool ski= p_start_event) --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 247BA2798FA; Tue, 20 May 2025 18:17:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765036; cv=none; b=nqglr7etXHDNqbKlxuqgEV5LH4iZOTIa503/jbDJOES26l8MhCJ4TOVOD3Y3pCGv9E0dqFGVeitu3kVkjO1HxDcNUK534bYpo3TAeHXw6+FX2LxBrp53lMqD4hDFYBO01YD9vTazswUeM0JjziBam4itMeAMYGgTR9LyWfwsrMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765036; c=relaxed/simple; bh=25j5vFEsBU7YPCN2sAyzRM/ZIyTaWwct8v5PeU7SHZk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jup33YD8nTH73yH7cFgJWCWtZIxztXOTg13jhhepfojePGjXqNGMS12riPAFSJeGbLYbKl6GLftR7squRD+3na513QeGZQpjXNeUabAAWM9VjKDsEpZhTx/Hc1QDlKREpXzeJFZ6j5K04vzR0qXgKiSsTmaiHm3nfYq36Ry5Cyg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OPjGmPbp; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OPjGmPbp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765035; x=1779301035; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=25j5vFEsBU7YPCN2sAyzRM/ZIyTaWwct8v5PeU7SHZk=; b=OPjGmPbpqdhURMSR6TCJ3ScM2GNijGujKI3T9/pZ6vtQQVRZ664Sipu6 c80P/Vf2WzxYUrfdPXpTa7OiZLcwVHGotb3F9qENXx/BuZiq8iQVPv5XM x0iPESPTv4TR0y5Mkjvfq/VprovF7TbXnYSv9cQzSqYx4hitWFDpp8vuf RdYauMLLxpXmEVUS7DG3dvLcWDe6u/alkYL+2oyTHJnJ5d3P0W3z0CZNP g5jrWERwb6qJCeADXPqKeFEucDT4izu/+TMU5COfkWSrhcWwlGcFUYn9o L5E/ytrU8p4ewM5G+QvrB21DunLia2yVzBpvgvs2OsFe1b0mlOWwBVpPt Q==; X-CSE-ConnectionGUID: HzxgwxW1R8+KMyXFQMQN8Q== X-CSE-MsgGUID: p44wuas0S8CmcLBmUcrVuQ== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49847961" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49847961" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:13 -0700 X-CSE-ConnectionGUID: LFIbr82xTlaH6zyIPqrotw== X-CSE-MsgGUID: XOFD5mFLTOe38gHhmlOvxw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514706" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:12 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang Subject: [PATCH V4 03/16] perf/x86/intel: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:31 -0700 Message-Id: <20250520181644.2673067-4-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang --- arch/x86/events/core.c | 3 +-- arch/x86/events/intel/core.c | 6 ++---- arch/x86/events/intel/ds.c | 7 +++---- arch/x86/events/intel/knc.c | 3 +-- arch/x86/events/intel/p4.c | 3 +-- 5 files changed, 8 insertions(+), 14 deletions(-) diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c index 186e31cd0c14..8a2f73333a50 100644 --- a/arch/x86/events/core.c +++ b/arch/x86/events/core.c @@ -1730,8 +1730,7 @@ int x86_pmu_handle_irq(struct pt_regs *regs) =20 perf_sample_save_brstack(&data, event, &cpuc->lbr_stack, NULL); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 if (handled) diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c index b7562d66c6ea..a8309a67693e 100644 --- a/arch/x86/events/intel/core.c +++ b/arch/x86/events/intel/core.c @@ -3138,8 +3138,7 @@ static void x86_pmu_handle_guest_pebs(struct pt_regs = *regs, continue; =20 perf_sample_data_init(data, 0, event->hw.last_period); - if (perf_event_overflow(event, data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, data, regs); =20 /* Inject one fake event is enough. */ break; @@ -3282,8 +3281,7 @@ static int handle_pmi_common(struct pt_regs *regs, u6= 4 status) if (has_branch_stack(event)) intel_pmu_lbr_save_brstack(&data, cpuc, event); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 return handled; diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c index 58c054fa56b5..f8610f7196f0 100644 --- a/arch/x86/events/intel/ds.c +++ b/arch/x86/events/intel/ds.c @@ -2368,8 +2368,7 @@ __intel_pmu_pebs_last_event(struct perf_event *event, * All but the last records are processed. * The last one is left to be able to call the overflow handler. */ - if (perf_event_overflow(event, data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, data, regs); } =20 if (hwc->flags & PERF_X86_EVENT_AUTO_RELOAD) { @@ -2597,8 +2596,8 @@ static void intel_pmu_drain_pebs_nhm(struct pt_regs *= iregs, struct perf_sample_d if (error[bit]) { perf_log_lost_samples(event, error[bit]); =20 - if (iregs && perf_event_account_interrupt(event)) - x86_pmu_stop(event, 0); + if (iregs) + perf_event_account_interrupt(event); } =20 if (counts[bit]) { diff --git a/arch/x86/events/intel/knc.c b/arch/x86/events/intel/knc.c index 3e8ec049b46d..384589168c1a 100644 --- a/arch/x86/events/intel/knc.c +++ b/arch/x86/events/intel/knc.c @@ -254,8 +254,7 @@ static int knc_pmu_handle_irq(struct pt_regs *regs) =20 perf_sample_data_init(&data, 0, last_period); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/arch/x86/events/intel/p4.c b/arch/x86/events/intel/p4.c index c85a9fc44355..126d5ae264cb 100644 --- a/arch/x86/events/intel/p4.c +++ b/arch/x86/events/intel/p4.c @@ -1072,8 +1072,7 @@ static int p4_pmu_handle_irq(struct pt_regs *regs) continue; =20 =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 if (handled) --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E934528003E; Tue, 20 May 2025 18:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765038; cv=none; b=LG8x1wvwLQ0aG1rmnv02ugPNeNrMuLYjbJTp0l8fWYfsN7cymMPjmU2lrbq1SO1IZ6AnKgDH1T0V1wymoUwmEOuii57MFFKX9yiC+GntfB/iFB2kN6Oe4YCJjmspwJOTHctQ7YA1iYU5UIbpBfUVhOrcPWAWAvWFa12bDkl400k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765038; c=relaxed/simple; bh=mmZ9nbgB5fwwHNOO/FW7dHFDnAhM6aTO/E4japeEfI4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Yt3PjVK9e9CxDnHze2gh4LdePGqbZPKMwn4bJ76MHhHxAo8j60j+tU7ad3M1Va0gU6LRk3PMKsMyKavqmeO/dha+9p8RZ8ePko0HqREuSnDqW2U+BWB0fN0mlFxh/OueRbatTG6tXuLAlPe2RUQv8qTMXIyeZDS4GaWfCjR6u1A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dLtymv18; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dLtymv18" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765037; x=1779301037; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mmZ9nbgB5fwwHNOO/FW7dHFDnAhM6aTO/E4japeEfI4=; b=dLtymv18BqxJ4R9+h1VXcb3EWPTnzJtpFwT3RFFvGJBlwuYpVPeyawQ0 Uw+OTyeDcyqQs0lQU8xOdmAvVxqYd6V3wcsWV3CUw5MZnj0NvsevwKDHI pZQ6ZCa4iPOP/qaYV2Q3OfCvSjxskMEoLlZzdfvz2RBD9fk1FRN3FlzIP bSFRDgzviaHsfxQG0pUK5A7CN5t9yeoQgFowRpTWXwWhMjChKHlTUq0rU xyqZLghl8H2LkNZ9zBv45ib59ZYPi/7oX/gX3xYOfOrliAkbCu0cfeH7S hBFmgUPfc+5IXS63tmcPUnrHha+Wgs/irf3YPNZ+ISfNyUATPWKmPAHfb w==; X-CSE-ConnectionGUID: ZGM9q/0XRW6xsqTR7V/sPQ== X-CSE-MsgGUID: YYH6FZlESUq3YMi1FIzU4g== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49847970" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49847970" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:13 -0700 X-CSE-ConnectionGUID: bbBrjheYTJOJj2VjtmhjiA== X-CSE-MsgGUID: YFkfR31YStOTiwISYwwrQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514707" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:12 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , Ravi Bangoria , Sandipan Das Subject: [PATCH V4 04/16] perf/x86/amd: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:32 -0700 Message-Id: <20250520181644.2673067-5-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Reviewed-by: Ravi Bangoria Signed-off-by: Kan Liang Cc: Sandipan Das Cc: Ravi Bangoria --- arch/x86/events/amd/core.c | 3 +-- arch/x86/events/amd/ibs.c | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c index 30d6ceb4c8ad..5e64283b9bf2 100644 --- a/arch/x86/events/amd/core.c +++ b/arch/x86/events/amd/core.c @@ -1003,8 +1003,7 @@ static int amd_pmu_v2_handle_irq(struct pt_regs *regs) =20 perf_sample_save_brstack(&data, event, &cpuc->lbr_stack, NULL); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index 0252b7ea8bca..4bbbca02aeb1 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -1373,9 +1373,7 @@ static int perf_ibs_handle_irq(struct perf_ibs *perf_= ibs, struct pt_regs *iregs) hwc->sample_period =3D perf_ibs->min_period; =20 out: - if (throttle) { - perf_ibs_stop(event, 0); - } else { + if (!throttle) { if (perf_ibs =3D=3D &perf_ibs_op) { if (ibs_caps & IBS_CAPS_OPCNTEXT) { new_config =3D period & IBS_OP_MAX_CNT_EXT_MASK; --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D9CD280321; Tue, 20 May 2025 18:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765039; cv=none; b=pmGawKMzdSet4uAVFZ/uh6ufKbgpCJzbjF520Ot7hvvjG4/SXHjW8nGM5sqj1qkokslgYwQAsvv+cVOtlJbO19knmgg3SFIds2iB06B1Vi14cYYd8G8YLMgIXKQBeItlZYe59stKUbK+x0ydk/oPWTm2dwAISKccEDjp3Uuw9os= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765039; c=relaxed/simple; bh=eftPXZUtS7TWj+fyRnjgJB01av2QQsqnM0j4qbjXMQk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WVn8MrfVD5NdrBYelNQLqkmYw0hiF9vgoVp4c8xbctW9F76P0oGo4Negk5oNHGKn/u+NM9+Q+61m7Uwu6d0NBbI5ejNRTwc0hYB7JytTVJ2I60xPJeK7LGisC9jgYZGboOs7cSZmlsJRGqIR/vfVVVo9FMm4CnO/MsWVnkc7IAE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dcwPwv3F; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dcwPwv3F" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765037; x=1779301037; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eftPXZUtS7TWj+fyRnjgJB01av2QQsqnM0j4qbjXMQk=; b=dcwPwv3FTyrsvlfRDu22nR37+QFAl0LHfKE0+Pp/cqE7Zn6F/2lQdELW BfnqKvANvFVE7OPHXGCNADWLPkaYYQBtnY1mKKf1X41O6KpPcxsrfdfg/ gv14+WRcqYnx+N/LzUV2P+ddkk6WMGxfRCxqjMP8xT9NfqoJZCfDVtL+b DJgQZ8Ta01nOKkRAz9RY/JIcAXOh/UL0WttrIaToVoiaYyC6LBqT3yQHK hNBoUKYNROTOsF11wE2PP0cLX6aJamNC7YbD9DydqcXgUNN82C0yMi/oj 61ezFK0E2BRXdbOlKkGRQ2bEzTaCfGnb46xU2iuU8fuC/1+IvxXz47xin Q==; X-CSE-ConnectionGUID: u5b/bcGxTi2bTUHhjRZTMA== X-CSE-MsgGUID: NWiLMpAhTM61Wd+jpdVRVg== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49847979" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49847979" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:13 -0700 X-CSE-ConnectionGUID: 0XHfJ6W6QsKLF5JG49WOEA== X-CSE-MsgGUID: f1vZVfHxS2GsiJjfNH3gKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514709" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:12 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , silviazhao , CodyYao-oc Subject: [PATCH V4 05/16] perf/x86/zhaoxin: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:33 -0700 Message-Id: <20250520181644.2673067-6-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: silviazhao Cc: CodyYao-oc --- arch/x86/events/zhaoxin/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/events/zhaoxin/core.c b/arch/x86/events/zhaoxin/core.c index 2fd9b0cf9a5e..49a5944fac63 100644 --- a/arch/x86/events/zhaoxin/core.c +++ b/arch/x86/events/zhaoxin/core.c @@ -397,8 +397,7 @@ static int zhaoxin_pmu_handle_irq(struct pt_regs *regs) if (!x86_perf_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 /* --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 381F3280A2F; Tue, 20 May 2025 18:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765038; cv=none; b=sj9DgrpbRzrLX8GX5QhVWnPHDzDKjkdtHfXHhzbeq4MmF6YmNV15DG5RjkhsvQfXNa8ARV8yktuKUjB1h/ZD+pGPbomfV0fe1JvUUxuMxyCYx4gprtoOlNEQkJNj5W6sLtahTj+aHiNhfFZ6gihs9e2XF3OqF0zLQqm+X6c8wZk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765038; c=relaxed/simple; bh=s+EyXjLUXo0M2dfj157AL5fvrY36sWvSBJ2tuImTWtk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ORTGwKDnHq3EVr1tBz/QBSrC7FwsKxCwPIwguZkVK82DXgU0Xvx5PXH2gVShtfjelK4xD/C04jcG5GmOPciYDyR9bRm19jiVeQCwIyxhzQy37kzyuO8PcHFWHaZegHh6eh6olV2BD29GiXHZgwzSPWdhxEQCQVbKPF1du8ou4F8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MwxZKh8d; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MwxZKh8d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765037; x=1779301037; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=s+EyXjLUXo0M2dfj157AL5fvrY36sWvSBJ2tuImTWtk=; b=MwxZKh8d3G7ErN+6/M3E3jiGw7sPfqh3yFadzyT3Cmnod98cL/Y5UJOu Bv0FCEwqWSEVg2AJWHjD5ruPuV2tvreNSScZ7E9OlpBUl1PmEWxg3EEza n8bSvZGdfJbD3OZ4BZfS/vFHL/ng0sLnn/Gz0/uE2t+bb59zsGphh86OQ bTN4F1JxnO6ks/eIRIQU4H0FSfxd8xmQYwM79trOKuHNyUrTYwnyW2wLL MsrBTb6sIVHdXiiZpQWmWs0YG+gBPhy0CfgtVWCrl4wWJ6imrokrkM8U8 ZIUfqQ2xMNrCHHSniNxpuQtl3a2326eu4S0ewZKueMPBKpaQOYVjkKTqy Q==; X-CSE-ConnectionGUID: u3yNZ/BERO2/BbHSm+uYRA== X-CSE-MsgGUID: NSPj8zWLTTOEK/S7qSWKqw== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49847988" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49847988" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:13 -0700 X-CSE-ConnectionGUID: tt0fVSeZQYu+1VmXOJztCQ== X-CSE-MsgGUID: DwqYvJaXTXKgUclat/S2VQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514710" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:12 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , Athira Rajeev , Madhavan Srinivasan , linuxppc-dev@lists.ozlabs.org Subject: [PATCH V4 06/16] powerpc/perf: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:34 -0700 Message-Id: <20250520181644.2673067-7-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Athira Rajeev Cc: Madhavan Srinivasan Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/perf/core-book3s.c | 6 ++---- arch/powerpc/perf/core-fsl-emb.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3= s.c index 42ff4d167acc..8b0081441f85 100644 --- a/arch/powerpc/perf/core-book3s.c +++ b/arch/powerpc/perf/core-book3s.c @@ -2344,12 +2344,10 @@ static void record_and_restart(struct perf_event *e= vent, unsigned long val, ppmu->get_mem_weight(&data.weight.full, event->attr.sample_type); data.sample_flags |=3D PERF_SAMPLE_WEIGHT_TYPE; } - if (perf_event_overflow(event, &data, regs)) - power_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } else if (period) { /* Account for interrupt in case of invalid SIAR */ - if (perf_event_account_interrupt(event)) - power_pmu_stop(event, 0); + perf_event_account_interrupt(event); } } =20 diff --git a/arch/powerpc/perf/core-fsl-emb.c b/arch/powerpc/perf/core-fsl-= emb.c index d2ffcc7021c5..7120ab20cbfe 100644 --- a/arch/powerpc/perf/core-fsl-emb.c +++ b/arch/powerpc/perf/core-fsl-emb.c @@ -635,8 +635,7 @@ static void record_and_restart(struct perf_event *event= , unsigned long val, =20 perf_sample_data_init(&data, 0, last_period); =20 - if (perf_event_overflow(event, &data, regs)) - fsl_emb_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } } =20 --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3B35281538; Tue, 20 May 2025 18:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765040; cv=none; b=gmAeJ9ifM/uEF8r/E/yPK/u1z/2Qnhb8qFunTDIgcgKWZ8EHucjQLXLsrSwNzo5dOyBQDAn8xY41CVelrc8RM7efqa00tvmEOiEQ7YTDoYMRrtGtNSr7WV9eqRXV9ZDXJdaQHSJZafBGdHgRkgY1P9Yo3Pim94CUYWc9nobF+m4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765040; c=relaxed/simple; bh=JYonQVJrRjxKJDpe7nXWSwniUE7wi5IkJhEj5Hcl77E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZGSP4PH97TyPuCiIsyeasYCG6hYVT433b5xShuLrWYgFRL86AIosMPcqP8aZYWRGfnbpAliSDSI8pxYF/z7IOYHzsIpUkTet/wbNDV1OBtEUfISOWkr7pULjvkFFSyS7YSgdO5oLLT7fGag7LgeYFtjRZc+Gsyvg7dR9p9Xu9us= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=c5Fpuxck; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="c5Fpuxck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765039; x=1779301039; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JYonQVJrRjxKJDpe7nXWSwniUE7wi5IkJhEj5Hcl77E=; b=c5Fpuxckm9qxt4ljKobP0rWto+JGH4dC5N/2NVC/7ZhFAsmr/bX0vpDI sNK56JIrfg5w/9PQjYmb+4AS4RRi+apuoT6TogayEIvfv1OCmhCbwrMXg Vq8I3ut72nBDbo9/nclOK9uCyLFI4DbDuOl9Ta0wMCNqvANALxlAE6LWN xvbHKa3GMRGu7zKrsjgLWuG+v4GCn1cMWneUm+kLYd3080Et+4jX1sZzT A/tPe5ieTj4Lp4m2PRYDdnqByYfpqn9XZsnCJD1DPX5hnAqTc4IJ6LqX0 DBwLSyLNcW+niJtgBEG6BEV3tunf+PzWn1/LWXVTWU0mee956iDna9TtR A==; X-CSE-ConnectionGUID: 5ecEAgWFRum45LOX8CNUbA== X-CSE-MsgGUID: VMr36PTHT56CQCALSnXD1g== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49847993" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49847993" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:13 -0700 X-CSE-ConnectionGUID: z2iBAAvTQQ6sHMnRBlwfbg== X-CSE-MsgGUID: +jvUbKMnRLGCJOj+xpoImg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514712" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:13 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , linux-s390@vger.kernel.org Subject: [PATCH V4 07/16] s390/perf: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:35 -0700 Message-Id: <20250520181644.2673067-8-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Tested-by: Thomas Richter Signed-off-by: Kan Liang Cc: Thomas Richter Cc: linux-s390@vger.kernel.org Tested-by: Sumanth Korikkar --- arch/s390/kernel/perf_cpum_cf.c | 2 -- arch/s390/kernel/perf_cpum_sf.c | 5 +---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/s390/kernel/perf_cpum_cf.c b/arch/s390/kernel/perf_cpum_c= f.c index e657fad7e376..6a262e198e35 100644 --- a/arch/s390/kernel/perf_cpum_cf.c +++ b/arch/s390/kernel/perf_cpum_cf.c @@ -980,8 +980,6 @@ static int cfdiag_push_sample(struct perf_event *event, } =20 overflow =3D perf_event_overflow(event, &data, ®s); - if (overflow) - event->pmu->stop(event, 0); =20 perf_event_update_userpage(event); return overflow; diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_s= f.c index ad22799d8a7d..91469401f2c9 100644 --- a/arch/s390/kernel/perf_cpum_sf.c +++ b/arch/s390/kernel/perf_cpum_sf.c @@ -1072,10 +1072,7 @@ static int perf_push_sample(struct perf_event *event, overflow =3D 0; if (perf_event_exclude(event, ®s, sde_regs)) goto out; - if (perf_event_overflow(event, &data, ®s)) { - overflow =3D 1; - event->pmu->stop(event, 0); - } + overflow =3D perf_event_overflow(event, &data, ®s); perf_event_update_userpage(event); out: return overflow; --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1687B2820CC; Tue, 20 May 2025 18:17:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765040; cv=none; b=PdFthlu3m5O6u5sIXpvRvdcP9L/6GMk3F0bfjWECVOlcf/tjCOmwQOvEljLDF+kPsfU+QEbzfXpHLOv1uAjpWE7tnBcy0uDjnvALMbhB90q77r8QGCwWBTrNuseiTQTb0eIujayl8K5vSUDLqKZ6PAS733KCC7c3S1A7OS1Xvts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765040; c=relaxed/simple; bh=h551J25h8XFy68PU1OOtFou2mqDGDS+8kG2qd49H3XQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JvMlZLDeTPlZNz8V/FhM4qL+asn+krL7Won7TznWKRDMpXWTVcQ4l+MNzykrwLxnN/AGSLcEZZ1sKBz/IWQtG+cbiQfCYZnn5CkQE3we0A0oB7Bjqimw5jyHYJbYBU7YGZVXWLn4TVwml4LsZmEqbm/4R7ROhLYt4ciMZA+H/Tc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=D25Xv37e; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D25Xv37e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765039; x=1779301039; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=h551J25h8XFy68PU1OOtFou2mqDGDS+8kG2qd49H3XQ=; b=D25Xv37e5kUsF1oLte5lazkzas7WYR3PimDRC22Xw/7cMVQ5dYxj2qew Z7D/vREuQwMZs0rqQuQQP9V+J1hpU+5vSSvhTyHOA1Zx7ioRm/dfsqNMV aHAVEBPPNF2Ao7r4TBVc1n+v46RopISCntYnmwW9CAxzBU3RjF1JoJUM6 swWPC2dHhuac6mia160y1c95JOJbd/bFh8nOLPrYCphNloj6al28gn615 yh3AKeslIaG1YrEvPIuKb/l5Mx4d3p2kj48kYv2Pzbb9VYgDd2CJvA3aV PJ464e7slOIRF5UHYQt9RWnV0/9Zs+jG11cTbog1laDN5HF/o6YZbzRzC A==; X-CSE-ConnectionGUID: 3e+qtiHvQNiSth1zJWTEJQ== X-CSE-MsgGUID: n0meFTSIT7OsKtECc7pcXw== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49848003" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49848003" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:13 -0700 X-CSE-ConnectionGUID: 55eNsgydRpqO2EHr3QlfWw== X-CSE-MsgGUID: lNNNpJUhTU2cdjOXb2jVXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514714" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:13 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , Rob Herring , Vincenzo Frascino , Will Deacon Subject: [PATCH V4 08/16] perf/arm: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:36 -0700 Message-Id: <20250520181644.2673067-9-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Tested-by: Leo Yan Signed-off-by: Kan Liang Cc: Mark Rutland Cc: Rob Herring (Arm) Cc: Vincenzo Frascino Cc: Will Deacon Cc: Leo Yan --- drivers/perf/arm_pmuv3.c | 3 +-- drivers/perf/arm_v6_pmu.c | 3 +-- drivers/perf/arm_v7_pmu.c | 3 +-- drivers/perf/arm_xscale_pmu.c | 6 ++---- 4 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c index e506d59654e7..3db9f4ed17e8 100644 --- a/drivers/perf/arm_pmuv3.c +++ b/drivers/perf/arm_pmuv3.c @@ -887,8 +887,7 @@ static irqreturn_t armv8pmu_handle_irq(struct arm_pmu *= cpu_pmu) * an irq_work which will be taken care of in the handling of * IPI_IRQ_WORK. */ - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } armv8pmu_start(cpu_pmu); =20 diff --git a/drivers/perf/arm_v6_pmu.c b/drivers/perf/arm_v6_pmu.c index b09615bb2bb2..7cb12c8e06c7 100644 --- a/drivers/perf/arm_v6_pmu.c +++ b/drivers/perf/arm_v6_pmu.c @@ -276,8 +276,7 @@ armv6pmu_handle_irq(struct arm_pmu *cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/drivers/perf/arm_v7_pmu.c b/drivers/perf/arm_v7_pmu.c index 17831e1920bd..a1e438101114 100644 --- a/drivers/perf/arm_v7_pmu.c +++ b/drivers/perf/arm_v7_pmu.c @@ -930,8 +930,7 @@ static irqreturn_t armv7pmu_handle_irq(struct arm_pmu *= cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/drivers/perf/arm_xscale_pmu.c b/drivers/perf/arm_xscale_pmu.c index 638fea9b1263..c2ac41dd9e19 100644 --- a/drivers/perf/arm_xscale_pmu.c +++ b/drivers/perf/arm_xscale_pmu.c @@ -186,8 +186,7 @@ xscale1pmu_handle_irq(struct arm_pmu *cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 irq_work_run(); @@ -519,8 +518,7 @@ xscale2pmu_handle_irq(struct arm_pmu *cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 irq_work_run(); --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F076283124; Tue, 20 May 2025 18:17:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765040; cv=none; b=Yl6WSXf+ZAbSaVYpkEnWU5QdTZM76bolKfW+TW8x/yqj6HpM8INWazYiANTpNnPb2gMUZEj/iDosY+Ou6jd/ps+5Vw8hcOMsA63jcImViw73EHjHmG56zDMVdqm19K05WYmwLmahIR+IzJ8f7QsMThzpzFbSwDqks+T3wy5QRuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765040; c=relaxed/simple; bh=jtzi1Dswis+7E8s5xuD4Q5RcegCZpv4/8lL3qUWjHa0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Mr8etga+NxzjL1pCnkXau5MRihF5jnjbKVPWiTPQxtvnxOkNh1VojV9SDHMPz3DuOeBR+eXhprlyOTJ6nqeEu8JFmQVj7V4Jg4XrBpWO+AKs25qWGmLr6y6JfNIPGDi8qnA56L/dc35EkAm95yCbx/0V66+JsJNnBJfXl1CxOWE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Gcrn8Ma4; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Gcrn8Ma4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765039; x=1779301039; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jtzi1Dswis+7E8s5xuD4Q5RcegCZpv4/8lL3qUWjHa0=; b=Gcrn8Ma4Lj0uzGudalyTqui7vFZh3+b66EU3MmoD4Lswh/huyo7G8z0p +CDh4YEaQ+eZUvVDqm7K1fWPlzJWbKYqXotI3hfeQDgJEB4fD+qRi/ES1 Jh6dvUSXLjR+yuUAyORMBAprvVppOGYpzqJTbeEp1qBJOjtFVUejiGR5z AREwokxmHKUk7Shff60jZfnrBmGJY1q8FqHjgMlsM4lLj0TSvf2UbAkYd 9L58ehxLvljxyESPxR9DV0c2ZOjcgQufx4OSrJdsdMOiWFadngSGh0WUM 2YdhJzSGhwKspH3XzLwRAeJLsJ92izFXcUgkMCvdyZoWMz7FKscxnAKP/ w==; X-CSE-ConnectionGUID: QICnwZHqSwOn3TFi1M+tKQ== X-CSE-MsgGUID: vAyPyvxxQYWvZMQfMQhYlA== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49848009" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49848009" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:13 -0700 X-CSE-ConnectionGUID: aR+nO4m0SN6lMNNDd2P2pA== X-CSE-MsgGUID: mT7kCPenRDGwkx/f5mixUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514715" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:13 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , Oliver Upton Subject: [PATCH V4 09/16] perf/apple_m1: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:37 -0700 Message-Id: <20250520181644.2673067-10-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Oliver Upton --- drivers/perf/apple_m1_cpu_pmu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/perf/apple_m1_cpu_pmu.c b/drivers/perf/apple_m1_cpu_pm= u.c index df9a28ba69dc..81b6f1a62349 100644 --- a/drivers/perf/apple_m1_cpu_pmu.c +++ b/drivers/perf/apple_m1_cpu_pmu.c @@ -474,8 +474,7 @@ static irqreturn_t m1_pmu_handle_irq(struct arm_pmu *cp= u_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - m1_pmu_disable_event(event); + perf_event_overflow(event, &data, regs); } =20 cpu_pmu->start(cpu_pmu); --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C80928466B; Tue, 20 May 2025 18:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765042; cv=none; b=J4u1l8dMEqWDOTexQcEF90cIMMonp2XcENBJW0zoXvubpcs8qj/YZw9ZHitJW8tsZXtF4fTWe1nzUO8lccmAbQIY/7M8KGEbdagbmYT0lDRUMEpMGDgdGc43NHySrm9iL5+gthelGuweX9rwQaf+1IE+QopfA0w76cQSDjbG9/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765042; c=relaxed/simple; bh=NhpvDIFF3RCGCMgFlua6GwCE5WabCIdXhqFSclRzhlI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=V5Bkz32A25pHQimOgooQcyqLAiquUfiGedcaazEFOB1XY+ylDpdwQvhgBy1Tx5wBOM8loAqkv5rSYGAfF9d/b2A+lIWrXEPl9FkhXlqkFND5H8qG10WNtPcw/QEW2woW/aKf1E4V2Xvy0F/fqROwzzTEPYGyjmBqjY7kjWrz9h4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=N32/zIx/; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="N32/zIx/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765041; x=1779301041; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NhpvDIFF3RCGCMgFlua6GwCE5WabCIdXhqFSclRzhlI=; b=N32/zIx/CAE9z1ENwja9kgXEDfxUlAYWfmdFizS3GvDih2Bi2KCcb/F7 414AgZk1Dl/Yalcs9g8sgypHjaJdtt68EaPlMiHTeRj74C6+RivkVk3+R l82g5e6pod6J+/A1AdTkAkExzmiaGQ2ClvNoXw5gZKuyV8fteTXVwy5vQ ngKGdZFg0NUyVi2BjPoSpUyVcCPBrsjOir1q+WJiUAaJW+QP3w6nMpi9v +/lRVu6MSlgghyA8yg8bL0uVwP0E6DjrXaTrV4PYvDsRaTUCzjz+p4u7l mZni0KFVlW5M8Dg64ZnjRbAAiX1UsVKwf3zDfpCQbGA7+9av5QOYShHFl w==; X-CSE-ConnectionGUID: 240JnDbiTKux5NQAjwHgnQ== X-CSE-MsgGUID: kXwvUSl3Q62BcDNaUxnl7A== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49848018" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49848018" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:14 -0700 X-CSE-ConnectionGUID: MWQgPnHHT9GHVVXzrxai1A== X-CSE-MsgGUID: eUInIzdbQdqyPrIvWSagIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514718" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:13 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , linux-alpha@vger.kernel.org Subject: [PATCH V4 10/16] alpha/perf: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:38 -0700 Message-Id: <20250520181644.2673067-11-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: linux-alpha@vger.kernel.org --- arch/alpha/kernel/perf_event.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/alpha/kernel/perf_event.c b/arch/alpha/kernel/perf_event.c index 1f0eb4f25c0f..a3eaab094ece 100644 --- a/arch/alpha/kernel/perf_event.c +++ b/arch/alpha/kernel/perf_event.c @@ -852,14 +852,9 @@ static void alpha_perf_event_irq_handler(unsigned long= la_ptr, alpha_perf_event_update(event, hwc, idx, alpha_pmu->pmc_max_period[idx]+1= ); perf_sample_data_init(&data, 0, hwc->last_period); =20 - if (alpha_perf_event_set_period(event, hwc, idx)) { - if (perf_event_overflow(event, &data, regs)) { - /* Interrupts coming too quickly; "throttle" the - * counter, i.e., disable it for a little while. - */ - alpha_pmu_stop(event, 0); - } - } + if (alpha_perf_event_set_period(event, hwc, idx)) + perf_event_overflow(event, &data, regs); + wrperfmon(PERFMON_CMD_ENABLE, cpuc->idx_mask); =20 return; --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E91C32853FC; Tue, 20 May 2025 18:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765042; cv=none; b=bouIAQdTl5655/rLh6KIxWE6sAuS/HocQ9effgQMoJ2DeJIsq9GQa5iw/IGgIVEKiGltoTj9UBuL2KzvqNJOfJgbdFAo8wYl0fi+A4ivqX9ycb5fFptWYibLQOth1ivgCxexae+vO9p5xdxShivmMF96F1NLYD4weH9KbiQi9io= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765042; c=relaxed/simple; bh=s3ZgcZ6BKTnLp+A1PAb6rpm8YoZDgBt/nxZwAaxXJ7E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PoHVItpZv0WaKdJX+5BSOXGlxAFAtj/PbTKRzoAnONAPNW12TLWNq1fCoPLafadvqL3CbHOPYxKzDynP0xJkzXLP3cjUJOvFdN7ZDIJrPRGkkpheSk/f02twXQsgxBom2FJvPBnC5Z/fJ2FF6pgsYHvoc7gVORe/i6h245Kvknc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=U4bEg5AQ; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="U4bEg5AQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765041; x=1779301041; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=s3ZgcZ6BKTnLp+A1PAb6rpm8YoZDgBt/nxZwAaxXJ7E=; b=U4bEg5AQgSU2XGBQ6e6JLyRbzM2S4A6nBX8c0g+3ru39H2LSNncu+sEl JzhkoG61GypAFiQsSLcpRWJd2kZTym5Wj6zqWYCpeymkFp98ufO27Agvh VblHSr9AdnZjMWMEi7BrO9lZvIYjSyHMN5huTPQEzNEtJ1CBgzW1J130m oYnAja/am+5KHokMHONryulUFRWyIm84GKV0K6TGIKQ3Fp92Uy1MEswwa kdjHoRrA3CjDM9LniBxVfcY48yocq7uyMQYeEpI+IcVd0FomfVJU0ZobR +nxgFMDP4TjAqA0S9ehvABvqn9poo5Ci6Xz7K1C52P9rb9kXURWiz+YvC w==; X-CSE-ConnectionGUID: MTXTFa7GQaSaGjWiEKMrhA== X-CSE-MsgGUID: jIVcGFOPQ1WU/ZQBh3unFg== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49848024" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49848024" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:14 -0700 X-CSE-ConnectionGUID: zgxjsAdARFahbTEB79tOeA== X-CSE-MsgGUID: uyVaAjEwQi6E30TJqOU05A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514719" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:13 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , Vineet Gupta , Vineet Gupta , linux-snps-arc@lists.infradead.org Subject: [PATCH V4 11/16] arc/perf: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:39 -0700 Message-Id: <20250520181644.2673067-12-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Acked-by: Vineet Gupta Signed-off-by: Kan Liang Cc: Vineet Gupta Cc: linux-snps-arc@lists.infradead.org --- arch/arc/kernel/perf_event.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c index 6e5a651cd75c..ed6d4f0cd621 100644 --- a/arch/arc/kernel/perf_event.c +++ b/arch/arc/kernel/perf_event.c @@ -599,10 +599,8 @@ static irqreturn_t arc_pmu_intr(int irq, void *dev) =20 arc_perf_event_update(event, &event->hw, event->hw.idx); perf_sample_data_init(&data, 0, hwc->last_period); - if (arc_pmu_event_set_period(event)) { - if (perf_event_overflow(event, &data, regs)) - arc_pmu_stop(event, 0); - } + if (arc_pmu_event_set_period(event)) + perf_event_overflow(event, &data, regs); =20 active_ints &=3D ~BIT(idx); } while (active_ints); --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03487285412; Tue, 20 May 2025 18:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765042; cv=none; b=u4zKEGCPG4ARj1vRlB4RHJkcCXwXGwvwiKRKB69B/YUZ1JQQrDvqJ9I9Z3JIaHrSF5zjUvaTz7WmR/VnbAmiglFj0r4DG0CDZyB72CrFuNF8bXePpkFSkEkyrt4ErCW9WZyYJ9ydqVfiiZHAACkj69nyoyr+c0cM73d0S9fr08g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765042; c=relaxed/simple; bh=rrfPQWQxUpl+1TbJT7SuB/unJ120m8U+rV6GjI5dzKk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QdYn2gsPdIgS3+VAnBG6iHIJGN3Taz1+eOns4qOxXKvmmJzbEvphoSIydH06PbxRXazb5iN4+fXn2man/K5L3rmrIbWvYyQZ2m16HIhSRKRZ9Roc2jmhVPxfaqb1rKVGKPIdI4U2iVbN9sVHlTNoDHpKanfkhrcE/DqXzErEa90= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZH35E+Zt; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZH35E+Zt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765041; x=1779301041; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rrfPQWQxUpl+1TbJT7SuB/unJ120m8U+rV6GjI5dzKk=; b=ZH35E+Zt23/1HV2TA6TpierBNxActOiuaH4u+zK4/BH4yqSFVpHHRagr Ufbi2znWpWd+Ix4s+9IIoTU7e2aCWj1WbyL8wZXb8dDdeJwxufMy5iv8B 98v1e++6VWAIvEwylljMxzEjznABnZIHgtWmB5VSXC5ysPfvD5VP38EoM iYXRYH+PD/211dew7ZaGuxQZwa3osNMu3mAaixtOYLLLG2dIh4Bg6fzdc eAiSlQNmhtZ1ebkZe0eN6T3NpmiJRGebDeEkIlgzgLC/YG/y4ARvsTLeX 0452BxLirUKv24rEFztE02Ypq2ZVFQFsvxjS8u04Ue0XuTv/7O2Kr/RbJ Q==; X-CSE-ConnectionGUID: olNzmwJPTj6N5vzuvz1d/Q== X-CSE-MsgGUID: WxBKMJsVTTW7QWigf35iGQ== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49848034" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49848034" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:14 -0700 X-CSE-ConnectionGUID: HPiXoGeHQsGm9bdl/h2sWw== X-CSE-MsgGUID: 32SONy88R0i1xY+3Fd5/qA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514720" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:13 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , Guo Ren , Mao Han , Guo Ren , linux-csky@vger.kernel.org Subject: [PATCH V4 12/16] csky/perf: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:40 -0700 Message-Id: <20250520181644.2673067-13-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Acked-by: Guo Ren Signed-off-by: Kan Liang Cc: Mao Han Cc: Guo Ren Cc: linux-csky@vger.kernel.org --- arch/csky/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/csky/kernel/perf_event.c b/arch/csky/kernel/perf_event.c index e5f18420ce64..e0a36acd265b 100644 --- a/arch/csky/kernel/perf_event.c +++ b/arch/csky/kernel/perf_event.c @@ -1139,8 +1139,7 @@ static irqreturn_t csky_pmu_handle_irq(int irq_num, v= oid *dev) perf_sample_data_init(&data, 0, hwc->last_period); csky_pmu_event_set_period(event); =20 - if (perf_event_overflow(event, &data, regs)) - csky_pmu_stop_event(event); + perf_event_overflow(event, &data, regs); } =20 csky_pmu_enable(&csky_pmu.pmu); --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 580E32874FF; Tue, 20 May 2025 18:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765044; cv=none; b=PfjdLEbEwsVStx9XhKQ9aWBp3GN0LDFT2ftC4WRWFZwp/KGWRoxbXySx7UT3cUNs6U7VmhvkTHWnyUhYm6Z51WQvUgim0d0YOBHO657DlAriC7TTNr33AWbddEsbcEtrzxdKIZV1EzNa8h11hXocSp7uIAG5SSN7DzG87EPzygE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765044; c=relaxed/simple; bh=dbXx+MD2QCNjSXPlgp390XJDfrTSi22QXjpUAVmjpNs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CHwmtvl0lc4wPuKYSsh05IF1/5FEUoIfO4A9bn9fiiFrOu92O76RTFzjEJrkbYpySgbxFNtEk98ly9rwvlw60fLtqQ1GKaWHdHvu4PamK5Trvl3Be5QrpZeryxpjiuFP3aS09PL36t3903gwtX2SF8TATvh4C2RfJruP0a9ccPs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IpZya7Sm; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IpZya7Sm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765043; x=1779301043; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dbXx+MD2QCNjSXPlgp390XJDfrTSi22QXjpUAVmjpNs=; b=IpZya7SmFWypX9RyAlKCveoDGsubmB33yj2a2D6vb8C+tgn5mxO5TzTh ri1p8ge/aQFoX1zxhQJGknvmOIdzv3yOGKaKaTd/mIwjIJ6jMIv3Q0B7G o4LtVm3UGvn/B39dL5xTNiJzquuBFloB58NFzOqZ6ILTVRGf/p/KWstiY n4nrUp7x0XhZHhlCqQsT9gW+vTmjxPj6PTM6DpFRIikP7N2arO8XkaJCW 2kqMAzrVR4q3QRNHQi+SBWwDNnScI+ZCYAHcRTA9Ig/3R7jrd5NHsDJkM 4y+lALFpqNgIMaxv6fBKZaUSputw/UI5j66GVuIgcfY/SnM5c1bzfAOzj Q==; X-CSE-ConnectionGUID: IVW93gROQYa3hSSb3tXC/Q== X-CSE-MsgGUID: XQ/Tb4XDRi2ggdpgqqUD6w== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49848038" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49848038" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:14 -0700 X-CSE-ConnectionGUID: TrTu6ZqPT6ypv9Q1C4ThIQ== X-CSE-MsgGUID: 9XXQkyNdQSmcZPyPMEDAQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514721" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:14 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , Bibo Mao , Huacai Chen , loongarch@lists.linux.dev Subject: [PATCH V4 13/16] loongarch/perf: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:41 -0700 Message-Id: <20250520181644.2673067-14-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Bibo Mao Cc: Huacai Chen Cc: loongarch@lists.linux.dev --- arch/loongarch/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/loongarch/kernel/perf_event.c b/arch/loongarch/kernel/per= f_event.c index f86a4b838dd7..8ad098703488 100644 --- a/arch/loongarch/kernel/perf_event.c +++ b/arch/loongarch/kernel/perf_event.c @@ -479,8 +479,7 @@ static void handle_associated_event(struct cpu_hw_event= s *cpuc, int idx, if (!loongarch_pmu_event_set_period(event, hwc, idx)) return; =20 - if (perf_event_overflow(event, data, regs)) - loongarch_pmu_disable_event(idx); + perf_event_overflow(event, data, regs); } =20 static irqreturn_t pmu_handle_irq(int irq, void *dev) --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAB7D28751A; Tue, 20 May 2025 18:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765044; cv=none; b=kcFSIgFXAZcp6CHdcGt7x7Tvxk2o0DVTpyjjvSfR9ZEW4Se2GHq/xNW12YRFo1n7yQTkom3cPte3iYWgN+wGRYeIfCqBzj1cnG16yZuoSmgWnUQJPn5Hi0Q8mDXRGkWDPWY3f7vCg5O7t75KmZjvyA+tirf2NFgZfQH12mQKOcg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765044; c=relaxed/simple; bh=+LerS4ypY2xtEwvIwpQb+1sereJGijuBSIcL0NVDkSQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VQZF3p5LjHg2ZN2VWjwUNxc90ttZjbe/OOJfrFCzuh0AI7+2PSlVgOiQl8mPaThHI1xvY+yhpqYYeJ6kKWVL8ZcJKbG2mGUqKDdpTIaL8IzMGsSY5EjZuPeTuCe1R+IzqexFy0AKMVDMZp8s6mDfUznnXU59c4SArNo1kEXI1VQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VgOncb3F; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VgOncb3F" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765043; x=1779301043; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+LerS4ypY2xtEwvIwpQb+1sereJGijuBSIcL0NVDkSQ=; b=VgOncb3FBudyiHqvWGxGYRlEbYeZLxoh7VxBOyDoQEW/h4C3hA6zRqDR VANtZKUh3jSHjWYXHS6Hq++06L1FOpa6vwZR1kb9cH99W1YWUzEsE4Zea cz7C8360i5wCOShHm12pGbFn/xoiS1SVp+GSnFijlWdXeqgiaYHWJvgqq 1uSt3pKtblmRphbZlb8ZtIsKOkr7RNEs5o8/4+HqTlYJKDZdbMDOGlsec d4l0EhlU7EQCOr0LdwrcsDkZUpkZLOr2Id5R3s/cdFEWXiid9AfJCDJu9 K33Aqs7w7AIFqIkTg2XZKvPVsWoZCJiXLtN8YZW3S+1h0prt/3izLpcdE w==; X-CSE-ConnectionGUID: w7zYMWFjSU2rcY4OrqfO5w== X-CSE-MsgGUID: 6KjH8gFkQpeF8f26Lneljw== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49848046" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49848046" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:14 -0700 X-CSE-ConnectionGUID: cr8XOTUAT+SPa6g60OZ7lw== X-CSE-MsgGUID: a4ZuTZ0RQCuFnKnQZwo38A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514722" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:14 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , "David S . Miller" , sparclinux@vger.kernel.org Subject: [PATCH V4 14/16] sparc/perf: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:42 -0700 Message-Id: <20250520181644.2673067-15-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: David S. Miller Cc: sparclinux@vger.kernel.org --- arch/sparc/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/sparc/kernel/perf_event.c b/arch/sparc/kernel/perf_event.c index f02a283a8e8f..cae4d33002a5 100644 --- a/arch/sparc/kernel/perf_event.c +++ b/arch/sparc/kernel/perf_event.c @@ -1668,8 +1668,7 @@ static int __kprobes perf_event_nmi_handler(struct no= tifier_block *self, if (!sparc_perf_event_set_period(event, hwc, idx)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - sparc_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 finish_clock =3D sched_clock(); --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDA4B2882BF; Tue, 20 May 2025 18:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765044; cv=none; b=cRWm8RJ2nGCN6vdSNDn2nwvMP5TEdqnwh3W7uEJ0CfbCY4ePJPNceMkextB71TARrWRIHYcqYwZuCA4IXWVfNe0xvUSduM5Vy5Cb8Wze771bUXF9EnO8QGdQpOlwPNoeIitwjXJkewJXmBubJJObh7Oljs0xJEKZvzuBMotJjE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765044; c=relaxed/simple; bh=NOF3NytMVQIJq/xAjPCxlMah7ql+VhgMWECiQmo4kho=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nnsZoNFov0WVFUmj5r0sAfK3oX/71MwMg7lCt675ULaaeweGAc8VkbPlX/ML7aEbWwTS8OPz3Y7gflbashZJK1n2jm0OlXdY3Ee+LcA7xmfekC7voa9rgXDinWove91ZkUyTe6hVaOf2NvzqrFdn5WzahpR0zpmwmzguVW7aV9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=V+lbkm+6; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="V+lbkm+6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765043; x=1779301043; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NOF3NytMVQIJq/xAjPCxlMah7ql+VhgMWECiQmo4kho=; b=V+lbkm+6w+k1Sbt0DTOW+RDvb3jzOI72dcUUfSdDZmTCwTvGRxlL/G2U ywEcgtIhb1pIe7ABINnjeXA6mdxAC0ph17B+SQ0rE2dAaKGSvKhnT7av0 kUoQ8/6D02vfwPlkwtpb+tg1Cvm49qDrhuMsBNxoSVBU2UnriHNnaFFSw WVBkbzphLRZcmbx/gV444Os09lb/ipzzmmvYte9wuQS51y++LH5mFyz1E gtipWVRhXvANSAmUs0+O2Vce9jMImLRAstZzDfls5O3e1t/DEpabUXj9Q s4M3BhBjkQm89u15b1NBs3O8fAQxSeH4/jQR320OYWEdYoYFDLRugE1X2 A==; X-CSE-ConnectionGUID: m+2/8ZTaT8mk+RSH+lx8/g== X-CSE-MsgGUID: 3e6ikdJnT9a9EKSduAkRwg== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49848048" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49848048" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:14 -0700 X-CSE-ConnectionGUID: 6qpFn7j3TNC6gp7qhJhruQ== X-CSE-MsgGUID: b781uelYQK67hqjQQq3+xw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514723" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:14 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , Max Filippov Subject: [PATCH V4 15/16] xtensa/perf: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:43 -0700 Message-Id: <20250520181644.2673067-16-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Reviewed-by: Max Filippov Signed-off-by: Kan Liang Cc: Max Filippov --- arch/xtensa/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/xtensa/kernel/perf_event.c b/arch/xtensa/kernel/perf_even= t.c index 183618090d05..223f1d452310 100644 --- a/arch/xtensa/kernel/perf_event.c +++ b/arch/xtensa/kernel/perf_event.c @@ -388,8 +388,7 @@ irqreturn_t xtensa_pmu_irq_handler(int irq, void *dev_i= d) struct pt_regs *regs =3D get_irq_regs(); =20 perf_sample_data_init(&data, 0, last_period); - if (perf_event_overflow(event, &data, regs)) - xtensa_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 rc =3D IRQ_HANDLED; --=20 2.38.1 From nobody Tue Dec 16 02:35:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED579289370; Tue, 20 May 2025 18:17:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765046; cv=none; b=P4xtXnDFX6/Nyr6BkQqUqf+8DWKNfEs9vd/bddbj68FXzPaZZEMIJerCannbJKkFih/jE7wczq+eBeVJvcQ5BRxUcY2POuad8WmNG9eTJWEfMkC17tIItbRjZcNsSujQ188YkPYKKndwdpJ6eqgBV5f/cUQS9H7KiaZm3rdomoE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747765046; c=relaxed/simple; bh=W83BuCBEGVgUrqk/CNpFhmFYGiaT4zNHiSxidabkeh4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=s0Z96rhtW2BuJsOMBju9tvZfE7U3Mo5/n00ehlrNkLBeRJTbLVoAkkVz568g025K/NYlpvAotTFa7gjRAhpwlz6ZaSz9cu4Jb5mv/uOTaRqifTfMai8IEqxdaWDCQViHIh+ad7UeJHgb3zcNMMlvrCpfalpd3tdfwITh8FZfPPc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=k28WW5Sr; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="k28WW5Sr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747765045; x=1779301045; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=W83BuCBEGVgUrqk/CNpFhmFYGiaT4zNHiSxidabkeh4=; b=k28WW5Sr21gZcGXPKSkK/mDziqHBROdeHGkLKP6OIaZ+fJVxy6opMA1F 2tpcvZPqBMJqoGBJrOGn/MyEVFbsKbYxCxokhdEftZ8ESowgGRbTXBfeF X3Wkdtik0oz//B+1s7cQrfJSZfttTZx1poI0ReIIy5a/df0jPYrZIsPuo +pFq+t6QlOX0ZXIJr/BLyxGe4ZZd5Je0wWk30JwHSH3diCwkSDZh0YNEq xkUL1kGUEbQsKU1qSw1lKeVm2c6l4sNbPRGv5YHHAF96Vc+xsEYmgYymQ GfPRZpm1yu3fNZ2dr/G/onrpTw1aWwWHtMa/9qVK17GO3qXFLxJmmPv3R Q==; X-CSE-ConnectionGUID: Co81dHvPQImnN1Yh+cfmqg== X-CSE-MsgGUID: 73Q3a8S3Sk6lL5+UeQ1bNQ== X-IronPort-AV: E=McAfee;i="6700,10204,11439"; a="49848063" X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="49848063" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2025 11:17:14 -0700 X-CSE-ConnectionGUID: IRyZBA6xRXK9/tMskgqUFQ== X-CSE-MsgGUID: MvsA5NJFQOmUedhDBhk8nA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,302,1739865600"; d="scan'208";a="144514724" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa003.jf.intel.com with ESMTP; 20 May 2025 11:17:14 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com, Kan Liang , Thomas Bogendoerfer , linux-mips@vger.kernel.org Subject: [PATCH V4 16/16] mips/perf: Remove driver-specific throttle support Date: Tue, 20 May 2025 11:16:44 -0700 Message-Id: <20250520181644.2673067-17-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250520181644.2673067-1-kan.liang@linux.intel.com> References: <20250520181644.2673067-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org --- arch/mips/kernel/perf_event_mipsxx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/mips/kernel/perf_event_mipsxx.c b/arch/mips/kernel/perf_e= vent_mipsxx.c index c4d6b09136b1..196a070349b0 100644 --- a/arch/mips/kernel/perf_event_mipsxx.c +++ b/arch/mips/kernel/perf_event_mipsxx.c @@ -791,8 +791,7 @@ static void handle_associated_event(struct cpu_hw_event= s *cpuc, if (!mipspmu_event_set_period(event, hwc, idx)) return; =20 - if (perf_event_overflow(event, data, regs)) - mipsxx_pmu_disable_event(idx); + perf_event_overflow(event, data, regs); } =20 =20 --=20 2.38.1