From nobody Fri Dec 19 14:35:39 2025 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCB35267B19 for ; Tue, 20 May 2025 08:53:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747731194; cv=none; b=tU+PpakijG0uttR4J8/3R7sF3bUMyOwZa9hwoxbpp3LSKJECk15b8PLt1XWSWu36Bbzjb2jPNMm+g0Rq+ICmFKozVj3fYZXqIdnictjfemeCkWV6wE98GOjOVq3dO0xZQtwqMNk9xhw+kG5vRhLb0WEJ3fpm+fDtuxrie8AK/vg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747731194; c=relaxed/simple; bh=Zf1tm63k5slx8xvKAWQSF/+vFTcVGSo/FoXjgAb4LcM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NMyEJ1QnZNb6A8ybUKuWPQXr973L+B6PJYA8koRgf66lHFc5yqiksawXiK3cYNSDxfBu1sOYYQMpgGGgHjeXQlThYHxzDpMjnrSdg4Fa+nNt8Xk5NjF5uZJnGMK/WEZnu9Xr3Hcj1SDx9hDf5EfBlwj//PNO2vI57nelxEjyivI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--vdonnefort.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kcTQql73; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--vdonnefort.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kcTQql73" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43ea256f039so42058685e9.0 for ; Tue, 20 May 2025 01:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747731191; x=1748335991; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=U1sUrkER67WLT4JN0Ut8NvS0zcoI4PCXbQaK2Om0Kxk=; b=kcTQql73Vf1OZ9zRhLiOXched8CxxoAQ27lhNFuTzBkv50pH0zdzRJW6syx6GoOyuq eKpA01Er/1Xfvs1MFtwuFtJqUEk2SHFRJ+zcfQ/wHr0ggsm2qEwsZvddO62WUGa9dxsX 0tJl1IkZMIdFOBzm8jjLOGnIalOxJ8GBSczZ4p8nCpAWQ9ve+2paFMsV61sF1w56/kY3 HCrvW8Ez403ybYCzvIfJtdMLpAPuLt3kZIqBQoi0D6l6A85jDKi4e9iHP8URytVzhRw4 QgHjAKDh8btwROxXuBqfIIFO1Yam1EdNnrto6CuBNlw03WkRxsIaGP0gMqpk1kvVDYU7 ZiqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747731191; x=1748335991; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U1sUrkER67WLT4JN0Ut8NvS0zcoI4PCXbQaK2Om0Kxk=; b=FkZLbj/IDuy7TUNC8zTiNy0HzJR6JdHlinNH6lRaOOa9VCt4fEFIsNUmdHytgSEHw3 tpJ6vhj6m3A8LFppnv8BQKI/xS1bTakQ2oLzSPml5b6x2AqtDAump9LYtEXsPKQP1vxe isG0DijopPKvrvI01vhm9E1SOMKUnvOc1jeDjGqeSAUhYRRPCBsRqFLJawRPJKaYK7z3 L2LIdOo/AXkecI5n37C7OB5CRq4JWSefA7jsAU5FuVVpdYRRQ8JtO04590hzX1SawzwH cKcmfZamvjQF32ptbY9bQKvgHizbtroRKi93ZQubqKBTzuyP4WGdiHWfIxcZKrkHc2Rq pY+A== X-Forwarded-Encrypted: i=1; AJvYcCVVwlfXcqdyVHA3hijp0pPEtSIqBEBHOoo8gpuEruWokwXcPB6XdwFfmmZK9t+q0EXbPHmdJgvL+Xd6Tbw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+9/94T6UnMOjcXbh/puDFNmvHYGKRmLwNIyIevryO2cc1ew0T JWQQxlZEotUYwOGTpMHvL04MbdRRYq8My46joJ8GhxjYHQ+eVUomW2+ay5Fg6kdfHxeYx+Die3o t8l1qP2RKTbguDd1LA4nEYw== X-Google-Smtp-Source: AGHT+IENthKzsKHv/HWcWQeB37Nikyn/qGeaUXDh4XyhJ9RJ8A2GBmHwwF7MrDhhpwbzghTBNva0zDUScLc85koj X-Received: from wmbej13.prod.google.com ([2002:a05:600c:3e8d:b0:440:673c:ce2]) (user=vdonnefort job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:5008:b0:43c:ef55:f1e8 with SMTP id 5b1f17b1804b1-442fd622ce5mr160161355e9.13.1747731191322; Tue, 20 May 2025 01:53:11 -0700 (PDT) Date: Tue, 20 May 2025 09:51:57 +0100 In-Reply-To: <20250520085201.3059786-1-vdonnefort@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250520085201.3059786-1-vdonnefort@google.com> X-Mailer: git-send-email 2.49.0.1143.g0be31eac6b-goog Message-ID: <20250520085201.3059786-7-vdonnefort@google.com> Subject: [PATCH v5 06/10] KVM: arm64: Add a range to __pkvm_host_test_clear_young_guest() From: Vincent Donnefort To: maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org Cc: qperret@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-team@android.com, Vincent Donnefort Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for supporting stage-2 huge mappings for np-guest. Add a nr_pages argument to the __pkvm_host_test_clear_young_guest hypercall. This range supports only two values: 1 or PMD_SIZE / PAGE_SIZE (that is 512 on a 4K-pages system). Signed-off-by: Vincent Donnefort diff --git a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h b/arch/arm64/kvm= /hyp/include/nvhe/mem_protect.h index 64d4f3bf6269..5f9d56754e39 100644 --- a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h +++ b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h @@ -43,8 +43,8 @@ int __pkvm_host_share_guest(u64 pfn, u64 gfn, u64 nr_page= s, struct pkvm_hyp_vcpu enum kvm_pgtable_prot prot); int __pkvm_host_unshare_guest(u64 gfn, u64 nr_pages, struct pkvm_hyp_vm *h= yp_vm); int __pkvm_host_relax_perms_guest(u64 gfn, struct pkvm_hyp_vcpu *vcpu, enu= m kvm_pgtable_prot prot); -int __pkvm_host_test_clear_young_guest(u64 gfn, bool mkold, struct pkvm_hy= p_vm *vm); int __pkvm_host_wrprotect_guest(u64 gfn, u64 nr_pages, struct pkvm_hyp_vm = *hyp_vm); +int __pkvm_host_test_clear_young_guest(u64 gfn, u64 nr_pages, bool mkold, = struct pkvm_hyp_vm *vm); int __pkvm_host_mkyoung_guest(u64 gfn, struct pkvm_hyp_vcpu *vcpu); =20 bool addr_is_memory(phys_addr_t phys); diff --git a/arch/arm64/kvm/hyp/nvhe/hyp-main.c b/arch/arm64/kvm/hyp/nvhe/h= yp-main.c index fa7e2421d359..8e8848de4d47 100644 --- a/arch/arm64/kvm/hyp/nvhe/hyp-main.c +++ b/arch/arm64/kvm/hyp/nvhe/hyp-main.c @@ -331,7 +331,8 @@ static void handle___pkvm_host_test_clear_young_guest(s= truct kvm_cpu_context *ho { DECLARE_REG(pkvm_handle_t, handle, host_ctxt, 1); DECLARE_REG(u64, gfn, host_ctxt, 2); - DECLARE_REG(bool, mkold, host_ctxt, 3); + DECLARE_REG(u64, nr_pages, host_ctxt, 3); + DECLARE_REG(bool, mkold, host_ctxt, 4); struct pkvm_hyp_vm *hyp_vm; int ret =3D -EINVAL; =20 @@ -342,7 +343,7 @@ static void handle___pkvm_host_test_clear_young_guest(s= truct kvm_cpu_context *ho if (!hyp_vm) goto out; =20 - ret =3D __pkvm_host_test_clear_young_guest(gfn, mkold, hyp_vm); + ret =3D __pkvm_host_test_clear_young_guest(gfn, nr_pages, mkold, hyp_vm); put_pkvm_hyp_vm(hyp_vm); out: cpu_reg(host_ctxt, 1) =3D ret; diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvh= e/mem_protect.c index a6c45202aa85..5a7a38c5d67c 100644 --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c @@ -1111,17 +1111,21 @@ int __pkvm_host_wrprotect_guest(u64 gfn, u64 nr_pag= es, struct pkvm_hyp_vm *vm) return ret; } =20 -int __pkvm_host_test_clear_young_guest(u64 gfn, bool mkold, struct pkvm_hy= p_vm *vm) +int __pkvm_host_test_clear_young_guest(u64 gfn, u64 nr_pages, bool mkold, = struct pkvm_hyp_vm *vm) { - u64 ipa =3D hyp_pfn_to_phys(gfn); + u64 size, ipa =3D hyp_pfn_to_phys(gfn); int ret; =20 if (pkvm_hyp_vm_is_protected(vm)) return -EPERM; =20 - assert_host_shared_guest(vm, ipa, PAGE_SIZE); + ret =3D __guest_check_transition_size(0, ipa, nr_pages, &size); + if (ret) + return ret; + + assert_host_shared_guest(vm, ipa, size); guest_lock_component(vm); - ret =3D kvm_pgtable_stage2_test_clear_young(&vm->pgt, ipa, PAGE_SIZE, mko= ld); + ret =3D kvm_pgtable_stage2_test_clear_young(&vm->pgt, ipa, size, mkold); guest_unlock_component(vm); =20 return ret; diff --git a/arch/arm64/kvm/pkvm.c b/arch/arm64/kvm/pkvm.c index daab4a00790a..057874bbe3e1 100644 --- a/arch/arm64/kvm/pkvm.c +++ b/arch/arm64/kvm/pkvm.c @@ -420,7 +420,7 @@ bool pkvm_pgtable_stage2_test_clear_young(struct kvm_pg= table *pgt, u64 addr, u64 lockdep_assert_held(&kvm->mmu_lock); for_each_mapping_in_range_safe(pgt, addr, addr + size, mapping) young |=3D kvm_call_hyp_nvhe(__pkvm_host_test_clear_young_guest, handle,= mapping->gfn, - mkold); + 1, mkold); =20 return young; } --=20 2.49.0.1143.g0be31eac6b-goog