From nobody Mon Feb 9 16:25:58 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FE0C27CB31; Tue, 20 May 2025 11:14:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747739671; cv=none; b=g/fpJXLRkckBVmo52YlrRXi4qkZPmSfmH/3O2IYqsfhPNfecZOzBAcS0o7rpmWvRKGXS51c7Iu55oK0Pp2ipjNnB8coe+WXoUUzEesb6dTWbw/swX0BSypUINuGCtek7iehApFoAA2LljaHDlpvl4qwCyk5b5yNgBIKkOEFVR1Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747739671; c=relaxed/simple; bh=9NOM1BnpOYdIMMsdfz/iuXKxgIAKdzhbcuh0RqV8Oes=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=nlwGht4lxoR/EYjZKZGGm/YtAJ1FnMmg52IH+mKIMLfFbCt57csmizpQq9zCTQPLGLqqnNE8JS7eXHEOYbnuDmIcrTyYIph20Nb7aPe1R6Y9YTiyJtj09CCKegDMhE1kpcbj3UWNggOZ3xxijg8dgoNskZ7pA7prgViGAsSAp0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=JLB7tyUo; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="JLB7tyUo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1747739667; bh=9NOM1BnpOYdIMMsdfz/iuXKxgIAKdzhbcuh0RqV8Oes=; h=From:Date:Subject:To:Cc:From; b=JLB7tyUo7qUYP4jrah/fsPEOXIeqlVK9aBMagE6TeN/OgeDDwG4cDdrxo4ecTdxep vqBxcl7Q7CCy0QqZyFiBzzJ+671LtFOzxgutNbuRuTIHR0bRuuGr1a31uPjxaAl7Vp ypAqNm+4MDfJ9duxHgkikLI8d61qcEXc+Sfu30dkQuo8hdrmMFVad9hIdWU6m/OZhC OGe75UkZqN1DqC14Bubsj52QWyFar9i0ZRFm+VkI4dQqkZOwzmZQc8NdPAu6axkoBf So2j1Nqdt54QEgXHv/dbity4rLbA6oAAuDuQFxINQjlNZ5sUjZphiX6EalEBWWc2dT 7ARTj/7MvRWAw== Received: from jupiter.universe (dyndsl-091-248-211-172.ewe-ip-backbone.de [91.248.211.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by bali.collaboradmins.com (Postfix) with ESMTPSA id B7E5417E0256; Tue, 20 May 2025 13:14:27 +0200 (CEST) Received: by jupiter.universe (Postfix, from userid 1000) id 5DEB8480038; Tue, 20 May 2025 13:14:27 +0200 (CEST) From: Sebastian Reichel Date: Tue, 20 May 2025 13:14:27 +0200 Subject: [PATCH] arm64: dts: rockchip: Add missing SFC power-domains to rk3576 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250520-rk3576-fix-fspi-pmdomain-v1-1-f07c6e62dadd@kernel.org> X-B4-Tracking: v=1; b=H4sIABJkLGgC/x2MQQqAIBAAvxJ7bsFMDfpKdLBca4lMFCII/550H JiZFzIlpgxj80KimzNfoULXNrDuNmyE7CqDFFILLQWmo9eDQc8P+hwZ4+mu03JAtXpLRi9GOQc 1j4mq9K+nuZQP3n2762oAAAA= X-Change-ID: 20250520-rk3576-fix-fspi-pmdomain-4cfae65b64dd To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Detlev Casanova Cc: Nicolas Frattaroli , kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sebastian Reichel X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4394; i=sre@kernel.org; h=from:subject:message-id; bh=9NOM1BnpOYdIMMsdfz/iuXKxgIAKdzhbcuh0RqV8Oes=; b=owJ4nAFtApL9kA0DAAoB2O7X88g7+poByyZiAGgsZBPq91G573PsEcDL6ydWxoOCNqPv5m/s0 oIw7A+5EZsmOYkCMwQAAQoAHRYhBO9mDQdGP4tyanlUE9ju1/PIO/qaBQJoLGQTAAoJENju1/PI O/qaNiUQAIdoJXFKSx/rtSlc3S9FH+fQkR0qTYaPWI1c5KPoa8zTlwmXkzaoo0/DGOgP6C+tnyW O82tyej7sEaBkHJTrbWrlE3uuFIhgshOTme5pKc3NrSoC2F2MuuL8QV4iOFmWuWtuK0Bi1aCUAg d0zeWBPn20E7TTBAcO22yZ208n+Z/Yu2kKYbwHB1qJg7iLRDut7HiqLFFk9G/10/U8jqH+CT65q q3rJYGGlnazZNGFmlrZ7V8TkaQ1ctyMYwX2r5el6I3PFKKq5aekFEDWFXsSFlNM9tuRf8Q90/MB EA/n5TDJDmRn6fjPT25MfCkhtbULkOmc/+MpOaEKRfhPF8hWslHFdzFjlQSRhrMu5vjAKySlPYD HxjPwZC6gWjmJ9ZQceZV9MtTlmj6r9/K5BnjwPrcVE2PmxNkIN4HUgR7okYsWPx6PtKQ9GV0z7R EJ/7bOT4X8Nd8q4SQQj2/46pmea4QnzrR93ZA/AfZTfp0vkSrLWmC37goYK8xEYDEkBnPN8G/hT gwj0/Eo3QGfc/Ff4altnk9NFZQj5Brc34VVj0Cg3OuqciL04aHMQa4l7okLUSx+npYZYErwZfP0 MvfXApNOvjLZ4sEm4z6bcLemHLmpI0iOrX00p71SfK3W4doM8jH597139sqopGkZ//K8vxHpIkg wOT1vrNlahY+DbnEnHT8yUQ== X-Developer-Key: i=sre@kernel.org; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A Add the power-domains for the RK3576 SFC nodes according to the TRM part 1. This fixes potential SErrors when accessing the SFC registers without other peripherals (e.g. eMMC) doing a prior power-domain enable. For example this is easy to trigger on the Rock 4D, which enables the SFC0 interface, but does not enable the eMMC interface at the moment. Cc: stable@vger.kernel.org Fixes: 36299757129c8 ("arm64: dts: rockchip: Add SFC nodes for rk3576") Signed-off-by: Sebastian Reichel --- I finally managed to get some RK3576 boards integrated to our CI pipeline and promptly got some SError on Rock 4D with the extra test coverage :( As we hope to get some of those boards for KernelCI, it would be good to get this fixed in all affected trees. It seemed enough to just describe the power-domain in DT (i.e. that fixed the SError for the arm64 defconfig when booting the Rock 4D). If we see further problems (I haven't so far), we might need something like [0] for the FSPI driver. [0] https://lore.kernel.org/all/20250423-rk3576-emmc-fix-v3-1-0bf80e29967f@= collabora.com/ [ 15.248915] Kernel panic - not syncing: Asynchronous SError Interrupt [ 15.248917] CPU: 7 UID: 0 PID: 142 Comm: (udev-worker) Not tainted 6.15.= 0-rc6-g51237a9145a9 #1 PREEMPT [ 15.248921] Hardware name: Radxa ROCK 4D (DT) [ 15.248923] Call trace: [ 15.248924] show_stack+0x2c/0x84 (C) [ 15.248937] dump_stack_lvl+0x60/0x80 [ 15.248941] dump_stack+0x18/0x24 [ 15.248944] panic+0x168/0x360 [ 15.248948] add_taint+0x0/0xbc [ 15.248952] arm64_serror_panic+0x64/0x70 [ 15.248956] do_serror+0x3c/0x70 [ 15.248958] el1h_64_error_handler+0x30/0x48 [ 15.248964] el1h_64_error+0x6c/0x70 [ 15.248967] rockchip_sfc_init.isra.0+0x20/0x8c [spi_rockchip_sfc] (P) [ 15.248972] platform_probe+0x68/0xdc [ 15.248978] really_probe+0xc0/0x39c [ 15.248982] __driver_probe_device+0x7c/0x14c [ 15.248985] driver_probe_device+0x3c/0x120 [ 15.248989] __driver_attach+0xc4/0x200 [ 15.248992] bus_for_each_dev+0x7c/0xdc [ 15.248995] driver_attach+0x24/0x30 [ 15.248998] bus_add_driver+0x110/0x240 [ 15.249001] driver_register+0x68/0x130 [ 15.249005] __platform_driver_register+0x24/0x30 [ 15.249010] rockchip_sfc_driver_init+0x20/0x1000 [spi_rockchip_sfc] [ 15.249014] do_one_initcall+0x60/0x1e0 [ 15.249017] do_init_module+0x54/0x1fc [ 15.249021] load_module+0x18f8/0x1e50 [ 15.249024] init_module_from_file+0x88/0xcc [ 15.249027] __arm64_sys_finit_module+0x260/0x358 [ 15.249031] invoke_syscall+0x48/0x104 [ 15.249035] el0_svc_common.constprop.0+0x40/0xe0 [ 15.249040] do_el0_svc+0x1c/0x28 [ 15.249044] el0_svc+0x30/0xcc [ 15.249048] el0t_64_sync_handler+0x10c/0x138 [ 15.249052] el0t_64_sync+0x198/0x19c [ 15.249057] SMP: stopping secondary CPUs [ 15.249064] Kernel Offset: 0x38f049600000 from 0xffff800080000000 [ 15.249066] PHYS_OFFSET: 0xfff0e21340000000 [ 15.249068] CPU features: 0x0400,00041250,01000400,0200421b [ 15.249071] Memory Limit: none [ 15.273962] ---[ end Kernel panic - not syncing: Asynchronous SError Int= errupt ]--- --- arch/arm64/boot/dts/rockchip/rk3576.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts= /rockchip/rk3576.dtsi index 79800959b7976950fb3655289076de70b5814283..260f9598ee6c9c1536115ca3dcb= 0cbaf61028057 100644 --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi @@ -1605,6 +1605,7 @@ sfc1: spi@2a300000 { interrupts =3D ; clocks =3D <&cru SCLK_FSPI1_X2>, <&cru HCLK_FSPI1>; clock-names =3D "clk_sfc", "hclk_sfc"; + power-domains =3D <&power RK3576_PD_SDGMAC>; #address-cells =3D <1>; #size-cells =3D <0>; status =3D "disabled"; @@ -1655,6 +1656,7 @@ sfc0: spi@2a340000 { interrupts =3D ; clocks =3D <&cru SCLK_FSPI_X2>, <&cru HCLK_FSPI>; clock-names =3D "clk_sfc", "hclk_sfc"; + power-domains =3D <&power RK3576_PD_NVM>; #address-cells =3D <1>; #size-cells =3D <0>; status =3D "disabled"; --- base-commit: a95d16b0324b6875f908e5965495b393c92614f8 change-id: 20250520-rk3576-fix-fspi-pmdomain-4cfae65b64dd Best regards, --=20 Sebastian Reichel