From nobody Fri Dec 19 15:59:30 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FE1F225413; Mon, 19 May 2025 21:37:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747690631; cv=none; b=p37uh/G9hWla7+hnMRm5wv4SmUDA/Vr8eoa5CMR6mYQOb9zhQgCL9JdUbBNaiKoZyZR/R39gjnH08a6A27boFXyxYjwPgnJ9C8mCnroWPFC11zGDyVboVecmMX2sc0iv5lwbQyGpZN/IOQ+TX7UcNeYMuEkqqEA4sDY90rCpS9w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747690631; c=relaxed/simple; bh=wOlbd/AhG2UEes21QN0n7WyeptntoS/yWob+FRL5Zr0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n/o8gMcT4qVnr93J8OiFq1E7BwDHMI0iUw0okU6/HwLEg147Yck5SW4GUJI0RhYB6cH4dH/U3YCw/V/M1srUGVmfsbMaUrxlcdH7juy/siM6rkfYaJ2KQlOfEFrfu5zR9284JZkwmH8aKeUapoAZPeZAsR4AbnSOF0Dv1EzoC/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i3gP4m9a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i3gP4m9a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8109EC4CEE4; Mon, 19 May 2025 21:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747690629; bh=wOlbd/AhG2UEes21QN0n7WyeptntoS/yWob+FRL5Zr0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i3gP4m9aPW2NsVE0xy/MHN/v0To6ljSLAxEBCwGF4MfF5EU8G3soT+MZBuMT1XmkQ gPwl0jolukEG+ok4nCEziW/vgY6CUiu46p9Mb3n6tv8An5fzPgk69f8gUZ2bKJ7ZtE BonoNkfpV/Q8FpsCbecgLiOvewlHuPnS+FLXq72RiyvMFfQ8G9g4he+YUmib8GNeRW rUd2GXGM/IcI5tGX3LVmFcpjw57h6qRMye5WD4/f/BQmPdkvXcj3umMqdT7JeEAeu3 qpeAnioifLP4Kiysktj1aIPLtIk+dyaRW+LryYsqJFtCdhXF+g2/hu9Yj2qy+lExzj URhun88hwlWjw== From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Jon Pan-Doh , Karolina Stolarek , Martin Petersen , Ben Fuller , Drew Walton , Anil Agrawal , Tony Luck , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sathyanarayanan Kuppuswamy , Lukas Wunner , Jonathan Cameron , Sargun Dhillon , "Paul E . McKenney" , Mahesh J Salgaonkar , Oliver O'Halloran , Kai-Heng Feng , Keith Busch , Robert Richter , Terry Bowman , Shiju Jose , Dave Jiang , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas Subject: [PATCH v6 12/16] PCI/AER: Make all pci_print_aer() log levels depend on error type Date: Mon, 19 May 2025 16:35:54 -0500 Message-ID: <20250519213603.1257897-13-helgaas@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250519213603.1257897-1-helgaas@kernel.org> References: <20250519213603.1257897-1-helgaas@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Karolina Stolarek Some existing logs in pci_print_aer() log with error severity by default. Convert them to depend on error type (consistent with rest of AER logging). Link: https://lore.kernel.org/r/20250321015806.954866-3-pandoh@google.com Signed-off-by: Karolina Stolarek Signed-off-by: Bjorn Helgaas Reviewed-by: Ilpo J=C3=A4rvinen Reviewed-by: Kuppuswamy Sathyanarayanan --- drivers/pci/pcie/aer.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index 73b03a195b14..06a7dda20846 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -788,15 +788,21 @@ void pci_print_aer(struct pci_dev *dev, int aer_sever= ity, layer =3D AER_GET_LAYER_ERROR(aer_severity, status); agent =3D AER_GET_AGENT(aer_severity, status); =20 - pci_err(dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", status, mask); + aer_printk(info.level, dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", + status, mask); __aer_print_error(dev, &info); - pci_err(dev, "aer_layer=3D%s, aer_agent=3D%s\n", - aer_error_layer[layer], aer_agent_string[agent]); + aer_printk(info.level, dev, "aer_layer=3D%s, aer_agent=3D%s\n", + aer_error_layer[layer], aer_agent_string[agent]); =20 if (aer_severity !=3D AER_CORRECTABLE) - pci_err(dev, "aer_uncor_severity: 0x%08x\n", - aer->uncor_severity); + aer_printk(info.level, dev, "aer_uncor_severity: 0x%08x\n", + aer->uncor_severity); =20 + /* + * pcie_print_tlp_log() uses KERN_ERR, but we only call it when + * tlp_header_valid is set, and info.level is always KERN_ERR in + * that case. + */ if (tlp_header_valid) pcie_print_tlp_log(dev, &aer->header_log, dev_fmt(" ")); } --=20 2.43.0