From nobody Fri Dec 19 15:59:32 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73F83223DDA; Mon, 19 May 2025 21:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747690625; cv=none; b=ckpJZusi7knBPdqXBIkREXEBogEZivOr+jsZqtv7nVytV1vmTpPScJKu70cspWkWeXadJNs3jLjnMnUaObpD8VB4IL7Bh0OJgKk9mg7PhBdtEdItdI66/sbRMb1NfVmXNN+iQKSX45JpakiXuzSBu1huI8fq7QaYhM2cYVUYlY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747690625; c=relaxed/simple; bh=8K5sDprPkS4frD6Ujl8cJhUCTK82u2aJfFFj51dk78M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VugHrlnleclMoMHNxFK1QsOQJaGiODhqjUSA83TzvoEBFX3KW0D7xMWxg59LptJ51BOtCx/tULiPoOe3lCGg75c4JuE6bP7PMzwWKj9Ub2Msp1rBx+zmXlTpwUMLM0CcffHMrsWepYC79KwfpO91JWMzDLYA6EDkm3HimxcXpiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FanzLzd/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FanzLzd/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C125CC4CEE4; Mon, 19 May 2025 21:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747690624; bh=8K5sDprPkS4frD6Ujl8cJhUCTK82u2aJfFFj51dk78M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FanzLzd/XC+i2vgwSpoMtnfHCvFE+ndlzC5zS1V9xrvW3pvtPwg76YudFotYWcrYP /0VZyV4Tc/h9XKxBYf6IV8Iis5rD3sBS8sazMTTzYFGYs2eSf0dQWTionBZWQYmJbc mPGaauRPG+HkczhJPGbN866GWbGq/V3bSGpy3YEYEwWHyORMWnyUegPZp4vVHmO0Oz I58sZ0UjIv9txf8aVRTL7g3qN7VqbMU/jkBx/2pj6tyNhSBMGMjHUtzcPfmcv9RE7M bFYMb0xGqPOneMpdqAqdhzPaFMzT/1bqaTQfMGUlT9uSqPlaESsJaHJRGWc+pcj4I4 fDXmBtKn8IxDQ== From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Jon Pan-Doh , Karolina Stolarek , Martin Petersen , Ben Fuller , Drew Walton , Anil Agrawal , Tony Luck , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sathyanarayanan Kuppuswamy , Lukas Wunner , Jonathan Cameron , Sargun Dhillon , "Paul E . McKenney" , Mahesh J Salgaonkar , Oliver O'Halloran , Kai-Heng Feng , Keith Busch , Robert Richter , Terry Bowman , Shiju Jose , Dave Jiang , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas Subject: [PATCH v6 09/16] PCI/AER: Update statistics early in logging Date: Mon, 19 May 2025 16:35:51 -0500 Message-ID: <20250519213603.1257897-10-helgaas@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250519213603.1257897-1-helgaas@kernel.org> References: <20250519213603.1257897-1-helgaas@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Bjorn Helgaas There are two AER logging entry points: - aer_print_error() is used by DPC (dpc_process_error()) and native AER handling (aer_process_err_devices()). - pci_print_aer() is used by GHES (aer_recover_work_func()) and CXL (cxl_handle_rdport_errors()) Both use __aer_print_error() to print the AER error bits. Previously __aer_print_error() also incremented the AER statistics via pci_dev_aer_stats_incr(). Call pci_dev_aer_stats_incr() early in the entry points instead of in __aer_print_error() so we update the statistics even if the actual printing of error bits is rate limited by a future change. Signed-off-by: Bjorn Helgaas Reviewed-by: Ilpo J=C3=A4rvinen Reviewed-by: Kuppuswamy Sathyanarayanan --- drivers/pci/pcie/aer.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index 73d618354f6a..eb80c382187d 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -693,7 +693,6 @@ static void __aer_print_error(struct pci_dev *dev, aer_printk(level, dev, " [%2d] %-22s%s\n", i, errmsg, info->first_error =3D=3D i ? " (First)" : ""); } - pci_dev_aer_stats_incr(dev, info); } =20 static void aer_print_source(struct pci_dev *dev, struct aer_err_info *inf= o, @@ -714,6 +713,8 @@ void aer_print_error(struct pci_dev *dev, struct aer_er= r_info *info) int id =3D pci_dev_id(dev); const char *level; =20 + pci_dev_aer_stats_incr(dev, info); + if (!info->status) { pci_err(dev, "PCIe Bus Error: severity=3D%s, type=3DInaccessible, (Unreg= istered Agent ID)\n", aer_error_severity_string[info->severity]); @@ -782,6 +783,8 @@ void pci_print_aer(struct pci_dev *dev, int aer_severit= y, info.status =3D status; info.mask =3D mask; =20 + pci_dev_aer_stats_incr(dev, &info); + layer =3D AER_GET_LAYER_ERROR(aer_severity, status); agent =3D AER_GET_AGENT(aer_severity, status); =20 --=20 2.43.0