From nobody Fri Dec 19 14:23:46 2025 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 601FC27453; Mon, 19 May 2025 17:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747676783; cv=none; b=hOXzk41z2T0R87fct+1XaorrqJhbXSujmVxih7KGGyhynbwE6UuVL66jj4Oy9rXDp8Xic9u4kI054927rDPFMve5DlbmSZ6U/CRkphIJ9JneCxqpDnAq4O0hr/kUezN+EMTOYtk7KE9YPEwkrgssQjal9BPOo8/XJP+qaJyNW+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747676783; c=relaxed/simple; bh=q0AYkd4rGf074iXEnJ/QykPvc+gtxieVvJ0CM7zvddU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dAokeaiQ6INJ6xEzM4Pstxt3FRsZt2dVQQWhdl0GKNifZbtiP19p9MfCPEoP5sBLR3+SgXQ6wuKQWV/B/qXgZRqps9TWlurjxh35l8DEY5lv4LHPVF+NDPEk8lHBpa3dT4sXK0uOPY1Lz3ElZwjy4/1ARbeOSI+o39oBumxWyuk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nlK4iuRD; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nlK4iuRD" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-601a5747638so3963081a12.3; Mon, 19 May 2025 10:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747676779; x=1748281579; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=seMvx2/HbYkcAE2ZuakaL1Z5/hGNc6djqCfoGNlK8Nc=; b=nlK4iuRDgd2wcQHSbKkr6uGSCpcyE70QuxWGHY2DZSbWirFNAxB6se/bblwDh5gn7j 428LSicFF86+KBoe8b9UgWtWf54qvtaiJ1/EM+1C1BZLMSNU77gKrIEdRizDUIVZsBpH q15d+cwKr8wn2a6dtd/fssfzqN33S+FdTFCBWNbo6/VWSEsGwsWvw0gaB5smdmU6+VML hpnqTVEwKZHV8LwATO4c1KoDbrDWhKyA3pb+40Mq2xWijLQ6P3Pyj06ijB+8PcUJrHnd uvjFaGHiO/6zBudd+T5QsxfPV83k0faC2JKqhV+tPl8k8G5CWNs3uSwbpL0uz0b+Biss 6LSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747676779; x=1748281579; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=seMvx2/HbYkcAE2ZuakaL1Z5/hGNc6djqCfoGNlK8Nc=; b=GotxmPNvLykfy4QntjdhGbmQa34EJktQeNEMfqBVGSL8apf42y6M4xma67looNiICu aQRL1SxXnCpR41LHQDUFJaiV4IYDo+FOYQUailAstCpC2mBcJLCjXCO4bVNZxBXb6cGa kpIS1MAcOmSNcuauHJYFpFF1z4osoLOzRmfVllLYZE0eXgPSipMGQDXDBnM8/sHQy6g3 PP6o4dBdfvhjsEB+N7mWVP7THmKAELWxSzA6kqHDojxfZWqi/1eQQN+gryiay/9uTC8U GmGKrTx6+5qhQY/5sX69bgaFJBIKteJ3Z5IHR0qJfmLVsriSNhIq+uMbXp6cbzjll5nh oiIQ== X-Forwarded-Encrypted: i=1; AJvYcCWNz8mSl9aaBSd4FQWIfE7HjPS84AECdQu7tQh7XY/qgdoOytS38e/3CkEBh/RXujN5PyyZV59z@vger.kernel.org, AJvYcCWjOXOcnt+QZuwzsFTb5VxxcLsA4KnEESuIGh9ucJfZmk4+JtDixEVCeJUE7Pvbc/vRYiq49uQYqVvJayw=@vger.kernel.org X-Gm-Message-State: AOJu0YwufG491rZ17v8x8kIMRlvkgvKk9Ol57/eJRWQbQhxXgUYjWjru w48ylZHSEMvqOSGbsD561W0Ux+DpdhZYEdu51WX3vhte7mSv1OorOhVl X-Gm-Gg: ASbGncvi0eL1KgNXxu1c4cZJsCYDK96rISO319NvfWJK/c58yuHqTpKqB8NECNbjYXp u6PWy5SuOpBJ05m9Gv3x6cSmLonvCkr4pHGhlHl+2Zt1Sfxliu+nGcvJbpmBK/XHRKoNfd2QwKQ J9wPfFymN6MwdvqHlv3JZ6wdw9RFHFCyi52/YECv8lJD53Vojo21UgLLrOPeEWueCOxBq/yAMji 74wo0Bgvr1TEAJzelViijRv1pujdJP/wOFxxSpmipV5XH/eOpLylw0HbkJcCDumRWX/1QE83zIU iMBQY7bGHFepn1q7o5Kx32BTJBQfGwnuzNp8IkAavFQ9wLiF4y/nPiTeb03NX2P3+cWzoWkaZQ4 hKOVjwl0YYmZVuHv6Bx2uA8MIZsBSnVY= X-Google-Smtp-Source: AGHT+IELjEn5Rlp08nY8OrSEaAK7vJ5FeVhzbeUI79IxT37ccG1RxSir5CmWmniqRwKhAeMgPaeWvQ== X-Received: by 2002:a17:907:7205:b0:ad2:409f:fe6f with SMTP id a640c23a62f3a-ad52d5d2fa4mr1536827966b.44.1747676779290; Mon, 19 May 2025 10:46:19 -0700 (PDT) Received: from localhost (dslb-002-205-017-193.002.205.pools.vodafone-ip.de. [2.205.17.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d4ea8aesm618980566b.179.2025.05.19.10.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 May 2025 10:46:18 -0700 (PDT) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 1/3] net: dsa: b53: do not enable EEE on bcm63xx Date: Mon, 19 May 2025 19:45:48 +0200 Message-ID: <20250519174550.1486064-2-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250519174550.1486064-1-jonas.gorski@gmail.com> References: <20250519174550.1486064-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" BCM63xx internal switches do not support EEE, but provide multiple RGMII ports where external PHYs may be connected. If one of these PHYs are EEE capable, we may try to enable EEE for the MACs, which then hangs the system on access of the (non-existent) EEE registers. Fix this by checking if the switch actually supports EEE before attempting to configure it. Fixes: 22256b0afb12 ("net: dsa: b53: Move EEE functions to b53") Signed-off-by: Jonas Gorski Reviewed-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index 7216eb8f9493..a316f8c01d0a 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -2348,6 +2348,9 @@ int b53_eee_init(struct dsa_switch *ds, int port, str= uct phy_device *phy) { int ret; =20 + if (!b53_support_eee(ds, port)) + return 0; + ret =3D phy_init_eee(phy, false); if (ret) return 0; @@ -2362,7 +2365,7 @@ bool b53_support_eee(struct dsa_switch *ds, int port) { struct b53_device *dev =3D ds->priv; =20 - return !is5325(dev) && !is5365(dev); + return !is5325(dev) && !is5365(dev) && !is63xx(dev); } EXPORT_SYMBOL(b53_support_eee); =20 --=20 2.43.0 From nobody Fri Dec 19 14:23:46 2025 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5422F285409; Mon, 19 May 2025 17:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747676784; cv=none; b=cuFz/wgBXeB8bRKFjUnT163u6sL1Imz7sxXoOTd2LhK/x6tUM4C+eUs/9iG3yz8bT39nlrxKavrYyulyiH2H7OpkBznC9foF1FQDGbKNjvI3cFFOXlc7S+DHDdNIYJ47SHjADVFX5yU8n81Aqc7xsWR2BYtxQp60FAx0I9OZyHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747676784; c=relaxed/simple; bh=Fgt1Hv6DqWEvToz0/T51Ct5RfMys3O4EwPv5qKgqKWI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JME4aA5bj4aULaCAcFWBYFPMEkucrKyDw/ctu8xH2TLEk1kvlf3kh5acz3DQdlOxIInQIJdqHOTmyqj7tD7vun3dVqTyND7Ybf7JBNnDZI1Xmp8uhArpTw/o7oozGzXLkhrTiVRLwACgAhZZHSDNuVsuXyuhePJ2VDiy6cuKEtE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HFyuXbZc; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HFyuXbZc" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ad56e993ae9so258873866b.3; Mon, 19 May 2025 10:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747676780; x=1748281580; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wTRR1DsUv5T48ThSl4nokG/JrA/NXGwJCeTbonpTz6w=; b=HFyuXbZcfNW0CTqPHNY3lDLsjxmY9L1ct7ZXEEnJcpEucaY13ng4Q0K0xTO8gIrTPa dIPvTlOII1pUCZ/nLac3POYFoASU/kaOpgPJ4Qp9wCIXxdjjKHX2ByjErDZior7UuN9z 7Vh9ExFwYdAmDvK6lmBOcd/RCPsU4xN7xT9M9W4BSDBoqNBNrqOYLvQR1eH6iSz+qNW/ BowQ4GtXWePvOouCpAgbdfo1cxJ2DN2r248OonRJf6eHa45ePsdELB6JYc+PJjy74iL5 WVqtuC6mxom3TpxMF78X3luMMkstwrpF0yKaxaSObDNSvrSKvMQPYcE3prAv9ht7rHi7 16Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747676780; x=1748281580; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wTRR1DsUv5T48ThSl4nokG/JrA/NXGwJCeTbonpTz6w=; b=eR2oFvksPiwCDGbnNLcFPTu7n7CBHi8I+oYCKY1nKZAdOVNJmWAsjd1vrBvklz7kIt CBW64vtdyLrn8cLwfm07b6+o4sOp92O4qR2ilGmU3ET0pGXZbE85tD2JFJqIuLA5Vvqw I2fW3QpjLBam9sFFpyvIXZroicJ7oxJZvr+RqrY94C8CmyDTROYCNetVg2fvjEmQQq32 C+fnuve4CukThgeiB3yi/7cwt+Coij1OPFTzMyXzZri1Q/Hg3FsvSwbUX08FEaLkOCk/ 1zUV4dbkhty1vyErsggOzP/ckGWaEDmIIZEnmQlPqm0hQuS4VsUKhPdDLf+gcFMLcB// SJYw== X-Forwarded-Encrypted: i=1; AJvYcCUqqX7T/DjRbo6Ea9V84r7HmtFChA4U+jNviYcOyg4Z6vufFvEZgLyhhHATzNRE0afAdY7sPc4M@vger.kernel.org, AJvYcCWHsQBAbNkCMaWRvKDWRdONXKeh7vlladgyAYjhs+VQgyPnB4Bd34PGlM0dMbO2N4BxssT/SFA9q7EQls0=@vger.kernel.org X-Gm-Message-State: AOJu0YyB7zH7z39DQkC5o0SmyRYkdCf5NUv/b60zAc2bRPMN/dxllf0g rtClPg5UVcOqsUkbExnANFCLwMmnz/Iab/DUaR3ypT7KZWkE0Jke3Vd3 X-Gm-Gg: ASbGncv24qd7n//qF11yzsoqJy8AqRE8HjrJ/k1I+MIZS7YRr5kT+eGGGES/+1PWumf zjOip8YjXS9y7zP02XZ0UjpA/yd3weEOHEfR7Xmpm9w0oN+edm3xggStEPN7E8Qniv/2xxPLOXx 1Mct+qtp9IqCfa0a2VJcVXprv/SXQgUycjQ/U9Ka1YtgwT5i0x93oSYVJ09Tf5siJb5lJpvKKWg ZdG/UbWzq1uEQ/rruniQ5HlkTVKIwDlrRfzW9tcvtTQ4GP4BVgW0GvRJCoJbhizvSy0zty5jqL3 gWExekyXyNDRJwnvxY0qTioGpFvFVKfcd+z2mOhKqQvJ6TN8n4goOQ4M1KRHhQtzvVkG2l/Toa6 RwKVSrIHaoA1ICkpnuFn3H+agrwlyVoBO5W1KLjyHTw== X-Google-Smtp-Source: AGHT+IEMKd5IKPfWCpZ5DavepczIl2J5lU7U8sKeO6HQQqieOggoCYuQrqo+rZm7rd94C3KTik8tGA== X-Received: by 2002:a17:907:2d1f:b0:ad2:23b6:149c with SMTP id a640c23a62f3a-ad536dcd710mr1032820766b.43.1747676780373; Mon, 19 May 2025 10:46:20 -0700 (PDT) Received: from localhost (dslb-002-205-017-193.002.205.pools.vodafone-ip.de. [2.205.17.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d4ca5c5sm615820266b.162.2025.05.19.10.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 May 2025 10:46:19 -0700 (PDT) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 2/3] net: dsa: b53: fix configuring RGMII delay on bcm63xx Date: Mon, 19 May 2025 19:45:49 +0200 Message-ID: <20250519174550.1486064-3-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250519174550.1486064-1-jonas.gorski@gmail.com> References: <20250519174550.1486064-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The RGMII delay type of the PHY interface is intended for the PHY, not the MAC, so we need to configure the opposite. Else we double the delay or don't add one at all if the PHY also supports configuring delays. Additionally, we need to enable RGMII_CTRL_TIMING_SEL for the delay actually being effective. Fixes e.g. BCM54612E connected on RGMII ports that also configures RGMII delays in its driver. Fixes: ce3bf94871f7 ("net: dsa: b53: add support for BCM63xx RGMIIs") Signed-off-by: Jonas Gorski --- drivers/net/dsa/b53/b53_common.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index a316f8c01d0a..b00975189dab 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1328,19 +1328,19 @@ static void b53_adjust_63xx_rgmii(struct dsa_switch= *ds, int port, =20 switch (interface) { case PHY_INTERFACE_MODE_RGMII_ID: - rgmii_ctrl |=3D (RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC); + rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC); break; case PHY_INTERFACE_MODE_RGMII_RXID: - rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_TXC); - rgmii_ctrl |=3D RGMII_CTRL_DLL_RXC; + rgmii_ctrl |=3D RGMII_CTRL_DLL_TXC; + rgmii_ctrl &=3D ~RGMII_CTRL_DLL_RXC; break; case PHY_INTERFACE_MODE_RGMII_TXID: - rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_RXC); - rgmii_ctrl |=3D RGMII_CTRL_DLL_TXC; + rgmii_ctrl |=3D RGMII_CTRL_DLL_RXC; + rgmii_ctrl &=3D ~RGMII_CTRL_DLL_TXC; break; case PHY_INTERFACE_MODE_RGMII: default: - rgmii_ctrl &=3D ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC); + rgmii_ctrl |=3D RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC; break; } =20 @@ -1350,6 +1350,7 @@ static void b53_adjust_63xx_rgmii(struct dsa_switch *= ds, int port, =20 rgmii_ctrl |=3D RGMII_CTRL_ENABLE_GMII; } + rgmii_ctrl |=3D RGMII_CTRL_TIMING_SEL; =20 b53_write8(dev, B53_CTRL_PAGE, off, rgmii_ctrl); =20 --=20 2.43.0 From nobody Fri Dec 19 14:23:46 2025 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BB60288C86; Mon, 19 May 2025 17:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747676785; cv=none; b=Ki9nDfhApgNBAdOymnBfF8GZa6wWifBYeAfJFJ6WRN5QBU3/Zo+l+c1wtvU0yUxhMo7ZqtwM105Zk2VrXkA/I8/2XcA1Er9VJSOsQKLXl+zrFYlT7wW7CJx7mRPYKPZPMmjZt1RzQllhXEIbALj2M6IKpD/t0EL92agC8cef1jo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747676785; c=relaxed/simple; bh=uqiw7kPHnRXfh4KjJ6YjxUfuMjfIRbxc3MxfKiuob40=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q5H5CgrNHcDR5Cn+53mu+eKAqmbrrhVUD2XY25i6aMcx5LNYAWM0Bqv1cih2wcp8DdmuJfU7DdmbTiythCx7byfWKKWjOg5QXSWvsfh0bvEiO1B8INA24Cyg0rfCLIbx3ydkur7l1jbcfBoc4tSdWTCZ+wcY0rwaJ216Go7rKY0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dgF8yVqT; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dgF8yVqT" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-6000f2f217dso3962452a12.1; Mon, 19 May 2025 10:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747676782; x=1748281582; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GUhHJEXQrlPdO/IBxhxTsANnm82xLSOlInc80+87whs=; b=dgF8yVqTczljL/ocjchAMjYEwieu6TifSpZAC5Byl9e/N+4HFlGOWSPkT6EeRsvoRv diLaBpUcoQvwO2YK20ab/Go1jvHWrL2U+nwIVvlL1Mb7rwfza6XVQWPYJ2eoC30zzAyI Gu0+R2ivtc76eUJUpW0+qrK7LBM9QZ5lN7Ig6veTq/vFYrZtFllntqfmgPe2Ag0WOCJY n5n6bI+KIuJ7PpovVCIXLiDz1hQsDQausYvQzYgy6GuOqoIg6e5iVShFlvcgsYHnOJ1h 6cUuf1O//lprZFttDjX+dFZInaRgT+N4sBXrxXK+Xj5A1f9U1sLhSXFT3kJe990j5hTo 6mlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747676782; x=1748281582; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GUhHJEXQrlPdO/IBxhxTsANnm82xLSOlInc80+87whs=; b=ESYqedq3C2Z8QyMvzOq4+DcQpKH8TVf3Kkdkx6Pk7ZUZ1yFuPljY7+/rvHLUDj5Y6A vnJ3WK/fPLaHYqZ0xyKFefIQi+fltIXAP7a+VGK9w4aUomGGC2zPKrI5f9HMh1YcsMCr eMj4L7rEHkn2ZOx7BT1MKsLqSrZiX0BRnOchNZat2RPTdU6m6QwblGvpj9YG335i5P3r GhIkF8lzL10czZtOAgVLXsDbZ1CEOd2PCQvKXYFB4udQnlC8qPtcm9Zg5kuO5RhViKYQ tfwrDyaL16FVBTCu7N0lGOnsD84VhC2rqN73FUAIireudDNwVU83YTVAt05yEauX3AFZ 3VoA== X-Forwarded-Encrypted: i=1; AJvYcCVoBsH3EROtv9PmjcLJ5O7XczFl1G9qrjbgth8NzuQ9NyeimfL+zkeTm7gt6UqYlkiAPFuAZ1n+DyO9EMI=@vger.kernel.org, AJvYcCVqwJY1BNcDbTAZBm9Zt3UmxcbiPfpWSV/qg4xDafUCPcOSiiAetqUl8g5MSvXgiw+87kUwm3vi@vger.kernel.org X-Gm-Message-State: AOJu0YwJSYJtLqtePOXKuOcTFPlIEPNQvUf1o5AdOlhjTt7h4Yvh0nBR kM31HD6j0WjAMKV64hxxIubfqG3TbwU+I2wfsKUVQQh5EuBnWWOnOhzk X-Gm-Gg: ASbGnctVUj8ujAX5Y1CEyOiM906WvRTIWYJUHUFiAVhse+l2q8HLtzs6fi8FcKGi8u0 u5p/hvHnefZ3AOJ6fj5a9nJDKptESFD6VEz/qxbr6Ocfra+9Ww2ENDzGNjrWdNnSgX2daD0+uYo 9am13pNjCsN+EPsFEPhPAwbbxO1wD0ncZU2bhAanDikdemTt49x57MrYjbSWwCCEwVS4eSbf+Tb jxZiXCs3LS+CikUgzacqEVlhZGCF1+lV9u9klHmoRH8Z+UpAy6Q3TGticNDd8szCvLrQQ/qw03R InjagFHUczEA44iPPOLG4LJbnt/LHW+OGLq7hisbOMdUcKpnud/bJqR6J4maIvCZ+yTtyMZBypj ChDBUJNxBtFrjCTD1Oz6WTYfHLq0+n37h3rZI+/7j/A== X-Google-Smtp-Source: AGHT+IFeYwhCeA6tAalFdp6N+IAjFVHwQXe3scg3Xdf5BUfVsFrivmVXWqv6JMq7KetvOHwL3ocb4A== X-Received: by 2002:a05:6402:4301:b0:602:3e4:54de with SMTP id 4fb4d7f45d1cf-60203e45620mr711671a12.10.1747676781464; Mon, 19 May 2025 10:46:21 -0700 (PDT) Received: from localhost (dslb-002-205-017-193.002.205.pools.vodafone-ip.de. [2.205.17.193]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6004d50364dsm6047560a12.32.2025.05.19.10.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 May 2025 10:46:21 -0700 (PDT) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 3/3] net: dsa: b53: allow RGMII for bcm63xx RGMII ports Date: Mon, 19 May 2025 19:45:50 +0200 Message-ID: <20250519174550.1486064-4-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250519174550.1486064-1-jonas.gorski@gmail.com> References: <20250519174550.1486064-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add RGMII to supported interfaces for BCM63xx RGMII ports so they can be actually used in RGMII mode. Without this, phylink will fail to configure them: [ 3.580000] b53-switch 10700000.switch GbE3 (uninitialized): validation = of rgmii with support 0000000,00000000,00000000,000062ff and advertisement = 0000000,00000000,00000000,000062ff failed: -EINVAL [ 3.600000] b53-switch 10700000.switch GbE3 (uninitialized): failed to c= onnect to PHY: -EINVAL [ 3.610000] b53-switch 10700000.switch GbE3 (uninitialized): error -22 s= etting up PHY for tree 0, switch 0, port 4 Fixes: ce3bf94871f7 ("net: dsa: b53: add support for BCM63xx RGMIIs") Signed-off-by: Jonas Gorski Reviewed-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index b00975189dab..9d97ad146ce4 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1458,6 +1458,10 @@ static void b53_phylink_get_caps(struct dsa_switch *= ds, int port, __set_bit(PHY_INTERFACE_MODE_MII, config->supported_interfaces); __set_bit(PHY_INTERFACE_MODE_REVMII, config->supported_interfaces); =20 + /* BCM63xx RGMII ports support RGMII */ + if (is63xx(dev) && port >=3D B53_63XX_RGMII0) + phy_interface_set_rgmii(config->supported_interfaces); + config->mac_capabilities =3D MAC_ASYM_PAUSE | MAC_SYM_PAUSE | MAC_10 | MAC_100; =20 --=20 2.43.0