From nobody Fri Dec 19 17:18:42 2025 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31C7628313A for ; Fri, 16 May 2025 23:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747436869; cv=none; b=EtkC2AsKxwVLQ5shi8Q57BjDbRNQG+ZYAa3AJYcyQa7IRxQFFuP1EyYQQjx5dW0OUYuKAyvXHesnEzx8MHwgEnGIIZO21xsSUz7WKmxVxkPRUOKx3zrca76LAKk9WP0UVz3s3gQw/YxltJuorbOCVig8PhHu0ZEKiBpniZpw/rQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747436869; c=relaxed/simple; bh=9fbaq6CwF6vLyggy/XV/8/w2/CV/cudq3CDw85TXlSE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=njWriK2u0OKtaY1j5GhCCutcT2WM/xVQaaedvYkq2nbvuJMmP5pRWh1mdadZJYtLubC3jJUan+Er4SdVUO1m8CXAGjkfSrADChihQ6+Xf+xmcd8gw2uH9UVxLkxfgfHia9zGOJRM7D3DKKAU8CuLjMq8zFwuRIhabpUFtXGalzA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Y7kY1pKJ; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Y7kY1pKJ" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-73dcce02a5cso1756740b3a.0 for ; Fri, 16 May 2025 16:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747436867; x=1748041667; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=oe5thiWbXg0oQhkHd+uP+1sLcx+Gwe9eK60YPiQS+Fw=; b=Y7kY1pKJnFIDf1qHpybNFR4/E0j2z6oX/y1xW/ATRroSbZ7hmZEXBf7/eOhY5NkUh2 +Du3R2D7tR7Ik4wNPhgmPsyoAnYraDYJ1bCF4uyUlMe9Cmqq9NE0DY/x+2gyfrEMGajP xKMdIU9yKF1JxoRWSWgxGAi7tx8L6IvSYf3Z16VLOqVskEGpboSEzwHlDJA6yKGicWxq FrPV4EIJ+ATB5o/ziDxtPibMBDQCe3MDenYxenI7R1ecDlmoCaoGXlpFpFB93+fHxYZO SblxSlI3Llr9mBmdJag2fLpy8fz2mhgEvAmBzkBfPh1F7uG6Vw50qajc4eRllUka3t/W vaNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747436867; x=1748041667; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oe5thiWbXg0oQhkHd+uP+1sLcx+Gwe9eK60YPiQS+Fw=; b=gRCIx/CKZdfTqUdKCGlnegpThqdE0KvNTaYoi4c5k/q5jChbD5OdngM7JPa+K+zK8i bVmMq6pPWZgXqQJpTdU9aRTaN62v93az4ceHqxAYWm1z5GnwFG3srTWiJeX7maKFvAwS 5fjr+/SYoEFUC9j0CDtG7T84WrugjoaupjQK3kIse4oKhGLqtJsFtXp2zUZnsG2woIqu wj17ErkrF4A9pSKWu6NMIrEJ/y4eHgu2SogEW0V3Ogz3A20ONYw8drfhLFsUyswECdad B3fjTKsYGtdF5uFyIZVwse1Bdi99mn/bMlbXxsTvEx5s2oNuXlXcwEo1VjE53+3z9Zyv U8IQ== X-Forwarded-Encrypted: i=1; AJvYcCXkcLf0+tGWMNFyfVeNwxkcMZLB/eWIVaQKB76zTeX/Vr0hNNBtX4yMQtV1lwY2SzAB+JZX72SfQA6qYCw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2JI6u1LkdgdTW86wN6dgiLZYzE10M48qePAq8hT3cpleyX970 bOt4ARFHDBDIwNCDTEH6K58NbR5oyjtYmhI5VhiDAU1z0cQCEXzsIyxg3WX69UfctN0zABtwmx7 0nS9ggg== X-Google-Smtp-Source: AGHT+IGwhN0lFa7qi9dcKhCQf1tbewsw4jw8vfokJ04Lk3TJnvb2OFxjdzkHkOC3oXEw4fYXmMusrSpK3XA= X-Received: from pjboi16.prod.google.com ([2002:a17:90b:3a10:b0:2fc:2ee0:d38a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:7f96:b0:1f5:7280:1cf2 with SMTP id adf61e73a8af0-2170cc66b99mr5833370637.12.1747436867484; Fri, 16 May 2025 16:07:47 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 16 May 2025 16:07:31 -0700 In-Reply-To: <20250516230734.2564775-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250516230734.2564775-1-seanjc@google.com> X-Mailer: git-send-email 2.49.0.1112.g889b7c5bd8-goog Message-ID: <20250516230734.2564775-6-seanjc@google.com> Subject: [PATCH v2 5/8] irqbypass: Use paired consumer/producer to disconnect during unregister From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini , "Michael S. Tsirkin" , Jason Wang , Alex Williamson Cc: kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kevin Tian , Oliver Upton , David Matlack , Like Xu , Binbin Wu , Yong He Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the paired consumer/producer information to disconnect IRQ bypass producers/consumers in O(1) time (ignoring the cost of __disconnect()). Reviewed-by: Kevin Tian Acked-by: Michael S. Tsirkin Signed-off-by: Sean Christopherson --- virt/lib/irqbypass.c | 48 ++++++++------------------------------------ 1 file changed, 8 insertions(+), 40 deletions(-) diff --git a/virt/lib/irqbypass.c b/virt/lib/irqbypass.c index fdbf7ecc0c21..6a183459dc44 100644 --- a/virt/lib/irqbypass.c +++ b/virt/lib/irqbypass.c @@ -138,32 +138,16 @@ EXPORT_SYMBOL_GPL(irq_bypass_register_producer); */ void irq_bypass_unregister_producer(struct irq_bypass_producer *producer) { - struct irq_bypass_producer *tmp; - struct irq_bypass_consumer *consumer; - if (!producer->eventfd) return; =20 mutex_lock(&lock); =20 - list_for_each_entry(tmp, &producers, node) { - if (tmp->eventfd !=3D producer->eventfd) - continue; + if (producer->consumer) + __disconnect(producer, producer->consumer); =20 - list_for_each_entry(consumer, &consumers, node) { - if (consumer->eventfd =3D=3D producer->eventfd) { - WARN_ON_ONCE(producer->consumer !=3D consumer); - __disconnect(producer, consumer); - break; - } - } - - producer->eventfd =3D NULL; - list_del(&producer->node); - break; - } - - WARN_ON_ONCE(producer->eventfd); + producer->eventfd =3D NULL; + list_del(&producer->node); mutex_unlock(&lock); } EXPORT_SYMBOL_GPL(irq_bypass_unregister_producer); @@ -228,32 +212,16 @@ EXPORT_SYMBOL_GPL(irq_bypass_register_consumer); */ void irq_bypass_unregister_consumer(struct irq_bypass_consumer *consumer) { - struct irq_bypass_consumer *tmp; - struct irq_bypass_producer *producer; - if (!consumer->eventfd) return; =20 mutex_lock(&lock); =20 - list_for_each_entry(tmp, &consumers, node) { - if (tmp !=3D consumer) - continue; + if (consumer->producer) + __disconnect(consumer->producer, consumer); =20 - list_for_each_entry(producer, &producers, node) { - if (producer->eventfd =3D=3D consumer->eventfd) { - WARN_ON_ONCE(consumer->producer !=3D producer); - __disconnect(producer, consumer); - break; - } - } - - consumer->eventfd =3D NULL; - list_del(&consumer->node); - break; - } - - WARN_ON_ONCE(consumer->eventfd); + consumer->eventfd =3D NULL; + list_del(&consumer->node); mutex_unlock(&lock); } EXPORT_SYMBOL_GPL(irq_bypass_unregister_consumer); --=20 2.49.0.1112.g889b7c5bd8-goog