From nobody Fri Dec 19 20:39:43 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FF4B1FF7C8; Fri, 16 May 2025 14:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747407531; cv=none; b=LBopY8k1MlaXtAOc1fSoCBKOwB6jo9LIiKTneliBWUesp7xqQgnL4/13LKn/dEhZBxlLBwviBjsRPM+pr5Xn9DPOkqKQjwIu5r42DDQzDvp3LJmh3ckP7V+jzg3ObX0Xpc2lbj6HLaJed1vcSW63sGA79uOYTU1m5QeTzshPm1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747407531; c=relaxed/simple; bh=e7/rff0nN+c5LP3hyZCSDYm6ySQB1kPcZXmcsnBqILQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L9FzBbZDfXLHZxtME7RCj9gUG848Fo+bv1+8HgQ/KzMsAzL0egrhRuNoLKAymCb7Xj4jB0F6421iuEp6LuxDzRUn9FFoTNApZmeVg03k8KuAkw5WcWPh9WHNRRha3n7xvpU4fuZYpYlLm3svhk+oFjc562HHEqzEIiI97KFkRm4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DE0s05ZT; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DE0s05ZT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747407530; x=1778943530; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=e7/rff0nN+c5LP3hyZCSDYm6ySQB1kPcZXmcsnBqILQ=; b=DE0s05ZTk+5xzxe+xzgjsYuyqiI+HN7B5ToFqwF+Gmsfy4roTXnr54GW 90a4OTYB1wqsn0rfNMIyC7tLw/tPfJiP8z/f1rwcwQGwpHkis144bVGKl Asn2qNEFtHN/vyf586n8ty9miT0uDHXcqNLy36165dNER3NJjIwmZHsw+ FRdHAJ6bw+qedvExrCh3tzeglVmXJbMcObYSTeNtjb0pgVw9wOSrnfSUf vWDtlx3cnFUlA9c5/Zk6pY/yxVu3J5rNn4pjg359xG25T4qYOEAXtYR2N 5h8WmoiPKVGzVOufhPRWN060DYsSqPQ2anQr+vdsE4X3WueF4H37ec5sS g==; X-CSE-ConnectionGUID: 9C48sd07RRKU0O0XzONlaA== X-CSE-MsgGUID: A15f94uSTjSsz4M4rIzV3A== X-IronPort-AV: E=McAfee;i="6700,10204,11435"; a="60407563" X-IronPort-AV: E=Sophos;i="6.15,294,1739865600"; d="scan'208";a="60407563" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2025 07:58:48 -0700 X-CSE-ConnectionGUID: /jCG6dFZSR+5466uPvg9Mg== X-CSE-MsgGUID: BOiSSllxSPq/ZTQ5qGKlVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,294,1739865600"; d="scan'208";a="139240128" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by orviesa007.jf.intel.com with ESMTP; 16 May 2025 07:58:41 -0700 Received: from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146]) by irvmail002.ir.intel.com (Postfix) with ESMTP id 97C7934325; Fri, 16 May 2025 15:58:38 +0100 (IST) From: Larysa Zaremba To: intel-wired-lan@lists.osuosl.org, Tony Nguyen Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Przemek Kitszel , Jiri Pirko , Tatyana Nikolova , Andrew Lunn , Alexander Lobakin , Michael Ellerman , Maciej Fijalkowski , Lee Trager , Madhavan Srinivasan , Larysa Zaremba , Sridhar Samudrala , Jacob Keller , Michal Swiatkowski , Mateusz Polchlopek , Ahmed Zaki , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Karlsson, Magnus" , Emil Tantilov , Madhu Chittim , Josh Hay , Milena Olech , pavan.kumar.linga@intel.com, "Singhai, Anjali" , Michal Kubiak Subject: [PATCH iwl-next v4 11/15] idpf: print a debug message and bail in case of non-event ctlq message Date: Fri, 16 May 2025 16:58:08 +0200 Message-ID: <20250516145814.5422-12-larysa.zaremba@intel.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250516145814.5422-1-larysa.zaremba@intel.com> References: <20250516145814.5422-1-larysa.zaremba@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unlike previous internal idpf ctlq implementation, idpf calls the default message handler for all received messages that do not have a matching xn transaction, not only for VIRTCHNL2_OP_EVENT. This leads to many error messages printing garbage, because the parsing expected a valid event message, but got e.g. a delayed response for a timed-out transaction. The information about timed-out transactions and otherwise unhandleable messages can still be valuable for developers, so print the information with dynamic debug and exit the function, so the following functions can parse valid events in peace. Reviewed-by: Michal Kubiak Signed-off-by: Larysa Zaremba Tested-by: Samuel Salin --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/= ethernet/intel/idpf/idpf_virtchnl.c index 31c7e1984f6c..d2bf5226b31d 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -82,6 +82,13 @@ void idpf_recv_event_msg(struct libie_ctlq_ctx *ctx, u32 event; =20 adapter =3D container_of(ctx, struct idpf_adapter, ctlq_ctx); + if (ctlq_msg->chnl_opcode !=3D VIRTCHNL2_OP_EVENT) { + dev_dbg(&adapter->pdev->dev, + "Unhandled message with opcode %u from CP\n", + ctlq_msg->chnl_opcode); + goto free_rx_buf; + } + if (payload_size < sizeof(*v2e)) { dev_err_ratelimited(&adapter->pdev->dev, "Failed to receive valid payloa= d for event msg (op %d len %d)\n", ctlq_msg->chnl_opcode, --=20 2.47.0