From nobody Fri Dec 19 19:05:47 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2C6BB189906; Fri, 16 May 2025 14:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747407388; cv=none; b=pBoJt/QUiIcKhqWS9LZ5SFyns/2nXrJjmM1Xz3YnWnortQPwOIKTGFkdq7u2vUBW+PaccvWe0lcGulqJilm1AUkd5mFXJTPv+P11ZadGdVHysZWyISfe435/ASjB5MJjlFkmyhCsGvsaJBTv4W8jIqMC3IhjWGZ0YF6kSQmQr80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747407388; c=relaxed/simple; bh=fj+CsMRTdhR1fX9gY8RgTc+l5nN9Ow3NT2nQ+WxKZ50=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LSZahTujQv+Q4wDOHL2KwlifqHPv+xK1Gvrnw4n4BmZvIxOu5E4+qwLQhDeIL31Zvlv6DtOmQ2J1AukxybAH0s7H6/WF4EmByNd4s23v0NPYk/q19Q7UPWY0hIC4Xw9zGtPORP1fsu7wmUfgGXALWeA6YVA1B2TQZ+6W5q79rGk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=ZAP66Zmb; arc=none smtp.client-ip=220.197.31.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="ZAP66Zmb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=OK C2LPdw3n8i6eOmbAF8IdjSTk4530z62vZdkc/GbAE=; b=ZAP66Zmbdeg2ELRjmX rjTqQUpbJ7br5GB/+zmH5QBtEK+FNUKBBjqyWp0gAGERH4kbAfCYsUOtC7M+Zcta ikPVzOCqgxPUp4U2LC/q8elaeU7NgkS1II1B51g1RtGwskcZgjdjIGKik/XNbHEs icMTj/9Vmi/JpCikJobFkV1Zk= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-3 (Coremail) with SMTP id _____wCXtfDyUSdoaTNOBw--.62835S3; Fri, 16 May 2025 22:55:48 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, heiko@sntech.de, manivannan.sadhasivam@linaro.org Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH v2 1/3] PCI: rockchip-host: Fix "Unexpected Completion" log message Date: Fri, 16 May 2025 22:55:42 +0800 Message-Id: <20250516145544.110516-2-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250516145544.110516-1-18255117159@163.com> References: <20250516145544.110516-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCXtfDyUSdoaTNOBw--.62835S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XrWrWF4xXF4kArW3Cw1fCrg_yoWkGrcE9r n8u3W7Aw45KrW3A3Wqy3yxtryrAas09a1IkayrtF1ayas2vr10q34kZ3y8JF15ur1DXF9r Kw1qyr47WwnrZjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRAzV1UUUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbBDwNPo2gnTiJ5TQAAs3 Content-Type: text/plain; charset="utf-8" Fix the debug message for the PCIE_CORE_INT_UCR interrupt to clearly indicate "Unexpected Completion" instead of a duplicate "malformed TLP" message. This improves error log accuracy. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Manivannan Sadhasivam --- drivers/pci/controller/pcie-rockchip-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 6a46be17aa91..2804980bab86 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -439,7 +439,7 @@ static irqreturn_t rockchip_pcie_subsys_irq_handler(int= irq, void *arg) dev_dbg(dev, "malformed TLP received from the link\n"); =20 if (sub_reg & PCIE_CORE_INT_UCR) - dev_dbg(dev, "malformed TLP received from the link\n"); + dev_dbg(dev, "Unexpected Completion received from the link\n"); =20 if (sub_reg & PCIE_CORE_INT_FCE) dev_dbg(dev, "an error was observed in the flow control advertisements = from the other side\n"); --=20 2.25.1 From nobody Fri Dec 19 19:05:47 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5ABC11BC099; Fri, 16 May 2025 14:56:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747407393; cv=none; b=mnsawtyquFavNtCccPZk8DVzwgTkYRVPUteHazZQ7exwThles01BmWpH+83cfBdjkJc1CwhR5iOkbe7QeHrV/v+TZaPWIMqRZpcb4KG4qmxLptjuddqhKgbDRnrOKs475chkf/nA+3x2A8jPgv9WBf4lT4fajDW16S1DFVxYW7M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747407393; c=relaxed/simple; bh=RWQ4XGYVHDZycGxd62P1KIGqj+01EfPS/QKkS6xcxKQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NavEe88eR4BIdZd+OGwCpak/KT9+vLDHujrGClUzWZ3yty4ugQ15+A7WhKwTasNy00y6mm+f9ZPVRBPbGZhg0Z12sFWZwcaCIL+O6wgPTTcZK7bTYrqLIebBes78H7tyWbJcAKJaO+toBPeTNX7EjR4aJX3Nqd06cQjvEJsDMrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=Yhzr7Ebe; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="Yhzr7Ebe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=7x riZp5G3YdXkIK9LD+KY/Qb8BNn8y/0CGxYnt75nvI=; b=Yhzr7EbetfKf3PAnMl Yeh+UlCmnuJeSxKfNk2GeRLJryYUUN2bLD/sk0DoOWwpx1uHTn3NQlRTWDjwQc+C 5uFk7/rYw5toOCP1jybMaaFGNB1gVnbvVrMXT7sRQaepLzz/kNYBA2lsaba9MAdr xw8B74HHCsLlEzziFJsU87sV4= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-3 (Coremail) with SMTP id _____wCXtfDyUSdoaTNOBw--.62835S4; Fri, 16 May 2025 22:55:49 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, heiko@sntech.de, manivannan.sadhasivam@linaro.org Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH v2 2/3] PCI: rockchip-host: Correct non-fatal error log message Date: Fri, 16 May 2025 22:55:43 +0800 Message-Id: <20250516145544.110516-3-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250516145544.110516-1-18255117159@163.com> References: <20250516145544.110516-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCXtfDyUSdoaTNOBw--.62835S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrZr4ruF1fCr4DAry5tFyrWFg_yoWDKrcE9r 1jva47Zw4UKr9ag3Zay3ySqr9xAasI9r4Iya1rKF1aya47Xr1Fq348Zwn8JFn5Cr15tF9F g3sFyFWUuF43ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRMpnQUUUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiWw5Po2gnTwJd2AACs8 Content-Type: text/plain; charset="utf-8" Correct the debug message for PCIE_CLIENT_INT_NFATAL_ERR from "no fatal error" to "non fatal error interrupt received" to match the actual interrupt semantics. This avoids confusion in log interpretation. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Manivannan Sadhasivam --- drivers/pci/controller/pcie-rockchip-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 2804980bab86..209eb94ece1b 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -489,7 +489,7 @@ static irqreturn_t rockchip_pcie_client_irq_handler(int= irq, void *arg) dev_dbg(dev, "fatal error interrupt received\n"); =20 if (reg & PCIE_CLIENT_INT_NFATAL_ERR) - dev_dbg(dev, "no fatal error interrupt received\n"); + dev_dbg(dev, "non fatal error interrupt received\n"); =20 if (reg & PCIE_CLIENT_INT_CORR_ERR) dev_dbg(dev, "correctable error interrupt received\n"); --=20 2.25.1 From nobody Fri Dec 19 19:05:47 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6DC713C914; Fri, 16 May 2025 14:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747407389; cv=none; b=fBRowXelMUE1PuSX0/LBy/K5zVR0DUzaB/ljLChMs9UApgwgki4ZSS1/W9IOVtYmfDiMHuPUErW0kNxSJSO+ozHpt//N8d+JY3ejTlI5pC2klQypTfqrt1GyMejC2nQ1XBKWcv0BGaBnkWs1HQekDR/5BYQMrVRa9VuWXwtwhBE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747407389; c=relaxed/simple; bh=8oeZBsX5EC0b5DNou3U2gY7TL+OyZZNV32V+AEK5ox0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=n9EB5kvqj+88xJsHLA+y7zQbrQIu8WcKFyBmBy0XRjLJVnVITtBw4bwDmwLDODgywOu55MlxVXT5G5YGYuImQdHfmnHLyLi/djIbqi7TvXQgMZa33me9auMsz398S9p/rjKfDLs1yotVy/Q2Pma8IkEOL6YDM2XyVO3iG+24tqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=Qpn9pmf/; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="Qpn9pmf/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=0j oqUCbd9YvfR3Cm4Fm+cClE5ZXyYtYajQTs8EUIyUc=; b=Qpn9pmf/PmS+YDPrMB 1doX8fxFQg+0WijijSwAlEhPPvP2t3sxj+9Ben1ViyNmx1bnK+HU7t/lXiQknnpC MJWUwFBuwdaG0Dqm3Ez3r8/MwukETUXNrbPie7KmvQY7lKsXaapU1NaUpixCjN/h j9iqXCP1f08WTNUwD+P3dD61E= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-3 (Coremail) with SMTP id _____wCXtfDyUSdoaTNOBw--.62835S5; Fri, 16 May 2025 22:55:49 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, heiko@sntech.de, manivannan.sadhasivam@linaro.org Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH v2 3/3] PCI: rockchip-host: Remove unused header includes Date: Fri, 16 May 2025 22:55:44 +0800 Message-Id: <20250516145544.110516-4-18255117159@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250516145544.110516-1-18255117159@163.com> References: <20250516145544.110516-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCXtfDyUSdoaTNOBw--.62835S5 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZF1fWw17JryxuF1DuryUZFb_yoW8GF1UpF WqkFWxJrZ5AF1UCFnruF1qkrn0va1DZr47J342ga47Z342yr1vq395Crnxtr1kAFW2gF1U Cay3trs5CrW5XrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U1pBhUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/1tbiOgdPo2gnTU2UZQAAsv Content-Type: text/plain; charset="utf-8" Clean up the driver by removing unnecessary header includes (e.g., , ) that are no longer referenced after refactoring. This improves code readability and build efficiency. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Manivannan Sadhasivam --- drivers/pci/controller/pcie-rockchip-host.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 209eb94ece1b..ba360ed62afa 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -12,26 +12,17 @@ */ =20 #include -#include -#include #include -#include #include #include #include #include #include -#include -#include #include #include #include -#include -#include #include #include -#include -#include =20 #include "../pci.h" #include "pcie-rockchip.h" --=20 2.25.1