From nobody Mon Dec 15 23:27:41 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B3823816B; Fri, 16 May 2025 11:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747394763; cv=none; b=tssb/yS+ogko6X1qqAWwfcEYPWOZFR5/d69MnOlRj1zO2DXzVsLwwDuTb/fPWAFditG0TVzImq98zedDV/EVc7uF0B8h83jW/iq9cTjiTTrfQ1jR3Dd7TcAUqLNui/uPX9Z7QpcRDNBoOneK60yG69C0qL7WFjfEeJysn9nRidI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747394763; c=relaxed/simple; bh=So2gG7QcCwBeFlnjr1ntJgcFQt5U/NoPavduZCJOHsc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Xk0R4IpOx9hsSt5ywKIo7yOjKvsa0sMJhKUOs26j9AFb7BbKU6zbiUNQ1wve5mj+H7JKjvTM/A/4tt3zTS+gdylHpMemJ4eNPLWXL+HDvgjjkfudkdaBeCZs4Mj9YyuppR03k4yXj2cOrYoEs7FZ4+SRDXARkmOLkU5MMjY4nMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E6AMSPQ/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E6AMSPQ/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE2FAC4CEF1; Fri, 16 May 2025 11:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747394762; bh=So2gG7QcCwBeFlnjr1ntJgcFQt5U/NoPavduZCJOHsc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=E6AMSPQ/vB6VlIrTqQlpQr/nb3B+IReAJvy7OKGMKOiyNualnuZ15bqRd60MGCvo3 Mv0QsxsC5A/eIDFGjJkmyGwbhKTO3xDHFLEJb9b/uRMYdVuvTKGCcGxzHu3xMz5Chs NUyipLdZmOYK0EGs7uJaEwQIvUNR5X68nTr5RgYisQix3lZuFpP/uj489N/vuMv5QZ a3xAiyx8fDuBicIlzAwDTBN5BycXl2GfOsYmYcWL5Ntnlax2VkWnm32qkFUAROYV42 wh15nJfMW6VSB3+zDxuoYXRA/7sgAqAKAgviNnyD3oCi1BlR3Hmh0jWOOVHoIj2p8t wGQGhfKDD8IBg== From: Christian Brauner Date: Fri, 16 May 2025 13:25:30 +0200 Subject: [PATCH v8 3/9] coredump: reflow dump helpers a little Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250516-work-coredump-socket-v8-3-664f3caf2516@kernel.org> References: <20250516-work-coredump-socket-v8-0-664f3caf2516@kernel.org> In-Reply-To: <20250516-work-coredump-socket-v8-0-664f3caf2516@kernel.org> To: linux-fsdevel@vger.kernel.org, Jann Horn , Daniel Borkmann , Kuniyuki Iwashima Cc: Eric Dumazet , Oleg Nesterov , "David S. Miller" , Alexander Viro , Daan De Meyer , David Rheinsberg , Jakub Kicinski , Jan Kara , Lennart Poettering , Luca Boccassi , Mike Yuan , Paolo Abeni , Simon Horman , =?utf-8?q?Zbigniew_J=C4=99drzejewski-Szmek?= , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, Christian Brauner , Alexander Mikhalitsyn X-Mailer: b4 0.15-dev-6f78e X-Developer-Signature: v=1; a=openpgp-sha256; l=1646; i=brauner@kernel.org; h=from:subject:message-id; bh=So2gG7QcCwBeFlnjr1ntJgcFQt5U/NoPavduZCJOHsc=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWSoK2xN95rx8qYg4z9BXb9kH20LYesbUj+nPey1XOlg+ q6n6JF3RykLgxgXg6yYIotDu0m43HKeis1GmRowc1iZQIYwcHEKwEQs1Bj+F3/+V3h7T1xxo7D7 hxNsk16dyPPmKvzl5bBTtyhzvds8NobfLGc0fy3tS+94La59YMX3yCW5nOuq+04UJsmz3/qtban FDQA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 They look rather messy right now. Acked-by: Luca Boccassi Reviewed-by: Jann Horn Reviewed-by: Alexander Mikhalitsyn Signed-off-by: Christian Brauner --- fs/coredump.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/fs/coredump.c b/fs/coredump.c index 47c811d32028..4b9ea455a59c 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -864,10 +864,9 @@ static int __dump_emit(struct coredump_params *cprm, c= onst void *addr, int nr) struct file *file =3D cprm->file; loff_t pos =3D file->f_pos; ssize_t n; + if (cprm->written + nr > cprm->limit) return 0; - - if (dump_interrupted()) return 0; n =3D __kernel_write(file, addr, nr, &pos); @@ -884,20 +883,21 @@ static int __dump_skip(struct coredump_params *cprm, = size_t nr) { static char zeroes[PAGE_SIZE]; struct file *file =3D cprm->file; + if (file->f_mode & FMODE_LSEEK) { - if (dump_interrupted() || - vfs_llseek(file, nr, SEEK_CUR) < 0) + if (dump_interrupted() || vfs_llseek(file, nr, SEEK_CUR) < 0) return 0; cprm->pos +=3D nr; return 1; - } else { - while (nr > PAGE_SIZE) { - if (!__dump_emit(cprm, zeroes, PAGE_SIZE)) - return 0; - nr -=3D PAGE_SIZE; - } - return __dump_emit(cprm, zeroes, nr); } + + while (nr > PAGE_SIZE) { + if (!__dump_emit(cprm, zeroes, PAGE_SIZE)) + return 0; + nr -=3D PAGE_SIZE; + } + + return __dump_emit(cprm, zeroes, nr); } =20 int dump_emit(struct coredump_params *cprm, const void *addr, int nr) --=20 2.47.2