From nobody Fri Dec 19 21:58:35 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC0A423E34F; Fri, 16 May 2025 12:36:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747398971; cv=none; b=GtVBpY4OEu+xjngNGhnfb9JpeZiSEpB5wz0nfS4Az9ue+vB0V91jcw9fxnezRGHlbzm5zgn0gdUsIN/VUj8sHhxRErASVEfvNXtU5lbdz29r7+KQcDEhHTIP3oCmXJll1Xg7Cabpje68ZZ9/Hk0fxRXiXGEbJzIzDQZUGH2r1SM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747398971; c=relaxed/simple; bh=JWoWSWI2iFDqq31hCJJ8HrX1GSFoCvibN7mj9LxkFS0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VYVfcBfxWSOmZndlvQvRYKu/oyXey5G74F64sSXdFVGU2NJxz3LCqHWGfJGfwa7pLOj1c4xksMN9vS7ia8JHxVkG/gg99LSt4H/GIOpoJvGN842wXPuM8llVEWv7CawjHuaGotATJb4Prns+XOKy0/IwIKYDKZBwE6TEAzJjZ1E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IiQ1cDHZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IiQ1cDHZ" Received: by smtp.kernel.org (Postfix) with ESMTPS id 5A7EDC4CEED; Fri, 16 May 2025 12:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747398970; bh=JWoWSWI2iFDqq31hCJJ8HrX1GSFoCvibN7mj9LxkFS0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=IiQ1cDHZbFjKJUyX8gXRWhq8zaa5TuQa6fJPmlKtYlungIBLP2uvjy1pJoilTjkEp jo+sypM3RkEUzfKnGIXChFNwGAz9yPan9TtO529WU+X6sGir4W4Jvfy+DLY0vcirIj R9JcAVyWQ6VmPs9v4kFYhiIODSWYar6KvdJ4cgjtqNO0VOgyKfCiyekqOm4R8XKCAp vaMst+lC11VA/OKn5VW/pbVg0VJxLk5DXy6c+jUEQH5JZlPp0qPc6k5/Ax8s0YlVLo yIXvtE5kWuvd5YOqLcwZQIzTcVEuz/jovGYydaylJHyxYnSGmLO7vfa8JpdlSaK8aQ 0r5Usd2TQUP6A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474C9C3ABD8; Fri, 16 May 2025 12:36:10 +0000 (UTC) From: George Moussalem via B4 Relay Date: Fri, 16 May 2025 16:36:08 +0400 Subject: [PATCH v4 1/5] clk: qcom: ipq5018: keep XO clock always on Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250516-ipq5018-cmn-pll-v4-1-389a6b30e504@outlook.com> References: <20250516-ipq5018-cmn-pll-v4-0-389a6b30e504@outlook.com> In-Reply-To: <20250516-ipq5018-cmn-pll-v4-0-389a6b30e504@outlook.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Luo Jie , Lee Jones , Konrad Dybcio , Arnd Bergmann Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, George Moussalem X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1747398968; l=3176; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=76iGGwYN7iao5R8Jw8ULkb9PNnmzQQ/WRzYbsqPI52M=; b=JWejKyFJlKcW3HeECybz+Ts56u28T+SVQOi5IdHrfuZ4/Nrcj6l4Kte/SMbl2bqIbGQIsaakQ SgQptU03TkuA1gFNPWB+H2rQcC1XkMPnxuFRH0qNQ0x/C2t6LkRqQqK X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem The XO clock must not be disabled to avoid the kernel trying to disable the it. As such, keep the XO clock always on by flagging it as critical. Signed-off-by: George Moussalem Reviewed-by: Konrad Dybcio --- The kernel will panic when parenting it under the CMN PLL reference clock and the below message will appear in the kernel logs. [ 0.916515] ------------[ cut here ]------------ [ 0.918890] gcc_xo_clk_src status stuck at 'on' [ 0.918944] WARNING: CPU: 0 PID: 8 at drivers/clk/qcom/clk-branch.c:86 c= lk_branch_wait+0x114/0x124 [ 0.927926] Modules linked in: [ 0.936945] CPU: 0 PID: 8 Comm: kworker/0:0 Not tainted 6.6.74 #0 [ 0.939982] Hardware name: Linksys MX2000 (DT) [ 0.946151] Workqueue: pm pm_runtime_work [ 0.950489] pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE= =3D--) [ 0.954566] pc : clk_branch_wait+0x114/0x124 [ 0.961335] lr : clk_branch_wait+0x114/0x124 [ 0.965849] sp : ffffffc08181bb50 [ 0.970101] x29: ffffffc08181bb50 x28: 0000000000000000 x27: 61c8864680b= 583eb [ 0.973317] x26: ffffff801fec2168 x25: ffffff800000abc0 x24: 00000000000= 00002 [ 0.980437] x23: ffffffc0809f6fd8 x22: 0000000000000000 x21: ffffffc0804= 4193c [ 0.985276] loop: module loaded [ 0.987554] x20: 0000000000000000 x19: ffffffc081749278 x18: 00000000000= 0007c [ 0.987573] x17: 0000000091706274 x16: 000000001985c4f7 x15: ffffffc0816= bbdf0 [ 0.987587] x14: 0000000000000174 x13: 000000000000007c x12: 00000000fff= fffea [ 0.987601] x11: 00000000ffffefff x10: ffffffc081713df0 x9 : ffffffc0816= bbd98 [ 0.987615] x8 : 0000000000017fe8 x7 : c0000000ffffefff x6 : 00000000000= 57fa8 [ 1.026268] x5 : 0000000000000fff x4 : 0000000000000000 x3 : ffffffc0818= 1b950 [ 1.033385] x2 : ffffffc0816bbd30 x1 : ffffffc0816bbd30 x0 : 00000000000= 00023 [ 1.040507] Call trace: [ 1.047618] clk_branch_wait+0x114/0x124 [ 1.049875] clk_branch2_disable+0x2c/0x3c [ 1.054043] clk_core_disable+0x60/0xac [ 1.057948] clk_core_disable+0x68/0xac [ 1.061681] clk_disable+0x30/0x4c [ 1.065499] pm_clk_suspend+0xd4/0xfc [ 1.068971] pm_generic_runtime_suspend+0x2c/0x44 [ 1.072705] __rpm_callback+0x40/0x1bc [ 1.077392] rpm_callback+0x6c/0x78 [ 1.081038] rpm_suspend+0xf0/0x5c0 [ 1.084423] pm_runtime_work+0xf0/0xfc [ 1.087895] process_one_work+0x17c/0x2f8 [ 1.091716] worker_thread+0x2e8/0x4d4 [ 1.095795] kthread+0xdc/0xe0 [ 1.099440] ret_from_fork+0x10/0x20 [ 1.102480] ---[ end trace 0000000000000000 ]--- --- drivers/clk/qcom/gcc-ipq5018.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-ipq5018.c b/drivers/clk/qcom/gcc-ipq5018.c index 70f5dcb96700f55da1fb19fc893d22350a7e63bf..24eb4c40da63462077ee2e5714e= 838aa30ced2e3 100644 --- a/drivers/clk/qcom/gcc-ipq5018.c +++ b/drivers/clk/qcom/gcc-ipq5018.c @@ -1371,7 +1371,7 @@ static struct clk_branch gcc_xo_clk =3D { &gcc_xo_clk_src.clkr.hw, }, .num_parents =3D 1, - .flags =3D CLK_SET_RATE_PARENT, + .flags =3D CLK_SET_RATE_PARENT | CLK_IS_CRITICAL, .ops =3D &clk_branch2_ops, }, }, --=20 2.49.0