From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5A0728314C; Wed, 14 May 2025 15:14:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235686; cv=none; b=a/8UnEOszOHXniaFOLAt7Dy7e2r1QWghV82PjV7TNq63352bK/O/jMbwL+hl+1wWngtgtHWraiOnZZZQxYBnXnh+w+QYHuTEJ2a3qDGn6v5vlsedr+W5jjME7jK8aJBbLToiAiN7x0h/unPlO+EuQu7X6Yh/g3FKyV4CI4AlRU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235686; c=relaxed/simple; bh=t6/LBgg+1aMJsZFJL58x9sXMIDVKAcDStYgCa68l14o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F/Lf2mD9yvFFJ/HHZry7hNRD9QCqFcXJgGHGjxg9JNkV6B9PPqa9BQ5P6i62UwAm/ESQz52Uc98trwZUqmP+yAaNvQ6cQahuWc0ci0uAqye54grPiGm89PO2zO4uT7W0+uv15yoE3TZYn9SYdLNVTaggAtyMOzpaI3219YJgc2Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Du1xuYlY; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Du1xuYlY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235685; x=1778771685; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=t6/LBgg+1aMJsZFJL58x9sXMIDVKAcDStYgCa68l14o=; b=Du1xuYlYFNohsp2Ijx7Mxy2bEoSX8UGO8yiRhEHcifEni6NPPWyVdle5 XEBd3AcNaXZw+yHmHJCC4mLKox2Ytbx/mF9rMnz7VT7qNkE8KD2tk6x3S 1QSrUqBAhT2gEdBOEFX/6BrPGhCBzaISrxjnA24bbk25lveqmPOjgvuFl 4B578X/h8S10gP4z0FINVn8Nfu/6Bywoao0MgVsIyt1l7vdVC+zMVC6Hc aldNnCAyfQ41UqkeCYFWZPtK9ssdorpKcNAfvY4TSJ9Iptd2EbaFFu73E VQ9lnjrusIujQ9Pu8lhG/yNUFhrqBNkqGMyrhD0VweZvcTcllT8P/jNVY A==; X-CSE-ConnectionGUID: +IQBdefzQJejHq0azXge3Q== X-CSE-MsgGUID: ElBzWMqIQI+JjbQeu6Y4fA== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072705" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072705" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:43 -0700 X-CSE-ConnectionGUID: FEOF1dHnR6CPlhZtRQDy0g== X-CSE-MsgGUID: dztFy6CMTf6z/e3GuJlvUg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939153" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:42 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang Subject: [PATCH V2 01/15] perf: Fix the throttle logic for a group Date: Wed, 14 May 2025 08:13:47 -0700 Message-Id: <20250514151401.2547932-2-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The current throttle logic doesn't work well with a group, e.g., the following sampling-read case. $ perf record -e "{cycles,cycles}:S" ... $ perf report -D | grep THROTTLE | tail -2 THROTTLE events: 426 ( 9.0%) UNTHROTTLE events: 425 ( 9.0%) $ perf report -D | grep PERF_RECORD_SAMPLE -a4 | tail -n 5 0 1020120874009167 0x74970 [0x68]: PERF_RECORD_SAMPLE(IP, 0x1): ... sample_read: .... group nr 2 ..... id 0000000000000327, value 000000000cbb993a, lost 0 ..... id 0000000000000328, value 00000002211c26df, lost 0 The second cycles event has a much larger value than the first cycles event in the same group. The current throttle logic in the generic code only logs the THROTTLE event. It relies on the specific driver implementation to disable events. For all ARCHs, the implementation is similar. Only the event is disabled, rather than the group. The logic to disable the group should be generic for all ARCHs. Add the logic in the generic code. The following patch will remove the buggy driver-specific implementation. The throttle only happens when an event is overflowed. Stop the entire group when any event in the group triggers the throttle. The MAX_INTERRUPTS is set to all throttle events. The unthrottled could happen in 3 places. - event/group sched. All events in the group are scheduled one by one. All of them will be unthrottled eventually. Nothing needs to be changed. - The perf_adjust_freq_unthr_events for each tick. Needs to restart the group altogether. - The __perf_event_period(). The whole group needs to be restarted altogether as well. With the fix, $ sudo perf report -D | grep PERF_RECORD_SAMPLE -a4 | tail -n 5 0 3573470770332 0x12f5f8 [0x70]: PERF_RECORD_SAMPLE(IP, 0x2): ... sample_read: .... group nr 2 ..... id 0000000000000a28, value 00000004fd3dfd8f, lost 0 ..... id 0000000000000a29, value 00000004fd3dfd8f, lost 0 Suggested-by: Peter Zijlstra (Intel) Signed-off-by: Kan Liang --- Changes since V1: - Apply the suggested throttle/unthrottle functions from Peter. The MAX_INTERRUPTS and throttle logs are applied to all events. - Update the description and comments accordingly kernel/events/core.c | 58 +++++++++++++++++++++++++++++++++----------- 1 file changed, 44 insertions(+), 14 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index a84abc2b7f20..a270fcda766d 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -2734,6 +2734,39 @@ void perf_event_disable_inatomic(struct perf_event *= event) static void perf_log_throttle(struct perf_event *event, int enable); static void perf_log_itrace_start(struct perf_event *event); =20 +static void perf_event_unthrottle(struct perf_event *event, bool start) +{ + event->hw.interrupts =3D 0; + if (start) + event->pmu->start(event, 0); + perf_log_throttle(event, 1); +} + +static void perf_event_throttle(struct perf_event *event) +{ + event->pmu->stop(event, 0); + event->hw.interrupts =3D MAX_INTERRUPTS; + perf_log_throttle(event, 0); +} + +static void perf_event_unthrottle_group(struct perf_event *event, bool sta= rt) +{ + struct perf_event *sibling, *leader =3D event->group_leader; + + perf_event_unthrottle(leader, leader !=3D event || start); + for_each_sibling_event(sibling, leader) + perf_event_unthrottle(sibling, sibling !=3D event || start); +} + +static void perf_event_throttle_group(struct perf_event *event) +{ + struct perf_event *sibling, *leader =3D event->group_leader; + + perf_event_throttle(leader); + for_each_sibling_event(sibling, leader) + perf_event_throttle(sibling); +} + static int event_sched_in(struct perf_event *event, struct perf_event_context *ctx) { @@ -4389,10 +4422,8 @@ static void perf_adjust_freq_unthr_events(struct lis= t_head *event_list) hwc =3D &event->hw; =20 if (hwc->interrupts =3D=3D MAX_INTERRUPTS) { - hwc->interrupts =3D 0; - perf_log_throttle(event, 1); - if (!event->attr.freq || !event->attr.sample_freq) - event->pmu->start(event, 0); + perf_event_unthrottle_group(event, + !event->attr.freq || !event->attr.sample_freq); } =20 if (!event->attr.freq || !event->attr.sample_freq) @@ -6421,14 +6452,6 @@ static void __perf_event_period(struct perf_event *e= vent, active =3D (event->state =3D=3D PERF_EVENT_STATE_ACTIVE); if (active) { perf_pmu_disable(event->pmu); - /* - * We could be throttled; unthrottle now to avoid the tick - * trying to unthrottle while we already re-started the event. - */ - if (event->hw.interrupts =3D=3D MAX_INTERRUPTS) { - event->hw.interrupts =3D 0; - perf_log_throttle(event, 1); - } event->pmu->stop(event, PERF_EF_UPDATE); } =20 @@ -6436,6 +6459,14 @@ static void __perf_event_period(struct perf_event *e= vent, =20 if (active) { event->pmu->start(event, PERF_EF_RELOAD); + /* + * Once the period is force-reset, the event starts immediately. + * But the event/group could be throttled. Unthrottle the + * event/group now to avoid the next tick trying to unthrottle + * while we already re-started the event/group. + */ + if (event->hw.interrupts =3D=3D MAX_INTERRUPTS) + perf_event_unthrottle_group(event, false); perf_pmu_enable(event->pmu); } } @@ -10326,8 +10357,7 @@ __perf_event_account_interrupt(struct perf_event *e= vent, int throttle) if (unlikely(throttle && hwc->interrupts >=3D max_samples_per_tick)) { __this_cpu_inc(perf_throttled_count); tick_dep_set_cpu(smp_processor_id(), TICK_DEP_BIT_PERF_EVENTS); - hwc->interrupts =3D MAX_INTERRUPTS; - perf_log_throttle(event, 0); + perf_event_throttle_group(event); ret =3D 1; } =20 --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B599D2820D8; Wed, 14 May 2025 15:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235686; cv=none; b=OeIv3m5jeIby+/8YrNu2njG/ZW4eLZ1PGcXX0TnN44vhHB4qYCbWHvFGn/vjG0scvBVhW6P5Plf4kyC5d2+xc1gp0HlmZzszZr/16CGB3BEw/6pP9dpiVsUQw/FeTHPeQPguYEfabfzusIpDX9ZpE7ImID1RHfPOts5TV8Jy1JY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235686; c=relaxed/simple; bh=25j5vFEsBU7YPCN2sAyzRM/ZIyTaWwct8v5PeU7SHZk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dt9AorTniY3/b4ne5zROL5vCzcq9wOU3Lg+IsNe680ULTZIB4Ty5XaM0jgSExDQlE4W2vchv/4++6TffLo0ZEPrSE7mRLs0tfx/eSX3jm1FL1t72RtqrUxc6dyOtB/d8zpCpPqmkW/A6yBExiZ3a1jgz2EDFlc9iYRA7sUHNJ8w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=mAQHncL5; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="mAQHncL5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235685; x=1778771685; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=25j5vFEsBU7YPCN2sAyzRM/ZIyTaWwct8v5PeU7SHZk=; b=mAQHncL5CA54bDKb3p5180ZdegtaXu5+t45W3nhGH/GkCzlg/7++Ve/0 MgaNX3FDby/rgxdyQEggJkClIb6vak9Rg3ZmC9Q4jhJLHedojKk0K4clf 04xkLY74ezmyEjqLzR38GQtC6bxJoxWbCj6k6O9M6AG+lCOaQLG1sXIBN QhX0biOzRBNgSV92etZNZepwJofrxTBKVWbNaFU/aT/Fq6iWA6dSvQMza LGaajYwWROr5dEoEEZCa7351V/fb9OgAxB0tDn1lHfZN50tekIq3V74ce 2L1LJSfMSqOZ3zIdExcbQZRd2nz3LgF+CCADvncWMyvWb+xDjDVo4Ewnh w==; X-CSE-ConnectionGUID: otDhMlYyTfqAXt7hr4FchQ== X-CSE-MsgGUID: pAk7T3lqRqK1VfSafIj6rw== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072712" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072712" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:43 -0700 X-CSE-ConnectionGUID: TovYpVoQRzWcDaNRAPCPTg== X-CSE-MsgGUID: 4nl4r0ooQRmTFHYvBL0iGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939155" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:43 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang Subject: [PATCH V2 02/15] perf/x86/intel: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:48 -0700 Message-Id: <20250514151401.2547932-3-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang --- arch/x86/events/core.c | 3 +-- arch/x86/events/intel/core.c | 6 ++---- arch/x86/events/intel/ds.c | 7 +++---- arch/x86/events/intel/knc.c | 3 +-- arch/x86/events/intel/p4.c | 3 +-- 5 files changed, 8 insertions(+), 14 deletions(-) diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c index 186e31cd0c14..8a2f73333a50 100644 --- a/arch/x86/events/core.c +++ b/arch/x86/events/core.c @@ -1730,8 +1730,7 @@ int x86_pmu_handle_irq(struct pt_regs *regs) =20 perf_sample_save_brstack(&data, event, &cpuc->lbr_stack, NULL); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 if (handled) diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c index b7562d66c6ea..a8309a67693e 100644 --- a/arch/x86/events/intel/core.c +++ b/arch/x86/events/intel/core.c @@ -3138,8 +3138,7 @@ static void x86_pmu_handle_guest_pebs(struct pt_regs = *regs, continue; =20 perf_sample_data_init(data, 0, event->hw.last_period); - if (perf_event_overflow(event, data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, data, regs); =20 /* Inject one fake event is enough. */ break; @@ -3282,8 +3281,7 @@ static int handle_pmi_common(struct pt_regs *regs, u6= 4 status) if (has_branch_stack(event)) intel_pmu_lbr_save_brstack(&data, cpuc, event); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 return handled; diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c index 58c054fa56b5..f8610f7196f0 100644 --- a/arch/x86/events/intel/ds.c +++ b/arch/x86/events/intel/ds.c @@ -2368,8 +2368,7 @@ __intel_pmu_pebs_last_event(struct perf_event *event, * All but the last records are processed. * The last one is left to be able to call the overflow handler. */ - if (perf_event_overflow(event, data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, data, regs); } =20 if (hwc->flags & PERF_X86_EVENT_AUTO_RELOAD) { @@ -2597,8 +2596,8 @@ static void intel_pmu_drain_pebs_nhm(struct pt_regs *= iregs, struct perf_sample_d if (error[bit]) { perf_log_lost_samples(event, error[bit]); =20 - if (iregs && perf_event_account_interrupt(event)) - x86_pmu_stop(event, 0); + if (iregs) + perf_event_account_interrupt(event); } =20 if (counts[bit]) { diff --git a/arch/x86/events/intel/knc.c b/arch/x86/events/intel/knc.c index 3e8ec049b46d..384589168c1a 100644 --- a/arch/x86/events/intel/knc.c +++ b/arch/x86/events/intel/knc.c @@ -254,8 +254,7 @@ static int knc_pmu_handle_irq(struct pt_regs *regs) =20 perf_sample_data_init(&data, 0, last_period); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/arch/x86/events/intel/p4.c b/arch/x86/events/intel/p4.c index c85a9fc44355..126d5ae264cb 100644 --- a/arch/x86/events/intel/p4.c +++ b/arch/x86/events/intel/p4.c @@ -1072,8 +1072,7 @@ static int p4_pmu_handle_irq(struct pt_regs *regs) continue; =20 =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 if (handled) --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D1EF2749F1; Wed, 14 May 2025 15:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235687; cv=none; b=A6dwk5WSE2ftSE9E1kZY7wlHQ6+u71+c5asqLzqyobbRoNjMDnJAqyPkoAV3prH+OU5IAxVoBlQxT904F3rQpfrl5a9W25q89U0joTpXUFfWLOJVI9PcFu+U9QSqSI0wfapuK0H+zZunwU1sQDtmC2kUjJ9fSkPFUZEtIxyvVSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235687; c=relaxed/simple; bh=0hRB1IvQlzGriWaTL732AEH9Fmh4KKnhaup08Q0Jp/4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BRwih52cce0q5dSr0Q+IpznmmaCXxMLigAsSAdhhnU5uGOZwnpUULMinsr/3Ebx4lwNiB6TgVi9YT0IGizyYJplmri7bN7/LsXIpGI3ac9WJUIthwpKqD5wEjiuGe2yiddiO136tcckB9Q4Pcg8AMr+FshK8FSIjytPyFHI9E1E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=L4KNQBKD; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="L4KNQBKD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235686; x=1778771686; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0hRB1IvQlzGriWaTL732AEH9Fmh4KKnhaup08Q0Jp/4=; b=L4KNQBKDlXrM8wvYhKpFmv7GOCCxTzhBCo28I5z5RxVA+4bZz+0qr3am NLjbIpe8Fbd+VGWxqx7Nb+c74oDUFSizz8Pcto5wghblVxax+Uvfarlin 1V87syDJI0/9fEcpHn07M9C96eSoGSLH+oHlW+f/CxpdxWlQ66rAM+MH5 zOMyeQoIaawhyR+YjIspcKGp26ukMpkoHutMZ75/HMynnf9708oQkletw o8solHDhmQo34WPcUuV53vxRLM3cTCQtyZuNdGRo5lQDs/fHcXf7hwBpZ yBms+T5wJSAZIsMz5q8INrf0UxSLlZ5MVgtZSnj5P+xJvM0l6C47SVH2G w==; X-CSE-ConnectionGUID: rXFmLqM6Sjm7Zj30fWl68g== X-CSE-MsgGUID: J/I3yQiuRVKndNd6kN6bkg== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072719" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072719" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:43 -0700 X-CSE-ConnectionGUID: ZwAYKfp0R7mD55WQIr3nOA== X-CSE-MsgGUID: UlfTyqo8Qkitcobp/Y9ixA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939161" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:43 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Ravi Bangoria , Sandipan Das Subject: [PATCH V2 03/15] perf/x86/amd: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:49 -0700 Message-Id: <20250514151401.2547932-4-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Reviewed-by: Ravi Bangoria Signed-off-by: Kan Liang Cc: Sandipan Das Cc: Ravi Bangoria --- Changes since V1: - Add Reviewed-by from Ravi arch/x86/events/amd/core.c | 3 +-- arch/x86/events/amd/ibs.c | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c index 30d6ceb4c8ad..5e64283b9bf2 100644 --- a/arch/x86/events/amd/core.c +++ b/arch/x86/events/amd/core.c @@ -1003,8 +1003,7 @@ static int amd_pmu_v2_handle_irq(struct pt_regs *regs) =20 perf_sample_save_brstack(&data, event, &cpuc->lbr_stack, NULL); =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index 0252b7ea8bca..4bbbca02aeb1 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -1373,9 +1373,7 @@ static int perf_ibs_handle_irq(struct perf_ibs *perf_= ibs, struct pt_regs *iregs) hwc->sample_period =3D perf_ibs->min_period; =20 out: - if (throttle) { - perf_ibs_stop(event, 0); - } else { + if (!throttle) { if (perf_ibs =3D=3D &perf_ibs_op) { if (ibs_caps & IBS_CAPS_OPCNTEXT) { new_config =3D period & IBS_OP_MAX_CNT_EXT_MASK; --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86DE42820C7; Wed, 14 May 2025 15:14:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235688; cv=none; b=YYbAULH1bGLvb7saYQYdRss394PnjO7KfKo3jZtDAYGVgat+FQzweHOpd+O6OVEhBezzFhNZ4uJSkzJ/lJbiB4vr1Hl0YdxqHRSur5AYx3vEHbHB48Nv3vbVnypfjvJErIuEmklLXkGTIAdqHJcw0QKZuw0zcBEb1ZVVulwIPPg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235688; c=relaxed/simple; bh=eftPXZUtS7TWj+fyRnjgJB01av2QQsqnM0j4qbjXMQk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=J0PHqPSx63MrGeHDmoF8IMEqKZLYiKN6y23PeqlOqp/qJqELehSgVyXAJNLGvmKSqqOQCmt9+YBTTcJjnn07y6G4eU6mD3YQWgpC1yIBY4hRxn7BD4PxIN0P6xgF/G99HbCOZhlzO9vH4Hcu8bzBYiqoWjVS5tZbLCnCoAahRxM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FRosZTLe; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FRosZTLe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235686; x=1778771686; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eftPXZUtS7TWj+fyRnjgJB01av2QQsqnM0j4qbjXMQk=; b=FRosZTLeiVxmFuH36Vl3u+7QBQ5Ur+X1bLYfKyGYrJngtikwZOz1raxE yxp6Yo4FbB12JDVUo2L0PbmMeJ+8R9Q9nQNTQU+5WHVuThDb7tnC4r796 X9rC6mZ7cdwXVcccIhjOa+2zFW+f1g237ewkZbyMc4uDJubrTnuQSoYrf DlUfBMpeBBHOjvNyKAUcdetsNMM49Ss8yWisaBRR9Zifyjp/5wHSFV7BE PXSvjESbbnhpGfKRtGud0+crqQyckUAtDe0iWPgGBkIdZhwo+xAxWgR6Y EN3MXx71b4gtv/exsnJgGLd8l6NxqIGn0Em1Qey6euL9bOpqS7vWU6CEd Q==; X-CSE-ConnectionGUID: 3wGaa6vEQN+FFVjTU65Gcg== X-CSE-MsgGUID: zmU2tb3OSyydU5eMN7oh4w== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072727" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072727" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:44 -0700 X-CSE-ConnectionGUID: gG+wDnInSwu+VvYjARXzXA== X-CSE-MsgGUID: LoRybGhBS4KvjBMm5+qKlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939163" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:44 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , silviazhao , CodyYao-oc Subject: [PATCH V2 04/15] perf/x86/zhaoxin: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:50 -0700 Message-Id: <20250514151401.2547932-5-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: silviazhao Cc: CodyYao-oc --- arch/x86/events/zhaoxin/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/events/zhaoxin/core.c b/arch/x86/events/zhaoxin/core.c index 2fd9b0cf9a5e..49a5944fac63 100644 --- a/arch/x86/events/zhaoxin/core.c +++ b/arch/x86/events/zhaoxin/core.c @@ -397,8 +397,7 @@ static int zhaoxin_pmu_handle_irq(struct pt_regs *regs) if (!x86_perf_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - x86_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 /* --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C72D3283FC9; Wed, 14 May 2025 15:14:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235688; cv=none; b=fprWCPioFW+J/S9tfcv/hkdn3G2Edd5rn2baCv7Vdp30v8THp8W5y0it2w/Hl3BAfPjKltg15k6lERX6o7OTP/GMwzeZMOrLZ5L/wgOi+mmmpZu7eKVhdUJvamO0R3CEFDtDoGxf3XGa/Eldndneqwu+nKHTtTO75riNIk4yvpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235688; c=relaxed/simple; bh=s+EyXjLUXo0M2dfj157AL5fvrY36sWvSBJ2tuImTWtk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SJWTGx6LqQuo19rqFBPzrkTw9z8LAYl2FoiBf7BgnFeiP/Rtk49NNNJ16xPJWASWfyQGYmALDaEfUNUwN4ffV0refsu8ZbKh1x1kSLpdxGmwMiWFuxf7++XpAQHPILL4R0MsDjcfpGgqeb7aSvj4ATRK9LkhtC5vNSEIGf2sxNI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JmPHSa8p; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JmPHSa8p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235687; x=1778771687; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=s+EyXjLUXo0M2dfj157AL5fvrY36sWvSBJ2tuImTWtk=; b=JmPHSa8pifUF7nqjUVenaAhZbECb5yUgXM4F2s1q8CiNMTk0Tk2c1CgN m2K4PkxHwGINIRqx0hfjoKN1nfZq2xqc6etfzyjUTggAMpH2o/6FzgpvM dDXlZ7QpYOKKeb1rzywQiQDCYF694rWOVYooPxgXfGDXDHEYdX4Qq68nA DcxM9zdavFtOp4TtYRhosk2kTd/DM9sQWCiDSvzzQACSH5m7T51R+Ibem nKMMFIiZq8YjddTaGlRz/4H+mTOFAarQpH5UCdvLeLTh+Zi+HXyOVVO+o q90b30rZIdhvkgI0eF8jOZ7gTcUFOyj0XP0OGOzqumQeYIVNbK67ek25f Q==; X-CSE-ConnectionGUID: iGuQkVsjSAWt8VMi6JC2yg== X-CSE-MsgGUID: VcrJcAKuSp6GtcG0Eea4kA== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072735" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072735" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:44 -0700 X-CSE-ConnectionGUID: CIB9tTiBQxeDfYbnRRxmEw== X-CSE-MsgGUID: X62WA9/KTryQTVKPFxrNVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939165" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:44 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Athira Rajeev , Madhavan Srinivasan , linuxppc-dev@lists.ozlabs.org Subject: [PATCH V2 05/15] powerpc/perf: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:51 -0700 Message-Id: <20250514151401.2547932-6-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Athira Rajeev Cc: Madhavan Srinivasan Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/perf/core-book3s.c | 6 ++---- arch/powerpc/perf/core-fsl-emb.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3= s.c index 42ff4d167acc..8b0081441f85 100644 --- a/arch/powerpc/perf/core-book3s.c +++ b/arch/powerpc/perf/core-book3s.c @@ -2344,12 +2344,10 @@ static void record_and_restart(struct perf_event *e= vent, unsigned long val, ppmu->get_mem_weight(&data.weight.full, event->attr.sample_type); data.sample_flags |=3D PERF_SAMPLE_WEIGHT_TYPE; } - if (perf_event_overflow(event, &data, regs)) - power_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } else if (period) { /* Account for interrupt in case of invalid SIAR */ - if (perf_event_account_interrupt(event)) - power_pmu_stop(event, 0); + perf_event_account_interrupt(event); } } =20 diff --git a/arch/powerpc/perf/core-fsl-emb.c b/arch/powerpc/perf/core-fsl-= emb.c index d2ffcc7021c5..7120ab20cbfe 100644 --- a/arch/powerpc/perf/core-fsl-emb.c +++ b/arch/powerpc/perf/core-fsl-emb.c @@ -635,8 +635,7 @@ static void record_and_restart(struct perf_event *event= , unsigned long val, =20 perf_sample_data_init(&data, 0, last_period); =20 - if (perf_event_overflow(event, &data, regs)) - fsl_emb_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } } =20 --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8AA0283FFA; Wed, 14 May 2025 15:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235690; cv=none; b=igpA87xSGX5n2q5hPIChZ6PU8UMtJNCvbvq8aLOVKV02Vs7AIWlc9iKsqcdPcgA1k2UKURru7oePDHquHu/P57kXKrFv9pgEMQHp0ejBePiI6eUpX8mXrdIXeKLZDm/ayOZOsNbnEECIW7ywkTdLwYB/bkLvG9owwggnyGiN1lk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235690; c=relaxed/simple; bh=L2nENQRMXr7cm7P8wvgZXQuelIQ1McOEGuf1n8wrLNc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=M24STAt0c0bsjwjPiBYA6QdrjkILkkTMfLUZGEM1Ft7dAEdfZIs3aS29Y/M/tzLsU3d+CGXaAODAvOWaQ0UKkPZf6IW8y2SD8T4PyE9hnCnTVs0pa8GRqHJ7pfovBZAdw3HvIQ9jXKPDqgmQkHKBz1pJE9NhZW13Ue4syPSd6Mo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VwUfkSAi; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VwUfkSAi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235688; x=1778771688; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=L2nENQRMXr7cm7P8wvgZXQuelIQ1McOEGuf1n8wrLNc=; b=VwUfkSAiNWGNLDIyIFrgNr1Tfe0KLo2Q8+9linaeff38XkWtNjDbjL76 Z4m02f947RrfL0egx7x8PFJbbztPLu9WT99CfKwjPrgUqU8rKR/UDnsew C9dkwW1eyl67qPDRjxBoJw5BI+5ZWg08zQgGkRgTBG11ChIeY58ME3xBf E3BydHVcm+onYRqfnQrzDXeVOKawbapR6Tgu8X5rjx9ZKals4zgCVwVCv nGyD+yo6HfBRyyujUwtTka7SLwu4phXStAyT6SWe5jPikuRXMgMZxtIyj Usm9ICWDfqzFS73YUUY6bXJLhRe52omw4MtGtzKW6jDDMlXh/rXSTGOk7 w==; X-CSE-ConnectionGUID: 9aPlbFMYTM6iOgWY1XYODw== X-CSE-MsgGUID: busp4fLUStieOAFn3xRHOQ== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072744" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072744" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:45 -0700 X-CSE-ConnectionGUID: j1d1npWEQYK184NLh4CAxQ== X-CSE-MsgGUID: gYZgcIb6QBuZVSdGR/Edug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939167" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:45 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , linux-s390@vger.kernel.org Subject: [PATCH V2 06/15] s390/perf: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:52 -0700 Message-Id: <20250514151401.2547932-7-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Thomas Richter Cc: linux-s390@vger.kernel.org Tested-by: Thomas Richter --- arch/s390/kernel/perf_cpum_cf.c | 2 -- arch/s390/kernel/perf_cpum_sf.c | 5 +---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/s390/kernel/perf_cpum_cf.c b/arch/s390/kernel/perf_cpum_c= f.c index e657fad7e376..6a262e198e35 100644 --- a/arch/s390/kernel/perf_cpum_cf.c +++ b/arch/s390/kernel/perf_cpum_cf.c @@ -980,8 +980,6 @@ static int cfdiag_push_sample(struct perf_event *event, } =20 overflow =3D perf_event_overflow(event, &data, ®s); - if (overflow) - event->pmu->stop(event, 0); =20 perf_event_update_userpage(event); return overflow; diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_s= f.c index ad22799d8a7d..91469401f2c9 100644 --- a/arch/s390/kernel/perf_cpum_sf.c +++ b/arch/s390/kernel/perf_cpum_sf.c @@ -1072,10 +1072,7 @@ static int perf_push_sample(struct perf_event *event, overflow =3D 0; if (perf_event_exclude(event, ®s, sde_regs)) goto out; - if (perf_event_overflow(event, &data, ®s)) { - overflow =3D 1; - event->pmu->stop(event, 0); - } + overflow =3D perf_event_overflow(event, &data, ®s); perf_event_update_userpage(event); out: return overflow; --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDD2628688F; Wed, 14 May 2025 15:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235691; cv=none; b=R5LE5q+kPRHU2mchYM2sBZSdf5oDZMopmznMPAi7zIO7Ckdkz+fUDEZdfVPoz1I4hfONu7D9UcnbRltunKnBkEEZ2xMPpF/u1LH73hbBYDjDuA4fER3dbxi9ahplInAwKetwCPnSGHU603XYuhWoQIGO9mcZ3QXBZGeI5v8RZRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235691; c=relaxed/simple; bh=niFjfiqBff3Sw+QM/hZYvrfOZbyI/nWGDj/epacEVR0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DXbwFP6PuNFEbiJzts+wnj8QFeiLUdLkde8/mN2B7PijqL1pXY49BoAndVFtbBmN/Q4/uTR/HFP/IXHpY/lwLVVmCIW5ojPQrFj5aHa9OZWeLdImyKg9lE50dFWJm2SyZWUEmYO/aoNGPQcIT1rB8Lp82ccVZ/jNK769Bjobl+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BVrkGIdp; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BVrkGIdp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235689; x=1778771689; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=niFjfiqBff3Sw+QM/hZYvrfOZbyI/nWGDj/epacEVR0=; b=BVrkGIdp2kf7ftXj4bXVEwphKYPKSc/FWzJdKGAJPa8uj3hdVi+M+F0u AvnBFyB/TU8lXsR0VwtjvyTWs42jUc4yH5sIXGWFg6EgcA4YSAvROUndd DZfpRUfEpmChCPtbUXHLfkmJkJDdrRbySNKQ7Isz2tum3UkuTtgzjl+51 0kVWPilOlD7cx1C285PyBjLDkp9Bwe0Y6wYyqO3sPuLL/T9tGPnwCdOBl yUzjsPwWFhOuYTiuZpCFox3pLGf+W6filbX/PYfcIRfLZHy/SsIPXeXAp fOj+EdRB9VxjbL5vPeBTaOrILAoc89d5yyOTCApvvsr8BerMLYgcoDfwp w==; X-CSE-ConnectionGUID: D7Sk/VggRpGR0k5aULcvUg== X-CSE-MsgGUID: Exf7cxoDR8WuaL5CIGgdzQ== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072751" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072751" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:45 -0700 X-CSE-ConnectionGUID: CCeHvT/ISKOJzJVwLYE/VA== X-CSE-MsgGUID: 1mvC+ajESP6F4gL4x1sOLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939170" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:45 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Rob Herring , Vincenzo Frascino , Will Deacon Subject: [PATCH V2 07/15] perf/arm: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:53 -0700 Message-Id: <20250514151401.2547932-8-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Mark Rutland Cc: Rob Herring (Arm) Cc: Vincenzo Frascino Cc: Will Deacon Tested-by: Leo Yan --- drivers/perf/arm_pmuv3.c | 3 +-- drivers/perf/arm_v6_pmu.c | 3 +-- drivers/perf/arm_v7_pmu.c | 3 +-- drivers/perf/arm_xscale_pmu.c | 6 ++---- 4 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c index e506d59654e7..3db9f4ed17e8 100644 --- a/drivers/perf/arm_pmuv3.c +++ b/drivers/perf/arm_pmuv3.c @@ -887,8 +887,7 @@ static irqreturn_t armv8pmu_handle_irq(struct arm_pmu *= cpu_pmu) * an irq_work which will be taken care of in the handling of * IPI_IRQ_WORK. */ - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } armv8pmu_start(cpu_pmu); =20 diff --git a/drivers/perf/arm_v6_pmu.c b/drivers/perf/arm_v6_pmu.c index b09615bb2bb2..7cb12c8e06c7 100644 --- a/drivers/perf/arm_v6_pmu.c +++ b/drivers/perf/arm_v6_pmu.c @@ -276,8 +276,7 @@ armv6pmu_handle_irq(struct arm_pmu *cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/drivers/perf/arm_v7_pmu.c b/drivers/perf/arm_v7_pmu.c index 17831e1920bd..a1e438101114 100644 --- a/drivers/perf/arm_v7_pmu.c +++ b/drivers/perf/arm_v7_pmu.c @@ -930,8 +930,7 @@ static irqreturn_t armv7pmu_handle_irq(struct arm_pmu *= cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 /* diff --git a/drivers/perf/arm_xscale_pmu.c b/drivers/perf/arm_xscale_pmu.c index 638fea9b1263..c2ac41dd9e19 100644 --- a/drivers/perf/arm_xscale_pmu.c +++ b/drivers/perf/arm_xscale_pmu.c @@ -186,8 +186,7 @@ xscale1pmu_handle_irq(struct arm_pmu *cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 irq_work_run(); @@ -519,8 +518,7 @@ xscale2pmu_handle_irq(struct arm_pmu *cpu_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - cpu_pmu->disable(event); + perf_event_overflow(event, &data, regs); } =20 irq_work_run(); --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE20428689C; Wed, 14 May 2025 15:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235690; cv=none; b=UNmWTmCzuht3Veixx1Mv3PaAXLNyRPbC0cND7YZrpeN3cM8ACLktGYoxU2cg12aPKdDOudpLpk2ODLtBBoQa81fDeeTqO0qJjrue+koVd1VmbhHW9ZsFOoeDtBq9APm0ybl7nHoMl+fVX/tGMmm+RBgqe8GNqKovHZuS19bU4BA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235690; c=relaxed/simple; bh=jtzi1Dswis+7E8s5xuD4Q5RcegCZpv4/8lL3qUWjHa0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=leICoVuFKNNz66Fqy1A/+qvLhXOyVpDSi13+cqLvz0c9GyrnX4gsvz4puFlcK7hokYYmhfVQyp/mo0AkRtjn0zbbLH0uLomuikCaMxA833jeT7I9YPRIfUqNut1FXOFHlFJr12cyE9cjNHZvIQgDuFju/Wb/o16dH+kJZFp2EY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IAhDzjbJ; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IAhDzjbJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235689; x=1778771689; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jtzi1Dswis+7E8s5xuD4Q5RcegCZpv4/8lL3qUWjHa0=; b=IAhDzjbJlfsKjjqTPw4QRvxLpUzo1x+8WHhQXQBUNis7ZIkwKAEl44CB x/NLR0JpDNga+UTVn+6qTDV95MsofGQY8rN9IwLe2Wsl9rNdbRwRlPKt+ LsiTXtdGTI3MXokg2E60FMFegd+kJgX7MKfCBGqj00JTUndvzp3f0CuEL VvGfuRFGXBdcLPziI5Wsg1okl18qkMuQXcUGNSKLIyLnJ0HbdWpL51jOx +h2i2bSS7LarD3mqi0tPOkVsAopa5oCiacjJdou3Br69gN63UbddIRo+B k3dWadmpamq9BqPGLrDubwQCTGbgOxq/r+XKsjQRtAssRvGoLdSf3fRp2 w==; X-CSE-ConnectionGUID: qYIT3d0zTTGYBKQI8zJajQ== X-CSE-MsgGUID: xrSx1r5eTxqjXAWCd3Pzqw== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072758" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072758" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:46 -0700 X-CSE-ConnectionGUID: b9U4YqtdR0+x9gn5tnQ9/Q== X-CSE-MsgGUID: BgFcYL/QQCa57Xepg6UOjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939171" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:45 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Oliver Upton Subject: [PATCH V2 08/15] perf/apple_m1: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:54 -0700 Message-Id: <20250514151401.2547932-9-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Oliver Upton --- drivers/perf/apple_m1_cpu_pmu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/perf/apple_m1_cpu_pmu.c b/drivers/perf/apple_m1_cpu_pm= u.c index df9a28ba69dc..81b6f1a62349 100644 --- a/drivers/perf/apple_m1_cpu_pmu.c +++ b/drivers/perf/apple_m1_cpu_pmu.c @@ -474,8 +474,7 @@ static irqreturn_t m1_pmu_handle_irq(struct arm_pmu *cp= u_pmu) if (!armpmu_event_set_period(event)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - m1_pmu_disable_event(event); + perf_event_overflow(event, &data, regs); } =20 cpu_pmu->start(cpu_pmu); --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B09282882D6; Wed, 14 May 2025 15:14:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235692; cv=none; b=UFRdDmaT6ENc0wq1OnewGw9HaaWnFkJueIPmZKhia3ANo0AVDO/v+08U2m62Ks9nJUVbn0FI6TXc/SBHcVo4H4l4dL/IPZRSCWEWPsBtSYBQZA1mfZeYRUZ+4lFnYl3ugh0LElgJV2fGl4SmIjOTXb4xokHqYNU6TIgzZT9TqQI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235692; c=relaxed/simple; bh=NhpvDIFF3RCGCMgFlua6GwCE5WabCIdXhqFSclRzhlI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Z7fLj/lw0BwFZamsKJlFrY7hoWQTjtinPMOjxDs5LzrKZeKrg+RZzhx9+XEFKncxHAQkKWoS1AqB0HeoMA4K7eBD1LrlTZ5kHMOQq/4Hpqu7UpyWaN96FNHRkK5cLVJJP3wSbx6Fe8AUDMHFIJjvfDT+Yrc6I9MOZHoav+isxoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Snfak2FR; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Snfak2FR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235691; x=1778771691; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NhpvDIFF3RCGCMgFlua6GwCE5WabCIdXhqFSclRzhlI=; b=Snfak2FRQTTNEv02yZuXd9UI0Rnov3u8vn40QYa9crEgQlPeTsxcOt4D FYz03DTBuWT9vzVbHRY3ctypNUc6pwt/RTcBjs7br0QT/cY9L4B5Clij2 nbxJhCAF4RrJ/SCwdVQzFyh1QtFAk2fvRygFUHxm2UMwvF1mvOPae5Xxw 5pMt/AoirExAGhAjwrXLWCNjC/uSoVBMu38vKdBMHjVGiEeBz/+KJ8IzT xJA7YicXivuynRjCnil68LBNpUl9t0+iRsywzVdKq/YkrvbOpDCmF87Pa vMnWW9A5ItYipioFSpw29sNTj+Vw1+3lkAhNWrhYNqaBr9j4BpAeypqar w==; X-CSE-ConnectionGUID: rxRJj5EgRy6AzG7fUlzwIA== X-CSE-MsgGUID: dbC7JQHiRR2SVNahh+Uw9w== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072766" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072766" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:46 -0700 X-CSE-ConnectionGUID: Z7MrihvETrqWO9x0Bqm68Q== X-CSE-MsgGUID: mwVaS7OrS2eDOd8QyPEg6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939173" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:46 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , linux-alpha@vger.kernel.org Subject: [PATCH V2 09/15] alpha/perf: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:55 -0700 Message-Id: <20250514151401.2547932-10-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: linux-alpha@vger.kernel.org --- arch/alpha/kernel/perf_event.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/alpha/kernel/perf_event.c b/arch/alpha/kernel/perf_event.c index 1f0eb4f25c0f..a3eaab094ece 100644 --- a/arch/alpha/kernel/perf_event.c +++ b/arch/alpha/kernel/perf_event.c @@ -852,14 +852,9 @@ static void alpha_perf_event_irq_handler(unsigned long= la_ptr, alpha_perf_event_update(event, hwc, idx, alpha_pmu->pmc_max_period[idx]+1= ); perf_sample_data_init(&data, 0, hwc->last_period); =20 - if (alpha_perf_event_set_period(event, hwc, idx)) { - if (perf_event_overflow(event, &data, regs)) { - /* Interrupts coming too quickly; "throttle" the - * counter, i.e., disable it for a little while. - */ - alpha_pmu_stop(event, 0); - } - } + if (alpha_perf_event_set_period(event, hwc, idx)) + perf_event_overflow(event, &data, regs); + wrperfmon(PERFMON_CMD_ENABLE, cpuc->idx_mask); =20 return; --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D424128850A; Wed, 14 May 2025 15:14:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235692; cv=none; b=jF04u2u/lhZGtMSHFjKyGAhDBxEicuTVB+ZD46lOS67eWxLN3l6SdLnk9iDJzo7hTQvNds/LZBOF4sBH7WUdE8IrC1Z+Fes50b3ijgKrdzFE/ZbrrI34elboUmSrfJ1qs5Sp02JAGINnJ+H8M1ZPDy/+1MuyIFbdx1EwtpVPD34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235692; c=relaxed/simple; bh=F4Te9Lur/xFSTBMdpmhCbCj26jVQpoawEm3xShr4VJE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NEWQJRqs9PpHt9iOOZWtwpNX/HQpng7DUrdkXuFxDBf8orTwdt2rnGMkkvCK9D13EGY5nhpL3dSoXdW5EcwNHn+Pt6bfFyQCfrpyl0jM3jRYQQv5hpoAZPQp4k50404XNfKnOAKhG+rEMEqTLCqAlM3xscol5Zc9zCFIswUa5SE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GHVWe1sM; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GHVWe1sM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235691; x=1778771691; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=F4Te9Lur/xFSTBMdpmhCbCj26jVQpoawEm3xShr4VJE=; b=GHVWe1sMv7Qj8jO2fAqivp+1jeDL2/PEw2BB5MDZlcHCJg9zgEVXbtgI u3WPIT7MnM9X5Qg0Ipns/f4Z4WqB38qpsMEl1HqQ9nlRbqztXoA4oZN/h ilBHGQl/PhY0v9Z5fgPLtQFEHouQlkQSNDVIQspcpTqkQM9dVGH4rUBh4 IJvmpLgQko092pRWL/IDDPRreTXCoAk0XyZoejrYDZ2s3zeDVtWVBISWj i+SEUht6rAfioNHLi3jap3Tf/RKxmyS9LzGRAzpNsiElxfABepU5MJ6K2 Y5D9j3CbrMsw8nFGO1+DA+w3rtJ0QW8skThp6xSO7RcjvHYSFHLdrVd0e Q==; X-CSE-ConnectionGUID: mvJaTH+4RkigJDLk8rZSNA== X-CSE-MsgGUID: JXn+umZ8RZynA76hCEkyyA== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072773" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072773" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:46 -0700 X-CSE-ConnectionGUID: ZPSRUvmATVmhHNzzC6m1BA== X-CSE-MsgGUID: vN5sn9IBR5Ke/vVIvDfstQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939174" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:46 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Vineet Gupta , linux-snps-arc@lists.infradead.org Subject: [PATCH V2 10/15] arc/perf: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:56 -0700 Message-Id: <20250514151401.2547932-11-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Vineet Gupta Cc: linux-snps-arc@lists.infradead.org --- arch/arc/kernel/perf_event.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c index 6e5a651cd75c..ed6d4f0cd621 100644 --- a/arch/arc/kernel/perf_event.c +++ b/arch/arc/kernel/perf_event.c @@ -599,10 +599,8 @@ static irqreturn_t arc_pmu_intr(int irq, void *dev) =20 arc_perf_event_update(event, &event->hw, event->hw.idx); perf_sample_data_init(&data, 0, hwc->last_period); - if (arc_pmu_event_set_period(event)) { - if (perf_event_overflow(event, &data, regs)) - arc_pmu_stop(event, 0); - } + if (arc_pmu_event_set_period(event)) + perf_event_overflow(event, &data, regs); =20 active_ints &=3D ~BIT(idx); } while (active_ints); --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 795702749F1; Wed, 14 May 2025 15:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235693; cv=none; b=ayL1G2ifggn/E/mfaSO+Em09P4OFl3B99RfQWn9lCss2m/iAXmnXR4qwQcPEAVJXVfv0JgQGy3+hLr3lOeuVw9do8rmSYXFL3N4Qrl4wVM9S9QCWYceuEj+L/qxfUyKehQ32Nc2ZVMpsS1rrupAHV+qGSRjpIjlGUIBOA50jlqs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235693; c=relaxed/simple; bh=UsduOhasYm/HfIIj9WN3RQZEbqTT0MBS3lHLGt9ZIsE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZVnT18/aEBfPiwoM3Fs7/okANg05bBtVN/xWnobiAK9FwslCAw+JjqYuK0nvjZVcNiMgJc3Iy1cUGGABsYFv1Wucv4lZl0ORV2GuDyjynMWg9PXMhBWF7OcOYQZdVCWVNuxdoh4F30zQzbRTMoiR2Z2eFRRoIDKAr/pMFt9BceE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IT4W/YU8; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IT4W/YU8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235691; x=1778771691; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UsduOhasYm/HfIIj9WN3RQZEbqTT0MBS3lHLGt9ZIsE=; b=IT4W/YU81HnNynSQ6sbg/u9hROl17aQAl+wjUWzEBO0E3YtnYNH+iJjH v0vOF6kBn2DPfwHY+yQN7mBWElNBZeXGZFOyA3V/CVKGeafYqhbRZpAS2 lR1z3O5N1XnFARNnnPVXT0T+jyaDQEe1kcuslzqsdK6A2Hyae9eN2SQ94 47tC8IypOXBfTwY6eEBKfqtT7kAiTjpvxotzwpSi8bHh80IZsYyNqrWZX kzUhzUYDb2HQTPFsbofY+FwlicnpRYmo952p25KKvjeBf3FE/yI33JOjh 9Q3BB1S3266mU+L391RPx7QtuqTfr8Hsy3sn5CJ2BqtBpHXrgtdRVf0Rp A==; X-CSE-ConnectionGUID: fOJn6xEaTZ+PBbySguwSbA== X-CSE-MsgGUID: WmMpWnuhTT6ECc8iGF0syQ== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072782" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072782" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:47 -0700 X-CSE-ConnectionGUID: 2sZf2b5/RXG+mXmpRA20iw== X-CSE-MsgGUID: tembz7sPSrmxQ6jxfscfVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939175" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:46 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Mao Han , Guo Ren , linux-csky@vger.kernel.org Subject: [PATCH V2 11/15] csky/perf: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:57 -0700 Message-Id: <20250514151401.2547932-12-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Mao Han Cc: Guo Ren Cc: linux-csky@vger.kernel.org Acked-by: Guo Ren --- arch/csky/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/csky/kernel/perf_event.c b/arch/csky/kernel/perf_event.c index e5f18420ce64..e0a36acd265b 100644 --- a/arch/csky/kernel/perf_event.c +++ b/arch/csky/kernel/perf_event.c @@ -1139,8 +1139,7 @@ static irqreturn_t csky_pmu_handle_irq(int irq_num, v= oid *dev) perf_sample_data_init(&data, 0, hwc->last_period); csky_pmu_event_set_period(event); =20 - if (perf_event_overflow(event, &data, regs)) - csky_pmu_stop_event(event); + perf_event_overflow(event, &data, regs); } =20 csky_pmu_enable(&csky_pmu.pmu); --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74BB0289353; Wed, 14 May 2025 15:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235694; cv=none; b=vEXtdswVz9bIqYb/KMsCvSsQkFldZwi+ADs6YBXkEeNoUAWDQrvMipHCrEUuYs8nAAjHrcT2W1l2KIW0qakdnkcYQBaDoAY+U63JOhutMo10nHC+WOvs7NvGeg5BPeqDeb4ThS18jPKVEAcRkjhslMH3l5I3wp+wThBxaxFq9oM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235694; c=relaxed/simple; bh=dbXx+MD2QCNjSXPlgp390XJDfrTSi22QXjpUAVmjpNs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PNua/EZ0FuSCUKvFs55Md3wntf7IHDPYaUvyXwEJKZk7tzmACtKkrmIrPwLMA79nbPZVV3GCCr3SbIw3Bhtw1dIdOQI30ynRR4fCJ+aDbUbIm98JbkcVgSuxJQRkmJpuqHUn/pUG9ov6/uvLr/fS+oGbpQoPxZYAHIApbhJdrs8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FNenUiMv; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FNenUiMv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235692; x=1778771692; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dbXx+MD2QCNjSXPlgp390XJDfrTSi22QXjpUAVmjpNs=; b=FNenUiMvr9X8LSuCIzC3zDUQQ5D3SqGSeLH6mt3DccMFT/MNtAD9fYU7 G5/MoWprXhb8Ihw9QC3OuaqwyGBzRNJ2q5P6oLB6CHooWE6Tvk3A1nOuL aETR3hroytrHTRHANPi8Je/P4l2Jm4rjbOWsakZfqQXG1OiRmnLTiHGJj 9RcJULFIqcMi8/xiaIpZzn+P+jJ47VN7mTGDcIOWrnuYTNy1bsiTAZCPK uf+WoaPf4crsbhWahzwGP49U7hbCmpP8o1pFmZ/kqZrQYZ/x1mTmV3cO7 pieeRGaIA5Z4kgFda5e+PwRXj8vGgUsOKoLo5qEo83j4i31sPinTOQ1aB Q==; X-CSE-ConnectionGUID: HRUzG1TPTty5+51bV/Rqvw== X-CSE-MsgGUID: sxUyXw8PQvCyZTFFbFSCXw== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072790" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072790" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:47 -0700 X-CSE-ConnectionGUID: PnJJIKlyTqaZd4PmKT1G2Q== X-CSE-MsgGUID: xQEo3F7WS/a5yxyQ6pAJUQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939176" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:47 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Bibo Mao , Huacai Chen , loongarch@lists.linux.dev Subject: [PATCH V2 12/15] loongarch/perf: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:58 -0700 Message-Id: <20250514151401.2547932-13-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Bibo Mao Cc: Huacai Chen Cc: loongarch@lists.linux.dev --- arch/loongarch/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/loongarch/kernel/perf_event.c b/arch/loongarch/kernel/per= f_event.c index f86a4b838dd7..8ad098703488 100644 --- a/arch/loongarch/kernel/perf_event.c +++ b/arch/loongarch/kernel/perf_event.c @@ -479,8 +479,7 @@ static void handle_associated_event(struct cpu_hw_event= s *cpuc, int idx, if (!loongarch_pmu_event_set_period(event, hwc, idx)) return; =20 - if (perf_event_overflow(event, data, regs)) - loongarch_pmu_disable_event(idx); + perf_event_overflow(event, data, regs); } =20 static irqreturn_t pmu_handle_irq(int irq, void *dev) --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A90B228937E; Wed, 14 May 2025 15:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235694; cv=none; b=U0lotfXSpzFfkx6K6BEQ2qSmUdPPl5anbR4LwRnk55QvH6beprsOj17RpvENQt+jF2O/DZXVGphyDjODQHIPiCMvEl8rj77NnVBICQpKYnXkJhg25NvEARaRB8FlLuxttQPEY1JEqBYHGEWdz3hpgGA7Xa83WzZH3Nq3vQZwJBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235694; c=relaxed/simple; bh=+LerS4ypY2xtEwvIwpQb+1sereJGijuBSIcL0NVDkSQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dse12Rc5QV4kPQdb8098geBlobFay7lzw4/eBox+uUSMmN7YNGze7wkM6yB6t4Byc5pgruTMIbR8sO9o+zEpi/bDncUb5Ods/yneP40U9++Xgs40IuqkOD6uJlvYeyVYbeMbQo8jZ/xNyjbWlMZ1qs+ZOKh6CbNv+RBtcG06GFM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RxlF1gDc; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RxlF1gDc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235693; x=1778771693; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+LerS4ypY2xtEwvIwpQb+1sereJGijuBSIcL0NVDkSQ=; b=RxlF1gDcN9NR7eHqAZY2TjK/c6atlZR9vn+ONwMOxxQzC68dE3ct5B5n ntgWVYfDMGMMoywfhBOeLulk5B5AhCc5dxtqNFQI3VvhRFWXEU5e1jCxf QBu+t/f2SPJgbL80IqUiMpjxz9ZvtRcuJDnnRfAWUU5SGdV/QMQadiJ8+ 4iefnZq41jJwaS4xZswXYHbO8GOsC7gTLX5R+VIL8K6P7qUEjRN51L4gy p/vrnvGf4YEa9wEbIE3+mxSb5gisSm4o0ps2vGlU2sZPwQxWD+TOyT5zd yp6Y7+pi/dtyU5SeuH12w8YY/Nk6syEXPuUDlu6Cwmm1oAE1A55YzRKFN A==; X-CSE-ConnectionGUID: jq08k84BQyizEeluuL9Nzg== X-CSE-MsgGUID: /OrodaR2QrO7G5ON47sG2A== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072799" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072799" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:48 -0700 X-CSE-ConnectionGUID: zRdsBm7kTuerEcSZEZ412Q== X-CSE-MsgGUID: WE8p07L+SwKeBGqY14W5eg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939178" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:47 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , "David S . Miller" , sparclinux@vger.kernel.org Subject: [PATCH V2 13/15] sparc/perf: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:13:59 -0700 Message-Id: <20250514151401.2547932-14-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: David S. Miller Cc: sparclinux@vger.kernel.org --- arch/sparc/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/sparc/kernel/perf_event.c b/arch/sparc/kernel/perf_event.c index f02a283a8e8f..cae4d33002a5 100644 --- a/arch/sparc/kernel/perf_event.c +++ b/arch/sparc/kernel/perf_event.c @@ -1668,8 +1668,7 @@ static int __kprobes perf_event_nmi_handler(struct no= tifier_block *self, if (!sparc_perf_event_set_period(event, hwc, idx)) continue; =20 - if (perf_event_overflow(event, &data, regs)) - sparc_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 finish_clock =3D sched_clock(); --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54BF428A1CD; Wed, 14 May 2025 15:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235695; cv=none; b=JgL423EMPGrLiAtNBSfsiPAWvVQ8cZYqRIU0lxktoL1MMMkQLTUTDMUEy7zi/Zc3h8qjLt2YVHx+4A8ZE8pBNVdJnAPt58MeL4I+3MnDpY7H7cgONnJqZeKt+2zWP6T/NU/ZQJOGY3g05LCH5o1zgIGsXjj+tD9o+gd6jEQnHMw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235695; c=relaxed/simple; bh=ZWv03XD/Q1kgk/HFJzz+qCMhdC25MzBMQsMSIBLWzs0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VY+Ri9I6INunPrJVcLQ8wNEmcpzZANn8usxlEYk51XIVzf2QjmiXEHhDqGETVqNoqB749wysOGsH/J2iP6bJeFmRNgjXDj/v8x24xP1VnsxHrCzhZ7Su5Abr7MvVwIsmjMsTJXXhT3A5H+/wCbMXK8p4+5Oq9qJhEham1No88Gw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ixl1aWjY; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ixl1aWjY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235693; x=1778771693; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZWv03XD/Q1kgk/HFJzz+qCMhdC25MzBMQsMSIBLWzs0=; b=ixl1aWjYh9wCzgA6TI4NzHCZIK78ZANauQz/beLEV52ODNx8rnfBRndC bDfuCevJHYfYtRvHNQqI2eK8y5yxTMBbDI4XoAf3AdTEErVSBSC0Kb9uc 23V0dJMq3zDo+kuSbqg2RiwdOjqL9vcf6VzQ8C7O6bqNCibqLRljE0Tt/ EEQ92992UsOa4+lzMx3YuORgsFFJ6FdvrKv3MYcFd2DXvkHiOXXwFsQ8R f/TmJXvts822ILaXZVYoNheNx+2ItnNKaDSm+Niv4XqwxeoYWlRoxKkW8 xyaQrNZfJphnSfK/qwXXaqCxxcD2yNobmAdjL1EGBLygh7qVo2Gh7wWKA A==; X-CSE-ConnectionGUID: dZpSFbBASKWyCrRuLWS3aw== X-CSE-MsgGUID: R8I+6cTSSkyttApBR8kqRg== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072807" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072807" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:48 -0700 X-CSE-ConnectionGUID: awuxL/G3Q2eVgn4/8N2g5Q== X-CSE-MsgGUID: 3KgVMnuPQqyDjnFdQTxxBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939179" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:48 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Max Filippov Subject: [PATCH V2 14/15] xtensa/perf: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:14:00 -0700 Message-Id: <20250514151401.2547932-15-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Reviewed-by: Max Filippov Signed-off-by: Kan Liang Cc: Max Filippov --- Changes since V1: - Add Reviewed-by from Max arch/xtensa/kernel/perf_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/xtensa/kernel/perf_event.c b/arch/xtensa/kernel/perf_even= t.c index 183618090d05..223f1d452310 100644 --- a/arch/xtensa/kernel/perf_event.c +++ b/arch/xtensa/kernel/perf_event.c @@ -388,8 +388,7 @@ irqreturn_t xtensa_pmu_irq_handler(int irq, void *dev_i= d) struct pt_regs *regs =3D get_irq_regs(); =20 perf_sample_data_init(&data, 0, last_period); - if (perf_event_overflow(event, &data, regs)) - xtensa_pmu_stop(event, 0); + perf_event_overflow(event, &data, regs); } =20 rc =3D IRQ_HANDLED; --=20 2.38.1 From nobody Sat Feb 7 10:44:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5082628B4EF; Wed, 14 May 2025 15:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235696; cv=none; b=TZDvha3Mm9Z2JbP8lnZ6i98dy7ZT6Qlq8guoXX9AVQe4bYywmzdqUQ/Ala2ecLCHqdFfW2CTVKcCrWUCLn7JaWuLVXXPyXwxkarMdQo8DqBwuHW2s8EVIbcIVyNVPw7maeja16xsBpJnw0sQ7EMjS6rDHMZwHx4AdDd6gTM3EcM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747235696; c=relaxed/simple; bh=W83BuCBEGVgUrqk/CNpFhmFYGiaT4zNHiSxidabkeh4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HOt3JT1/EAZ4Fq1/0kLaq/LRVPt+L4d3BPyY5p3TMT/zHwM73THYiRi6fCx8tK5V3l0vVg9P+QCbc52cgsusdqJbmeHeM6LaRbYtMywz1e66XR7E8ekwlVd1/iDCtuv3R4NOajKMzI9tFIUM8foMB1Wwub3lAbQyBOi4nM2ecc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HfItV8za; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HfItV8za" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747235694; x=1778771694; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=W83BuCBEGVgUrqk/CNpFhmFYGiaT4zNHiSxidabkeh4=; b=HfItV8zaUDR2/Hsmt8TfopWtM632WmtUQekS+MbI+qLhCltntLSsp2SC JXxMeV1UsXmcuzUt/GtC+WjBLFcul6xeq+0xtNjMVZ1TEIQWiX5+Yrvlf v+vIYR1WtIcms+vuoL0xx4MXLpm6gMDU/QToQGGqOR0mdkU/C7leIjdnd Ht1wDwz8uie6S0K6dHKtrXu/d1Ywf2SMlyt0KuOI1qHqMsjBlqFXHoZhU y1wKaTKBjql9+oS8zNdv70sR2X7b+dp26mrEi57dVaZhZPX0RpNHNv7Zw /m0bYEnycqvOusW3qFHwvFlEcIU5LbcBjq1xPScCqweISvEYj8Uw+esAc w==; X-CSE-ConnectionGUID: tR8n6SjbR9GF+mfoivqczg== X-CSE-MsgGUID: 6bDVnvpPQyG6gPhhpTQlhw== X-IronPort-AV: E=McAfee;i="6700,10204,11433"; a="49072816" X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="49072816" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 08:14:48 -0700 X-CSE-ConnectionGUID: r2MKxGuURU68vDYrBO+sLQ== X-CSE-MsgGUID: B0QC86l3RLCRt+rPAsb38g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,288,1739865600"; d="scan'208";a="142939181" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmviesa005.fm.intel.com with ESMTP; 14 May 2025 08:14:48 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, Kan Liang , Thomas Bogendoerfer , linux-mips@vger.kernel.org Subject: [PATCH V2 15/15] mips/perf: Remove driver-specific throttle support Date: Wed, 14 May 2025 08:14:01 -0700 Message-Id: <20250514151401.2547932-16-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250514151401.2547932-1-kan.liang@linux.intel.com> References: <20250514151401.2547932-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The throttle support has been added in the generic code. Remove the driver-specific throttle support. Besides the throttle, perf_event_overflow may return true because of event_limit. It already does an inatomic event disable. The pmu->stop is not required either. Signed-off-by: Kan Liang Cc: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org --- arch/mips/kernel/perf_event_mipsxx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/mips/kernel/perf_event_mipsxx.c b/arch/mips/kernel/perf_e= vent_mipsxx.c index c4d6b09136b1..196a070349b0 100644 --- a/arch/mips/kernel/perf_event_mipsxx.c +++ b/arch/mips/kernel/perf_event_mipsxx.c @@ -791,8 +791,7 @@ static void handle_associated_event(struct cpu_hw_event= s *cpuc, if (!mipspmu_event_set_period(event, hwc, idx)) return; =20 - if (perf_event_overflow(event, data, regs)) - mipsxx_pmu_disable_event(idx); + perf_event_overflow(event, data, regs); } =20 =20 --=20 2.38.1